Re: [libvirt] [PATCH v2 3/3] conf: Allow users to define UUID for devices

On Tue, Oct 03, 2017 at 04:03:20PM +0200, Martin Kletzander wrote: > On Tue, Oct 03, 2017 at 02:53:46PM +0100, Daniel P. Berrange wrote: > > On Tue, Oct 03, 2017 at 02:11:44PM +0200, Martin Kletzander wrote: > > > On Tue, Oct 03, 2017 at 12:58:59PM +0200, Michal Privoznik wr

Re: [libvirt] [PATCH v2 3/3] conf: Allow users to define UUID for devices

On Tue, Oct 03, 2017 at 02:11:44PM +0200, Martin Kletzander wrote: > On Tue, Oct 03, 2017 at 12:58:59PM +0200, Michal Privoznik wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1434451 > > > > It comes handy for management application to be able to have a > > per-device label so that it can

Re: [libvirt] [PATCH] spec: Delay supported_platform check

On Tue, Oct 03, 2017 at 01:48:04PM +0200, Jiri Denemark wrote: > Building RPM should only be allowed on a supported platform, but > unpacking the source and applying all patches can be done anywhere. > > Signed-off-by: Jiri Denemark > --- > libvirt.spec.in | 9 + >

Re: [libvirt] [PATCH 1/3] hyperv: Fix hypervInitConnection error reporting

On Tue, Oct 03, 2017 at 11:04:56AM +0200, Ladi Prosek wrote: > "%s is not a Hyper-V server" is not a correct generalization of all possible > error conditions of hypervEnumAndPull. For example: > > $ virsh --connect hyperv://localhost/?transport=http > Enter username for localhost

Re: [libvirt] [libvirt-jenkins-ci PATCH 05/18] ansible: Add libvirt-cim project

On Tue, Oct 03, 2017 at 09:18:32AM +0200, Andrea Bolognani wrote: > On Mon, 2017-10-02 at 16:57 +0100, Daniel P. Berrange wrote: > > > +packages: > > > + - libcmpiutil-devel > > > + - libconfig-devel > > > + - libuuid-devel > > > + -

Re: [libvirt] [libvirt-jenkins-ci PATCH 03/18] ansible: Add libosinfo project

On Tue, Oct 03, 2017 at 09:07:15AM +0200, Andrea Bolognani wrote: > On Mon, 2017-10-02 at 17:04 +0100, Daniel P. Berrange wrote: > > > +- name: '{{ project }}: Run sanity checks' > > > + command: '{{ make }} -j{{ smp }} syntax-check' > > > + args: > > > +

Re: [libvirt] [libvirt-jenkins-ci PATCH 03/18] ansible: Add libosinfo project

On Mon, Oct 02, 2017 at 05:10:41PM +0200, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > ansible/host_vars/libvirt-centos-7/main.yml | 1 + > ansible/host_vars/libvirt-debian-8/main.yml | 1 + > ansible/host_vars/libvirt-debian-9/main.yml

Re: [libvirt] [libvirt-jenkins-ci PATCH 05/18] ansible: Add libvirt-cim project

On Mon, Oct 02, 2017 at 05:10:43PM +0200, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > ansible/host_vars/libvirt-centos-6/main.yml | 1 + > ansible/host_vars/libvirt-centos-7/main.yml | 1 + > ansible/host_vars/libvirt-fedora-25/main.yml

Re: [libvirt] [PATCH go-xml] qemu: extend serial console source

On Mon, Oct 02, 2017 at 11:34:18AM +, Jeroen Simonetti wrote: > October 2 2017 12:47 PM, "Daniel P. Berrange" <berra...@redhat.com> wrote: > >> This will change the type of `DomainSerial.Source` from > >> `*DomainChardevSource` to a new `*DomainSerialSo

Re: [libvirt] [PATCH go-xml] qemu: extend serial console source

On Mon, Oct 02, 2017 at 12:10:40PM +0200, Jeroen Simonetti wrote: > *Warning* this is a BWC breaking change! That's fine - we don't promise API compat for this module. > This will change the type of `DomainSerial.Source` from > `*DomainChardevSource` to a new `*DomainSerialSource`. > > This is

Re: [libvirt] [Qemu-devel] libvirt/QEMU/SEV interaction

On Sat, Sep 30, 2017 at 12:16:55AM +0300, Michael S. Tsirkin wrote: > On Fri, Sep 29, 2017 at 02:48:45PM -0500, Richard Relph wrote: > > On 9/29/17 2:34 PM, Michael S. Tsirkin wrote: > > > On Wed, Sep 27, 2017 at 02:06:10PM -0500, Richard Relph wrote: > > > > Whether the "BIOS" is a "static shim"

Re: [libvirt] [Qemu-devel] libvirt/QEMU/SEV interaction

On Fri, Sep 29, 2017 at 02:48:45PM -0500, Richard Relph wrote: > On 9/29/17 2:34 PM, Michael S. Tsirkin wrote: > > On Wed, Sep 27, 2017 at 02:06:10PM -0500, Richard Relph wrote: > > > Whether the "BIOS" is a "static shim" as Michael suggests, or a full BIOS, > > > or even a BIOS+kernel+initrd is

Re: [libvirt] [PATCH alt] conf: Allow user define their own alias

On Fri, Sep 29, 2017 at 03:56:53PM +0200, Michal Privoznik wrote: > On 09/29/2017 01:52 PM, Daniel P. Berrange wrote: > > On Fri, Sep 29, 2017 at 12:09:52PM +0100, Daniel P. Berrange wrote: > >> On Fri, Sep 29, 2017 at 01:04:34PM +0200, Michal Privoznik wrote: > >>>

Re: [libvirt] [PATCH alt] conf: Allow user define their own alias

On Fri, Sep 29, 2017 at 12:09:52PM +0100, Daniel P. Berrange wrote: > On Fri, Sep 29, 2017 at 01:04:34PM +0200, Michal Privoznik wrote: > > On 09/29/2017 10:49 AM, Daniel P. Berrange wrote: > > > On Fri, Sep 29, 2017 at 09:06:01AM +0200, Michal Privoznik wrote: > > >&g

Re: [libvirt] [PATCH alt] conf: Allow user define their own alias

On Fri, Sep 29, 2017 at 01:04:34PM +0200, Michal Privoznik wrote: > On 09/29/2017 10:49 AM, Daniel P. Berrange wrote: > > On Fri, Sep 29, 2017 at 09:06:01AM +0200, Michal Privoznik wrote: > >> https://bugzilla.redhat.com/show_bug.cgi?id=1434451 > >> > >> It co

Re: [libvirt] [PATCH python] Unify whitespace around *_ALLOW_THREADS macros

> wrapped with these macros are treated as a separate block. > --- > libvirt-override.c | 115 > - > 1 file changed, 87 insertions(+), 28 deletions(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> and pushed to git.

Re: [libvirt] [PATCH alt] conf: Allow user define their own alias

On Fri, Sep 29, 2017 at 09:06:01AM +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1434451 > > It comes handy for management application to be able to have a > per-device label so that it can uniquely identify devices it > cares about. The advantage of this approach

Re: [libvirt] gnulib tests in libvirt broken by newer glibc 2.26

On Thu, Sep 28, 2017 at 04:41:37PM -0700, Paul Eggert wrote: > That patch essentially negates the point of the test, which is that getopt > should be visible from unistd.h. I'd rather fix the problem than nuke the > test. > > Could you explain what the Gnulib problem is here? I can't really see

[libvirt] [PATCH] Fix vxhs test to have stable certificate dir

The test suite has hardcoded /etc/pki/qemu as the cert dir, but this only works if configure has --sysconfdir=/etc passed. We must set the vxhs cert dir to a stable path in the test suite. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Pushed as a build fix .../qemuxml2arg

Re: [libvirt] gnulib tests in libvirt broken by newer glibc 2.26

On Wed, Sep 27, 2017 at 11:36:20PM +0200, Christian Ehrhardt wrote: > Hi, > there seems to be an incompatibility to the last glibc due to [1]. > > Eventually this breaks gnulib unittests (and maybe more). [snip] We should have detected this a while ago sinc Fedora rawhide has 2.26, in fact it

Re: [libvirt] [RFC] docs: Discourage usage of cache mode=passthrough

On Thu, Sep 21, 2017 at 01:14:04PM -0400, Laine Stump wrote: > On 09/19/2017 03:37 PM, Eduardo Habkost wrote: > > Cache mode=passthrough can result in a broken cache topology if > > the domain topology is not exactly the same as the host topology. > > Warn about that in the documentation. > > > >

Re: [libvirt] [PATCH v9 4/4] qemu: Add TLS support for Veritas HyperScale (VxHS)

On Wed, Sep 27, 2017 at 05:08:51PM +0200, Peter Krempa wrote: > On Wed, Sep 27, 2017 at 11:05:01 -0400, John Ferlan wrote: > > > > > > On 09/27/2017 10:25 AM, Peter Krempa wrote: > > > On Tue, Sep 19, 2017 at 21:32:46 -0400, John Ferlan wrote: > > >> From: Ashish Mittal

Re: [libvirt] [PATCH python] Release the GIL during virDomainGetMemoryStats

PyvirDomain_Get(pyobj_domain); > > +LIBVIRT_BEGIN_ALLOW_THREADS; > nr_stats = virDomainMemoryStats(domain, stats, > VIR_DOMAIN_MEMORY_STAT_NR, 0); > +LIBVIRT_END_ALLOW_THREADS; > + > if (nr_stats == -1) > return VIR

Re: [libvirt] [PATCH go-xml] Add qemu udp unicast tunneling support

tions(+), 8 deletions(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Will push to git - thanks for your contribution. Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange

Re: [libvirt] [PATCH go-xml] 1, add memoryBacking for domain. 2, add hugepages, nosharepages, locked, source, access and allocation for memoryBacking. 3, add test case for memoryBacking.

MemoryAllocation: { > + Mode: "immediate|ondemand", > + }, In these examples, you should pick either 'file' or 'anonymous', not include them both. Likewise for the access & allocation data. I

Re: [libvirt] [PATCH python] Fix comparisons between signed & unsigned integers

On Tue, Sep 26, 2017 at 01:36:13PM +0200, Martin Kletzander wrote: > On Tue, Sep 26, 2017 at 11:16:05AM +0100, Daniel P. Berrange wrote: > > When python3 builds C modules, it adds the -Wsign-compare flag to GCC. > > This creates lots of warnings where we compare a 'size_t

Re: [libvirt] [PATCH 4/4] qemu: hot-unplug of watchdog

On Tue, Sep 26, 2017 at 11:38:26AM +0200, Michal Privoznik wrote: > On 09/12/2017 04:29 PM, John Ferlan wrote: > > > > > > On 09/05/2017 07:45 AM, Michal Privoznik wrote: > >> https://bugzilla.redhat.com/show_bug.cgi?id=1447169 > >> > >> Signed-off-by: Michal Privoznik > >>

[libvirt] [PATCH python] Fix comparisons between signed & unsigned integers

When python3 builds C modules, it adds the -Wsign-compare flag to GCC. This creates lots of warnings where we compare a 'size_t' value against an 'int' value due to signed/unsigned difference. Change all the size_t types to ssize_t to address this. Signed-off-by: Daniel P. Berrange <be

Re: [libvirt] [PATCH v2 0/6] libvirt-python/libvirtaio patches for 3.8.0

On Tue, Sep 26, 2017 at 12:45:16AM +0200, Wojtek Porczyk wrote: > On Mon, Sep 25, 2017 at 12:14:24PM +0100, Daniel P. Berrange wrote: > > On Fri, Sep 22, 2017 at 05:54:04PM +0200, Wojtek Porczyk wrote: > > > Hi libvirt-list, > > > > > > I'd like to submit a s

Re: [libvirt] [PATCH v2 6/6] libvirtaio: add .drain() coroutine

On Tue, Sep 26, 2017 at 12:47:00AM +0200, Wojtek Porczyk wrote: > On Mon, Sep 25, 2017 at 02:53:01PM +0100, Daniel P. Berrange wrote: > > On Thu, Sep 14, 2017 at 02:41:12AM +0200, Wojtek Porczyk wrote: > > > The intended use is to ensure that the implementation is empty, whic

[libvirt] [PATCH python] Avoid implicit treatment of an arithmetic result as a boolean

p; (size * count)) { ~~^~~~ Add an explicit comparison '!= 0' to keep it happy, since its suggestion to use '&&' is nonsense. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt-utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-u

Re: [libvirt] [PATCH v2 1/6] libvirtaio: add more debug logging

On Tue, Sep 26, 2017 at 12:46:02AM +0200, Wojtek Porczyk wrote: > On Mon, Sep 25, 2017 at 02:43:56PM +0100, Daniel P. Berrange wrote: > > On Thu, Aug 24, 2017 at 09:22:49PM +0200, Wojtek Porczyk wrote: > > > This logging is helpful for tracing problems with unclosed connections

Re: [libvirt] [PATCH v2 6/6] libvirtaio: add .drain() coroutine

On Thu, Sep 14, 2017 at 02:41:12AM +0200, Wojtek Porczyk wrote: > The intended use is to ensure that the implementation is empty, which is > one way to ensure that all connections were properly closed and file > descriptors reclaimed. > > Signed-off-by: Wojtek Porczyk

Re: [libvirt] [PATCH v2 2/6] libvirtaio: cache the list of callbacks when calling

''' > -for callback in self.callbacks.values(): > +for callback in list(self.callbacks.values()): > if callback.event is not None and callback.event & event: > callback.cb(callback.iden, self.fd, event, callback.opaque) Reviewed-by: Daniel P. Berrange <berra...@

Re: [libvirt] [PATCH v2 1/6] libvirtaio: add more debug logging

On Thu, Aug 24, 2017 at 09:22:49PM +0200, Wojtek Porczyk wrote: > This logging is helpful for tracing problems with unclosed connections > and leaking file descriptors. > > Signed-off-by: Wojtek Porczyk > --- > libvirtaio.py | 33 + >

Re: [libvirt] [PATCH v2 3/6] libvirtaio: do not double-add callbacks

.., opaque=...) = %d', > timeout, callback.iden) > self.callbacks[callback.iden] = callback Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: h

Re: [libvirt] [PATCH] Print hex values with '0x' prefix and octal with '0' in debug messages

On Mon, Sep 25, 2017 at 02:12:33PM +0200, Pino Toscano wrote: > On Monday, 25 September 2017 12:45:51 CEST Daniel P. Berrange wrote: > > Seeing a log message saying 'flags=93' is ambiguous & confusing unless > > you happen to know that libvirt always prints flags as hex. C

Re: [libvirt] [PATCH v2 0/6] libvirt-python/libvirtaio patches for 3.8.0

On Fri, Sep 22, 2017 at 05:54:04PM +0200, Wojtek Porczyk wrote: > Hi libvirt-list, > > I'd like to submit a second iteration of libvirtaio series for 3.8.0. > There are some improvements to have better control over closing > connections, which are important in test suites which repeatedly open >

Re: [libvirt] [PATCH] Print hex values with '0x' prefix and octal with '0' in debug messages

On Mon, Sep 25, 2017 at 01:27:24PM +0200, Ján Tomko wrote: > On Mon, Sep 25, 2017 at 11:45:51AM +0100, Daniel P. Berrange wrote: > > Seeing a log message saying 'flags=93' is ambiguous & confusing unless > > you happen to know that libvirt always prints flags as hex. Change our

Re: [libvirt] [PATCH 2/2] qemu: block: Use correct alias when extracting disk node names

On Mon, Sep 25, 2017 at 11:53:07AM +0200, Peter Krempa wrote: > For some arcane reason we don't use the alias from disk->info.alias > directly but prepend drive in front of it. 'disk->info.alias' is used as the ID for the frontend device (eg virtio-blk) device. IDs must be globally unique in

Re: [libvirt] [PATCH go-xml] add VCPUs support in Domain

On Mon, Sep 25, 2017 at 04:21:14PM +0800, zhenwei.pi wrote: > Signed-off-by: zhenwei.pi <zhenwei...@youruncloud.com> > --- > domain.go | 12 > domain_test.go | 24 > 2 files changed, 36 insertions(+) Reviewed-by: Daniel P. Berrange

Re: [libvirt] [PATCH libvirt-cim 1/2] maint: Rename autoconfiscate.sh to autogen.sh

On Fri, Sep 22, 2017 at 07:27:33PM +0200, Andrea Bolognani wrote: > On Fri, 2017-09-22 at 12:58 -0400, John Ferlan wrote: > > By killing it - I was thinking more along the lines of removing it from > > our CI infrastructure and just letting the repo sit silently without > > updates, but that ship

Re: [libvirt] [PATCH libvirt-cim 1/2] maint: Rename autoconfiscate.sh to autogen.sh

On Fri, Sep 22, 2017 at 10:08:44AM -0400, John Ferlan wrote: > > > On 09/22/2017 09:28 AM, Andrea Bolognani wrote: > > While the "autoconfiscate" name is very clever and cute, the > > de-facto standard name for this kind of script is "autogen", and > > deviating from it means having to

Re: [libvirt] [PATCH v1 4/7] qemu: Allow regeneration of aliases

On Fri, Sep 22, 2017 at 10:25:46AM +0200, Peter Krempa wrote: > On Fri, Sep 22, 2017 at 10:18:02 +0200, Michal Privoznik wrote: > > On 09/21/2017 07:18 PM, Daniel P. Berrange wrote: > > > On Thu, Sep 21, 2017 at 06:05:19PM +0200, Peter Krempa wrote: > > >> On Thu,

Re: [libvirt] [PATCH v1 4/7] qemu: Allow regeneration of aliases

On Thu, Sep 21, 2017 at 06:05:19PM +0200, Peter Krempa wrote: > On Thu, Sep 21, 2017 at 16:47:08 +0200, Michal Privoznik wrote: > > In the near future the qemuAssignDeviceAliases() function is > > going to be called multiple times: once at the domain define > > time, then in domain prepare phase.

[libvirt] [PATCH] Fix commandhelper build on win32

For win32 we need EXIT_AM_SKIP which is in testutils.h. We must define NO_LIBVIRT to prevent replacement of fprintf with virFilePrintf as we can't link to libvirt_util.la Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Pushed as a build fix tests/commandhelper.c | 2 ++

Re: [libvirt] [PATCH libvirt-glib 0/5] Portability fixes

pts: Fix sha-bang lines For all 5 patches: Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entang

[libvirt] [PATCH] iohelper: avoid calling read() with misaligned buffers for O_DIRECT

, but this does not appear to matter when at end-of-file. Tested-by: Nikolay Shirokovskiy <nshirokovs...@virtuozzo.com> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/util/iohelper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/iohelper.

Re: [libvirt] [PATCH v2] iohelper: fix reading with O_DIRECT

On Wed, Sep 20, 2017 at 06:00:59PM +0300, Nikolay Shirokovskiy wrote: > > > On 20.09.2017 17:48, Daniel P. Berrange wrote: > > > > IOW can simplify your patch to just this I believe:> > > diff --git a/src/util/iohelper.c b/src/util/iohelper.c > > index fe15a

Re: [libvirt] [PATCH v2] iohelper: fix reading with O_DIRECT

On Wed, Sep 20, 2017 at 04:45:35PM +0300, Nikolay Shirokovskiy wrote: > > > On 20.09.2017 16:41, Daniel P. Berrange wrote: > > On Wed, Sep 20, 2017 at 04:35:58PM +0300, Nikolay Shirokovskiy wrote: > >> > >> > >> On 20.09.2017 16:30, Daniel P. Berrange

Re: [libvirt] [PATCH v2] iohelper: fix reading with O_DIRECT

On Wed, Sep 20, 2017 at 02:58:55PM +0300, Nikolay Shirokovskiy wrote: > saferead is not suitable for direct reads. If file size is not multiple > of align size then we get EINVAL on the read(2) that is supposed to > return 0 because read buffer will not be aligned at this point. > > Let's not

Re: [libvirt] [PATCH v2] iohelper: fix reading with O_DIRECT

On Wed, Sep 20, 2017 at 04:35:58PM +0300, Nikolay Shirokovskiy wrote: > > > On 20.09.2017 16:30, Daniel P. Berrange wrote: > > On Wed, Sep 20, 2017 at 02:58:55PM +0300, Nikolay Shirokovskiy wrote: > >> saferead is not suitable for direct reads. If file size is not mul

Re: [libvirt] [PATCH v2] iohelper: fix reading with O_DIRECT

On Wed, Sep 20, 2017 at 02:58:55PM +0300, Nikolay Shirokovskiy wrote: > saferead is not suitable for direct reads. If file size is not multiple > of align size then we get EINVAL on the read(2) that is supposed to > return 0 because read buffer will not be aligned at this point. > > Let's not

Re: [libvirt] [PATCH] Stop linking tests/commandhelper to libvirt code

On Wed, Sep 20, 2017 at 12:08:59PM +0100, Daniel P. Berrange wrote: > The commandhelper binary is a helper for commandtest that > validates what file handles were inherited. For this to > work reliably we must not have any libraries that leak > file descriptors into commandhelper. U

[libvirt] [PATCH] Stop linking tests/commandhelper to libvirt code

t link to it. With the introduction of the util/vircrypto.c file that assumption is no longer valid. We must not link to libvirt_util.la at all - only gnulib and libc can (hopefully) be relied on not to open random file descriptors in constructors. Signed-off-by: Daniel P. Berrange <berra...@r

Re: [libvirt] [PATCH] Link libvirt_util.la with gnutls

On Wed, Sep 20, 2017 at 11:35:14AM +0200, Martin Kletzander wrote: > On Wed, Sep 20, 2017 at 09:41:24AM +0100, Daniel P. Berrange wrote: > > The util/vircrypto.c file uses gnutls, so we must directly link > > libvirt_util.la with gnutls to avoid errors on OS which do not >

[libvirt] [PATCH] Link libvirt_util.la with gnutls

/libvirt_util.a(libvirt_util_la-vircrypto.o): undefined reference to symbol 'gnutls_strerror@@GNUTLS_1_4' //usr/lib/x86_64-linux-gnu/libgnutls.so.26: error adding symbols: DSO missing from command line Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Pushed as a build breaker fix

Re: [libvirt] [PATCH] Revert "travis: Limit git depth to 5 commits"

> 1 file changed, 1 deletion(-) > > diff --git a/.travis.yml b/.travis.yml > index b3e73bcf7..480419dfd 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -75,7 +75,6 @@ addons: >- zfs-fuse > > git: > - depth: 5 >submodules: true > >

[libvirt] [PATCH python v2] Add travis build config

as the oldest for now. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- .travis.yml | 55 +++ requirements-test.txt | 2 ++ setup.py | 15 +++--- 3 files changed, 65 insertions(+), 7 deletions(-) create mode

Re: [libvirt] [PATCH python] Add travis build config

On Tue, Sep 19, 2017 at 03:06:58PM +0200, Martin Kletzander wrote: > On Tue, Sep 19, 2017 at 12:56:55PM +0100, Daniel P. Berrange wrote: > > Enable builds on several python versions, and against several versions > > of libvirt. Ideally we would build all the way back t

[libvirt] [PATCH python] Add travis build config

as the oldest for now. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- .travis.yml | 55 +++ setup.py| 13 +++-- 2 files changed, 62 insertions(+), 6 deletions(-) create mode 100644 .travis.yml diff --git a/.travis

Re: [libvirt] [PATCH go-xml] Add support for domain hostdev and test code

On Fri, Sep 15, 2017 at 02:12:44PM +0800, zhenwei.pi wrote: > Signed-off-by: zhenwei.pi > --- > domain.go | 36 > domain_test.go | 44 > 2 files changed, 80 insertions(+) > > diff

Re: [libvirt] [PATCH python] Skip sparseRecvAll / sparseSendAll in sanity test

On Mon, Sep 18, 2017 at 11:47:24AM +0200, Michal Privoznik wrote: > On 09/14/2017 02:50 PM, Daniel P. Berrange wrote: > > The sanity test check aims to ensure that every function listed in > > the Python code maps to a corresponding C function. The Sparse > > send/recv metho

Re: [libvirt] [Qemu-devel] libvirt/QEMU/SEV interaction

On Mon, Sep 18, 2017 at 11:43:57AM +0200, Erik Skultety wrote: > [...] > > > > > > > > c) what existing communicate interface can be used between libvirt > > > and qemu > > > > to get the measurement ? can we add a new qemu monitor command > > > > 'get_sev_measurement' to get the

Re: [libvirt] RFC: libvirt support for QEMU live patching

On Mon, Sep 18, 2017 at 09:37:14AM +0200, Martin Kletzander wrote: > On Fri, Sep 15, 2017 at 09:18:18AM +0100, Daniel P. Berrange wrote: > > On Fri, Sep 15, 2017 at 01:27:31PM +0530, Madhu Pavan wrote: > > > Hi, > > > QEMU live patching should be just a matt

Re: [libvirt] [PATCH] spec: Use %license when available

On Fri, Sep 15, 2017 at 09:09:05AM +0100, Daniel P. Berrange wrote: > On Thu, Sep 14, 2017 at 05:43:37PM -0400, Cole Robinson wrote: > > This is required by the fedora packaging guidelines: > > > > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines > > >

Re: [libvirt] [libvirt-sandbox PATCH 1/2] Drop library/ from image path

ndbox/image/sources/docker.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-ht

Re: [libvirt] [libvirt-sandbox PATCH 2/2] Sanitize domain name

bvirt-sandbox/image/cli.py | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-

Re: [libvirt] RFC: libvirt support for QEMU live patching

On Fri, Sep 15, 2017 at 01:27:31PM +0530, Madhu Pavan wrote: > Hi, > QEMU live patching should be just a matter of updating the QEMU RPM package > and then live migrating the VMs to another QEMU instance on the same host > (which would point to the just installed new QEMU executable). > I think it

Re: [libvirt] [PATCH] spec: Use %license when available

inition > > https://bugzilla.redhat.com/show_bug.cgi?id=1483293 > > Reported-by: Ville Skyttä <ville.sky...@iki.fi> > Signed-off-by: Cole Robinson <crobi...@redhat.com> > --- > libvirt.spec.in | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Dani

Re: [libvirt] [PATCH] spec: Own %{_libdir}/libvirt{, /connection-driver} dirs

ff-by: Cole Robinson <crobi...@redhat.com> > --- > libvirt.spec.in | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://lib

Re: [libvirt] [PATCH 7/8] travis: Install more build dependencies

On Thu, Sep 14, 2017 at 04:09:37PM +0200, Andrea Bolognani wrote: > On Thu, 2017-09-14 at 14:50 +0100, Daniel P. Berrange wrote: > > > @@ -5,37 +5,60 @@ addons: > > >apt: > > > # Please keep this list sorted alphabetically > > > packages: >

Re: [libvirt] [PATCH 4/8] travis: Split building command

On Thu, Sep 14, 2017 at 04:45:30PM +0200, Andrea Bolognani wrote: > On Thu, 2017-09-14 at 14:48 +0100, Daniel P. Berrange wrote: > > > script: > > > - - make -j3 && make -j3 syntax-check && make -j3 check > > > + - make -j3 > > &g

Re: [libvirt] [PATCH 5/8] travis: Don't have a separate script definition for macOS

so does syntax-check, so skip for now > -# one day we must fix it though > -- make -j3 > > after_failure: >- echo > '' > -- Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel --

Re: [libvirt] [PATCH 6/8] travis: Improve test matrix

rusty > - compiler: clang >dist: precise > - compiler: clang >dist: trusty > -- compiler: gcc > - dist: trusty > - compiler: clang >os: osx Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |:

Re: [libvirt] [PATCH 4/8] travis: Split building command

eck succeeeds, you now have to search through the middle of the logfile to find the failure, instead of just jumping straight to the end. So I'm on the fence about this patch - I'd have a slight preference for existing behaviour of failing fast to keep errors at the end of the log None the less Reviewe

Re: [libvirt] [PATCH 7/8] travis: Install more build dependencies

On Thu, Sep 14, 2017 at 03:09:07PM +0200, Andrea Bolognani wrote: > Since configure automatically picks up as many optional dependencies > as possible, installing more packages allows us to improve our test > coverage. > > Signed-off-by: Andrea Bolognani > --- > .travis.yml

Re: [libvirt] [PATCH 3/8] travis: Don't abort build due to -Wvariadic-macros

- PATH="/usr/local/opt/gettext/bin:/usr/local/opt/rpcgen/bin:$PATH" > +# The hyperv driver fails to build with clang on precise due to this > +# error being raised in one of openwsman header files > +- CFLAGS="-Wno-error=variadic-macros" > - VIR_TEST_DEBUG=1 > &g

Re: [libvirt] [PATCH 2/8] travis: Move variables to 'env' section

_TEST_DEBUG=1 make -j3 && make -j3 syntax-check && make -j3 check > + - make -j3 && make -j3 syntax-check && make -j3 check > > # Environments here are run in addition to the main environment defined above > matrix: Reviewed-by: Daniel P. Berrange &l

Re: [libvirt] [PATCH 1/8] travis: Limit git depth to 5 commits

VAc0MkhQ8GgXGSA61fR6aXYonroI/WnBVItwDmUnnMfSziZXxk09GLl4=" > > git: > + depth: 5 > submodules: true > > before_install: Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dbe

Re: [libvirt] [libvirt-python][PATCH] maint: Require libvirt-3.4.0 at least

On Thu, Sep 14, 2017 at 03:05:15PM +0200, Michal Privoznik wrote: > On 09/14/2017 02:42 PM, Daniel P. Berrange wrote: > > On Thu, Sep 14, 2017 at 01:41:08PM +0200, Michal Privoznik wrote: > >> Currently, we require 0.9.11. However, some APIs are missing > >> there

[libvirt] [PATCH python] Skip sparseRecvAll / sparseSendAll in sanity test

The sanity test check aims to ensure that every function listed in the Python code maps to a corresponding C function. The Sparse send/recv methods are special though - we're never calling the corresponding C APIs, instead we have a pure python impl. Signed-off-by: Daniel P. Berrange <be

Re: [libvirt] [libvirt-python][PATCH] maint: Require libvirt-3.4.0 at least

On Thu, Sep 14, 2017 at 01:41:08PM +0200, Michal Privoznik wrote: > Currently, we require 0.9.11. However, some APIs are missing > there and thus sanity check fails: > > DEBUG: /usr/bin/python sanitytest.py build/lib.linux-s390x-2.7 > /usr/share/libvirt/api/libvirt-api.xml > DEBUG: FAIL

Re: [libvirt] [PATCH go-xml 0/2] DomainAddress parsing fix

On Wed, Sep 13, 2017 at 01:57:44PM +0100, Dean Smith wrote: > *** BLURB HERE *** > I have taken Anton Kryukovs fix from #13 on github and am submitting > along with addition of 1.8 and 1.9 as travis go version targets > > Example of failing running on 1.9, which passes on 1.7 can be found > at >

Re: [libvirt] [PATCH 2/2] qemu: Use secret objects to pass iSCSI passwords

On Wed, Sep 13, 2017 at 03:24:42PM +0200, Peter Krempa wrote: > On Wed, Sep 13, 2017 at 09:05:43 -0400, John Ferlan wrote: > > > > I was thinking more about virstoragefile.c and virstoragetest.c. It's > > easy enough to fetch the user/password-secret in > > virStorageSourceParseBackingJSONiSCSI:

Re: [libvirt] Yet another RFC for CAT

On Tue, Sep 12, 2017 at 11:33:53AM +0200, Martin Kletzander wrote: > On Thu, Sep 07, 2017 at 11:02:21AM +0800, 乔立勇(Eli Qiao) wrote: > > > I'm concerned about the idea of not checking 'from' for collisions, > > > if there's allowed a mix of guests with & within 'from'. > > > > eg consider > > > >

Re: [libvirt] New QEMU daemon for persistent reservations

On Mon, Sep 11, 2017 at 05:47:28PM +0200, Paolo Bonzini wrote: > On 11/09/2017 17:33, Daniel P. Berrange wrote: > > On Mon, Sep 11, 2017 at 05:27:20PM +0200, Paolo Bonzini wrote: > >> On 11/09/2017 17:23, Daniel P. Berrange wrote: > >>>> On the other h

Re: [libvirt] New QEMU daemon for persistent reservations

On Mon, Sep 11, 2017 at 05:20:10PM +0200, Paolo Bonzini wrote: > On 11/09/2017 16:32, Daniel P. Berrange wrote: > >> This is already handled via SCM_RIGHTS and is part of the design of the > >> helper daemon. QEMU cannot even open mpath devices which are not > >&g

Re: [libvirt] New QEMU daemon for persistent reservations

On Mon, Sep 11, 2017 at 05:27:20PM +0200, Paolo Bonzini wrote: > On 11/09/2017 17:23, Daniel P. Berrange wrote: > >> On the other hand, the daemon has CAP_SYS_RAWIO and CAP_SYS_ADMIN, so if > >> you get memory corruption all bets are probably off anyway. > > That's

Re: [libvirt] New QEMU daemon for persistent reservations

On Mon, Sep 11, 2017 at 04:23:27PM +0200, Paolo Bonzini wrote: > On 11/09/2017 14:09, Daniel P. Berrange wrote: > > On Mon, Sep 11, 2017 at 01:44:59PM +0200, Paolo Bonzini wrote: > >> On 11/09/2017 12:46, Daniel P. Berrange wrote: > >>>> So the helper is a bit

Re: [libvirt] New QEMU daemon for persistent reservations

On Mon, Sep 11, 2017 at 01:44:59PM +0200, Paolo Bonzini wrote: > On 11/09/2017 12:46, Daniel P. Berrange wrote: > >> So the helper is a bit different from QEMU with respect to both SELinux > >> MCS labeling and the devices cgroup. Access limitation comes from only > >

Re: [libvirt] New QEMU daemon for persistent reservations

On Sun, Sep 10, 2017 at 11:52:24AM +0200, Paolo Bonzini wrote: > On 29/08/2017 14:41, Daniel P. Berrange wrote: > > On Tue, Aug 22, 2017 at 06:27:40PM +0200, Paolo Bonzini wrote: > >> Hi all, > >> > >> I am adding a new daemon to QEMU, that QEMU can connect

Re: [libvirt] [PATCH] virsh: help: Drop 'id' from possible values for argument

On Mon, Sep 11, 2017 at 10:01:45AM +0200, Erik Skultety wrote: > At the moment, we can only rename inactive domains. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1490164 > > Signed-off-by: Erik Skultety > --- > > Theoretically, we could also remove this check

Re: [libvirt] [Qemu-devel] libvirt/QEMU/SEV interaction

On Fri, Sep 08, 2017 at 10:48:10AM -0500, Brijesh Singh wrote: > > So I could see a flow like the following: > > > The flow looks good > > > > > > >1. mgmt tool calls virConnectGetCapabilities. This returns an XML > > document that includes the following > > > > > >

Re: [libvirt] [Qemu-devel] libvirt/QEMU/SEV interaction

On Fri, Sep 08, 2017 at 01:45:06PM +, Relph, Richard wrote: > A few answers in line… > > On 9/8/17, 8:16 AM, "Daniel P. Berrange" <berra...@redhat.com> wrote: > > On Fri, Sep 08, 2017 at 06:57:30AM -0500, Brijesh Singh wrote: > > Hi All, >

Re: [libvirt] [Qemu-devel] libvirt/QEMU/SEV interaction

On Fri, Sep 08, 2017 at 06:57:30AM -0500, Brijesh Singh wrote: > Hi All, > > (sorry for the long message) > > CPUs from AMD EPYC family supports Secure Encrypted Virtualization (SEV) > feature - the feature allows running encrypted VMs. To enable the feature, > I have been submitting patches to

Re: [libvirt] [PATCH v3] [libvirt-jenkins-ci] Build on supported Fedora releases (25-26)

On Thu, Sep 07, 2017 at 01:46:03PM +0200, Andrea Bolognani wrote: > On Thu, 2017-09-07 at 11:58 +0100, Daniel P. Berrange wrote: > > > Fedora 26 has been released in the meantime, which means we can > > > get rid of two builders instead of one! Someone will have to >

Re: [libvirt] [PATCH v3] [libvirt-jenkins-ci] Build on supported Fedora releases (25-26)

On Thu, Sep 07, 2017 at 12:48:22PM +0200, Andrea Bolognani wrote: > Fedora 23 has been out of support for quite a while now, with > Fedora 24 recently joining it with the release of Fedora 26 > which, on the other hand, is fully supported and a prime candidate > for building libvirt. > >

Re: [libvirt] [PATCH 2/2] travis: Install gettext

On Thu, Sep 07, 2017 at 11:29:15AM +0200, Andrea Bolognani wrote: > On Wed, 2017-09-06 at 14:25 +0100, Daniel P. Berrange wrote: > > On Wed, Sep 06, 2017 at 03:13:30PM +0200, Andrea Bolognani wrote: > > > msgmerge(1) and friends are required to build libvirt, so the > >

Re: [libvirt] [PATCH 2/2] travis: Install gettext

On Wed, Sep 06, 2017 at 03:13:30PM +0200, Andrea Bolognani wrote: > msgmerge(1) and friends are required to build libvirt, so the > corresponding package should be installed in the Travis worker. It is only used if you regenerate .po files. 99% of the time developers or apps bulding libvirt won't

<    1   2   3   4   5   6   7   8   9   10   >