Re: [libvirt] Redefinition of struct in6_addr in netinet/in.h and linux/in6.h

2013-01-16 Thread David Miller
From: Mike Frysinger vap...@gentoo.org Date: Wed, 16 Jan 2013 14:22:16 -0500 On Wednesday 16 January 2013 13:59:59 David Miller wrote: This has been done for decades, wake up. and it's been broken for just as long. no need to be a dick. By being ignorant and having such a simplistic view

Re: [libvirt] Redefinition of struct in6_addr in netinet/in.h and linux/in6.h

2013-01-16 Thread David Miller
From: Mike Frysinger vap...@gentoo.org Date: Wed, 16 Jan 2013 12:04:56 -0500 certainly true, but the current expectation is that you don't mix your ABIs. if you're programming with the C library API, then use the C library headers. if you're banging directly on the kernel, then use the

Re: [libvirt] Redefinition of struct in6_addr in netinet/in.h and linux/in6.h

2013-01-16 Thread David Miller
From: Mike Frysinger vap...@gentoo.org Date: Wed, 16 Jan 2013 12:28:39 -0500 if you're not calling the kernel directly, why are you including the kernel headers ? what is the problem people are actually trying to address here (and no, i want to include both headers is not the answer) ?

Re: [libvirt] Redefinition of struct in6_addr in netinet/in.h and linux/in6.h

2013-01-16 Thread David Miller
From: Ben Hutchings bhutchi...@solarflare.com Date: Wed, 16 Jan 2013 15:47:12 + On Wed, 2013-01-16 at 23:21 +0900, YOSHIFUJI Hideaki wrote: Cong Wang wrote: (Cc'ing some glibc developers...) Hello, In glibc source file inet/netinet/in.h and kernel source file

Re: [libvirt] Redefinition of struct in6_addr in netinet/in.h and linux/in6.h

2013-01-16 Thread David Miller
From: Carlos O'Donell car...@systemhalted.org Date: Wed, 16 Jan 2013 20:58:47 -0500 So I just went down the rabbit hole, and the further I get the closer I get to having two exact copies of the same definitions in both glibc and the kernel and using whichever one was included first. Is

Re: [libvirt] Redefinition of struct in6_addr in netinet/in.h and linux/in6.h

2013-01-16 Thread David Miller
From: Carlos O'Donell car...@systemhalted.org Date: Wed, 16 Jan 2013 21:15:03 -0500 +/* If a glibc-based userspace has already included in.h, then we will not + * define in6_addr (nor the defines), sockaddr_in6, or ipv6_mreq. The + * ABI used by the kernel and by glibc match exactly. Neither

Re: [libvirt] Redefinition of struct in6_addr in netinet/in.h and linux/in6.h

2013-01-17 Thread David Miller
From: Mike Frysinger vap...@gentoo.org Date: Thu, 17 Jan 2013 23:14:31 -0500 the kernel already exports many types with a __kernel_ prefix. i changed the kernel headers in Gentoo for a few releases (2.6.28 - 2.6.34) to do the same thing to pretty much all the networking headers. a few