error;
+
h = sep;
}
}
--
1.8.3.1
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
ACK
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
ACK
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
/libvir-list
ACK. Just a question above if a line is necessary.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
message.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
= virURIParse(disk-src)))
+return -1;
+return qemuParseDriveURIString(disk, uri, nbd);
}
if (VIR_ALLOC(h) 0)
--
1.8.3.1
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
ACK
--
Doug Goldstein
--
libvir-list
On Mon, Sep 23, 2013 at 5:28 AM, Daniel P. Berrange berra...@redhat.com wrote:
On Fri, Sep 20, 2013 at 03:06:51PM -0500, Doug Goldstein wrote:
Add support for VMware Fusion in the existing VMware driver. Connect
via the URI vmwarefusion:///session
---
docs/drvvmware.html.in | 15
Currently the VMware version check code only supports two types of
VMware backends, Workstation and Player. But in the near future we will
have an additional one so we need to support more. Additionally, we
discover and cache the path to the vmrun binary so we should use that
path when using the
Add support for VMware Fusion in the existing VMware driver. Connect
via the URI vmwarefusion:///session
---
change from v1:
* ifdef PATH for Apple machines only
---
docs/drvvmware.html.in | 15 +++
src/vmware/vmware_conf.c | 8 +++-
src/vmware/vmware_conf.h | 1 +
Currently the VMware version check code only supports two types of
VMware backends, Workstation and Player. But in the near future we will
have an additional one so we need to support more. Additionally, we
discover and cache the path to the vmrun binary so we should use that
path when using the
Add support for VMware Fusion in the existing VMware driver. Connect
via the URI vmwarefusion:///session
---
docs/drvvmware.html.in | 15 +++
src/vmware/vmware_conf.c | 8 +++-
src/vmware/vmware_conf.h | 1 +
src/vmware/vmware_driver.c | 3 +++
4 files changed, 22
Rather than looking up the path to vmrun each time we call it, look it
up once and save it. This sets up the ability for us to detect where the
path is on Mac OS X and not have to look it up each time we execute it.
---
src/vmware/vmware_conf.c | 3 ++-
src/vmware/vmware_conf.h | 2 +-
@@ -0,0 +1 @@
+VMware Workstation 7.0.0 build-203739 Release
diff --git a/tests/vmwarevertest.c b/tests/vmwarevertest.c
new file mode 100644
index 000..f5ccb06
--- /dev/null
+++ b/tests/vmwarevertest.c
@@ -0,0 +1,105 @@
+/*
+ * Copyright (c) 2013. Doug Goldstein car...@cardoe.com
(www.diateam.net)
+ * Copyright (c) 2013, Doug Goldstein (car...@cardoe.com)
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
@@ -30,8 +31,14 @@
# define VIR_FROM_THIS VIR_FROM_VMWARE
# define PROGRAM_SENTINEL ((char
format for the version so the code will need to change
this allows us to add tests.
I personally don't own a copy of VMware Workstation or VMware Fusion,
so if anyone does please send me (or submit patches) of additional
version numbers so that we can improve our test coverage.
Doug Goldstein (3
;
I'm sure the fix isn't this trivial but i can finish it up and submit
an official patch (through git) if this is close.
Dusty
Not yet sure of the correctness / completeness but I would go ahead
and submit a git commit and we can go from there.
--
Doug Goldstein
--
libvir-list mailing list
. For that
matter if you've got access to a copy of VMware Fusion as well that'd
be awesome so that I can test the changes I'm making instead of
relying on others to test. *hint any VMware people following the list*
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com
/mailman/listinfo/libvir-list
ACK.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
='block' device='lun' instead of adding a
driver element to better match the behavior available via QEMU.
v2:
* Added additional test cases and fixed issues that arose from those
*** BLURB HERE ***
Doug Goldstein (3):
Allow source for type=block to have no dev
VMX: Add support for 'auto
VMWare Fusion 5 can set the CD-ROM's device name to be 'auto detect' when
using the physical drive via 'cdrom-raw' device type. VMWare will then
connect to first available host CD-ROM to the virtual machine upon start
up according to VMWare documentation. If no device is available, it
appears that
Currently the XML parser already allows the following syntax:
disk type='block' device='cdrom'
source startupPolicy='optional'/
target dev='hda' bus='ide'/
address type='drive' controller='0' bus='0' target='0' unit='0'/
/disk
But it if the dev value then it would not have the
A user was having an issue with this specific VMWare Fusion config and
he gave me permission to add it as part of our test suite to further
expand our VMX test coverage. Unfortunately our VMX parser and
generator does not support many features contained within and just
silently ignores fields it
On Mon, Sep 9, 2013 at 8:48 PM, Doug Goldstein car...@cardoe.com wrote:
A user came into #virt the other day and was trying to get libvirtd
to work with VMware Fusion 5, which is basically the Mac OS X version of
VMware Workstation. In helping him out I noticed a few limitations of our
VMX
On Mon, Sep 16, 2013 at 12:03 PM, Eric Blake ebl...@redhat.com wrote:
On 09/09/2013 07:48 PM, Doug Goldstein wrote:
Currently the XML parser already allows the following syntax:
disk type='block' device='cdrom'
source startupPolicy='optional'/
target dev='hda' bus='ide
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
;
qemuMigrationJobSetPhase(driver, vm, QEMU_MIGRATION_PHASE_PREPARE);
--
1.8.1.5
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir
of
either, so sorry about that. I didn't actually give this patchset a
whirl but I plan on it. I'm at LinuxCon this week so I'm not sure when
I'll have a chance.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
insertions(+), 44 deletions(-)
ACK.
Pushed this based on Osier's ACK.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
deletions(-)
create mode 100644 tests/qemuhelpdata/qemu-1.1
create mode 100644 tests/qemuhelpdata/qemu-1.1-device
--
1.8.4.rc3
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
--
Doug Goldstein
--
libvir-list mailing list
libvir-list
. Otherwise there's a bit
of inconsistency with the rest of the system.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
. But I don't see
virNetcfDriverStateOnceInit() called anywhere and I don't see
virNetcfDriverStateInitialize() defined anywhere? Are those suppose to
be one in the same or is there some magical macro expansion going on
somewhere that I just don't know about.
--
Doug Goldstein
--
libvir-list
On Wed, Sep 11, 2013 at 10:43 AM, Michal Privoznik mpriv...@redhat.com wrote:
On 11.09.2013 17:37, Doug Goldstein wrote:
On Wed, Sep 11, 2013 at 10:06 AM, Laine Stump la...@laine.org wrote:
This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=983026
The netcf interface driver previously
/libvir-list
ACK with the fix in the white space.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
);
-if (qemuDomainObjEndJob(driver, vm) 0)
+if (!qemuDomainObjEndJob(driver, vm))
vm = NULL;
goto endjob;
}
--
1.8.3.1
ACK. Looked fairly mechanical. Only thing I had to check was the goto
cleanup going away in a few places and it was all correct.
--
Doug Goldstein
--
libvir
CD-ROMs and Floppies are allowed to have no source to imply they are
empty or disconnected. Since the LUN type is used for raw CD-ROM access
with QEMU (and VMWare in the future), it also needs to allow an empty
source when the raw CD-ROM device is disconnected from the domain.
---
that arose from those
*** BLURB HERE ***
Doug Goldstein (4):
Allow LUN type disks to have no source
Allow source for type=block to have no dev
VMX: Add support for 'auto detect' fileNames
VMX: Add a VMWare Fusion 5 configuration for tests
docs/schemas/domaincommon.rng | 8
A user was having an issue with this specific VMWare Fusion config and
he gave me permission to add it as part of our test suite to further
expand our VMX test coverage. Unfortunately our VMX parser and
generator does not support many features contained within and just
silently ignores fields it
VMWare Fusion 5 can set the CD-ROM's device name to be 'auto detect' when
using the physical drive via 'cdrom-raw' device type. VMWare will then
connect to first available host CD-ROM to the virtual machine upon start
up according to VMWare documentation. If no device is available, it
appears that
Currently the XML parser already allows the following syntax:
disk type='block' device='cdrom'
source startupPolicy='optional'/
target dev='hda' bus='ide'/
address type='drive' controller='0' bus='0' target='0' unit='0'/
/disk
But it did not support writing out the source entry
= VIR_CPU_COMPARE_ERROR;
+goto out;
+}
+
I agree with all of John's reviews here as well.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
When virGetUserEnt() and virGetGroupEnt() fail due to the uid or gid not
existing on the machine they'll print a message like:
$ virsh -c vbox:///session list
error: failed to connect to the hypervisor
error: Failed to find user record for uid '32655': Success
The success at the end is a bit
On Thu, Aug 29, 2013 at 5:19 AM, Michal Privoznik mpriv...@redhat.comwrote:
On 28.08.2013 23:53, Doug Goldstein wrote:
Sometimes a serial port might not be actually wired to a device when the
user does not have the VM powered on and we should not consider this a
fatal error.
---
src
,
};
--
1.8.1.4
I don't have PPC however so I can't actually test the code. But I did add a
few comments above.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Thu, Aug 29, 2013 at 5:19 AM, Michal Privoznik mpriv...@redhat.comwrote:
On 28.08.2013 23:53, Doug Goldstein wrote:
virVMXFormatHardDisk() and virVMXFormatCDROM() duplicated a lot of code
from each other and made a lot of nested if checks to build each part of
the VMX file
libvirt Python bindings to just 2.7 which constantly causes me
grief in the form of bug reports for other versions. So I support this
effort whole heartedly and will gladly lend a hand where time permits.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com
On Thu, Aug 29, 2013 at 5:19 AM, Michal Privoznik mpriv...@redhat.comwrote:
On 28.08.2013 23:53, Doug Goldstein wrote:
A user was having an issue with this specific VMWare Fusion config and
he gave me permission to add it as part of our test suite to further
expand our VMX test coverage
On Thu, Aug 29, 2013 at 5:19 AM, Michal Privoznik mpriv...@redhat.comwrote:
On 28.08.2013 23:53, Doug Goldstein wrote:
According to VMWare's documentation 'cdrom-raw' is an acceptable value
for deviceType for a CD-ROM drive. The documentation states that the VMX
configuration for a CD-ROM
/lxc_monitor_protocol.x, line 18: expected ';'
cannot shutdown /usr/bin/rpcgen: at ./rpc/genprotocol.pl line 136.
make[2]: *** [lxc/lxc_monitor_protocol.c] Error 1
I haven't been able to look into the issue but I'm guessing its going to
need a bit more code manipulation with Perl.
--
Doug Goldstein
A user was having an issue with this specific VMWare Fusion config and
he gave me permission to add it as part of our test suite to further
expand our VMX test coverage. Unfortunately our VMX parser and
generator does not support many features contained within and just
silently ignores fields it
virVMXFormatHardDisk() and virVMXFormatCDROM() duplicated a lot of code
from each other and made a lot of nested if checks to build each part of
the VMX file. This hopefully simplifies the code path while combining
the two functions with no net difference.
---
src/libvirt_vmx.syms | 3 +-
Sometimes a serial port might not be actually wired to a device when the
user does not have the VM powered on and we should not consider this a
fatal error.
---
src/vmx/vmx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c
index bcbb997..036e234
and virVMXFormatCDROM into
one function.
* Converted to disk type='block' device='lun' instead of adding a
driver element to better match the behavior available via QEMU.
v2:
* Added additional test cases and fixed issues that arose from those
Doug Goldstein (4):
VMX: Create virVMXFormatDisk() from HD and CD
According to VMWare's documentation 'cdrom-raw' is an acceptable value
for deviceType for a CD-ROM drive. The documentation states that the VMX
configuration for a CD-ROM deviceType is as follows:
ide|scsi(n):(n).deviceType = cdrom-raw|atapi-cdrom|cdrom-image
From the documentation it appears
On Tue, Aug 27, 2013 at 8:56 AM, Paolo Bonzini pbonz...@redhat.com wrote:
Il 27/08/2013 15:50, Daniel P. Berrange ha scritto:
On Thu, Aug 22, 2013 at 08:53:06PM -0500, Doug Goldstein wrote:
According to VMWare's documentation 'cdrom-raw' is an acceptable value
for deviceType for a CD-ROM
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, Aug 23, 2013 at 10:45 AM, Nehal J Wani nehaljw.k...@gmail.comwrote:
On Fri, Aug 23, 2013 at 8:16 PM, Doug Goldstein car...@gentoo.org wrote:
On Thu, Aug 22, 2013 at 5:18 PM, nehaljwani nehaljw.k...@gmail.com
wrote:
Use virDomainInterfacesAddresses in virsh
tools/virsh
element and added the tray to be opened.
Doug Goldstein (4):
VMX: Add cdrom-raw dev type from VMWare Fusion
VMX: Add support for 'auto detect' fileNames
VMX: Some serial ports are not actually connected
VMX: Add a VMWare Fusion 5 configuration for tests
docs/formatdomain.html.in
VMWare Fusion 5 can set the CD-ROM's device name to be 'auto detect' when
using the physical drive via 'cdrom-raw' device type. VMWare will then
connect to first available host CD-ROM to the virtual machine upon start
up according to VMWare documentation.
To better model this a CD-ROM that is
A user was having an issue with this specific VMWare Fusion config and
he gave me permission to add it as part of our test suite to further
expand our VMX test coverage. Unfortunately our VMX parser and
generator does not support many features contained within and just
silently ignores fields it
According to VMWare's documentation 'cdrom-raw' is an acceptable value
for deviceType for a CD-ROM drive. The documentation states that the VMX
configuration for a CD-ROM deviceType is as follows:
ide|scsi(n):(n).deviceType = cdrom-raw|atapi-cdrom|cdrom-image
From the documentation it appears
Sometimes a serial port might not be actually wired to a device when the
user does not have the VM powered on and we should not consider this a
fatal error.
---
src/vmx/vmx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c
index e7732e4..a13ef63
what a
more correct syntax would be.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Wed, Aug 21, 2013 at 4:46 PM, Eric Blake ebl...@redhat.com wrote:
On 08/17/2013 01:56 PM, Doug Goldstein wrote:
Previously the error message showed the following:
error: internal error: Invalid or not yet handled value 'auto detect'
for VMX entry 'ide0:0.fileName'
This left
not what's wanted then
ignore my comments. But do fix the versioning reviews above.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Mon, Aug 19, 2013 at 2:47 PM, Eric Blake ebl...@redhat.com wrote:
On 08/19/2013 01:22 PM, Doug Goldstein wrote:
On Mon, Aug 19, 2013 at 1:19 PM, Giuseppe Scrivano gscri...@redhat.com
wrote:
---
I have started working on:
https://bugzilla.redhat.com/show_bug.cgi?id=916786
According to VMWare's documentation 'cdrom-raw' is an acceptable value
for deviceType for a CD-ROM drive.
ide|scsi(n):(n).deviceType = cdrom-raw|atapi-cdrom|cdrom-image
'cdrom-raw' appears to pass on your host CD-ROM instead of emulating an
ATAPI CD-ROM drive.
---
src/vmx/vmx.c
Sometimes a serial port might not be actually wired to a device when the
user does not have the device connected at power on and we should not
consider this a fatal error.
---
src/vmx/vmx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c
index
their products in many
years so I can't test this myself.
Doug Goldstein (5):
VMX: Improve disk parse error for unknown values
VMX: Add cdrom-raw dev type from VMWare Fusion
VMX: Add support for 'auto detect' fileNames
VMX: Some serial ports are not actually connected
VMX: Add a VMWare Fusion
VMWare Fusion 5 can set the CD-ROM's file name to be 'auto detect' when
using the physical drive via 'cdrom-raw' device type. VMWare will then
connect to first available host CD-ROM to the virtual machine upon start
up according to VMWare documentation.
---
src/vmx/vmx.c
A user was having an issue with this specific VMWare Fusion config and
he gave me permission to add it as part of our test suite to further
expand our VMX test coverage.
---
tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.vmx | 88 ++
Previously the error message showed the following:
error: internal error: Invalid or not yet handled value 'auto detect'
for VMX entry 'ide0:0.fileName'
This left the user unsure if it was a CD-ROM or a disk device that they
needed to fix. Now the error shows:
error: internal error: Invalid or
-EINVAL from the kernel. Newer systems have /run as tmpfs and /var/run
symlinked to /run.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
I've gone ahead and pushed 43cee32 (revert of 2df8d99) plus this
(70024dc) to v1.1.1-maint since v1.1.1-maint did not compile for me on
Fedora 19 and on Gentoo with glibc 2.17.
--
Doug Goldstein
On Thu, Aug 8, 2013 at 10:05 PM, Alex Jia a...@redhat.com wrote:
Martin, I pushed this now.
--
Regards,
Alex
Pushed to v1.1.1-maint
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, Aug 9, 2013 at 10:31 AM, Eric Blake ebl...@redhat.com wrote:
On 08/07/2013 08:15 AM, Eric Blake wrote:
On 08/07/2013 07:29 AM, Doug Goldstein wrote:
On Tue, Jul 30, 2013 at 3:45 PM, Eric Blake ebl...@redhat.com wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=951637
Newer gnutls
#Processor_Cores */
--
1.8.3.1
ACK. Easy mechanical change.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
previously
discussed it. If you need me to test it, I can do that tonight.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
);
+testTLSDiscardCert(clientcertlevel2breq);
+unlink(cacertchain.pem);
+
testTLSCleanup();
return ret==0 ? EXIT_SUCCESS : EXIT_FAILURE;
--
1.8.3.1
To follow Michal's ACK. I've tried just this patch with a chained
certificate I had and I can confirm this worked.
--
Doug Goldstein
--
libvir
.
---
src/xen/xend_internal.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
ACK.
Pushed now, thanks.
Regards,
Jim
I pushed this to v1.1.1-maint as well.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir
.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Mon, Aug 5, 2013 at 9:15 PM, Doug Goldstein car...@gentoo.org wrote:
On Mon, Aug 5, 2013 at 8:13 PM, Laine Stump la...@laine.org wrote:
This patch addresses two concerns with the error reporting when an
incompatible PCI address is specified for a device:
1) It wasn't always apparent which
On Mon, Aug 5, 2013 at 1:33 AM, Laine Stump la...@laine.org wrote:
On 08/04/2013 05:01 PM, Doug Goldstein wrote:
On Sat, Aug 3, 2013 at 9:01 PM, Laine Stump la...@laine.org wrote:
+if ((cont-type == VIR_DOMAIN_CONTROLLER_TYPE_IDE cont-idx ==
0
+ addr-function == 1
On Mon, Aug 5, 2013 at 3:37 AM, Laine Stump la...@laine.org wrote:
On 08/04/2013 07:53 PM, Doug Goldstein wrote:
On Sat, Aug 3, 2013 at 9:01 PM, Laine Stump la...@laine.org wrote:
This patch adds in special handling for a few devices that need to be
treated differently for q35 domains:
usb
completely ignores any io window setup done by the
guest. Oops.
cheers,
Gerd
Thanks a bunch for tracking that down Gerd. I can confirm that fixes
the issue and the libvirt patch to work around this is unnecessary.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https
that way.
So long story short
ACK.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Other than my slight nitpick, visually this looks good. I'll give it a
whirl with some of my bad configs tonight.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
)
continue;
--
1.7.11.7
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Overall looks good and I learned a bit about parts of libvirt I didn't
know much about. I had a few comment nitpicks but otherwise ACK from
me here.
--
Doug Goldstein
On Sat, Aug 3, 2013 at 9:11 PM, Laine Stump la...@laine.org wrote:
On 08/03/2013 10:06 PM, Doug Goldstein wrote:
On Sat, Aug 3, 2013 at 8:48 PM, Laine Stump la...@laine.org wrote:
On 08/03/2013 09:36 PM, Doug Goldstein wrote:
On Sat, Aug 3, 2013 at 6:28 PM, Laine Stump la...@laine.org wrote
-virtio-scsi);
--
1.7.11.7
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Overall an ACK, just fix up the commit message and move the since
documentation fixup to 2/7, which I think you can do without
reposting.
--
Doug Goldstein
://www.redhat.com/mailman/listinfo/libvir-list
ACK. Seems to just straight forward add pcie-root along side pci-root.
I'd just move the fix to the since section to this patch from 3/7 that
I noted above.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo
@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Straight forward so ACK. This could probably be re-ordered before 4/7
if you want to merge in the ACK'd patches.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
if my understanding is wrong.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
as well as correctness (QEMU
allowing you to attach PCI devices to PCIe buses and vis versa). If
this approach is the one that goes forward, then consider this an ACK
of this patch.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir
-bridge'/
--
1.7.11.7
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Had some questions above so holding off on ACK.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
,
qemuDomainPCIConnectFlags flags);
--
1.7.11.7
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Sun, Aug 4, 2013 at 6:50 PM, Doug Goldstein car...@gentoo.org wrote:
On Sat, Aug 3, 2013 at 9:11 PM, Laine Stump la...@laine.org wrote:
On 08/03/2013 10:06 PM, Doug Goldstein wrote:
On Sat, Aug 3, 2013 at 8:48 PM, Laine Stump la...@laine.org wrote:
On 08/03/2013 09:36 PM, Doug Goldstein
On Sun, Aug 4, 2013 at 6:50 PM, Doug Goldstein car...@gentoo.org wrote:
On Sat, Aug 3, 2013 at 9:11 PM, Laine Stump la...@laine.org wrote:
On 08/03/2013 10:06 PM, Doug Goldstein wrote:
On Sat, Aug 3, 2013 at 8:48 PM, Laine Stump la...@laine.org wrote:
On 08/03/2013 09:36 PM, Doug Goldstein
myself. I should have probably spoke up on the ML rather than
remaining silent. I'll finish up testing it tonight and ACK a handful
shortly.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Sat, Aug 3, 2013 at 8:48 PM, Laine Stump la...@laine.org wrote:
On 08/03/2013 09:36 PM, Doug Goldstein wrote:
On Sat, Aug 3, 2013 at 6:28 PM, Laine Stump la...@laine.org wrote:
...and here is the result of applying all 10 patches of this 7 patch
series, and starting up a domain using
On Fri, Jul 26, 2013 at 10:37 PM, Eric Blake ebl...@redhat.com wrote:
On 07/26/2013 07:22 PM, Doug Goldstein wrote:
It appears it was an optional cutover and I guess Gentoo made the
plunge. Another idea, that you might hate would be to use pkg-config
directly and pass --static so we can get
On Sat, Jul 27, 2013 at 3:09 PM, Doug Goldstein car...@gentoo.org wrote:
On Fri, Jul 26, 2013 at 10:37 PM, Eric Blake ebl...@redhat.com wrote:
On 07/26/2013 07:22 PM, Doug Goldstein wrote:
It appears it was an optional cutover and I guess Gentoo made the
plunge. Another idea, that you might
201 - 300 of 570 matches
Mail list logo
