| 2 --
2 files changed, 3 insertions(+), 5 deletions(-)
ACK.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
Please push this into v1.1.0-maint as well.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https
-lgnutls -lgcrypt -lgpg-error -ltasn1 -lz -lp11-kit
With GnuTLS 3.2 I get the following:
pkg-config --libs --static gnutls
-lgnutls -lhogweed -lnettle -lz -lgmp
Maybe that helps?
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir
-o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Ok to push this into v1.1.0-maint as this fixes a crasher for users
with this configuration? Should we also push the 1/2 patch?
--
Doug Goldstein
--
libvir-list
without having to reconfigure and rebuild.
Count this as a would like to see python 3.x support but don't have
time to personally do it.
Just a thought.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, Jun 28, 2013 at 2:49 AM, Ján Tomko jto...@redhat.com wrote:
On 06/28/2013 03:48 AM, Doug Goldstein wrote:
The udev based interface backend did not allow querying data over a
read-only connection which is different than how the netcf backend
operates. This brings the behavior inline
On Thu, Jun 27, 2013 at 9:46 PM, Doug Goldstein car...@gentoo.org wrote:
On Thu, Jun 27, 2013 at 11:01 AM, Daniel Veillard veill...@redhat.comwrote:
I have just tagged the release candidate 2 in git and sent a tarball
to the usual place (rpms are coming):
ftp://libvirt.org/libvirt
The udev based interface backend did not allow querying data over a
read-only connection which is different than how the netcf backend
operates. This brings the behavior inline with the default, netcf
backend.
---
src/interface/interface_backend_udev.c | 2 +-
1 file changed, 1 insertion(+), 1
that the file isn't there. I was under
the impression that a NBD starts up and streams the data over. It gives me
an error to hint that if I can include --tunnelled in the options.
Using qemu 1.4.2 for reference (its Cole's patchset for 1.4.2 from Fedora's
qemu.git)
--
Doug Goldstein
--
libvir-list
In the first if case, virGetUserEnt() isn't necessary so don't bother
calling it before determining we need it.
---
Found this trying to get libvirtd running happily on my Mac OS X machine
for qemu. Unfortunately it appears virGetUserEnt() is always failing
on Mac OS X (getpwuid_r() returns 0 each
The libvirt-php 0.4.8 tar is missing from the git repo [1]. Hopefully
someone who created the tarball can create the tag as well and push it.
[1] http://libvirt.org/git/?p=libvirt-php.git
Thanks.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman
If I get an ACK on these 4, I'll cherry pick them back to v1.0.5-maint.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Commit 894f784948a93760629de3cb195c69ef4f4b831f broke the v1.0.5-maint
branch because VIR_STRDUP() didn't exist in the v1.0.5 release so the
resulting build is missing that symbol.
This patch is only for the v1.0.5-maint branch.
---
src/qemu/qemu_migration.c | 2 +-
1 file changed, 1
.
We should put this fix into the -maint branch as well then.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
more finesse with the detection and choosing
whether to use --conntrack or --state for RHEL 5 era systems.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
, and definitely 1.0.4 material.
Thanks, pushed to master. I wonder if it should be pushed to stable
branches as well. Doug, Cole - what do you think?
Michal
Agreed. That's definitely a regression since we've switched and the
patch is very straight forward.
--
Doug Goldstein
--
libvir-list
to carry a patch. But how do
they find out they need to carry that patch if they don't follow the
developer mailing list closely.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, Mar 22, 2013 at 12:27 PM, Daniel P. Berrange
berra...@redhat.com wrote:
On Fri, Mar 22, 2013 at 11:59:56AM +, Daniel P. Berrange wrote:
On Thu, Mar 21, 2013 at 11:50:40PM -0500, Doug Goldstein wrote:
So still trying to figure out what I'm doing wrong with LXC because I
just can't
). If
you don't care about any authentication or encryption for testing
purposes you can use qemu+tcp://
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Sun, Mar 3, 2013 at 11:19 PM, Gao feng gaof...@cn.fujitsu.com wrote:
Hi Doug,
On 2013/03/04 12:38, Doug Goldstein wrote:
On Sun, Mar 3, 2013 at 5:24 PM, Doug Goldstein car...@gentoo.org wrote:
On Fri, Dec 21, 2012 at 10:15 PM, Lars Kellogg-Stedman l...@oddbit.com
wrote:
Using libvirt
On Sat, Mar 16, 2013 at 9:11 PM, Doug Goldstein car...@cardoe.com wrote:
When building with --without-libvirtd and udev support is detected we
will fail to build with the following error:
node_device/node_device_udev.c:1608:37: error: unknown type name
'virStateInhibitCallback
On Tue, Mar 19, 2013 at 12:58 PM, Eric Blake ebl...@redhat.com wrote:
On 03/16/2013 08:11 PM, Doug Goldstein wrote:
When building with --without-libvirtd and udev support is detected we
will fail to build with the following error:
node_device/node_device_udev.c:1608:37: error: unknown type
When building with --without-libvirtd and udev support is detected we
will fail to build with the following error:
node_device/node_device_udev.c:1608:37: error: unknown type name
'virStateInhibitCallback'
---
src/Makefile.am | 2 ++
1 file changed, 2 insertions(+)
diff --git
-contained without
needing sys/types.h.
+#include sys/stat.h
Required - ACK to this one line addition.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
Pushed the ACK'd part to v1.0.3-maint
Thanks.
--
Doug Goldstein
--
libvir-list
, VSH_MAX_XML_FILE, buffer) 0) {
ACK to this patch, though. We probably have to support that code forever now
:(.
Peter
Pushed to v1.0.3-maint
Thanks.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
.
Pushed to v1.0.3-maint
Thanks.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
insertions(+), 15 deletions(-)
ACK.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
Backported to v1.0.3-maint.
Thanks.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir
changed, 1 insertion(+), 3 deletions(-)
ACK.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
Backported to v1.0.3-maint.
Thanks.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo
,
I just gave it a whirl. And I'm able to reproduce the same issue you
are seeing. The issue appears to be that
lxcContainerMountFsBlockAuto() is never being called. It was added in
http://www.redhat.com/archives/libvir-list/2011-August/msg00201.html
Hopefully I'll have more info soon.
--
Doug
On Sun, Mar 3, 2013 at 5:24 PM, Doug Goldstein car...@gentoo.org wrote:
On Fri, Dec 21, 2012 at 10:15 PM, Lars Kellogg-Stedman l...@oddbit.com
wrote:
Using libvirt 1.0.1, I'm trying to start an LXC container using the
'filesytem type=block' syntax, like this:
filesystem type=block
least be on the roadmap for
Fedora 19.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
/
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
don't care was
wrong.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, Feb 26, 2013 at 6:10 AM, Laine Stump la...@laine.org wrote:
On 02/26/2013 01:28 AM, Doug Goldstein wrote:
This fixes a potential NULL deref identified by John Ferlan
jfer...@redhat.com if scandir() didn't return an expected value.
---
src/interface/interface_backend_udev.c | 7
does not for older versions. We detect the capabilities of qemu via
src/qemu/qemu_capabilities.c and you'll probably want to add a
capability bit to support this.
Hope that helps.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
This fixes a potential NULL deref identified by John Ferlan
jfer...@redhat.com if scandir() didn't return an expected value.
---
src/interface/interface_backend_udev.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/interface/interface_backend_udev.c
The bridge device was showing the vnet devices created for the domains
as connected to the bridge. libvirt should only show host devices when
trying to get the interface definition rather than the domain devices as
well.
---
Honestly this method sucks. But it makes the code path work and doesn't
Adds the --start option to the define command to simplify the often used
case of virsh define dom.xml; start dom or virsh define dom.xml
virsh start dom.
This is just a rebased version of:
https://www.redhat.com/archives/libvir-list/2013-January/msg00490.html
There's a competing patchset
Adds support to the qemu driver for the VIR_DOMAIN_START_PERSISTENT flag
---
Figured this would be better to define the domain before starting it,
rather than starting and then defining but I can change as people prefer.
---
src/qemu/qemu_driver.c | 45
Added a VIR_DOMAIN_START_PERSISTENT flag for virDomainCreateXML() so
that the guest remains defined after it is destroyed. The result of
using this flag is equivilent to calling virDomainDefineXML() followed
by virDomainCreate() or virDomainCreateWithFlags().
---
Not sure if this is the correct
Add support for the persistent flag to virsh create to allow creating of
guests that remain defined after they are stopped.
---
The discussion on
https://www.redhat.com/archives/libvir-list/2013-January/msg00490.html
was more inclined to have 'virsh create --persistent' so this adds that.
---
On Fri, Feb 22, 2013 at 11:40 AM, Doug Goldstein car...@cardoe.com wrote:
Added support for a --start flag to the define command
---
Implements
https://www.redhat.com/archives/libvir-list/2013-January/msg00490.html
in a new way using the persistent flag for create.
---
tools/virsh
Added support for a --start flag to the define command
---
Implements
https://www.redhat.com/archives/libvir-list/2013-January/msg00490.html
in a new way using the persistent flag for create.
---
tools/virsh-domain.c | 9 -
tools/virsh.pod | 5 +++--
2 files changed, 11
On Fri, Feb 22, 2013 at 11:48 AM, Daniel P. Berrange
berra...@redhat.com wrote:
On Fri, Feb 22, 2013 at 11:40:32AM -0600, Doug Goldstein wrote:
Added a VIR_DOMAIN_START_PERSISTENT flag for virDomainCreateXML() so
that the guest remains defined after it is destroyed. The result of
using
On Thu, Feb 21, 2013 at 9:55 AM, Peter Krempa pkre...@redhat.com wrote:
On 02/18/13 06:11, Doug Goldstein wrote:
On Fri, Jan 11, 2013 at 2:51 PM, Guido Günther a...@sigxcpu.org wrote:
On Tue, Jan 08, 2013 at 04:41:58PM -0700, Eric Blake wrote:
On 01/08/2013 02:36 PM, Doug Goldstein wrote
On Wed, Feb 20, 2013 at 1:56 PM, Doug Goldstein car...@cardoe.com wrote:
Refactor code, clean up error handling, and finally add bond support. The
last patch optionally supports a patch I submitted to the Linux kernel
which should go in for 3.9 (it was just accepted for net-next).
After
series --
/bridge
/interface
Doug Goldstein (6):
interface: Refactor udev bridge to helper func
interface: udev bridge code error handling updates
interface: Refactor interface vlan to helper func
interface: Improve udev backend device type id
interface: add bond support to udev backend
Mechanical move to break up udevIfaceGetIfaceDef() into different
helpers for each of the interface types to hopefully make the code
easier to follow. This moves the bridge code to
udevIfaceGetIfaceDefBridge().
---
src/interface/interface_backend_udev.c | 155 ++---
1
Patch has been accepted into net-next's 3.9 queue to correctly expose
bond interfaces with the 'bond' devtype.
---
I'd consider this patch optional until the fix lands in Linus' tree.
---
src/interface/interface_backend_udev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
Mechanical move to break up udevIfaceGetIfaceDef() into different
helpers for each of the interface types to hopefully make the code
easier to follow. This moves the vlan code to
udevIfaceGetIfaceDefVlan().
---
src/interface/interface_backend_udev.c | 73 +-
1 file
Refactored the interface device type identification to make it more
clear about the operations. Add support for udev devtype to detect
VLANs on Linux 3.7 and newer. Move VLAN detection based on device
name to fallback case.
---
src/interface/interface_backend_udev.c | 46
Based on feedback from Laine Stump, improve a number of the error
handling cases to report the issue to the user instead of not generating
data or giving vague errors. Added the bridge device name to every error
message as well to make it clear which bridge failed.
---
The udev backend now supports bond interfaces.
---
src/interface/interface_backend_udev.c | 264 -
1 file changed, 263 insertions(+), 1 deletion(-)
diff --git a/src/interface/interface_backend_udev.c
b/src/interface/interface_backend_udev.c
index db4e7d1..9f1570c
, but again if people think they'd be
useful I'm happy to push them.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
supporting each release of libvirt, we'll have a
stable branch for every release that others are welcome to follow or
look at or make suggestions to include.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, Feb 19, 2013 at 2:54 PM, Jiri Denemark jdene...@redhat.com wrote:
On Tue, Feb 19, 2013 at 14:37:40 -0600, Doug Goldstein wrote:
FWIW, I keep the patchset that I push into Gentoo now in a bit
friendlier place to access:
http://git.cardoe.com/?p=libvirt.git;a=shortlog;h=refs/heads
On Mon, Feb 18, 2013 at 7:22 AM, Laine Stump la...@laine.org wrote:
On 02/18/2013 01:10 AM, Doug Goldstein wrote:
The conversion to qemuCaps dropped the ability with qemu{,-kvm} 1.2 and
newer to set the lost tick policy for the PIT. While the
-no-kvm-pit-reinjection option is depreacated
On Mon, Feb 18, 2013 at 7:29 AM, Laine Stump la...@laine.org wrote:
On 02/18/2013 12:40 AM, Doug Goldstein wrote:
/src/lxc/lxc_protocol.[ch] is autogenerated so add it to .gitignore
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 23fdc91
On Mon, Feb 18, 2013 at 2:56 AM, Peter Krempa pkre...@redhat.com wrote:
On 02/18/13 05:28, Doug Goldstein wrote:
udevIfaceListAllInterface() used the udev_device after it had its ref
count decremented which results in a use after free issue.
---
src/interface/interface_backend_udev.c | 2
On Mon, Feb 18, 2013 at 11:13 AM, Laine Stump la...@laine.org wrote:
On 02/18/2013 09:54 AM, Doug Goldstein wrote:
On Mon, Feb 18, 2013 at 7:22 AM, Laine Stump la...@laine.org wrote:
On 02/18/2013 01:10 AM, Doug Goldstein wrote:
The conversion to qemuCaps dropped the ability with qemu{,-kvm
On Sun, Feb 17, 2013 at 7:12 PM, Doug Goldstein car...@gentoo.org wrote:
On Sun, Feb 17, 2013 at 11:33 AM, Guido Günther a...@sigxcpu.org wrote:
so we don't try to change uid/git to 0 when probing capabilities.
---
On Fri, Feb 15, 2013 at 11:20:17PM -0600, Doug Goldstein wrote:
The following
On Sat, Feb 16, 2013 at 4:53 PM, Laine Stump la...@laine.org wrote:
On 02/16/2013 12:20 AM, Doug Goldstein wrote:
On Tue, Feb 12, 2013 at 2:15 PM, Laine Stump la...@laine.org wrote:
Normally when a process' uid is changed to non-0, all the capabilities
bits are cleared, even those explicitly
On Sun, Feb 17, 2013 at 11:33 AM, Guido Günther a...@sigxcpu.org wrote:
so we don't try to change uid/git to 0 when probing capabilities.
---
On Fri, Feb 15, 2013 at 11:20:17PM -0600, Doug Goldstein wrote:
The following error bisect's down to this commit when running out of
my local checkout
Mechanical move to break up udevIfaceGetIfaceDef() into different
helpers for each of the interface types to hopefully make the code
easier to follow. This moves the bridge code to
udevIfaceGetIfaceDefBridge().
---
src/interface/interface_backend_udev.c | 161 +++--
1
Refactored the interface device type identification to make it more
clear about the operations.
---
src/interface/interface_backend_udev.c | 43 --
1 file changed, 30 insertions(+), 13 deletions(-)
diff --git a/src/interface/interface_backend_udev.c
The udev backend now supports bond interfaces.
---
The result of an iface-dumpxml bond0 is as follows:
interface type='bond' name='bond0'
mtu size='1500'/
bond mode='balance-rr'
interface type='ethernet' name='eth2'
mac address='d0:67:e5:fa:88:95'/
mtu size='1500'/
This patchset primarily aims to add support for bond devices which was
lacking from the exiting code. This closes out support for all interface
device types. The patchset also refactors to code to make it a bit easier
to follow hopefully.
Doug Goldstein (4):
interface: Refactor udev bridge
udevIfaceListAllInterface() used the udev_device after it had its ref
count decremented which results in a use after free issue.
---
src/interface/interface_backend_udev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/interface/interface_backend_udev.c
/src/lxc/lxc_protocol.[ch] is autogenerated so add it to .gitignore
---
.gitignore | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.gitignore b/.gitignore
index 23fdc91..16ac708 100644
--- a/.gitignore
+++ b/.gitignore
@@ -31,6 +31,7 @@
/COPYING
/ChangeLog
/GNUmakefile
+/HACKING
On Fri, Jan 11, 2013 at 2:51 PM, Guido Günther a...@sigxcpu.org wrote:
On Tue, Jan 08, 2013 at 04:41:58PM -0700, Eric Blake wrote:
On 01/08/2013 02:36 PM, Doug Goldstein wrote:
I often find myself doing virsh define blah.xml; start blah. I figured
adding this would be a easier^Hlazier way
/src/lxc/lxc_protocol.[ch] is autogenerated so add it to .gitignore
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 23fdc91..c918372 100644
--- a/.gitignore
+++ b/.gitignore
@@ -121,6 +121,7 @@
/src/lxc/lxc_monitor_dispatch.h
On Sun, Feb 17, 2013 at 11:05 PM, Doug Goldstein car...@cardoe.com wrote:
/src/lxc/lxc_protocol.[ch] is autogenerated so add it to .gitignore
---
.gitignore | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.gitignore b/.gitignore
index 23fdc91..16ac708 100644
--- a/.gitignore
+++ b
The conversion to qemuCaps dropped the ability with qemu{,-kvm} 1.2 and
newer to set the lost tick policy for the PIT. While the
-no-kvm-pit-reinjection option is depreacated, it is still supported at
least through 1.4, it is better to not lose the functionality.
---
src/qemu/qemu_capabilities.c
/bin:/usr/x86_64-pc-linux-gnu/gcc-bin/4.6.3:/usr/games/bin
HOME=/home/cardoe USER=cardoe LOGNAME=cardoe /usr/bin/qemu-kvm -help)
unexpected exit status 1: libvir: error : internal error cannot apply
process capabilities -1
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https
);
}
--
1.8.0.1.240.ge8a1f5a
What platform or target were you aiming this for that this was needed?
This appears to prevent supporting backends from being registered
while the other parts of the code provide other functionality.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https
virtualization library http://libvirt.org
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Pushed.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Wed, Jan 30, 2013 at 12:53 PM, Scott Sullivan
ssulli...@liquidweb.com wrote:
On 01/29/2013 02:55 PM, Doug Goldstein wrote:
On Tue, Jan 29, 2013 at 9:52 AM, Scott Sullivanssulli...@liquidweb.com
wrote:
I have a machine with four AMD Opteron(TM) 6272 processors:
http://www.amd.com/us
On Wed, Jan 30, 2013 at 4:12 PM, Doug Goldstein car...@gentoo.org wrote:
On Wed, Jan 30, 2013 at 12:53 PM, Scott Sullivan
ssulli...@liquidweb.com wrote:
On 01/29/2013 02:55 PM, Doug Goldstein wrote:
On Tue, Jan 29, 2013 at 9:52 AM, Scott Sullivanssulli...@liquidweb.com
wrote:
I have
detects
the CPU incorrectly.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Setting the log output prefix to 0 is not supported and in fact results
in the following message:
warning : virLogParseOutputs:1021 : Ignoring invalid log output setting.
---
src/util/virlog.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/util/virlog.c b/src/util/virlog.c
index
missing something? Or is this command line argument not necessary
any longer?
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
with a caveat. How would you feel about a macro called
VSH_CMD_OPT_END that is defined to:
{.name = NULL,
.type = 0,
.flags = 0,
.help = NULL
}
Just a thought to cutdown on the number of changes necessary if/when
the members of the struct change.
--
Doug Goldstein
--
libvir-list
On Mon, Jan 14, 2013 at 10:51 AM, Michal Privoznik mpriv...@redhat.com wrote:
On 14.01.2013 17:33, Doug Goldstein wrote:
On Mon, Jan 14, 2013 at 9:59 AM, Michal Privoznik mpriv...@redhat.com
wrote:
---
tools/virsh.c | 62
---
1 file
}
};
#define FILTER(NAME, FLAG) \
--
1.8.0.2
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
ACK.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
-list
ACK.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
https://www.redhat.com/mailman/listinfo/libvir-list
ACK.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
. But if it worked for Eric then its
likely fine.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
I often find myself doing virsh define blah.xml; start blah. I figured
adding this would be a easier^Hlazier way to do it.
---
tools/virsh-domain.c | 20 ++--
1 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index
will be exposed
on the command line and via QMP so I think we really need to wait
until that lands in upstream's repo before we add code for it in
libvirt.
Just my 2c.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, Jan 8, 2013 at 5:41 PM, Eric Blake ebl...@redhat.com wrote:
On 01/08/2013 02:36 PM, Doug Goldstein wrote:
I often find myself doing virsh define blah.xml; start blah. I figured
adding this would be a easier^Hlazier way to do it.
---
tools/virsh-domain.c | 20
. */
+VIR_DOMAIN_CONTROLLER_TYPE_PCIBRIDGE,
VIR_DOMAIN_CONTROLLER_TYPE_USB,
VIR_DOMAIN_CONTROLLER_TYPE_SCSI,
VIR_DOMAIN_CONTROLLER_TYPE_SATA,
--
1.7.2.5
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
.
This change also needs an update to the XML schemas in
docs/schemas/basictypes.rng
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
*/
+if (qemuCapsGet(caps, QEMU_CAPS_DEVICE_QXL))
+qemuCapsSet(caps, QEMU_CAPS_VGA_QXL);
return 0;
}
--
1.8.0.2
I'm late to the party but ACK as being a better patch than the one I
sent earlier.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https
The -vga command always accepts qxl in 1.2 and newer.
---
src/qemu/qemu_capabilities.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index f49a31c..c3ab488 100644
--- a/src/qemu/qemu_capabilities.c
+++
but it should at the very
least get you going for now.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
was aiming for. I could be wrong though. I'll take
another look at it tonight.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
, __FUNCTION__);
+ return -1;
+}
+#endif
Are these changes really necessary? This is from SystemD and it talks
about BSD in the source.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Just minor doc nits.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
wording nit.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
. If you look at some of my past comments to older version of
the patch I rewrote it with a lot more detail.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
301 - 400 of 570 matches
Mail list logo
