from disk.xml
error: internal error: unable to execute QEMU command 'device_add': Bus
'scsi0.0' not found
Since the infrastructure is in place, we can also create a controller
silently for use by the hotplugged hostdev device.
Signed-off-by: Eric Farman far...@linux.vnet.ibm.com
---
src/qemu
to allow hotplug (and unplug)
work without incident.
Reviewed-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com
Eric Farman (3):
qemu: Rename controller hotplug functions to not be PCI-specific
qemu: Separate calls based on controller bus type
qemu: Auto-generate controller for hotplugged hostdev
routines made assumptions
that any caller had a PCI bus. These routines now selectively calls
PCI functions where necessary, and assigns the device information
type to one appropriate for the bus in use.
Signed-off-by: Eric Farman far...@linux.vnet.ibm.com
---
src/qemu/qemu_hotplug.c | 45
For attach/detach of controller devices, we rename the functions to
remove 'PCI' from their title. The actual separation of PCI-specific
operations will be handled in the next patch.
Signed-off-by: Eric Farman far...@linux.vnet.ibm.com
---
src/qemu/qemu_driver.c |4 ++--
src/qemu
from disk.xml
error: internal error: unable to execute QEMU command 'device_add': Bus
'scsi0.0' not found
Since the infrastructure is in place, we can also create a controller
silently for use by the hotplugged hostdev device.
Signed-off-by: Eric Farman far...@linux.vnet.ibm.com
---
src/qemu
relies on the presence of a PCI bus, which does not
work in all environments.
These patches correct this behavior, in order to allow hotplug (and unplug)
work without incident.
Reviewed-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com
Eric Farman (3):
qemu: Rename controller hotplug
routines made assumptions
that any caller had a PCI bus. These routines now selectively calls
PCI functions where necessary, and assigns the device information
type to one appropriate for the bus in use.
Signed-off-by: Eric Farman far...@linux.vnet.ibm.com
---
src/qemu/qemu_hotplug.c | 45
For attach/detach of controller devices, we rename the functions to
remove 'PCI' from their title. The actual separation of PCI-specific
operations will be handled in the next patch.
Signed-off-by: Eric Farman far...@linux.vnet.ibm.com
---
src/qemu/qemu_driver.c |4 ++--
src/qemu
On 11/12/2013 02:30 AM, Ján Tomko wrote:
On 10/08/2013 02:45 PM, Eric Farman wrote:
For systems without a PCI bus, attaching a SCSI controller fails:
[root@ ~]# cat controller.xml
controller type='scsi' model='virtio-scsi' index='0' /
[root@ ~]# virsh attach-device
from disk.xml
error: internal error: unable to execute QEMU command 'device_add': Bus
'scsi0.0' not found
Since the infrastructure is in place, we can also create a controller
silently for use by the hotplugged hostdev device.
Signed-off-by: Eric Farman far...@linux.vnet.ibm.com
---
src/qemu
routines made assumptions
that any caller had a PCI bus. These routines now selectively calls
PCI functions where necessary, and assigns the device information
type to one appropriate for the bus in use.
Signed-off-by: Eric Farman far...@linux.vnet.ibm.com
---
src/qemu/qemu_hotplug.c | 52
For attach/detach of controller devices, we rename the functions to
remove 'PCI' from their title. The actual separation of PCI-specific
operations will be handled in the next patch.
Signed-off-by: Eric Farman far...@linux.vnet.ibm.com
---
src/qemu/qemu_driver.c |4 ++--
src/qemu
Resending the series. Fixed the indentation change that I missed
in patch one, but otherwise patch one and three are unchanged.
Changes in patch two:
- Check for VIR_..._TYPE_NONE on controller-info.type
- Check device address for TYPE_CCW controllers during detach
Eric Farman (3):
qemu
On 11/12/2013 11:59 AM, Eric Farman wrote:
Resending the series. Fixed the indentation change that I missed
in patch one, but otherwise patch one and three are unchanged.
Changes in patch two:
- Check for VIR_..._TYPE_NONE on controller-info.type
- Check device address for TYPE_CCW
On 11/20/2013 04:16 AM, Ján Tomko wrote:
On 11/12/2013 05:59 PM, Eric Farman wrote:
For systems without a PCI bus, attaching a SCSI controller fails:
[root@ ~]# cat controller.xml
controller type='scsi' model='virtio-scsi' index='0' /
[root@ ~]# virsh attach-device
from disk.xml
error: internal error: unable to execute QEMU command 'device_add': Bus
'scsi0.0' not found
Since the infrastructure is in place, we can also create a controller
silently for use by the hotplugged hostdev device.
Signed-off-by: Eric Farman far...@linux.vnet.ibm.com
---
src/qemu
device address for TYPE_CCW controllers during detach
- Patch 1: Fixed an indentation change that was missed
Eric Farman (3):
qemu: Rename controller hotplug functions to not be PCI-specific
qemu: Separate calls based on controller bus type
qemu: Auto-generate controller for hotplugged hostdev
For attach/detach of controller devices, we rename the functions to
remove 'PCI' from their title. The actual separation of PCI-specific
operations will be handled in the next patch.
Signed-off-by: Eric Farman far...@linux.vnet.ibm.com
---
src/qemu/qemu_driver.c |4 ++--
src/qemu
routines made assumptions
that any caller had a PCI bus. These routines now selectively calls
PCI functions where necessary, and assigns the device information
type to one appropriate for the bus in use.
Signed-off-by: Eric Farman far...@linux.vnet.ibm.com
---
src/qemu/qemu_hotplug.c | 41
it's worth, other than the one doc change suggestion, the rest
looks (and works) fine to me.
Reviewed-by: Eric Farman far...@linux.vnet.ibm.com
- Eric
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 06/22/2015 05:05 PM, John Ferlan wrote:
If a SCSI subsystem hostdev element is provided with an address,
then enforce that the address type is 'drive'. If not provided,
a 'drive' element was created by virDomainHostdevAssignAddress
which uses VIR_DOMAIN_DEVICE_ADDRESS_TYPE_DRIVE.
On 06/18/2015 12:47 PM, John Ferlan wrote:
On 06/16/2015 11:29 PM, Eric Farman wrote:
A logical unit address is a positive integer, so it would be wise
to reject any negative inputs.
Signed-off-by: Eric Farman far...@linux.vnet.ibm.com
---
src/conf/domain_conf.c | 2 +-
tools/virsh
On 06/18/2015 02:38 PM, John Ferlan wrote:
On 06/16/2015 11:29 PM, Eric Farman wrote:
Defining a domain with a SCSI disk attached via a hostdev
tag and a source address unit value longer than two digits
causes an error when editing the domain with virsh edit,
even if no changes are made
The logical unit field is an unsigned integer, we should
use the appropriate substitution when printing it.
Signed-off-by: Eric Farman far...@linux.vnet.ibm.com
---
src/conf/domain_audit.c | 2 +-
src/conf/domain_conf.c | 2 +-
src/qemu/qemu_hotplug.c | 4 ++--
src/util/virhostdev.c | 6
://www.redhat.com/archives/libvir-list/2015-June/msg00489.html
Eric Farman (5):
Print SCSI logical unit as a positive integer
Print SCSI logical unit as unsigned integer
Convert SCSI logical unit from int to long long
docs: Fix XML schema handling of LUN address in hostdev tag
docs: Correct
A logical unit address is a positive integer, so it would be wise
to reject any negative inputs.
Signed-off-by: Eric Farman far...@linux.vnet.ibm.com
---
src/conf/domain_conf.c | 2 +-
tools/virsh-domain.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/conf
-off-by: Eric Farman far...@linux.vnet.ibm.com
Reviewed-by: Matthew Rosato mjros...@linux.vnet.ibm.com
Reviewed-by: Stefan Zimmermann s...@linux.vnet.ibm.com
Reviewed-by: Boris Fiuczynski fiu...@linux.vnet.ibm.com
---
docs/formatdomain.html.in | 6 +-
docs/schemas/domaincommon.rng | 14
The type='scsi' parameter of an address element is ignored
if placed within a hostdev section, and rejected by the XML
schema used by virt-xml-validate. Remove it from the doc,
and correct a typo in the remaining address arguments.
Signed-off-by: Eric Farman far...@linux.vnet.ibm.com
Reviewed
The SCSI Architecture Model defines a logical unit address
as 64-bits in length, so change the field accordingly so
that the entire value could be stored.
Signed-off-by: Eric Farman far...@linux.vnet.ibm.com
---
src/conf/domain_audit.c | 2 +-
src/conf/domain_conf.c | 4 ++--
src/conf
On 06/15/2015 05:03 PM, John Ferlan wrote:
Something I didn't catch on pass1, but perhaps an important distinction
title:
Resolve issues with SCSI LUN hostdev device addressing
Sounds good! I'll work that into the split patches.
Coincidentally - there's a bz regarding the address
On 06/12/2015 04:49 PM, John Ferlan wrote:
On 06/10/2015 11:22 AM, Eric Farman wrote:
Defining a domain with a SCSI disk attached via a hostdev
tag and a source address unit value longer than two digits
causes an error when editing the domain with virsh edit,
even if no changes are made
both the validation utility
and the virsh edit command to succeed when a hostdev
tag is included.
Signed-off-by: Eric Farman far...@linux.vnet.ibm.com
Reviewed-by: Matthew Rosato mjros...@linux.vnet.ibm.com
Reviewed-by: Stefan Zimmermann s...@linux.vnet.ibm.com
Reviewed-by: Boris Fiuczynski fiu
On 08/01/2016 04:08 AM, Michal Privoznik wrote:
On 25.07.2016 22:48, Eric Farman wrote:
This patch series provides a libvirt implementation of the vhost-scsi
interface in QEMU. As near as I can see, this was discussed upstream in
July 2014[1], and ended in a desire to replace a vhost-scsi
is not specified, we need to be sure to allocate one so that
we can avoid polluting the device numbers with silently-created
entries.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com
Add an example of the vhost-scsi hostdev tag, and its associated
definitions, to the domain XML helpfile.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com>
Reviewed-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com>
The idea of vhost-scsi is to have a controller-less host device that
carries all LUNs, so (silently) creating a virtio-scsi controller is
not necessary here. Let's get adjust the comparison so we don't
accidentally make one.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Re
Let's adjust some of the indentation in the command line code for the
upcoming vhost-scsi support, so we can keep existing code separate
from the new code that we'll add.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com>
-
When issuing virsh dumpxml and parsing a hostdev element,
the vhost-scsi protocol needs to be handled separately from
the existing options, to create valid XML.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com>
Reviewed-by: Bori
/2014-July/msg01235.html
[2] http://www.redhat.com/archives/libvir-list/2014-July/msg01390.html
Eric Farman (19):
conf: Add definitions for "vhost" protocol in hostdev tags
util: Allow a vhost protocol for scsi hostdev
security: Allow a vhost protocol for scsi host
so that shutting down the
guest cleans up the host cgroup entries and allows future guests to use
vhost-scsi devices. (Otherwise the guest will silently end.)
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com>
Reviewed-by: Boris
Let's adjust some of the indentation in the hotplug code for the
upcoming vhost-scsi support, so we can keep existing code separate
from the new code that we'll add.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com>
Revie
Make sure that the new vhost protocol does not drive the existing
virtio SCSI code.
Also, do a little minor formatting in virHostdevReAttachSCSIDevices,
to match the similar functions elsewhere.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynsk
.vnet.ibm.com>
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com>
---
src/conf/domain_conf.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index d6b9c42..b
Do all the stuff for the vhost-scsi capability in QEMU,
so it's in place for our checks later.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com>
---
src/qemu/qemu_capabilities.c| 2
Validate an XML schema that contains the vhost protocol in its
hostdev tag.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com>
---
docs/schemas/domaincommon.rng |
Add code that will permit a hostdev tag to specify a vhost protocol,
and parse the associated XML within it. But don't do anything with
that information just yet.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com>
Review
Make sure that the new vhost protocol does not drive the existing
virtio SCSI code.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com>
Reviewed-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com>
Reviewed-by: Bor
We're going to make some changes here, and the boolean logic
does not lend itself to be easily expanded.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com>
---
sr
Since the vhost-scsi protocol for hostdev tags has no child
elements within its source tag, we can use a self-closing
source tag to make the resulting XML a little cleaner.
Suggested-by: Bjoern Walk <bw...@linux.vnet.ibm.com>
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com&
a vhost-scsi-ccw device in the case of an s390 machine, or
vhost-scsi-pci for any others.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com>
---
src/libvirt_private.syms | 1 +
src/qemu/qemu_com
The qemuxml2argv test was cloned from hostdev-scsi-virtio-scsi
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com>
---
.../qemuxml2argv-hostdev-scsi-vhost-scsi.args | 24
.../qemuxml2argv-hostde
Make sure that the new vhost protocol does not drive the existing
virtio SCSI code.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com>
---
src/qemu/qemu_cgroup.c |
Add some vhost definitions, in preparation for a new protocol that
will allow vhost-scsi devices to be specified on a hostdev tag.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com>
Reviewed-by: Marc Hartmayer <mhart...@lin
On 08/01/2016 08:07 AM, Eric Farman wrote:
On 08/01/2016 04:08 AM, Michal Privoznik wrote:
On 25.07.2016 22:48, Eric Farman wrote:
This patch series provides a libvirt implementation of the vhost-scsi
interface in QEMU. As near as I can see, this was discussed
upstream in
July 2014[1
On 08/09/2016 10:54 AM, Daniel P. Berrange wrote:
On Tue, Aug 09, 2016 at 10:44:44AM -0400, Eric Farman wrote:
On 08/09/2016 08:22 AM, Daniel P. Berrange wrote:
+
+
+
I'm not sure this syntax really makes sense.
IIRC, currently is used to passthrough an individual
SCSI LUNs
On 08/09/2016 08:22 AM, Daniel P. Berrange wrote:
On Tue, Aug 09, 2016 at 02:13:29PM +0200, Michal Privoznik wrote:
On 25.07.2016 22:48, Eric Farman wrote:
The qemuxml2argv test was cloned from hostdev-scsi-virtio-scsi
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Re
On 08/09/2016 08:13 AM, Michal Privoznik wrote:
On 25.07.2016 22:48, Eric Farman wrote:
So, I went through the patches. They look okay. But require some
polishing before they can be merged.
Your review and feedback is much appreciated, thank you! I'll get a v2
up as soon as I can, thought
a vhost-scsi-ccw device in the case of an s390 machine, or
vhost-scsi-pci for any others.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
---
src/libvirt_private.syms | 1 +
src/qemu/qemu_command.c | 80
src/qemu/qemu_command.h
so that shutting down the
guest cleans up the host cgroup entries and allows future guests to use
vhost-scsi devices. (Otherwise the guest will silently end.)
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
---
src/conf/domain_conf.c | 6 ++
src/qemu/qemu_hotplu
[2] http://www.redhat.com/archives/libvir-list/2014-July/msg01390.html
Eric Farman (5):
Introduce a "scsi_host" hostdev type
qemu: Introduce vhost-scsi capability
qemu: Add vhost-scsi string for -device parameter
qemu: Allow hotplug of vhost-scsi device
tests: Introduce basic vhost-sc
associated documentation and XML schema information.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
---
docs/formatdomain.html.in | 24
docs/schemas/domaincommon.rng | 23 +++
src/conf/domain_audit.c | 2 ++
src/conf/domain_conf.c
The qemuxml2argv test was cloned from hostdev-scsi-virtio-scsi
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com>
---
.../qemuxml2argv-hostdev-scsi-vhost-scsi.args | 24
.../qemuxml2argv-hostde
Do all the stuff for the vhost-scsi capability in QEMU,
so it's in place for our checks later.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com>
---
src/qemu/qemu_capabilities.c| 2
On 08/09/2016 08:13 AM, Michal Privoznik wrote:
On 25.07.2016 22:48, Eric Farman wrote:
In the case of other SCSI host devices, the device that is created
within the guest will be within the usual SCSI namespace
(e.g., host:bus:target:lun). But for vhost-scsi, the actual naming
structure
Do all the stuff for the vhost-scsi capability in QEMU,
so it's in place for our checks later.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com>
---
src/qemu/qemu_capabilities.c| 3 +
a vhost-scsi-ccw device in the case of an s390 machine, or
vhost-scsi-pci for any others.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
---
src/libvirt_private.syms | 1 +
src/qemu/qemu_command.c | 80
src/qemu/qemu_command.h
associated documentation and XML schema information.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
---
docs/formatdomain.html.in | 24
docs/schemas/domaincommon.rng | 23 +++
src/conf/domain_audit.c | 2 ++
src/conf/domain_conf.c
so that shutting down the
guest cleans up the host cgroup entries and allows future guests to use
vhost-scsi devices. (Otherwise the guest will silently end.)
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
---
src/conf/domain_conf.c | 6 ++
src/qemu/qemu_hotplu
The qemuxml2argv test was cloned from hostdev-scsi-virtio-scsi
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com>
---
.../qemuxml2argv-hostdev-scsi-vhost-scsi.args | 24
.../qemuxml2argv-hostde
orts multiple vhostfds)
- Replaced "qemuMonitorAddDevice" with "qemuMonitorAddDeviceWithFd"
in hotplug routine
v1: https://www.redhat.com/archives/libvir-list/2016-July/msg01004.html
[1] http://www.redhat.com/archives/libvir-list/2014-July/msg01235.html
[2] http://www.redhat.com/a
On 09/06/2016 08:58 AM, Eric Farman wrote:
[Resending after the release of 2.2.0; no changes other than a rebase
to current master and the associated tweaking to the capabilities patch]
Ping?
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir
On 09/12/2016 06:10 PM, John Ferlan wrote:
On 09/06/2016 08:58 AM, Eric Farman wrote:
Open /dev/vhost-scsi, and record the resulting file descriptor, so that
the guest has access to the host device outside of the libvirt daemon.
Pass this information, along with data parsed from the XML file
On 09/12/2016 05:34 PM, John Ferlan wrote:
On 09/06/2016 08:58 AM, Eric Farman wrote:
We already have a "scsi" hostdev type, which refers to a single LUN
that is passed through to a guest. But what of things where multiple
LUNs are passed through via a single SCSI HBA, such as with
On 09/13/2016 04:49 PM, John Ferlan wrote:
[...]
I took a peek at the v1, but suffice to say didn't follow it that
closely since there's a number of changes in v2 related to patch
ordering. You could get 3 different opinions on that matter too!
Hopefully a consensus before too long. :)
On 09/13/2016 05:48 PM, Eric Farman wrote:
On 09/13/2016 04:49 PM, John Ferlan wrote:
[...]
Thanks for the review. (Silent ACK on a lot of the above comments.)
I'll try to get these all in place for a v3 with a little runway before
the next freeze.
OK - hopefully I won't be neck deep
On 09/13/2016 04:55 PM, John Ferlan wrote:
[...]
diff --git a/src/util/virscsi.c b/src/util/virscsi.c
index 4843367..290b692 100644
--- a/src/util/virscsi.c
+++ b/src/util/virscsi.c
@@ -105,6 +105,32 @@ virSCSIDeviceGetAdapterId(const char *adapter,
return -1;
}
+int
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
---
docs/schemas/domaincommon.rng | 23
src/conf/domain_audit.c | 7
src/conf/domain_conf.c| 81 +--
3 files changed, 109 insertions(+), 2 deletions(-)
diff
a vhost-scsi-ccw device in the case of an s390 machine, or
vhost-scsi-pci for any others.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
---
src/qemu/qemu_cgroup.c | 32 +
src/qemu/qemu_command.c| 79 ++
sr
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
---
docs/formatdomain.html.in | 24
1 file changed, 24 insertions(+)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 11b3330..ed96ca4 100644
--- a/docs/formatdomain.html.in
+++
These tests were cloned from hostdev-scsi-virtio-scsi in both
xml2argv and xml2xml
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com>
---
.../qemuxml2argv-hostdev-scsi-vhost-scsi.args | 24 +
.../qemuxml2
As was suggested in an earlier review comment[1], we can
catch some additional code points by cleaning up how we use the
hostdev subsystem type in some switch statements.
[1] End of
https://www.redhat.com/archives/libvir-list/2016-September/msg00399.html
Signed-off-by: Eric Farman <
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
---
src/security/security_apparmor.c | 18 -
src/security/security_dac.c | 42 ++--
src/security/security_selinux.c | 39 +++--
3 files chang
so that shutting down the
guest cleans up the host cgroup entries and allows future guests to use
vhost-scsi devices. (Otherwise the guest will silently end.)
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
---
src/qemu/qemu_hotplug.c | 158 +++
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
---
po/POTFILES.in | 1 +
src/Makefile.am | 1 +
src/libvirt_private.syms | 19 +++
src/util/virhost.c | 299 +++
src/util/virhost.h | 72
sr
Do all the stuff for the vhost-scsi capability in QEMU,
so it's in place for our checks later.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com>
---
src/qemu/qemu_capabilities.c| 2
We already have a "scsi" hostdev type, which refers to a single LUN
that is passed through to a guest. But what of things where multiple
LUNs are passed through via a single SCSI HBA, such as with the
vhost-scsi target? Create a new hostdev type that will carry this.
Signed-off-by: E
tember/msg00148.html
v2:https://www.redhat.com/archives/libvir-list/2016-August/msg01028.html
v1:https://www.redhat.com/archives/libvir-list/2016-July/msg01004.html
[1] http://www.redhat.com/archives/libvir-list/2014-July/msg01235.html
[2] http://www.redhat.com/archives/libvir-list/2014-July/
On 11/11/2016 04:40 PM, John Ferlan wrote:
On 11/08/2016 01:26 PM, Eric Farman wrote:
Do all the stuff for the vhost-scsi capability in QEMU,
so it's in place for our checks later.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynsk
On 11/11/2016 04:41 PM, John Ferlan wrote:
s/$SUBJ/Introduce framework for hostdev SCSI_Host subsys type
On 11/08/2016 01:26 PM, Eric Farman wrote:
We already have a "scsi" hostdev type, which refers to a single LUN
that is passed through to a guest. But what of things where mul
On 11/11/2016 04:47 PM, John Ferlan wrote:
On 11/08/2016 01:26 PM, Eric Farman wrote:
Adjust the device string that is built for vhost-scsi devices so that it
can be invoked from hotplug.
>From the QEMU command line, the file descriptors are expect to be numeric only.
s/>//
Look
On 11/11/2016 04:44 PM, John Ferlan wrote:
While perhaps mostly obvious - you need some sort of commit message here.
On 11/08/2016 01:26 PM, Eric Farman wrote:
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
---
po/POTFILES.in | 1 +
src/Makefile.am
On 11/22/2016 04:12 PM, John Ferlan wrote:
On 11/21/2016 10:58 PM, Eric Farman wrote:
With the QEMU components in place, provide the XML parsing to
invoke that code when given the following XML snippet:
An optional address element can be specified within the hostdev
On 11/22/2016 04:08 PM, John Ferlan wrote:
[...]
void
+qemuHostdevReAttachSCSIVHostDevices(virQEMUDriverPtr driver,
+const char *name,
+virDomainHostdevDefPtr *hostdevs,
+int
On 11/22/2016 04:16 PM, John Ferlan wrote:
On 11/21/2016 10:58 PM, Eric Farman wrote:
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
---
docs/formatdomain.html.in | 24
1 file changed, 24 insertions(+)
This will get squashed in with the conf patch
$ virsh detach-device guest_one_virtio_scsi scsicontroller.xml
Device detached successfully
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com>
---
src/qemu/q
I believe this is still the preferred method... Could I please have an
account "farman" for the libvirt wiki, in order to contribute some of
the cover-letter "howto" information from the recent vhost-scsi series?
Thanks,
- Eric
--
libvir-list mailing list
libvir-list@redhat.com
"SCSIHost" to refer to
a hostdev type='scsi' protcol='none'.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
---
po/POTFILES.in | 1 +
src/Makefile.am | 1 +
src/libvirt_private.syms | 18 +++
src/util/virhostdev.c| 163
These tests were cloned from hostdev-scsi-virtio-scsi in both
xml2argv and xml2xml
We add ones for both vhost-scsi-ccw and vhost-scsi-pci since
the syntaxes are slightly different between them.
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynsk
With the QEMU components in place, provide the XML parsing to
invoke that code when given the following XML snippet:
An optional address element can be specified within the hostdev
(pick CCW or PCI as necessary):
Signed-off-by: Eric Farman <
Signed-off-by: Eric Farman <far...@linux.vnet.ibm.com>
---
src/conf/domain_conf.c | 11 ++-
src/conf/domain_conf.h | 18 ++
src/qemu/qemu_cgroup.c | 7 +++
src/qemu/qemu_hotplug.c | 2 ++
src/security/security_ap
1 - 100 of 171 matches
Mail list logo
