Re: [libvirt] [libvirt-designer] [PATCH] Show also short-ids when calling --list-{os, platform}

2014-10-22 Thread Fabiano Fidêncio
Eric, On Wed, 2014-10-22 at 11:55 -0600, Eric Blake wrote: On 10/22/2014 08:16 AM, Fabiano Fidêncio wrote: As the short-id can be used to set the os/platform in the example program, let's expose them to the user. --- examples/virt-designer.c | 16 ++-- 1 file changed, 10

[libvirt] [RFC] [libvirt-gconfig] Suggestion about (maybe) re-factoring GVirtConfigDomainGraphics

2016-02-29 Thread Fabiano Fidêncio
de for this, but not before we discuss and set a decision about the approach. :-) I'm looking forward for some feedback. -- Fabiano Fidêncio -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [libvirt-glib/libvirt-gconfig 05/17] gconfig: Implement gvir_config_domain_graphics_sdl_get_fullscreen()

2016-03-22 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio <fiden...@redhat.com> --- libvirt-gconfig/libvirt-gconfig-domain-graphics-sdl.c | 10 ++ libvirt-gconfig/libvirt-gconfig-domain-graphics-sdl.h | 1 + libvirt-gconfig/libvirt-gconfig.sym | 1 + 3 files changed, 12 insertions(+)

[libvirt] [libvirt-glib/libvirt-gconfig 12/17] gconfig: Adapt GVirConfigDomainGraphicsRdp to GVirConfigDomainGraphicsRemote

2016-03-22 Thread Fabiano Fidêncio
breakage. Signed-off-by: Fabiano Fidêncio <fiden...@redhat.com> --- libvirt-gconfig/libvirt-gconfig-domain-graphics-rdp.c | 11 --- libvirt-gconfig/libvirt-gconfig-domain-graphics-rdp.h | 4 ++-- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/libvirt-gconfig/libvirt-g

[libvirt] [libvirt-glib/libvirt-gconfig 14/17] gconfig: Add GVirCofigDomainGraphicsLocal class

2016-03-22 Thread Fabiano Fidêncio
GVirConfigDomainGraphicsLocal (see the next patches), which inherits from GVirConfigDomainGraphics (it will cause ABI breakages, though). Signed-off-by: Fabiano Fidêncio <fiden...@redhat.com> --- libvirt-gconfig/Makefile.am| 2 + .../libvirt-gconfig-domain-graphics-l

[libvirt] [libvirt-glib/libvirt-gconfig 00/17] Graphics: Introduce the new Remote and Local classes (and also implement a few missing methods).

2016-03-22 Thread Fabiano Fidêncio
case (see more explanations on the 10th and 14th commits. This series, unfortunately, introduces an ABI breakage. Fabiano Fidêncio (17): gconfig: Implement gvir_config_domain_graphics_vnc_get_autoport() gconfig: Implement gvir_config_domain_graphics_spice_get_autoport() gconfig:

[libvirt] [libvirt-glib/libvirt-gconfig 08/17] gconfig: Implement gvir_config_domain_graphics_vnc_{get, set}_host()

2016-03-22 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio <fiden...@redhat.com> --- libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c | 18 ++ libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.h | 4 libvirt-gconfig/libvirt-gconfig.sym | 2 ++ 3 files changed, 24 inse

[libvirt] [libvirt-glib/libvirt-gconfig 15/17] gconfig: Adapt GVirConfigDomainGraphicsSdl to GVirConfigDomainGraphicsLocal

2016-03-22 Thread Fabiano Fidêncio
an ABI breakage. Signed-off-by: Fabiano Fidêncio <fiden...@redhat.com> --- libvirt-gconfig/libvirt-gconfig-domain-graphics-sdl.c | 11 +++ libvirt-gconfig/libvirt-gconfig-domain-graphics-sdl.h | 4 ++-- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/libvirt-gconfig/l

[libvirt] [libvirt-glib/libvirt-gconfig 06/17] gconfig: Implement gvir_config_domain_graphics_spice_get_tls_port()

2016-03-22 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio <fiden...@redhat.com> --- libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c | 8 libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.h | 1 + libvirt-gconfig/libvirt-gconfig.sym | 1 + 3 files changed, 10 insertions(+)

[libvirt] [libvirt-glib/libvirt-gconfig 11/17] gconfig: Adapt GVirConfigDomainGraphicsSpice to GVirConfigDomainGraphicsRemote

2016-03-22 Thread Fabiano Fidêncio
an ABI breakage. Signed-off-by: Fabiano Fidêncio <fiden...@redhat.com> --- libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c | 11 --- libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.h | 4 ++-- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/libvirt-gconfig/l

[libvirt] [libvirt-glib/libvirt-gconfig 17/17] gconfig, graphics: Avoid crash when gvir_config_object_new_from_xml() returns NULL

2016-03-22 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio <fiden...@redhat.com> --- libvirt-gconfig/libvirt-gconfig-domain-graphics-desktop.c | 3 +++ libvirt-gconfig/libvirt-gconfig-domain-graphics-rdp.c | 3 +++ libvirt-gconfig/libvirt-gconfig-domain-graphics-sdl.c | 3 +++ libvirt-gconfig/libvirt-gconfig-

[libvirt] [libvirt-glib/libvirt-gconfig 10/17] gconfig: Add GVirCofigDomainGraphicsRemote class

2016-03-22 Thread Fabiano Fidêncio
icense for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Author: Fabiano Fidêncio <fiden...@redhat.com> + */ + +#include + +#include + +#include "

[libvirt] [libvirt-glib/libvirt-gconfig 01/17] gconfig: Implement gvir_config_domain_graphics_vnc_get_autoport()

2016-03-22 Thread Fabiano Fidêncio
For completeness and also because it's useful for libvirt-gconfig API's consumers who are interested on reading the guest configuration, like virt-viewer. Signed-off-by: Fabiano Fidêncio <fiden...@redhat.com> --- libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c | 8 libvirt-g

[libvirt] [libvirt-glib/libvirt-gconfig 16/17] gconfig: Adapt GVirConfigDomainGraphicsDesktop to GVirConfigDomainGraphicsLocal

2016-03-22 Thread Fabiano Fidêncio
introduces an ABI breakage. Signed-off-by: Fabiano Fidêncio <fiden...@redhat.com> --- libvirt-gconfig/libvirt-gconfig-domain-graphics-desktop.c | 11 +++ libvirt-gconfig/libvirt-gconfig-domain-graphics-desktop.h | 4 ++-- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/l

[libvirt] [libvirt-glib/libvirt-gconfig 09/17] gconfig: Implement gvir_config_domain_graphics_rdp_{get, set}_host()

2016-03-22 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio <fiden...@redhat.com> --- libvirt-gconfig/libvirt-gconfig-domain-graphics-rdp.c | 18 ++ libvirt-gconfig/libvirt-gconfig-domain-graphics-rdp.h | 4 libvirt-gconfig/libvirt-gconfig.sym | 2 ++ 3 files changed, 24 inse

[libvirt] [libvirt-glib/libvirt-gconfig 13/17] gconfig: Adapt GVirConfigDomainGraphicsVnc to GVirConfigDomainGraphicsRemote

2016-03-22 Thread Fabiano Fidêncio
breakage. Signed-off-by: Fabiano Fidêncio <fiden...@redhat.com> --- libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c | 11 --- libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.h | 4 ++-- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/libvirt-gconfig/libvirt-g

[libvirt] [libvirt-glib/libvirt-gconfig 02/17] gconfig: Implement gvir_config_domain_graphics_spice_get_autoport()

2016-03-22 Thread Fabiano Fidêncio
For completeness and also because it's useful for libvirt-gconfig API's consumers who are interested on reading the guest configuration, like virt-viewer. Signed-off-by: Fabiano Fidêncio <fiden...@redhat.com> --- libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c | 8 l

[libvirt] [libvirt-glib/libvirt-gconfig 03/17] gconfig: Implement gvir_config_domain_graphics_rdp_get_autoport()

2016-03-22 Thread Fabiano Fidêncio
For completeness and also because it's useful for libvirt-gconfig API's consumers who are interested on reading the guest configuration, like virt-viewer. Signed-off-by: Fabiano Fidêncio <fiden...@redhat.com> --- libvirt-gconfig/libvirt-gconfig-domain-graphics-rdp.c | 8 libvirt-g

[libvirt] [libvirt-glib/libvirt-gconfig 04/17] gconfig: Implement gvir_config_domain_graphics_sdl_get_display()

2016-03-22 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio <fiden...@redhat.com> --- libvirt-gconfig/libvirt-gconfig-domain-graphics-sdl.c | 9 + libvirt-gconfig/libvirt-gconfig-domain-graphics-sdl.h | 1 + libvirt-gconfig/libvirt-gconfig.sym | 1 + 3 files changed, 11 insertions(+) diff

[libvirt] [libvirt-glib/libvirt-gconfig 07/17] gconfig: Implement gvir_config_domain_graphics_spice_{get, set}_host()

2016-03-22 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio <fiden...@redhat.com> --- .../libvirt-gconfig-domain-graphics-spice.c| 18 ++ .../libvirt-gconfig-domain-graphics-spice.h| 4 libvirt-gconfig/libvirt-gconfig.sym| 2 ++ 3 files chang

[libvirt] [libvirt-glib] gconfig: Fix next API version number

2016-03-04 Thread Fabiano Fidêncio
Commit 01e01f2 introduced a wrong next API version number in libvirt-gconfig.sym Signed-off-by: Fabiano Fidêncio <fiden...@redhat.com> --- libvirt-gconfig/libvirt-gconfig.sym | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-gconfig/libvirt-gconfig.sym b/l

[libvirt] build: workaround broken SASL header (again)

2016-03-30 Thread Fabiano Fidêncio
Compilation for xdg-app failed due to a buggy SASL headers present on the used runtime (org.gnome.Sdk 3.18). In file included from rpc/virnetsaslcontext.h:24:0, from rpc/virnetsaslcontext.c:25: /usr/include/sasl/sasl.h:230:38: error: unknown type name 'size_t' typedef void

[libvirt] [PATCH 2/3] vmx: convert to typesafe virConf accessors

2018-05-25 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio <fabi...@fidencio.org> --- src/vmx/vmx.c | 197 +++--- 1 file changed, 73 insertions(+), 124 deletions(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index df6a58a47..6247fa938 100644 --- a/src/vmx/vmx.c +++ b/s

[libvirt] [PATCH 3/3] xen_common: convert to typesafe virConf accessors

2018-05-25 Thread Fabiano Fidêncio
as other types (as boolean or long) doesn't seem to be the safest path to take. Signed-off-by: Fabiano Fidêncio <fabi...@fidencio.org> --- src/xenconfig/xen_common.c | 631 ++--- 1 file changed, 299 insertions(+), 332 deletions(-) diff --git a/src/xen

[libvirt] [PATCH 0/3] Finish the conversion to virConfGetValue* functions

2018-05-25 Thread Fabiano Fidêncio
. The side-effect of this is that we will have to live with some specific code doing that as part of vmx and xen_common. Fabiano Fidêncio (3): xen_vm: convert to typesafe virConf accessors vmx: convert to typesafe virConf accessors xen_common: convert to typesafe virConf accessors src/vmx/vmx.c

[libvirt] [PATCH 1/3] xen_vm: convert to typesafe virConf accessors

2018-05-25 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio <fabi...@fidencio.org> --- src/xenconfig/xen_xm.c | 268 - 1 file changed, 132 insertions(+), 136 deletions(-) diff --git a/src/xenconfig/xen_xm.c b/src/xenconfig/xen_xm.c index 4becb40b4..fc88ac823 100644 ---

Re: [libvirt] [PATCH 0/3] Finish the conversion to virConfGetValue* functions

2018-05-25 Thread Fabiano Fidêncio
On Fri, May 25, 2018 at 3:27 PM, Fabiano Fidêncio <fiden...@redhat.com> wrote: > This patchset finishes the conversion to virConfGetValue* functions, > started by Daniel Berrange a few months ago. > > Please, mind that although we could make virConfGetValue* functions more

Re: [libvirt] [PATCHv3 0/7] Finish the conversion to virConfGetValue* functions

2018-06-11 Thread Fabiano Fidêncio
On Mon, Jun 11, 2018 at 3:34 PM, Ján Tomko wrote: > On Mon, May 28, 2018 at 12:28:19AM +0200, Fabiano Fidêncio wrote: >> >> This patchset finishes the conversion to virConfGetValue* functions, >> started by Daniel Berrange a few months ago. >> >> Please,

[libvirt] [PATCH v4 0/2] Finish the conversion to virConfGetValue* functions

2018-06-13 Thread Fabiano Fidêncio
the non-whitespace changes in the first patch; Fabiano Fidêncio (2): xen_common: Split per-Vif logic from xenParseVif() xen_common: convert to typesafe virConf acessors src/xenconfig/xen_common.c | 535 +++-- 1 file changed, 273 insertions(+), 262

[libvirt] [PATCH v4 1/2] xen_common: Split per-Vif logic from xenParseVif()

2018-06-13 Thread Fabiano Fidêncio
xenParsePCI(), but now it just iterates over the list of Vifs, calling xenParsePCI() per each Vif. This patch is basically preparing the ground for the future when typesafe virConf acessors will be used. Signed-off-by: Fabiano Fidêncio --- src/xenconfig/xen_common.c | 358

[libvirt] [PATCH v4 2/2] xen_common: convert to typesafe virConf acessors

2018-06-13 Thread Fabiano Fidêncio
for whoever has to debug this code path; - Expanding virConfValue*() to support strings as other types (for instance, as boolean or long) does not seem to be the safest path to take. Signed-off-by: Fabiano Fidêncio --- src/xenconfig/xen_common.c | 197 ++--- 1

[libvirt] [PATCHv2 2/3] vmx: convert to typesafe virConf accessors

2018-05-26 Thread Fabiano Fidêncio
From: Fabiano Fidêncio <fiden...@redhat.com> Signed-off-by: Fabiano Fidêncio <fabi...@fidencio.org> --- src/vmx/vmx.c | 196 ++ 1 file changed, 73 insertions(+), 123 deletions(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c inde

[libvirt] [PATCHv2 0/3] Finish the conversion to virConfGetValue* functions

2018-05-26 Thread Fabiano Fidêncio
alues" from virConfGetValueString() are freed Fabiano Fidêncio (3): xen_vm: convert to typesafe virConf accessors vmx: convert to typesafe virConf accessors xen_common: convert to typesafe virConf accessors src/vmx/vmx.c | 196 ++ src/xenconfig/xen_comm

[libvirt] [PATCHv2 1/3] xen_vm: convert to typesafe virConf accessors

2018-05-26 Thread Fabiano Fidêncio
From: Fabiano Fidêncio <fiden...@redhat.com> Signed-off-by: Fabiano Fidêncio <fabi...@fidencio.org> --- src/xenconfig/xen_xm.c | 268 - 1 file changed, 132 insertions(+), 136 deletions(-) diff --git a/src/xenconfig/xen_xm.c b/s

[libvirt] [PATCHv2 3/3] xen_common: convert to typesafe virConf accessors

2018-05-26 Thread Fabiano Fidêncio
From: Fabiano Fidêncio <fiden...@redhat.com> There are still some places using virConfGetValue() and then checking the specific type of the pointers and so on. Those place are not going to be changed as: - Directly using virConfGetValue*() would trigger virReportError() on their curren

Re: [libvirt] [PATCHv2 3/3] xen_common: convert to typesafe virConf accessors

2018-05-27 Thread Fabiano Fidêncio
On Sun, May 27, 2018 at 1:17 PM, Ján Tomko <jto...@redhat.com> wrote: > On Sat, May 26, 2018 at 11:00:27PM +0200, Fabiano Fidêncio wrote: >> >> From: Fabiano Fidêncio <fiden...@redhat.com> >> >> There are still some places using virConfGetValue()

Re: [libvirt] [PATCHv2 2/3] vmx: convert to typesafe virConf accessors

2018-05-27 Thread Fabiano Fidêncio
On Sun, May 27, 2018 at 1:02 PM, Ján Tomko <jto...@redhat.com> wrote: > On Sat, May 26, 2018 at 11:00:26PM +0200, Fabiano Fidêncio wrote: >> >> From: Fabiano Fidêncio <fiden...@redhat.com> >> >> Signed-off-by: Fabiano Fidêncio <fabi...@f

Re: [libvirt] [PATCHv2 3/3] xen_common: convert to typesafe virConf accessors

2018-05-28 Thread Fabiano Fidêncio
On Mon, May 28, 2018 at 9:16 AM, Ján Tomko <jto...@redhat.com> wrote: > On Sun, May 27, 2018 at 02:08:58PM +0200, Fabiano Fidêncio wrote: >> >> On Sun, May 27, 2018 at 1:17 PM, Ján Tomko <jto...@redhat.com> wrote: >>> >>> On Sat, May 26, 201

[libvirt] [PATCH 2/2] vircgroup: Add virCgroupSetupMemtune()

2018-06-03 Thread Fabiano Fidêncio
virCgroupSetupMemtune() has been introduced in order to remove the code duplication present between virLXCCgroupSetupMemTune() and qemuSetupMemoryCgroup(). Signed-off-by: Fabiano Fidêncio --- src/libvirt_private.syms | 1 + src/lxc/lxc_cgroup.c | 20 ++-- src/qemu

[libvirt] [PATCH 0/2] Share cgroup code that is duplicated between QEMU and LXC

2018-06-03 Thread Fabiano Fidêncio
virLXCCgroupSetupBlkioTune() and qemuSetupBlkioCgroup() and virLXCCgroupSetupCpuTune() and qemuSetupCpuCgroup() are the most similar functions between QEMU and LXC code. Let's move their common code to virCgroup. Fabiano Fidêncio (2): vircgroup: Add virCgroupSetupBlkiotune() vircgroup: Add

[libvirt] [PATCH 1/2] vircgroup: Add virCgroupSetupBlkiotune()

2018-06-03 Thread Fabiano Fidêncio
virCgroupSetupBlkiotune() has been introduced in order to remove the code duplication present between virLXCCgroupSetupBlkioTune() and qemuSetupBlkioCgroup(). Signed-off-by: Fabiano Fidêncio --- src/libvirt_private.syms | 1 + src/lxc/lxc_cgroup.c | 49

Re: [libvirt] [PATCH 1/2] vircgroup: Add virCgroupSetupBlkiotune()

2018-06-05 Thread Fabiano Fidêncio
On Tue, Jun 5, 2018 at 4:16 PM, Michal Privoznik wrote: > On 06/03/2018 08:09 PM, Fabiano Fidêncio wrote: >> virCgroupSetupBlkiotune() has been introduced in order to remove the >> code duplication present between virLXCCgroupSetupBlkioTune() and >> qemuSetupBlkioCgrou

[libvirt] [PATCHv3 5/7] xen_common: Split per-Vfi logic from xenParseVif()

2018-05-27 Thread Fabiano Fidêncio
xenParsePCI(), but now it just iterates over the list of Vfis, calling xenParsePCI() per each Vfi. This patch is basically preparing the ground for the future when typesafe virConf acessors will be used. Signed-off-by: Fabiano Fidêncio <fabi...@fidencio.org> --- src/xenconfig/xen_common.c

[libvirt] [PATCHv3 3/7] vmx: convert to typesafe virConf accessors

2018-05-27 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio <fabi...@fidencio.org> --- src/vmx/vmx.c | 194 +- 1 file changed, 70 insertions(+), 124 deletions(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index df6a58a474..b6df257144 100644 --- a/src/vmx/vmx.c

[libvirt] [PATCHv3 2/7] xen_vm: convert to typesafe virConf accessors

2018-05-27 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio <fabi...@fidencio.org> --- src/xenconfig/xen_xm.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/src/xenconfig/xen_xm.c b/src/xenconfig/xen_xm.c index be50a13909..ef52cf4250 100644 --- a/src/xenconfig/xen_xm.c

[libvirt] [PATCHv3 4/7] xen_common: Split per-PCI logic from xenParsePCI()

2018-05-27 Thread Fabiano Fidêncio
xenParsePCI(), but now it just iterates over the list of PCIs, calling xenParsePCI() per each PCI. This patch is basically preparing the ground for the future when typesafe virConf acessors will be used. Signed-off-by: Fabiano Fidêncio <fabi...@fidencio.org> --- src/xenconfig/xen_common.c

[libvirt] [PATCHv3 0/7] Finish the conversion to virConfGetValue* functions

2018-05-27 Thread Fabiano Fidêncio
alues" from virConfGetValueString() are freed - Changes since v2: All comments from Ján Tomko have been addressed; A few leaks were (possibly) found and they're addressed in the last patch of the series; Fabiano Fidêncio (7): xen_xm: Split the per-disk logic from xenParseXMDisk() xen_v

[libvirt] [PATCHv3 7/7] xen_common: Fix a few memory leaks

2018-05-27 Thread Fabiano Fidêncio
While converting the functions of xen_common to use typesafe virConf acessors, I've spotted a few memory leaks, which are fixed in this patch. Signed-off-by: Fabiano Fidêncio <fabi...@fidencio.org> --- src/xenconfig/xen_common.c | 22 +- 1 file changed, 13 insertions

[libvirt] [PATCHv3 6/7] xen_common: convert to typesafe virConf acessors

2018-05-27 Thread Fabiano Fidêncio
for whoever has to debug this code path; - Expanding virConfValue*() to support strings as other types (for instance, as boolean or long) does not seem to be the safest path to take. Signed-off-by: Fabiano Fidêncio <fabi...@fidencio.org> --- src/xenconfig/xen_common.c

[libvirt] [PATCHv3 1/7] xen_xm: Split the per-disk logic from xenParseXMDisk()

2018-05-27 Thread Fabiano Fidêncio
the old xenParseXMDisk(), but now it just iterates over the list of disks, calling xenParseXMDisk() per each disk. This patch is basically preparing the ground for the future when typesafe virConf acessors will be used. Signed-off-by: Fabiano Fidêncio <fabi...@fidencio.org> --- src/xenconfig/xe

Re: [libvirt] [PATCHv2 1/3] xen_vm: convert to typesafe virConf accessors

2018-05-27 Thread Fabiano Fidêncio
On Sun, May 27, 2018 at 11:55 AM, Ján Tomko <jto...@redhat.com> wrote: > On Sat, May 26, 2018 at 11:00:25PM +0200, Fabiano Fidêncio wrote: >> >> From: Fabiano Fidêncio <fiden...@redhat.com> >> >> Signed-off-by: Fabiano Fidêncio <fabi...@fidencio.org>

Re: [libvirt] [PATCH 0/2] rpm: modernize the spec file for RHEL

2018-07-20 Thread Fabiano Fidêncio
com > https://www.redhat.com/mailman/listinfo/libvir-list Best Regards, -- Fabiano Fidêncio -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 2/2] docs: formatdomain: clarify period cputune subelement

2018-07-17 Thread Fabiano Fidêncio
ith value 0 means no value. You can use this feature to ensure that > all > +vcpus run at the same speed. > Only QEMU driver support since 0.9.4, LXC since > 0.9.10 > > -- > 2.17.1 > > -- > libvir-list mailing list > libvir-list@redhat.com &g

[libvirt] [jenkins-ci PATCH v2 2/2] projects: Enable {media, tree}uri tests for libosinfo

2018-09-11 Thread Fabiano Fidêncio
Both media and tree uris tests are only run when LIBOSINFO_NETWORK_TESTS is set. Let's have those enabled in order to early catch URL changes in osinfo-db. Signed-off-by: Fabiano Fidêncio --- projects/libosinfo.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/projects/libosinfo.yaml

[libvirt] [PATCH] rpm: increase min required Fedora to 27

2018-09-11 Thread Fabiano Fidêncio
Fedora 26 has reached its EOL on May 29th 2018. https://lists.fedoraproject.org/archives/list/annou...@lists.fedoraproject.org/message/XGG7GYUJN3VDA6HX4KJNFSKSQCGF2FMW/ Signed-off-by: Fabiano Fidêncio --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt] [jenkins-ci PATCH v2 0/2] Enable libosinfo tests that require network connectivity

2018-09-11 Thread Fabiano Fidêncio
Let's enable both media and tree uris tests in order to early catch URL changes that need to be fixed in osinfo-db. Fabiano Fidêncio (2): guests: Enable {media,tree}uris tests for libosinfo projects: Enable {media,tree}uri tests for libosinfo guests/playbooks/build/projects/libosinfo.yml

[libvirt] [jenkins-ci PATCH v2 1/2] guests: Enable {media, tree}uris tests for libosinfo

2018-09-11 Thread Fabiano Fidêncio
Both media and tree uris tests are only run when LIBOSINFO_NETWORK_TESTS is set. Let's have those enabled in order to early catch URL changes in osinfo-db. Signed-off-by: Fabiano Fidêncio --- guests/playbooks/build/projects/libosinfo.yml | 4 1 file changed, 4 insertions(+) diff --git

[libvirt] [libvirt PATCH v5 1/1] xen_common: Convert to typesafe virConf acessors

2018-09-11 Thread Fabiano Fidêncio
messages for whoever has to debug this code path; - Expanding virConfValue*() to support strings as other types (for instance, as boolean or long) does not seem to be neither the safest nor the preferential path to take. Signed-off-by: Fabiano Fidêncio --- src/xenconfig/xen_common.c | 163

[libvirt] [libvirt PATCH v5 0/1] Finish the conversion to virConfGetValue* functions

2018-09-11 Thread Fabiano Fidêncio
the non-whitespace changes in the first patch; - Chages since v4: All comments from Ján Tomko have been addressed (hopefully, they actually were this time :-)); Fabiano Fidêncio (1): xen_common: Convert to typesafe virConf acessors src/xenconfig/xen_comm

[libvirt] [osinfo-db-tools PATCH v2 1/2] import: Learn how to deal with URLs

2018-10-08 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio --- tools/osinfo-db-import.c | 88 ++-- 1 file changed, 84 insertions(+), 4 deletions(-) diff --git a/tools/osinfo-db-import.c b/tools/osinfo-db-import.c index 0d0bdd9..289a85d 100644 --- a/tools/osinfo-db-import.c +++ b/tools

[libvirt] [osinfo-db-tools PATCH v2 2/2] import: Remove unused variable

2018-10-08 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio --- tools/osinfo-db-import.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/osinfo-db-import.c b/tools/osinfo-db-import.c index 289a85d..c0b4931 100644 --- a/tools/osinfo-db-import.c +++ b/tools/osinfo-db-import.c @@ -193,7 +193,6 @@ static int

[libvirt] [osinfo-db-tools PATCH v2 0/2] RFC: Make osinfo-db-import aware of URLs

2018-10-08 Thread Fabiano Fidêncio
of curl; - An additional patch removing a unused var; Fabiano Fidêncio (2): import: Learn how to deal with URLs import: Remove unused variable tools/osinfo-db-import.c | 91 1 file changed, 84 insertions(+), 7 deletions(-) -- 2.19.1 -- libvir-list

Re: [libvirt] [osinfo-db-tools PATCH v2 0/2] RFC: Make osinfo-db-import aware of URLs

2018-10-08 Thread Fabiano Fidêncio
On Mon, 2018-10-08 at 10:53 +0200, Fabiano Fidêncio wrote: > This is a simple draft of a work that has been discussed back in July > as > part of this thread[0]. > > There are a few things which are not clear to me whether we want (or > whether we do *not* want). > > F

[libvirt] [glib PATCH 3/3] tests: Add testes for _domain_os_{set, get}_machine()

2018-10-11 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio --- tests/test-gconfig.c| 2 ++ tests/xml/gconfig-domain-os.xml | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/test-gconfig.c b/tests/test-gconfig.c index a64da26..3328297 100644 --- a/tests/test-gconfig.c +++ b/tests/test

[libvirt] [glib PATCH 1/3] gconfig-domain-sound: Add ich9 sound device

2018-10-11 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio --- libvirt-gconfig/libvirt-gconfig-domain-sound.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-sound.h b/libvirt-gconfig/libvirt-gconfig-domain-sound.h index 8779754..41b0122 100644 --- a/libvirt

[libvirt] [glib PATCH 2/3] gconfig: add _domain_os_get_machine()

2018-10-11 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio --- libvirt-gconfig/libvirt-gconfig-domain-os.c | 7 +++ libvirt-gconfig/libvirt-gconfig-domain-os.h | 1 + libvirt-gconfig/libvirt-gconfig.sym | 1 + 3 files changed, 9 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-os.c b/libvirt

[libvirt] [glib PATCH 0/3] Add ich9 sound device + _domain_os_get_machine()

2018-10-11 Thread Fabiano Fidêncio
. Fabiano Fidêncio (3): gconfig-domain-sound: Add ich9 sound device gconfig: add _domain_os_get_machine() tests: Add testes for _domain_os_{set,get}_machine() libvirt-gconfig/libvirt-gconfig-domain-os.c| 7 +++ libvirt-gconfig/libvirt-gconfig-domain-os.h| 1 + libvirt-gconfig

[libvirt] [glib PATCH] gconfig, gobject: Use G_DEFINE_ABSTRACT_TYPE_WITH_PRIVATE

2018-10-03 Thread Fabiano Fidêncio
st replace G_DEFINE_ABSTRACT_TYPE by G_DEFINE_ABSTRACT_TYPE_WITH_PRIVATE. Signed-off-by: Fabiano Fidêncio --- libvirt-gconfig/libvirt-gconfig-domain-address.c| 2 +- libvirt-gconfig/libvirt-gconfig-domain-chardev-source.c | 2 +- libvirt-gconfig/libvirt-gconfig-domain-chardev.c| 2 +- libvi

[libvirt] [glib PATCH 2/2] domain: Introduce gvir_config_domain_set_custom_xml_ns_children()

2018-10-03 Thread Fabiano Fidêncio
gvir_config_domain_set_custom_xml_ns_children() basically has the same functionallity as gvir_config_domain_set_custom_xml() but also sets the namespace to the nodes' children. Signed-off-by: Fabiano Fidêncio --- libvirt-gconfig/libvirt-gconfig-domain.c | 41 libvirt

[libvirt] [glib PATCH 1/2] object: Also add the ns to the node's children

2018-10-03 Thread Fabiano Fidêncio
hrough the node's children and also set the namespace for each children. Signed-off-by: Fabiano Fidêncio --- libvirt-gconfig/libvirt-gconfig-domain.c | 2 +- .../libvirt-gconfig-object-private.h | 3 +- libvirt-gconfig/libvirt-gconfig-object.c | 51 +++ 3

[libvirt] [glib PATCH 0/2] Add ns to the node's children when setting a custom XML

2018-10-03 Thread Fabiano Fidêncio
, we ensure we won't break anything there); - the new Boxes' metadata.libosinfo; - Nova's XML example; Fabiano Fidêncio (2): object: Also add the ns to the node's children domain: Introduce gvir_config_domain_set_custom_xml_ns_children() libvirt-gconfig/libvirt-gconfig-domain.c | 41

Re: [libvirt] [PATCH 25/53] vircgroup: introduce virCgroupV2SetBlkioDeviceReadIops

2018-10-05 Thread Fabiano Fidêncio
On Fri, 2018-10-05 at 09:54 +0200, Fabiano Fidêncio wrote: > On Tue, 2018-10-02 at 10:44 +0200, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > Here, again, I'd just adjust the commit log to show that you're > adding > the Get/Set instead of just the Set function.

Re: [libvirt] [PATCH 24/53] vircgroup: introduce virCgroupV2SetBlkioDeviceWeight

2018-10-05 Thread Fabiano Fidêncio
On Tue, 2018-10-02 at 10:44 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina I'd just adjust the commit log to show that you're adding the Get/Set instead of just the Set function. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 25/53] vircgroup: introduce virCgroupV2SetBlkioDeviceReadIops

2018-10-05 Thread Fabiano Fidêncio
On Tue, 2018-10-02 at 10:44 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina Here, again, I'd just adjust the commit log to show that you're adding the Get/Set instead of just the Set function. -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 42/53] vircgroup: add support for hybrid configuration

2018-10-05 Thread Fabiano Fidêncio
On Fri, 2018-10-05 at 12:14 +0200, Michal Privoznik wrote: > On 10/02/2018 10:44 AM, Pavel Hrdina wrote: > > This enables to use both cgroup v1 and v2 at the same time together > > with libvirt. It is supported by kernel and there is valid use- > > case, > > not all controllers are implemented in

[libvirt] [libvirt PATCH] news: Update for 4.8.0 release

2018-10-01 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio --- I went through the commits since last release and added a few notes which seem to be relevant for the news. In case you notice there's something missing, please, either send me the text to add it (and I'll re-sping this patch) and add the text before merging

[libvirt] [libvirt PATCH v3] news: Update for 4.8.0 release

2018-10-01 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio --- I went through the commits since last release and added a few notes which seem to be relevant for the news. In case you notice there's something missing, please, either send me the text to add it (and I'll re-sping this patch) and add the text before merging

Re: [libvirt] [libvirt PATCH] news: Update for 4.8.0 release

2018-10-01 Thread Fabiano Fidêncio
On Mon, 2018-10-01 at 11:48 +0200, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > I went through the commits since last release and added a few notes > which seem to be relevant for the news. > > In case you notice there's something missing, please, either se

[libvirt] [PATCH v2] news: Update for 4.8.0 release

2018-10-01 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio --- I went through the commits since last release and added a few notes which seem to be relevant for the news. In case you notice there's something missing, please, either send me the text to add it (and I'll re-sping this patch) and add the text before merging

[libvirt] [libvirt PATCH v4] news: Update for 4.8.0 release

2018-10-01 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio --- I went through the commits since last release and added a few notes which seem to be relevant for the news. In case you notice there's something missing, please, either send me the text to add it (and I'll re-sping this patch) and add the text before merging

Re: [libvirt] [libvirt PATCH v3] news: Update for 4.8.0 release

2018-10-01 Thread Fabiano Fidêncio
On Mon, 2018-10-01 at 15:22 +0200, Peter Krempa wrote: > On Mon, Oct 01, 2018 at 15:04:37 +0200, Fabiano Fidêncio wrote: > > Signed-off-by: Fabiano Fidêncio > > --- > > I went through the commits since last release and added a few notes > > which seem to be relevant for

Re: [libvirt] [PATCH 12/53] vircgroup: introduce virCgroupV2GetAnyController

2018-10-04 Thread Fabiano Fidêncio
On Thu, 2018-10-04 at 13:41 +0200, Pavel Hrdina wrote: > On Thu, Oct 04, 2018 at 01:18:14PM +0200, Michal Privoznik wrote: > > On 10/02/2018 10:43 AM, Pavel Hrdina wrote: > > > Signed-off-by: Pavel Hrdina > > > --- > > > src/util/vircgroupv2.c | 8 > > > 1 file changed, 8 insertions(+)

Re: [libvirt] [PATCH 17/53] vircgroup: introduce virCgroupV2HasEmptyTasks

2018-10-04 Thread Fabiano Fidêncio
On Tue, 2018-10-02 at 10:44 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/util/vircgroupv2.c | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/src/util/vircgroupv2.c b/src/util/vircgroupv2.c > index e7dbace42b..c6a9e0a7df 100644 > ---

Re: [libvirt] [PATCH 14/53] vircgroup: introduce virCgroupV2MakeGroup

2018-10-04 Thread Fabiano Fidêncio
On Tue, 2018-10-02 at 10:43 +0200, Pavel Hrdina wrote: > When creating cgroup hierarchy we need to enable controllers in the > parent cgroup in order to be usable. That means writing > "+{controller}" > into cgroup.subtree_control file. We can enable only controllers > that > are enabled for

[libvirt] [jenkins-ci PATCH 1/2] guests: enable {media, tree}uris tests for libosinfo

2018-09-03 Thread Fabiano Fidêncio
Both media and tree uris tests are only run when LIBOSINFO_NETWORK_TESTS is set. Let's have those enabled in order to early catch URL changes in osinfo-db. Signed-off-by: Fabiano Fidêncio --- guests/playbooks/build/projects/libosinfo.yml | 5 + 1 file changed, 5 insertions(+) diff --git

[libvirt] [jenkins-ci PATCH 2/2] projects: enable {media, tree}uri tests for libosinfo

2018-09-03 Thread Fabiano Fidêncio
Both media and tree uris tests are only run when LIBOSINFO_NETWORK_TESTS is set. Let's have those enabled in order to early catch URL changes in osinfo-db. Signed-off-by: Fabiano Fidêncio --- projects/libosinfo.yaml | 4 1 file changed, 4 insertions(+) diff --git a/projects

Re: [libvirt] [jenkins-ci PATCH 1/2] guests: enable {media, tree}uris tests for libosinfo

2018-09-03 Thread Fabiano Fidêncio
On Mon, Sep 3, 2018 at 5:26 PM, Andrea Bolognani wrote: > Please include a cover letter when sending more than a single > patch to libvir-list. > > On Mon, 2018-09-03 at 15:02 +0200, Fabiano Fidêncio wrote: > [...] >> - include: '{{ playbook_base }}/jobs/autotools-chec

Re: [libvirt] [PATCH v2 0/9] cgroup cleanups and preparation for v2

2018-09-20 Thread Fabiano Fidêncio
el-7.1.cgroups > create mode 100644 tests/vircgroupdata/rhel-7.1.self.cgroup > create mode 100644 tests/vircgroupdata/systemd.cgroups > create mode 100644 tests/vircgroupdata/systemd.mounts > create mode 100644 tests/vircgroupdata/systemd.self.cgroup > > -- > 2.17.1 > > -- > libvir-list mailing list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list > Reviewed-by: Fabiano Fidêncio -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH] guests: Hash test user password dynamically

2018-09-20 Thread Fabiano Fidêncio
On Tue, Sep 4, 2018 at 2:34 PM, Andrea Bolognani wrote: > Current versions of Ansible support the password_hash() > filter, so we can avoid hardcoding a pre-computed hash > and make what's happening a bit clearer. > > Signed-off-by: Andrea Bolognani > Reviewed-by

Re: [libvirt] [libvirt PATCH v7 3/6] xen_common: Change xenConfigGetString to using virConfGetValueString

2018-09-20 Thread Fabiano Fidêncio
On Thu, Sep 20, 2018 at 10:17 PM, John Ferlan wrote: > > > On 09/20/2018 09:28 AM, Fabiano Fidêncio wrote: > > This change actually changes the behaviour of xenConfigGetString() as > > now it returns a newly-allocated string. > > > > Unfortunately, there's n

Re: [libvirt] [libvirt PATCH v7 4/6] xen_common: Change xenParsePCIList to using virConfGetValueStringList

2018-09-20 Thread Fabiano Fidêncio
On Thu, Sep 20, 2018 at 10:18 PM, John Ferlan wrote: > > > On 09/20/2018 09:28 AM, Fabiano Fidêncio wrote: > > The `if(!list || list->type != VIR_CONF_LIST)` check couldn't be > > written in a 100% similar way. Instead, we're just checking whether > > `vi

Re: [libvirt] [libvirt PATCH v7 6/6] xen_common: Change xenParseCharDev to using virConfGetValueStringList

2018-09-20 Thread Fabiano Fidêncio
On Thu, Sep 20, 2018 at 10:20 PM, John Ferlan wrote: > > > On 09/20/2018 09:28 AM, Fabiano Fidêncio wrote: > > Signed-off-by: Fabiano Fidêncio > > --- > > src/xenconfig/xen_common.c | 27 +-- > > 1 file changed, 13 insertions(+), 14 dele

Re: [libvirt] [libvirt PATCH v7 5/6] xen_common: Change xenParseVfbs to using virConfGetValueStringList

2018-09-20 Thread Fabiano Fidêncio
On Thu, Sep 20, 2018 at 10:19 PM, John Ferlan wrote: > > > On 09/20/2018 09:28 AM, Fabiano Fidêncio wrote: > > Signed-off-by: Fabiano Fidêncio > > --- > > src/xenconfig/xen_common.c | 18 +++--- > > 1 file changed, 11 insertions(+), 7 deletions(-) &

Re: [libvirt] [PATCH 01/47] util: introduce vircgroupbackend files

2018-09-20 Thread Fabiano Fidêncio
l Hrdina > Reviewed-by: Fabiano Fidêncio > --- > src/Makefile.am | 1 + > src/libvirt_private.syms| 3 ++ > src/util/Makefile.inc.am| 2 ++ > src/util/vircgroupbackend.c | 64 + > src/util/vircgroupbackend.h

Re: [libvirt] [PATCH 02/47] vircgroup: introduce cgroup v1 backend files

2018-09-20 Thread Fabiano Fidêncio
f the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the im

Re: [libvirt] [PATCH 03/47] vircgroup: extract virCgroupV1Available

2018-09-20 Thread Fabiano Fidêncio
On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/util/vircgroup.c| 28 +--- > src/util/vircgroupbackend.h | 7 +++ > src/util/vircgroupv1.c | 35 +++ > 3 files changed, 51

Re: [libvirt] [PATCH 40/47] vircgroup: extract virCgroupV1GetCpuacct*Usage

2018-09-20 Thread Fabiano Fidêncio
On Tue, Sep 18, 2018 at 5:46 PM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > Reviewed-by: Fabiano Fidêncio > --- > src/util/vircgroup.c| 7 ++- > src/util/vircgroupbackend.h | 11 +++ > src/util/vircgroupv1.c | 22 ++

Re: [libvirt] [PATCH 38/47] vircgroup: extract virCgroupV1(Set|Get)CpuCfsQuota

2018-09-20 Thread Fabiano Fidêncio
On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > Reviewed-by: Fabiano Fidêncio > --- > src/util/vircgroup.c| 20 +++- > src/util/vircgroupbackend.h | 10 ++ > src/util/vircgrouppriv.h| 5 + >

Re: [libvirt] [PATCH 42/47] vircgroup: extract virCgroupV1(Set|Get)FreezerState

2018-09-20 Thread Fabiano Fidêncio
On Tue, Sep 18, 2018 at 5:46 PM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > Reviewed-by: Fabiano Fidêncio > --- > src/util/vircgroup.c| 8 ++-- > src/util/vircgroupbackend.h | 11 +++ > src/util/vircgroupv1.c | 23

Re: [libvirt] [PATCH 35/47] vircgroup: extract virCgroupV1(Allow|Deny)AllDevices

2018-09-20 Thread Fabiano Fidêncio
On Tue, Sep 18, 2018 at 5:45 PM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > Reviewed-by: Fabiano Fidêncio > --- > src/util/vircgroup.c| 18 ++ > src/util/vircgroupbackend.h | 9 + > src/util/vircg

  1   2   3   4   5   6   7   >