Re: [Libvir] Release of libvirt-0.4.1

2008-03-07 Thread Guido Günther
Hi Daniel. On Mon, Mar 03, 2008 at 10:13:12AM -0500, Daniel Veillard wrote: It was really time for a new release, quite a lot of patches had accumulated since the previous one ! Available at ftp://libvirt.org/libvirt Cool thing! Unfortunatley this release breaks kvm/qemu bridged

Re: [Libvir] Release of libvirt-0.4.1

2008-03-12 Thread Guido Günther
On Fri, Mar 07, 2008 at 04:23:13PM +0100, Guido Günther wrote: Hi Daniel. On Mon, Mar 03, 2008 at 10:13:12AM -0500, Daniel Veillard wrote: It was really time for a new release, quite a lot of patches had accumulated since the previous one ! Available at ftp://libvirt.org/libvirt

[Libvir] [PATCH] mark error messages as translatable

2008-03-23 Thread Guido Günther
This patch marks the error messages in qemu_driver.c as translatable, some of them were marked as such already. Please apply. -- Guido --- src/qemu_driver.c | 200 ++-- 1 files changed, 100 insertions(+), 100 deletions(-) diff --git

[Libvir] [PATCH] remove trailing newlines in error strings

2008-03-23 Thread Guido Günther
Most of the error messages don't pass a final newline. Strip the ones that still do so for consistency. Please apply. -- Guido --- src/qemu_driver.c | 40 1 files changed, 20 insertions(+), 20 deletions(-) diff --git a/src/qemu_driver.c

Re: [Libvir] [PATCH] reindent __virErrorMsg with spaces instead of tabs

2008-03-25 Thread Guido Günther
HI Daniel, On Mon, Mar 24, 2008 at 03:56:07AM -0400, Daniel Veillard wrote: Hum, could you send those kind of patches as attachments in the future ? Basically assuming spaces/tabs are correctly preserved in an email body is taking unecessary risks. Also having a name for the patch and being

Re: [Libvir] error : could not connect to xen:///; error: failed to connect to the hypervisor

2008-03-26 Thread Guido Günther
Hi Felix, On Wed, Mar 26, 2008 at 02:52:14PM +0100, Felix Krohn wrote: Since I was using the version from etch-backports (http://packages.qa.debian.org/libv/libvirt.html) I don't think so. The version on backports.org doesn't even have xen support enabled due to the missing libxen in Debian

Re: [Libvir] error : could not connect to xen:///; error: failed to connect to the hypervisor

2008-03-26 Thread Guido Günther
On Wed, Mar 26, 2008 at 02:23:05PM +, Richard W.M. Jones wrote: Currently (libvirt 0.4.0-6) the logic is: There's a 0.4.1 package in exprimental but the autobuilder didn't pick it up yet so it's only available on ppc: http://packages.debian.org/experimental/libvirt-bin I'll move that one

[Libvir] use C99 initializer for lastErr

2008-03-28 Thread Guido Günther
...this makes things just a bit more readable. -- Guido --- src/virterror.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/virterror.c b/src/virterror.c index 1e39be4..1463129 100644 --- a/src/virterror.c +++ b/src/virterror.c @@ -19,7 +19,9 @@ #include

[Libvir] [PATCH/RFC] remote driver uses already freed dom

2008-03-28 Thread Guido Günther
Hi, when trying to undefine a running qemu domain the domain name gets corrupted: $ ./virsh undefine system1 Name: /�em1 libvir: QEMU error /�em1: internal error cannot delete active domain error: Failed to undefine domain system1 the reaseon is that in qemud/remote.c the domain is freed after

Re: [libvir] [PATCH] Change group ownership of /var/run/libvirt/

2008-04-25 Thread Guido Günther
On Thu, Apr 24, 2008 at 07:20:45PM +0400, Anton Protopopov wrote: 1) If libvirtd is running as root, main() will try to change the group ownership of /var/run/libvirt to one specified by unix_sock_gid. 2) Default permissions on /var/run/libvirt are now 0750 How does this match with the default

Re: [libvirt] [PATCH] qemudDomainCreate check if domain is already active

2008-07-24 Thread Guido Günther
On Thu, Jul 24, 2008 at 10:01:32AM +0100, Daniel P. Berrange wrote: diff --git a/src/qemu_driver.c b/src/qemu_driver.c index b84bdf4..0ad72ae 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -1978,6 +1978,15 @@ static virDomainPtr qemudDomainCreate(virConnectPtr conn, const

[libvirt] [PATCH] qemudDomainCreate: also check uuid

2008-07-24 Thread Guido Günther
On Thu, Jul 24, 2008 at 04:12:05PM +0100, Daniel P. Berrange wrote: On Thu, Jul 24, 2008 at 10:41:31AM -0400, Guido G?nther wrote: On Thu, Jul 24, 2008 at 10:01:32AM +0100, Daniel P. Berrange wrote: [..snip..] You need to check for UUID clash too. Indeed. But before fixing this I wonder

[libvirt] [PATCH] qemudOpenMonitor: fix open(2) error check

2008-07-24 Thread Guido Günther
Hi, open returns -1 on failure. Pointed out by Guido Trotter on: http://bugs.debian.org/492250 Patch against current CVS attached. -- Guido --- src/qemu_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index

[libvirt] [PATCH]: libvirt.h: very xen centric

2008-07-24 Thread Guido Günther
Hi, while reading through that I noticed libvirt.h is quiet xen centric. Purely cosmetic patch attached, -- Guido --- include/libvirt/libvirt.h | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/libvirt/libvirt.h b/include/libvirt/libvirt.h index

[libvirt] [PATCH]: qemu_driver: convert uuid to string in error messages

2008-07-24 Thread Guido Günther
Hi, qemu_driver misses some conversions to a char* before printing the uuid. Possible fix attached. Cheers, -- Guido --- src/qemu_driver.c | 25 - 1 files changed, 20 insertions(+), 5 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index

Re: [libvirt] [PATCH]: qemu_driver: convert uuid to string in error messages

2008-07-25 Thread Guido Günther
On Fri, Jul 25, 2008 at 05:02:43AM -0400, Daniel Veillard wrote: On Fri, Jul 25, 2008 at 09:29:43AM +0100, Daniel P. Berrange wrote: On Thu, Jul 24, 2008 at 03:52:32PM -0400, Guido G?nther wrote: Hi, qemu_driver misses some conversions to a char* before printing the uuid. Possible fix

[libvirt] [PATCH/RFC]: hostdev passthrough support

2008-07-25 Thread Guido Günther
Hi, attached is some basic support for host device passthrough. It enables you to passthrough usb devices in qemu/kvm via: devices hostdev type='usb' vendor='0204' product='6025'/ hostdev type='usb' bus='001' device='007'/ /devices I didn't implement unplug yet since this needs some

Re: [libvirt] [PATCH]: qemu_driver: convert uuid to string in error messages

2008-07-25 Thread Guido Günther
On Fri, Jul 25, 2008 at 11:46:48AM -0400, Daniel Veillard wrote: On Fri, Jul 25, 2008 at 09:56:27AM -0400, Guido Günther wrote: On Fri, Jul 25, 2008 at 05:02:43AM -0400, Daniel Veillard wrote: On Fri, Jul 25, 2008 at 09:29:43AM +0100, Daniel P. Berrange wrote: On Thu, Jul 24, 2008 at 03

[libvirt] [PATCH] qemud: move check for polkit before config file check

2008-07-26 Thread Guido Günther
Hi, Without this patch and without a /etc/libvirt/libvirt.conf config file the default policy for running the daemon as non root user is still polkit which is bad. Please apply. Cheers, -- Guido qemud/qemud.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git

[libvirt] [PATCH] don't dump core on NULL ifname

2008-07-29 Thread Guido Günther
Hi, actually I thought I sent this out already, but it seems I didn't: Don't dump core on NULL ifname when getting interface statistic. Not all networking types have a target ifname set (user,client,server,mcast). Cheers, -- Guido [PATCH] don't dump core on NULL ifname not all networking types

Re: [libvirt] [PATCH/RFC]: hostdev passthrough support

2008-07-29 Thread Guido Günther
Hi Daniel, On Mon, Jul 28, 2008 at 09:26:57AM -0400, Daniel Veillard wrote: On Fri, Jul 25, 2008 at 04:17:30PM -0400, Guido Günther wrote: Hi, attached is some basic support for host device passthrough. It enables you to passthrough usb devices in qemu/kvm via: devices hostdev type

Re: [libvirt] [PATCH/RFC]: file backed usb massstorage

2008-07-31 Thread Guido Günther
On Wed, Jul 30, 2008 at 09:47:00AM +0100, Daniel P. Berrange wrote: On Mon, Jul 28, 2008 at 11:02:45AM -0400, Guido G?nther wrote: On Fri, Jul 25, 2008 at 04:17:30PM -0400, Guido Günther wrote: attached is some basic support for host device passthrough. It enables you to passthrough usb

Re: [libvirt] [PATCH] qemudDomainCreate: also check uuid

2008-07-31 Thread Guido Günther
On Wed, Jul 30, 2008 at 12:05:56AM -0500, Charles Duffy wrote: It appears that this patch was applied (in commit 45616162db2d1e807dbe70e60c67cb701cbd06d8) with the virDomainIsActive(vm) checks removed from qemudDomainCreate, such that we fail out with domain [...] is already defined and

[libvirt] [PATCH/RFC]: hostdev passthrough support take #2

2008-08-02 Thread Guido Günther
Hi, attached is a second version. Changes are: * s/bus/subsystem/ * support hexadecimal and decimal attributes * introduce device and source elements. I decided to not drop vendor and product id into their own elements since the structure would then become very nested for no good reason. Some

[libvirt] [PATCH/RFC]: file backed usb massstorage #2

2008-08-02 Thread Guido Günther
Hi, attached is a second version of the usb massstorage patch: Changes are: * use sd* dummy dev names instead of usbdisk * move the check for the subtype (hard disk/cdrom/...) into the driver An example is: disk type='file' device='disk' target dev=sda bus='usb'/ source

Re: [libvirt] [PATCH/RFC]: hostdev passthrough support take #2

2008-08-04 Thread Guido Günther
On Mon, Aug 04, 2008 at 10:34:31AM +0100, Daniel P. Berrange wrote: On Sun, Aug 03, 2008 at 01:41:28AM +0200, Guido G?nther wrote: Hi, attached is a second version. Changes are: * s/bus/subsystem/ * support hexadecimal and decimal attributes * introduce device and source elements.

Re: [libvirt] How does virt-manager send shutdown?

2008-08-07 Thread Guido Günther
On Mon, Aug 04, 2008 at 09:05:07AM -0400, Bryan Kearney wrote: I added the following to my xml features feature acpi/ /feature /features and had acpi=force on my kernel line.. still no luck. I looked for bugs in bugzilla.redhat... saw none

[libvirt] [PATCH]: hostdev passthrough support take #3

2008-08-07 Thread Guido Günther
Hi, attached is version three of the hostdev passthrough patch. It adds: * code to format the XML for output * RelaxNG schema update * testcases Cheers, -- Guido From cfcfc85accdcc7be7a5fbfd2c8dde435646d5ab2 Mon Sep 17 00:00:00 2001 From: Guido Guenther [EMAIL PROTECTED] Date: Fri, 25 Jul 2008

[libvirt] [PATCH] fix xmlint in separate build dir

2008-08-07 Thread Guido Günther
Hi, attached patch lets the domainschema check work when building in $build instead of $src. Otherwise it won't find the xml files to validate. -- Guido From e2a19f1e14ef6712626a1b1b06b62cedf032495e Mon Sep 17 00:00:00 2001 From: Guido Guenther [EMAIL PROTECTED] Date: Thu, 7 Aug 2008 16:12:43

[libvirt] [PATCH]: file backed usb massstorage #3

2008-08-07 Thread Guido Günther
Hi, attached is version three of the file backed usb massstorage patch. * handle type != DISK case * on OOM use VIR_ERR_NO_MEMORY instead of VIR_ERR_OPERAION_FAILED * RelaxNG schema update * testcase The patches are ment to be applied on top of the hostdev patches. Cheers, -- Guido From

[libvirt] [PATCH]: file backed usb massstorage #4

2008-08-08 Thread Guido Günther
On Fri, Aug 08, 2008 at 02:07:49PM +0200, Jim Meyering wrote: Guido Günther [EMAIL PROTECTED] wrote: [..snip..] +static int qemudDomainAttachUsbMassstorageDevice(virDomainPtr dom, virDomainDeviceDefPtr dev) +{ +struct qemud_driver *driver = (struct qemud_driver *)dom-conn

[libvirt] [PATCH]: hostdev passthrough support take #4

2008-08-08 Thread Guido Günther
On Fri, Aug 08, 2008 at 02:30:15PM +0200, Jim Meyering wrote: Guido Günther [EMAIL PROTECTED] wrote: [..snip..] +static int qemudDomainAttachCdromDevice(virDomainPtr dom, +virDomainDeviceDefPtr dev) +{ +struct qemud_driver *driver = (struct

Re: [libvirt] [PATCH]: hostdev passthrough support take #4

2008-08-08 Thread Guido Günther
Hi, On Fri, Aug 08, 2008 at 10:34:00AM -0400, Daniel Veillard wrote: [..snip..] I think the only thing missing is extending the descrition in the documentation would you mind adding a description in formatdomain.html(.in) Probably an USB devices section added below the elementsDisks part,

Re: [libvirt] [PATCH] make sure we call the freshly build libvirtd

2008-08-08 Thread Guido Günther
On Fri, Aug 08, 2008 at 06:30:56PM +0200, Jim Meyering wrote: Guido Guenther [EMAIL PROTECTED] wrote: ...not the one in $PATH. I was wondering why this test kept failing... You shouldn't need that change, since make check already sets PATH so that $abs_top_builddir/qemud is early in PATH.

Re: [libvirt] /var/run/libvirt

2008-08-09 Thread Guido Günther
On Sat, Aug 09, 2008 at 09:56:45AM +0100, Richard W.M. Jones wrote: [..snip..] Dan/Dan, any reason we can't 'mkdir' this when libvirtd starts up? Shoulnd't this better be handled in the distros init script? -- Guido -- Libvir-list mailing list Libvir-list@redhat.com

Re: [libvirt] [PATCH] Fix serial console telnet protocol support

2008-08-14 Thread Guido Günther
Hi Mark, On Wed, Aug 13, 2008 at 06:44:28PM +0100, Mark McLoughlin wrote: With e.g.: serial type='tcp' source mode='bind' host='127.0.0.1' service=''/ protocol type='telnet'/ target port='0'/ /serial You currently get: Unknown option: listen qemu: could not

Re: [libvirt] [PATCH] kvm: maxVCPU runtime detection

2008-08-22 Thread Guido Günther
On Fri, Aug 22, 2008 at 07:26:12PM +0200, Jim Meyering wrote: [..snip..] I've just checked up to date rawhide and debian unstable systems. Both had this: $ grep KVM_CHECK_EXTENSION /usr/include/linux/kvm.h #define KVM_CHECK_EXTENSION _IO(KVMIO, 0x03) But rawhide lacks

Re: [libvirt] [PATCH] kvm: maxVCPU runtime detection

2008-09-08 Thread Guido Günther
On Fri, Sep 05, 2008 at 12:23:36PM -0400, Cole Robinson wrote: [..snip..] FYI, I'm about to post a patch that builds on this to offer max vcpu checking based on the kvm version which is parsed from the help message. Should also help providing useful values for older kernels and kvm versions.

Re: [libvirt] [PATCH] kvm: maxVCPU runtime detection

2008-09-17 Thread Guido Günther
On Fri, Aug 22, 2008 at 03:16:42PM +0200, Guido Günther wrote: Hi, with recent linux kernels we can detect the maximum number of virtual cpus at runtime via an ioctl. Possible patch attached. It does this on every call to qemudGetMaxVCPUs. Would you prefer something that does this only once

Re: [libvirt] [PATCH] kvm: maxVCPU runtime detection

2008-09-17 Thread Guido Günther
On Wed, Sep 17, 2008 at 02:11:46PM +0100, Richard W.M. Jones wrote: On Wed, Sep 17, 2008 at 01:38:49PM +0200, Guido Günther wrote: On Fri, Aug 22, 2008 at 03:16:42PM +0200, Guido Günther wrote: Hi, with recent linux kernels we can detect the maximum number of virtual cpus at runtime

[libvirt] [PATCH] qemu: fix block stats for virtio and scsi

2008-10-02 Thread Guido Günther
Hi, qemudDomainBlockStats needs to map between qemu and libvirt device naming as well. Possible patch attached. Cheers, -- Guido From 57b8c8e66abfcc57c2f05d8b8364de6ecc05dcf9 Mon Sep 17 00:00:00 2001 From: Guido Guenther [EMAIL PROTECTED] Date: Thu, 2 Oct 2008 21:12:20 +0200 Subject: [PATCH]

Re: [libvirt] [PATCH] qemu: fix block stats for virtio and scsi

2008-10-02 Thread Guido Günther
On Thu, Oct 02, 2008 at 09:06:25PM +0100, Daniel P. Berrange wrote: I think this needs to use the virDiskNameToIndex() method to extract the index instead. Corrected pach attached. I don't know how devices are called when using xenner so I left that out. -- Guido From

[libvirt] [PATCH] use C99 initializers for virState

2008-10-05 Thread Guido Günther
Hi, attached patch uses C99 initializers for virStateDriver. Makes reading easier and extending the structure less error prone. -- Guido From 61dd31fd378a1bf1db2b4f7cc871234a3c8fd51e Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Guido=20G=C3=BCnther?= [EMAIL PROTECTED] Date: Sun, 5 Oct 2008 13:46:25

[libvirt] [PATCH] fix build in separate build-dir

2008-10-05 Thread Guido Günther
Hi, building in a separate build dir is currently broken since the Makefile is looking for libvirt.policy in the wrong location. Fix attached. Cheers, -- Guido From 39bba201df8e3962001e950e82faf989751b7c37 Mon Sep 17 00:00:00 2001 From: Guido Guenther [EMAIL PROTECTED] Date: Sun, 5 Oct 2008

[libvirt] [PATCH]: (trivial) getpwuid is not OOM

2008-10-07 Thread Guido Günther
Hi, we shouldn't print an oom error message when actually getpwuid failed. Cheers, -- Guido [PATCH] don't report OOM when it's not --- src/qemu_driver.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index b5ba723..806608d 100644

Re: [libvirt] [PATCH] qemu: fix block stats for virtio and scsi

2008-10-10 Thread Guido Günther
On Tue, Oct 07, 2008 at 03:03:10PM -0400, Cole Robinson wrote: Guido Günther wrote: On Thu, Oct 02, 2008 at 09:06:25PM +0100, Daniel P. Berrange wrote: I think this needs to use the virDiskNameToIndex() method to extract the index instead. Corrected pach attached. I don't know how devices

[libvirt] [PATCH 1/3] qemu: fix block stats for virtio and scsi

2008-10-10 Thread Guido Günther
Hi, 0 looks like a valid index as returned by virDiskNameToIndex, so we should accept it. Also the disk argument can be const. -- Guido From 084dcc24ce4ec3a7561eaf2a090cdb45a97e9a56 Mon Sep 17 00:00:00 2001 From: Guido Guenther [EMAIL PROTECTED] Date: Fri, 10 Oct 2008 17:13:33 +0200 Subject:

[libvirt] [PATCH 2/3] qemu: fix block stats for virtio and scsi

2008-10-10 Thread Guido Günther
Hi, qemuDiskDeviceName treat's all IDE and SCSI devices as cdroms, make it also handle disks. Make funcion arguments const. -- Guido From 3204259d61af4eee8436ccaea66469544f929613 Mon Sep 17 00:00:00 2001 From: Guido Guenther [EMAIL PROTECTED] Date: Fri, 10 Oct 2008 17:14:15 +0200 Subject: [PATCH]

[libvirt] [PATCH 3/3] qemu: fix block stats for virtio and scsi

2008-10-10 Thread Guido Günther
Hi, use qemudDiskDeviceName to determine the block device name (as suggested by Cole). -- Guido From 6985fee585561b04942036d283632e7cb2bb708f Mon Sep 17 00:00:00 2001 From: Guido Guenther [EMAIL PROTECTED] Date: Thu, 2 Oct 2008 21:12:20 +0200 Subject: [PATCH] support virtio and scsi disks in

[libvirt] Re: [PATCH/RFC] kvm/qemu vs libvirtd restarts

2008-10-10 Thread Guido Günther
On Tue, Oct 07, 2008 at 05:37:52PM +0100, Daniel P. Berrange wrote: [..snip..] This also needs to be implemented with the assumption that the daemon can will crash any time. So putting the state-saving hooks into the qemudShutdown() method won't be sufficient. We need to write out the state

[libvirt] Re: [PATCH 3/3] qemu: fix block stats for virtio and scsi

2008-10-11 Thread Guido Günther
On Fri, Oct 10, 2008 at 06:05:37PM +0100, Daniel P. Berrange wrote: Sorry to mess up your patch, but I just committed the code to turn all linked lists into arrays. So you'll need to tweak this to do for (i = 0 ; i vm-def-ndisks ; i++) if (STREQ(vm-def-disks[i]-dst))

[libvirt] (no subject)

2008-10-16 Thread Guido Günther
On Wed, Oct 15, 2008 at 09:59:12PM +0100, Daniel P. Berrange wrote: When you get to that level of cleverness, it seems to me that it is verging on a complete re-implementation of DLM (distributed lock manager), which really, AFAIK, needs a proper cluster setup so it can safely fence

[libvirt] [PATCH] qemu/kvm: allow to hotadd scsi/virtio disks

2008-10-17 Thread Guido Günther
Hi, recent kvm allows to hot add scsi/virtio disks, it uses pci hotplugging for that. Attached patch adds support for this to libvirt. -- Guido From 56d179adeb04d47ef8f3557702948976e3b5cbea Mon Sep 17 00:00:00 2001 From: Guido Guenther [EMAIL PROTECTED] Date: Thu, 16 Oct 2008 18:15:04 +0200

[libvirt] [PATCH/RFC] qemu: persist hotadd devices

2008-10-17 Thread Guido Günther
Hi, currently devices added via qemudDomainAttachDevice don't ever get written out into the xml domain definition. Is this intentional? Attached patch calls virDomainSaveConfig to fix this. -- Guido From 42142a2ecb04a26f867d030fb986fcee2b7a05b9 Mon Sep 17 00:00:00 2001 From: Guido Guenther [EMAIL

Re: [libvirt] [PATCH] qemu/kvm: allow to hotadd scsi/virtio disks

2008-10-17 Thread Guido Günther
On Fri, Oct 17, 2008 at 11:05:50AM +0100, Daniel P. Berrange wrote: On Fri, Oct 17, 2008 at 09:48:58AM +0200, Guido G?nther wrote: Hi, recent kvm allows to hot add scsi/virtio disks, it uses pci hotplugging for that. Attached patch adds support for this to libvirt. Great, I didn't know

[libvirt] [PATCH] minor usb masstorage hotadd cleanup

2008-10-17 Thread Guido Günther
Hi, this just brings qemudDomainAttachUsbMassstorageDevice in line with the rest of the code: * don't allow to add the same target device name more than once * escape paths for qemu's monitor command Cheers, -- Guido From e8a83a21642c78f22c80750b280c67fb9a7e0c06 Mon Sep 17 00:00:00 2001 From:

[libvirt] [PATCH/RFC] qemu/kvm: allow to hot remove scsi/virtio disks

2008-10-17 Thread Guido Günther
On Fri, Oct 17, 2008 at 02:37:17PM +0200, Daniel Veillard wrote: [..snip..] Looks fine, i just removed a couple of extra spaces at end of line before commiting :-) Thanks a lot for applying this so quickly! Attached is a patch that allows for unplugging of disks. To do that I added a token to

Re: [libvirt] [PATCH/RFC] qemu/kvm: allow to hot remove scsi/virtio disks

2008-10-21 Thread Guido Günther
On Tue, Oct 21, 2008 at 02:42:40PM +0100, Daniel P. Berrange wrote: [..snip..] Is there not some 'info pci' or 'info disk' command we cna use to find out the PCI slot number at the time we want to detach the device. This would make it work for all disks, and avoid the need to track the state

Re: [libvirt] [PATCH/RFC] qemu/kvm: allow to hot remove scsi/virtio disks

2008-10-21 Thread Guido Günther
Hi Daniel, On Tue, Oct 21, 2008 at 03:25:25PM +0200, Daniel Veillard wrote: Those are just stylistic issues, I can apply the patch with those changed if you wish if you don't have time for a new patch, I'll come up with a corrected version, no problem. -- Guido -- Libvir-list mailing list

Re: [libvirt] [PATCH] minor usb masstorage hotadd cleanup

2008-10-21 Thread Guido Günther
On Tue, Oct 21, 2008 at 03:09:48PM +0200, Daniel Veillard wrote: On Fri, Oct 17, 2008 at 12:44:13PM +0200, Guido Günther wrote: Hi, this just brings qemudDomainAttachUsbMassstorageDevice in line with the rest of the code: * don't allow to add the same target device name more than once

Re: [libvirt] image locking?

2008-10-22 Thread Guido Günther
On Tue, Oct 21, 2008 at 12:16:01PM -0700, Itamar Heim wrote: While this might work for SBC (although most enterprises have the datacenter on remote sites as well, so not always that easy). I don't think the solution is viable for CBC though (I am not sure CBC would use iSCSI, probably NFS is

Re: [libvirt] [PATCH/RFC] qemu/kvm: allow to hot remove scsi/virtio disks

2008-10-23 Thread Guido Günther
Hi Daniel, On Tue, Oct 21, 2008 at 03:25:25PM +0200, Daniel Veillard wrote: [..snip..] Those are just stylistic issues, I can apply the patch with those changed if you wish if you don't have time for a new patch, Thanks for your comments. Updated version attached. I basically removed the

[libvirt] [libvirt-sandbox PATCH 1/2] main: Don't free error twice

2012-02-26 Thread Guido Günther
It's already being cleared in cleanup. Otherwise we see: Unknown option -D Run 'libvirt-sandbox --help' to see a full list of available command line options *** glibc detected *** /var/scratch/debian/libvirt-sandbox/libvirt-sandbox/bin/.libs/lt-virt-sandbox: double free or corruption

[libvirt] [libvirt-sandbox PATCH 2/2] Debug is '-d' not '-D'

2012-02-26 Thread Guido Günther
--- bin/virt-sandbox.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c index 00b2a29..b3b5166 100644 --- a/bin/virt-sandbox.c +++ b/bin/virt-sandbox.c @@ -300,7 +300,7 @@ Display the version number and exit Display verbose

Re: [libvirt] [libvirt-sandbox PATCH 1/2] main: Don't free error twice

2012-02-27 Thread Guido Günther
On Sun, Feb 26, 2012 at 07:11:29PM +, Daniel P. Berrange wrote: On Sun, Feb 26, 2012 at 01:49:33PM +0100, Guido Günther wrote: It's already being cleared in cleanup. Otherwise we see: Unknown option -D Run 'libvirt-sandbox --help' to see a full list of available command line

Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1

2012-03-27 Thread Guido Günther
On Mon, Mar 26, 2012 at 10:32:23AM +0800, Daniel Veillard wrote: As scheduled, we are entering the freeze for 0.9.11. I think most API additions are now commited to git upstream (please raise your voice quickly if you see something missing !) I have made a release candidate 1 tarball (and

Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1

2012-04-03 Thread Guido Günther
On Tue, Apr 03, 2012 at 09:22:56AM +0200, Philipp Hahn wrote: Hello, On Tuesday 27 March 2012 18:30:17 Guido Günther wrote: On Mon, Mar 26, 2012 at 10:32:23AM +0800, Daniel Veillard wrote: As scheduled, we are entering the freeze for 0.9.11. ... Please give it a try ! Stability

[libvirt] [PATCH] virURIParse: don't forget to copy the user part

2012-04-05 Thread Guido Günther
This got dropped with 300e60e15b22387dda41ed5985a9ebadfd86dd25 Cheers, -- Guido --- src/util/viruri.c |5 - tests/viruritest.c | 24 +--- 2 files changed, 17 insertions(+), 12 deletions(-) diff --git a/src/util/viruri.c b/src/util/viruri.c index 2c6de51..a41f345

[libvirt] [libvirt-glib] Explicitly link conn-test against libvirt-gconfig libvirt-glib

2012-04-10 Thread Guido Günther
otherwise the build fails with: $ CCLD conn-test ../libvirt-gobject/.libs/libvirt-gobject-1.0.so: undefined reference to `gvir_config_domain_new_from_xml@LIBVIRT_GCONFIG_0.0.4' ../libvirt-gobject/.libs/libvirt-gobject-1.0.so: undefined reference to `gvir_set_error@LIBVIRT_GLIB_0.0.4'

[libvirt] [libvirt-glib] libvirt-gconfig: Move symbols introduced post 0.0.4 to the correct versions

2012-04-10 Thread Guido Günther
Triggered by http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667683 --- If this looks correct I'll have a look at libvirt-glib and libvirt-gobject too. -- Guido libvirt-gconfig/libvirt-gconfig.sym | 50 +++ 1 files changed, 33 insertions(+), 17 deletions(-)

Re: [libvirt] [libvirt-glib] libvirt-gconfig: Move symbols introduced post 0.0.4 to the correct versions

2012-04-11 Thread Guido Günther
On Wed, Apr 11, 2012 at 10:47:46AM +0200, Christophe Fergeau wrote: Hey, On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote: On Tue, Apr 10, 2012 at 10:31:55PM +0200, Guido Günther wrote: Triggered by http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667683

Re: [libvirt] [libvirt-glib] Explicitly link conn-test against libvirt-gconfig libvirt-glib

2012-04-11 Thread Guido Günther
On Tue, Apr 10, 2012 at 09:36:57PM +0100, Daniel P. Berrange wrote: On Tue, Apr 10, 2012 at 10:29:59PM +0200, Guido Günther wrote: otherwise the build fails with: $ CCLD conn-test ../libvirt-gobject/.libs/libvirt-gobject-1.0.so: undefined reference

Re: [libvirt] [libvirt-glib] libvirt-gconfig: Move symbols introduced post 0.0.4 to the correct versions

2012-04-11 Thread Guido Günther
On Wed, Apr 11, 2012 at 01:41:38PM +0200, Christophe Fergeau wrote: On Wed, Apr 11, 2012 at 01:25:45PM +0200, Guido Günther wrote: On Wed, Apr 11, 2012 at 10:47:46AM +0200, Christophe Fergeau wrote: Hey, On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote: On Tue

Re: [libvirt] [libvirt-glib] libvirt-gconfig: Move symbols introduced post 0.0.4 to the correct versions

2012-04-11 Thread Guido Günther
On Wed, Apr 11, 2012 at 12:30:05PM +0100, Daniel P. Berrange wrote: On Wed, Apr 11, 2012 at 01:25:45PM +0200, Guido Günther wrote: On Wed, Apr 11, 2012 at 10:47:46AM +0200, Christophe Fergeau wrote: Hey, On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote: On Tue

Re: [libvirt] [libvirt-gconfig PATCHv2 01/14] Add GVirConfigDomainController skeleton

2012-04-12 Thread Guido Günther
On Wed, Apr 11, 2012 at 03:48:09PM +0200, Christophe Fergeau wrote: [..snip..] --- a/libvirt-gconfig/libvirt-gconfig.sym +++ b/libvirt-gconfig/libvirt-gconfig.sym @@ -69,6 +69,8 @@ LIBVIRT_GCONFIG_0.0.4 { gvir_config_domain_console_set_target_type;

Re: [libvirt] [libvirt-glib] Getter/setter for disk source's startupPolicy attribute

2012-04-12 Thread Guido Günther
On Thu, Apr 12, 2012 at 05:54:25AM +0300, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gconfig/libvirt-gconfig-domain-disk.c | 26 + libvirt-gconfig/libvirt-gconfig-domain-disk.h |9

Re: [libvirt] [libvirt-glib] Explicitly link conn-test against libvirt-gconfig libvirt-glib

2012-04-12 Thread Guido Günther
On Wed, Apr 11, 2012 at 01:41:20PM +0100, Daniel P. Berrange wrote: On Wed, Apr 11, 2012 at 01:54:27PM +0200, Guido Günther wrote: On Tue, Apr 10, 2012 at 09:36:57PM +0100, Daniel P. Berrange wrote: On Tue, Apr 10, 2012 at 10:29:59PM +0200, Guido Günther wrote: otherwise the build fails

Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1

2012-04-13 Thread Guido Günther
On Mon, Apr 02, 2012 at 10:42:21AM -0400, Laine Stump wrote: On 04/02/2012 06:43 AM, Philipp Hahn wrote: The patch still aplies, but sending new version as you requested. Still compiles (with minor problems regarding undefined IFLA_PORT_MAX and broken libnl on my Debian-Squeeze here)

Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1

2012-04-13 Thread Guido Günther
Hi Laine, On Tue, Apr 03, 2012 at 08:27:39PM +0200, Guido Günther wrote: On Tue, Apr 03, 2012 at 09:22:56AM +0200, Philipp Hahn wrote: Hello, On Tuesday 27 March 2012 18:30:17 Guido Günther wrote: On Mon, Mar 26, 2012 at 10:32:23AM +0800, Daniel Veillard wrote: As scheduled, we

Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1

2012-04-13 Thread Guido Günther
On Fri, Apr 13, 2012 at 03:52:46PM +0200, Philipp Hahn wrote: Hello Guido, Am Freitag 13 April 2012 15:10:49 schrieb Guido Günther: könntest Du das als richtigen Patch schicken, dann apply ich das. [Guido asks me to send a full patch, so he can apply it.] Sure, see the attached patch

[libvirt] [PATCH] Fix macvtap detection by also checking for IFLA_VF_MAX

2012-04-14 Thread Guido Günther
since this isn't available on older kernels such as Debian Squeeze's 2.6.32. This make --with-macvtap=check work as expected. --- configure.ac |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) O.k. to apply? Cheers, -- Guido diff --git a/configure.ac b/configure.ac index

Re: [libvirt] [PATCH] Fix macvtap detection by also checking for IFLA_VF_MAX

2012-04-15 Thread Guido Günther
On Sat, Apr 14, 2012 at 03:45:44PM -0600, Eric Blake wrote: On 04/14/2012 11:18 AM, Guido Günther wrote: since this isn't available on older kernels such as Debian Squeeze's 2.6.32. This make --with-macvtap=check work as expected. --- configure.ac |3 ++- 1 file changed, 2

Re: [libvirt] [PATCH] openvz: wire up more node information functions

2012-04-16 Thread Guido Günther
On Mon, Apr 16, 2012 at 09:48:38AM +0800, Osier Yang wrote: On 2012年04月15日 04:20, Guido Günther wrote: in detail nodeGetCPUStats, nodeGetMemoryStats, nodeGetCellsFreeMemory and nodeGetFreeMemory --- src/openvz/openvz_driver.c |4 1 file changed, 4 insertions(+) diff --git

[libvirt] [PATCH] docs: fix path to openvz network configuration file

2012-04-16 Thread Guido Günther
It's vznet.conf not vznetctl.conf, see e.g.: http://git.openvz.org/?p=vzctl;a=blob;f=bin/vznetcfg.in;h=e91f5c4a0744c1ea149e1b8c241b666052e10b12;hb=HEAD --- docs/drvopenvz.html.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/drvopenvz.html.in

Re: [libvirt] [PATCH] docs: fix path to openvz network configuration file

2012-04-16 Thread Guido Günther
On Mon, Apr 16, 2012 at 03:27:28PM +0100, Daniel P. Berrange wrote: On Mon, Apr 16, 2012 at 04:21:01PM +0200, Guido Günther wrote: It's vznet.conf not vznetctl.conf, see e.g.: http://git.openvz.org/?p=vzctl;a=blob;f=bin/vznetcfg.in;h=e91f5c4a0744c1ea149e1b8c241b666052e10b12;hb=HEAD

[libvirt] [PATCH] openvz; wire up getHostname

2012-04-19 Thread Guido Günther
--- Trivial thing missing in the openvz driver. Cheers, -- Guido src/openvz/openvz_driver.c |1 + 1 file changed, 1 insertion(+) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index 0451c22..7ec327d 100644 --- a/src/openvz/openvz_driver.c +++

[libvirt] [PATCH] openvz: add network interface stats

2012-04-19 Thread Guido Günther
This will only work for veth devices since venet devices don't have a target element. --- src/openvz/openvz_driver.c | 52 1 file changed, 52 insertions(+) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index 7ec327d..e8b6915

Re: [libvirt] [PATCH] openvz; wire up getHostname

2012-04-20 Thread Guido Günther
On Thu, Apr 19, 2012 at 04:40:58PM -0600, Eric Blake wrote: On 04/19/2012 04:32 PM, Guido Günther wrote: --- Trivial thing missing in the openvz driver. Cheers, -- Guido src/openvz/openvz_driver.c |1 + 1 file changed, 1 insertion(+) diff --git a/src/openvz

Re: [libvirt] [PATCH] openvz: add network interface stats

2012-04-23 Thread Guido Günther
On Fri, Apr 20, 2012 at 12:01:51PM -0400, Laine Stump wrote: On 04/19/2012 06:32 PM, Guido Günther wrote: This will only work for veth devices since venet devices don't have a target element. Well, there is precedent for having stats work on some types of interfaces and not on others

Re: [libvirt] udevadm settle can take too long

2012-04-23 Thread Guido Günther
Hi, On Sun, Apr 22, 2012 at 02:41:54PM -0400, Jim Paris wrote: Hi, http://bugs.debian.org/663931 is a bug I'm hitting, where virt-manager times out on the initial connection to libvirt. I reassigned the bug back to libvirt. I still wonder what triggers this though for some users but not for

[libvirt] [PATCH] openvz: read vmguarpages/privvmpages to set memory tunables

2012-04-23 Thread Guido Günther
--- OpenVZ's memory paramters [1,2] aren't very well supported at the moment. Let's make a start with privvmpages/vmguarpages using already available memtune parameters. I hope the mapping looks correct. Cheers, -- Guido [1] http://wiki.openvz.org/UBC_primary_parameters [2]

[libvirt] [PATCH 1/2] domain_conf: add filesystem limits to virDomainFSDef

2012-04-24 Thread Guido Günther
--- src/conf/domain_conf.c | 15 +++ src/conf/domain_conf.h |4 2 files changed, 19 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 184ff23..2b2a1d9 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11101,6 +11101,21 @@

[libvirt] [PATCH 0/2] Filesystem limits for containers

2012-04-24 Thread Guido Günther
parsing code. Other container solutions like lxc might have similar needs. Cheers, -- Guido Guido Günther (2): domain_conf: add filesystem limits to virDomainFSDef openvz; support file system quota reporting src/conf/domain_conf.c | 15 ++ src/conf/domain_conf.h |4 ++ src/openvz

[libvirt] [PATCH 2/2] openvz; support file system quota reporting

2012-04-24 Thread Guido Günther
--- src/openvz/openvz_conf.c | 114 +- 1 file changed, 73 insertions(+), 41 deletions(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index 579fcfc..7ea5e25 100644 --- a/src/openvz/openvz_conf.c +++ b/src/openvz/openvz_conf.c @@

[libvirt] [PATCH] openvz: read vmguarpages/privvmpages to set memory tunables [v2]

2012-04-27 Thread Guido Günther
--- This is a reworked version of the patch already sent, now adding handling for unlimited (represented by LONG_MAX in openvz) as well as a schema testcase. I also switched all value to unsigned long long to avoid overflows. Note that privvmpages is the amount of memory available to the

Re: [libvirt] libvirt stable releases

2012-04-29 Thread Guido Günther
On Thu, Apr 26, 2012 at 02:39:14PM -0400, Cole Robinson wrote: Hi all, An idea we've kicked around for awhile in Red Hat/Fedora land is doing official libvirt stable releases, but nothing ever took shape. The idea was brought up again recently and I've offered to help get something going.

Re: [libvirt] ANNOUNCE: Stable release libvirt-0.9.11.1

2012-04-29 Thread Guido Günther
Hi Cole, On Thu, Apr 26, 2012 at 03:45:25PM -0400, Cole Robinson wrote: I'm pleased to announce the release of libvirt-0.9.11.1. This is libvirt-0.9.11 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at:

[libvirt] [PATCHv2] openvz: read vmguarpages/privvmpages to set memory tunables

2012-05-03 Thread Guido Günther
--- Changes since last time: * check sysconf return value before division * use virStrToLong_ull instead of sscanf O.k. to apply? Cheers, -- Guido src/openvz/openvz_conf.c| 115 src/openvz/openvz_driver.c | 222

Re: [libvirt] [PATCHv2] openvz: read vmguarpages/privvmpages to set memory tunables

2012-05-04 Thread Guido Günther
On Thu, May 03, 2012 at 02:37:00PM -0600, Eric Blake wrote: On 05/03/2012 11:13 AM, Guido Günther wrote: --- Changes since last time: * check sysconf return value before division * use virStrToLong_ull instead of sscanf O.k. to apply? Cheers, -- Guido ACK

[libvirt] [PATCH] openvz: simplify openvzDomainDefineCmd by using virCommandPtr

2012-05-05 Thread Guido Günther
--- While working on setting filesystem quotas I came accross this and I figured I'll send this in advance because of the diffstat. Cheers, -- Guido src/openvz/openvz_driver.c | 79 +++- 1 file changed, 19 insertions(+), 60 deletions(-) diff --git

  1   2   3   4   5   6   7   8   9   10   >