On Tue, Jul 10, 2012 at 05:31:27PM -0600, Eric Blake wrote:
On 07/10/2012 12:54 PM, Guido Günther wrote:
This makes the driver fail with a clear error message in case of UUID
collisions (for example if somebody copied a container configuration
without updating the UUID) and also raises
On Wed, Jul 11, 2012 at 11:11:46AM +0200, Peter Krempa wrote:
On 07/11/12 10:39, Guido Günther wrote:
to match our CodingStyle.
---
This avoids c'n'p problems as seen in my recent domhostname patch.
Cheers,
-- Guido
tools/virsh.c | 186
On Tue, Jul 10, 2012 at 03:18:19PM -0600, Eric Blake wrote:
On 07/10/2012 02:46 PM, Guido Günther wrote:
---
tools/virsh.c | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 591a1ce..2c0446c 100644
to retrieve a VEs config parameters as a single string. This will be
used by the upcoming domainGetHostname implementation.
---
src/libvirt_openvz.syms |2 +-
src/openvz/openvz_util.c | 32
src/openvz/openvz_util.h |1 +
3 files changed, 34
to query the guest's hostname.
---
tools/virsh.c | 44
tools/virsh.pod |4
2 files changed, 48 insertions(+)
diff --git a/tools/virsh.c b/tools/virsh.c
index f9fe4b1..7c20202 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -14133,6
---
src/remote/remote_driver.c |1 +
src/remote/remote_protocol.x | 12 +++-
src/remote_protocol-structs |8
3 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 3314f80..5d1ce4d 100644
---
---
src/openvz/openvz_driver.c | 42 ++
1 file changed, 42 insertions(+)
diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c
index c9150e0..6046a60 100644
--- a/src/openvz/openvz_driver.c
+++ b/src/openvz/openvz_driver.c
@@ -234,6
VIR_ERR_OPERATION_FAILED instead
Cheers,
-- Guido
Guido Günther (5):
Add virDomainGetHostname
virsh: Add domhostname
remote: Provide RPC call for domainGetHostname
openvz: Add openvzVEGetStringParam
openvz: Implement domainGetHostname
include/libvirt/libvirt.h.in |2 ++
src/driver.h
to query a guests's hostname. Containers like LXC and OpenVZ allow to
set a hostname different from the hosts name and QEMU's guest agent
could provide similar functionality.
---
include/libvirt/libvirt.h.in |2 ++
src/driver.h |6 ++
src/libvirt.c|
On Mon, Jul 16, 2012 at 12:17:49PM +0200, Maciej Nabożny wrote:
Hello,
I'm developer of CC1 project in Institute of Nuclear Physics in
Cracow. We are creating cloud computing system based on Libvirt. Is
it possible to add link to our project at yours website in
applications section?
Title:
On Wed, Jul 18, 2012 at 09:19:05PM +0100, Daniel P. Berrange wrote:
On Sun, Jul 15, 2012 at 11:45:05PM +0200, Guido Günther wrote:
to query a guests's hostname. Containers like LXC and OpenVZ allow to
set a hostname different from the hosts name and QEMU's guest agent
could provide similar
Hi,
otherwise the directory returned by networkDnsmasqLeaseFileName will not
be created if ipdef-nhosts == 0 in networkBuildDnsmasqArgv.
O.k. to apply?
Cheers,
-- Guido
---
src/network/bridge_driver.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git
On Mon, Apr 25, 2011 at 03:05:51AM -0400, Laine Stump wrote:
On 04/24/2011 04:02 AM, Guido Günther wrote:
Hi,
otherwise the directory returned by networkDnsmasqLeaseFileName will not
be created if ipdef-nhosts == 0 in networkBuildDnsmasqArgv.
O.k. to apply?
Cheers,
-- Guido
that break compilation on non intel architectures:
mips:
https://buildd.debian.org/status/fetch.php?pkg=libvirtarch=mipsver=0.9.2-1stamp=1307570195
powerpc:
https://buildd.debian.org/status/fetch.php?pkg=libvirtarch=powerpcver=0.9.2-1stamp=1307550913
s390:
since the testfiles assume a /proc/cpuinfo specific to this
architecture. We e.g. can't parse the number of cores on other
architectures.
O.k. to apply?
Cheers,
-- Guido
---
tests/nodeinfotest.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/tests/nodeinfotest.c
since it's needed for the lock manager too. Fixes linking on non intel
architectures. See e.g.
https://buildd.debian.org/status/fetch.php?pkg=libvirtarch=mipsver=0.9.2-3stamp=1307914762
O.k. to apply?
Cheers,
-- Guido
---
configure.ac| 44 ++--
On Mon, Jun 13, 2011 at 04:22:56PM -0600, Eric Blake wrote:
s/superflous/superfluous/
On 06/11/2011 10:18 AM, Guido Günther wrote:
that break compilation on non intel architectures:
mips:
https://buildd.debian.org/status/fetch.php?pkg=libvirtarch=mipsver=0.9.2-1stamp=1307570195
On Mon, Jun 13, 2011 at 02:08:14PM -0600, Eric Blake wrote:
On 06/13/2011 01:54 PM, Guido Günther wrote:
since it's needed for the lock manager too. Fixes linking on non intel
architectures. See e.g.
https://buildd.debian.org/status/fetch.php?pkg=libvirtarch=mipsver=0.9.2-3stamp
Hi,
I'm seeing spurious test failures of test-nonblocking-pipe.sh on several
of Debian's autobuilders, e.g.:
https://buildd.debian.org/status/fetch.php?pkg=libvirtarch=mipselver=0.9.2-4stamp=1308020396
Since I can't reproduce this locally I wonder if somebody else is seeing
this?
Cheers,
--
On Tue, Jun 14, 2011 at 09:54:33AM -0600, Eric Blake wrote:
On 06/12/2011 04:37 PM, Guido Günther wrote:
since the testfiles assume a /proc/cpuinfo specific to this
architecture. We e.g. can't parse the number of cores on other
architectures.
O.k. to apply?
Cheers,
-- Guido
While we checked the return value we didn't maks sure ret != 0 which
resulted in dnsmasq errors being ignored.
---
src/network/bridge_driver.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index
On Sun, Jul 24, 2011 at 10:08:13AM -0400, Laine Stump wrote:
On 07/23/2011 05:26 PM, Guido Günther wrote:
While we checked the return value we didn't maks sure ret != 0 which
resulted in dnsmasq errors being ignored.
---
src/network/bridge_driver.c |4 +++-
1 files changed, 3
On Wed, Jul 27, 2011 at 10:53:01AM -0600, Eric Blake wrote:
[adding libvir-list]
On 07/27/2011 10:28 AM, Whit Blauvelt wrote:
Looks like my real problem may be not incorporating a Debian/Ubuntu patch
before building 0.9.x, since netcat differs:
Hi Eric,
On Wed, Jul 27, 2011 at 02:52:46PM -0600, Eric Blake wrote:
[..snip..]
Pasting from that URL gave awkward results below; can you address my
comments below, then post a v2 as a proper patch against
libvirt.git?
Thanks for the review! New version attached.
[..snip..]
I don't like
Quote strings so they're safe to pass to the shell. Based on glib's
g_quote_string.
---
src/libvirt_private.syms |1 +
src/util/buf.c | 29 +
src/util/buf.h |1 +
3 files changed, 31 insertions(+), 0 deletions(-)
diff --git
to quote the netcat command since it's passed to the shell. Adjust
expected test case output accordingly.
---
src/rpc/virnetsocket.c | 25 -
tests/virnetsockettest.c | 10 +-
2 files changed, 25 insertions(+), 10 deletions(-)
diff --git
Hi Eric,
On Mon, Aug 08, 2011 at 09:53:39AM -0600, Eric Blake wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=728772
points out that libvirt commit 1c93fbbb pulled in a gnulib
regression that broke large file support.
I had a quick look and rerunning this pulls in quite some auto* changes.
On Tue, Aug 09, 2011 at 10:54:36AM +0100, Daniel P. Berrange wrote:
On Mon, Aug 08, 2011 at 10:15:37PM +0200, Guido Günther wrote:
Hi Eric,
On Mon, Aug 08, 2011 at 09:53:39AM -0600, Eric Blake wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=728772
points out that libvirt commit
On Tue, Aug 09, 2011 at 09:24:55AM -0600, Eric Blake wrote:
On 08/09/2011 08:37 AM, Guido Günther wrote:
On Tue, Aug 09, 2011 at 10:54:36AM +0100, Daniel P. Berrange wrote:
On Mon, Aug 08, 2011 at 10:15:37PM +0200, Guido Günther wrote:
Hi Eric,
On Mon, Aug 08, 2011 at 09:53:39AM -0600, Eric
Hi,
virt-viewer is using it's own virEventRegisterImpl. With current libvirt
this can deadlock when connection to nonexistant URIs like
qemu+ssh:///unknownhost.example.com/system
like:
23:47:00.338: 1526: debug : doRemoteOpen:503 : proceeding with name =
qemu:///system
23:47:00.338: 1526:
Hi Daniel,
On Sat, Aug 13, 2011 at 08:57:45PM -0700, Daniel P. Berrange wrote:
On Fri, Aug 12, 2011 at 11:54:28PM +0200, Guido Günther wrote:
[..snip..]
In the default libvirt event loop, the 'ff' callback is always invoked
from a clean stack in the event loop, so you never have this problem
On Thu, Jun 18, 2009 at 12:20:40PM -0400, Jim Paris wrote:
Daniel P. Berrange wrote:
We close the socket to the 'nc' process here so in theory it should
be getting a HUP event from poll or EOF from read, etc and then
exiting. Ominously though I see several patches to Fedora's 'nc'
RPM at
On Wed, Jul 01, 2009 at 10:58:57PM +0100, Andreas Sommer wrote:
I'm still experimenting around with the vTPM patch, and I want to
install my version of libvirt on a Debian system - not in my $HOME
directory but on the default paths. I followed the autogen command below
and also did make
Hi,
in current git make distcheck currently fails on me with:
make[5]: Entering directory
`/var/scratch/debian/libvirt/cvs/libvirt/libvirt-0.6.5/_build/gnulib/lib'
/bin/sh ../../../mylibtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I.
-I../../../gnulib/lib -I../.. -I../../intl -g -O2
Hi,
attached patch makes the path to the xen userspace tools configurable.
Debian keeps this under /usr/lib/xen-default/ instead of /usr/lib/xen/.
We don't have the amd64 libs in /usr/lib64/xen either so we can use:
./configure --with-xen-tools=/usr/lib/xen-defaults
On Tue, Jul 07, 2009 at 06:02:20PM +0100, Daniel P. Berrange wrote:
On Tue, Jul 07, 2009 at 01:16:02PM +0200, Guido G?nther wrote:
Hi,
attached patch makes the path to the xen userspace tools configurable.
Debian keeps this under /usr/lib/xen-default/ instead of /usr/lib/xen/.
We don't
Hi,
the python example imports pygtk but uses gtk.main() so it fails to
work. Attached patch fixes this.
Cheers,
-- Guido
From: =?utf-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
Date: Wed, 22 Jul 2009 12:00:47 +0200
Subject: [PATCH] use gtk instead of pygtk
the example uses gtk.* everywhere
Hi,
the python example is lacking the details argument in the callback. This
makes the example fail due to the wrong number of arguments.
Cheers,
-- Guido
From: =?utf-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
Date: Wed, 22 Jul 2009 12:01:36 +0200
Subject: [PATCH] add missing details argument
Hi,
attached patch updates the console docs a bit. O.k. to apply?
Cheers,
-- Guido
From 204361a3f015601e389f9ab83a2590906cb44581 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
Date: Thu, 23 Jul 2009 09:39:22 +0200
Subject: [PATCH] document tcp listen and raw wire
On Wed, Jul 29, 2009 at 10:33:12AM +0100, Daniel P. Berrange wrote:
[..snip..]
FYI, my libvirt-glib work is temporarily on hold due to lack of time.
As such I've just pulled the event loop code directly into the
virt-viewer application, so I can do a release of virt-viewer without
needing
On Wed, Jul 29, 2009 at 12:50:17PM +0100, Daniel P. Berrange wrote:
On Wed, Jul 29, 2009 at 01:24:24PM +0200, Guido G?nther wrote:
On Wed, Jul 29, 2009 at 10:33:12AM +0100, Daniel P. Berrange wrote:
[..snip..]
FYI, my libvirt-glib work is temporarily on hold due to lack of time.
As
On Thu, Aug 06, 2009 at 02:37:53PM +0200, Daniel Veillard wrote:
On Thu, Aug 06, 2009 at 12:39:34PM +0100, Daniel P. Berrange wrote:
On Wed, Aug 05, 2009 at 12:58:33PM +0200, Jonas Eriksson wrote:
* src/remote_internal.c: Honour USE_SOCAT by selecting between
netcat/nc and socat at
Hi Daniel,
On Fri, Oct 23, 2009 at 02:05:39PM +0100, Daniel P. Berrange wrote:
The daemonizing code lets the parent exit almost immediately. This
means that it may think it has successfully started even when
important failures occur like not being able to acquire the PID
file. It also means
On Wed, Oct 28, 2009 at 06:52:49PM +, Daniel P. Berrange wrote:
On Wed, Oct 28, 2009 at 03:22:38PM +0100, Guido G?nther wrote:
Hi Daniel,
On Fri, Oct 23, 2009 at 02:05:39PM +0100, Daniel P. Berrange wrote:
The daemonizing code lets the parent exit almost immediately. This
means that
Hi,
attached patch makes sure we only remove the masquerade rules if
forwardType == VIR_NETWORK_FORWARD_NAT and not if forwardType ==
VIR_NETWORK_FORWARD_ROUTE since we don't use them there. This fixes:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=549949
O.k. to apply?
-- Guido
From
On Thu, Nov 05, 2009 at 08:35:20PM +0100, Guido Günther wrote:
Hi,
attached patch makes sure we only remove the masquerade rules if
forwardType == VIR_NETWORK_FORWARD_NAT and not if forwardType ==
VIR_NETWORK_FORWARD_ROUTE since we don't use them there. This fixes:
http
On Sun, Nov 15, 2009 at 11:56:37AM -0500, Cole Robinson wrote:
On 11/13/2009 12:18 PM, Guido Günther wrote:
On Thu, Nov 05, 2009 at 08:35:20PM +0100, Guido Günther wrote:
Hi,
attached patch makes sure we only remove the masquerade rules if
forwardType == VIR_NETWORK_FORWARD_NAT
Otherwise the build fails with:
/usr/bin/ld: conn_test-conn-test.o: undefined reference to symbol
'g_type_check_instance_cast'
/usr/bin/ld: note: 'g_type_check_instance_cast' is defined in DSO
/usr/lib/libgobject-2.0.so.0 so try adding it to the linker command line
/usr/lib/libgobject-2.0.so.0:
On Mon, Oct 03, 2011 at 09:43:32AM +0100, Daniel P. Berrange wrote:
On Sun, Oct 02, 2011 at 02:02:12PM +0200, Guido Günther wrote:
Otherwise the build fails with:
/usr/bin/ld: conn_test-conn-test.o: undefined reference to symbol
'g_type_check_instance_cast'
/usr/bin/ld: note
On Tue, Aug 16, 2011 at 02:24:53PM +0200, Guido Günther wrote:
Hi Daniel,
On Sat, Aug 13, 2011 at 08:57:45PM -0700, Daniel P. Berrange wrote:
On Fri, Aug 12, 2011 at 11:54:28PM +0200, Guido Günther wrote:
[..snip..]
In the default libvirt event loop, the 'ff' callback is always invoked
On Tue, Oct 04, 2011 at 09:00:17AM +0100, Daniel P. Berrange wrote:
On Mon, Oct 03, 2011 at 10:41:17PM +0200, Guido Günther wrote:
On Tue, Aug 16, 2011 at 02:24:53PM +0200, Guido Günther wrote:
Hi Daniel,
On Sat, Aug 13, 2011 at 08:57:45PM -0700, Daniel P. Berrange wrote:
On Fri, Aug
O.k. to apply?
-- Guido
---
src/xenxs/xen_xm.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/xenxs/xen_xm.c b/src/xenxs/xen_xm.c
index d057043..30188e2 100644
--- a/src/xenxs/xen_xm.c
+++ b/src/xenxs/xen_xm.c
@@ -697,8 +697,8 @@ xenParseXM(virConfPtr conf,
otherwise a missing UUID in a domain config just shows:
libxlDomainXMLFromNative:2600 : Internal Error parsing xm config failed
Now we have:
xenXMConfigGetUUID:186 : Internal Error config value uuid was missing
O.k. to apply?
-- Guido
---
src/xenxs/xen_xm.c | 37
On Thu, Oct 06, 2011 at 11:56:29AM +0200, Michal Privoznik wrote:
On 06.10.2011 11:16, Guido Günther wrote:
O.k. to apply?
-- Guido
---
src/xenxs/xen_xm.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/xenxs/xen_xm.c b/src/xenxs/xen_xm.c
On Thu, Oct 06, 2011 at 11:56:29AM +0200, Michal Privoznik wrote:
On 06.10.2011 11:16, Guido Günther wrote:
O.k. to apply?
-- Guido
---
src/xenxs/xen_xm.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/xenxs/xen_xm.c b/src/xenxs/xen_xm.c
On Thu, Oct 06, 2011 at 08:27:42AM -0600, Eric Blake wrote:
On 10/06/2011 05:38 AM, Guido Günther wrote:
...and here's the doc update.
-- Guido
0001-Document-STREQ_NULLABLE-and-STRNEQ_NULLABLE.patch
From 07b8940e3bb64e2208b191d890e95f059a7ac7a9 Mon Sep 17 00:00:00 2001
From: =?UTF
Hi Eric,
On Thu, Oct 06, 2011 at 10:50:46AM -0600, Eric Blake wrote:
On 10/06/2011 03:15 AM, Guido Günther wrote:
otherwise a missing UUID in a domain config just shows:
libxlDomainXMLFromNative:2600 : Internal Error parsing xm config failed
Now we have:
xenXMConfigGetUUID:186
On Thu, Oct 06, 2011 at 12:44:05PM -0600, Eric Blake wrote:
On 10/06/2011 05:36 AM, Guido Günther wrote:
In fact I was looking for that kind of function in hacking.html. New
patch attached.
Cheers,
-- Guido
0001-xenParseXM-don-t-dereference-NULL-pointer-when-scrip.patch
From
On Thu, Oct 06, 2011 at 08:54:22AM -0600, Eric Blake wrote:
On 10/06/2011 08:52 AM, Guido Günther wrote:
ACK. But be sure you also run 'make check', then squash in the
regeneration of HACKING prior to pushing your commit.
I had to do a explicit make HACKING to get this regenerated. Pushed
On Thu, Oct 06, 2011 at 03:55:48PM -0400, Laine Stump wrote:
On 10/06/2011 01:36 PM, Guido Günther wrote:
Hi Eric,
On Thu, Oct 06, 2011 at 10:50:46AM -0600, Eric Blake wrote:
These three errors should probably all be changed away from
VIR_ERR_INTERNAL_ERROR into something more useful
On Thu, Oct 06, 2011 at 04:33:49PM -0600, Eric Blake wrote:
On 10/06/2011 11:36 AM, Guido Günther wrote:
These three errors should probably all be changed away from
VIR_ERR_INTERNAL_ERROR into something more useful, but I'm not sure
whether that would be VIR_ERR_CONF_SYNTAX
Hi,
attached patch is needed to properly skip the SELinux tests if SELinux
isn't enabled.
Cheers,
-- Guido
From 8647fef32cdc13636ee86a937f854cdb931added Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
Date: Fri, 7 Oct 2011 16:31:42 +0200
Subject: [PATCH] Use SKIP
On Fri, Oct 07, 2011 at 08:51:47AM -0600, Eric Blake wrote:
On 10/07/2011 08:35 AM, Guido Günther wrote:
Hi,
attached patch is needed to properly skip the SELinux tests if SELinux
isn't enabled.
Cheers,
-- Guido
ACK.
Pushed. Thanks,
-- Guido
--
libvir-list mailing list
libvir-list
On Fri, Oct 07, 2011 at 12:18:51PM +0200, Guido Günther wrote:
On Thu, Oct 06, 2011 at 04:33:49PM -0600, Eric Blake wrote:
On 10/06/2011 11:36 AM, Guido Günther wrote:
These three errors should probably all be changed away from
VIR_ERR_INTERNAL_ERROR into something more useful, but I'm
On Mon, Oct 10, 2011 at 01:23:20PM -0600, Eric Blake wrote:
On 10/07/2011 04:18 AM, Guido Günther wrote:
ACK to the concept, once we decide on the correct error code.
I think we've decided.
(Hopefully) final version attached. I've left the first error as
INTERNAL_ERROR since this it's
On Mon, Oct 10, 2011 at 01:24:35PM -0600, Eric Blake wrote:
On 10/10/2011 09:14 AM, Guido Guenther wrote:
On xen 4.1 I observied configurations that look like:
s/observied/observed/
(image
(hvm
(kernel '')
(loader '/foo/bar')
))
The kernel element is there
Hi,
having JUnit like XML allows for easy integration into CI tools like
Jenkins. Attach patch adds this using TAP::Formatter::JUnit.
Does this look reasonable?
-- Guido
From 85880da3060dfad62183bb7c8ab881a345dacd3e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
On Tue, Oct 11, 2011 at 08:41:09AM +0100, Daniel P. Berrange wrote:
On Mon, Oct 10, 2011 at 04:15:47PM -0600, Eric Blake wrote:
On 10/10/2011 03:46 PM, Guido Günther wrote:
Hi,
having JUnit like XML allows for easy integration into CI tools like
Jenkins. Attach patch adds this using TAP
Hi,
I got a bit confused how snapshotting/reverting is supposed to work now
so I added some tests. O.k. to apply?
This requires Sys::Virt 0.9.5.
Cheers,
-- Guido
---
Build.PL |2 +-
perl-Sys-Virt-TCK.spec.PL |2 +-
scripts/domain/400-snapshots.t | 127
On Tue, Oct 11, 2011 at 02:57:20PM +0100, Daniel P. Berrange wrote:
On Tue, Oct 11, 2011 at 03:44:32PM +0200, Guido Günther wrote:
On Tue, Oct 11, 2011 at 08:41:09AM +0100, Daniel P. Berrange wrote:
On Mon, Oct 10, 2011 at 04:15:47PM -0600, Eric Blake wrote:
On 10/10/2011 03:46 PM, Guido
On Tue, Oct 11, 2011 at 08:33:49AM -0600, Eric Blake wrote:
On 10/11/2011 07:47 AM, Guido Günther wrote:
Hi,
I got a bit confused how snapshotting/reverting is supposed to work now
so I added some tests. O.k. to apply?
This requires Sys::Virt 0.9.5.
Cheers,
-- Guido
I haven't looked
Hi,
when looking at the DomainSnapshot docs I wondered if these also take
the flags argument as the other functions so I went ahead and updated
the docs after checking the source.
Cheers,
-- Guido
---
lib/Sys/Virt/DomainSnapshot.pm | 16 ++--
1 files changed, 10 insertions(+), 6
On Wed, Oct 12, 2011 at 08:53:31PM +0100, Daniel P. Berrange wrote:
On Wed, Oct 12, 2011 at 09:48:39PM +0200, Guido Günther wrote:
Hi,
when looking at the DomainSnapshot docs I wondered if these also take
the flags argument as the other functions so I went ahead and updated
the docs after
Hi,
Finally here's a respin of the netcat detection when used over SSH.
Changes are:
* virBufferQuoteString renamed to virBufferEscapeShell
* Use outer quote only when metacharacters show up
* Make a pessimistic buffer allocation instead of resizing it all the
time
Cheers,
-- Guido
Guido
Escape strings so they're safe to pass to the shell. Based on glib's
g_quote_string.
---
src/libvirt_private.syms |1 +
src/util/buf.c | 54 ++
src/util/buf.h |1 +
3 files changed, 56 insertions(+), 0 deletions(-)
diff
to escape the netcat command since it's passed to the shell. Adjust
expected test case output accordingly.
---
src/rpc/virnetsocket.c | 25 -
tests/virnetsockettest.c | 10 +-
2 files changed, 25 insertions(+), 10 deletions(-)
diff --git
Based on a patch by Marc Deslauriers marc.deslauri...@ubuntu.com
RH: https://bugzilla.redhat.com/show_bug.cgi?id=562176
Ubuntu: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/517478
Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=573172
---
src/rpc/virnetsocket.c | 23
so execution times can be reported too.
---
bin/libvirt-tck | 11 ++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/bin/libvirt-tck b/bin/libvirt-tck
index dcb053c..816234b 100644
--- a/bin/libvirt-tck
+++ b/bin/libvirt-tck
@@ -109,6 +109,10 @@ Generate an archive
On Thu, Oct 13, 2011 at 12:12:10PM +0100, Daniel P. Berrange wrote:
On Thu, Oct 13, 2011 at 01:05:59PM +0200, Guido Günther wrote:
so execution times can be reported too.
---
bin/libvirt-tck | 11 ++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/bin
On Mon, Oct 03, 2011 at 04:07:23PM +0200, Michal Privoznik wrote:
This element says what to do with cdrom (or floppy) on migration.
Currently, only one attribute is supported: 'optional'. It accepts
'require', 'optional' and 'drop' values. Setting a cdrom to be
required means migration will
On Wed, Oct 12, 2011 at 05:22:02PM -0600, Eric Blake wrote:
On 10/12/2011 04:40 PM, Guido Günther wrote:
to escape the netcat command since it's passed to the shell. Adjust
expected test case output accordingly.
---
src/rpc/virnetsocket.c | 25 -
tests
---
tools/virsh.c | 25 +
1 files changed, 5 insertions(+), 20 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index bcf0603..fe1a224 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -12340,27 +12340,12 @@ cmdEcho (vshControl *ctl ATTRIBUTE_UNUSED, const
On Wed, Oct 12, 2011 at 05:16:35PM -0600, Eric Blake wrote:
On 10/12/2011 04:39 PM, Guido Günther wrote:
Escape strings so they're safe to pass to the shell. Based on glib's
g_quote_string.
Is this still true, or does it now resemble more what I did
(independently from g_quote_string
Hi Eric,
On Wed, Oct 12, 2011 at 05:03:45PM -0600, Eric Blake wrote:
On 10/12/2011 04:39 PM, Guido Günther wrote:
Based on a patch by Marc Deslauriersmarc.deslauri...@ubuntu.com
RH: https://bugzilla.redhat.com/show_bug.cgi?id=562176
Ubuntu: https://bugs.launchpad.net/ubuntu/+source/libvirt
On Thu, Oct 13, 2011 at 11:03:05PM +0200, Guido Günther wrote:
---
tools/virsh.c | 25 +
1 files changed, 5 insertions(+), 20 deletions(-)
I just noticed that this breaks the testsuite for two reasons:
cmdEcho emits '' in case of an *arg == 0 and it also allows
On Thu, Oct 13, 2011 at 03:25:10PM -0600, Eric Blake wrote:
On 10/13/2011 03:02 PM, Guido Günther wrote:
On Wed, Oct 12, 2011 at 05:16:35PM -0600, Eric Blake wrote:
On 10/12/2011 04:39 PM, Guido Günther wrote:
Escape strings so they're safe to pass to the shell. Based on glib's
g_quote_string
Fix typo that breaks setting the backing store format.
---
lib/Sys/Virt/TCK/StorageVolBuilder.pm |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/Sys/Virt/TCK/StorageVolBuilder.pm
b/lib/Sys/Virt/TCK/StorageVolBuilder.pm
index 515795f..da90788 100644
---
On Fri, Oct 14, 2011 at 10:39:12AM +0100, Daniel P. Berrange wrote:
On Fri, Oct 14, 2011 at 11:36:14AM +0200, Guido Günther wrote:
Fix typo that breaks setting the backing store format.
---
lib/Sys/Virt/TCK/StorageVolBuilder.pm |2 +-
1 files changed, 1 insertions(+), 1 deletions
What holds for netcat is also true for the socket path since it can be
part of the connection URI as well. Make both subject to the same amount
of shell parsing.
Cheers,
-- Guido
---
src/rpc/virnetsocket.c | 30 +-
tests/virnetsockettest.c | 14 +++---
When checking if we need to escape a single quote we were looking at the
character after the quote instead of at the quote itself.
---
src/util/buf.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/util/buf.c b/src/util/buf.c
index 7dd9852..2d9499a 100644
---
On Tue, Oct 18, 2011 at 08:39:48AM -0600, Eric Blake wrote:
On 10/18/2011 01:31 AM, Guido Günther wrote:
When checking if we need to escape a single quote we were looking at the
character after the quote instead of at the quote itself.
---
src/util/buf.c |4 ++--
1 files changed, 2
---
tools/virsh.c | 39 ++-
1 files changed, 18 insertions(+), 21 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 54684f6..d45baa6 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -12322,7 +12322,7 @@ static const vshCmdOptDef opts_echo[] = {
---
src/qemu/qemu_monitor.c | 49 --
src/qemu/qemu_monitor.h |1 -
2 files changed, 5 insertions(+), 45 deletions(-)
diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
index c9dd69e..182e63d 100644
--- a/src/qemu/qemu_monitor.c
+++
Make the empty string return '' to match cmdEcho's behavior.
---
src/util/buf.c | 15 ++-
1 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/src/util/buf.c b/src/util/buf.c
index f582cd2..b7fcf6d 100644
--- a/src/util/buf.c
+++ b/src/util/buf.c
@@ -507,15 +507,20 @@
On Fri, Oct 14, 2011 at 08:28:48AM -0600, Eric Blake wrote:
On 10/14/2011 06:18 AM, Guido Günther wrote:
What holds for netcat is also true for the socket path since it can be
part of the connection URI as well. Make both subject to the same amount
of shell parsing.
Hmm, I'm not sure about
The attached patches use virBufferEscapeShell in virsh's virCmd and
eliminate qemuMonitorEscapeShell so we have only one function that does
the shell escaping.
Cheers,
-- Guido
Guido Günther (3):
virBufferEscapeShell: Emit quotes for the empty string
Use virBufferEscapeShell in cmdEcho
On Tue, Oct 18, 2011 at 02:09:55PM -0600, Eric Blake wrote:
On 10/18/2011 01:35 PM, Guido Günther wrote:
Make the empty string return '' to match cmdEcho's behavior.
---
src/util/buf.c | 15 ++-
1 files changed, 10 insertions(+), 5 deletions(-)
ACK.
Pushed the whole series
Hi,
Migration will be disallowed when the vm uses host devices or has
snapshots (qemuMigrationIsAllowed)[1]. Would it make sense to introduce
a VIR_MIGRATE_FORCE similar to VIR_REVERT_FORCE here? We could then
introduce error codes similar to the snapshot case
(VIR_ERR_MIGRATE_RISKY).
This path
On Mon, Oct 24, 2011 at 04:12:08PM -0600, Eric Blake wrote:
On 10/24/2011 02:00 AM, Daniel P. Berrange wrote:
On Fri, Oct 21, 2011 at 08:16:24PM +0200, Guido Günther wrote:
Hi,
Migration will be disallowed when the vm uses host devices or has
snapshots (qemuMigrationIsAllowed)[1]. Would
Hi Daniel,
On Tue, Oct 11, 2011 at 11:26:59AM +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
If we are comparing storage pools we must skip comparing with
ourself, so that re-defining an existing pool works
* conf/storage_conf.c: Skip self when comparing
401 - 500 of 1099 matches
Mail list logo
