This way we don't have to bother about stdin/stdout/stderr on reconnect.
Since we dup stdin/stderr on the logfile we need to reparse it for the
monitor path.
Cheers,
-- Guido
---
src/domain_conf.h |1 +
src/qemu_driver.c | 155 +++--
2 files
On Mon, Jan 19, 2009 at 04:37:43PM +0100, Daniel Veillard wrote:
On Sun, Jan 18, 2009 at 08:28:05PM +0100, Guido Günther wrote:
This one is as posted before. Not really necessary, but makes things look
nicer.
-- Guido
Looks fine, please commit,
Applied.
-- Guido
--
Libvir-list
On Mon, Jan 19, 2009 at 01:31:17PM +, Daniel P. Berrange wrote:
On Sun, Jan 18, 2009 at 08:28:13PM +0100, Guido G?nther wrote:
so they doen't get killed when the libvirtd quits unexpectedly
changes:
* longer timeouts when waiting for procs to show up
* check if process exists
Hi,
On Mon, Jan 19, 2009 at 01:38:22PM +, Daniel P. Berrange wrote:
/* Got them all, so now open the monitor console */
-ret = qemudOpenMonitor(conn, vm, monitor);
+qemuDriverLock(driver);
+ret = qemudOpenMonitor(conn, driver, vm, monitor, 0);
+
On Mon, Jan 19, 2009 at 01:39:51PM +, Daniel P. Berrange wrote:
+vm-stdout_fd = vm-stderr_fd = vm-logfile;
If nothing is actaully using the stdout/err FDs anymore we can just
leave them at -1.
Fixed in the attached patch.
-- Guido
From 88002890116720af5dc4c331af6c2b7e90670639
Hi,
After applying the previous two patches the qemu driver doesn't need
these anymore and they can then be removed from lxc/uml as well.
-- Guido
From 2be075e11c0df03de29afdf0b0a05db2d06b4386 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
Date: Tue, 20 Jan 2009
On Tue, Jan 20, 2009 at 11:08:56PM +, Daniel P. Berrange wrote:
[..snip..]
+static int
+qemudInitPasswords(virConnectPtr conn,
+ virDomainObjPtr vm) {
+char *info = NULL;
+
+/*
+ * NB: Might have more passwords to set in the future. eg a qcow
+ * disk
Hi,
attached patch lets virsh work with missing locales. This is:
http://bugs.debian.org/512721
Cheers,
-- Guido
From cb456e15dba480640508df4c4250234f30172083 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
Date: Fri, 23 Jan 2009 16:25:33 +0100
Subject: [PATCH]
On Fri, Jan 23, 2009 at 04:29:24PM +, Daniel P. Berrange wrote:
On Fri, Jan 23, 2009 at 04:55:22PM +0100, Guido G?nther wrote:
Hi,
attached patch lets virsh work with missing locales. This is:
http://bugs.debian.org/512721
ACK, but can you add a comment below perror explaining why
On Fri, Jan 30, 2009 at 11:37:35AM +, Daniel P. Berrange wrote:
diff -r 826e6ed70ee0 src/qemu_driver.c
--- a/src/qemu_driver.c Fri Jan 30 10:58:34 2009 +
+++ b/src/qemu_driver.c Fri Jan 30 11:00:43 2009 +
@@ -355,10 +355,9 @@ qemudReconnectVMs(struct qemud_driver *d
Hi,
we currently don't report errors to save qemu's domain status file back
to the caller. That was o.k. as long as the code was there for testing
but now that the XML is being picked up on daemon restart we must
handle these.
The attached patch does that, although I'm not confident that it's
On Sat, Jan 31, 2009 at 12:25:54PM +0100, Jim Meyering wrote:
Guido Günther a...@sigxcpu.org wrote:
attached patch removes the hardcoded port 22 when going through ssh, ssh
uses it by default. This makes it easier to override this via
.ssh/config on a per host basis instead of having to add
Hi Daniel,
On Fri, Jan 30, 2009 at 11:37:35AM +, Daniel P. Berrange wrote:
@@ -670,11 +674,17 @@ qemudReadMonitorOutput(virConnectPtr con
_(Failure while reading %s startup
output), what);
return -1;
}
+} else if
On Sat, Jan 31, 2009 at 02:32:09PM +0100, Guido Günther wrote:
we currently don't report errors to save qemu's domain status file back
to the caller. That was o.k. as long as the code was there for testing
but now that the XML is being picked up on daemon restart we must
handle these.
Any
On Fri, Feb 06, 2009 at 10:33:51AM +0100, Farkas Levente wrote:
if ret is None:raise libvirtError('virDomainCreateLinux() failed',
conn=self)
libvirtError: internal error unable to start guest:
I'm currently working around this with:
diff --git a/src/qemu_driver.c b/src/qemu_driver.c
index
On Fri, Feb 06, 2009 at 04:48:09PM +, Daniel P. Berrange wrote:
On Fri, Feb 06, 2009 at 05:27:47PM +0100, Guido G?nther wrote:
On Fri, Feb 06, 2009 at 10:33:51AM +0100, Farkas Levente wrote:
if ret is None:raise libvirtError('virDomainCreateLinux() failed',
conn=self)
Hi,
attached patch makes sure we set a proper error status when the domain
doesn't show up. O.k. to apply?
Cheers,
-- Guido
From f7a6fa53008ab17eab04d63a53a33bfd455bc596 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
Date: Sat, 7 Feb 2009 17:14:26 +0100
Subject:
On Fri, Feb 06, 2009 at 04:48:09PM +, Daniel P. Berrange wrote:
On Fri, Feb 06, 2009 at 05:27:47PM +0100, Guido G?nther wrote:
On Fri, Feb 06, 2009 at 10:33:51AM +0100, Farkas Levente wrote:
if ret is None:raise libvirtError('virDomainCreateLinux() failed',
conn=self)
On Thu, Feb 05, 2009 at 06:49:52PM +0100, Jim Meyering wrote:
Guido Günther a...@sigxcpu.org wrote:
we currently don't report errors to save qemu's domain status file back
to the caller. That was o.k. as long as the code was there for testing
but now that the XML is being picked up
On Mon, Feb 09, 2009 at 11:30:30AM -0500, Cole Robinson wrote:
[..snip..]
No fault of this patch, but this makes me ask the question: what exactly
are attachDevice and detachDevice supposed to do?
In the qemu driver, it is entirely hotplug/hotunplug, and deliberately
fails on an inactive
On Mon, Feb 09, 2009 at 10:49:08AM +, Daniel P. Berrange wrote:
On Sat, Feb 07, 2009 at 06:04:22PM +0100, Guido G?nther wrote:
Hi,
attached patch makes sure we set a proper error status when the domain
doesn't show up. O.k. to apply?
ACK, this is quite a nasty scenario - we have to
On Mon, Feb 09, 2009 at 11:02:58AM +, Daniel P. Berrange wrote:
On Sat, Feb 07, 2009 at 06:05:51PM +0100, Guido G?nther wrote:
The problem is that we're using this function for two purposes: To read
from a logfile where poll()'ing on POLLIN always returns data readable
which leaves us
On Fri, Feb 13, 2009 at 07:07:49PM +0100, Jim Meyering wrote:
Here's a proposed patch to make it use better types
(always suspect that using int is wrong ;-).
What about the attached version?
-- Guido
From 5b2c2328195f0cf4eb32d2da1d5a5ef57b2fede4 Mon Sep 17 00:00:00 2001
From:
On Fri, Feb 13, 2009 at 05:00:40PM +, Daniel P. Berrange wrote:
[..snip..]
We cannot guarentee whether the active hotplugging will update the
persistent config or not, but if possible it should. Currenty XenD
appears to update the config from what I see, though haven't tested
it for real
On Sat, Feb 14, 2009 at 03:42:00PM +0100, Jim Meyering wrote:
Guido Günther a...@sigxcpu.org wrote:
On Fri, Feb 13, 2009 at 07:07:49PM +0100, Jim Meyering wrote:
Here's a proposed patch to make it use better types
(always suspect that using int is wrong ;-).
What about the attached
On Fri, Feb 20, 2009 at 05:14:54PM -0500, David Allan wrote:
This patch contains the implementation Daniel Berrange did of storage
pools using SCSI HBAs. I have updated it for the current tree in
preparation for implementing NPIV support. Let me know what you
think.
This looks like a great
On Mon, Feb 23, 2009 at 09:41:20PM -0500, Dave Allan wrote:
Guido Günther wrote:
On Mon, Feb 23, 2009 at 07:53:07PM +, Daniel P. Berrange wrote:
On Mon, Feb 23, 2009 at 06:03:07PM +0100, Guido G?nther wrote:
On Fri, Feb 20, 2009 at 05:14:54PM -0500, David Allan wrote:
This patch contains
Hi,
determines the maximum needed buffersize for getgrnam_r using sysconf
instead of hardcoding it to 1024 and increases the buffer on ERANGE.
The latter is needed since sysconf is allowed to return -1. Furthermore
some glibc versions seem to return a too small buffer on amd64
On Thu, Apr 16, 2009 at 09:56:27AM +0200, Daniel Veillard wrote:
On Thu, Apr 16, 2009 at 09:19:38AM +0200, Guido Günther wrote:
Hi,
determines the maximum needed buffersize for getgrnam_r using sysconf
instead of hardcoding it to 1024 and increases the buffer on ERANGE.
The latter
Hi,
currently every monitor command is dumped into the domain logfiles, this
can lead to huge logs[1]. Since we're not going through the normal
logging facilites to get per domain logfiles we should at least resepct
the default priority.
Cheers,
-- Guido
[1] http://bugs.debian.org/524145
From
On Thu, Apr 16, 2009 at 01:29:08PM +0100, Daniel P. Berrange wrote:
On Thu, Apr 16, 2009 at 02:17:29PM +0200, Guido G?nther wrote:
Hi,
currently every monitor command is dumped into the domain logfiles, this
can lead to huge logs[1]. Since we're not going through the normal
logging
16, 2009 at 09:19:38AM +0200, Guido Günther wrote:
Hi,
determines the maximum needed buffersize for getgrnam_r using sysconf
instead of hardcoding it to 1024 and increases the buffer on ERANGE.
The latter is needed since sysconf is allowed to return -1. Furthermore
some glibc
Hi Ryota,
On Thu, Apr 16, 2009 at 11:24:10PM +0900, Ryota Ozaki wrote:
+#ifdef HAVE_GETPWNAM_R
+int virGetUIDByUsername(virConnectPtr conn, char *name)
+{
+struct passwd pwbuf;
+struct passwd *pw = NULL;
+char *strbuf;
+size_t strbuflen = sysconf(_SC_GETPW_R_SIZE_MAX);
+
On Thu, Apr 16, 2009 at 02:40:44PM +0100, Daniel P. Berrange wrote:
On Thu, Apr 16, 2009 at 02:14:13PM +0200, Guido G?nther wrote:
On Thu, Apr 16, 2009 at 09:56:27AM +0200, Daniel Veillard wrote:
On Thu, Apr 16, 2009 at 09:19:38AM +0200, Guido Günther wrote:
Hi,
determines
Hi,
I broke make syntax-check by forgetting to set a C locale. O.k. to
apply:
diff --git a/ChangeLog b/ChangeLog
index 18845e1..96ac44a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,4 +1,4 @@
-Do Apr 16 17:48:30 CEST 2009 Guido Günther a...@sigxcpu.org
+Thu Apr 16 17:48:30 CEST 2009 Guido Günther
On Fri, Apr 17, 2009 at 10:00:29AM +0200, Daniel Veillard wrote:
On Thu, Apr 16, 2009 at 07:17:46PM +0200, Guido Günther wrote:
Hi,
I broke make syntax-check by forgetting to set a C locale. O.k. to
apply:
okay
Committed. The problem here is that one usually runs make syntax-check
On Sat, May 02, 2009 at 04:23:54PM +, Frederik Himpe wrote:
The following patch is needed to make sure libvirt is not
started too early in the boot sequence on Mandriva.
--- libvirt-0.6.1/qemud/libvirtd.init.in.orig 2009-03-05 19:34:05.0
+0100
+++
On Sat, May 02, 2009 at 07:48:50PM +0200, jens wrote:
Hello,
I tried to migrate a kvm domain to a second identical machine with the
command:
virsh migrate --live dom1 qemu+ssh://second.machine.org/system which
leads me to an unresponsive virsh on the second machine - 'virsh list'
just
On Sun, May 03, 2009 at 09:21:20PM +0200, Felix Schwarz wrote:
So how can I use USB pass through? Could this be Windows-related? Judging from
all the other threads (like [1]) it should be really easy to use.
Yes, it usually is. I had problems with older KVM as well. Try updating
to 84 or 85.
In this case we reference def with is NULL. O.k. to apply?
Cheers,
-- Guido
From ff82eb24e50b4f80769bd932ca739e8a2539edb4 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
Date: Mon, 4 May 2009 21:29:15 +0200
Subject: [PATCH 1/2] don't crash with def == NULL
Hi,
attached patch makes it easier to detect bogus paths when
creating/removing pidfiles. O.k. to apply?
Cheers,
-- Guido
From f79fcd99b28e36cbb80bd91ac52109148eafa814 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
Date: Mon, 4 May 2009 21:31:57 +0200
Subject:
On Tue, May 05, 2009 at 10:38:12AM +0100, Daniel P. Berrange wrote:
On Mon, May 04, 2009 at 09:40:33PM +0200, Guido G?nther wrote:
Hi,
attached patch makes it easier to detect bogus paths when
creating/removing pidfiles. O.k. to apply?
ACK
Applied.
-- Guido
--
Libvir-list mailing list
On Tue, May 05, 2009 at 10:37:49AM +0100, Daniel P. Berrange wrote:
On Mon, May 04, 2009 at 09:39:04PM +0200, Guido G?nther wrote:
In this case we reference def with is NULL. O.k. to apply?
Cheers,
ACK, but what code would call libvirt_lx without args ?
No code but a human being (me in
Hi,
virsh fails with:
10:47:37.104: debug : do_open:922 : no name, allowing driver auto-select
10:47:37.104: debug : do_open:930 : trying driver 0 (Test) ...
10:47:37.104: debug : do_open:936 : driver 0 Test returned DECLINED
10:47:37.104: debug : do_open:930 : trying driver 1 (OPENVZ) ...
Hi,
not having set up pfuncs already results in a core dump. O.k. to
apply?
Cheers,
-- Guido
From f01472982e8a00c98937a6f4a41c59a061a9ed98 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
Date: Thu, 7 May 2009 10:31:21 +0200
Subject: [PATCH] don't crash if init
On Thu, May 07, 2009 at 11:25:49AM +0200, Pritesh Kothari wrote:
On Thursday 07 May 2009 10:52:15 Guido Günther wrote:
Hi,
not having set up pfuncs already results in a core dump. O.k. to
apply?
ACK,
Applied now.
-- Guido
--
Libvir-list mailing list
Libvir-list@redhat.com
https
On Thu, May 07, 2009 at 10:25:34AM +0100, Daniel P. Berrange wrote:
On Thu, May 07, 2009 at 11:19:01AM +0200, Pritesh Kothari wrote:
On Thursday 07 May 2009 10:50:54 Guido Günther wrote:
Hi,
virsh fails with:
10:47:37.104: debug : do_open:922 : no name, allowing driver auto-select
On Fri, May 08, 2009 at 05:42:07PM +0100, Daniel P. Berrange wrote:
The patches we just applied for the VirtualBox open method still were
not quite right. It would return VIR_DRV_OPEN_DECLINED when uri==NULL,
but before doing so it would have set conn-uri to vbox:///session. So
even though
Hi,
On Tue, Apr 06, 2010 at 12:50:31PM +, Frederik Himpe wrote:
I updated my system from libvirt 0.7.1 to 0.7.7, one of my qemu-kvm VMs
was not starting anymore, with this error:
LC_ALL=C PATH=/sbin:/usr/sbin:/bin:/usr/bin HOME=/ TMPDIR=/tmp
QEMU_AUDIO_DRV=none /usr/bin/qemu-kvm -S -M
On Tue, Apr 20, 2010 at 08:20:35AM -0600, Eric Blake wrote:
On 04/19/2010 10:16 AM, Guido Günther wrote:
[..snip..]
since the former is O(1) while the latter is nominally O(n) in the
Good point. New patch attached.
-- Guido
From 6dc897319fd6ff6863895ffac01e5a38ba911abd Mon Sep 17 00:00:00 2001
On Tue, Apr 20, 2010 at 02:20:05PM -0600, Eric Blake wrote:
On 04/20/2010 02:18 PM, Guido Günther wrote:
On Tue, Apr 20, 2010 at 08:20:35AM -0600, Eric Blake wrote:
On 04/19/2010 10:16 AM, Guido Günther wrote:
[..snip..]
since the former is O(1) while the latter is nominally O(n
Hi,
this patch from Klau Ethgen looks right to me. O.k. to apply? I'll
remove the comment with this patch then.
Cheers,
-- Guido
- Forwarded message from Klaus Ethgen kl...@ethgen.de -
in node_device_udev.c is the base 10 used for conversion of USB values.
But they are hex values so
On Mon, Apr 26, 2010 at 11:26:51AM -0600, Eric Blake wrote:
On 04/26/2010 11:11 AM, Guido Günther wrote:
Hi,
this patch from Klau Ethgen looks right to me. O.k. to apply? I'll
remove the comment with this patch then.
Is there documentation somewhere that mentions what base the udev
Otherwise connections to older libvirt abort with:
$ virsh -c qemu+ssh://host.example.com/system list
error: invalid connection pointer in virDrvSupportsFeature
error: failed to connect to the hypervisor
Tested against 0.8.3 and 0.9.8.
---
src/remote/remote_driver.c |4 +---
1 files
On Sun, Dec 04, 2011 at 04:10:34PM +0800, Daniel Veillard wrote:
On Fri, Dec 02, 2011 at 02:30:35PM +0100, Peter Krempa wrote:
On 12/02/2011 01:42 AM, Daniel Veillard wrote:
On Thu, Dec 01, 2011 at 02:11:24PM -0700, Eric Blake wrote:
But that means we really are committing to an rc2.
On Mon, Dec 05, 2011 at 11:54:54AM +0100, Jiri Denemark wrote:
On Sun, Dec 04, 2011 at 15:42:29 +0100, Guido Günther wrote:
Otherwise connections to older libvirt abort with:
$ virsh -c qemu+ssh://host.example.com/system list
error: invalid connection pointer in virDrvSupportsFeature
On Thu, Jul 07, 2011 at 03:17:18PM +0100, Daniel P. Berrange wrote:
The lock manager infrastructure we recently added to QEMU only has
two possible drivers at this time, 'nop' and 'sanlock'. The former
does absolutely nothing, while the latter requires a 3rd party
package installed and is a
since libvird won't start otherwise without avahi running.
Having avahi compiled in shouldn't force us to have avahi running.
---
src/rpc/virnetserver.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c
index
On Mon, Jan 16, 2012 at 07:52:38PM +, Daniel P. Berrange wrote:
On Mon, Jan 16, 2012 at 11:29:51AM -0700, Eric Blake wrote:
On 01/14/2012 01:01 PM, Guido Günther wrote:
since libvird won't start otherwise without avahi running.
Having avahi compiled in shouldn't force us to have
---
src/xen/xen_hypervisor.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xen/xen_hypervisor.c b/src/xen/xen_hypervisor.c
index 855576c..51b92d3 100644
--- a/src/xen/xen_hypervisor.c
+++ b/src/xen/xen_hypervisor.c
@@ -2598,7 +2598,7 @@
by dereferencing a NULL pointer in the call to
virNodeSuspendGetTargetMask.
Only warn but Don't set an error to not overwrite an error code set by
xenHypervisorMakeCapabilities.
---
src/xen/xen_hypervisor.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git
On Fri, Jan 20, 2012 at 05:01:48PM +, Daniel P. Berrange wrote:
On Fri, Jan 20, 2012 at 05:57:34PM +0100, Guido Günther wrote:
by dereferencing a NULL pointer in the call to
virNodeSuspendGetTargetMask.
Only warn but Don't set an error to not overwrite an error code set
On Fri, Jan 20, 2012 at 04:36:29PM -0700, Eric Blake wrote:
On 01/20/2012 09:57 AM, Guido Günther wrote:
---
src/xen/xen_hypervisor.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xen/xen_hypervisor.c b/src/xen/xen_hypervisor.c
index 855576c..51b92d3
On Fri, Jan 20, 2012 at 05:01:48PM +, Daniel P. Berrange wrote:
On Fri, Jan 20, 2012 at 05:57:34PM +0100, Guido Günther wrote:
by dereferencing a NULL pointer in the call to
virNodeSuspendGetTargetMask.
Only warn but Don't set an error to not overwrite an error code set
On Mon, Jan 23, 2012 at 10:22:35AM +, Daniel P. Berrange wrote:
On Sun, Jan 22, 2012 at 12:30:20PM +0100, Guido Günther wrote:
On Fri, Jan 20, 2012 at 05:01:48PM +, Daniel P. Berrange wrote:
On Fri, Jan 20, 2012 at 05:57:34PM +0100, Guido Günther wrote:
by dereferencing a NULL
Hi,
it seems Xen changed the paths to the block device statistics in sysfs:
from /sys/devices/xen-backend/vbd-%d-%d/statistics/%s to
/sys/bus/xen-backend/devices/vbd-%d-%d/statistics/%s:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=596004
Attached patch fixes this. O.k. to apply?
-- Guido
Hi,
attached patch improves the error message when we can't find a suitable
emulator. Otherwise it's simply Unknown failure. O.k. to apply?
Cheers,
-- Guido
From 7092e11363983228d005a45c054f9b3604771b10 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
Date: Fri, 8
Hi,
attached patch passes -n to ip(6)tables to avoid long timeouts waiting
for DNS servers. O.k. to apply?
Cheers,
-- Guido
From aa7e3226adb2eb333863e0b1e52e26098a7673dc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
Date: Fri, 8 Oct 2010 16:35:03 +0200
Subject:
On Mon, Oct 11, 2010 at 03:39:39PM -0600, Eric Blake wrote:
On 10/08/2010 07:55 AM, Guido Günther wrote:
Hi,
attached patch improves the error message when we can't find a suitable
emulator. Otherwise it's simply Unknown failure. O.k. to apply?
Cheers,
-- Guido
ACK.
Pushed, thanks
Hi,
when using HAL instead of udev for nodeinfo we don't fail if HAL isn't
available. We also shouldn't fail if D-Bus is missing thenn either.
Attached patch fixes this. O.k. to apply?
Cheers,
-- Guido
From aab94ae8d34e462cd937ada7367560389f79aa25 Mon Sep 17 00:00:00 2001
From:
On Wed, Oct 13, 2010 at 10:31:38AM +0200, Daniel Veillard wrote:
On Wed, Oct 13, 2010 at 10:18:42AM +0200, Guido Günther wrote:
Hi,
when using HAL instead of udev for nodeinfo we don't fail if HAL isn't
available. We also shouldn't fail if D-Bus is missing thenn either.
Attached patch
Hi,
starting of lxc domains currently fails if memory controller support is
disabled in the kernel. Attached patch fixes this by ignoring the error
in case the files don't exist in the cgroup filesystem. I didn't add the
same exceptions for the recent hard and soft limit code since if somebody
On Fri, Oct 15, 2010 at 10:15:02AM +0200, Guido Günther wrote:
Hi,
starting of lxc domains currently fails if memory controller support is
disabled in the kernel. Attached patch fixes this by ignoring the error
in case the files don't exist in the cgroup filesystem. I didn't add the
same
On Mon, Oct 18, 2010 at 10:11:51AM +0100, Daniel P. Berrange wrote:
On Fri, Oct 15, 2010 at 06:05:10PM +0200, Guido Günther wrote:
On Fri, Oct 15, 2010 at 10:15:02AM +0200, Guido Günther wrote:
Hi,
starting of lxc domains currently fails if memory controller support is
disabled
On Wed, Nov 10, 2010 at 10:35:40AM +0200, Avi Kivity wrote:
On 11/10/2010 10:01 AM, Hermann Himmelbauer wrote:
Hi,
I manage my KVM machines via libvirt and wonder if there are any init.d
scripts for automatically starting up and shutting down virtual machines
during boot/shutdown of the host?
Hi,
We currently use the next free veid although there's one given in the
domain xml. This currently breaks defining new domains since vmdef-name
and veid don't match leading to the following error later on:
error: Failed to define domain from 110.xml
error: internal error Could not set
Hi,
this patch fixes some overwritten error messages. There are more but
these are the ones I could check easily. O.k. to apply?
Cheers,
-- Guido
From c18eb1fee9248bc8f09cb937416d43fa30d5c7b8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
Date: Mon, 29 Nov 2010
Attached patch ignores files named TAGS as generated by make tags.
O.k. to apply?
Cheers,
-- Guido
From 7897e8b2cb6b26b8086ab2216d96378923c1b6b9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
Date: Mon, 29 Nov 2010 13:43:00 +0100
Subject: [PATCH] Ignore files
On Mon, Nov 29, 2010 at 04:23:37PM -0700, Eric Blake wrote:
On 11/28/2010 05:32 PM, Guido Günther wrote:
Hi,
We currently use the next free veid although there's one given in the
domain xml. This currently breaks defining new domains since vmdef-name
and veid don't match leading
Drop unused (and unclosed) errfd and close outfd on exit. Otherwise
polling the running domains with virt-manager let's us quickly run out
of fds. O.k. to apply?
Cheers,
-- Guido
From 5ee971803e1bb7dc642c06b63bbbea724bdfd3dc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Guido=20G=C3=BCnther?=
On Wed, Dec 01, 2010 at 11:14:01AM -0700, Eric Blake wrote:
On 12/01/2010 11:06 AM, Guido Günther wrote:
Drop unused (and unclosed) errfd and close outfd on exit. Otherwise
polling the running domains with virt-manager let's us quickly run out
of fds. O.k. to apply?
ACK
On Fri, Dec 17, 2010 at 07:10:27AM -0700, Eric Blake wrote:
On 12/17/2010 04:13 AM, Laurent Léonard wrote:
Hi,
The attached patch removes functions library inclusion from libvirt-guests.
No function from this library is used by the script so there is no need to
include it.
NACK.
On Fri, Dec 17, 2010 at 05:26:52PM -0700, Eric Blake wrote:
* tools/libvirt-guests.init.in (libvirtd): Skip function library
if it is not present.
Suggested by Guido Günther.
---
tools/libvirt-guests.init.in |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/tools
Hi,
attached patchs adds AM_MAINTAINER_MODE and keeps it enabled by
defaults. This allows downstreams to turn it of via:
./configure --disable-maintainer-mode
as discussed in
https://www.redhat.com/archives/virt-tools-list/2010-October/msg00049.html
O.k. to apply?
Cheers,
-- Guido
From
On Fri, Jan 07, 2011 at 08:50:15AM -0700, Eric Blake wrote:
On 01/07/2011 03:34 AM, Guido Günther wrote:
Hi,
attached patchs adds AM_MAINTAINER_MODE and keeps it enabled by
defaults. This allows downstreams to turn it of via:
./configure --disable-maintainer-mode
as discussed
Hi,
Libvirt currently fails to start with dnsmasq = 2.56.
since dnsmasq now bails out with empty arguments. See
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=613944
for the Debian bug and
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=589885
for the upstream reasoning.
Tested with 2.55
On Fri, Feb 18, 2011 at 01:52:03PM -0700, Eric Blake wrote:
On 02/18/2011 01:49 PM, Guido Günther wrote:
On Fri, Feb 18, 2011 at 11:37:53AM -0700, Eric Blake wrote:
[..snip..]
This might as well be the shorter (and faster):
virCommandAddArg(cmd, --conf-file=);
now that it is only
as described at
http://wiki.debian.org/ToolChain/DSOLinking
https://fedoraproject.org/wiki/UnderstandingDSOLinkChange
otherwise the build fails on current Debian unstable with:
CCLD libvirtd
/usr/bin/ld:
../src/.libs/libvirt_driver_lxc.a(libvirt_driver_lxc_la-lxc_container.o):
undefined
as described at
http://wiki.debian.org/ToolChain/DSOLinking
https://fedoraproject.org/wiki/UnderstandingDSOLinkChange
otherwise the build fails on current Debian unstable with:
CCLD virsh
/usr/bin/ld: virsh-virsh.o: undefined reference to symbol
'xmlSaveTree@@LIBXML2_2.6.8'
/usr/bin/ld: note:
On Tue, Mar 08, 2011 at 06:57:22PM +, Daniel P. Berrange wrote:
On Tue, Mar 08, 2011 at 07:36:00PM +0100, Guido Günther wrote:
as described at
http://wiki.debian.org/ToolChain/DSOLinking
https://fedoraproject.org/wiki/UnderstandingDSOLinkChange
otherwise the build fails on current
On Tue, Mar 08, 2011 at 06:57:02PM +, Daniel P. Berrange wrote:
[..snip..]
-libvirtd_LDADD += ../src/libvirt.la
+if WITH_SECDRIVER_SELINUX
+libvirtd_LDADD += $(SELINUX_LIBS)
+endif
+if WITH_SECDRIVER_APPARMOR
+libvirtd_LDADD += $(APPARMOR_LIBS)
+endif
+
From 4a3765d97c3f5049aa294a4b7b629eabfd9cf04d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
Date: Mon, 7 Mar 2011 22:22:36 +0100
Subject: [PATCH 1/2] Move rundir creation into separate function
---
daemon/libvirtd.c | 31 ---
1
otherwise the user might not have enough permissions to access the
socket if roots umask is 077.
http://bugs.debian.org/614210
---
daemon/libvirtd.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index 610e7fd..a968e05 100644
---
On Wed, Mar 09, 2011 at 12:12:22PM +, Daniel P. Berrange wrote:
On Wed, Mar 09, 2011 at 09:17:56AM +0100, Guido Günther wrote:
From 4a3765d97c3f5049aa294a4b7b629eabfd9cf04d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
Date: Mon, 7 Mar 2011 22:22:36
On Wed, Mar 09, 2011 at 12:03:37PM +, Daniel P. Berrange wrote:
[..snip..]
libvirt_driver_lxc_la_SOURCES = $(LXC_DRIVER_SOURCES)
@@ -870,6 +878,12 @@ libvirt_driver_storage_la_CFLAGS = \
-I@top_srcdir@/src/conf $(AM_CFLAGS)
libvirt_driver_storage_la_LDFLAGS =
On Wed, Mar 09, 2011 at 09:20:50AM +0100, Guido Günther wrote:
otherwise the user might not have enough permissions to access the
socket if roots umask is 077.
This version of the patch fixes the dependency on a sane umask without
introducing a new function.
O.k. to apply?
Cheers,
-- Guido
From
Hi,
Attached patch makes sure we reset the umask in qemudListenUnix on the
error path.
O.k. to apply?
-- Guido
From 10c0088ca1ee55a2e44802f1f0185d7a8be907ee Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
Date: Wed, 9 Mar 2011 14:19:56 +0100
Subject: [PATCH] Fix
On Wed, Mar 09, 2011 at 02:16:47PM +, Daniel P. Berrange wrote:
On Wed, Mar 09, 2011 at 02:19:18PM +0100, Guido Günther wrote:
On Wed, Mar 09, 2011 at 09:20:50AM +0100, Guido Günther wrote:
otherwise the user might not have enough permissions to access the
socket if roots umask is 077
On Thu, Mar 10, 2011 at 07:43:05PM +0800, Daniel Veillard wrote:
On Wed, Mar 09, 2011 at 02:20:59PM +0100, Guido Günther wrote:
Hi,
Attached patch makes sure we reset the umask in qemudListenUnix on the
error path.
O.k. to apply?
-- Guido
From
Hi,
attached patch adds the missing checks for
https://bugzilla.redhat.com/show_bug.cgi?id=683650
O.k. to apply?
Cheers,
-- Guido
From 582e21051ea6d2521a64ed7db5ac162a25599c1e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
Date: Sat, 12 Mar 2011 22:47:45 +0100
601 - 700 of 1099 matches
Mail list logo
