Re: [libvirt] [PATCHv5 11/13] Add compatibility attribute to video

Hi Ján, I apply your patches of virtio compatibility attribute. And I find virtio video and input devices using virtio modern when set compatibility as legacy. The xml: Check virtio version in guest:

[libvirt] [PATCH 1/1] docs: schema: Add missing to devices

input device: , , should be interleaved. hub device: , should be interleaved. redirdev device: , , , should be interleaved. Signed-off-by: Han Han --- docs/schemas/domaincommon.rng | 60 +++ 1 file changed, 33 insertions(+), 27 deletions(-) diff --git a/docs

[libvirt] [PATCH 0/1] *** SUBJECT HERE ***

*** BLURB HERE *** Han Han (1): docs: schema: Add missing to devices docs/schemas/domaincommon.rng | 60 +++ 1 file changed, 33 insertions(+), 27 deletions(-) -- 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman

[libvirt] [PATCH 0/2] Add function to check cdrom status

handling of virStorageBackendVolOpen on cdrom. Han Han (2): util: Introduce virFileCdromStatus storage: Improve error handling on cdrom backend src/libvirt_private.syms | 1 + src/storage/storage_util.c | 38 src/util/virfile.c | 52

[libvirt] [PATCH 1/2] util: Introduce virFileCdromStatus

This private API helps check cdrom drive status via ioctl(). Signed-off-by: Han Han --- src/libvirt_private.syms | 1 + src/util/virfile.c | 52 src/util/virfile.h | 10 3 files changed, 63 insertions(+) diff --git a/src

[libvirt] [PATCH 2/2] storage: Improve error handling on cdrom backend

Implement virFileCdromStatus() in virStorageBackendVolOpen to show detailed errors or warnings of cdrom instead of general Input/output error. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1596096 Signed-off-by: Han Han --- src/storage/storage_util.c | 38

[libvirt] [PATCH 2/2] virsh: sata support for virsh attach-disk --address

Adding sata bus address support to the optional address parameter of virsh attach-disk. The address is used as controller.bus.unit. e.g. sata:0.0.0 Signed-off-by: Han Han --- tools/virsh-domain.c | 46 +++- tools/virsh.pod | 2 +- 2 files changed

[libvirt] [PATCH 0/2] Usb and sata for virsh attach-disk --address

Add usb and sata support for attach-disk of address parameter in virsh. Han Han (2): virsh: usb support for virsh attach-disk --address virsh: sata support for virsh attach-disk --address tools/virsh-domain.c | 82 +++- tools/virsh.pod | 2 +- 2

[libvirt] [PATCH 1/2] virsh: usb support for virsh attach-disk --address

Adding usb bus address support to the optional address parameter of virsh attach-disk. The address is used as bus:port. e.g. usb:1:1 Signed-off-by: Han Han --- tools/virsh-domain.c | 38 +- tools/virsh.pod | 2 +- 2 files changed, 38 insertions(+), 2

[libvirt] [PATCH] docs: schema: Add missing to devices

For input,hub,redirdev devices, their sub-elements should be interleaved. input device: interleave for , , hub device: interleave for , redirdev device: interleave for , , , Signed-off-by: Han Han --- docs/schemas/domaincommon.rng | 60 +++ 1 file changed, 33

Re: [libvirt] [PATCH] conf: Don't parse edev of non-passthrough input device

On Thu, Jul 19, 2018 at 12:34 AM, John Ferlan wrote: > > > On 07/11/2018 01:57 AM, Han Han wrote: > > In input devices, edev attribute is only for passthrough devices. > > Don't parse this for other input devices. > > > > Resolves: https://bugzilla.r

[libvirt] [PATCH v2 0/1] conf: Add validation of input devices

v1: https://www.redhat.com/archives/libvir-list/2018-July/msg00658.html Han Han (1): conf: Add validation of input devices src/conf/domain_conf.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) -- 2.18.0 -- libvir-list mailing list libvir-list@redhat.com https

[libvirt] [PATCH v2 1/1] conf: Add validation of input devices

https://bugzilla.redhat.com/show_bug.cgi?id=1591151 Add function virDomainInputDefValidate to validate input devices. Make sure evdev attribute of source element is not used by mouse, keyboard, and tablet input device. Signed-off-by: Han Han --- src/conf/domain_conf.c | 22

Re: [libvirt] [PATCH 2/2] esx: Fix SetAutoStart invalid pointer free

gt; +strcpy(newPowerInfo->stopAction, (char *)"none"); > > The same here > if (esxVI_AutoStartPowerInfo_AppendToList(>powerInfo, >newPowerInfo) < 0) { > -- > 2.17.1 > > -- > libvir-list maili

[libvirt] [PATCH] conf: Fix typo in error msg of virDomainVideoDefValidate

https://bugzilla.redhat.com/show_bug.cgi?id=1607825 Fix typo of error msg when 'none' type is not the only video device defined in VM. Signed-off-by: Han Han --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf

[libvirt] [PATCH] news: Usb and sata for virsh attach-disk --address

Signed-off-by: Han Han --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index fc7924ad5f..a68ef2dc1c 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -76,6 +76,16 @@ using attach-disk or attach-interface commands

[libvirt] [PATCH] qemu: Check sev capability pointer before using it

https://bugzilla.redhat.com/show_bug.cgi?id=1612009 Check sev capability pointer in function qemuGetSEVInfoToParams to avoid null pointer dereferences. Signed-off-by: Han Han --- src/qemu/qemu_driver.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu

Re: [libvirt] [PATCH v2 0/2] Add .domainGetHostname() support for QEMU driver.

iling list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list > -- Best regards, --- Han Han Quality Engineer Redhat. Email: h...@redhat.com Phone: +861065339333 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 1/2] virsh: Implement virNodeGetSEVInfo in virsh

Add sub-command nodesevinfo to get node infomation of AMD SEV feature. Signed-off-by: Han Han --- tools/virsh-host.c | 66 ++ tools/virsh.pod| 5 2 files changed, 71 insertions(+) diff --git a/tools/virsh-host.c b/tools/virsh-host.c index

[libvirt] [PATCH 0/2] Add nodesevinfo in virsh

Add virsh nodesevinfo to get AMD SEV features via virNodeGetSEVInfo. Han Han (2): virsh: Implement virNodeGetSEVInfo in virsh news: Add nodesevinfo command in virsh docs/news.xml | 9 +++ tools/virsh-host.c | 66 ++ tools/virsh.pod

[libvirt] [PATCH 2/2] news: Add nodesevinfo command in virsh

Signed-off-by: Han Han --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index c6d03f5556..fc9db92d05 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -63,6 +63,15 @@ Support the vhost-vsock-ccw device on S390

[libvirt] [PATCH] virsh: Don't break loop of domblkinfo for disks

after virDomainGetBlockInfo returning fail. Signed-off-by: Han Han --- tools/virsh-domain-monitor.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index b9b4f9739b..ee926baae8 100644 --- a/tools/virsh

Re: [libvirt] [PATCH] virsh: Don't break loop of domblkinfo for disks

On Tue, Aug 21, 2018 at 11:26 PM, Peter Krempa wrote: > On Tue, Aug 21, 2018 at 21:23:42 +0800, Han Han wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1619625 > > > > --all option is added to cmdDomblkinfo since commit 62c39193 allowing to > > show all blo

[libvirt] [PATCH v3] virsh: Don't break loop of domblkinfo for disks

breaks the loop of domblkinfo for disks. Signed-off-by: Han Han --- tools/virsh-domain-monitor.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index b9b4f9739b..ecb98d4128 100644 --- a/tools/virsh

[libvirt] [PATCH v2] virsh: Don't break loop of domblkinfo for disks

https://bugzilla.redhat.com/show_bug.cgi?id=1619625 --all option is added to cmdDomblkinfo since commit 62c39193 allowing to show all block devices info. Reset error when empty source in case error breaks the loop of domblkinfo for disks. Signed-off-by: Han Han --- tools/virsh-domain-monitor.c

[libvirt] [PATCH 1/2] virsh: Support alias in attach-disk

Add --alias to support custom disk alias in virsh attach-disk. Report error if custom alias doesn't start with 'ua-'. Signed-off-by: Han Han --- tools/virsh-domain.c | 15 ++- tools/virsh.pod | 3 ++- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/tools/virsh

[libvirt] [PATCH 0/2] Add alias support in sub-commands of virsh

Support to set alias with --alias in virsh attach-disk and attach-interface. Han Han (2): virsh: Support alias in attach-disk virsh: Support alias in attach-interface tools/virsh-domain.c | 30 -- tools/virsh.pod | 7 +-- 2 files changed, 33 insertions

[libvirt] [PATCH 2/2] virsh: Support alias in attach-interface

Add --alias to support custom alias in virsh attach-interface. Report error if custom alias doesn't start with 'ua-'. Signed-off-by: Han Han --- tools/virsh-domain.c | 15 ++- tools/virsh.pod | 4 +++- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/tools/virsh

[libvirt] [PATCH v2 0/2] Add alias support in sub-commands of virsh

Fix make syntax-check failure in v1. v1 link: https://www.redhat.com/archives/libvir-list/2018-July/msg00929.html Han Han (2): virsh: Support alias in attach-disk virsh: Support alias in attach-interface tools/virsh-domain.c | 30 -- tools/virsh.pod | 7

[libvirt] [PATCH v2 1/2] virsh: Support alias in attach-disk

Add --alias to support custom disk alias in virsh attach-disk. Report error if custom alias doesn't start with 'ua-'. Signed-off-by: Han Han --- tools/virsh-domain.c | 15 ++- tools/virsh.pod | 3 ++- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/tools/virsh

[libvirt] [PATCH v2 2/2] virsh: Support alias in attach-interface

Add --alias to support custom alias in virsh attach-interface. Report error if custom alias doesn't start with 'ua-'. Signed-off-by: Han Han --- tools/virsh-domain.c | 15 ++- tools/virsh.pod | 4 +++- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/tools/virsh

[libvirt] [PATCH] news: Add --alias to virsh attach-disk and attach-interface

Signed-off-by: Han Han --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 20c2ff7a6f..1e632eb378 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -67,6 +67,15 @@ only rendering devices within the guest

Re: [libvirt] [PATCH v2 0/2] Add alias support in sub-commands of virsh

On Mon, Jul 23, 2018 at 6:21 PM, Michal Prívozník wrote: > On 07/15/2018 12:08 PM, Han Han wrote: > > Fix make syntax-check failure in v1. > > v1 link: https://www.redhat.com/archives/libvir-list/2018- > July/msg00929.html > > > > Han Han (2): > >

Re: [libvirt] [PATCH v2 1/2] virsh: Support alias in attach-disk

On Mon, Jul 23, 2018 at 6:21 PM, Michal Prívozník wrote: > On 07/15/2018 12:08 PM, Han Han wrote: > > Add --alias to support custom disk alias in virsh attach-disk. > > Report error if custom alias doesn't start with 'ua-'. > > > > Signed-off-by: Han Han > > -

Re: [libvirt] [PATCH] docs: Typo fix in virDomainGetJobStats

ion hosts have synchronized time (i.e., NTP daemon > is > -- > 2.17.1 > > -- > libvir-list mailing list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list > -- Best regards, --- Han Han Quality Engineer Redhat.

Re: [libvirt] [PATCH 1/2] util: Introduce virFileCdromStatus

:05 PM, Han Han wrote: > Thank u for reviewing. I will give patch v2 later. > > On Tue, Jul 10, 2018 at 2:38 PM, Michal Privoznik > wrote: > >> On 07/03/2018 04:29 AM, Han Han wrote: >> > This private API helps check cdrom drive status via ioctl(). &g

Re: [libvirt] [PATCH 1/2] util: Introduce virFileCdromStatus

Sorry, it should be virFileCdromStatus not virFileCdromState :) On Tue, Jul 10, 2018 at 9:28 PM, Han Han wrote: > Hello Michel, > I agree with you that we could integrate these two APIs into one. If so, I > think we should change the API name virFileIsCDROM to **virFileC

Re: [libvirt] [PATCH 1/2] util: Introduce virFileCdromStatus

Thank u for reviewing. I will give patch v2 later. On Tue, Jul 10, 2018 at 2:38 PM, Michal Privoznik wrote: > On 07/03/2018 04:29 AM, Han Han wrote: > > This private API helps check cdrom drive status via ioctl(). > > > > Signed-off-by: Han Han > > --- > &g

Re: [libvirt] [PATCH 0/2] Add function to check cdrom status

Hello, could anyone help review? On Tue, Jul 3, 2018 at 10:29 AM, Han Han wrote: > In libvirt, it gives general Input/Output error when reading a not ready > cdrom. This error could be more detailed on cdrom, such as drive not > ready, no disc, trey open, no information. > These pat

[libvirt] [PATCH 1/2] util: Refactor virFileIsCDROM to virFileCheckCDROM

Add enum type of cdrom statuses. Add argument cd_status in virFileCheckCDROM to store cdrom status. Now virFileCheckCDROM could be used to check the cdrom drive status such as no info, no disc, trey open, drive not ready or ok. Signed-off-by: Han Han --- src/libvirt_private.syms | 2 +- src

[libvirt] [PATCH v2 0/2] Change virFileIsCDROM to check cdrom status

with warning just like the warning of lacking backing file. Han Han (2): util: Refactor virFileIsCDROM to virFileCheckCDROM storage: Improve error handling on cdrom backend src/libvirt_private.syms | 2 +- src/qemu/qemu_domain.c | 4 ++-- src/storage/storage_util.c | 15 - src

[libvirt] [PATCH 2/2] storage: Improve error handling on cdrom backend

Implement virFileCheckCDROM in virStorageBackendVolOpen to check if cdrom backend is ready. Skip the error of cdrom not ready. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1596096 Signed-off-by: Han Han --- src/storage/storage_util.c | 15 ++- 1 file changed, 14 insertions

Re: [libvirt] [PATCH 0/2] Change virFileIsCDROM to check cdrom status

Sorry I forget to add the former patch link. Please ignore these mails. On Wed, Jul 11, 2018 at 10:52 AM, Han Han wrote: > Refactor virFileIsCDROM to virFileCheckCDROM and now it could be used to > store cdrom status. > > In libvirt, it gives general Input/Output error when reading

[libvirt] [PATCH] conf: Don't parse edev of non-passthrough input device

In input devices, edev attribute is only for passthrough devices. Don't parse this for other input devices. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1591151 Signed-off-by: Han Han --- src/conf/domain_conf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src

[libvirt] [PATCH 2/2] storage: Improve error handling on cdrom backend

Implement virFileCheckCDROM in virStorageBackendVolOpen to check if cdrom backend is ready. Skip the error of cdrom not ready. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1596096 Signed-off-by: Han Han --- src/storage/storage_util.c | 15 ++- 1 file changed, 14 insertions

[libvirt] [PATCH 1/2] util: Refactor virFileIsCDROM to virFileCheckCDROM

Add enum type of cdrom statuses. Add argument cd_status in virFileCheckCDROM to store cdrom status. Now virFileCheckCDROM could be used to check the cdrom drive status such as no info, no disc, trey open, drive not ready or ok. Signed-off-by: Han Han --- src/libvirt_private.syms | 2 +- src

[libvirt] [PATCH 0/2] Change virFileIsCDROM to check cdrom status

Refactor virFileIsCDROM to virFileCheckCDROM and now it could be used to store cdrom status. In libvirt, it gives general Input/Output error when reading a not ready cdrom backend vol. This error should be replaced with warning just like the warning of lacking backing file. Han Han (2): util

Re: [libvirt] [PATCH 1/2] util: Refactor virFileIsCDROM to virFileCheckCDROM

On Wed, Jul 11, 2018 at 3:04 PM, Peter Krempa wrote: > On Wed, Jul 11, 2018 at 11:07:52 +0800, Han Han wrote: > > Add enum type of cdrom statuses. Add argument cd_status in > > virFileCheckCDROM to store cdrom status. > > Now virFileCheckCDROM could be used to check t

[libvirt] [PATCH v3 1/2] util: Refactor virFileIsCDROM to virFileCheckCDROM

. Signed-off-by: Han Han --- src/libvirt_private.syms | 2 +- src/qemu/qemu_domain.c | 4 ++-- src/util/virfile.c | 41 ++-- src/util/virfile.h | 13 - 4 files changed, 50 insertions(+), 10 deletions(-) diff --git a/src

[libvirt] [PATCH v3 0/2] Change virFileIsCDROM to check cdrom status

general Input/Output error when reading a not ready cdrom backend vol. This error should be replaced with warning just like the warning of lacking backing file. Han Han (2): util: Refactor virFileIsCDROM to virFileCheckCDROM storage: Improve error handling on cdrom backend src

[libvirt] [PATCH v3 2/2] storage: Improve error handling on cdrom backend

Implement virFileCheckCDROM in virStorageBackendVolOpen to check if cdrom backend is ready. Skip the error of cdrom not ready. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1596096 Signed-off-by: Han Han --- src/storage/storage_util.c | 8 1 file changed, 8 insertions(+) diff

[libvirt] [PATCH] virt-xml-validate: Add schema for nwfilterbinding

Add nwfilterbinding schema in virt-xml-validate for autoprobing. Add document of nwfilterbinding schema in tools/virt-xml-validate.pod. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1600330 Signed-off-by: Han Han --- tools/virt-xml-validate.in | 3 +++ tools/virt-xml-validate.pod | 4

[libvirt] [PATCH] virsh.pod: Fix typo of nwfilter-binding-undefine

Rename nwfilter-binding-undefine to nwfilter-binding-delete. Signed-off-by: Han Han --- tools/virsh.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 4c6e21fc22..771e99591e 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod

[libvirt] [PATCH] docs: schema: Add missing to vsock device

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1600345 Signed-off-by: Han Han --- docs/schemas/domaincommon.rng | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index bd687ce9d3..f24a56392a 100644 --- a/docs/schemas

Re: [libvirt] [PATCH 0/2] Usb and sata for virsh attach-disk --address

Could anyone help review it? On Wed, Jul 4, 2018 at 11:04 AM, Han Han wrote: > Add usb and sata support for attach-disk of address parameter in virsh. > > Han Han (2): > virsh: usb support for virsh attach-disk --address > virsh: sata support for virsh attach-disk --address &

Re: [libvirt] [PATCH 4/4] qemu: block: Add support for RBD authentication for blockdev

work-qcow2- > backing-chain-encryption_auth.json > +++ b/tests/qemublocktestdata/xml2json/network-qcow2- > backing-chain-encryption_auth.json > @@ -24,6 +24,11 @@ > } >], >"user": "testuser-rbd", > + "auth-client-required": [ > +"cephx", > +"none" > + ], > + "key-secret": "node-a-s-secalias", >"node-name": "node-a-s", >"read-only": false, >"discard": "unmap" > -- > 2.16.2 > > -- > libvir-list mailing list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list > -- Best regards, --- Han Han Quality Engineer Redhat. Email: h...@redhat.com Phone: +861065339333 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1/2] virsh: usb support for virsh attach-disk --address

Sorry for this stupid mistake. Thank you for reviewing. On Mon, Jul 9, 2018 at 11:20 PM, Michal Privoznik wrote: > On 07/04/2018 05:04 AM, Han Han wrote: > > Adding usb bus address support to the optional address parameter of virsh > > attach-disk. The address is used as bus:por

[libvirt] [PATCH] libvirt: Fix comments for two public APIs.

Fix comments for virConnectListAllNodeDevices and virConnectListAllSecrets. Signed-off-by: Han Han <h...@redhat.com> --- src/libvirt-nodedev.c | 2 +- src/libvirt-secret.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libvirt-nodedev.c b/src/libvirt-nodedev.c

[libvirt] [PATCH v2 2/8] qemu: Allow coldunplugging of hub device

https://bugzilla.redhat.com/show_bug.cgi?id=1375423 Signed-off-by: Han Han --- src/conf/domain_conf.c | 30 ++ src/conf/domain_conf.h | 3 +++ src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 10 +- 4 files changed, 43 insertions(+), 1

[libvirt] [PATCH v2 0/8] Usb hub Cold(un)plug and hot(un)plug support

v1: https://www.redhat.com/archives/libvir-list/2018-October/msg00563.html Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1375423 Han Han (8): qemu: Allow coldplugging of hub device qemu: Allow coldunplugging of hub device qemu_alias: Refactor hub alias assignment for hotplug

[libvirt] [PATCH v2 1/8] qemu: Allow coldplugging of hub device

https://bugzilla.redhat.com/show_bug.cgi?id=1375423 Signed-off-by: Han Han --- src/qemu/qemu_driver.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a52e2495d5..130ce4cbd6 100644 --- a/src/qemu/qemu_driver.c +++ b

[libvirt] [PATCH v2 6/8] qemu: implement usb hub device hotplug

https://bugzilla.redhat.com/show_bug.cgi?id=1375423 Signed-off-by: Han Han --- src/qemu/qemu_driver.c | 9 ++- src/qemu/qemu_hotplug.c | 58 + src/qemu/qemu_hotplug.h | 8 ++ 3 files changed, 74 insertions(+), 1 deletion(-) diff --git a/src

[libvirt] [PATCH v2 3/8] qemu_alias: Refactor hub alias assignment for hotplug

Make qemuAssignDeviceHubAlias global and allow alias generating for reuse on hotplug. Signed-off-by: Han Han --- src/qemu/qemu_alias.c | 22 ++ src/qemu/qemu_alias.h | 4 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_alias.c b/src/qemu

[libvirt] [PATCH v2 5/8] private_syms: add virDomainHubDefFree to libvirt_private.syms

Add virDomainHubDefFree to for the preparation of usb hub hotplug. Signed-off-by: Han Han --- src/libvirt_private.syms | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 6245927673..b29c2bf62b 100644 --- a/src/libvirt_private.syms +++ b

[libvirt] [PATCH v2 8/8] news: Cold(un)plug and hot(un)plug support for usb hub device

Signed-off-by: Han Han --- docs/news.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index dc08c96352..0efad21758 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -35,6 +35,11 @@ + + + qemu: Add support for cold(un

[libvirt] [PATCH v2 4/8] qemu_command: Make qemuBuildHubDevStr global

Make function qemuBuildHubDevStr global for reuse on hub hotplug. Signed-off-by: Han Han --- src/qemu/qemu_command.c | 2 +- src/qemu/qemu_command.h | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 269276f2f9

[libvirt] [PATCH v2 7/8] qemu: implement usb hub device hotunplug

https://bugzilla.redhat.com/show_bug.cgi?id=1375423 Signed-off-by: Han Han --- src/qemu/qemu_driver.c | 5 ++- src/qemu/qemu_hotplug.c | 74 - src/qemu/qemu_hotplug.h | 4 +++ 3 files changed, 81 insertions(+), 2 deletions(-) diff --git a/src/qemu

[libvirt] [PATCH] conf: More clear error msg for incomplete coalesce xml

https://bugzilla.redhat.com/show_bug.cgi?id=1535930 Report more clear err msg instead of unknown error when coalesce settings is incomplete. Signed-off-by: Han Han --- src/conf/domain_conf.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src

[libvirt] [PATCH] conf: Fix typos in pcie controllers' name

Signed-off-by: Han Han --- src/conf/domain_addr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index 442e6aab94..e4ed143b76 100644 --- a/src/conf/domain_addr.c +++ b/src/conf/domain_addr.c @@ -158,9 +158,9

Re: [libvirt] [PATCH] conf: More clear error msg for incomplete coalesce xml

On Wed, Oct 17, 2018 at 4:46 PM Martin Kletzander wrote: > On Tue, Oct 16, 2018 at 07:19:41PM -0400, John Ferlan wrote: > > > > > >On 10/14/18 10:26 AM, Han Han wrote: > >> https://bugzilla.redhat.com/show_bug.cgi?id=1535930 > >> > >> Report

Re: [libvirt] [RFC 0/3] update NVDIMM support

t's OK. > Regards, > Luyao Zhong > > On 2018/10/18 上午9:10, Han Han wrote: > > > > On Wed, Oct 17, 2018 at 10:25 AM Luyao Zhong > wrote: > >> Hi libvirt experts, >> >> This is the RFC for updating NVDIMM support in libvirt. >> >> QEMU has sup

Re: [libvirt] [RFC 0/3] update NVDIMM support

y-hotplug-nvdimm-pmem.xml > create mode 12 > tests/qemuxml2xmloutdata/memory-hotplug-nvdimm-unarmed.xml > > -- > 2.7.4 > > -- > libvir-list mailing list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list > -- Best regards, --- Han Han Quality Engineer Redhat. Email: h...@redhat.com Phone: +861065339333 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] conf: More clear error msg for incomplete coalesce xml

On Thu, Oct 18, 2018 at 5:28 PM Martin Kletzander wrote: > On Thu, Oct 18, 2018 at 02:12:36PM +0800, Han Han wrote: > >On Wed, Oct 17, 2018 at 4:46 PM Martin Kletzander > >wrote: > > > >> On Tue, Oct 16, 2018 at 07:19:41PM -0400, John Ferlan wrote: > >> &

[libvirt] RFC: VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA is not functional?

ight** result, if the function for VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA will not be designed, how will we deal with the flag? Remove it from code OR update the docs to mark it unsupported? -- Best regards, --- Han Han Quality Engineer Redhat. Email: h...@redhat.com P

[libvirt] [PATCH v4 1/2] util: Refactor virFileIsCDROM to virFileCheckCDROM

Refactor virFileIsCDROM to virFileCheckCDROM for checking cdrom status. Add add enum type virFileCDRomStatus. Now virFileCheckCDROM could be used to check the cdrom drive status such as ok, no disc, tray open, drive not ready, or unknown. Signed-off-by: Han Han --- src/libvirt_private.syms

[libvirt] [PATCH v4 0/2] Refactor virFileIsCDROM to check cdrom status

with cdrom status. Give more detailed when fail to read cdrom backend vol. Han Han (2): util: Refactor virFileIsCDROM to virFileCheckCDROM storage: Improve error handling on cdrom backend src/libvirt_private.syms | 2 +- src/qemu/qemu_domain.c | 4 ++-- src/storage/storage_util.c | 32

[libvirt] [PATCH v4 2/2] storage: Improve error handling on cdrom backend

https://bugzilla.redhat.com/show_bug.cgi?id=1596096 Implement virFileCheckCDROM in virStorageBackendVolOpen to check if cdrom backend is ok. Report more detailed error if not ok. Signed-off-by: Han Han --- src/storage/storage_util.c | 32 1 file changed, 32

[libvirt] [PATCH v3 10/10] news: Cold(un)plug and hot(un)plug support for usb hub

Signed-off-by: Han Han --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 88774c55ae..b677f52efc 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -35,6 +35,16 @@ + + + Qemu: Add active

[libvirt] [PATCH v3 03/10] qemu: Refactor hub alias assignment for hotplug

Make qemuAssignDeviceHubAlias global and allow alias generating for reuse on hotplug. Signed-off-by: Han Han --- src/qemu/qemu_alias.c | 22 ++ src/qemu/qemu_alias.h | 4 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_alias.c b/src/qemu

[libvirt] [PATCH v3 07/10] conf: Add function virDomainUSBAddressIsAttachedToHub

Add this function to check if the a usb address is attached to a hub device. Signed-off-by: Han Han --- src/conf/domain_addr.c | 22 ++ src/conf/domain_addr.h | 5 + src/libvirt_private.syms | 1 + 3 files changed, 28 insertions(+) diff --git a/src/conf

[libvirt] [PATCH v3 01/10] qemu: Allow coldplugging of hub device

https://bugzilla.redhat.com/show_bug.cgi?id=1375423 Signed-off-by: Han Han --- src/qemu/qemu_driver.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 9f71641dfa..1e5a69358b 100644 --- a/src/qemu/qemu_driver.c +++ b

[libvirt] [PATCH v3 02/10] qemu: Allow coldunplugging of hub device

https://bugzilla.redhat.com/show_bug.cgi?id=1375423 Signed-off-by: Han Han --- src/conf/domain_conf.c | 30 ++ src/conf/domain_conf.h | 3 +++ src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 10 +- 4 files changed, 43 insertions(+), 1

[libvirt] [PATCH v3 05/10] conf: Add virDomainHubDefFree to libvirt_private.syms

Add virDomainHubDefFree to for the preparation of usb hub hotplug. Signed-off-by: Han Han --- src/libvirt_private.syms | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 6245927673..b29c2bf62b 100644 --- a/src/libvirt_private.syms +++ b

[libvirt] [PATCH v3 04/10] qemu: Make qemuBuildHubDevStr global

Make function qemuBuildHubDevStr global for reuse on hub hotplug. Signed-off-by: Han Han --- src/qemu/qemu_command.c | 2 +- src/qemu/qemu_command.h | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index f59cbf559e

[libvirt] [PATCH v3 09/10] qemu: Implement usb hub device hotunplug

https://bugzilla.redhat.com/show_bug.cgi?id=1375423 Signed-off-by: Han Han --- src/qemu/qemu_driver.c | 5 ++- src/qemu/qemu_hotplug.c | 81 - src/qemu/qemu_hotplug.h | 4 ++ 3 files changed, 88 insertions(+), 2 deletions(-) diff --git a/src/qemu

[libvirt] [PATCH v3 08/10] qemu: Check whether hub device is busy

qemuDomainHubIsBusy is to check whether a usb device are attached to the hub device. It will be used for hotunplugging and live device update of hub device. Signed-off-by: Han Han --- src/qemu/qemu_hotplug.c | 64 + 1 file changed, 64 insertions(+) diff

[libvirt] [PATCH v3 06/10] qemu: Implement usb hub device hotplug

https://bugzilla.redhat.com/show_bug.cgi?id=1375423 Signed-off-by: Han Han --- src/qemu/qemu_driver.c | 9 ++- src/qemu/qemu_hotplug.c | 58 + src/qemu/qemu_hotplug.h | 4 +++ 3 files changed, 70 insertions(+), 1 deletion(-) diff --git a/src/qemu

[libvirt] [PATCH v3 00/10] Cold(un)plug and hot(un)plug support for hub

/libvir-list/2018-October/msg00719.html Han Han (10): qemu: Allow coldplugging of hub device qemu: Allow coldunplugging of hub device qemu: Refactor hub alias assignment for hotplug qemu: Make qemuBuildHubDevStr global conf: Add virDomainHubDefFree to libvirt_private.syms qemu: Implement usb

Re: [libvirt] [PATCH] docs: Add notes for VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA

On Thu, Nov 15, 2018 at 12:36 AM Andrea Bolognani wrote: > On Wed, 2018-11-14 at 15:19 +0800, Han Han wrote: > > When listing snapshot with VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA, it > > always returns 0 or no snapshot. Because we never implement funtions > > to list

Re: [libvirt] [PATCH v2 8/8] news: Cold(un)plug and hot(un)plug support for usb hub device

On Tue, Nov 6, 2018 at 6:52 AM John Ferlan wrote: > > > On 10/12/18 4:50 AM, Han Han wrote: > > Signed-off-by: Han Han > > --- > > docs/news.xml | 5 + > > 1 file changed, 5 insertions(+) > > > > diff --git a/docs/news.xml b/docs/new

Re: [libvirt] RFC: VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA is not functional?

On Mon, Nov 5, 2018 at 9:38 PM Peter Krempa wrote: > On Fri, Nov 02, 2018 at 15:52:54 +0800, Han Han wrote: > > Hello, > > I found snapshot APIs(like virDomainSnapshotNum) invoked with > > VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA will return 0 even there are > internal &

Re: [libvirt] [PATCH v2 2/8] qemu: Allow coldunplugging of hub device

On Tue, Nov 6, 2018 at 6:29 AM John Ferlan wrote: > > > On 10/12/18 4:50 AM, Han Han wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1375423 > > > > Signed-off-by: Han Han > > --- > > src/conf/domain_conf.c | 30 ++

Re: [libvirt] [PATCH v2 6/8] qemu: implement usb hub device hotplug

On Tue, Nov 6, 2018 at 6:34 AM John Ferlan wrote: > $SUBJ: > > s/implement/Implement > > On 10/12/18 4:50 AM, Han Han wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1375423 > > Add the infrastructure to allow a USB Hub device to be hotplugged. >

Re: [libvirt] [PATCH v2 7/8] qemu: implement usb hub device hotunplug

On Tue, Nov 6, 2018 at 6:47 AM John Ferlan wrote: > > $SUBJ: > > s/implement/Implement > > On 10/12/18 4:50 AM, Han Han wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1375423 > > > > Add the infrastructure to allow a USB Hub device to be hot unp

[libvirt] [PATCH] docs: Add notes for VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA

DATA) == VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA) return 0; Add notes for that flag. Please update the comment and man page of that flag when no-metadata snapshot list is implemented in the future. Signed-off-by: Han Han --- include/libvirt/libvirt-domain-snapshot.h | 5 - tools/virsh

[libvirt] [PATCH] virFileIsSharedFSType: Copy mnt_dir when browsing mount table

nt in case its mnt_dir is changed by getmntent_r in the loop later. Signed-off-by: Han Han --- src/util/virfile.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 2a7e87102a..c503462633 100644 --- a/src/util/virfile.c

[libvirt] [PATCH v2] virFileIsSharedFixFUSE: Copy mnt_dir when browsing mount table

lowing: 10.XX.XX.XX:/gv0 /mnt fuse.glusterfs rw 0 0 r...@xx.xx.xx:/tmp/mkdir /tmp/br0 fuse.sshfs rw 0 0 Copy mnt_dir of struct mntent in case its mnt_dir is changed by getmntent_r in the loop later. Signed-off-by: Han Han --- src/util/virfile.c | 12 1 file changed, 8 insertions(+), 4

[libvirt] [PATCH 1/2] qemu: Allow coldplugging of hub device

https://bugzilla.redhat.com/show_bug.cgi?id=1375423 Signed-off-by: Han Han --- src/qemu/qemu_driver.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a52e2495d5..130ce4cbd6 100644 --- a/src/qemu/qemu_driver.c +++ b

[libvirt] [PATCH 2/2] qemu: Allow coldunplugging of hub device

https://bugzilla.redhat.com/show_bug.cgi?id=1375423 Signed-off-by: Han Han --- src/conf/domain_conf.c | 30 ++ src/conf/domain_conf.h | 3 +++ src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 10 +- 4 files changed, 43 insertions(+), 1

[libvirt] [PATCH 0/2] Allow coldplug and coldunplug of hub device

Han Han (2): qemu: Allow coldplugging of hub device qemu: Allow coldunplugging of hub device src/conf/domain_conf.c | 30 ++ src/conf/domain_conf.h | 3 +++ src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 16 ++-- 4 files changed, 48

  1   2   3   4   5   6   >