Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

2018-08-10 Thread Ivan Mishonov
wrote: On Fri, Aug 10, 2018 at 05:47:40PM +0300, Ivan Mishonov wrote: Yes, this is totally doable. I just don't know if it's a good idea to add a new device type specifically for bhyve LPC and nothing else. Even if we do it like this I'll still have to send another patch including the bhyve XML

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

2018-08-10 Thread Ivan Mishonov
the setting for unimplemented MSRs? Regards, Ivan On 08/10/2018 06:24 PM, Daniel P. Berrangé wrote: On Fri, Aug 10, 2018 at 06:11:57PM +0300, Ivan Mishonov wrote: I'd like to hear Roman's opinion on this too since he wrote the initial implementation. As for the command line arguments I was looking

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

2018-08-10 Thread Ivan Mishonov
to the bhyve process related to unimplemented MSRs on AMD Zen systems. I thought I'd do the 2 things in a similar manner as both of them are strictly bhyve specific Regards, Ivan On 08/10/2018 04:58 PM, Daniel P. Berrangé wrote: On Fri, Aug 10, 2018 at 03:41:09PM +0300, Ivan Mishonov wrote

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

2018-08-13 Thread Ivan Mishonov
On 08/13/2018 11:00 AM, Daniel P. Berrangé wrote: On Sun, Aug 12, 2018 at 08:22:08PM +0400, Roman Bogorodskiy wrote: Ivan Mishonov wrote: Yes, that makes sense. I'll try to find some time next week to redo my code and send another patch. Since my time for working on libvirt is very

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

2018-08-10 Thread Ivan Mishonov
P. Berrangé wrote: On Fri, Aug 10, 2018 at 02:22:32PM +0300, Ivan Mishonov wrote: Windows UEFI guests didn't have working keyboard input through VNC when LPC is on slot 1. The FreeBSD Handbook examples use slot 31 for UEFI guests. Borrowed most of the code from the qemu:commandline implementation

Re: [libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

2018-08-10 Thread Ivan Mishonov
-ISA bridge with COM1 and COM2     16550 serial ports and a boot ROM.     The LPC bridge emulation can only be     configured on bus 0. Regards, Ivan On 08/10/2018 03:25 PM, Daniel P. Berrangé wrote: On Fri, Aug 10, 2018 at 03:20:06PM +0300, Ivan Mishonov wrote: The problem

[libvirt] [PATCH 0/1] bhyve: Make LPC slot number configurable

2018-08-10 Thread Ivan Mishonov
Windows UEFI guests didn't have working keyboard input through VNC when LPC is on slot 1. The FreeBSD Handbook examples use slot 31 for UEFI guests. Borrowed most of the code from the qemu:commandline implementation and made LPC slot number configurable e.g. Ivan Mishonov (1): bhyve: Make

[libvirt] [PATCH 1/1] bhyve: Make LPC slot number configurable

2018-08-10 Thread Ivan Mishonov
Signed-off-by: Ivan Mishonov --- docs/schemas/domaincommon.rng | 15 ++ src/bhyve/bhyve_command.c | 7 ++- src/bhyve/bhyve_conf.c| 12 + src/bhyve/bhyve_conf.h| 9 src/bhyve/bhyve_device.c | 16 --- src/bhyve/bhyve_domain.c | 86

[libvirt] [PATCH 1/1] Changed LPC slot from 1 to 31

2018-07-06 Thread Ivan . Mishonov
From: Ivan Mishonov --- src/bhyve/bhyve_command.c | 2 +- src/bhyve/bhyve_device.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index 802997bd2d..e595b3d6c1 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve

[libvirt] [PATCH 1/1] Changed LPC slot from 1 to 31

2018-07-06 Thread Ivan Mishonov
From: Ivan Mishonov --- src/bhyve/bhyve_command.c | 2 +- src/bhyve/bhyve_device.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index 802997bd2d..e595b3d6c1 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve

[libvirt] [PATCH 0/1] Changed LPC slot from 1 to 31

2018-07-06 Thread Ivan Mishonov
From: Ivan Mishonov There was no keyboard input on Graphical UEFI guests running Windows 2016. Changed slot number according to the example given in the FreeBSD Handbook section related to bhyve and Graphical UEFI guests Ivan Mishonov (1): Changed LPC slot from 1 to 31 src/bhyve

[libvirt] [PATCH 0/1] Changed LPC slot from 1 to 31

2018-07-06 Thread Ivan . Mishonov
From: Ivan Mishonov There was no keyboard input on Graphical UEFI guests running Windows 2016. Changed slot number according to the example given in the FreeBSD Handbook section related to bhyve and Graphical UEFI guests Ivan Mishonov (1): Changed LPC slot from 1 to 31 src/bhyve

Re: [libvirt] [PATCH] Changed LPC slot from 1 to 31

2018-07-09 Thread Ivan Mishonov
Yes, I talked to him and he said he will review and test. Thanks On 07/09/2018 05:17 PM, Daniel P. Berrangé wrote: On Mon, Jul 09, 2018 at 05:14:35PM +0300, Ivan Mishonov wrote: --- src/bhyve/bhyve_command.c | 2 +- src/bhyve/bhyve_device.c | 4 ++-- 2 files changed, 3 insertions(+), 3

[libvirt] [PATCH] Changed LPC slot from 1 to 31

2018-07-09 Thread Ivan Mishonov
--- src/bhyve/bhyve_command.c | 2 +- src/bhyve/bhyve_device.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index 802997bd2d..e595b3d6c1 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve/bhyve_command.c @@