On 6/3/21 1:34 PM, Michal Privoznik wrote:
> I've identified some places (mostly by looking for
> virBufferUse()) that can use virXMLFormatElement() instead of
> open coded version of it. I'm sure there are many more places
> that could use the same treatment. Let's cure them some other
> time.
>
On 6/17/21 12:42 PM, Michal Privoznik wrote:
> The virSecurityDACSetOwnershipInternal() function accepts two
> arguments (among others): @path and @src. The idea being that in
> some cases @path is NULL and @src is not and then @path is filled
> from @src->path. However, this is done in both
On 6/17/21 12:42 PM, Michal Privoznik wrote:
> I've started looking at how we could fix the following bug:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1786222
>
> Long story short, we are not using just async signal safe functions in a
> forked off thread that runs chown() from within the
On 6/16/21 5:05 PM, Peter Krempa wrote:
> Peter Krempa (7):
> qemuSnapshotPrepareDiskExternal: Move temp variables into the block
> using them
> qemuSnapshotPrepareDiskExternal: Avoid condition squashing
> qemuSnapshotPrepareDiskExternal: Reject creation of block devices
> sooner
>
On 6/21/21 1:08 PM, Pavel Hrdina wrote:
> When removing check for return value of VIR_EXPAND_N this place was
> incorrectly modified causing failure to start a VM with cputune
> memorytune configured with useless error message:
>
> error: Failed to start domain 'vm1'
> error: An error
On 6/21/21 4:53 AM, Masayoshi Mizuma wrote:
> On Fri, Jun 18, 2021 at 01:45:18PM +0200, Ján Tomko wrote:
>> In some cases, such as doing intense I/O on slow filesystems,
>> it can take virtiofsd as long as 42 seconds to exit.
>>
>> Add a delay of extra 45 seconds before we forcefully kill it.
>>
On 6/22/21 3:54 PM, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake
> ---
> docs/kbase/live_full_disk_backup.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Ján Tomko
and pushed.
Jano
On 6/14/21 10:23 AM, Simon Chopin wrote:
> I expect to find a link to the repositories when clicking on
> "Contribute", this patch fixes this. The wording is directly inspired by
> the one on the hacking page.
>
> Signed-off-by: Simon Chopin
> ---
> docs/contribute.html.in | 7 ---
> 1 file
On 6/15/21 12:42 PM, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander
> ---
> build-aux/syntax-check.mk | 5 +++--
> src/esx/README| 1 -
> 2 files changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Ján Tomko
Jano
On 6/11/21 4:48 PM, Peter Krempa wrote:
> The new version allows passing a virBuffer to format the string into.
> This will be helpful in solving a memory lean in wrong usage of
*leak
Jano
> virCommandToString and also in tests where we need to add a newline
> after the command in certain
On 6/11/21 4:48 PM, Peter Krempa wrote:
> This series consists of 3 parts:
>
> Part 1, patches 1-3:
>
> These are fixes to the virCommand->string conversion, namely two bugs:
> - VIR_TEST_REGENERATE_OUTPUT would produce new files with missing end
> newline
> - memleak in bhyves
On 6/15/21 12:01 PM, Peter Krempa wrote:
> Thomas' recent qemu patch strives to add proper detectability of SDL
> support:
>
> https://listman.redhat.com/archives/libvir-list/2021-June/msg00398.html
>
> This series is the libvirt counterpart.
>
> Note that all capability files we have for now
On 6/15/21 12:27 PM, Peter Krempa wrote:
> Peter Krempa (13):
> qemuMonitorJSONParsePropsList: Refactor cleanup
> qemuMonitorJSONGetObjectProps: Refactor cleanup
> qemuMonitorJSONGetMigrationCapabilities: Refactor cleanup
> qemuMonitorJSONGetCommands: Refactor cleanup
>
On 5/27/21 1:30 PM, Ján Tomko wrote:
> On a Thursday in 2021, Thomas Huth wrote:
>> We are already compiling libvirt with -Wvla - so it does not make
>> too much sense to still allow people to use alloca() instead. Thus
>> put it on the list of things we want to warn about. Fortunately,
>> there
On 5/27/21 12:37 PM, Thomas Huth wrote:
> The flag has a typo in it, it's "...-than=..." and not "...-then=...",
> so this was in fact never used. Since we're also using -Wvla (without
> size), we should already get warnings about any variable length arrays
> anyway, so the additional
On 6/15/21 4:16 PM, Peter Krempa wrote:
> The 'rbd_image_spec_t' struct has two string members 'id' and
> 'name'. We only stole the 'name' members thus the 'id's as well as the
> whole list would be leaked on success.
>
> Restructure the code so that we copy out the image names and call
>
On 6/15/21 4:16 PM, Peter Krempa wrote:
> Use automatic memory freeing for the string list so that we can remove
> the cleanup section.
>
> Signed-off-by: Peter Krempa
> ---
> src/storage/storage_backend_rbd.c | 12
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
Reviewed-by:
On 6/18/21 3:04 PM, Peter Krempa wrote:
> Peter Krempa (4):
> conf: storage: Introduce virStoragePoolSourceListFree
> virStorageBackendISCSIDirectFindPoolSources: Use allocated
> virStoragePoolSourceList
> virISCSIDirectUpdateTargets: Rework to simplify cleanup and return
> GStrv
>
On 6/18/21 3:04 PM, Peter Krempa wrote:
> Count the elements in advance rather than using VIR_APPEND_ELEMENT and
> ensure that there's a NULL terminator for the string list so it's GStrv
> compatible.
>
> Signed-off-by: Peter Krempa
> ---
> src/storage/storage_backend_iscsi_direct.c | 29
On 6/17/21 9:03 AM, Peter Krempa wrote:
> On Wed, Jun 16, 2021 at 18:30:08 -0300, Daniel Henrique Barboza wrote:
>> Commit 56dcdec1ac81 ("conf: reject duplicate virtiofs tags") added
>> validation code to reject duplicated virtiofs tags. But the
>> element is not always present, meaning that
On 6/7/21 3:47 PM, Michal Privoznik wrote:
> *** BLURB HERE ***
>
> Michal Prívozník (2):
> ch_driver: Avoid driver double free
> virCHDriverConfig: Drop @uri member
>
> src/ch/ch_conf.c | 1 -
> src/ch/ch_conf.h | 1 -
> src/ch/ch_driver.c | 2 +-
> 3 files changed, 1 insertion(+), 3
On 6/8/21 10:45 AM, Michal Privoznik wrote:
> I've noticed couple of bugs/problems while reviewing Fabiano's patch.
> Here are fixes.
>
> Michal Prívozník (5):
> virt-host-validate: Initialize the error object
> virt-host-validate: Report an error if failed to detect CGroups
>
On 6/2/21 10:46 AM, Michal Privoznik wrote:
> The iscsi-direct storage pool backend works merely like this: a
> connection is established to the target (usually done via
> virStorageBackendISCSIDirectSetConnection()), intended action is
> executed (e.g. reporting LUNs, volume wiping), and at the
On a %A in %Y, Tim Wiederhake wrote:
> In the spirit of
> https://listman.redhat.com/archives/libvir-list/2021-May/msg00550.html.
>
> Tim Wiederhake (6):
> conf: Add AUTOPTR_CLEANUP_FUNC for virDomainSEVDef
> conf: virDomainSEVDef: Change type of "sectype" to
> virDomainLaunchSecurity
>
On a %A in %Y, Jim Fehlig wrote:
> My main objective with this series was to decompose libxlDomainStart a bit,
> as it had become quite unwieldy. Along the way I made a few other small
> improvements to the code.
>
> Jim Fehlig (6):
> libxl: Drop unused 'cfg' parameter from
On a %A in %Y, Pavel Hrdina wrote:
> We have several other options that depend on result of `driver_remote`
> option check so we need to do it early to have the result available.
>
> Fixes: https://gitlab.com/libvirt/libvirt/-/issues/185
> Signed-off-by: Pavel Hrdina
> ---
> meson.build | 65
On a %A in %Y, Jim Fehlig wrote:
> Move network device cleanup code from libxlDomainCleanup to a helper
> function for use in a subsequent patch.
>
> Signed-off-by: Jim Fehlig
> ---
> src/libxl/libxl_domain.c | 49 +++-
> 1 file changed, 28 insertions(+), 21
On a %A in %Y, Peter Krempa wrote:
> See patch 1/2.
>
> Peter Krempa (2):
> qemu: migration: Use correct flag constant for enabling storage
> migration
> NEWS: Mention implications of the bug in migration code
>
> NEWS.rst | 7 +++
> src/qemu/qemu_migration.c | 2 +-
On a %A in %Y, Vinayak Kale wrote:
> In 'virResctrlAllocUpdateMask', mask is updated only if 'previous mask' is
> NULL.
>
> By default, the bitmask for a cache resource for a VM is initialized with
> 'default-resctrl-group' bitmask. So the 'previous mask' would not be NULL and
> mask won't get
On a %A in %Y, Peter Krempa wrote:
> Wrong flag use could have user-visible implications. Mention the fix.
>
> Signed-off-by: Peter Krempa
> ---
> NEWS.rst | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/NEWS.rst b/NEWS.rst
> index 2536955a4a..2a97b5ece4 100644
> --- a/NEWS.rst
On 6/24/21 10:25 AM, Jiri Denemark wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1975677
>
> Signed-off-by: Jiri Denemark
> ---
> libvirt.spec.in | 4
> 1 file changed, 4 insertions(+)
>
Reviewed-by: Ján Tomko
Jano
On a %A in %Y, Michal Prívozník wrote:
> On 7/7/21 12:46 PM, Kristina Hanicova wrote:
>> Signed-off-by: Kristina Hanicova
>
> The commit message is a bit sparse. Can you describe the intent?
>
>> ---
>> src/qemu/qemu_namespace.c | 24 ++--
>> src/util/virprocess.c | 6
On a %A in %Y, Jiri Denemark wrote:
> No need to overwrite vmid_ex_id with a pointer to another copy of the
> same string when the original is still alive.
>
> Signed-off-by: Jiri Denemark
> ---
> src/util/virnetdevopenvswitch.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git
On a %A in %Y, Michal Privoznik wrote:
> In virTestMain() the @failedTests bitmap is allocated and
> optionally @testBitmap too. But neither of them is freed.
> > Signed-off-by: Michal Privoznik
> ---
> tests/testutils.c | 3 +++
> 1 file changed, 3 insertions(+)
>
Fixes:
On a %A in %Y, Tim Wiederhake wrote:
> ping
>
Sorry, I thought you already pushed it based on Peter's reply.
> On Fri, 2021-07-23 at 11:56 +0200, Tim Wiederhake wrote:
>> Signed-off-by: Tim Wiederhake
>> ---
>> src/conf/nwfilter_params.c | 7 ++-
>> 1 file changed, 2 insertions(+), 5
On a %A in %Y, Michal Privoznik wrote:
> There are cpu definitions that are allocated in
> qemuTestDriverInit() but are missing corresponding
> virCPUDefFree() call in qemuTestDriverFree(). It's safe to call
> the free function because the definitions contain a refcounter
> and thus even if they
On a %A in %Y, Michal Privoznik wrote:
> See 4/4 for explanation.
>
> Michal Prívozník (4):
> virDomainDefGetSecurityLabelDef: Fix const correctness
> qemuDomainOpenFile: Take virDomainDef instead of virDomainObj
> qemuDomainOpenFile: Take @cfg instead of driver
> qemu: Open chardev
On a %A in %Y, Kristina Hanicova wrote:
> On Fri, Aug 6, 2021 at 4:26 PM Kristina Hanicova
> wrote:
>
>> This is v2 of:
>> https://listman.redhat.com/archives/libvir-list/2021-August/msg00187.html
>>
>> Changes since v1 (suggested by Peter):
>> * split of the patch containing api and virsh
On a %A in %Y, Michal Privoznik wrote:
> Libvirt assumes that a SCSI bus can fit up to 8 devices
> (including controller itself), except for so called wide bus
> which can accommodate up to 16 devices (again, including
> controller). This plays important role when computing 'drive'
> address in
On a %A in %Y, Peter Krempa wrote:
> Switch remaining users of virStringListFreeCount to g_auto(GStrv) and
> clean up some usage of string lists.
>
> Depends on the refactor of the virtual function code I've posted
> earlier.
>
> Pipeline:
>
>
On a %A in %Y, Michal Privoznik wrote:
> As of vSphere 6.7 there can be up to 64 units on a SCSI bus.
>
> Honestly, I'm not a big fan of 5/7 but we want to support three
> different values and one of them doesn't depend on the driver that's
> assigning the disk address, but at a runtime
On a %A in %Y, Peter Krempa wrote:
> Note that this applies on top of the 'VIR_APPEND_ELEMENT' refactor I've
> sent earlier.
>
> Pipeline:
> https://gitlab.com/pipo.sk/libvirt/-/pipelines/348524810
>
> Peter Krempa (6):
> virNetDevGetVirtualFunctions: Remove 'max_vfs' argument
>
On a %A in %Y, Peter Krempa wrote:
> Peter Krempa (6):
> virsh: Un-document 'virsh echo'
> virshtest: Don't use both '--xml' and '--shell' for 'virsh echo'
> virsh: cmdEcho: Make '--xml' and '--shell' mutually exclusive
> virsh: cmdEcho: Rewrite with new buffer helpers
> virsh: Add
On a %A in %Y, Kristina Hanicova wrote:
> We didn't always save status xml after generating new taint message
> which resulted in it being deleted in case of a libvirtd restart.
> Some taint messages were preserved thanks to saving status xml
> separately at the end of the calling functions. With
On a %A in %Y, Kristina Hanicova wrote:
> virXMLParse() now allows to validate xml against schema directly,
s/allows to validate/allows validating/
> eliminating the need to do it individually in each function.
>
> Signed-off-by: Kristina Hanicova
> ---
> src/conf/backup_conf.c | 13
On a %A in %Y, Peter Krempa wrote:
> Before we resume the CPUs there was no guest code executed so the events
> emitted by qemu are purely based on libvirt actions. Ignore them since
> they are emitted when we are resetting the machine so that it picks up
> hotplugged disks.
>
> Peter Krempa (2):
On a %A in %Y, Peter Krempa wrote:
> Add a disclaimer that filing a feature request issue has no guarantees
> that anybody will actually implement the feature.
>
> Based on the disclaimer in the QEMU project.
>
> Signed-off-by: Peter Krempa
> ---
> .gitlab/issue_templates/feature.md | 16
On a %A in %Y, Tim Wiederhake wrote:
> This appears to be a copy-paste mistake from the check directly above.
>
> Signed-off-by: Tim Wiederhake
> ---
> src/util/viridentity.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Ján Tomko
Jano
On a %A in %Y, Peter Krempa wrote:
> Peter Krempa (33):
> qemu: monitor: Remove handlers for the 'POWERDOWN' event
> qemu: monitor: Remove return value from qemuMonitorEmit* functions
> qemu: Remove return value from qemuMonitorDomainEventCallback
> qemu: Remove return value from
On a %A in %Y, Peter Krempa wrote:
> The submission of the event to the helper thread has a verbose cleanup
> path which was duplicated in all the event handlers. Simplify it by
> extracting the code into a helper named 'qemuProcessEventSubmit' and
> reuse it where appropriate.
>
> Signed-off-by:
On a %A in %Y, Peter Krempa wrote:
> On Wed, Jul 21, 2021 at 14:46:40 +0200, Tim Wiederhake wrote:
>> The next commit will use this macro outside the apparmor context.
>>
>> Signed-off-by: Tim Wiederhake
>> ---
>> src/security/security_apparmor.c | 4 ++--
>> src/security/security_apparmor.h |
On a %A in %Y, Peter Krempa wrote:
> The callers in the monitor code invoking the callbacks after events are
> received don't actually check the return value from the callbacks and
> there isn't really anything we could do on failure.
>
> Remove the return value from the intermediary functions so
On a %A in %Y, Peter Krempa wrote:
> Follow up to:
>
> https://listman.redhat.com/archives/libvir-list/2021-July/msg00281.html
>
> Peter Krempa (5):
> virsh-host: Avoid 'vir' prefix for locally declared VIR_ENUM* helpers
> virsh-domain: Avoid 'vir' prefix for locally declared VIR_ENUM*
>
On a %A in %Y, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake
> ---
> src/conf/nwfilter_params.c | 11 ---
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c
> index 63ab7e7150..35ea0256c3 100644
> ---
On a %A in %Y, Tim Wiederhake wrote:
> "virHashNew" cannot return NULL, yet we check for NULL in various places.
>
> See https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html.
>
> Tim Wiederhake (10):
> conf: Add AUTOPTR_CLEANUP_FUNC for virNWFilterVarValue
>
On a %A in %Y, Michal Privoznik wrote:
> A stub implementation for virQEMUCapsGetKVMSupportsSecureGuest()
> was added recently. However, the very same implementation was
> added to domaincapsmock.c which is also loaded by
> qemuxml2argvtest and thus one occurrence of the stub can be
> dropped.
>
On a %A in %Y, Daniel P. Berrangé wrote:
> Since we use git to manage RPM applied patches, we need to disable both
> meson's -Werror config knob and libvirt's equivalent.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> libvirt.spec.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
Reviewed-by: Ján Tomko
On Thu, Jun 30, 2022 at 10:56 AM Michal Privoznik wrote:
>
> Suggested by Dan here:
>
> https://listman.redhat.com/archives/libvir-list/2022-January/226681.html
>
> Since we can bump min gnutls version we don't have to care about
> pre-3.6.0 release he mentions in the
On a Tuesday in June Peter Krempa wrote:
>
> Patch 4/4 fixes the regression. Patch 3/4 fixes missing cases in the
> validation. Rest of the series is preparation/cleanup.
>
> Peter Krempa (4):
> virDomainDiskDefValidate: Improve error messages for 'startupPolicy'
> checks
>
59 matches
Mail list logo
