[libvirt] [PATCH] Fix sexpr2string() to handle empty list

ement. But IMO we should not produce the (cpus (()()...)) sexpr in this case. It should only be produced when user has explicitly specified affinity. Does this sound reasonable? Regards, Jim >From 1a1f8b9dbb68bf43c831e471ab4308d81a113ecd Mon Sep 17 00:00:00 2001 From: Jim Fehlig Date: Tue, 25

Re: [libvirt] 0.7.1 compile fails on opensuse 11.1

Dominik Klein wrote: Hi it seems openSuSE 11.1 does not come with a pkgconfig for the device-mapper-devel package. I created a bug [1] for opensuse but was also told to mention it here so configure.in could be patched once the bug was fixed. Regards Dominik 1 https://bugzilla.novell.com/show_b

Re: [libvirt] 0.7.1 compile fails on opensuse 11.1

Pritesh Kothari wrote: >> it seems openSuSE 11.1 does not come with a pkgconfig for the >> device-mapper-devel package. I created a bug [1] for opensuse but was >> also told to mention it here so configure.in could be patched once the >> bug was fixed. >> > > Hi All, > > Just fixed this for ub

[libvirt] [PATCH] Add ocfs2 to list of fs pool types

Ensures mount.ocfs2 is called when is specified in storage pool XML. Regards, Jim commit d68a79d63931d231d73fcfb3ae17285440e10ca6 Author: Jim Fehlig Date: Tue Oct 13 11:07:49 2009 -0600 Add filesystem type ocfs2 diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index

Re: [libvirt] [PATCH] Add ocfs2 to list of fs pool types

Daniel Veillard wrote: > On Tue, Oct 13, 2009 at 03:20:35PM -0600, Jim Fehlig wrote: > >> Ensures mount.ocfs2 is called when >> >> >> >> is specified in storage pool XML. >> > > Okay, looks fine but I also had to add ocfs2

Re: [libvirt] Re: [virt-tools-list] libvirt 0.7.2 linker issues

led and I have no > problem to build libvirt 0.7.1. Something wrong with the following > refactoring > (2009-09-20) ? > > * src/Makefile.am: Add -Isrc/conf to the individual build targets > which need to use XML config APIs. Remove LIBXML_CFLAGS, > LIBSSH2_CFL

[libvirt] [PATCH] Fix virsh.c compilation warning

A call to vshError() containing 'doexit' parameter sneaked in after I removed said parameter. Regards, Jim commit edea3dfdd861d5eee4712da43781908f0fa2a6d5 Author: Jim Fehlig Date: Mon Oct 19 13:53:40 2009 -0600 Remove extra arg in call to vshError() diff --git a/tools/virsh

Re: [libvirt] 0.7.1 compile fails on opensuse 11.1

Jim Fehlig wrote: > Pritesh Kothari wrote: > >>> it seems openSuSE 11.1 does not come with a pkgconfig for the >>> device-mapper-devel package. I created a bug [1] for opensuse but was >>> also told to mention it here so configure.in could be p

Re: [libvirt] virsh: error: failed to disconnect from the hypervisor in F12/rawhide with Xen

Pasi Kärkkäinen wrote: > Hello, > > I have a testbox running current Fedora 12 (rawhide), with custom 2.6.31.4 > Xen pv_ops dom0 kernel. > > [r...@f12test ~]# xm list > NameID Mem VCPUs State > Time(s) > Domain-0

[libvirt] [PATCH] Fix compilation of libvirt against xen-unstable

libvirt fails to compile against current xen-unstable. This patch fixes it. Regards, Jim commit d08067f04248c7f1bd797f4401308ea9a8971f1b Author: Jim Fehlig Date: Fri Nov 13 14:44:56 2009 -0700 xen-unstable changeset 19788 removed MAX_VIRT_CPUS from public headers, breaking

[libvirt] [PATCH] fix detach-disk for inactive xen domains

ns. Regards, Jim commit 769a887434faf76f8e80aa505e3880d4fdbe572e Author: Jim Fehlig Date: Fri Nov 13 15:34:44 2009 -0700 Fix detach-disk for inactive xen domains. Looking in xenstore for device ID of disk won't work for inactive xen domains. Instead, use the device name, e.g. xvda,

[libvirt] [PATCH 2/2] Disallow attach/detach device in Xen driver

The API documentation now explicitly states that attaching and detaching devices is only permitted on active domains. This is already the case in the qemu driver, make it so in the Xen driver. --- src/xen/xend_internal.c | 22 ++ 1 files changed, 10 insertions(+), 12 deletion

[libvirt] [PATCH 0/2] Disallow attach/detach device on inactive domains

This small patch series improves virDomain{Attach,Detach}Device documentation and disallows these operation on inactive domains in Xen driver as discussed here http://www.redhat.com/archives/libvir-list/2009-November/msg00513.html Jim Fehlig (2): Improve virDomain{Attach,Detach}Device

[libvirt] [PATCH 1/2] Improve virDomain{Attach, Detach}Device documentation

virDomain{Attach,Detach}Device is only permitted on active domains. Explicitly state this restriction in the API documentation. --- src/libvirt.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 05e45f3..918dd4f 100644 --- a/src/lib

Re: [libvirt] [PATCH 1/2] Improve virDomain{Attach, Detach}Device documentation

Daniel Veillard wrote: > On Mon, Nov 16, 2009 at 04:06:41PM -0700, Jim Fehlig wrote: > >> virDomain{Attach,Detach}Device is only permitted on active >> domains. Explicitly state this restriction in the API >> documentation. >> > > Well, actually I&#

Re: [libvirt] [PATCH 1/2] Improve virDomain{Attach, Detach}Device documentation

Cole Robinson wrote: > On 11/20/2009 01:39 PM, Jim Fehlig wrote: > >> Daniel Veillard wrote: >> >>> On Mon, Nov 16, 2009 at 04:06:41PM -0700, Jim Fehlig wrote: >>> >>> >>>> virDomain{Attach,Detach}Device is only permitted o

[libvirt] [PATCH] fix xenDaemonListDefinedDomains

Commit 790f0b3057787bb64da8c46c111ff8d3eff7b2af causes contents of names array to be freed even on success, resulting in no listing of defined but inactive Xen domains. Patch below fixes it. Regards, Jim Index: libvirt-0.7.4/src/xen/xend_internal.c ===

Re: [libvirt] [PATCH] fix xenDaemonListDefinedDomains

Matthias Bolte wrote: > 2009/11/25 Jim Fehlig : > >> Commit 790f0b3057787bb64da8c46c111ff8d3eff7b2af causes contents of names >> array to be freed even on success, resulting in no listing of defined >> but inactive Xen domains. Patch below fixes it. >> >>

[libvirt] [RFC] virDomain{Attach,Detach}Device

History I found that virDomainDetachDevice did not work with inactive domains and submitted a patch [1] to fix this. As it turns out, some drivers do not support attaching/detaching devices on inactive domains and it was preferred that virDomain{Attach,Detach}Device only be permitted on active do

[libvirt] [PATCH] Plumb domain description tag in xend backend

I sent this patch yesterday evening using git send-email on a test machine which did not have my .gitconfig, so the headers seem quite jacked. Resending ... /me still learning git :-/ Regards, Jim >From acba9b620128c4dcdbb95a1ea06604f3013a0518 Mon Sep 17 00:00:00 2001 From: Jim Fehlig D

[libvirt] [PATCH] [RFC] xen domctl version 6

xen-unstable c/s 20685 changed the domctl interface, adding a field to xen_domctl_getdomaininfo structure. This additional field causes stack corruption in libvirt. xen-unstable c/s 20711 rightly bumped the domctl interface version so it is at least possible to handle the new field. The attached

[libvirt] [PATCH]Fix minor issues in logical storage backend

Hi All! I came across some problems trying to create a new LVM-based storage pool using this config test_vg /dev/test_vg Volume group did not previously exist so I did virsh pool-define virsh pool-build test_vg pool-build failed since the backend logical storage driver

[libvirt] [PATCH] fix network interface parsing

Hi All, While testing libvirt 0.4.5 and 0.4.6 I noticed only one network interface in domain xml for a xen guest regardless of number actually assigned. Turns out the last interface parsed is always placed on head of nets list instead of appending to tail. Patch attached. Cheers, Jim Index: l

[libvirt] Relax requirement of bridge source device

Hi All, I wanted to get folks thoughts on relaxing the requirement for bridge source device in network interface of domain XML, e.g. allowing Currently, virDomainNetDefParseXML() in src/domain_conf.c will fail such configuration. Since this is common code between backends I'm

Re: [libvirt] Relax requirement of bridge source device

Daniel P. Berrange wrote: > On Wed, Nov 19, 2008 at 11:20:08PM -0700, Jim Fehlig wrote: > >> Hi All, >> >> I wanted to get folks thoughts on relaxing the requirement for bridge >> source device in network interface of domain XML, e.g. allowing >> &g

Re: [libvirt] libvirt + xen 3.2.1 oddities

Daniel P. Berrange wrote: > On Fri, Nov 21, 2008 at 11:13:04PM +0100, Guido G?nther wrote: > >> Hi, >> I just ran across these oddities when using a bit more libvirt+xen: >> >> 1.) virsh setmaxmem: >> >> On a running domain: >> # virsh setmaxmem domain 256000 >> completes but virsh dumpx

[libvirt] [PATCH] Prefer xend setmaxmem interface

As discussed in [1], prefer xend interface for setting max memory. Regards, Jim [1] https://www.redhat.com/archives/libvir-list/2008-November/msg00339.html Index: libvirt-0.4.6/src/xen_unified.c === --- libvirt-0.4.6.orig/src/xen_uni

Re: [libvirt] [PATCH] Prefer xend setmaxmem interface

Err, maybe a patch that actually compiles would be useful .. Jim Jim Fehlig wrote: > As discussed in [1], prefer xend interface for setting max memory. > > Regards, > Jim > > [1] https://www.redhat.com/archives/libvir-list/2008-November/msg00339.html > Index: libvirt-0.

Re: [libvirt] RFC: configuring host interfaces with libvirt

David Lutterkort wrote: > For certain applications, we want libvirt to be able to configure host > network interfaces in a variety of ways; currently, we are most > interested in teaching libvirt how to set up ordinary ethernet > interfaces, bridges, bonding and vlan's. > I agree that carving u

Re: [libvirt] RFC: configuring host interfaces with libvirt

David Lutterkort wrote: > For certain applications, we want libvirt to be able to configure host > network interfaces in a variety of ways; currently, we are most > interested in teaching libvirt how to set up ordinary ethernet > interfaces, bridges, bonding and vlan's. > > Below is a high-level pr

Re: [libvirt] RFC: configuring host interfaces with libvirt

Adding Marius (SuSE sysconfig maintainer) in case I'm misspeaking :-) David Lutterkort wrote: On Tue, 2009-01-20 at 11:35 -0700, Jim Fehlig wrote: David Lutterkort wrote: For certain applications, we want libvirt to be able to configure host network interfaces in a variety of

Re: [libvirt] Getting error "libvir: QEMU error : Domain not found"

M. Mohan Kumar wrote: > Hi, > > When I try to run vm-install on a OpenSuse 11.1 machine, vm-install displays > the following message "libvir: QEMU error : Domain not found". How ever the > functionality is not affected. > vm-install has some issues with qemu/kvm guests in 11.1. This is not a

Re: [libvirt] [PATCH] [RFC] xen domctl version 6

Daniel Veillard wrote: > On Wed, Dec 23, 2009 at 10:59:09AM -0700, Jim Fehlig wrote: > >> xen-unstable c/s 20685 changed the domctl interface, adding a field to >> xen_domctl_getdomaininfo structure. This additional field causes stack >> corruption in libvirt. xen-un

[libvirt] [PATCH] Fix free of invalid pointer in node_device_driver

If device does not have a driver, an uninitialized pointer was being free()'d in node_device_driver. Here's a small patch to fix it. Regards, Jim commit 49d8d703e4ac3253155871f97350bec10a15dfaf Author: Jim Fehlig Date: Wed Jan 6 17:17:08 2010 -0700 Fix free of invalid

Re: [libvirt] [PATCH] Fix free of invalid pointer in node_device_driver

Matthias Bolte wrote: > 2010/1/7 Jim Fehlig : > >> If device does not have a driver, an uninitialized pointer was being >> free()'d in node_device_driver. Here's a small patch to fix it. >> >> Regards, >> Jim >> >> > > I

Re: [libvirt] [PATCH] [RFC] xen domctl version 6

Jim Fehlig wrote: > Daniel Veillard wrote: > >> On Wed, Dec 23, 2009 at 10:59:09AM -0700, Jim Fehlig wrote: >> >> >>> xen-unstable c/s 20685 changed the domctl interface, adding a field to >>> xen_domctl_getdomaininfo structure. This addit

[libvirt] [PATCH] Fix migration in xend driver

Upstream xen has changed parameters to the migration operation several times over the past 18 months. Changeset 17553 removed the resouce parameter, Changesets 17709, 17753, and 20326 added ssl, node, and change_home_server parameters respectively. Fortunately, testing has revealed that xend wil

[libvirt] [PATCH 9/9] Modify virsh commands

Change all virsh commands that invoke virDomain{Attach,Detach}Device() to use virDomain{Attach,Detach}DeviceFlags() instead. Add a "--persistent" flag to these virsh commands, allowing user to specify that the domain persisted config be modified as well. --- tools/virsh.c | 55 +

[libvirt] [PATCH 0/9] virDomain{Attach,Detach}DeviceFlags patches

the new APIs. Jim Fehlig (9): Restrict virDomain{Attach,Detach}Device to active domains Public API Internal API Public API Implementation Wire protocol format Remote driver Server side dispatcher domain{Attach,Detach}DeviceFlags handler for drivers Modify virsh commands daemon

[libvirt] [PATCH 7/9] Server side dispatcher

Server side dispatcher for Domain{Attach,Detach}DeviceFlags. --- daemon/remote.c | 53 + 1 files changed, 53 insertions(+), 0 deletions(-) diff --git a/daemon/remote.c b/daemon/remote.c index 0b30131..395c060 100644 --- a/daemon/remote.c +++ b

[libvirt] [PATCH 2/9] Public API

Definition of public API for virDomain{Attach,Detach}DeviceFlags. --- include/libvirt/libvirt.h.in | 13 + src/libvirt_public.syms |6 ++ 2 files changed, 19 insertions(+), 0 deletions(-) diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index f19

[libvirt] [PATCH 6/9] Remote driver

Implementation of Domain{Attach,Detach}DeviceFlags in remote driver. --- src/remote/remote_driver.c | 54 1 files changed, 54 insertions(+), 0 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index d6f5fce..eb16f62 10

[libvirt] [PATCH 3/9] Internal API

Definition of internal API for virDomain{Attach,Detach}DeviceFlags. --- src/driver.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/driver.h b/src/driver.h index c7e4fbf..08fe816 100644 --- a/src/driver.h +++ b/src/driver.h @@ -192,9 +192,17 @@ typedef int

[libvirt] [PATCH 5/9] Wire protocol format

Definition of wire protocol format for virDomain{Attach,Detach}DeviceFlags. --- src/remote/remote_protocol.x | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x index bed3940..98953a9 100644 --- a/src

[libvirt] [PATCH 4/9] Public API Implementation

Implementation of public API for virDomain{Attach,Detach}DeviceFlags. --- src/libvirt.c | 106 1 files changed, 98 insertions(+), 8 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 1145561..77f76bc 100644 --- a/src/libvirt.c +

[libvirt] [PATCH 1/9] Restrict virDomain{Attach, Detach}Device to active domains

virDomain{Attach,Detach}Device is now only permitted on active domains. Explicitly state this restriction in the API documentation and enforce it in libvirt frontend. --- src/libvirt.c | 14 -- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/libvirt.c b/src/libvi

[libvirt] [PATCH 8/9] domain{Attach, Detach}DeviceFlags handler for drivers

Implementation of domain{Attach,Detach}DeviceFlags handlers in the drivers. --- src/esx/esx_driver.c|2 + src/lxc/lxc_driver.c|2 + src/opennebula/one_driver.c |2 + src/openvz/openvz_driver.c |2 + src/phyp/phyp_driver.c |2 + src/qemu/qemu_driver.c

[libvirt] [PATCH] Minor fixes for API extension doc

Update the API Extensions doc to reflect new source directory layout. --- docs/api_extension.html.in |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/api_extension.html.in b/docs/api_extension.html.in index 59d3414..de6eedc 100644 --- a/docs/api_extension.html.i

Re: [libvirt] [PATCH 4/9] Public API Implementation

Daniel P. Berrange wrote: > On Tue, Jan 19, 2010 at 07:40:14PM +, Daniel P. Berrange wrote: > >> On Thu, Jan 14, 2010 at 10:42:41AM -0700, Jim Fehlig wrote: >> >>> Implementation of public API for virDomain{Attach,Detach}DeviceFlags. >&g

Re: [libvirt] [PATCH 1/9] Restrict virDomain{Attach, Detach}Device to active domains

Daniel P. Berrange wrote: > On Thu, Jan 14, 2010 at 10:42:38AM -0700, Jim Fehlig wrote: > >> virDomain{Attach,Detach}Device is now only permitted on active >> domains. Explicitly state this restriction in the API >> documentation and enforce it in libvirt frontend.

Re: [libvirt] [PATCH 4/9] Public API Implementation

mpler / clearer code todo, so lets > just do that first. We can easily revisit adding compat code in the > remote driver client at a later date if we find it to be neccessary. > Revised patch below. Thanks, Jim commit 487b2434403d520027957ed623354b398984af31 Author: Jim Fehlig Date:

Re: [libvirt] [PATCH 9/9] Modify virsh commands

Daniel P. Berrange wrote: > On Thu, Jan 14, 2010 at 10:42:46AM -0700, Jim Fehlig wrote: > >> Change all virsh commands that invoke virDomain{Attach,Detach}Device() >> to use virDomain{Attach,Detach}DeviceFlags() instead. >> >> Add a "--persistent" flag t

Re: [libvirt] [PATCH 9/9] Modify virsh commands

Jim Fehlig wrote: > The existing behavior is essentially VIR_DOMAIN_DEVICE_MODIFY_LIVE. > qemu fails the operation if domain is inactive. Attach works on > inactive Xen domains, but detach does not. BTW, I'll have a follow on patch to fix the inactive detach in Xen driver. T

[libvirt] [PATCH] support XEN_SYSCTL_INTERFACE_VERSION

xen-unstable c/s 20762 bumped XEN_SYSCTL_INTERFACE_VERSION to 7. I don't see how the interface change affects libvirt, other than failing xenHypervisorInit() since version 7 is not tried. The attached patch accommodates the upcoming Xen 4.0 release by checking for XEN_SYSCTL_INTERFACE_VERSION 7.

Re: [libvirt] [PATCH] support XEN_SYSCTL_INTERFACE_VERSION

Daniel P. Berrange wrote: > On Tue, Jan 26, 2010 at 11:34:28PM -0700, Jim Fehlig wrote: > >> xen-unstable c/s 20762 bumped XEN_SYSCTL_INTERFACE_VERSION to 7. I >> don't see how the interface change affects libvirt, other than failing >> xenHypervisorInit()

Re: [libvirt] [PATCH 0/9] virDomain{Attach, Detach}DeviceFlags patches

Jim Fehlig wrote: > This set implements two new APIs, virDomainAttachDeviceFlags and > virDomainDetachDeviceFlags as discussed here > > https://www.redhat.com/archives/libvir-list/2009-December/msg00124.html > > Introduce two new APIs > > virDomainAttachDeviceFlags(virD

Re: [libvirt] [PATCH 0/9] virDomain{Attach, Detach}DeviceFlags patches

Daniel P. Berrange wrote: > On Mon, Feb 08, 2010 at 05:16:25PM -0500, Chris Lalancette wrote: > >> I suspect you have to run "cd src ; make rpcgen", and then check the >> resulting >> src/remote/remote_protocol.c and src/remote/remote_protocol.h into the >> repository to get things to work agai

Re: [libvirt] [PATCH 4/4] remote: Detect 'nc' version incompatibilities

Cole Robinson wrote: > This ugly thing is a shell script to detect availability of > the -q option for 'nc': debian and suse based distros need this > flag to ensure the remote nc will exit on EOF, so it will go away > when we close the tunnel. If it doesn't go away, a useless 'nc' > process is lef

Re: [libvirt] [PATCH 2/3] Format FS pools

Daniel Veillard wrote: > On Thu, Feb 18, 2010 at 05:58:06PM -0500, David Allan wrote: > >> * If the user supplies the appropriate flag, create the filesystem on the >> partition used by the pool. >> --- >> configure.ac |5 + >> include/libvirt/libvirt.h.in |

[libvirt] [PATCH] Do not search xenstore for disk device IDs

Disk devices can be referenced by name in Xen, e.g. when modifying their configuration or remvoving them. As such, don't search xenstore for a device ID corresponding to the disk device. Instead, search the disks contained in the domain definition and use the disk's target name if found. This ap

Re: [libvirt] [PATCH] Do not search xenstore for disk device IDs

Daniel P. Berrange wrote: > On Mon, Feb 22, 2010 at 02:50:07PM -0700, Jim Fehlig wrote: > >> Disk devices can be referenced by name in Xen, e.g. when modifying >> their configuration or remvoving them. As such, don't search >> xenstore for a device ID corresponding

[libvirt] [PATCH] Avoid libvirtd crash when cgroups is not configured on host

Patch for libvirtd segfault discussed on IRC recently ... Regards, Jim commit f034c0bfd7089ba3400b7a44b97540c4a8785e35 Author: Jim Fehlig Date: Sun Mar 21 19:59:13 2010 -0600 Avoid libvirtd crash when cgroups is not configured on host Invoking virDomainSetMemory() on lxc driver

Re: [libvirt] [PATCH] Avoid libvirtd crash when cgroups is not configured on host

Daniel P. Berrange wrote: > On Sun, Mar 21, 2010 at 08:07:15PM -0600, Jim Fehlig wrote: > > >> commit f034c0bfd7089ba3400b7a44b97540c4a8785e35 >> Author: Jim Fehlig >> Date: Sun Mar 21 19:59:13 2010 -0600 >> >> Avoid libvirtd crash

[libvirt] [PATCH] Only parse 'CPU XML' in virCPUDefParseXML()

factory please include it for 0.7.8/0.8.0 release :-). Otherwise I'll respin with suggested changes next week. Thanks! Jim commit 93d68602a9701dc6f6b4f4b20eaac7159c8d3be7 Author: Jim Fehlig Date: Wed Mar 31 17:02:57 2010 -0600 Only parse 'CPU XML' in virCPUDefParseXML()

Re: [libvirt] [PATCH] Only parse 'CPU XML' in virCPUDefParseXML()

Jiri Denemark wrote: >> commit 93d68602a9701dc6f6b4f4b20eaac7159c8d3be7 >> Author: Jim Fehlig >> Date: Wed Mar 31 17:02:57 2010 -0600 >> >> Only parse 'CPU XML' in virCPUDefParseXML() >> > > I pushed this patch. > Thanks!

Re: [Libvir] PATCH: Allow remote driver to handle any connection URI

Daniel P. Berrange wrote: > We currently have logic in the remote driver so that it handles the local > QEMU driver URIs, so they get re-directed to the daemon. It also handles > networking APIs for Xen driver. For normal APIs, Xen has the auto-spawned > setuid proxy daemon. This was very useful at

Re: [Libvir] [PATCH] Xen: Support cpu_weight and cpu_cap for Xen.

David Lutterkort wrote: On Fri, 2007-10-26 at 09:08 -0400, Daniel Veillard wrote: I can understand the need to make it easy for an user, I still don't think this means those tuning informations need to be associated to the domain definition, to me it is somehow orthogonal to the domain them

Re: [Libvir] The problem of the definition of tuning informations

Daniel Veillard wrote: > On Thu, Nov 08, 2007 at 02:00:10PM -0600, Ryan Harper wrote: > >> * Daniel Veillard <[EMAIL PROTECTED]> [2007-11-08 10:08]: >> >>> I promised that mail for the beginning of the week but I still have >>> I think tuning informations are that set of parameters associ

Re: [Libvir] Libvirt version

Katti, Vadiraj (STSD-Openview) wrote: > > Hi, >Currently the latest version of libvirt available is 0.3.3. But > SLES 10 ships 0.2.0 version of libvirt (not sure what version RHEL 5.1 > ships). Any idea when and on what basis SLES decides to ship the > upgraded version of libvirt. > libvirt wi

Re: [Libvir] Libvirt version

Jim Fehlig wrote: [...] > I have latest libvirt packages for 10.3 and SLE in my home project: > > https://build.opensuse.org/package/show?project=home%3Ajfehlig&package=libvirt > Oops, sorry - I was logged in when I copied that link. For SLE you can get rpms here http://downl

[Libvir] [PATCH] Add /usr/sbin to path when searching for iptables

iptables resides in /usr/sbin on SuSE distros. Add it to path when searching for iptables. Regards, Jim diff -ur a/configure.in b/configure.in --- a/configure.in 2008-05-05 13:46:20.0 -0600 +++ b/configure.in 2008-05-05 13:43:14.0 -0600 @@ -217,7 +217,7 @@ AC_DEFINE_UNQUOTED(

Re: [libvirt] [PREPOST 05/17] src/xenxs:Refactor PCI parsing code

David Kiarie wrote: > From: Kiarie Kahurani > > Introduce the function > xenParseXMPCI(.); > which parses PCI config > > signed-off-by:David Kiarie > --- > src/xenxs/xen_xm.c | 192 > +++-- > 1 file changed, 99 insertions(+), 93 deletions

Re: [libvirt] [PREPOST 06/17] src/xenxs:Refactor code parsing CPU config

David Kiarie wrote: > From: Kiarie Kahurani > > Introduce xenParseXMCPUFeatures(.); > This function parses config related to CPU and power > management > > signed-off-by:David Kiarie > --- > src/xenxs/xen_xm.c | 116 > - > 1 file changed, 6

Re: [libvirt] [PREPOST 07/17] src/xenxs:Refactor disk config parsing code

David Kiarie wrote: > From: Kiarie Kahurani > > Introduce the function > xenParseXMDisk(..); > > Parses disk config > > signed-off-by: David Kiarie > --- > src/xenxs/xen_xm.c | 204 > - > 1 file changed, 108 insertions(+), 96 deletions

Re: [libvirt] [PREPOST 07/17] src/xenxs:Refactor disk config parsing code

Eric Blake wrote: > On 07/11/2014 01:04 PM, Jim Fehlig wrote: > >> David Kiarie wrote: >> >>> From: Kiarie Kahurani >>> >>> Introduce the function >>> xenParseXMDisk(..); >>> >>> Parses disk config &

Re: [libvirt] [PREPOST 08/17] src/xenxs:Refactor graphics config parsing code

David Kiarie wrote: > From: Kiarie Kahurani > > introduce function > > xenParseXMVfb(.); > > which parses the graphics config > > signed-off-by: David Kiarie > --- > src/xenxs/xen_xm.c | 247 > - > 1 file changed, 131 insertions(+), 116 d

Re: [libvirt] [PREPOST 09/17] src/xenxs:Refactor OS and Miscellaneous deivices config

David Kiarie wrote: > From: Kiarie Kahurani > > Introduce functions > xenParseXMOS(.) and > xenParseXMMisc(.) to parse the OS and > Miscellaneous devices configs > > signed-off-by: David Kiarie > --- > src/xenxs/xen_xm.c | 146 > ++--- >

Re: [libvirt] [PREPOST 10/17] src/xenxs:Refactor xenParseXM( )

David Kiarie wrote: > From: Kiarie Kahurani > > A couple of miscellaneous fixed and wrap code common code into > xenParseConfigCommon(...).I will drop some of the functions later > though > > signed-off-by: David Kiarie > --- > src/xenxs/xen_xm.c | 134 > -

Re: [libvirt] [PREPOST 11/17] src/xenxs:Refactor code formating general information

David Kiarie wrote: > From: Kiarie Kahurani > > refactor code parsing uuid, memory and name options > > signed-off-by:David Kiarie > --- > src/xenxs/xen_xm.c | 40 +++- > 1 file changed, 27 insertions(+), 13 deletions(-) > > diff --git a/src/xenxs/xen_xm.c b/sr

Re: [libvirt] [PREPOST 12/17] src/xenxs:Refactor virtual time config options formating code

David Kiarie wrote: > From: Kiarie Kahurani > > Introduce function > xenFormatXMTimeOffset(..) > which formats virtual time config > Ah, on the format side you split TimeOffset and EventActions as I requested on the parse side. Looks good with the exception of the usual whitespace commen

Re: [libvirt] [PREPOST 13/17] src/xenxs:Refactor code formating event actions config

David Kiarie wrote: > From: Kiarie Kahurani > > Introduce function > xenFormatXMEventActions(.) > which formats actions following certain events > Looks good with exception of my tiring whitespace comments :-). Regards, Jim > signed-off-by:David Kiarie > --- > src/xenxs/xen_xm.c | 6

Re: [libvirt] [PREPOST 14/17] src/xenxs:Refactor code formating char devices config

David Kiarie wrote: > From: Kiarie Kahurani > > Introduce function > xenFormatXMCharDev(); > which formats char devices config > > signed-off-by:David Kiarie > --- > src/xenxs/xen_xm.c | 155 > - > 1 file changed, 82 insertions(+), 73 dele

Re: [libvirt] [PREPOST 15/17] src/xenxs:Refactor Vif formating code

David Kiarie wrote: > From: Kiarie Kahurani > > Introduce the function > xenFormatXMDomainNet(..) > On the parsing side, you called this xenParseXMVif. To be consistent, this should be xenFormatXMVif. > I think this could be done in a cleaner way > > signed-of-by: David Kiarie > --- >

Re: [libvirt] [PATCH 0/3] libxl: support hotplug of device

Chunyan Liu wrote: > This patch series is to add support for attach/detaching an > device. At the same time, add two fixes (1/3 and 3/3) > > Chunyan Liu (3): > libxl: add HOSTDEV type in libxlDomainDetachDeviceConfig > libxl: support hotplug of > libxl: fix return value error Attach|DetachD

Re: [libvirt] [PREPOST 03/17] src/xenxm:Refactor network config parsing code

Jim Fehlig wrote: > David Kiarie wrote: > >> From: Kiarie Kahurani >> >> I introduced the function >> xenFormatXMVif(virConfPtr conf, ..); >> which parses network configuration >> >> signed-off-by: D

Re: [libvirt] [PREPOST 15/17] src/xenxs:Refactor Vif formating code

David kiarie wrote: > Thanks for the review, am applying changes to address your comments. > Thanks David, looking forward to a V2. BTW, 16/17 and 17/17 look good with exception of the usual whitespace comments. Regards, Jim -- libvir-list mailing list libvir-list@redhat.com https://www.redh

Re: [libvirt] [PATCH] libxl: Implement basic video device selection

Stefan Bader wrote: > being as bad with timely responses. Ok, so how about the following? > > One note: it could be the STRDUP's are not strictly needed. But > to me it felt wrong to have two places refer to the same strings > (as MakeVFB copies the struct containing the pointers). Agreed. Withou

Re: [libvirt] [PATCH] libxl: Implement basic video device selection

Stefan Bader wrote: > On 16.07.2014 23:05, Jim Fehlig wrote: > >> While testing this, I noticed that libvirt will set vram to 9216 if not >> specified. E.g. >> >> # cat test.xml >> ... >> >> >> >

Re: [libvirt] [python PATCH] Bump version to 1.2.8 for new dev cycle

Eric Blake wrote: > Signed-off-by: Eric Blake > --- > > Pushing under the trivial rule. > > setup.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/setup.py b/setup.py > index 334d7b2..f5c6542 100755 > --- a/setup.py > +++ b/setup.py > @@ -309,7 +309,7 @@ class my_clean(

Re: [libvirt] [PATCH v2 01/25] src/xenxs:Refactor code parsing memory config

David Kiarie wrote: > From: Kiarie Kahurani > > Introduce function > xenParseXMMem(virConfPtr conf,..); > which parses memory config instead > Since you mentioned off-list that a V3 is in the works, I'll point out a nit below you can address. > signed-off-by: David Kiarie > --- > src/xe

Re: [libvirt] [PATCH v2 02/25] src/xenxs:Refactor code parsing event actions config

David Kiarie wrote: > From: Kiarie Kahurani > > Introduce function > xenParseXMEventActions(virConfPtr conf,..); > which parses events config instead > > signed-off-by: David Kiarie > --- > src/xenxs/xen_xm.c | 65 > +++--- > 1 file changed, 3

Re: [libvirt] [PATCH v2 03/25] src/xenxs:Refactor code parsing virtual time controls config

David Kiarie wrote: > From: Kiarie Kahurani > > Introduce function > xenParseXMTimeOffset(virConfPtr conf,..); > which parses virtual config instead > > signed-off-by: David Kiarie > --- > src/xenxs/xen_xm.c | 73 > -- > 1 file changed, 44

Re: [libvirt] [PATCH v2 06/25] src/xenxs:Refactor code parsing disk config

David Kiarie wrote: > From: Kiarie Kahurani > > Introduce function > xenParseXMDisk(virConfPtr conf,..); > which parses XM disk config instead > > signed-off-by: David Kiarie > --- > src/xenxs/xen_xm.c | 302 > - > 1 file changed, 157 inse

Re: [libvirt] [PATCH v2 07/25] src/xenxs:Refactor code parsing Vfb config

David Kiarie wrote: > From: Kiarie Kahurani > > introduce function > xenParseXMVfb(virConfPtr conf,...) > which parses Vfb config > > signed-off-by: David Kiarie > --- > src/xenxs/xen_xm.c | 296 > - > 1 file changed, 154 insertions(+), 1

Re: [libvirt] [PATCH v2 10/25] src/xenxs:Refactor code parsing Vif

David Kiarie wrote: > From: Kiarie Kahurani > > introduce function > xenParseXMVif(virConfPtr conf, ...) > which parses char Vif config instead > > signed-off-by: David Kiarie > --- > src/xenxs/xen_xm.c | 161 > - > 1 file changed, 86 ins

Re: [libvirt] [PATCH v2 14/25] src/xenxs:Refactor code formating general config

David Kiarie wrote: > From: Kiarie Kahurani > > introduce function > xenFormatXMGeneralMeta(virConfPtr conf, ...); > which formats UUID and name instead > > signed-off-by: David Kiarie > --- > src/xenxs/xen_xm.c | 24 +++- > 1 file changed, 15 insertions(+), 9 deletions(-

Re: [libvirt] [PATCH v2 15/25] src/xenxs:Refactor code formating memory config

David Kiarie wrote: > From: Kiarie Kahurani > > introduce function > xenFormatXMMem(virConfPtr conf, ...); > which formats mem and max-mem instead.This could be joined into > XenFormatXMGeneralMeta but I separated them for consistency > > signed-off-by: David Kiarie > --- > src/xenxs/xen_xm.

Re: [libvirt] [PATCH v2 17/25] src/xenxs:Refactor code formating event actions config

David Kiarie wrote: > From: Kiarie Kahurani > > introduce function > xenFormatXMEventActions(virConfPtr conf, ...); > which formats event actions config instead > > signed-off-by: David Kiarie > --- > src/xenxs/xen_xm.c | 64 > ++ > 1 fil

Re: [libvirt] [PATCH v2 16/25] src/xenxs:Reafactor code formating virtual time config

David Kiarie wrote: > From: Kiarie Kahurani > > introduce function > xenFormatXMTimeOffset(virConfPtr conf, ...); > which formats time offset config instead > > signed-off-by: David Kiarie > --- > src/xenxs/xen_xm.c | 156 > - > 1 file ch

Re: [libvirt] [PATCH v2 18/25] src/xenxs:Refactor code formating Vif config

David Kiarie wrote: > From: Kiarie Kahurani > > introduce function > xenFormatXMVif(virConfPtr conf, ); > which formats Vif config instead > > signed-off-by: David Kiarie > --- > src/xenxs/xen_xm.c | 60 > ++ > 1 file changed, 38 inse

  1   2   3   4   5   6   7   8   9   10   >