[PATCH 5/5] tests: check conversion of passthrough hypervisor feature

2020-04-17 Thread Jim Fehlig
Add a new test to check the 'mode' attribute of the passthrough element and augment an existing, related test to check enablement of the passthrough element only. Signed-off-by: Jim Fehlig --- .../test-fullvirt-hypervisor-features.cfg | 26 ++ .../test-fullvirt-

[PATCH 1/5] conf: add xen hypervisor feature 'passthrough'

2020-04-17 Thread Jim Fehlig
element also supports a 'mode' attribute with values restricted to snyc_pt and share_pt, similar to xl.cfg(5) 'passthrough' setting . Signed-off-by: Jim Fehlig --- docs/formatdomain.html.in | 7 +++ docs/schemas/domaincommon.rng | 12 src/conf/domain_conf.c

Re: [PATCH] libxl: enable Xen's e820_host setting

2020-04-14 Thread Jim Fehlig
On 4/14/20 4:07 PM, Marek Marczykowski-Górecki wrote: On Tue, Apr 14, 2020 at 03:56:47PM -0600, Jim Fehlig wrote: On 4/13/20 1:17 PM, Marek Marczykowski-Górecki wrote: FWIW, in Qubes we have a patches adding e820_host setting here: https://github.com/QubesOS/qubes-core-libvirt/ (patches 8-11

Re: [PATCH v2 1/4] conf: add xen specific feature: e820_host

2020-04-14 Thread Jim Fehlig
. e820_host is silently ignored if set in HVM domain configuration. See xl.cfg(5) man page in the Xen documentation for more details. Signed-off-by: Marek Marczykowski-Górecki This looks good to me now so Reviewed-by: Jim Fehlig But before pushing I'd like to settle on mapping the new 'p

Re: [PATCH] libxl: enable Xen's e820_host setting

2020-04-14 Thread Jim Fehlig
On 4/13/20 1:17 PM, Marek Marczykowski-Górecki wrote: FWIW, in Qubes we have a patches adding e820_host setting here: https://github.com/QubesOS/qubes-core-libvirt/ (patches 8-11) Not submitted before, exactly to avoid adding temporary options. But since 8+ years later it is still there, I think

Re: [PATCH 4/4] tests: check e820_host option handling

2020-04-13 Thread Jim Fehlig
--- a/tests/xlconfigtest.c +++ b/tests/xlconfigtest.c @@ -300,6 +300,7 @@ mymain(void) DO_TEST("vif-multi-ip"); DO_TEST("usb"); DO_TEST("usbctrl"); +DO_TEST("paravirt-e820_host"); testXLFreeDriver(driver); Reviewed-by: Jim Fehlig Regards, Jim

Re: [PATCH 3/4] xenconfig: parse e820_host option

2020-04-13 Thread Jim Fehlig
;e820_host", 1) < 0) +return -1; +} } for (i = 0; i < def->clock.ntimers; i++) { Reviewed-by: Jim Fehlig Regards, Jim

Re: [PATCH 2/4] libxl: make use of e820_host feature

2020-04-13 Thread Jim Fehlig
On 4/13/20 2:10 PM, Marek Marczykowski-Górecki wrote: Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jim Fehlig Regards, Jim --- src/libxl/libxl_conf.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index

Re: [PATCH] libxl: enable Xen's e820_host setting

2020-04-13 Thread Jim Fehlig
On 4/13/20 1:17 PM, Marek Marczykowski-Górecki wrote: On Thu, Apr 09, 2020 at 02:52:30PM -0600, Jim Fehlig wrote: On 4/9/20 7:14 AM, Daniel P. Berrangé wrote: On Wed, Apr 08, 2020 at 02:29:16PM -0600, Jim Fehlig wrote: Hotplugging PCI devices to Xen PV guests is only possible if the

Re: [PATCH 1/4] conf: add xen specific feature: e820_host

2020-04-13 Thread Jim Fehlig
On 4/13/20 2:10 PM, Marek Marczykowski-Górecki wrote: This is Xen specific option to provide domain e820 map based on host one. Useful when using PCI passthrough, see Xen documentation for more details. I would reword this a bit to mention it is PV-only and documented in the xl.cfg man page. E

Re: [PATCH] libxl: enable Xen's e820_host setting

2020-04-09 Thread Jim Fehlig
On 4/9/20 7:14 AM, Daniel P. Berrangé wrote: On Wed, Apr 08, 2020 at 02:29:16PM -0600, Jim Fehlig wrote: Hotplugging PCI devices to Xen PV guests is only possible if the libxl_domain_build_info struct has the e820_host field enabled when the guest is created. By default it is disabled but libxl

[PATCH] libxl: enable Xen's e820_host setting

2020-04-08 Thread Jim Fehlig
"once the auto-ballooning of guests with PCI devices works". Those commits are from May 2011 so I think it is safe to say the issues have been resolved in the meantime. Regardless, we should avoid exposing a Xen setting in libvirt that could be removed later. Signed-off-by: Jim Fehlig

[PATCH 3/3] xenconfig: Add support for max_event_channels

2020-04-08 Thread Jim Fehlig
of the existing tests. Include a new test for the event channel conversion. Signed-off-by: Jim Fehlig --- src/libxl/xen_xl.c| 57 +++ tests/xlconfigdata/test-max-eventchannels.cfg | 13 + tests/xlconfigdata/test-max-eventchannels.xml | 32 +++

[PATCH 0/3] libxl: Add support for max_event_channels

2020-04-08 Thread Jim Fehlig
This series implements support Xen's max_event_channels setting as proposed in this thread https://www.redhat.com/archives/libvir-list/2020-April/msg00376.html See the individual patches for details. Jim Fehlig (3): conf: Add a new xenbus controller option for event channels libxl

[PATCH 2/3] libxl: Add support for max_event_channels

2020-04-08 Thread Jim Fehlig
Add support for setting event_channels in libxl domain config object and include a test to check that it is properly converted from XML to libxl domain config. Signed-off-by: Jim Fehlig --- src/libxl/libxl_conf.c| 14 +-- .../max-eventchannels-hvm.json

[PATCH 1/3] conf: Add a new xenbus controller option for event channels

2020-04-08 Thread Jim Fehlig
reason the native Xen config format supports the 'max_event_channels' setting. See xl.cfg(5) man page for more details. Similar to the existing maxGrantFrames option, add a new xenbus controller option 'maxEventChannels', allowing to adjust the maximum value via libvirt. Signe

Re: A few XML modeling questions

2020-04-07 Thread Jim Fehlig
On 4/7/20 12:02 PM, Jim Fehlig wrote: Hi All, [...] e820_host is a bit trickier. For this setting, which is PV-specific, the man page says:  Selects whether to expose the host e820 (memory map) to the guest via the  virtual e820. When this option is false (0) the guest pseudo-physical

A few XML modeling questions

2020-04-07 Thread Jim Fehlig
Hi All, I've been struggling a bit deciding how to model Xen's max_event_channels and e820_host xl.cfg(5) settings. For max_event_channels the man page says: Limit the guest to using at most N event channels (PV interrupts). Guests use hypervisor resources for each event channel they use.

Re: [PATCH] libxl: fix crash when initializing driver

2020-04-06 Thread Jim Fehlig
On 4/6/20 3:19 AM, Ján Tomko wrote: On a Friday in 2020, Jim Fehlig wrote: Commit 54a401af478 split out DriverConfigInit from DriverConfigNew, but then called it a bit late from libxlStateInitialize. The cfg is used in libxlDriverConfigLoadFile and when uninitialized results in a crash. Calling

[PATCH] libxl: fix crash when initializing driver

2020-04-03 Thread Jim Fehlig
-off-by: Jim Fehlig --- src/libxl/libxl_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 7ec4fcc3d1..980984b199 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -702,14 +702,14

Re: [PATCH] docs: fix typo in domcaps host-model CPU description

2020-03-25 Thread Jim Fehlig
On 3/24/20 3:44 AM, Jiri Denemark wrote: The situation on the first machine is a bit strange as there are no features disabled in host-model CPU definition, which makes it unclear why QEMU reports Cascadelake-Server as unusable (QEMU reports the reason, but we don't do so yet). I got back to lo

Re: [PATCH] docs: fix typo in domcaps host-model CPU description

2020-03-24 Thread Jim Fehlig
On 3/24/20 8:30 AM, Jim Fehlig wrote: On 3/24/20 3:44 AM, Jiri Denemark wrote: The situation on the first machine is a bit strange as there are no features disabled in host-model CPU definition, which makes it unclear why QEMU reports Cascadelake-Server as unusable (QEMU reports the reason, but

Re: [PATCH] docs: fix typo in domcaps host-model CPU description

2020-03-24 Thread Jim Fehlig
On 3/24/20 3:44 AM, Jiri Denemark wrote: On Mon, Mar 23, 2020 at 15:47:49 -0600, Jim Fehlig wrote: The domain capabilities documentation contains a small but confusing error in the host-model CPU description, referencing the element instead of . Fix this small typo. Signed-off-by: Jim Fehlig

Re: TCK regression from blockdev change

2020-03-23 Thread Jim Fehlig
On 3/10/20 1:21 AM, Peter Krempa wrote: On Mon, Mar 09, 2020 at 15:11:22 -0600, Jim Fehlig wrote: Hi all, I noticed libvirt-tck test 207-disk-media-change.t is failing with 6.1.0, although I _think_ the failure has actually been around since the change to using blockdev in the qemu driver. The

[libvirt-tck] scripts: fix disk media change test

2020-03-23 Thread Jim Fehlig
ure the correct path exists at the end of the test. Signed-off-by: Jim Fehlig --- scripts/domain/207-disk-media-change.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/domain/207-disk-media-change.t b/scripts/domain/207-disk-media-change.t index dfef7c9..7a43a

[PATCH] docs: fix typo in domcaps host-model CPU description

2020-03-23 Thread Jim Fehlig
The domain capabilities documentation contains a small but confusing error in the host-model CPU description, referencing the element instead of . Fix this small typo. Signed-off-by: Jim Fehlig --- I only found this small typo (well, I'm pretty sure it's a typo :-)) by tring to un

Re: [PATCH] qemu: Create multipath targets for PRs

2020-03-11 Thread Jim Fehlig
tLength((const char **) paths); if (qemuDomainNamespaceMknodPaths(vm, (const char **) paths, npaths) < 0) -goto cleanup; + return -1; -ret = 0; - cleanup: -virStringListFreeCount(paths, npaths); -return ret; +return 0; It looks like a little

TCK regression from blockdev change

2020-03-09 Thread Jim Fehlig
Hi all, I noticed libvirt-tck test 207-disk-media-change.t is failing with 6.1.0, although I _think_ the failure has actually been around since the change to using blockdev in the qemu driver. The test essentially creates a minimal domain with a cdrom disk device, then calls attach_device a fe

Re: [PATCH] virt-aa-helper: Fix build by including virutil.h

2020-02-25 Thread Jim Fehlig
On 2/25/20 4:35 AM, Michal Privoznik wrote: On 2/25/20 10:06 AM, Christian Ehrhardt wrote: On Tue, Feb 25, 2020 at 12:36 AM Jim Fehlig <mailto:jfeh...@suse.com>> wrote:     Commit fb01e1a44d missed including virutil.h, causing the following     compilation error     ../../src/secu

Re: [libvirt PATCH 0/7] tests: libxl: clean up test mocking

2020-02-24 Thread Jim Fehlig
+++ tests/testutilsxen.c | 9 +++- 7 files changed, 75 insertions(+), 58 deletions(-) For the series Reviewed-by: Jim Fehlig Regards, Jim

Re: [libvirt PATCH 7/7] tests: libxl: do not run the emulator

2020-02-24 Thread Jim Fehlig
On 2/22/20 7:25 AM, Ján Tomko wrote: Ever since commit c5a00350 the libxl parser invokes the emulator to probe which device model to use. Commit b90c4b5 introduced a workaround that used a stable path which was very likely to result in the answer matching the default. However the test is still a

[PATCH] virt-aa-helper: Fix build by including virutil.h

2020-02-24 Thread Jim Fehlig
RenderNode = virHostGetDRMRenderNode(); Signed-off-by: Jim Fehlig --- Pushing under the build-breaker rule. src/security/virt-aa-helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 6f36652c7c..b6f58efdea 100644 --- a/src/securi

Re: [PATCH] apparmor: allow to call vhost-user-gpu

2020-02-14 Thread Jim Fehlig
On 2/14/20 1:14 PM, Christian Ehrhardt wrote: On Fri, Feb 14, 2020 at 6:00 PM Jim Fehlig <mailto:jfeh...@suse.com>> wrote: On 2/13/20 4:32 AM, Christian Ehrhardt wrote: > Configuring vhost-user-gpu like: >      >        >        > 

Re: [PATCH] apparmor: allow to call vhost-user-gpu

2020-02-14 Thread Jim Fehlig
On 2/13/20 4:32 AM, Christian Ehrhardt wrote: Configuring vhost-user-gpu like: Triggers an apparmor denial like: apparmor="DENIED" operation="exec" profile="libvirtd" name="/usr/lib/qemu/vhost-user-gpu" pid=888257 comm="libvirtd" requested_mask="x" denie

Re: [libvirt PATCH 0/6] Introduce Local Migration Support in Libvirt

2020-02-10 Thread Jim Fehlig
On 2/3/20 5:43 AM, Daniel P. Berrangé wrote: I'm (re-)sending this patch series on behalf of Shaju Abraham who has tried to send this several times already. Red Hat's email infrastructure is broken, accepting the mails and then failing to deliver them to mailman, or any other Red Hat address. U

Re: [PATCH v3 2/3] apparmor: Allow libvirt to spawn virt-aa-helper and libvirt_lxc

2020-02-03 Thread Jim Fehlig
On 2/3/20 9:50 AM, Daniel P. Berrangé wrote: On Thu, Jan 30, 2020 at 03:12:31PM +0100, Michal Privoznik wrote: Both of these binaries are spawn by libvirt. Add a rule to the default profile to allow that. Signed-off-by: Michal Privoznik --- src/security/apparmor/usr.sbin.libvirtd.in | 2 ++

Re: [PATCH v3 1/3] apparmor: Reflect paths from configure in profiles

2020-02-03 Thread Jim Fehlig
On 1/30/20 7:12 AM, Michal Privoznik wrote: The configure script allows users to specify different paths for /etc/, /usr/sbin/, /var/run/ and /usr/libexec/. Instead of assuming user will pass expected value, generate the apparmor profiles using the actual values. Signed-off-by: Michal Privoznik

Re: [PATCH] lib: Prohibit parallel connections with tunneled migration

2020-01-31 Thread Jim Fehlig
Any comments on this patch? Regards, Jim On 1/21/20 8:00 PM, Jim Fehlig wrote: As discussed on the developer list, parallel migration connections are not compatible with tunneled migration https://www.redhat.com/archives/libvir-list/2020-January/msg00463.html Prohibit the concurrent use of

Re: [PATCH] build: Drop execute permissions on virsh bash completion command

2020-01-31 Thread Jim Fehlig
On 1/31/20 8:39 AM, Michal Privoznik wrote: On 1/31/20 3:38 PM, Jim Fehlig wrote: rpmlint complains about "script-without-shebang" due to the execute permissions on /usr/share/bash-completion/completions/vsh. Use INSTALL_DATA instead of INSTALL_SCRIPT to avoid the unnecessa

[PATCH] build: Drop execute permissions on virsh bash completion command

2020-01-31 Thread Jim Fehlig
rpmlint complains about "script-without-shebang" due to the execute permissions on /usr/share/bash-completion/completions/vsh. Use INSTALL_DATA instead of INSTALL_SCRIPT to avoid the unnecessary execute permissions. Signed-off-by: Jim Fehlig --- BTW, of the nearly 800 files in /usr/

Re: [PATCH 1/6] apparmor: Fix parthelper, iohelper and virt-aa-helper paths in profiles

2020-01-30 Thread Jim Fehlig
On 1/29/20 11:48 PM, Michal Privoznik wrote: > Ah, so I guess SUSE has a patch that moves virt-aa-helper from its default > location then? No. The configure script is invoked with '--libexecdir=%{_libdir}/%{name}'. I'd have to dig deep into history to know why that's the case. Regards, Jim

Re: [PATCH 1/6] apparmor: Fix parthelper, iohelper and virt-aa-helper paths in profiles

2020-01-29 Thread Jim Fehlig
On 1/29/20 11:53 AM, Jamie Strandboge wrote: > On Wed, 29 Jan 2020, Michal Privoznik wrote: > >> On 1/27/20 5:30 PM, Jamie Strandboge wrote: >>> On Sat, 25 Jan 2020, Michal Privoznik wrote: >>> These helper binaries are installed under libexec dir not lib dir. Signed-off-by: Mi

Re: [PATCH] libxl: support getting and setting parameters for the Credit2

2020-01-29 Thread Jim Fehlig
ow) the very > same parameters ('weight' and 'cap'). So we can just let credit2 pass > the scheduler-type check and the same code will work for both. > > Signed-off-by: Dario Faggioli > --- > Cc: Jim Fehlig > --- > src/libxl/libxl_driver.c | 18 +

Re: [PATCH] libxl: initialize shutdown inhibit callback

2020-01-21 Thread Jim Fehlig
;s been overlooked for quite some time. > > Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jim Fehlig and pushed now. Regards, Jim > --- > src/libxl/libxl_driver.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/src/libx

[PATCH] lib: Prohibit parallel connections with tunneled migration

2020-01-21 Thread Jim Fehlig
As discussed on the developer list, parallel migration connections are not compatible with tunneled migration https://www.redhat.com/archives/libvir-list/2020-January/msg00463.html Prohibit the concurrent use of parallel and tunneled migration options. Signed-off-by: Jim Fehlig --- I added

Re: [libvirt] Question about parallel migration connections

2020-01-10 Thread Jim Fehlig
On 1/10/20 12:16 AM, Peter Krempa wrote: > On Thu, Jan 09, 2020 at 23:04:19 +0000, Jim Fehlig wrote: >> Are they supported with tunneled migration? The feature seems limited to >> native >> migration, in which case I can send a patch prohibiting parallel migration >>

Re: [libvirt] Question about parallel migration connections

2020-01-10 Thread Jim Fehlig
On 1/10/20 2:26 AM, Daniel P. Berrangé wrote: > On Thu, Jan 09, 2020 at 11:04:19PM +0000, Jim Fehlig wrote: >> Are they supported with tunneled migration? The feature seems limited to >> native >> migration, in which case I can send a patch prohibiting parallel migration &g

[libvirt] Question about parallel migration connections

2020-01-09 Thread Jim Fehlig
Are they supported with tunneled migration? The feature seems limited to native migration, in which case I can send a patch prohibiting parallel migration connections with the tunnel. Regards, Jim -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-

Re: [libvirt] Xen + libvirt + TPM

2020-01-06 Thread Jim Fehlig
You posted the same message on the libvirt-user list, which would have been sufficient for this query. For the record, it was answered there https://www.redhat.com/archives/libvirt-users/2020-January/msg3.html Regards, Jim On 12/30/19 8:30 AM, Arthur Borsboom wrote: > Hello, > > I am tryin

Re: [libvirt] [jenkins-ci PATCH] lcitool: Don't install yast2_base group on openSUSE

2019-12-12 Thread Jim Fehlig
index f8ec3df..ceb702d 100644 > --- a/guests/configs/autoinst.xml > +++ b/guests/configs/autoinst.xml > @@ -44,7 +44,6 @@ > > base > minimal_base > - yast2_basis > > > openssh > I suppose I could have sent this

Re: [libvirt] [jenkins-ci PATCH 1/5] guests: Add mapping for augeas-lenses

2019-12-12 Thread Jim Fehlig
On 12/12/19 9:19 AM, Andrea Bolognani wrote: > On Thu, 2019-12-12 at 15:57 +0000, Jim Fehlig wrote: >> On 12/12/19 8:07 AM, Andrea Bolognani wrote: >>> On Thu, 2019-12-12 at 15:43 +0100, Fabiano Fidêncio wrote: >>>> On Thu, Dec 12, 2019 at 3:31 PM Andrea Bolognani

Re: [libvirt] [jenkins-ci PATCH 0/5] lcitool: Make Dockerfile generation work on openSUSE

2019-12-12 Thread Jim Fehlig
On 12/12/19 8:31 AM, Andrea Bolognani wrote: > On Thu, 2019-12-12 at 15:45 +0100, Fabiano Fidêncio wrote: >> On Thu, Dec 12, 2019 at 3:31 PM Andrea Bolognani wrote: >>> Andrea Bolognani (5): >>>guests: Add mapping for augeas-lenses >>>guests: Install augeas-lenses for libvirt >>>lcitoo

Re: [libvirt] [jenkins-ci PATCH 1/5] guests: Add mapping for augeas-lenses

2019-12-12 Thread Jim Fehlig
On 12/12/19 8:07 AM, Andrea Bolognani wrote: > On Thu, 2019-12-12 at 15:43 +0100, Fabiano Fidêncio wrote: >> On Thu, Dec 12, 2019 at 3:31 PM Andrea Bolognani wrote: >>> + augeas-lenses: >>> +default: augeas >>> +deb: augeas-lenses >>> +OpenSUSE: augeas-lenses >> >> Hmm. I guess it onl

Re: [libvirt] [PATCH V3 jenkins-ci 2/2] guests: Add lci build support for openSUSE

2019-12-09 Thread Jim Fehlig
On 12/9/19 8:44 AM, Andrea Bolognani wrote: > On Mon, 2019-12-09 at 12:59 +0100, Andrea Bolognani wrote: >> On Fri, 2019-12-06 at 23:44 +0000, Jim Fehlig wrote: >>> guests: Add lci build support for openSUSE >> >> s/lci build/'lcitool build'/ >> >

Re: [libvirt] [PATCH V3 jenkins-ci 0/2] Add support for openSUSE

2019-12-06 Thread Jim Fehlig
On 12/6/19 4:44 PM, Jim Fehlig wrote: > Jim Fehlig (2): >guests: Add support for openSUSE >guests: Add lci build support for openSUSE I forgot to mention, 'lcitool update libvirt-opensuse-151 libvirt' still fails in the Configure hostname task TASK

[libvirt] [PATCH V3 jenkins-ci 1/2] guests: Add support for openSUSE

2019-12-06 Thread Jim Fehlig
This change adds support for installing and updating openSUSE Leap 15.1 using lcilool. Signed-off-by: Jim Fehlig --- guests/configs/autoinst.xml | 77 +++ .../host_vars/libvirt-opensuse-151/docker.yml | 2 + .../libvirt-opensuse-151/install.yml | 2

[libvirt] [PATCH V3 jenkins-ci 0/2] Add support for openSUSE

2019-12-06 Thread Jim Fehlig
Jim Fehlig (2): guests: Add support for openSUSE guests: Add lci build support for openSUSE guests/configs/autoinst.xml | 77 +++ .../host_vars/libvirt-opensuse-151/docker.yml | 2 + .../libvirt-opensuse-151/install.yml | 2 + .../host_vars

[libvirt] [PATCH V3 jenkins-ci 2/2] guests: Add lci build support for openSUSE

2019-12-06 Thread Jim Fehlig
Signed-off-by: Jim Fehlig --- guests/playbooks/build/jobs/defaults.yml| 1 + guests/playbooks/build/projects/libvirt.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/guests/playbooks/build/jobs/defaults.yml b/guests/playbooks/build/jobs/defaults.yml index 48cf643..43ab882 100644

Re: [libvirt] [PATCH] maint: Post-release version bump to 5.11.0

2019-12-03 Thread Jim Fehlig
On 12/3/19 1:35 AM, Peter Krempa wrote: > On Tue, Dec 03, 2019 at 04:24:59 +0000, Jim Fehlig wrote: >> Signed-off-by: Jim Fehlig >> --- >> >> Pushing under the trivial rule. >> >> configure.ac | 2 +- >> docs/news.xml | 8 >

[libvirt] [PATCH] maint: Post-release version bump to 5.11.0

2019-12-02 Thread Jim Fehlig
Signed-off-by: Jim Fehlig --- Pushing under the trivial rule. configure.ac | 2 +- docs/news.xml | 8 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index ef521e370c..d0ef7de750 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7

[libvirt] [PATCH] news: Fix XML validation

2019-12-02 Thread Jim Fehlig
o validate against schema: Unable to validate doc against /home/jfehlig/virt/upstream/libvirt/build/../docs/schemas/../news.rng Element release failed to validate attributes Signed-off-by: Jim Fehlig --- Pushing under the build-breaker rule. One could argue the schema could be relaxed, but let'

Re: [libvirt] [jenkins-ci] guests: Add support for openSUSE Leap 15.1

2019-11-25 Thread Jim Fehlig
On 11/19/19 6:52 AM, Fabiano Fidêncio wrote: > On Tue, Nov 19, 2019 at 11:33 AM Andrea Bolognani wrote: >> >> On Tue, 2019-11-19 at 00:21 +0000, Jim Fehlig wrote: >>> Signed-off-by: Jim Fehlig >>> --- >>> guests/configs/autoinst.xml

Re: [libvirt] [PATCH RFC V2 jenkins-ci] guests: Add support for openSUSE

2019-11-25 Thread Jim Fehlig
Grrr, I keep forgetting something within '--subject-prefix=' when sending these patches... On 11/25/19 5:50 PM, Jim Fehlig wrote: > This change adds support for the latest openSUSE Leap and > openSUSE Tumbleweed guests. > > Signed-off-by: Jim Fehlig > --- >

[libvirt] [PATCH RFC V2] guests: Add support for openSUSE

2019-11-25 Thread Jim Fehlig
This change adds support for the latest openSUSE Leap and openSUSE Tumbleweed guests. Signed-off-by: Jim Fehlig --- This version of the patch overcomes the 'lci build' issues noted in V1 and works well for openSUSE Leap 15.1 and Tumbleweed. I'm still of the opinion of only suppor

Re: [libvirt] [jenkins-ci] guests: Add support for openSUSE Leap 15.1

2019-11-20 Thread Jim Fehlig
On 11/20/19 2:16 PM, Fabiano Fidêncio wrote: > On Wed, Nov 20, 2019 at 8:44 PM Jim Fehlig wrote: >> >> On 11/19/19 11:56 PM, Fabiano Fidêncio wrote: >>> On Wed, Nov 20, 2019 at 12:01 AM Jim Fehlig wrote: >>>> >>>> On 11/19/19 3:32 AM, Andrea Bo

Re: [libvirt] [jenkins-ci] guests: Add support for openSUSE Leap 15.1

2019-11-20 Thread Jim Fehlig
On 11/20/19 1:03 AM, Andrea Bolognani wrote: > On Wed, 2019-11-20 at 07:56 +0100, Fabiano Fidêncio wrote: >> On Wed, Nov 20, 2019 at 12:01 AM Jim Fehlig wrote: >>> On 11/19/19 3:32 AM, Andrea Bolognani wrote: >>>> As for os_version, if you look at all existing

Re: [libvirt] [jenkins-ci] guests: Add support for openSUSE Leap 15.1

2019-11-20 Thread Jim Fehlig
On 11/19/19 11:56 PM, Fabiano Fidêncio wrote: > On Wed, Nov 20, 2019 at 12:01 AM Jim Fehlig wrote: >> >> On 11/19/19 3:32 AM, Andrea Bolognani wrote: >>> On Tue, 2019-11-19 at 00:21 +, Jim Fehlig wrote: [...] >>>> +++ b/guests/host_vars/libvirt-opensus

Re: [libvirt] [jenkins-ci] guests: Add support for openSUSE Leap 15.1

2019-11-19 Thread Jim Fehlig
On 11/19/19 6:52 AM, Fabiano Fidêncio wrote: > On Tue, Nov 19, 2019 at 11:33 AM Andrea Bolognani wrote: >> >> On Tue, 2019-11-19 at 00:21 +0000, Jim Fehlig wrote: >>> Signed-off-by: Jim Fehlig >>> --- >>> guests/configs/autoinst.xml

Re: [libvirt] [jenkins-ci] guests: Add support for openSUSE Leap 15.1

2019-11-19 Thread Jim Fehlig
On 11/19/19 3:32 AM, Andrea Bolognani wrote: > On Tue, 2019-11-19 at 00:21 +0000, Jim Fehlig wrote: >> Signed-off-by: Jim Fehlig >> --- >> guests/configs/autoinst.xml | 86 +++ >> .../libvirt-opensuse-15.1/docker.yml | 2

Re: [libvirt] [jenkins-ci] guests: Add support for openSUSE Leap 15.1

2019-11-18 Thread Jim Fehlig
On 11/18/19 5:21 PM, Jim Fehlig wrote: > Signed-off-by: Jim Fehlig > --- > guests/configs/autoinst.xml | 86 +++ > .../libvirt-opensuse-15.1/docker.yml | 2 + > .../libvirt-opensuse-15.1/install.yml | 2 + > .../host_var

[libvirt] [jenkins-ci] guests: Add support for openSUSE Leap 15.1

2019-11-18 Thread Jim Fehlig
Signed-off-by: Jim Fehlig --- guests/configs/autoinst.xml | 86 +++ .../libvirt-opensuse-15.1/docker.yml | 2 + .../libvirt-opensuse-15.1/install.yml | 2 + .../host_vars/libvirt-opensuse-15.1/main.yml | 22 + guests/inventory

Re: [libvirt] [PATCH v2 00/24] scripts: convert most perl scripts to python

2019-11-15 Thread Jim Fehlig
On 9/13/19 9:28 AM, Andrea Bolognani wrote: > On Fri, 2019-09-13 at 13:58 +0000, Jim Fehlig wrote: >> On 9/13/19 2:56 AM, Andrea Bolognani wrote: >>> Jim, does SLES 12 have >>> Python 3? >> >> Yes, python 3.4.6. And python 2.7.13. > > That's *ama

[libvirt] [PATCH] spec: Remove build-time list of edk2 firmwares

2019-11-14 Thread Jim Fehlig
Fedora now advertises supported firmwares via descriptor files. Since the upstream spec file assumes recent Fedora, remove the build-time list of firmwares, which can produce a warning after commit 75597f022a. Signed-off-by: Jim Fehlig --- libvirt.spec.in | 29 - 1

Re: [libvirt] [PATCH] qemu: Warn verbosely if using old loader:nvram pairs

2019-11-13 Thread Jim Fehlig
On 11/13/19 9:20 AM, Michal Privoznik wrote: > On 11/12/19 11:17 PM, Jim Fehlig wrote: >> On 11/11/19 9:42 AM, Michal Privoznik wrote: >>> There are two ways for specifying loader:nvram pairs: >>> >>>     1) --with-loader-nvram configure option >>>    

Re: [libvirt] [PATCH] qemu: Warn verbosely if using old loader:nvram pairs

2019-11-13 Thread Jim Fehlig
On 11/13/19 9:20 AM, Michal Privoznik wrote: > On 11/12/19 11:17 PM, Jim Fehlig wrote: >> On 11/11/19 9:42 AM, Michal Privoznik wrote: >>> There are two ways for specifying loader:nvram pairs: >>> >>>     1) --with-loader-nvram configure option >>>    

Re: [libvirt] [PATCH] qemu: Warn verbosely if using old loader:nvram pairs

2019-11-12 Thread Jim Fehlig
On 11/11/19 9:42 AM, Michal Privoznik wrote: > There are two ways for specifying loader:nvram pairs: > >1) --with-loader-nvram configure option >2) nvram variable in qemu.conf > > Since we have FW descriptors, using this old style is > discouraged, but not as strong as one would expect. P

Re: [libvirt] [PATCH] libxl: Fix lock manager lock ordering

2019-11-06 Thread Jim Fehlig
Does anyone have a few moments to review this patch? Thanks! Regards, Jim On 10/14/19 3:39 PM, Jim Fehlig wrote: > The ordering of lock manager locks in the libxl driver has a flaw that was > uncovered by a migration error path. In the perform phase of migration, the > source h

Re: [libvirt] [PATCH] docs: Fix attribute names in filesystem/driver example

2019-11-04 Thread Jim Fehlig
On 11/4/19 4:20 AM, Erik Skultety wrote: > On Fri, Nov 01, 2019 at 05:52:20PM +0000, Jim Fehlig wrote: >> Signed-off-by: Jim Fehlig >> --- > Reviewed-by: Erik Skultety Thanks. I pushed this but missed adding your RB. I need to tweak my workflow to prevent that... Regards, J

Re: [libvirt] [PATCH 6/9] conf: qemu: add virtio-fs fsdriver type

2019-11-01 Thread Jim Fehlig
On 11/1/19 6:16 AM, Ján Tomko wrote: > Introduce a new 'virtio-fs' driver type for filesystem. > > > After resolving my confusion* regarding the example and description of the filesystem/driver element, I think this change is logical and shouldn't require much bikeshedding :-). Although yo

[libvirt] [PATCH] docs: Fix attribute names in filesystem/driver example

2019-11-01 Thread Jim Fehlig
Signed-off-by: Jim Fehlig --- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 7619c88514..84257c1bb4 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -3847,7 +3847,7

Re: [libvirt] Entering freeze for libvirt 5.9.0

2019-10-31 Thread Jim Fehlig
On 10/30/19 2:58 PM, Daniel Veillard wrote: > On Mon, Oct 28, 2019 at 06:08:39PM +0100, Daniel Veillard wrote: > [...] >> Please give it a try, I will try to push RC2 on Wednesday, and based >> on feedback roll the release on Friday or during the week-end, > >Well, so far there haven't been an

[libvirt] [PATCH 1/2] docs: Fix version that introduced Xen support for ACPI firmware

2019-10-31 Thread Jim Fehlig
Xen support for specifying ACPI firmware path was introduced in the 5.9.0 dev cycle, not 5.8.0 as currently indicated by the docs. Signed-off-by: Jim Fehlig --- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs

[libvirt] [PATCH 2/2] news: Add entry for ACPI firmware support in Xen

2019-10-31 Thread Jim Fehlig
Signed-off-by: Jim Fehlig --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index c8d55e357b..79255de011 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -59,6 +59,15 @@ support should be available to pSeries guests

[libvirt] [PATCH 0/2] Doc fix and news entry for Xen ACPI support

2019-10-31 Thread Jim Fehlig
g I can do about the former, but the latter can be fixed with trivial patch 1. Patch 2 adds a news entry. Jim Fehlig (2): docs: Fix version that introduced Xen support for ACPI firmware news: Add entry for ACPI firmware support in Xen docs/formatdomain.html.in | 2 +- docs/news.xml

Re: [libvirt] [PATCH] Apparmor: Support Xen scripts in libexec

2019-10-18 Thread Jim Fehlig
On 10/18/19 8:31 AM, Andrea Bolognani wrote: > On Thu, 2019-10-17 at 03:41 +0000, Jim Fehlig wrote: >> Upstream Xen has traditionally installed various hotplug and >> utility scripts in /etc/xen/scripts/. openSUSE is slowly moving >> all distribution provided configuration f

[libvirt] [PATCH] Apparmor: Support Xen scripts in libexec

2019-10-16 Thread Jim Fehlig
/xen/scripts/. Adjust the libvirtd Apparmor profile to allow executing scripts from this location. Signed-off-by: Jim Fehlig --- If this is deemed too distro-specific I'm happy to maintain a downstream patch. src/security/apparmor/usr.sbin.libvirtd | 1 + 1 file changed, 1 insertion(+)

[libvirt] [PATCH] libxl: Fix lock manager lock ordering

2019-10-14 Thread Jim Fehlig
destination, which avoids reacquiring the lock if the send fails. Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c| 14 +++--- src/libxl/libxl_migration.c | 14 +- 2 files changed, 12 insertions(+), 16 deletions(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl

Re: [libvirt] Question about migration confirm phase

2019-10-14 Thread Jim Fehlig
On 10/14/19 2:18 AM, Jiri Denemark wrote: > On Fri, Oct 11, 2019 at 23:18:29 +0000, Jim Fehlig wrote: >> I've been investigating a lockd lock ordering bug in a migration error >> handling >> path in the libxl driver. In the perform phase, the src calls >> virDomai

[libvirt] Question about migration confirm phase

2019-10-11 Thread Jim Fehlig
I've been investigating a lockd lock ordering bug in a migration error handling path in the libxl driver. In the perform phase, the src calls virDomainLockProcessPause to release the lock before sending the VM to dst. In this case the send fails for other reasons and an attempt is made to reacqu

Re: [libvirt] [PATCH v2 2/3] tests: libxl: ACPI slic table test

2019-10-10 Thread Jim Fehlig
On 9/16/19 6:47 AM, Marek Marczykowski-Górecki wrote: > On Mon, Sep 16, 2019 at 12:23:35PM +0000, Jim Fehlig wrote: >> On 9/15/19 1:43 PM, Marek Marczykowski-Górecki wrote: >>> Signed-off-by: Marek Marczykowski-Górecki >>> --- >>>tests/libxlxml2domcon

Re: [libvirt] [PATCH] docs: document that C & Python are the preferred languages

2019-09-30 Thread Jim Fehlig
On 9/23/19 7:52 AM, Daniel P. Berrangé wrote: > On Thu, Sep 05, 2019 at 06:15:04PM +0100, Daniel P. Berrangé wrote: >> On Thu, Sep 05, 2019 at 12:30:27PM -0400, Laine Stump wrote: >>> (BTW, what does the removal of perl from libvirt say about continued >>> use of perl for libvirt-tck? There are a

Re: [libvirt] [PATCH v2 2/3] tests: libxl: ACPI slic table test

2019-09-16 Thread Jim Fehlig
On 9/15/19 1:43 PM, Marek Marczykowski-Górecki wrote: > Signed-off-by: Marek Marczykowski-Górecki > --- > tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json | 54 +- > tests/libxlxml2domconfigdata/fullvirt-acpi-slic.xml | 32 - > tests/libxlxml2domconfigtest.c

Re: [libvirt] [PATCH v2 00/24] scripts: convert most perl scripts to python

2019-09-13 Thread Jim Fehlig
On 9/13/19 9:28 AM, Andrea Bolognani wrote: > On Fri, 2019-09-13 at 13:58 +0000, Jim Fehlig wrote: >> On 9/13/19 2:56 AM, Andrea Bolognani wrote: >>> Jim, does SLES 12 have >>> Python 3? >> >> Yes, python 3.4.6. And python 2.7.13. > > That's *ama

Re: [libvirt] [PATCH v2 00/24] scripts: convert most perl scripts to python

2019-09-13 Thread Jim Fehlig
On 9/13/19 3:09 AM, Andrea Bolognani wrote: > If I understand the SLES / OpenSUSE situation correctly, then SLES > 12.3 should be comparable to OpenSUSE 42.3, Nice job! Even SUSE folks are known to get confused by the numbering :-). openSUSE 42.3 ~= SLES12 SP3 SLES12 SP4 and SP5 have no openSUSE

Re: [libvirt] [PATCH] apparmor: avoid copying empty profile name

2019-09-13 Thread Jim Fehlig
On 9/9/19 10:26 AM, Jim Fehlig wrote: > AppArmorGetSecurityProcessLabel copies the VM's profile name to the > label member of virSecurityLabel struct. If the profile is not loaded, > the name is set empty before calling virStrcpy to copy it. However, > virStrcpy will fail if src i

Re: [libvirt] [PATCH v2 00/24] scripts: convert most perl scripts to python

2019-09-13 Thread Jim Fehlig
On 9/13/19 2:56 AM, Andrea Bolognani wrote: > On Wed, 2019-09-11 at 17:23 +0100, Daniel P. Berrangé wrote: >> This series is an effort to reduce the number of different >> languages we use by eliminating most use of perl in favour >> of python. > > Just today I found out about > > > https://a

Re: [libvirt] [PATCH 1/2] libxl: add acpi slic table support

2019-09-11 Thread Jim Fehlig
On 9/11/19 10:33 AM, Marek Marczykowski-Górecki wrote: > On Wed, Sep 11, 2019 at 01:31:34PM +0000, Jim Fehlig wrote: >> On 9/11/19 5:43 AM, Marek Marczykowski-Górecki wrote: >>> On Wed, Sep 11, 2019 at 02:34:57AM +, Jim Fehlig wrote: >>>> On 9/10/19 5:24 PM, Mar

Re: [libvirt] [PATCH 1/2] libxl: add acpi slic table support

2019-09-11 Thread Jim Fehlig
On 9/11/19 5:43 AM, Marek Marczykowski-Górecki wrote: > On Wed, Sep 11, 2019 at 02:34:57AM +0000, Jim Fehlig wrote: >> On 9/10/19 5:24 PM, Marek Marczykowski-Górecki wrote: >>> On Tue, Sep 10, 2019 at 10:54:15PM +, Jim Fehlig wrote: >>>> On 9/6/19 8:31 PM, Mar

Re: [libvirt] [PATCH 1/2] libxl: add acpi slic table support

2019-09-10 Thread Jim Fehlig
On 9/10/19 5:24 PM, Marek Marczykowski-Górecki wrote: > On Tue, Sep 10, 2019 at 10:54:15PM +0000, Jim Fehlig wrote: >> On 9/6/19 8:31 PM, Marek Marczykowski-Górecki wrote: >>> From: Ivan Kardykov >>> >>> Libxl driver did not support setup additional a

Re: [libvirt] [PATCH 1/2] libxl: add acpi slic table support

2019-09-10 Thread Jim Fehlig
On 9/6/19 8:31 PM, Marek Marczykowski-Górecki wrote: > From: Ivan Kardykov > > Libxl driver did not support setup additional acpi firmware to xen > guest. It is necessary to activate OEM Windows installs. This patch > allow to define in OS section acpi table param (which supported domain > commo

<    1   2   3   4   5   6   7   8   9   10   >