Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Introduce use of a virDomainDefPtr in the domain lifecycle
APIs to simplify introduction of ACL security checks.
The virDomainPtr cannot be safely used, since the app
may have supplied mis-matching name/uuid/id fields. eg
Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Introduce use of a virDomainDefPtr in the domain property
APIs to simplify introduction of ACL security checks.
The virDomainPtr cannot be safely used, since the app
may have supplied mis-matching name/uuid/id fields. eg
Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Introduce use of a virDomainDefPtr in the domain save
APIs to simplify introduction of ACL security checks.
The virDomainPtr cannot be safely used, since the app
may have supplied mis-matching name/uuid/id fields. eg
the
Dario Faggioli wrote:
Hi Jim, everyone,
I'm having an issue using the libvirt's libxl driver while installing a
Fedora 18 (via netinstall) on both Fedora 18 or rawhide host.
So, what happens is, basically, that I do not see the output from the
installer at all, neither in the virt-viewer
Found that I was unable to start existing domains after updating
to a kernel with no cgroups support
# zgrep CGROUP /proc/config.gz
# CONFIG_CGROUPS is not set
# virsh start test
error: Failed to start domain test
error: Unable to initialize /machine cgroup: Cannot allocate memory
Daniel P. Berrange wrote:
On Fri, May 10, 2013 at 12:40:40PM -0600, Jim Fehlig wrote:
Found that I was unable to start existing domains after updating
to a kernel with no cgroups support
# zgrep CGROUP /proc/config.gz
# CONFIG_CGROUPS is not set
# virsh start test
error: Failed
Daniel P. Berrange wrote:
On Fri, May 10, 2013 at 01:13:20PM -0600, Jim Fehlig wrote:
From 63e878b287b98e418b65db46888c1f5d1a01d805 Mon Sep 17 00:00:00 2001
From: Jim Fehlig jfeh...@suse.com
Date: Fri, 10 May 2013 12:05:00 -0600
Subject: [PATCH] Fix starting domains when kernel has
libxl expects the event handler to free the event passed to it. From
libxl_event.h:
event becomes owned by the application and must be freed, either
by event_occurs or later
---
src/libxl/libxl_driver.c |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git
Xen 4.3 fixes a mistake in the libxl event handler signature where the
event owned by the application was defined as const. Detect this and
define the libvirt libxl event handler signature appropriately.
---
src/libxl/libxl_driver.c |7 ++-
1 files changed, 6 insertions(+), 1
Xen upstream commit 5fb11a07 fixed the signature of the event handler,
causing build failures of the libxl driver on xen-unstable / Xen 4.3.
While at it, plug leaking of libxl_event objects in the event handler.
Jim Fehlig (2):
libxl: fix build with Xen4.3
libxl: fix leaking libxl events
On 05/16/2013 01:56 PM, Eric Blake wrote:
On 05/16/2013 10:01 AM, Jim Fehlig wrote:
libxl expects the event handler to free the event passed to it. From
libxl_event.h:
event becomes owned by the application and must be freed, either
by event_occurs or later
---
src/libxl
I finally have some time to continue reviewing this series...
Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Introduce use of a virDomainDefPtr in the domain migrate
start APIs to simplify introduction of ACL security checks.
Not really the 'start' API, but
Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Introduce use of a virDomainDefPtr in the domain VCPU
APIs to simplify introduction of ACL security checks.
The virDomainPtr cannot be safely used, since the app
may have supplied mis-matching name/uuid/id fields. eg
the
Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Introduce use of a virDomainDefPtr in the domain hotplug
APIs to simplify introduction of ACL security checks.
The virDomainPtr cannot be safely used, since the app
may have supplied mis-matching name/uuid/id fields. eg
Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Introduce use of a virDomainDefPtr in the domain autostart
APIs to simplify introduction of ACL security checks.
The virDomainPtr cannot be safely used, since the app
may have supplied mis-matching name/uuid/id fields. eg
Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Introduce use of a virDomainDefPtr in the domain scheduler
APIs to simplify introduction of ACL security checks.
The virDomainPtr cannot be safely used, since the app
may have supplied mis-matching name/uuid/id fields. eg
Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Introduce use of a virDomainDefPtr in the domain stats
peek APIs to simplify introduction of ACL security checks.
The virDomainPtr cannot be safely used, since the app
may have supplied mis-matching name/uuid/id fields.
Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Introduce use of a virDomainDefPtr in the domain coredump
APIs to simplify introduction of ACL security checks.
The virDomainPtr cannot be safely used, since the app
may have supplied mis-matching name/uuid/id fields. eg
Jim Fehlig wrote:
Jim Fehlig wrote:
Laine Stump wrote:
On 04/10/2013 05:10 AM, Daniel P. Berrange wrote:
On Wed, Apr 10, 2013 at 04:44:43AM +0200, Marek Marczykowski wrote:
This can be useful for route or NAT networks, or any other
Jim Fehlig wrote:
Daniel P. Berrange wrote:
On Wed, Apr 10, 2013 at 04:44:43AM +0200, Marek Marczykowski wrote:
---
src/libxl/libxl_conf.c | 72
++
src/libxl/libxl_conf.h | 2 ++
2 files changed, 74 insertions
Marek Marczykowski wrote:
For now only for PCI devices. Mostly copy-paste from old xen driver.
This one is (or will be) covered by Chanyan's work as well right?
Regards,
Jim
---
src/libxl/libxl_driver.c | 193
+++
1 file changed, 193
Marek Marczykowski wrote:
On 19.04.2013 13:10, Stefano Stabellini wrote:
On Thu, 11 Apr 2013, Marek Marczykowski wrote:
On 11.04.2013 09:52, Ian Campbell wrote:
On Thu, 2013-04-11 at 05:09 +0100, Jim Fehlig wrote:
+/* This will fill xenstore info about free
Marek Marczykowski wrote:
At least Xen supports backend drivers in another domain (aka driver
domain). This patch introduces XML config option for such setting as
'domain' element with 'name' attribute. Verification its content is left
for the driver.
In the future some option will be needed
Marek Marczykowski wrote:
This implement handling of domain name=''/ parameter introduced in
previous patch.
Lookup on domain name (to get domain ID) requires libxlDriverPrivate
object, so it must be passed down to libxlMakeDisk and libxlMakeNet from
top level callers.
---
Marek Marczykowski wrote:
Vfb entries in domain config are used only by PV drivers. Qemu
parameters are build based on b_info struct. So fill it with the same
s/build/built/
data as vfb entries (actually the first one).
This will additionally allow graphic-less domain, when no graphics/
Marek Marczykowski wrote:
Xen have feature of having device model in separate domain (called stub
domain). It used to be enabled by special 'stubdom-dm' device model
path. Recent xl have separate config option for this feature
(device_model_stubdomain_override), but I'm not sure if it worth
Marek Marczykowski wrote:
While iterating with virDomainObjListForEach it is safe to remove
current element. But while iterating, 'doms' lock is already taken, so
can't use standard virDomainObjListRemove. So introduce
virDomainObjListRemoveLocked for this purpose.
This seems sane to me,
Marek Marczykowski wrote:
Use virDomainObjListRemoveLocked instead of virDomainObjListRemove, as
driver-domains is already taken by virDomainObjListForEach.
Above deadlock can be triggered when libvirtd is started after some
domain have been started by hand (in which case driver will not find
Marek Marczykowski wrote:
On 01.05.2013 16:11, Daniel P. Berrange wrote:
On Wed, May 01, 2013 at 02:44:11PM +0100, David Scott wrote:
On 01/05/13 09:46, Ian Campbell wrote:
I would suggest that libvirt+libxl expose the version as the emulator
option and not the path. Just
Marek Marczykowski wrote:
On 31.05.2013 10:25, Ian Campbell wrote:
On Thu, 2013-05-30 at 11:53 -0600, Jim Fehlig wrote:
Marek Marczykowski wrote:
On 01.05.2013 16:11, Daniel P. Berrange wrote:
On Wed, May 01, 2013 at 02:44:11PM +0100, David Scott wrote
Eric Blake wrote:
On 06/04/2013 08:43 AM, Jim Fehlig wrote:
Only install nwfilter example XML files when WITH_NWFILTER
is defined.
Does this require any corresponding libvirt.spec.in file changes?
I don't think so. I stumbled across this issue doing a client-only
package build
Eric Blake wrote:
On 06/05/2013 05:38 AM, Laine Stump wrote:
On 06/04/2013 07:02 PM, Eric Blake wrote:
On the other hand; WITH_NWFILTER controlls what libvirtd provides, not
what the client can do. Technically, even on a machine where the client
was built without nwfilter support,
Dario Faggioli wrote:
On gio, 2013-06-06 at 14:59 +0100, Ian Campbell wrote:
On Thu, 2013-06-06 at 15:53 +0200, Dario Faggioli wrote:
Hi Jim,
As I told you in Dublin, I'm looking into libvirt a bit, with the main
purpose of implementing the NUMA interface for the libxl driver.
This small series fixes some capatiblity issues in the libxl driver wrt
the legacy xen driver.
Jim Fehlig (2):
libxl: Report connect type as Xen
libxl: set bootloader for PV domains if not specified
src/libxl/libxl_conf.c | 13 +++--
src/libxl/libxl_conf.h |1 +
src/libxl
Currently, the libxl driver reports a connection type of xenlight.
To be compatible with the legacy Xen driver, it should return Xen.
Note: I noticed this while testing the libxl driver on OpenStack.
After switching my Xen compute nodes to use the libxl stack, I
could no longer launch instances
The legacy xen toolstack will set pygrub as the bootloader if not
specified. For compatibility, do the same in the libxl driver
iff not using direct kernel boot.
---
src/libxl/libxl_conf.c | 13 +++--
src/libxl/libxl_conf.h |1 +
2 files changed, 12 insertions(+), 2 deletions(-)
Michal Privoznik wrote:
On 10.06.2013 22:21, Jim Fehlig wrote:
Currently, the libxl driver reports a connection type of xenlight.
To be compatible with the legacy Xen driver, it should return Xen.
Note: I noticed this while testing the libxl driver on OpenStack.
After switching my Xen
Michal Privoznik wrote:
On 11.06.2013 16:12, Jim Fehlig wrote:
Michal Privoznik wrote:
On 10.06.2013 22:21, Jim Fehlig wrote:
Currently, the libxl driver reports a connection type of xenlight.
To be compatible with the legacy Xen driver, it should return Xen.
Note: I
Daniel Veillard wrote:
On Tue, Jun 11, 2013 at 10:27:37AM -0600, Jim Fehlig wrote:
Michal Privoznik wrote:
On 11.06.2013 16:12, Jim Fehlig wrote:
Michal Privoznik wrote:
On 10.06.2013 22:21, Jim Fehlig wrote:
Currently, the libxl
Daniel Veillard wrote:
On Tue, Jun 11, 2013 at 10:27:37AM -0600, Jim Fehlig wrote:
Michal Privoznik wrote:
On 11.06.2013 16:12, Jim Fehlig wrote:
Michal Privoznik wrote:
On 10.06.2013 22:21, Jim Fehlig wrote:
Currently, the libxl
virConnectGetSysinfo was never implemented in the legacy xen driver.
This patch provides an implementation based on the qemu driver.
---
src/xen/xen_driver.c | 37 -
1 files changed, 36 insertions(+), 1 deletions(-)
diff --git a/src/xen/xen_driver.c
virConnectGetSysinfo was never implemented in the libxl driver.
This patch provides an implementation based on the qemu driver.
---
src/libxl/libxl_conf.h |1 +
src/libxl/libxl_driver.c | 29 +
2 files changed, 30 insertions(+), 0 deletions(-)
diff --git
While discussing a recent libxl patch, we realized virConnectGetSysinfo was
never implemented in the libxl and legacy xen drivers. This small series
provides an implementation for these drivers.
Jim Fehlig (2):
libxl: Implement virConnectGetSysinfo
xen: Implement virConnectGetSysinfo
src
Marek Marczykowski-Górecki wrote:
Actually only those interface types are handled correctly so reject
others instead of ignoring settings (i.e. treating as bridge/ethernet
anyway).
Also allow script/ in 'ethernet' (which should be the only
script-allowing type). Keep script/ allowed in bridge
Frediano Ziglio wrote:
When creating a timer/event handler reference counting is used. So it could
be possible (in theory) that libxlDomainObjPrivateFree is called with
reference counting 1. The problem is that libxlDomainObjPrivateFree leave
the object in an invalid state with ctx freed (but
Marek Marczykowski-Górecki wrote:
libxl uses some xenstore entries for hints in memory management
(especially when starting new domain). This includes dom0 memory limit
and Xen free memory margin, based on current system state. Entries are
created at first function usage, so force such call at
Marek Marczykowski-Górecki wrote:
At least Xen supports backend drivers in another domain (aka driver
domain). This patch introduces XML config option for such setting as
'domain' element with 'name' attribute. Verification its content is left
for the driver.
In the future some option will
Marek Marczykowski-Górecki wrote:
This implement handling of domain name=''/ parameter introduced in
previous patch.
Lookup on domain name (to get domain ID) requires libxlDriverPrivate
object, so it must be passed down to libxlMakeDisk and libxlMakeNet from
top level callers.
Changes in
Marek Marczykowski-Górecki wrote:
Vfb entries in domain config are used only by PV drivers. Qemu
parameters are build based on b_info struct. So fill it with the same
data as vfb entries (actually the first one).
This will additionally allow graphic-less domain, when no graphics/
entries are
Marek Marczykowski-Górecki wrote:
libxl uses some xenstore entries for hints in memory management
(especially when starting new domain). This includes dom0 memory limit
and Xen free memory margin, based on current system state. Entries are
created at first function usage, so force such call at
Marek Marczykowski-Górecki wrote:
While iterating with virDomainObjListForEach it is safe to remove
current element. But while iterating, 'doms' lock is already taken, so
can't use standard virDomainObjListRemove. So introduce
virDomainObjListRemoveLocked for this purpose.
Changes in v2:
-
Marek Marczykowski-Górecki wrote:
Do not leave uninitialized variables, not all parameters are set in
libxlMake*.
Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com
---
src/libxl/libxl_conf.c | 8
1 file changed, 8 insertions(+)
diff --git
Jim Fehlig wrote:
Marek Marczykowski-Górecki wrote:
Do not leave uninitialized variables, not all parameters are set in
libxlMake*.
Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com
---
src/libxl/libxl_conf.c | 8
1 file changed, 8 insertions(+)
diff
libxl contains logic to determine an appropriate devid for new devices
that do not specify one in their configuration. For all device types
except NICs, the libxl driver allows libxl to determine devid. Do the
same for NICs.
---
src/libxl/libxl_conf.c |2 --
1 files changed, 0
Marek Marczykowski-Górecki wrote:
Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com
---
src/libxl/libxl_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index b2cff5b..8dec70b 100644
Commit 752596b5 broke the build with -Werror
qemu/qemu_hotplug.c: In function 'qemuDomainChangeGraphics':
qemu/qemu_hotplug.c:1980:39: error: declaration of 'listen' shadows a
global declaration [-Werror=shadow]
Fix with s/listen/newlisten/
---
Pushing under the build-breaker rule.
Marek Marczykowski-Górecki wrote:
Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com
---
src/libxl/libxl_driver.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index
Jiri Denemark wrote:
On Thu, Jun 20, 2013 at 11:47:18 -0600, Jim Fehlig wrote:
libxl contains logic to determine an appropriate devid for new devices
that do not specify one in their configuration. For all device types
except NICs, the libxl driver allows libxl to determine devid. Do
Jim Fehlig wrote:
While discussing a recent libxl patch, we realized virConnectGetSysinfo was
never implemented in the libxl and legacy xen drivers. This small series
provides an implementation for these drivers.
I'll need to update the version to 1.1.0, but otherwise any comment
Daniel P. Berrange wrote:
On Fri, Jun 21, 2013 at 10:40:31AM -0600, Jim Fehlig wrote:
Jim Fehlig wrote:
While discussing a recent libxl patch, we realized virConnectGetSysinfo was
never implemented in the libxl and legacy xen drivers. This small series
provides an implementation
Specifying an unsupported disk format with the tap driver resulted in
a less than helpful error message
error: Failed to start domain test-hvm
error: internal error libxenlight does not support disk driver qed
Change the message to state that the qed format is not supported by
the tap driver,
libxl supports the LIBXL_DISK_BACKEND_QDISK disk backend, where qemu
is used to provide the disk backend. This patch simply maps the
existing driver name='qemu'/ to LIBXL_DISK_BACKEND_QDISK.
---
src/libxl/libxl_conf.c | 25 +
1 files changed, 25 insertions(+), 0
a slightly misleading error was
emitted when the tap backend didn't support the requested disk format. Fix
this with the first patch, including adding format checks in the other
supported disk backends.
V2: Fix logic errors when validating disk format
Jim Fehlig (2):
libxl: Fix disk format error
varun bhatnagar wrote:
Thank you so much for the reply... :)
I am trying to build this on OpenSUSE-11.4.
That is a very old openSUSE release that reached end of life long ago.
And you said that I can get distro provided packages. I just want to
ask whether installing those packages will
Daniel P. Berrange wrote:
On Fri, Jun 21, 2013 at 02:32:50PM -0600, Jim Fehlig wrote:
libxl supports the LIBXL_DISK_BACKEND_QDISK disk backend, where qemu
is used to provide the disk backend. This patch simply maps the
existing driver name='qemu'/ to LIBXL_DISK_BACKEND_QDISK.
---
src
Ján Tomko wrote:
Since we already have the v1.1.0-rc1 tag in git.
[...]
diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index a311d78..9f52394 100644
--- a/src/libxl/libxl_driver.c
+++ b/src/libxl/libxl_driver.c
@@ -4625,7 +4625,7 @@ static virDriver libxlDriver = {
Peter Krempa wrote:
Not every timer model is supported with each hypervisor. Explicitly
mention the driver supporting each timer model.
---
docs/formatdomain.html.in | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/docs/formatdomain.html.in
Paolo Bonzini wrote:
Il 25/06/2013 17:26, Jim Fehlig ha scritto:
-being modified, and can be one of platform, hpet,
-kvmclock, pit, rtc, or tsc.
+being modified, and can be one of
+platform (currently unsupported),
Platform
On 06/28/2013 08:32 AM, Dario Faggioli wrote:
Hi Jim, Everyone,
First patch series, so maybe a small introduction is required: I'm Dario and I
work for Citrix on improving the NUMA support of Xen.
Welcome Dario!
This patch series implements some of the missing bits and pieces, in the libxl
On 06/28/2013 08:32 AM, Dario Faggioli wrote:
Starting from Xen 4.2, libxl has all the bits and pieces are in
s/are in/in/
place for retrieving an adequate amount of information about the
host NUMA topology. It is therefore possible, after a bit of
shuffling, to arrange those information in
On 06/28/2013 08:32 AM, Dario Faggioli wrote:
domainGetNumaParameters has a string typed parameter, hence it
is necessary for the libxl driver to support this.
This change implements the connectSupportsFeature hook for the
libxl driver, advertising that VIR_DRV_FEATURE_TYPED_PARAM_STRING
is
On 06/28/2013 08:32 AM, Dario Faggioli wrote:
By providing the implementation of nodeGetCellsFreeMemory for
the driver. This is all just a matter of properly formatting, in
a way that libvirt like, what Xen provides via libxl_get_numainfo().
[raistlin@Zhaman ~]$ sudo virsh --connect xen:///
On 06/28/2013 08:33 AM, Dario Faggioli wrote:
Although, having it depending on Xen = 4.3 (by using the proper
libxl feature flag).
Xen currently implements a NUMA placement policy which is basically
the same as the 'interleaved' policy of `numactl', although it can
be applied on a subset of the
On 07/02/2013 02:22 PM, Jim Fehlig wrote:
On 06/28/2013 08:33 AM, Dario Faggioli wrote:
Although, having it depending on Xen = 4.3 (by using the proper
libxl feature flag).
Xen currently implements a NUMA placement policy which is basically
the same as the 'interleaved' policy of `numactl
On 06/20/2013 10:24 AM, Marek Marczykowski-Górecki wrote:
On 20.06.2013 17:34, Jim Fehlig wrote:
Marek Marczykowski-Górecki wrote:
While iterating with virDomainObjListForEach it is safe to remove
current element. But while iterating, 'doms' lock is already taken, so
can't use standard
On 06/12/2013 07:54 PM, Marek Marczykowski-Górecki wrote:
Use virDomainObjListRemoveLocked instead of virDomainObjListRemove, as
driver-domains is already taken by virDomainObjListForEach.
Above deadlock can be triggered when libvirtd is started after some
domain have been started by hand (in
On 06/12/2013 07:54 PM, Marek Marczykowski-Górecki wrote:
Both live and config.
Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com
---
src/libxl/libxl_driver.c | 164 ++-
1 file changed, 161 insertions(+), 3 deletions(-)
On 06/12/2013 07:54 PM, Marek Marczykowski-Górecki wrote:
Do not silently ignore its value.
Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com
---
src/libxl/libxl_conf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/libxl/libxl_conf.c
On 06/12/2013 07:54 PM, Marek Marczykowski-Górecki wrote:
Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com
---
src/libxl/libxl_conf.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
Dario Faggioli wrote:
Starting from Xen 4.2, libxl has all the bits and pieces in place
for retrieving an adequate amount of information about the host
NUMA topology. It is therefore possible, after a bit of shuffling,
to arrange those information in the way libvirt wants to present
them to
Dario Faggioli wrote:
On lun, 2013-07-08 at 18:45 -0600, Jim Fehlig wrote:
Dario Faggioli wrote:
diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index e170357..7515995 100644
--- a/src/libxl/libxl_conf.c
+++ b/src/libxl/libxl_conf.c
@@ -161,6 +161,115
Dario Faggioli wrote:
Starting from Xen 4.2, libxl has all the bits and pieces in place
for retrieving an adequate amount of information about the host
NUMA topology. It is therefore possible, after a bit of shuffling,
to arrange those information in the way libvirt wants to present
them to
Hi All,
I was recently asked about the possibility of libvirt creating a config
file and then invoking qemu with '-readconfig file' instead of passing
all arguments on the command line. The primary reason for this request
is a more readable ps output and the ability to inspect the arguments in
a
On 07/04/2013 05:58 AM, Bamvor Jian Zhang wrote:
this patch introduce the console api in libxl driver for both pv and
hvm guest. and import and update the libxlMakeChrdevStr function
which was deleted in commit dfa1e1dd.
Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com
---
Stefan Bader wrote:
I tried to follow previous changes. This worked for me using Xen-4.3
and the xm stack (I know rather deprecated but as long as one can get
it working, still).
Agreed, we should keep the legacy driver working with the latest Xen
release until its dependencies (xm/xend)
Daniel P. Berrange wrote:
On Sat, Jul 13, 2013 at 02:27:10AM +0200, Dario Faggioli wrote:
domainGetNumaParameters has a string typed parameter, hence it
is necessary for the libxl driver to support this.
This change implements the connectSupportsFeature hook for the
libxl driver,
Stefan Bader wrote:
On 17.07.2013 18:42, Jim Fehlig wrote:
All of the existing logic uses decimal for the interface version
numbers. I've changed all uses of hex to decimal, added the commits
that bumped the versions, and pushed the patch.
Thanks, yes I was struggling myself a bit
Bamvor Jian Zhang wrote:
Hi, Jim
thanks your reply. one comment below.
已写入 Jim Fehlig jfeh...@suse.com On 07/04/2013 05:58 AM, Bamvor Jian
Zhang wrote:
BTW, do all of these types work with Xen? I've only tested with type 'pty',
which works fine with both pv and hvm guests
Richard,
I think you should have cc'd the bug assignee when discussing this issue
upstream. Adding him now...
Regards,
Jim
Daniel P. Berrange wrote:
On Wed, Jul 17, 2013 at 11:33:22PM +0200, Richard Weinberger wrote:
Am 12.07.2013 03:36, schrieb Gao feng:
On 07/11/2013 07:58 PM,
Daniel P. Berrange wrote:
On Thu, Jul 18, 2013 at 08:14:17PM +0800, Bamvor Jian Zhang wrote:
this patch introduce the console api in libxl driver for both pv and
hvm guest. and import and update the libxlMakeChrdevStr function
which was deleted in commit dfa1e1dd.
Signed-off-by: Bamvor
Bamvor Jian Zhang wrote:
Hi, Denial
thanks your reply.
Daniel P. Berrange 2013-7-19 下午 23:53
On Fri, Jul 19, 2013 at 11:48:56PM +0800, Bamvor Jian Zhang wrote:
this patch introduce the console api in libxl driver for both pv and
hvm guest. and import and update the
One comment below in addition to Konrad's...
Konrad Rzeszutek Wilk wrote:
On Mon, Jul 22, 2013 at 12:51:05PM +0200, Stefan Bader wrote:
This fixes the basic setup but there is likely more to do if things
like manual CPU hirarchy (nodes, cores, threads) to be working.
Cross-posting to
Stefan Bader wrote:
On 23.07.2013 23:20, Jim Fehlig wrote:
[...]
You are using the driver-wide libxl_ctx in libxlDriverPrivate here, but
should be using the per-domain libxl_ctx in libxlDomainObjPrivate
structure IMO.
It looks like libxlBuildDomainConfig, which calls
Bamvor Jian Zhang wrote:
this patch introduce the console api in libxl driver for both pv and
hvm guest. and import and update the libxlMakeChrdevStr function
which was deleted in commit dfa1e1dd.
Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com
---
Changes since V3:
implicity forbit
Noticed that the expected not supported error is dropped when
invoking 'virsh snapshot-list dom' on a Xen installation running
the libxl driver
virsh snapshot-list test
error: Invalid snapshot: virDomainSnapshotFree
The error is overwritten by a call to virDomainSnapshotFree
in cleanup code
Eric Blake wrote:
On 07/25/2013 02:38 PM, Jim Fehlig wrote:
Noticed that the expected not supported error is dropped when
invoking 'virsh snapshot-list dom' on a Xen installation running
the libxl driver
virsh snapshot-list test
error: Invalid snapshot: virDomainSnapshotFree
Daniel P. Berrange wrote:
On Thu, Jul 25, 2013 at 12:07:44PM +0200, David Weber wrote:
SUSE advises to use indirect leases which we also want to avoid:
https://www.suse.com/documentation//sled11/book_kvm/?page=/documentation//sled11/book_kvm/data/sec_libvirt_storage_locking.html
Bamvor Jian Zhang wrote:
this patch introduce the console api in libxl driver for both pv and
hvm guest. and import and update the libxlMakeChrdevStr function
which was deleted in commit dfa1e1dd.
ACK, looks good to me now. Unless there are other review comments, I'll
commit this once
On 07/26/2013 10:46 AM, Jim Fehlig wrote:
Bamvor Jian Zhang wrote:
this patch introduce the console api in libxl driver for both pv and
hvm guest. and import and update the libxlMakeChrdevStr function
which was deleted in commit dfa1e1dd.
ACK, looks good to me now. Unless there are other
Stefan Bader wrote:
Beside dumpxml still being broken with the xen driver (hint [1] ;) )
Hmm, not sure how I overlooked that, sorry. My day is nearing a close,
so might not get to it until tomorrow.
there is also a quite annoying problem of creating new definitions
now failing. Using
101 - 200 of 2960 matches
Mail list logo
