reaching the m4 knowledge barrier. Before
attempting to bypass that, I'd like to see what others think of this
approach. Is there a simpler solution?
Regards,
Jim
>From 29a4c10dabb4cc1fd0585f404759a99c538a26c1 Mon Sep 17 00:00:00 2001
From: Jim Fehlig
Date: Tue, 27 May 2014 21:31:36
Eric Blake wrote:
> On 05/27/2014 10:05 PM, Jim Fehlig wrote:
>
>> The attached patch is an attempt to fix recent build failures I've
>> noticed with libselinux 2.3
>>
>> CC securityselinuxhelper.lo
>> securityselinuxhelper.c:159:5: error: c
Alvin Starr wrote:
Adding to Eric's comments...
> I have been trying do some simulations of an openstack environment on
> my workstation that is running xen and libvirt.
> I managed to create nested HVM environments under lx but found a
> number of shortfalls in libxl code.
Just to clarify termi
Alvin Starr wrote:
> On 05/28/2014 02:04 AM, Jim Fehlig wrote:
>> Alvin Starr wrote:
>>
>> Adding to Eric's comments...
>>
>>> I have been trying do some simulations of an openstack environment on
>>> my workstation that is running xen and libvir
Cédric Bosdonnat wrote:
> Several function signatures changed in libselinux 2.3, now taking
> a 'const char *' instead of 'security_context_t'. The latter is
> defined in selinux/selinux.h as
>
> typedef char *security_context_t;
> ---
> m4/virt-selinux.m4| 18 ++
>
Commit 292d3f2d fixed the build with libselinux 2.3, but missed
some suggestions by eblake
https://www.redhat.com/archives/libvir-list/2014-May/msg00977.html
This patch changes the macro introduced in 292d3f2d to either be
empty in the case of newer libselinux, or contain 'const' in the
case of o
Eric Blake wrote:
> My attempts to tweak this weren't panning out quickly enough, and yours
> definitely fixes a build-breaker, while still working for me with
> libselinux 2.2. Thanks for stepping in and helping :)
>
I managed to get your idea working and sent a cleanup patch.
Regards,
Jim
Eric Blake wrote:
> On 05/28/2014 01:54 PM, Jim Fehlig wrote:
>
>> Commit 292d3f2d fixed the build with libselinux 2.3, but missed
>> some suggestions by eblake
>>
>> https://www.redhat.com/archives/libvir-list/2014-May/msg00977.html
>>
>> This patch c
k
> * minimum need patch to avoid hang with qemu 2.0
> * remaining patches should rebase on top of pkrempa, even if it
> misses release
>* vbox snapshot patches - been waiting a long time
>* Jim Fehlig has libxl migration patches - probably desired for the
>
deepanshus wrote:
> Hi,
>
> I have successfully installed xen 3.11 kernel but when I am running
> the vm I am getting this error:
What version of Xen? Your problem appears to be more tools or packaging
related, not the kernel.
>
>
> libvirt: Xen Driver error : Domain not found: xenGetDomai
Stefan Bader wrote:
> This is a bit debatable. On one side it hides configuration errors
> in a way that makes them hard to spot. On the other side there is
> at least one issue with (maybe some older versions) virt-manager.
> Virt-manager sets VRAM directly, not using the default memory setting
>
Hi Stefan,
Thanks for the patches, sorry for the delay...
Stefan Bader wrote:
> This started as an investigation into an issue where libvirt (using the
> libxl driver) and the Xen host, like an old couple, could not agree on
> who is responsible for selecting the VNC port to use.
>
> Things usual
Olaf Hering wrote:
> Translate libvirt discard settings into libxl-4.5 discard settings.
>
> Signed-off-by: Olaf Hering
> ---
>
> default means leave decision to libxl.
> Not sure if that is what "default" in libvirt terms really means.
>
It generally means hypervisor default, so deferring to
Olaf Hering wrote:
> Up to now xend and libxl did not have any way and need to specify a cache=
> mode for block devices. At least the libxl driver did just ignore the
> cachemode value.
>
Even though cache mode was ignored before, should we now error on
unsupported values?
> With xen-4.5 a ne
Daniel P. Berrange wrote:
> To make it easier to unit test, change libxlBuildDomainConfig
> so that it takes 'virDomainDefPtr' and 'libxl_ctx *' objects
> as separate parameters.
>
> Signed-off-by: Daniel P. Berrange
> ---
> src/libxl/libxl_conf.c | 19 +--
> src/libxl/libxl_con
Daniel P. Berrange wrote:
> To make it easier to test, change libxlBuildDomainConfig so
> that it takes a virPortAllocatorPtr instead of the larger
> libxlDriverPrivatePtr object.
>
> Signed-off-by: Daniel P. Berrange
> ---
> src/libxl/libxl_conf.c | 12 ++--
> src/libxl/libxl_conf.h
Daniel P. Berrange wrote:
> To allow the test suite to creat the XML option object,
> move the virDomainXMLOptionNew call into a libxlCreateXMLConf
> method.
>
> Signed-off-by: Daniel P. Berrange
> ---
> src/libxl/libxl_conf.c | 7 +++
> src/libxl/libxl_conf.h | 2 ++
> src/libxl/libxl_do
Daniel P. Berrange wrote:
> On Mon, Jun 02, 2014 at 01:53:46PM +0100, Ian Campbell wrote:
>
>> On Fri, 2014-05-30 at 18:24 +0100, Daniel P. Berrange wrote:
>>
>>> +if (STRNEQ(expectargv, (char *)actualargv)) {
>>> +virtTestDifference(stderr, expectargv, (char *)actualargv);
>>>
Daniel P. Berrange wrote:
> On Mon, Jun 02, 2014 at 01:41:58PM +0100, Ian Campbell wrote:
>
>>>I hacked around this, but it is a little dirty too. libvirt
>>>already links to libyajl for the QEMU driver, but we don't
>>>really need the raw YAJL objects. It'd be nice to have a
>>>
>>
Daniel P. Berrange wrote:
> Comparing JSON docs using strcmp is simple, but is not flexible
> as it is sensitive to whitespace used in the doc generation.
> When comparing objects it may also be desirable to treat the
> existance of keys in the actual object but not expected object
> as non-fatal.
Daniel P. Berrange wrote:
> Test suites using the port allocator don't want to have different
> behaviour depending on whether a port is in use on the host. Add
> a VIR_PORT_ALLOCATOR_SKIP_BIND_CHECK which test suites can use
> to skip the bind() test. The port allocator will thus only track
> port
Daniel P. Berrange wrote:
> Rename the VIR_MOCK_IMPL* macros to VIR_MOCK_WRAP*
> and add new VIR_MOCK_IMPL macros which let you directly
> implement overrides in the preloaded source.
>
> Signed-off-by: Daniel P. Berrange
> ---
> tests/virfirewalltest.c | 4 ++--
> tests/virmock.h | 54
Daniel P. Berrange wrote:
> The libxl library allows a libxl_domain_config object to be
> serialized to a JSON string. Use this to allow testing of
> the XML -> libxl_domain_config conversion process
>
> Signed-off-by: Daniel P. Berrange
> ---
> configure.ac | 2 +
> tes
Vikas Kokare wrote:
> I am trying to establish a connection (using virsh command) to a
> couple of hypervisor hosts, both on SLES 11.3 environments. The host
> from where i am making both the connections is a SLES 10.4 instance.
Hi Vikas,
FYI, this list is for discussing upstream libvirt developm
Introduce a simple libxlDomainDefCheckABIStability() function that
can be used check ABI stability between two virDomainDef objects.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_domain.c | 23 +++
src/libxl/libxl_domain.h | 5 +
2 files changed, 28 insertions(+)
diff
V7 here
https://www.redhat.com/archives/libvir-list/2014-May/msg00301.html
In V8:
- Set freed resources to NULL/0.
- Add libxlDomainDefCheckABIStability() function to do simple
ABI stability checks of two virDomainDef objects.
Jim Fehlig (2):
libxl: introduce
This patch adds initial migration support to the libxl driver,
using the VIR_DRV_FEATURE_MIGRATION_PARAMS family of migration
functions.
Signed-off-by: Jim Fehlig
---
po/POTFILES.in | 1 +
src/Makefile.am | 3 +-
src/libxl/libxl_conf.h | 6 +
src/libxl
Daniel P. Berrange wrote:
> On Thu, May 08, 2014 at 03:56:51PM -0600, Jim Fehlig wrote:
>
>> This patch adds initial migration support to the libxl driver,
>> using the VIR_DRV_FEATURE_MIGRATION_PARAMS family of migration
>> functions.
>>
>> Signed-off-
Daniel P. Berrange wrote:
> On Wed, Jun 04, 2014 at 02:35:14PM -0600, Jim Fehlig wrote:
>
>> This patch adds initial migration support to the libxl driver,
>> using the VIR_DRV_FEATURE_MIGRATION_PARAMS family of migration
>> functions.
>>
>> Signed-off-by: J
Add support for in the libxl driver.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_conf.c | 41 +++--
1 file changed, 39 insertions(+), 2 deletions(-)
diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index cec37d6..6efcea6 100644
--- a/src/libxl
Jim Fehlig wrote:
> Add support for in the libxl driver.
>
> Signed-off-by: Jim Fehlig
> ---
> src/libxl/libxl_conf.c | 41 +++--
> 1 file changed, 39 insertions(+), 2 deletions(-)
>
> diff --git a/src/libxl/libxl_conf.c b/src/li
Eric Blake wrote:
> Jim Fehlig reported a regression found by libvirt-TCK tests:
>
>
>> ~ # perl /usr/share/libvirt-tck/tests/qemu/100-disk-encryption.t
>>
> ...
>
>> ok 4 - defined persistent domain config
>> # Starting inactive domain config
>
Generally, ...
Patch 1 is a V2 of
http://www.redhat.com/archives/libvir-list/2014-June/msg00382.html
Patch 2 is a result of Laine's comments to V1. It ensures
Add support for in the libxl driver.
Signed-off-by: Jim Fehlig
---
V2:
Support both libvirt's traditional managed networks and libvirt
networks that use an existing host bridge.
src/libxl/libxl_conf.c | 51 +++---
1 file changed, 48 inser
Laine Stump wrote:
> On 06/07/2014 12:30 AM, Jim Fehlig wrote:
>
>> Add support for in the libxl driver.
>>
>> Signed-off-by: Jim Fehlig
>> ---
>> src/libxl/libxl_conf.c | 41 +++--
>> 1 file changed, 39 insertions
John Ferlan wrote:
> Resolve two Coverity issues introduced by commit id '9b8d6e1e'
>
> Signed-off-by: John Ferlan
> ---
> src/libxl/libxl_migration.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/src/libxl/libxl_migration.c b/src/libxl/libxl_migration.c
> index 9
responding to your patch to fix the
warnings. Does that patch fix all the issues noted below?
Regards,
Jim
> John
>
> On 06/04/2014 04:35 PM, Jim Fehlig wrote:
>
>> This patch adds initial migration support to the libxl driver,
>> using the VIR_DRV_FEATURE_MIGRATI
s
originally based on qemu.
The below patch works for me. Can you give it a try? I'd like to hear wha
others think about taking the easy way out with option 2.
Regards,
Jim
>From 92c476cbe47009c43ebb4a3076a17347c8eea238 Mon Sep 17 00:00:00 2001
From: Jim Fehlig
Date: Thu, 12 Jun 2014
I've been having problems lately with an internal MTA connecting to an
external one that apparently serves the libvirt list. E.g. I recently
responded to "[PATCH v2 4/4] libxl: Add a test suite for libxl option
generator", which includes the xen-devel list. The response made it to
xen-devel, but
Ian Campbell wrote:
> On Mon, 2014-06-16 at 17:11 -0600, Jim Fehlig wrote:
>
>>> This function exists in Xen 4.2 as well, in libxl.h.
>>>
>>>
>> Any ideas on how to handle this? I'm not aware of an existing macro to
>> check for
Eric Blake wrote:
> On 06/17/2014 09:24 AM, Ian Campbell wrote:
>
>> In addition to extra= xm supported a root= option which was supposed
>> to be incorporated into the final command line. Handle that for "virsh
>> domxml-from-native xen-xm". Tested with the libxl backend.
>>
>> Signed-off-by: I
Ian Campbell wrote:
> On Tue, 2014-06-17 at 16:24 +0100, Ian Campbell wrote:
>
>> +if (xenXMConfigGetString(conf, "extra", &extra, NULL) < 0)
>>
>
> This was subtly broken. The default needs to be "".
>
> -8<--
>
> >From 539412a6deac8b928c82945d692ef20a49535d65 Mon Sep 17 00
Jim Fehlig wrote:
> Patch 1 is a V2 of
>
> http://www.redhat.com/archives/libvir-list/2014-June/msg00382.html
>
> Patch 2 is a result of Laine's comments to V1. It ensures
Commit ac63014c introduced a regression in the conversion of Xen
xm config to XML by emitting an empty . Prior to this
commit, was omitted if the xm config was missing (or
contained an empty) 'extra='.
Signed-off-by: Jim Fehlig
---
Pushing under the build breaker rule.
src/xenx
Eric Blake wrote:
> On 06/18/2014 11:46 AM, Jim Fehlig wrote:
>
>
>>> In addition to extra= xm supported a root= option which was supposed
>>> to be incorporated into the final command line. Handle that for "virsh
>>> domxml-from-native xen-xm". Tes
Ian Campbell wrote:
> On Tue, 2014-06-17 at 16:24 +0100, Ian Campbell wrote:
>
>> +if (xenXMConfigGetString(conf, "extra", &extra, NULL) < 0)
>>
>
> This was subtly broken. The default needs to be "".
>
Turns out, it wasn't :). Prior to this patch, def->os.cmdline was set
to NU
Laine Stump wrote:
> On 06/11/2014 12:25 AM, Jim Fehlig wrote:
>
>> Add support for in the libxl driver.
>>
>> Signed-off-by: Jim Fehlig
>> ---
>>
>> V2:
>> Support both libvirt's traditional managed networks and libvirt
>>
Jason Andryuk wrote:
> Migration code specifies the problematic non-cooperative resume mode
> which is a known issue with Xen's libxl [1]. Instead, use the better
> supported cooperative mode.
>
> Without this, guests BUG() in xen_irq_resume after failing to bind
> still-bound event channels.
>
>
In addition, tap performs poorly compared to qdisk.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index fdbb522..4b6b5c0 100644
--- a/src/libxl
Stefano Stabellini wrote:
> On Fri, 20 Jun 2014, Jim Fehlig wrote:
>
>> The libxl driver currently sets the disk backend to
>> LIBXL_DISK_BACKEND_TAP when is specified
>> in the config. qdisk should be prefered with this
>> configuration, otherwise exis
Commit 9b8d6e1e missed updating the libvirt version which
introduced support for domainMigrate*3Params functions.
Signed-off-by: Jim Fehlig
---
This patch only changes the comments describing when these functions
were introduced. Pushing under the trivial rule.
src/libxl/libxl_driver.c | 10
Ian Campbell wrote:
> On Fri, 2014-06-20 at 15:07 -0600, Jim Fehlig wrote:
>
>> The libxl driver currently sets the disk backend to
>> LIBXL_DISK_BACKEND_TAP when is specified
>> in the config. qdisk should be prefered with this
>> configuration, otherwise exis
Jim Fehlig wrote:
> Ian Campbell wrote:
>
>> Jim,
>>
>> What would be the right thing to do for this? The intention is for
>> osstest to skip migration tests when that feature is unimplemented by
>> the toolstack/xen/arch combination.
>>
>>
Ian Campbell wrote:
> On Tue, 2014-06-24 at 21:18 -0600, Jim Fehlig wrote:
>
>
>> Something like the attached patch (compile-tested only). You'll need an
>> updated libvirt.git master to apply cleanly.
>>
>
> Thanks. Building on ARM I get:
http://lists.xen.org/archives/html/xen-devel/2014-06/msg02171.html
Signed-off-by: Jim Fehlig
---
Derived from a test patch I sent to Ian Campbell
http://lists.xen.org/archives/html/xen-devel/2014-06/msg03150.html
Includes fixups Ian provided later in the thread.
src/libxl/libxl_conf.c | 4
src/
Ian Campbell wrote:
> On Wed, 2014-06-25 at 09:25 -0600, Jim Fehlig wrote:
>
>> With the fixup, does this work for you? Is omitted
>> from the capabilities?
>>
>
> Yes, it is omitted. On ARM:
&g
http://lists.xen.org/archives/html/xen-devel/2014-06/msg02171.html
Signed-off-by: Jim Fehlig
---
Another option for
https://www.redhat.com/archives/libvir-list/2014-June/msg01276.html
With this one, we even avoid the distasteful double negative :).
Compile-tested on x86 only at this point. The ARM bui
Eric Blake wrote:
> On 06/25/2014 12:13 PM, Jim Fehlig wrote:
>
>> libxl does not support save, restore, or migrate on all architectures,
>> notably ARM. Detect whether libxl supports these operations using
>> LIBXL_HAVE_NO_SUSPEND_RESUME. If not supporte
Eric Blake wrote:
> On 06/25/2014 06:09 PM, Jim Fehlig wrote:
>
>> libxl does not support save, restore, or migrate on all architectures,
>> notably ARM. Detect whether libxl supports these operations using
>> LIBXL_HAVE_NO_SUSPEND_RESUME. If not supporte
after upgrading a xm/xend stack to xl/libxl.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_domain.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index da3f241..0c86601 100644
--- a/src/libxl/libxl_domain.c
Dario Faggioli wrote:
> On lun, 2014-06-30 at 08:11 +0100, Ian Campbell wrote:
>
>> On Sun, 2014-06-29 at 18:35 +0100, xen.org wrote:
>>
>>> branch xen-unstable
>>> xen branch xen-unstable
>>> job build-i386-libvirt
>>> test libvirt-build
>>>
>>> Tree: gnulib_libvirt
>>> git://drall.uk.xen
Would it be fine to
push this? It fixes a libxl driver build failure against xen-unstable.
Regards,
Jim
> Signed-off-by: Dario Faggioli
> Cc: Jim Fehlig
> Cc: Ian Campbell
> Cc: Ian Jackson
> ---
> src/libxl/libxl_conf.h | 11 +++
> 1 file changed, 11 insertions
Eric Blake wrote:
> On 06/30/2014 03:11 PM, Jim Fehlig wrote:
>
>> Dario Faggioli wrote:
>>
>>> libxl interface for vcpu pinning is changing in Xen 4.5. Basically,
>>> libxl_set_vcpuaffinity() now wants one more parameter. That is
>>> represen
reference to symbol 'xmlXPathRegisterNs@@LIBXML2_2.4.30'
/usr/lib64/libxml2.so: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
Fixed by adding LIBXML_LIBS to libvirt_driver_vbox_impl_la_LIBADD
Signed-off-by: Jim Fehlig
---
Oddly, I don'
Eric Blake wrote:
> On 06/30/2014 04:42 PM, Jim Fehlig wrote:
>
>> Noticed the following error when building the vbox driver
>> in the openSUSE build service
>>
>> CCLD vboxsnapshotxmltest
>> /usr/lib64/gcc/x86_64-suse-linux/4.8/../../../../x86_6
Jim Fehlig wrote:
> Eric Blake wrote:
>
>> On 06/30/2014 04:42 PM, Jim Fehlig wrote:
>>
>>
>>> Noticed the following error when building the vbox driver
>>> in the openSUSE build service
>>>
>>> CCLD vboxsnapshotxmltest
The commit caused prohibit_long_lines to fail in src/Makefile.am.
Signed-off-by: Jim Fehlig
---
Pushing under the build-breaker rule.
src/Makefile.am | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 10c35d7..35720be 100644
--- a
Jenkins CI wrote:
> prohibit_long_lines
> src/Makefile.am:1146:libvirt_driver_vbox_impl_la_LIBADD = $(DLOPEN_LIBS)
> $(MSCOM_LIBS) $(LIBXML_LIBS)
> maint.mk: Wrap long lines in Makefiles
>
Heh, doesn't take long for the alarms to sound :-). Fix has been pushed.
Regards,
Jim
--
libvir-list
Eric Blake wrote:
> On 06/30/2014 10:29 AM, Jim Fehlig wrote:
>
>> Xen PV domains always have a PV console, so add one to the domain
>> config via post-parse callback if not explicitly specified in
>> the XML. The legacy Xen driver behaves similarly, causing a
>>
Dario Faggioli wrote:
> Just thinking out loud here but, if we did not get the push failure,
> when would have we discovered this?
>
Good question. I could have been days (or even weeks) before I stumbled
across it. ATM, I don't have any automated builds of libvirt.git master
against xen.git
See individual patches for details.
Jim Fehlig (4):
libxl: rename goto label
libxl: remove domain when migration prepare fails
libxl: acquire job though begin phase only
libxl: fix crash in migrate confirm for transient domains
src/libxl/libxl_driver.c| 7 ++
src/libxl
ee of the virDomainDef. Similar
to the qemu driver, pass a pointer to virDomainDefPtr so it can be set
to NULL once a virDomainObj is created from it.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_driver.c| 2 +-
src/libxl/libxl_migration.c | 10 --
src/libxl/libxl_migration.h | 2
lled=0) at libxl/libxl_migration.c:583
Fix by setting the virDomainObjPtr to NULL after removing it from
the domain list.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_migration.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/libxl/libxl_migration.c b/src
In libxlDomainMigrationPrepare(), the cleanup label handles error
conditions and should be renamed as such for clarity.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_migration.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/src/libxl
future patch adding CHANGE_PROTECTION support.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_driver.c| 5 +
src/libxl/libxl_migration.c | 16
2 files changed, 5 insertions(+), 16 deletions(-)
diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index b5f8703
Eric Blake wrote:
> On 07/08/2014 03:52 PM, Jim Fehlig wrote:
>
>> In libxlDomainMigrationConfirm(), a transient domain is removed
>> from the domain list after successful migration. Later in cleanup,
>> the domain object is unlocked, resulting in a crash
>>
>
Olaf Hering wrote:
> Translate libvirt discard settings into libxl-4.5 discard settings.
>
> Signed-off-by: Olaf Hering
> ---
> v3:
> passing discard= with old libxl is now a fatal error
> v2:
> add cast to switch variable to let compiler check if the code handles
> all enum values
>
Thanks
David Kiarie wrote:
> From: Kiarie Kahurani
>
> Introduce function xenParseXMGeneral(virConfPtr conf, ...);
> This function parses the xm general options such as uuid and name
>
> signed-off-by: David Kiarie
> ---
> src/xenxs/xen_xm.c | 65
> +++--
Eric Blake wrote:
> On 07/10/2014 07:42 AM, David Kiarie wrote:
>
>> From: Kiarie Kahurani
>>
>> Introduce function xenParseXMGeneral(virConfPtr conf, ...);
>> This function parses the xm general options such as uuid and name
>>
>
> [meta-comment]:
>
> When posting a series, it's useful to
David Kiarie wrote:
> From: Kiarie Kahurani
>
> Introduce function xenParseXMMem(virConfPtr conf,);
> This function parses the xm memory options
>
> signed-off-by: David Kiarie
> ---
> src/xenxs/xen_xm.c | 26 --
> 1 file changed, 16 insertions(+), 10 deletions(-)
>
>
David Kiarie wrote:
> From: Kiarie Kahurani
>
> I introduced the function
> xenFormatXMVif(virConfPtr conf, ..);
> which parses network configuration
>
> signed-off-by: David Kiarie
> ---
> src/xenxs/xen_xm.c | 298
> -
> 1 file changed,
David Kiarie wrote:
> From: Kiarie Kahurani
>
> Introduce the functions
> xenParseXMTimeOffset(...);
> xenParseXMEventActions(..);
>
These aren't related and should be split into two patches IMO.
Regards,
Jim
> These parse the time config and Event actions configs
> respect
From: Ian Campbell
This was converted to a typedef in 5a2bd4c9171d "conf: more enum
cleanups in "src/conf/domain_conf.h"" causing:
libxl/libxl_conf.c: In function 'libxlDiskSetDiscard':
libxl/libxl_conf.c:724:19: error: conversion to incomplete type
Signed-off-by: Ian Campbell
---
This
usterman...@web.de wrote:
> hello,
>
> if i start a transient guest doamin via "virsh create abcd.xml" i see an
> additional libvirt thread and also some open files:
>
> pstree -h `pgrep libvirtd`
> libvirtd───11*[{libvirtd}]
>
> libvirtd 3016 root 21w REG 253,0 6044 10520
web2 wrote:
> Hi
>
> ursprüngliche Nachricht-
> Von: "Michal Privoznik" mpriv...@redhat.com
> An: "web2" usterman...@web.de , "libvirt-users redhat.com"
> , "libvirt-list redhat.com"
> Datum: Wed, 01 Oct 2014 18:12:45 +0200
> ---
issue is trivial, and although not obvious to me, I think
there are several devs on the list that can give hints.
Regards,
Jim
[1] http://www.gnu.org/software/automake/manual/html_node/Yacc-and-Lex.html
> On Fri, Sep 12, 2014 at 4:17 PM, Eric Blake wrote:
>
>> On 09/11/2014 06:14 PM, Ji
Michal Privoznik wrote:
> On 19.09.2014 21:23, Jim Fehlig wrote:
>> This patch introduces a function to detect whether the specified
>> emulator is QEMU_XEN or QEMU_XEN_TRADITIONAL. Detection is based on the
>> string "Options specific to the Xen version:" in
Michal Privoznik wrote:
> On 19.09.2014 21:23, Jim Fehlig wrote:
>> This is essentially a V2 of Stefan's patch to add support
>> for user-specified video device in the libxl driver.
>>
>> https://www.redhat.com/archives/libvir-list/2014-September/msg01157.html
>
1 of this series is a respin of patch 5 that includes Michal's
suggestion. Patch 2 fixes an issue found while testing.
Jim Fehlig (2):
libxl: Support user-specified
libxl: fix double-free of libxl_domain_build_info
src/libxl/libxl_conf.c | 48 +
() from
libxlMakeDomBuildInfo(). On error, callers will dispose the
libxl_domain_config object, which in turn disposes the build info.
Signed-off-by: Jim Fehlig
---
This a new patch from V1, fixing an issue found while testing V2
of "libxl: Support user-specified ".
src/libxl/libxl_c
With the introduction of the libxlDomainGetEmulatorType function,
it is trivial to support a user-specfied in the libxl
driver. This patch is based loosely on David Scott's old patch
to do the same
https://www.redhat.com/archives/libvir-list/2013-April/msg02119.html
Signed-off-by: Jim F
Add missing 'break's from commit 1298daca, as noted by John Ferlan
https://www.redhat.com/archives/libvir-list/2014-October/msg00430.html
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_domain.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/libxl/libxl_domain.c b
John Ferlan wrote:
> Coverity complains...
> On 09/19/2014 03:23 PM, Jim Fehlig wrote:
>
>> From: Stefan Bader
>>
>> This started as an investigation into an issue where libvirt (using the
>> libxl driver) and the Xen host, like an old couple, could not a
Eric Blake wrote:
> On 10/16/2014 12:42 PM, Jim Fehlig wrote:
>
>> Add missing 'break's from commit 1298daca, as noted by John Ferlan
>>
>> https://www.redhat.com/archives/libvir-list/2014-October/msg00430.html
>> Signed-off-by: Jim Fehlig
>> ---
Ian Campbell wrote:
> Hi,
>
> On Fri, 2014-10-17 at 00:42 +0100, xen.org wrote:
>
>> *** Found and reproduced problem changeset ***
>>
>> Bug is in tree: libvirt git://libvirt.org/libvirt.git
>> Bug introduced: 24c160376275b7d31f71fbde83af8183cbf744a7
>> Bug not present: 69f7b67d55316ab7
, message: Requested operation
is not valid: PCI device :03:00.1 is still in use by driver QEMU, domain
tck)
I've found that sleeping for a bit after creating the guest allows the
tests to pass.
While here, also fix a small typo from copy and paste of disk tests.
Signed-off-by: Jim Fehli
Eric Blake wrote:
> On 10/23/2014 03:21 PM, Jim Fehlig wrote:
>
>> This patch fixes a few issues noted while enabling the TCK PCI device
>> hotplug tests.
>>
>> First, the call to node device dettach function misses parameters, resulting
>> in the following
Daniel P. Berrange wrote:
> On Fri, Oct 24, 2014 at 09:15:42AM -0600, Jim Fehlig wrote:
>
>> Eric Blake wrote:
>>
>>> On 10/23/2014 03:21 PM, Jim Fehlig wrote:
>>>
>>>
>>>> This patch fixes a few issues noted while enabli
Daniel P. Berrange wrote:
> On Fri, Oct 24, 2014 at 09:29:29AM -0600, Jim Fehlig wrote:
>
>> Right. IMO, sleeping in this test is not papering over a bug. The bug
>> is attempting to hotplug/hotunplug devices before the guest has an
>> opportunity to boot. As curren
701 - 800 of 3017 matches
Mail list logo
