QEMU
instead when miration is running. But I guess this is good enough.
Reviewed-by: Jiri Denemark
On Thu, Oct 07, 2021 at 11:09:19 +0100, Daniel P. Berrangé wrote:
> On Thu, Oct 07, 2021 at 11:53:00AM +0200, Jiri Denemark wrote:
> > On Thu, Oct 07, 2021 at 10:05:12 +0100, Daniel P. Berrangé wrote:
> > > The -cpu arg gained support for feature=on|off syntax for the x86
>
On Thu, Oct 07, 2021 at 10:05:12 +0100, Daniel P. Berrangé wrote:
> The -cpu arg gained support for feature=on|off syntax for the x86
> emulator in 2.4.0
>
> commit 38e5c119c2925812bd441450ab9e5e00fc79e662
> Author: Eduardo Habkost
> Date: Mon Mar 23 17:29:32 2015 -0300
>
>
The 7.8.0 release of both libvirt and libvirt-python is tagged and
signed tarballs and source RPMs are available at
https://libvirt.org/sources/
https://libvirt.org/sources/python/
Thanks everybody who helped with this release by sending patches,
reviewing, testing, or providing
I have just tagged v7.8.0-rc2 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
I have just tagged v7.8.0-rc1 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
We are getting close to the next release of libvirt. To aim for the
release on Oct 01 I suggest entering the freeze on Monday Sep 27 and
tagging RC2 on Wednesday Sep 29.
I hope this works for everyone.
Jirka
>
> ci: re-generate containers/gitlab config from manifest
>
> Signed-off-by: Daniel P. Berrangé
> ---
> .gitlab-ci.yml | 8
> 1 file changed, 8 deletions(-)
Reviewed-by: Jiri Denemark
By doing so we can get rid of the code which violates our coding style
guidelines.
Signed-off-by: Jiri Denemark
---
tools/virsh-domain.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index e5bd1fdd75
ns(+), 8 deletions(-)
Reviewed-by: Jiri Denemark
The 7.7.0 release of both libvirt and libvirt-python is tagged and
signed tarballs and source RPMs are available at
https://libvirt.org/sources/
https://libvirt.org/sources/python/
Thanks everybody who helped with this release by sending patches,
reviewing, testing, or providing any
> daemons. As a result the virtlockd/virtlogd sockets are not started
> when the virtqemud/virtxend daemons are started.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> src/libxl/virtxend.service.in | 2 ++
> src/qemu/virtqemud.service.in | 4
> 2 files changed, 6 insertions(+)
Reviewed-by: Jiri Denemark
t; --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -1441,7 +1441,7 @@ fi
> %preun daemon-driver-secret
> %libvirt_daemon_systemd_preun virtsecretd
>
> -%posttranstrans daemon-driver-secret
> +%posttrans daemon-driver-secret
> %libvirt_daemon_perform_restart virtsecretd
Reviewed-by: Jiri Denemark
I have just tagged v7.7.0-rc2 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
I have just tagged v7.7.0-rc1 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
No need to overwrite vmid_ex_id with a pointer to another copy of the
same string when the original is still alive.
Signed-off-by: Jiri Denemark
---
src/util/virnetdevopenvswitch.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/util/virnetdevopenvswitch.c b/src/util
I'm sending this early as I'll be out until Aug 25, but don't worry I'll
be back in time to handle the whole release process.
To aim for the release on Sep 01 I suggest entering the freeze on
Thursday Aug 26 and tagging RC2 on Monday Aug 30.
I hope this works for everyone.
Jirka
On Fri, Aug 06, 2021 at 18:12:21 +0100, Daniel P. Berrangé wrote:
> On Fri, Aug 06, 2021 at 05:07:45PM +0200, Jiri Denemark wrote:
> > On Thu, Aug 05, 2021 at 14:50:51 +0100, Daniel P. Berrangé wrote:
> > > On Thu, Aug 05, 2021 at 03:36:37PM +0200, Tim Wiederhake wrote:
> >
On Thu, Aug 05, 2021 at 14:50:51 +0100, Daniel P. Berrangé wrote:
> On Thu, Aug 05, 2021 at 03:36:37PM +0200, Tim Wiederhake wrote:
> > The kernel command line can contain settings affecting the availability
> > of cpu features, eg. "tsx=on". This series adds the kernel command line
> > to the cpu
The 7.6.0 release of both libvirt and libvirt-python is tagged and
signed tarballs and source RPMs are available at
https://libvirt.org/sources/
https://libvirt.org/sources/python/
Thanks everybody who helped with this release by sending patches,
reviewing, testing, or providing any
back(dconn,
> qemuMigrationSrcConnectionClosed);
> +ignore_value(qemuDomainObjExitRemote(vm, false));
> +}
> virErrorRestore(_err);
> return ret;
> }
Reviewed-by: Jiri Denemark
We are getting close to the next release of libvirt. To aim for the
release on Aug 02 I suggest entering the freeze on Tuesday Jul 27 and
tagging RC2 on Thursday Jul 29.
I'll be on PTO next week and thus I won't be able to make the RC
releases, Pavel Hrdina volunteered to make them while I'm
On Mon, Jul 19, 2021 at 09:37:01 +0200, Michal Prívozník wrote:
> On 7/16/21 5:06 PM, Jiri Denemark wrote:
> > Signaling the condition before vm->def->id is reset to -1 is dangerous:
> > in case a waiting thread wakes up, it does not see anything interesting
> >
in is not active anymore.
https://bugzilla.redhat.com/show_bug.cgi?id=1949869
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_process.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index c972c90801..914f936e45 100644
--- a
The 7.5.0 release of both libvirt and libvirt-python is tagged and
signed tarballs and source RPMs are available at
https://libvirt.org/sources/
https://libvirt.org/sources/python/
Thanks everybody who helped with this release by sending patches,
reviewing, testing, or providing any
I have just tagged v7.5.0-rc2 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
I have just tagged v7.5.0-rc1 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
gt; Signed-off-by: Peter Krempa
> ---
> .../caps_6.1.0.x86_64.replies | 3663 ++---
> .../caps_6.1.0.x86_64.xml | 366 +-
> 2 files changed, 2525 insertions(+), 1504 deletions(-)
Reviewed-by: Jiri Denemark
https://bugzilla.redhat.com/show_bug.cgi?id=1975677
Signed-off-by: Jiri Denemark
---
libvirt.spec.in | 4
1 file changed, 4 insertions(+)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index b8a698e81e..c1ccd2f74e 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -85,6 +85,10
We are getting close to the next release of libvirt. To aim for the
release on Jul 01 I suggest entering the freeze on Friday Jun 25 and
tagging RC2 on Tuesday Jun 29.
I hope this works for everyone.
Jirka
The 7.4.0 release of both libvirt and libvirt-python is tagged and
signed tarballs and source RPMs are available at
https://libvirt.org/sources/
https://libvirt.org/sources/python/
Thanks everybody who helped with this release by sending patches,
reviewing, testing, or providing any
rovements**
>
>* Add win-dmp crashdump format
> @@ -29,6 +40,10 @@ v7.4.0 (unreleased)
>
> * **Bug fixes**
>
> + * Allow 0 offset in XML schema for `` size='321'/>``
> +
> +Having a 0 offset so that the size of the image can be limited is a
> +valid configuration so it was allowd in the XML schema.
s/allowd/allowed/
Reviewed-by: Jiri Denemark
I have just tagged v7.4.0-rc2 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
On Wed, May 26, 2021 at 11:37:48 -0500, Jonathon Jongsma wrote:
> On Tue, May 25, 2021 at 10:12 AM Jiri Denemark wrote:
> >
> > I have just tagged v7.4.0-rc1 in the repository and pushed signed
> > tarballs and source RPMs to https://libvirt.org/sources/
> >
> >
I have just tagged v7.4.0-rc1 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
We are getting close to the next release of libvirt. To aim for the
release on Jun 01 I suggest entering the freeze on Tuesday May 25 and
tagging RC2 on Thursday May 27.
I hope this works for everyone.
Jirka
On Mon, May 17, 2021 at 11:16:35 +0200, Peter Krempa wrote:
> Add test data based on qemu commit v6.0.0-540-g6005ee07c3.
>
> Notable changes are the removal of 'sheepdog' disk storage protocol.
>
> Additionally the cpu model reported when probing seems to have changed
> from:
>
> "model-id":
The 7.3.0 release of both libvirt and libvirt-python is tagged and
signed tarballs and source RPMs are available at
https://libvirt.org/sources/
https://libvirt.org/sources/python/
Thanks everybody who helped with this release by sending patches,
reviewing, testing, or providing any
g VIR_EXPAND_N instead solves both issues and we have a
lot places with VIR_EXPAND_N so we can fix them all at some point if we
want to drop this wrapper for some reason.
Reviewed-by: Jiri Denemark
STOP event from QEMU.
An alternative approach would be to make sure we always remove the
entries regardless on why a domain was paused (e.g., during migration),
but that would be a significantly more disruptive change with possible
side effects.
Signed-off-by: Jiri Denemark
---
src/util
I have just tagged v7.3.0-rc2 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
I have just tagged v7.3.0-rc1 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
https://bugzilla.redhat.com/show_bug.cgi?id=1946529
Signed-off-by: Jiri Denemark
---
libvirt.spec.in | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index f9af330186..be74964b7b 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
We are getting close to the next release of libvirt. To aim for the
release on May 03 I suggest entering the freeze on Tuesday Apr 27 and
tagging RC2 on Thursday Apr 29 in the afternoon.
I hope this works for everyone.
Jirka
While the key is available on public GPG key servers, having it locally
at https://libvirt.org/sources/gpg_key.asc is even better.
Signed-off-by: Jiri Denemark
---
Notes:
Version 2:
- moved the new sentence to a dedicated paragraph as suggested by Andrea
docs/downloads.html.in | 6
On Thu, Apr 01, 2021 at 20:18:33 +0200, Ján Tomko wrote:
> On a Thursday in 2021, Jiri Denemark wrote:
> >While the key is available on public GPG key servers, having it locally
> >at https://libvirt.org/sources/gpg_key.asc is even better.
> >
Oops, I completely forgot I hav
While the key is available on public GPG key servers, having it locally
at https://libvirt.org/sources/gpg_key.asc is even better.
Signed-off-by: Jiri Denemark
---
docs/downloads.html.in | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/docs/downloads.html.in b/docs
The 7.2.0 release of both libvirt and libvirt-python is tagged and
signed tarballs and source RPMs are available at
https://libvirt.org/sources/
https://libvirt.org/sources/python/
Thanks everybody who helped with this release by sending patches,
reviewing, testing, or providing any
I have just tagged v7.2.0-rc2 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
mainStartDirtyRateCalc(virDomainPtr dom,
> if (virDomainStartDirtyRateCalcEnsureACL(dom->conn, vm->def) < 0)
> goto cleanup;
>
> -if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0)
> +if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_MODIFY) < 0)
> goto cleanup;
>
> if (!virDomainObjIsActive(vm)) {
Reviewed-by: Jiri Denemark
I have just tagged v7.2.0-rc1 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
; 6 files changed, 56 insertions(+), 2 deletions(-)
>
> --=20
> 2.26.2
Reviewed-by: Jiri Denemark
and pushed, thanks.
On Mon, Mar 22, 2021 at 11:17:12 +0100, Michal Privoznik wrote:
> On 3/19/21 10:42 PM, Jiri Denemark wrote:
> > In case an async job spans multiple APIs (e.g., incoming migration) the
> > API that started the job is recorded as the asyncOwnerAPI even though it
> >
Signed-off-by: Jiri Denemark
---
src/bhyve/bhyve_parse_command.c | 8 +++---
src/conf/capabilities.c | 3 +--
src/conf/domain_conf.c | 11
src/conf/storage_conf.c | 3 +--
src/conf/virinterfaceobj.c | 2 +-
src
Signed-off-by: Jiri Denemark
---
src/access/viraccessdriverstack.c | 3 +-
src/conf/backup_conf.c| 3 +-
src/conf/capabilities.c | 4 +-
src/conf/domain_addr.c| 6 +--
src/conf/domain_conf.c
Signed-off-by: Jiri Denemark
---
src/util/viralloc.c | 17 +
src/util/viralloc.h | 4 ++--
2 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/src/util/viralloc.c b/src/util/viralloc.c
index 1317537c8a..cd770eb601 100644
--- a/src/util/viralloc.c
+++ b/src/util
Our reallocation APIs already abort on OOM and thus can only return 0.
There's no need to force callers to check the result.
Signed-off-by: Jiri Denemark
---
src/util/viralloc.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/util/viralloc.h b/src/util/viralloc.h
Signed-off-by: Jiri Denemark
---
src/bhyve/bhyve_capabilities.c | 5 +
src/bhyve/bhyve_parse_command.c | 11 ++
src/conf/capabilities.c | 36 -
src/conf/cpu_conf.c | 11 ++
src/conf/domain_capabilities.c | 5 ++---
src
They can never return anything but zero anyway.
Jiri Denemark (7):
util: Drop G_GNUC_WARN_UNUSED_RESULT from reallocation APIs
Do not check return value of VIR_RESIZE_N
util: Make virResizeN return void
Do not check return value of VIR_EXPAND_N
util: Make virExpandN return void
Do
Signed-off-by: Jiri Denemark
---
src/util/viralloc.c | 14 ++
src/util/viralloc.h | 4 ++--
2 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/src/util/viralloc.c b/src/util/viralloc.c
index cd770eb601..81f5ba9a09 100644
--- a/src/util/viralloc.c
+++ b/src/util
Signed-off-by: Jiri Denemark
---
src/util/viralloc.c | 13 +
src/util/viralloc.h | 4 ++--
2 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/src/util/viralloc.c b/src/util/viralloc.c
index 81f5ba9a09..cd7ae9e7d1 100644
--- a/src/util/viralloc.c
+++ b/src/util
virQEMUCapsGet checks for qemuCaps itself, no need to do it explicitly.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_domain.c | 5 +
src/qemu/qemu_process.c | 3 +--
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 79dcb4a15d..ba2ee4f081 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_monitor_json.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index b669630bc8..5e7f425495 100644
--- a/src/qemu/qemu_monitor_json.c
+++ b/src/qemu
I'll be touching these functions soon, let's modernize them first.
Jiri Denemark (2):
qemu: Use g_autofree in qemuMigrationJobCheckStatus
qemu: Use g_autoptr in qemuMonitorJSONSetCapabilities
src/qemu/qemu_migration.c| 15 +--
src/qemu/qemu_monitor_json.c | 19
obvious which is the current (or the most recent) API involved in
the job.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_domainjob.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_domainjob.c b/src/qemu/qemu_domainjob.c
index b58d6837ad..50cfc45f5b 100644
We are getting close to the next release of libvirt. To aim for the
release on Apr 01 I suggest entering the freeze on Froday Mar 26 and
tagging RC2 on Tuesday Mar 30.
I hope this works for everyone.
Jirka
On Thu, Mar 11, 2021 at 18:47:37 +, Daniel P. Berrangé wrote:
> On Thu, Mar 11, 2021 at 06:54:20PM +0100, Michal Privoznik wrote:
> > Historically, we declared pointer type to our types:
> >
> > typedef struct _virXXX virXXX;
> > typedef virXXX *virXXXPtr;
> >
> > But usefulness of such
On Tue, Mar 09, 2021 at 17:44:16 +, Daniel P. Berrangé wrote:
...
> We can't do anything about the use "Ptr" in the include/ files because
> that is public ABI. We can potentially eliminate "Ptr" types everywhere
> else in the codebase, even the src/libvirt*.c files corresponding to
> the
dif /* WITH_BHYVE */
>
> -return ret;
> +return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
> }
>
> #if WITH_QEMU
Reviewed-by: Jiri Denemark
MigrationSrcRun(virQEMUDriverPtr driver,
> }
>
> if (qemuMigrationSetDBusVMState(driver, vm) < 0)
> -goto exit_monitor;
> +goto error;
>
> /* Before EnterMonitor, since already qemuProcessStopCPUs does that */
> if (!(flags & VIR_MIGRATE_LIVE) &&
Reviewed-by: Jiri Denemark
On Thu, Feb 25, 2021 at 14:23:06 +0100, Tim Wiederhake wrote:
> See https://bugzilla.redhat.com/show_bug.cgi?id=1840770
>
> Signed-off-by: Tim Wiederhake
> ---
> src/qemu/qemu_process.c | 27 +++
> 1 file changed, 27 insertions(+)
>
> diff --git
Commit a208176ca1d9eedf8aa6bf12fde6a7a9579ab549 introduced this feature
with an incorrect "svme-addr-check" spelling.
Signed-off-by: Jiri Denemark
---
src/cpu_map/sync_qemu_i386.py | 2 +-
src/cpu_map/x86_EPYC-Milan.xml | 2 +-
src/cpu_map/x86_features.xml | 2 +-
3 files
Signed-off-by: Jiri Denemark
---
src/cpu_map/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/cpu_map/meson.build b/src/cpu_map/meson.build
index 48f69f623c..013fc62a02 100644
--- a/src/cpu_map/meson.build
+++ b/src/cpu_map/meson.build
@@ -34,6 +34,7 @@ cpumap_data
Introduced in QEMU 6.0.0 by 623972ceae091b31331ae4a1dc94fe5cbb891937
Signed-off-by: Jiri Denemark
---
src/cpu_map/index.xml | 1 +
src/cpu_map/x86_EPYC-Milan.xml | 92 ++
2 files changed, 93 insertions(+)
create mode 100644 src/cpu_map/x86_EPYC
> tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml | 1 +
> tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml | 1 +
> 4 files changed, 11 insertions(+)
Reviewed-by: Jiri Denemark
and pushed, thanks.
The 7.1.0 release of both libvirt and libvirt-python is tagged and
signed tarballs and source RPMs are available at
https://libvirt.org/sources/
https://libvirt.org/sources/python/
Thanks everybody who helped with this release by sending patches,
reviewing, testing, or providing any
I have just tagged v7.1.0-rc2 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
On Thu, Feb 25, 2021 at 08:17:09 +0100, Tim Wiederhake wrote:
> libvirt performs cpu checking if "check" is set to "partial", but skips
> checking the cpu if "check" is set to "full".
This is intentional because QEMU knows better. I wish we had no CPU
comparison in libvirt at all, but we can't do
allocated owner name will disappear with the
reconnecting thread. Any follow up usage of the pointer will read random
memory.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_domainjob.c | 12 ++--
src/qemu/qemu_process.c | 2 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff
I have just tagged v7.1.0-rc1 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
then configure
> source for the migration.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_migration.c | 333 +-
> 1 file changed, 331 insertions(+), 2 deletions(-)
Reviewed-by: Jiri Denemark
rform merges.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_migration_params.c | 29 +
> src/qemu/qemu_migration_params.h | 5 +
> 2 files changed, 34 insertions(+)
Reviewed-by: Jiri Denemark
yone caring about the exact image format on
the destination needs to precreate the images manually.
So I guess this should good enough.
Reviewed-by: Jiri Denemark
| 741 ++
> .../caps_6.0.0.x86_64.xml | 22 +-
> 2 files changed, 441 insertions(+), 322 deletions(-)
Reviewed-by: Jiri Denemark
On Thu, Feb 18, 2021 at 16:50:43 +0100, Peter Krempa wrote:
> On Thu, Feb 18, 2021 at 15:54:37 +0100, Jiri Denemark wrote:
> > On Thu, Feb 11, 2021 at 16:37:57 +0100, Peter Krempa wrote:
> > > Preserve block dirty bitmaps after migration with
> > > QEMU_MONITOR_M
rQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_USB_STORAGE) &&
> !virQEMUCapsGet(qemuCaps, QEMU_CAPS_USB_STORAGE_WERROR)) {
Reviewed-by: Jiri Denemark
On Thu, Feb 11, 2021 at 16:37:57 +0100, Peter Krempa wrote:
> Preserve block dirty bitmaps after migration with
> QEMU_MONITOR_MIGRATE_NON_SHARED_(DISK|INC).
>
> This patch implements functions which offer the bitmaps to the
> destination, check for eligibility on destination and then configure
>
t; +}
> +
> +return 0;
> +}
> +
> +
> static virStorageSourcePtr
> qemuMigrationSrcNBDStorageCopyBlockdevPrepareSource(virDomainDiskDefPtr disk,
> const char *host,
...
Reviewed-by: Jiri Denemark
();
> +
> +bitmaps = g_slist_prepend(bitmaps, bmp);
> +}
> +
> +jobPriv->migTempBitmaps = g_slist_reverse(g_steal_pointer());
> +return 0;
> +}
> +
> +
> static int
> qemuDomainParseJobPrivate(xmlXPathContextPtr ctxt,
>qemuDomainJobObjPtr job,
> @@ -277,6 +358,9 @@ qemuDomainParseJobPrivate(xmlXPathContextPtr ctxt,
> if (qemuDomainObjPrivateXMLParseJobNBD(vm, ctxt) < 0)
> return -1;
>
> +if (qemuDomainParseJobPrivateXMLMigrationBlockDirtyBitmapsTemp(priv,
> ctxt) < 0)
> +return -1;
> +
> if (qemuMigrationParamsParse(ctxt, >migParams) < 0)
> return -1;
>
...
No matter whether you decide to change the functions names...
Reviewed-by: Jiri Denemark
Either
int
qemuMigrationCookieBlockDirtyBitmapsMatchDisks(...
or
int qemuMigrationCookieBlockDirtyBitmapsToParams(...
Reviewed-by: Jiri Denemark
eing non-NULL here.
> +bitmaps = g_slist_prepend(bitmaps, bitmap);
> +}
> +
> +disk = g_new0(qemuMigrationBlockDirtyBitmapsDisk, 1);
> +disk->target = virXMLPropString(disknodes[i], "target");
And here as well.
> +disk->bitmaps = g_slist_reverse(bitmaps);
> +
> +disks = g_slist_prepend(disks, disk);
> +}
> +
> +mig->blockDirtyBitmaps = g_slist_reverse(g_steal_pointer());
> +
> +return 0;
> +}
> +
> +
> static int
> qemuMigrationCookieXMLParse(qemuMigrationCookiePtr mig,
> virQEMUDriverPtr driver,
...
With the checks for virXMLPropString result added
Reviewed-by: Jiri Denemark
files changed, 269 insertions(+), 27 deletions(-)
> create mode 100644
> tests/qemumigrationcookiexmldata/nbd-bitmaps-xml2xml-in.xml
> create mode 100644
> tests/qemumigrationcookiexmldata/nbd-bitmaps-xml2xml-migparams.json
> create mode 100644
> tests/qemumigrationcookie
ration-out-nbd-bitmaps-in.xml
> create mode 12
> tests/qemustatusxml2xmldata/migration-out-nbd-bitmaps-out.xml
Reviewed-by: Jiri Denemark
We are getting close to the next release of libvirt. To aim for the
release on Mar 01 I suggest entering the freeze on Monday Feb 22 and
tagging RC2 on Thursday Feb 25.
I hope this works for everyone.
Jirka
On Fri, Feb 12, 2021 at 12:13:58 +, Daniel P. Berrangé wrote:
> On Fri, Feb 12, 2021 at 11:55:36AM +0100, Peter Krempa wrote:
> > On Fri, Feb 12, 2021 at 10:49:02 +, Daniel Berrange wrote:
> > > On Thu, Feb 11, 2021 at 04:37:47PM +0100, Peter Krempa wrote:
> > > > Format the new volumes
volxml2argvdata/qcow2-zerocapacity.argv| 2 +-
> 13 files changed, 13 insertions(+), 13 deletions(-)
Reviewed-by: Jiri Denemark
> .../qcow2-nocow-compat.argv | 9 +---
> tests/storagevolxml2argvdata/qcow2-nocow.argv | 9 +---
> .../qcow2-zerocapacity.argv | 5 +++-
> 21 files changed, 147 insertions(+), 77 deletions(-)
Reviewed-by: Jiri Denemark
t;) ||
> + virStringHasSuffix(filename, ".argv") ||
>virStringHasSuffix(filename, ".ldargs")))
> return 0;
>
Reviewed-by: Jiri Denemark
347,7 +4347,7 @@ qemuMigrationSrcPerformPeer2Peer3(virQEMUDriverPtr
> driver,
> char *uri_out = NULL;
> char *cookiein = NULL;
> char *cookieout = NULL;
> -char *dom_xml = NULL;
> +g_autofree char *dom_xml = NULL;
> int cookieinlen = 0;
> in
701 - 800 of 7240 matches
Mail list logo
