[libvirt PATCH 10/39] cpu_x86: Use g_auto* in x86FeatureParse

Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 31 --- 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index a678bcde61..d2bbcbd891 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -1023,13 +1023,12

[libvirt PATCH 05/39] cpu_x86: Use glib allocation for virCPUx86Model

Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 31 --- 1 file changed, 8 insertions(+), 23 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index cfb8a2e4a5..4a0413db16 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -,29 +,18

[libvirt PATCH 19/39] cpu_x86: Use g_auto* in x86Encode

Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 51 +++ 1 file changed, 21 insertions(+), 30 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index ce43da2bfa..431fbd8ec6 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c

[libvirt PATCH 11/39] cpu_x86: Use g_auto* in x86ModelFromCPU

Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index d2bbcbd891..9455fd1440 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -1173,7 +1173,7 @@ x86ModelFromCPU

[libvirt PATCH 02/39] cpu_x86: Use glib allocation for virCPU{, x86}Data

Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 45 ++--- 1 file changed, 22 insertions(+), 23 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index eeb16c2763..f0d9b7056a 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c

[libvirt PATCH 12/39] cpu_x86: Use g_auto* in x86ModelParse

Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 9455fd1440..fc94c029e4 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -1493,41 +1493,36

[libvirt PATCH 09/39] cpu_x86: Use g_auto* in x86VendorParse

Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index d0ef66f1e3..a678bcde61 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -849,9 +849,8

[libvirt PATCH 01/39] cpu_x86: Drop noTSX hint for incompatible CPUs

it to cover all current noTSX models. Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 42 ++ 1 file changed, 6 insertions(+), 36 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index ce15bb0454..eeb16c2763 100644 --- a/src/cpu/cpu_x86.c

[libvirt PATCH 20/39] cpu_x86: Use g_auto* in virCPUx86CheckFeature

Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 431fbd8ec6..3b3a428ecd 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -2282,21 +2282,16 @@ static int

[libvirt PATCH 06/39] cpu_x86: Use glib allocation for virCPUx86Map

Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 4a0413db16..bcb87d6f93 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -1566,23 +1566,24 @@ x86MapFree

[libvirt PATCH 13/39] cpu_x86: Use g_auto* in virCPUx86LoadMap

Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index fc94c029e4..ba269df66d 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -1559,18 +1559,14

[libvirt PATCH 15/39] cpu_x86: Use g_auto* in x86Compute

Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 64 ++- 1 file changed, 24 insertions(+), 40 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 6c3f9fc0be..6758fcc170 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c

[libvirt PATCH 04/39] cpu_x86: Use glib allocation for virCPUx86Feature

Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 6fad4af922..cfb8a2e4a5 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -893,28 +893,17

[libvirt PATCH 03/39] cpu_x86: Use glib allocation for virCPUx86Vendor

Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index f0d9b7056a..6fad4af922 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -830,9 +830,10 @@ x86VendorFree

[libvirt PATCH 18/39] cpu_x86: Use g_auto* in x86EncodePolicy

Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 26d872622e..ce43da2bfa 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -2168,7 +2168,7 @@ x86EncodePolicy(virCPUx86Data

[libvirt PATCH 23/39] cpu_x86: Use g_auto* in x86UpdateHostModel

Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index ccbae3dabd..9f6027ec5c 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -2821,17 +2821,16 @@ static int

Re: [PATCH] docs: fix typo in domcaps host-model CPU description

On Mon, Mar 23, 2020 at 15:47:49 -0600, Jim Fehlig wrote: > The domain capabilities documentation contains a small but confusing > error in the host-model CPU description, referencing the element > instead of . Fix this small typo. > > Signed-off-by: Jim Fehlig > --- > > I only found this

Re: [PATCH v2 1/1] cpu_map: Add more -noTSX x86 CPU models

gs.launchpad.net/ubuntu/+source/libvirt/+bug/1853200 > > Signed-off-by: Christian Ehrhardt Reviewed-by: Jiri Denemark I just resent this patch (with my Reviewed-by already applied) together with a few additional patches for not using the new noTSX model for host-model CPUs. Jirka

[libvirt PATCH 4/4] cpu_map: Don't use new noTSX models for host-model CPUs

. The new models will be advertised in host capabilities and they may be used explicitly with custom CPUs. Signed-off-by: Jiri Denemark --- src/cpu_map/x86_Cascadelake-Server-noTSX.xml | 2 +- src/cpu_map/x86_Icelake-Client-noTSX.xml | 2 +- src/cpu_map/x86_Icelake-Server

[libvirt PATCH 3/4] cpu_x86: Honor CPU models' element

Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 366337ef57..ce15bb0454 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -2044,10 +2044,23

[libvirt PATCH 2/4] cpu_map: Add element to x86 CPU model definitions

and host-model CPU definitions is controlled by the @guest attribute. Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 43 +++ src/cpu_map/x86_486.xml | 1 + src/cpu_map/x86_Broadwell-IBRS.xml| 1 + src/cpu_map

[libvirt PATCH 1/4] cpu_map: Add more -noTSX x86 CPU models

://www.kernel.org/doc/html/latest/admin-guide/hw-vuln/tsx_async_abort.html Fixes: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1853200 Signed-off-by: Christian Ehrhardt Message-Id: <20200310104806.2723-2-christian.ehrha...@canonical.com> Reviewed-by: Jiri Denemark --- src/c

[libvirt PATCH 0/4] cpu_map: Add more -noTSX x86 CPU models

Christian Ehrhardt (1): cpu_map: Add more -noTSX x86 CPU models Jiri Denemark (3): cpu_map: Add element to x86 CPU model definitions cpu_x86: Honor CPU models' element cpu_map: Don't use new noTSX models for host-model CPUs src/cpu/cpu_x86.c | 65

Re: [PATCH v2 1/1] cpu_map: Add more -noTSX x86 CPU models

On Fri, Mar 13, 2020 at 09:45:15 +0100, Christian Ehrhardt wrote: > On Tue, Mar 10, 2020 at 11:48 AM Christian Ehrhardt < > christian.ehrha...@canonical.com> wrote: > > > One of the mitigation methods for TAA[1] is to disable TSX > > support on the host system. Linux added a mechanism to disable

[libvirt PATCH 0/3] cpu: Honor check='full' for host-passthrough CPUs

See patch 3/3 for explanation. Jiri Denemark (3): cpu: Change control flow in virCPUUpdateLive cpu_x86: Prepare virCPUx86UpdateLive for easier extension cpu: Honor check='full' for host-passthrough CPUs src/cpu/cpu.c | 12 +++- src/cpu/cpu_x86.c | 20 +--- 2

[libvirt PATCH 3/3] cpu: Honor check='full' for host-passthrough CPUs

-passthrough CPUs with VIR_CPU_CHECK_FULL to make sure the architecture specific code can validate the provided virtual CPU against the desired definition. https://bugzilla.redhat.com/show_bug.cgi?id=1515677 Signed-off-by: Jiri Denemark --- src/cpu/cpu.c | 3 ++- src/cpu/cpu_x86.c | 10

[libvirt PATCH 1/3] cpu: Change control flow in virCPUUpdateLive

The updateLive CPU sub-driver function is supposed to be called only for a subset of CPU definitions. Let's make it more obvious by turning a negative test and return into a positive check. Signed-off-by: Jiri Denemark --- src/cpu/cpu.c | 11 ++- 1 file changed, 6 insertions(+), 5

[libvirt PATCH 2/3] cpu_x86: Prepare virCPUx86UpdateLive for easier extension

Adding more checks into the existing if statements would turn them into an unreadable mess. Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index dca9ed2979..5a6b7bb1d8

Re: [PATCH] cpu_map: Add more -noTSX x86 CPU models

On Fri, Mar 06, 2020 at 09:41:43 +0100, Christian Ehrhardt wrote: > One of the mitigation methods for TAA[1] is to disable TSX > support on the host system. Linux added a mechanism to disable > TSX globally through the kernel command line, and many Linux > distributions now default to tsx=off.

[libvirt PATCH] cputest: Add data for Intel(R) Core(TM) i7-8550U CPU without TSX

Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + .../x86_64-cpuid-Core-i7-8550U-disabled.xml |6 + .../x86_64-cpuid-Core-i7-8550U-enabled.xml|9 + .../x86_64-cpuid-Core-i7-8550U-guest.xml | 31 + .../x86_64-cpuid-Core-i7-8550U-host.xml

Re: [PATCH] cpu_map: Add more -noTSX x86 CPU models

On Fri, Mar 06, 2020 at 09:41:43 +0100, Christian Ehrhardt wrote: > One of the mitigation methods for TAA[1] is to disable TSX > support on the host system. Linux added a mechanism to disable > TSX globally through the kernel command line, and many Linux > distributions now default to tsx=off.

[libvirt PATCH] qemu: Do not set default CPU for archs without CPU driver

would add a default CPU to any domain as long as QEMU reports it causing failures to start any domain on affected architectures. https://bugzilla.redhat.com/show_bug.cgi?id=1805755 Signed-off-by: Jiri Denemark --- src/cpu/cpu.c| 24 src/cpu/cpu.h

[libvirt PATCH 2/2] cpu_conf: Format vendor_id for host-model CPUs

In commit v5.9.0-400-gaf8e39921a I removed printing model's fallback and vendor_id attributes when no model is specified. However, vendor_id makes sense even without a specific CPU model (for host-model CPUs). https://bugzilla.redhat.com/show_bug.cgi?id=1804549 Signed-off-by: Jiri Denemark

[libvirt PATCH 0/2] cpu_conf: Format vendor_id for host-model CPUs

In commit v5.9.0-400-gaf8e39921a I removed printing model's fallback and vendor_id attributes when no model is specified. However, vendor_id makes sense even without a specific CPU model (for host-model CPUs). https://bugzilla.redhat.com/show_bug.cgi?id=1804549 Jiri Denemark (2

[libvirt PATCH 1/2] qemuxml2xmltest: Add case for host-model vendor_id

This patch show a bug in our code: the element present in the source XML is lost when the parsed CPU definition is formatted back to XML. https://bugzilla.redhat.com/show_bug.cgi?id=1804549 Signed-off-by: Jiri Denemark --- .../cpu-host-model-vendor.xml | 28

[libvirt PATCH 1/3] qemu: Pass machine type to virQEMUCapsIsCPUModeSupported

The usability of a specific CPU mode may depend on machine type, let's prepare for this by passing it to virQEMUCapsIsCPUModeSupported. Signed-off-by: Jiri Denemark --- src/qemu/qemu_capabilities.c | 12 src/qemu/qemu_capabilities.h | 3 ++- src/qemu/qemu_domain.c | 3

[libvirt PATCH 3/3] qemu_capabilities: Disable CPU models on old s390 machine types

pport -cpu host. https://bugzilla.redhat.com/show_bug.cgi?id=1795651 Reported-by: Christian Ehrhardt Signed-off-by: Jiri Denemark --- src/qemu/qemu_capabilities.c | 19 ++- ...t-cpu-kvm-ccw-virtio-2.7.s390x-latest.args | 4 +--- ...lt-cpu-kvm-ccw-virtio

[libvirt PATCH 2/3] qemuxml2*test: Add default CPU tests for s390-ccw-virtio-2.7 machines

Signed-off-by: Jiri Denemark --- ...t-cpu-kvm-ccw-virtio-2.7.s390x-latest.args | 34 +++ .../s390-default-cpu-kvm-ccw-virtio-2.7.xml | 16 + ...t-cpu-tcg-ccw-virtio-2.7.s390x-latest.args | 32 + .../s390-default-cpu-tcg-ccw-virtio-2.7.xml | 16

[libvirt PATCH 0/3] qemu: Fix default CPU for old s390 machine types

See the last patch for detailed description and https://bugzilla.redhat.com/show_bug.cgi?id=1795651 for a discussion about this topic. Jiri Denemark (3): qemu: Pass machine type to virQEMUCapsIsCPUModeSupported qemuxml2*test: Add default CPU tests for s390-ccw-virtio-2.7 machines

Re: [PATCH] qemu: snapshot: Prevent too-nested domain XML when doing inactive snapshot

On Mon, Jan 20, 2020 at 16:12:06 +0100, Peter Krempa wrote: > Similarly to 510d154a0b41aa70aadabc0918d16dee22882394 we need to prevent > doing too deeply nested backing chains and reject them with a sane error > message. > > Add a loop to go through the snapshots prior to attempting actually >

Re: [PATCH] qemu: monitor: Improve error message when QEMU reply is too large

anged, 3 insertions(+), 3 deletions(-) Reviewed-by: Jiri Denemark

[PATCH] qemu: Don't emit SUSPENDED_POSTCOPY event on destination

entering post-copy mode is already properly advertised by VIR_DOMAIN_EVENT_RESUMED_POSTCOPY event. https://bugzilla.redhat.com/show_bug.cgi?id=1791458 Signed-off-by: Jiri Denemark --- src/qemu/qemu_process.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_process.c b/src/qemu

Re: [libvirt] [PATCH for 6.0.0] vircgroupv2devices: free BPF map when replacing with new one

ified.devices.progfd = progfd; > group->unified.devices.mapfd = mapfd; > group->unified.devices.max = max; Reviewed-by: Jiri Denemark -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH for 6.0.0] qemuxml2*test: Fix hugepages-default-system-size tests

(ppc64le) with default page size other than 4KiB. Signed-off-by: Jiri Denemark --- tests/qemuxml2argvtest.c | 2 +- tests/qemuxml2xmltest.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 8af2ba38d3..560a012149

Re: [libvirt] [PATCH 0/4] Fix formatting of encrypted disk secret info (for 6.0.0)

| 1 + > tests/virstoragetest.c| 2 +- > 13 files changed, 259 insertions(+), 11 deletions(-) > create mode 100644 > tests/qemuxml2argvdata/luks-disks-source-qcow2.x86_64-latest.args > create mode 100644 > tests/qemuxml2xmloutdata/luks-disks-source-

Re: [libvirt] [PATCH 4/4] conf: Always format storage source auth and encryption under for backing files

On Fri, Jan 10, 2020 at 17:57:22 +0100, Peter Krempa wrote: > Historically there are two places where we format authentication and > encryption for a disk. The logich which formats it for backing files was > flawed though and didn't format it at all. This worked if the image > became a backing

Re: [libvirt] [PATCH v2 0/5] introduce support for CPU dies in host/guest topology

; - Fixed docs for dies attribute > - Improve error checking when parsing > - Misc typos Reviewed-by: Jiri Denemark -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] docs: add pages to support Go module package resolution

On Fri, Jan 10, 2020 at 11:50:48 +, Daniel P. Berrangé wrote: > On Fri, Jan 10, 2020 at 12:47:51PM +0100, Jiri Denemark wrote: > > On Fri, Jan 10, 2020 at 10:03:28 +, Daniel P. Berrangé wrote: > > > Currently the libvirt Go modules are accessed by applications using

Re: [libvirt] [PATCH] docs: add pages to support Go module package resolution

On Fri, Jan 10, 2020 at 10:03:28 +, Daniel P. Berrangé wrote: > Currently the libvirt Go modules are accessed by applications using > their github repository URLs. This is undesirable as we don't want > applications to have a direct dependancy on a specific source repo > location. We want to

[libvirt] [PATCH] qemu: Don't use NULL path from qemuDomainGetHostdevPath

-off-by: Jiri Denemark --- src/qemu/qemu_cgroup.c | 32 ++-- src/qemu/qemu_domain.c | 9 + 2 files changed, 23 insertions(+), 18 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 2bcc0527f6..45701b4c6e 100644 --- a/src/qemu

Re: [libvirt] [PATCH 5/5] tests: add host CPU data files for validating die_id

test data was from > a Fedora 31 QEMU guest launched with > > -cpu qemu64 -smp sockets=2,dies=3,cores=2,threads=1 > > Ideally we'd replace this data with some from a real machine reporting > "die_id", to ensure we're not mislead by QEMU's impl. > > Signed-off-

Re: [libvirt] [PATCH 4/5] hostcpu: add support for reporting die_id in NUMA topology

> > > Notes core_id is repeated within the scope of the socket. > > It now reports > > > > > > > > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Jiri Denemark -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 3/5] qemu: add support for specifying CPU "dies" topology parameter

100644 tests/qemuxml2argvdata/smp-dies.args > create mode 100644 tests/qemuxml2argvdata/smp-dies.xml Reviewed-by: Jiri Denemark -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 2/5] conf: remove unused virCapabilitiesSetHostCPU method

On Thu, Dec 19, 2019 at 12:42:05 +, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > src/conf/capabilities.c | 21 - > src/conf/capabilities.h | 6 -- > src/libvirt_private.syms | 1 - > 3 files changed, 28 deletions(-)

Re: [libvirt] [PATCH 1/5] conf: add support for specifying CPU "dies" parameter

On Thu, Dec 19, 2019 at 12:42:04 +, Daniel P. Berrangé wrote: > Recently CPU hardware vendors have started to support a new level of > inside the CPU package topology known as a "die". Thus the hierarchy Level of what? Looks like a missing word between "level of" and "inside". > is now: > >

Re: [libvirt] [PATCH] virsh migrate: Require --tls for --tls-destination

On Tue, Dec 17, 2019 at 14:46:24 +0100, Peter Krempa wrote: > On Tue, Dec 17, 2019 at 14:34:12 +0100, Jiri Denemark wrote: > > --tls-destination would be just ignored unless --tls is not specified, > > which is correct, but let's provide a bit of a guidance is a user > >

[libvirt] [PATCH] virsh migrate: Require --tls for --tls-destination

--tls-destination would be just ignored unless --tls is not specified, which is correct, but let's provide a bit of a guidance is a user forgets to add --tls. https://bugzilla.redhat.com/show_bug.cgi?id=1784345 Signed-off-by: Jiri Denemark --- tools/virsh-domain.c | 1 + 1 file changed, 1

Re: [libvirt] [PATCH] cpu: add CLZERO CPUID support for AMD platforms (libvirt 4.5)

On Tue, Dec 03, 2019 at 03:19:39 -0800, Ani Sinha wrote: > Qemu commit e900135dcfb67 ("i386: Add CPUID bit for CLZERO and XSAVEERPTR") > adds support for CLZERO CPUID bit. This commit extends support for this > bit in libvirt. > > This patch is based off of libvirt-4.5 tree. Thanks, but we are

Re: [libvirt] [PATCH] cpu: add CLZERO CPUID support for AMD platforms

pport clzero. That said, I dropped the changes to EPYC* CPU models, moved the feature definition in x86_features a bit, updated the test results, and pushed this as commit 1d17f881a278c408ede19c7e6a5330e3f19fe0f0 Reviewed-by: Jiri Denemark -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] src: warn against virNodeGetInfo() API call due to inaccurate info

On Mon, Dec 16, 2019 at 10:36:40 +, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > include/libvirt/libvirt-host.h | 4 > src/libvirt-host.c | 16 > 2 files changed, 20 insertions(+) Reviewed-by: Jiri Denemark -- libv

[libvirt] [PATCH] cpu_map/x86: Add support for BFLOAT16 data type

Introduced in QEMU by commit v4.1.0-266-g80db491da4. Signed-off-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 4 1 file changed, 4 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index b42b490160..eefb55067e 100644 --- a/src/cpu_map

[libvirt] [PATCH 2/2] cpu_map: Add TSX_CTRL bit for IA32_ARCH_CAPABILITIES MSR

CVE-2019-11135 When TSX_CTRL bit of IA32_ARCH_CAPABILITIES MSR is set to 1, the CPU supports IA32_TSX_CTRL MSR which can be used to disable and/or mask TSX. Signed-off-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map

[libvirt] [PATCH 1/2] cpu_map: Add TAA_NO bit for IA32_ARCH_CAPABILITIES MSR

CVE-2019-11135 CPUs with TAA_NO bit of IA32_ARCH_CAPABILITIES MSR set to 1 are not vulnerable to TSX Asynchronous Abort and passing this bit to a guest may avoid unnecessary mitigations. Signed-off-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions

[libvirt] [PATCH 0/2] cpu_map: Introduce IA32_ARCH_CAPABILITIES MSR bits for TAA

-synchronization-extensions-intel-tsx-asynchronous-abort [2] https://www.kernel.org/doc/html/latest/admin-guide/hw-vuln/tsx_async_abort.html Jiri Denemark (2): cpu_map: Add TAA_NO bit for IA32_ARCH_CAPABILITIES MSR cpu_map: Add TSX_CTRL bit for IA32_ARCH_CAPABILITIES MSR src/cpu_map

Re: [libvirt] [PATCH 0/2] qemu: Refactor qemuDomainAbortJob

rting of a domain job to a switch statement > > src/qemu/qemu_driver.c | 90 +- > 1 file changed, 63 insertions(+), 27 deletions(-) Reviewed-by: Jiri Denemark -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 0/4] Introduce VIR_MIGRATE_PARAM_TLS_DESTINATION migration param

the migration. Jiri Denemark (4): qemu: Add support for setting string migration params Introduce VIR_MIGRATE_PARAM_TLS_DESTINATION migration param qemu: Implement VIR_MIGRATE_PARAM_TLS_DESTINATION virsh: Add --tls-destination option for migrate command include/libvirt/libvirt-domain.h

[libvirt] [PATCH 3/4] qemu: Implement VIR_MIGRATE_PARAM_TLS_DESTINATION

Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.h| 1 + src/qemu/qemu_migration_params.c | 9 - 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.h b/src/qemu/qemu_migration.h index d98fe9f80a..b6f88d3fd9 100644 --- a/src/qemu

[libvirt] [PATCH 1/4] qemu: Add support for setting string migration params

The functions for converting migration typed parameters to QEMU migration parameters and back were only implemented for integer types. This patch adds support for string parameters. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration_params.c | 56 1 file

[libvirt] [PATCH 2/4] Introduce VIR_MIGRATE_PARAM_TLS_DESTINATION migration param

the migration. Signed-off-by: Jiri Denemark --- include/libvirt/libvirt-domain.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index 40c71091ec..a099b3d891 100644 --- a/include/libvirt/libvirt-domain.h +++ b

[libvirt] [PATCH 4/4] virsh: Add --tls-destination option for migrate command

This option can be used to override the destination host name used for TLS verification. Signed-off-by: Jiri Denemark --- tools/virsh-domain.c | 11 +++ tools/virsh.pod | 8 ++-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh

[libvirt] [PATCH] spec: Fix printing test-suite.log when make check fails

Commit v5.7.0-248-g03449e2504 removed "cd tests" without updating the patch to test-suite.log. Signed-off-by: Jiri Denemark --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index c7fac104d9..4c6161a

[libvirt] [PATCH] spec: Disable gluster on i686 on RHEL-8

Gluster 6.0 is not built on i686 for RHEL-8, which prevents libvirt from building. Let's just disable gluster there as all we need are client libraries anyway. Signed-off-by: Jiri Denemark --- libvirt.spec.in | 8 1 file changed, 8 insertions(+) diff --git a/libvirt.spec.in b

[libvirt] [PATCH] qemu: Fix migration without parameters

.redhat.com/show_bug.cgi?id=1777094 Signed-off-by: Jiri Denemark --- src/util/virtypedparam.c | 4 1 file changed, 4 deletions(-) diff --git a/src/util/virtypedparam.c b/src/util/virtypedparam.c index 603fcf213a..be3dac1571 100644 --- a/src/util/virtypedparam.c +++ b/src/util/virtypedparam.c

Re: [libvirt] [PATCH] qemu_capabilities: Use proper free function for caps->cpuModels

els); > +qemuMonitorCPUDefsFree(caps->cpuModels); > } Oops, introduced by v5.9.0-318-gbc0b22884a which switched cpuModels from virDomainCapsCPUModelsPtr (virObject) to qemuMonitorCPUDefsPtr. Unfortunately, virObjectUnref takes void * so the compiler could not help here. Reviewed-by: Jiri Denemark -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 2/2] util: virNetDevBandwidthPlug: Drop ATTRIBUTE_UNUSED(4)

On Fri, Nov 22, 2019 at 17:09:00 +0100, Erik Skultety wrote: > Since we know for sure that the @bandwidth parameter is properly handled > in networkCheckBandwidth (@ifaceBand), it cannot ever be NULL, but > coverity doesn't see this fact. In order to prevent coverity from > reporting a false

Re: [libvirt] [PATCH 1/2] Revert "network: Check for QOS before blindly using it"

hPlug would have been even > made. > > Signed-off-by: Erik Skultety > --- > src/network/bridge_driver.c | 14 -- > 1 file changed, 14 deletions(-) Reviewed-by: Jiri Denemark -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 02/52] tests: Update 4.2.0 capabilities data on ppc64

On Tue, Nov 12, 2019 at 15:26:16 +0100, Ján Tomko wrote: > On Tue, Nov 05, 2019 at 02:27:00PM +0100, Jiri Denemark wrote: > >Generated with "spapr/kvm: Set default cpu model for all machine > >classes" fix for QEMU applied. > > > >Signed-off-by: Jiri Denemark

Re: [libvirt] [PATCH 0/4] qemu: Use host-model CPU on s390 by default

On Mon, Nov 18, 2019 at 18:34:36 +0100, Boris Fiuczynski wrote: > > > On 11/15/19 4:14 PM, Jiri Denemark wrote: > > On Fri, Nov 15, 2019 at 15:55:04 +0100, Christian Borntraeger wrote: > >> > >> > >> On 15.11.19 15:47, Jiri Denemark wrote: > >

Re: [libvirt] [PATCH 0/4] qemu: Use host-model CPU on s390 by default

On Fri, Nov 15, 2019 at 15:55:04 +0100, Christian Borntraeger wrote: > > > On 15.11.19 15:47, Jiri Denemark wrote: > > On Fri, Nov 15, 2019 at 15:12:18 +0100, Boris Fiuczynski wrote: > >> Just a heads up. > >> After installing libvirt rpms of this branch all m

Re: [libvirt] [PATCH 0/4] qemu: Use host-model CPU on s390 by default

On Fri, Nov 15, 2019 at 15:12:18 +0100, Boris Fiuczynski wrote: > Just a heads up. > After installing libvirt rpms of this branch all my existing kvm s390 > domains ended up with > > > qemu > > > Newly defined domains without specified cpu do so as well. Unless the domains are all

[libvirt] [PATCH] virsh: Fix typo in the man page

Signed-off-by: Jiri Denemark --- Pushed as trivial. tools/virsh.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index c261d403d8..2dce4493cb 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -1827,7 +1827,7 @@ agent commands block

[libvirt] [PATCH 4/4] qemu: Use host-model CPU on s390 by default

can safely use host-model and benefit from CPU compatibility checks during migration, snapshot restore and similar operations. Signed-off-by: Jiri Denemark --- src/qemu/qemu_domain.c| 33 --- ...t-cpu-kvm-ccw-virtio-4.2.s390x-latest.args | 4 ++- ...lt-c

[libvirt] [PATCH 0/4] qemu: Use host-model CPU on s390 by default

an fetch both series at once using git fetch https://gitlab.com/jirkade/libvirt cpu-default-type Jiri Denemark (4): cpu_conf: Fix default value for CPU match attribute cpu_conf: Don't format empty model for host-model CPUs cpu_s390: Don't check match attribute for host-model CPUs qemu

[libvirt] [PATCH 3/4] cpu_s390: Don't check match attribute for host-model CPUs

as optional features are not supported on s390 either. Signed-off-by: Jiri Denemark --- src/cpu/cpu_s390.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/cpu/cpu_s390.c b/src/cpu/cpu_s390.c index a4a381f4b8..dd030c5a11 100644 --- a/src/cpu/cpu_s390.c +++ b/src

[libvirt] [PATCH 1/4] cpu_conf: Fix default value for CPU match attribute

-off-by: Jiri Denemark --- Notes: Well, thanks to a bug (fixed in another patch in this series) the s390 CPU driver actually looks at the match attribute even for host-model CPUs. src/conf/cpu_conf.c | 9 ++--- src/conf/cpu_conf.h | 2 +- 2 files changed, 3 insertions(+), 8

[libvirt] [PATCH 2/4] cpu_conf: Don't format empty model for host-model CPUs

Most likely for historical reasons our CPU def formatting code is happily adding useless for host-model CPUs. We can just drop it. Signed-off-by: Jiri Denemark --- src/conf/cpu_conf.c | 16 +--- .../cputestdata/ppc64-host+guest-compat-none.xml | 4

[libvirt] [PATCH 5/6] cputest: Add data for Ice Lake Server CPU

Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + .../x86_64-cpuid-Ice-Lake-Server-disabled.xml |7 + .../x86_64-cpuid-Ice-Lake-Server-enabled.xml | 10 + .../x86_64-cpuid-Ice-Lake-Server-guest.xml| 36 + .../x86_64-cpuid-Ice-Lake-Server

[libvirt] [PATCH 6/6] cpu_map: Drop pconfig from Icelake-Server CPU model

migration scenario stays broken (and there's nothing we can do about it): from any host to a host with libvirt < 5.10.0 and QEMU > 3.1.0. https://bugzilla.redhat.com/show_bug.cgi?id=1749672 Signed-off-by: Jiri Denemark --- src/cpu_map/x86_Icelake-Server.xml| 1 - src/qemu/qemu_do

[libvirt] [PATCH 1/6] cpu_conf: Pass policy to CPU feature filtering callbacks

Signed-off-by: Jiri Denemark --- src/conf/cpu_conf.c | 6 +++--- src/conf/cpu_conf.h | 1 + src/cpu/cpu_x86.c| 13 - src/cpu/cpu_x86.h| 2 ++ src/qemu/qemu_capabilities.c | 1 + src/qemu/qemu_capabilities.h | 1 + 6 files changed, 20

[libvirt] [PATCH 2/6] qemuxml2*test: Add tests for Icelake-Server, -pconfig

Signed-off-by: Jiri Denemark --- ...u-Icelake-Server-pconfig.x86_64-3.1.0.args | 34 +++ ...-Icelake-Server-pconfig.x86_64-latest.args | 34 +++ .../cpu-Icelake-Server-pconfig.xml| 22 tests/qemuxml2argvtest.c | 3

[libvirt] [PATCH 4/6] cpu_map: Drop comments about ospke

QEMU does not support setting this feature on the command line anymore. We don't need to explain why it is not included in CPU models then. Signed-off-by: Jiri Denemark --- src/cpu_map/x86_Cascadelake-Server.xml | 2 -- src/cpu_map/x86_Icelake-Client.xml | 2 -- src/cpu_map/x86_Icelake

[libvirt] [PATCH 0/6] qemu: Fix "Property '.pconfig' not found" error

migration scenario stays broken (and there's nothing we can do about it): from any host to a host with libvirt < 5.10.0 and QEMU > 3.1.0. https://bugzilla.redhat.com/show_bug.cgi?id=1749672 Jiri Denemark (6): cpu_conf: Pass policy to CPU feature filtering callbacks qemuxml2*test: Add tests for I

[libvirt] [PATCH 3/6] qemu: Drop disabled CPU features unknown to QEMU

When a CPU definition wants to explicitly disable some features that are unknown to QEMU, we can safely drop them from the definition before starting QEMU. Naturally QEMU won't enable such features implicitly. Signed-off-by: Jiri Denemark --- src/qemu/qemu_process.c | 32

Re: [libvirt] [PATCH v3 00/52] qemu: Store default CPU in domain XML

On Fri, Nov 08, 2019 at 12:25:06 +0100, Christian Borntraeger wrote: > As discussed, does it make sense to add the default change to host-model for > s390 > in this series or should that be a separate patch? Originally I wanted to do it as a separate patch, but since no review has apparently

Re: [libvirt] [PATCH 5/5] news: Introduce virConnectSetIdentity API in 5.8

On Fri, Nov 08, 2019 at 15:00:22 +0800, Han Han wrote: > Signed-off-by: Han Han > --- > docs/news.xml | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/docs/news.xml b/docs/news.xml > index 571a1b6ea4..c37d0d22ef 100644 > --- a/docs/news.xml > +++ b/docs/news.xml > @@ -199,6

Re: [libvirt] [PATCHv2 2/2] util: set bridge device MAC address explicitly during virNetDevBridgeCreate

rMacAddr *mac ATTRIBUTE_UNUSED) > { > virReportSystemError(ENOSYS, > _("Unable to create bridge %s"), brname); > @@ -528,6 +554,7 @@ virNetDevBridgeDelete(const char *brname) > _("Unable to remove bridge %s&q

Re: [libvirt] [PATCHv2 1/2] util: allow sending mac addr to virNetNewLink without ifindex

virnetlink.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Reviewed-by: Jiri Denemark -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 REBASE 2 00/12] hostdev: handle usb detach/attach on node

Hi Dave, Time flies, doesn't it? :-) My reply is not related to this patch series, but rather your use case... On Thu, Oct 31, 2019 at 12:50:28 -0400, Dave Allan wrote: > My usecase is that I'm flashing the USB device with a program running > in the VM. I keep the VM running, and when I need

[libvirt] [PATCH v3 21/52] qemu: Store typename from query-cpu-definitions in qemuCaps

We need to create a mapping between CPU model names and their corresponding QOM types. Signed-off-by: Jiri Denemark Reviewed-by: Ján Tomko --- Notes: Version 2: - ignore empty typename strings Version 3: - g_strdup src/qemu/qemu_capabilities.c | 3

[libvirt] [PATCH v3 18/52] qemu: Switch qemuCaps to use qemuMonitorCPUDefs

We will need to keep some QEMU-specific data for each CPU model supported by a QEMU binary. Instead of complicating the generic virDomainCapsCPUModelsPtr, we can just directly store qemuMonitorCPUDefsPtr returned by the capabilities probing code. Signed-off-by: Jiri Denemark --- Notes

<    7   8   9   10   11   12   13   14   15   16   >