This capability is supported even in QEMU 3.1.0 which is the oldest
supported version of QEMU.
Jiri Denemark (2):
qemu: Simplify qemuProcessIncomingDef
qemu: Drop QEMU_CAPS_INCOMING_DEFER
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h
All QEMU releases currently supported by libvirt already understand
"-incoming defer". We can drop the code handling "-incoming URI".
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration.c | 3 +--
src/qemu/qemu_process.c | 22 +++---
src/qemu/qemu_pro
On Fri, Apr 01, 2022 at 15:27:32 +0200, Ján Tomko wrote:
> Prefer readability to brevity.
>
> Ján Tomko (4):
> tools: snapshot: remove pointless checks
> src: introduce VIR_UNLESS and VIR_ELSIF
> tools: use VIR_UNLESS more
> tools: use VIR_ELSIF more
Laughed-at-by: Jiri Denemark
The 8.2.0 release of both libvirt and libvirt-python is tagged and
signed tarballs and source RPMs are available at
https://libvirt.org/sources/
https://libvirt.org/sources/python/
Thanks everybody who helped with this release by sending patches,
reviewing, testing, or providing feedback.
; 1 file changed, 51 insertions(+)
Reviewed-by: Jiri Denemark
On Fri, Apr 01, 2022 at 10:44:22 +0200, Peter Krempa wrote:
> Signed-off-by: Peter Krempa
> ---
> NEWS.rst | 11 +++
> 1 file changed, 11 insertions(+)
>
Reviewed-by: Jiri Denemark
I have just tagged v8.2.0-rc2 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
ions
remained in src/qemu/qemu_domainjob.[ch], but still their prefix was
changed to "vir". Let's change it back to "qemu".
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_domainjob.c | 10 +-
src/qemu/qemu_domainjob.h | 4 ++--
src/qemu/qemu_migration.c | 2 +-
I have just tagged v8.2.0-rc1 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
ork.
>
> https://lists.gnu.org/archive/html/qemu-devel/2022-03/msg06077.html
>
> https://lists.gnu.org/archive/html/qemu-devel/2022-03/msg06188.html
Reviewed-by: Jiri Denemark
Start(virQEMUDriver *driver,
> if (!(pidfile = qemuTPMEmulatorPidFileBuildPath(cfg->swtpmStateDir,
> shortName)))
> return -1;
>
> +virCommandDoAsyncIO(cmd);
> virCommandDaemonize(cmd);
> virCommandSetPidFile(cmd, pidfile);
> virCommandSetErrorFD(cmd, &errfd);
> --
> 2.34.1
>
Reviewed-by: Jiri Denemark
We are getting close to the next release of libvirt. To aim for the
April Fools' release on Apr 01 I suggest entering the freeze on Monday
Mar 28 and tagging RC2 on Wednesday Mar 30.
I hope this works for everyone.
Jirka
lls the qemu driver from privateData.
>
> Signed-off-by: Kristina Hanicova
I would have split the patch as the qemuDomain{Obj,}SaveStatus change is
buried among the churn caused by removing driver parameter from
qemuDomainObjExitMonitor.
Anyway,
Reviewed-by: Jiri Denemark
and pushed.
Jirka
On Wed, Mar 02, 2022 at 09:43:24 +, Daniel P. Berrangé wrote:
> On Wed, Mar 02, 2022 at 08:42:30AM +0100, Erik Skultety wrote:
> > ...
> Ultimately when we switch to using merge requests, the integration tests
> should be run as a gating job, triggered from the merge train when the
> code gets
On Wed, Mar 02, 2022 at 09:49:35 +0100, Michal Prívozník wrote:
> On 3/2/22 00:21, Jim Fehlig wrote:
> > On 3/1/22 10:47, Boris Fiuczynski wrote:
> >> Commit 5adfb3472342741c443ac91dee0abb18b5a3d038 causes a segmentation
> >> fault.
>
> Pushed now. I believe, this warrants maintenance release. Jirk
The 8.1.0 release of both libvirt and libvirt-python is tagged and
signed tarballs and source RPMs are available at
https://libvirt.org/sources/
https://libvirt.org/sources/python/
Thanks everybody who helped with this release by sending patches,
reviewing, testing, or providing feedback.
I have just tagged v8.1.0-rc2 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
I have just tagged v8.1.0-rc1 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
Fixes the "GDBus.Error:org.freedesktop.DBus.Error.InvalidArgs: Invalid
unit name virt%sd.service" error for me, so
Reviewed-by: Jiri Denemark
The destination daemon would crash in Finish phase due to NULL
dereference which I missed in my review of commit
v8.0.0-428-g0301db44e2.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_migration.c b/src
We are getting close to the next release of libvirt. To aim for the
release on Mar 01 I suggest entering the freeze on Wednesday Feb 23 and
tagging RC2 on Friday Feb 25.
I hope this works for everyone.
Jirka
parate function for setting statsType of privateData
> libxl: use virDomainJobData instead of virDomainJobInfo
Reviewed-by: Jiri Denemark
And pushed. Thanks.
On Fri, Feb 11, 2022 at 15:16:35 +0100, Ján Tomko wrote:
> On a Friday in 2022, Jiri Denemark wrote:
> >On Fri, Feb 11, 2022 at 14:34:04 +0100, Jiri Denemark wrote:
> >> This partially reverts commit 0fc4a43d248b86fd54ad7323beb66faec8c1043c.
> >>
> &
On Fri, Feb 11, 2022 at 14:34:04 +0100, Jiri Denemark wrote:
> This partially reverts commit 0fc4a43d248b86fd54ad7323beb66faec8c1043c.
>
> Signed-off-by: Jiri Denemark
> ---
> tests/securityselinuxlabeltest.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
On Fri, Feb 11, 2022 at 14:26:12 +0100, Michal Prívozník wrote:
> On 2/11/22 13:39, Jiri Denemark wrote:
> > Otherwise devAddr.multi would be uninitialized.
> >
> > Signed-off-by: Jiri Denemark
> > ---
> > src/conf/node_device_conf.c | 2 +-
> > 1 f
.c | 6 +++---
> src/node_device/node_device_udev.c | 2 +-
> src/qemu/qemu_domain_address.c | 4 ++--
> src/util/virpci.c | 2 +-
> 7 files changed, 11 insertions(+), 14 deletions(-)
Reviewed-by: Jiri Denemark
This partially reverts commit 0fc4a43d248b86fd54ad7323beb66faec8c1043c.
Signed-off-by: Jiri Denemark
---
tests/securityselinuxlabeltest.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/securityselinuxlabeltest.c b/tests/securityselinuxlabeltest.c
index dfe9d38d34
All callers currently guarantee flags passed to virDomainObjGetMessages
are either zero or contain at least one of the supported flags. But it
doesn't mean we should not check for the possibility an unknown flag was
the only one passed to virDomainObjGetMessages.
Signed-off-by: Jiri Den
Otherwise devAddr.multi would be uninitialized.
Signed-off-by: Jiri Denemark
---
src/conf/node_device_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
index 61c8715037..eaa42c05ee 100644
--- a/src/conf
Jiri Denemark (2):
qemu_migration_cookie: Rename ret in qemuDomainExtractTLSSubject
qemu_migration_cookie: Properly fetch cert DN
src/qemu/qemu_migration_cookie.c | 34
1 file changed, 21 insertions(+), 13 deletions(-)
--
2.35.0
On Thu, Feb 10, 2022 at 17:03:01 +0100, Ján Tomko wrote:
> On a Thursday in 2022, Jiri Denemark wrote:
> >If 1024 was not enough to fit the DN, gnutls_x509_crt_get_dn would store
> >the required size in subjectlen. And since we're not checking the return
> >value of this
We use 'ret' for storing values to be returned from a function. Return
values from called functions that are not supposed to be returned
further are usually called 'rv' (or 'rc').
Signed-off-by: Jiri Denemark
Reviewed-by: Ján Tomko
---
Notes:
Version
If 1024 was not enough to fit the DN, gnutls_x509_crt_get_dn would store
the required size in subjectlen. And since we're not checking the return
value of this function, we would happily overwrite some random memory.
Signed-off-by: Jiri Denemark
---
Notes:
Version 2:
- do not pass
If 1024 was not enough to fit the DN, gnutls_x509_crt_get_dn would store
the required size in subjectlen. And since we're not checking the return
value of this function, we would happily overwrite some random memory.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration_cookie.c
We use 'ret' for storing values to be returned from a function. Return
values from called functions that are not supposed to be returned
further are usually called 'rv' (or 'rc').
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration_cookie.c | 14 +++---
Jiri Denemark (2):
qemu_migration_cookie: Rename ret in qemuDomainExtractTLSSubject
qemu_migration_cookie: Properly fetch cert DN
src/qemu/qemu_migration_cookie.c | 35 +++-
1 file changed, 21 insertions(+), 14 deletions(-)
--
2.35.1
Tests testVirPCIVPDReadVPDBytes and testVirPCIVPDParseFullVPDInvalid
failed to properly close open fildescriptors in some cases. Let's fix it
by switching to VIR_AUTOCLOSE in the whole file.
Signed-off-by: Jiri Denemark
---
tests/virpcivpdtest.c | 23 ---
1 file chang
On Wed, Feb 09, 2022 at 14:28:29 +0100, Michal Prívozník wrote:
> On 2/9/22 10:39, Daniel P. Berrangé wrote:
> > On Tue, Feb 08, 2022 at 12:22:36PM +0100, Michal Privoznik wrote:
> >> In one of my previous commits, I've changed an XPath in
> >> virCPUDefParseXML() from "boolean(./counter...)" to
>
Older kernels did not support this sysctl, but did not restrict
userfaultfd in any way so everything worked as if
vm.unprivileged_userfaultfd was set to 1. Thus we can safely ignore
errors when setting the value.
Signed-off-by: Jiri Denemark
---
src/qemu/postcopy-migration.sysctl | 2 +-
1 file
; Signed-off-by: Kristina Hanicova
> ---
> src/libxl/libxl_domain.c | 10 +-
> src/libxl/libxl_domain.h | 3 ++-
> src/libxl/libxl_driver.c | 14 +-
> 3 files changed, 16 insertions(+), 11 deletions(-)
Reviewed-by: Jiri Denemark
On Thu, Jan 20, 2022 at 17:59:48 +0100, Kristina Hanicova wrote:
> This patch includes:
> * introducing new files: src/hypervisor/domain_job.c and
> src/hypervisor/domain_job.h
> * new struct virDomainJobData, which is almost the same as
> qemuDomainJobInfo - the only differences are moving qemu
On Thu, Jan 20, 2022 at 17:59:49 +0100, Kristina Hanicova wrote:
> We only need to set statsType in almost every case of setting
> something from private data, so it seems unnecessary to pull
> privateData out of current / completed job for just this one
> thing every time. I think this patch keeps
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_domainjob.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_domainjob.c b/src/qemu/qemu_domainjob.c
index c8fe8ad555..1ecde5af86 100644
--- a/src/qemu/qemu_domainjob.c
+++ b/src/qemu/qemu_domainjob.c
The 8.0.0 release of both libvirt and libvirt-python is tagged and
signed tarballs and source RPMs are available at
https://libvirt.org/sources/
https://libvirt.org/sources/python/
Thanks everybody who helped with this release by sending patches,
reviewing, testing, or providing feedback.
> chain
> +when taking an external snapshot, or the target of a block copy operation
> +now enables sub-cluster allocation (``extended_l2``) if the original
> +image has the option enabled.
> +
> * **Bug fixes**
>
>* qemu: Fix device hot-unplug with ``lib
or later is installed
> and may not have any effect otherwise. The selection of PCR banks only
> works
> with the ``emulator`` backend. since:`Since 7.10.0`
Reviewed-by: Jiri Denemark
And safe for 8.0.0.
t's plugged
> into an
s/an TAP/a TAP/
> +OvS bridge values passed to the OvS were incorrectly recalculated
> resulting
> + in slightly different limits being applied.
> +
>
> v7.10.0 (2021-12-01)
>
Reviewed-by: Jiri Denemark
I have just tagged v8.0.0-rc2 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
I have just tagged v8.0.0-rc1 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
We are getting close to the next release of libvirt. To aim for the
release on Jan 14 I suggest entering the freeze on Monday Jan 10 and
tagging RC2 on Wednesday Jan 12.
I hope this works for everyone.
Jirka
On Wed, Dec 15, 2021 at 16:14:34 +0100, Jiri Denemark wrote:
> On Wed, Dec 15, 2021 at 18:37:21 +0530, Ani Sinha wrote:
> > Commit 52521de8332c2323bd ("qemu: Use qemuDomainSaveStatus") replaced a call
> > to virDomainObjSave() with qemuDomainSaveStatus() as a pa
s on vm %s", vm->def->name);
> +goto cleanup;
> +}
> } else {
> int detail = (start_paused ? VIR_DOMAIN_EVENT_SUSPENDED_PAUSED :
>VIR_DOMAIN_EVENT_SUSPENDED_RESTORED);
Oops, I apparently overlooked the goto statement here.
Signed-off-by: Jiri Denemark
And its callers. The parameter is no longer used since virDomainObjSave
was replaced with qemuDomainSaveStatus wrapper.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_domain.c | 3 +--
src/qemu/qemu_domain.h | 3 +--
src/qemu/qemu_driver.c | 14 +++---
src/qemu/qemu_process.c | 13
It is a nice wrapper around virDomainObjSave which logs a warning, but
otherwise ignores the error. Let's use it where appropriate.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_domain.c| 11 ++---
src/qemu/qemu_migration.c | 9 +
src/qemu/qemu_process.c
Jiri Denemark (2):
qemu: Use qemuDomainSaveStatus
qemu: Drop driver parameter from qemuDomainSetFakeReboot
src/qemu/qemu_domain.c| 12 ++---
src/qemu/qemu_domain.h| 3 +-
src/qemu/qemu_driver.c| 14 +++---
src/qemu/qemu_migration.c | 9 +---
src/qemu/qemu_process.c | 98
n_systemd_preun virtlockd
>
> %postun daemon
> /bin/systemctl daemon-reload >/dev/null 2>&1 || :
Reviewed-by: Jiri Denemark
So far we were enabling specific migration capabilities when a
corresponding API flag is set. We need to generalize our code to be able
to enable some migration capabilities unless a particular API flag is
used.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration_params.c | 33
t, because our tunnel
only allows one-way communication from the source to the destination.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration_params.c | 6 ++
src/qemu/qemu_migration_params.h | 1 +
2 files changed, 7 insertions(+)
diff --git a/src/qemu/qemu_migration_params.c
See 2/2 for more details about the capability.
Jiri Denemark (2):
qemu: Support enabling migration caps unless a flag is used
qemu: Add support for return-path migration capability
src/qemu/qemu_migration_params.c | 39
src/qemu/qemu_migration_params.h | 1
_COMPARE_IDENTICAL) {
While at it you could have placed VIR_CPU_COMPARE_IDENTICAL at the end
of the previous line.
> VIR_DEBUG("Outdated capabilities for '%s': host cpuid changed",
>qemuCaps->binary);
Reviewed-by: Jiri Denemark
Userfaultfd is by default allowed only for privileged processes. Since
libvirt runs QEMU unprivileged, we need to enable unprivileged access to
userfaultfd to enable post-copy migration.
https://bugzilla.redhat.com/show_bug.cgi?id=1945420
Signed-off-by: Jiri Denemark
---
Notes:
If you
On Tue, Dec 07, 2021 at 09:41:32 +, Daniel P. Berrangé wrote:
> On Tue, Dec 07, 2021 at 10:19:42AM +0100, Jiri Denemark wrote:
> > Userfaultfd is by default allowed only for privileged processes. Since
> > libvirt runs QEMU unprivileged, we need to enable unprivileged access to
-copy migration is requested. This way
unprivileged_userfaultfd is only enabled once actually used.
https://bugzilla.redhat.com/show_bug.cgi?id=1945420
Signed-off-by: Jiri Denemark
---
Notes:
Version 2:
- setting unprivileged_userfaultfd only when it is not already enabled
-copy migration is requested. This way
unprivileged_userfaultfd is only enabled once actually used.
https://bugzilla.redhat.com/show_bug.cgi?id=1945420
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration_params.c | 25 +
1 file changed, 25 insertions(+)
diff --git a
The 7.10.0 release of both libvirt and libvirt-python is tagged and
signed tarballs and source RPMs are available at
https://libvirt.org/sources/
https://libvirt.org/sources/python/
Thanks everybody who helped with this release by sending patches,
reviewing, testing, or providing feedback
t; wireshark: Drop needless comment in dissect_xdr_bytes()
>
> tools/wireshark/src/packet-libvirt.c | 32 +++-
> 1 file changed, 8 insertions(+), 24 deletions(-)
>
Reviewed-by: Jiri Denemark
I have just tagged v7.10.0-rc2 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
Signed-off-by: Jiri Denemark
---
src/rpc/virnetserver.c | 64 +++-
src/rpc/virnetserverclient.h | 2 ++
2 files changed, 28 insertions(+), 38 deletions(-)
diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c
index f016f15f39..d0f248e7f5 100644
uld be too long, we can drop the "-worker" part and just keep it
as "rpc-*" and "prio-rpc-*".
Such confusing entries can, for example, be found in audit log when
SELinux is complaining that "rpc-worker" was denied access to something.
Signed-off-by: Jir
Jiri Denemark (4):
virthreadpool: Copy job name
virnetserver: Format functions consistently
virnetserver: Use autoptr for virNetServer and virNetServerClient
virnetserver: Make pool job name less generic
src/rpc/virnetserver.c | 247 ---
src/rpc
igned-off-by: Jiri Denemark
---
src/rpc/virnetserver.c | 180 +
1 file changed, 112 insertions(+), 68 deletions(-)
diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c
index c7b4939398..f016f15f39 100644
--- a/src/rpc/virnetserver.c
+++ b/sr
Currently virThreadPoolNewFull relies on the caller to ensure the job
name outlives the thread pool. Which basically enforces static strings.
Let's drop this implicit requirement by making a copy of the job name.
Signed-off-by: Jiri Denemark
---
src/util/virthreadpool.c | 5 +++--
1
I have just tagged v7.10.0-rc1 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
On Wed, Nov 24, 2021 at 09:15:44 +, Daniel P. Berrangé wrote:
> On Wed, Nov 24, 2021 at 10:11:44AM +0100, Jiri Denemark wrote:
> > On Wed, Nov 24, 2021 at 10:06:12 +0100, Michal Prívozník wrote:
> > > On 11/23/21 19:04, Daniel P. Berrangé wrote:
> > > > If
On Wed, Nov 24, 2021 at 10:06:12 +0100, Michal Prívozník wrote:
> On 11/23/21 19:04, Daniel P. Berrangé wrote:
> > If we can report whuether TPM is available, then mgmt apps can enable it
> > by default for new VMs. This is important because OS like Win11 consider
> > TPM to be mandatory.
> >
> >
| 11 +--
> src/qemu/qemu_domain_address.c | 11 +--
> src/qemu/qemu_domainjob.c | 3 +--
> src/qemu/qemu_driver.c | 32
> 9 files changed, 42 insertions(+), 46 deletions(-)
Reviewed-by: Jiri Denemark
We are getting close to the next release of libvirt. To aim for the
release on Dec 01 I suggest entering the freeze on Thursday Nov 25 and
tagging RC2 on Monday Nov 29.
I hope this works for everyone.
Jirka
-aa-helper.c
> @@ -1438,7 +1438,7 @@ main(int argc, char **argv)
> char *profile = NULL;
> char *include_file = NULL;
> off_t size;
> -bool purged = 0;
> +bool purged = false;
>
> if (virGettextInitialize() < 0 ||
> virErrorInitialize() < 0) {
Reviewed-by: Jiri Denemark
It won't cause any harm as cpus is NULL when we pass a negative ncpus,
but doing so when the function expects unsigned value is not right.
Signed-off-by: Jiri Denemark
---
src/conf/capabilities.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/conf/capabilities.c b/src
The return value was not properly checked in the code for input type
evdev.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_command.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 45278c7108..483041f584
Signed-off-by: Jiri Denemark
---
src/util/virnetdevopenvswitch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitch.c
index 250726a633..5dab545037 100644
--- a/src/util/virnetdevopenvswitch.c
+++ b/src/util
The 7.9.0 release of both libvirt and libvirt-python is tagged and
signed tarballs and source RPMs are available at
https://libvirt.org/sources/
https://libvirt.org/sources/python/
Thanks everybody who helped with this release by sending patches,
reviewing, testing, or providing feedback.
k hook wasn't
> + called upon removal of interface after domain shut off itself. With this
> + release the bug is fixed.
> +
> +
> v7.8.0 (2021-10-01)
> ===
Reviewed-by: Jiri Denemark
On Wed, Oct 27, 2021 at 15:38:22 +0100, Daniel P. Berrangé wrote:
> On Wed, Oct 27, 2021 at 03:58:29PM +0200, Jiri Denemark wrote:
> > The curl block driver is no longer a requirement for qemu-kvm package in
> > RHEL-9, which breaks support for https network disks. Let
I have just tagged v7.9.0-rc2 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
https://bugzilla.redhat.com/show_bug.cgi?id=2014229
Signed-off-by: Jiri Denemark
---
libvirt.spec.in | 4
1 file changed, 4 insertions(+)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 4ecb28114c..b71888653d 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -791,6 +791,10 @@ Req
I have just tagged v7.9.0-rc1 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
g long.
Signed-off-by: Jiri Denemark
---
src/storage_file/storage_file_probe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/storage_file/storage_file_probe.c
b/src/storage_file/storage_file_probe.c
index f5bb8b7dbb..dc438a5e5d 100644
--- a/src/storage_file/storage_file_p
One of the paths returned -1 directly without going through the cleanup
section.
Signed-off-by: Jiri Denemark
---
src/node_device/node_device_udev.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/src/node_device/node_device_udev.c
b/src/node_device
It's only used once and open coding it is at least as clear as using the
macro.
Signed-off-by: Jiri Denemark
---
src/internal.h | 2 --
src/util/virutil.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/internal.h b/src/internal.h
index e1250a59fe..d3809
We are getting close to the next release of libvirt. To aim for the
release on Nov 01 I suggest entering the freeze on Tuesday Oct 26 and
tagging RC2 on Friday Oct 29.
I hope this works for everyone.
Jirka
On Tue, Oct 05, 2021 at 14:30:43 +, Simon Rowe wrote:
> I see that cancellation of core dump jobs that are memory-only are explicitly
> rejected
>
>
> >>> d.abortJob()
>
> libvirt: QEMU Driver error : Requested operation is not valid: cannot abort
> memory-only dump
>
> Traceback (most re
On Fri, Oct 08, 2021 at 10:01:45 +0100, Daniel P. Berrangé wrote:
> The "canonical CPU features" capability is a derivative of the
> "unavailable features" capability, which is exposed when seeing
> the "max" CPU models has the "unavailable-features" property.
>
> This property was actually added
/hyperv.x86_64-4.0.0.args | 2 +-
> tests/qemuxml2argvdata/hyperv.x86_64-latest.args| 2 +-
> 5 files changed, 7 insertions(+), 7 deletions(-)
Reviewed-by: Jiri Denemark
oQEMU(qemuCaps,
cpu->features[i].name);
or just put the all on a single line.
Anyway, nicely separated patch which makes it obvious removing the
function did not have unexpected side effects.
Reviewed-by: Jiri Denemark
ture" syntax,
> given the current minimum QEMU version.
>
> Signed-off-by: Daniel P. Berrangé
Reviewed-by: Jiri Denemark
>
> Signed-off-by: Daniel P. Berrangé
> ---
> src/qemu/qemu_command.c | 8 +---
> tests/qemuxml2argvdata/hyperv.x86_64-4.0.0.args | 2 +-
> 2 files changed, 2 insertions(+), 8 deletions(-)
Reviewed-by: Jiri Denemark
aliases for feature names with underscores
>
> Libvirt names use underscores so we conditionally tranlate the
> names when talking to new QEMU. Since the min QEMU was raised to
> version 2.11.0, all QEMU versions we talk to expect hypens, so
> the translation can be done unconditionally.
Reviewed-by: Jiri Denemark
On Fri, Oct 08, 2021 at 12:56:24 +0200, Michal Prívozník wrote:
> On 10/8/21 12:44 PM, Jiri Denemark wrote:
> > On Fri, Oct 08, 2021 at 10:19:04 +0200, Kristina Hanicova wrote:
> >> We did not set priv->migMaxBandwidth if '--bandwidth' was
> >> specified as
width = resource;
instead? It's not on a single line, but the else branch is quite
redundant. Not a big deal, though.
Reviewed-by: Jiri Denemark
601 - 700 of 7327 matches
Mail list logo
