Re: [libvirt] [PATCH] Ignore failure to mount SELinux filesystem in container

On Tue, Jul 02, 2013 at 11:21:59 +0100, Daniel Berrange wrote: From: Daniel P. Berrange berra...@redhat.com User namespaces will deny the ability to mount the SELinux filesystem. This is harmless for libvirt's LXC needs, so the error can be ignored. Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH] Add some misc debugging to LXC startup

On Tue, Jul 02, 2013 at 11:22:11 +0100, Daniel Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Add some debug logging of LXC wait/continue messages and uid/gid map update code. --- src/lxc/lxc_container.c | 4 src/lxc/lxc_controller.c | 2 ++ 2 files changed, 6

Re: [libvirt] [PATCH 1/3] qemu: Move memory limit computation to a reusable function

On Tue, Jul 02, 2013 at 12:34:44 +0200, Paolo Bonzini wrote: Il 02/07/2013 08:34, Jiri Denemark ha scritto: I'm not sure if that's the right think to do or not but it's certainly better than before when memory locking limit completely ignore the need for VRAM and per-disk cache

Re: [libvirt] [PATCH 2/2] qemu: Allow seamless migration for domains with multiple graphics

On Wed, Jul 03, 2013 at 12:10:23 +0100, Daniel Berrange wrote: On Tue, Jul 02, 2013 at 03:46:01PM +0200, Martin Kletzander wrote: Since commit 23e8b5d8, the code is refactored in a way that supports domains with multiple graphics elements and commit 37b415200 allows starting such domains.

Re: [libvirt] [PATCH] conf: don't check hyperv spinlock retries if disabled

On Thu, Jul 04, 2013 at 13:40:42 +0200, Jano Tomko wrote: hyperv spinlocks state='off'/ /hyperv results in: error: XML error: missing HyperV spinlock retry count Don't require retries when state is off and use virXPathUInt instead of virXPathString to simplify parsing.

[libvirt] [PATCH] Fix NULL dereference caused by ACL filtering of domains

Caused by 763973607ddace04562da1a1e545ab6692d5175f. --- src/libxl/libxl_driver.c | 3 ++- src/qemu/qemu_driver.c | 6 -- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 1bae3d6..ededbbc 100644 ---

Re: [libvirt] [PATCH] Fix NULL dereference caused by ACL filtering of domains

On Thu, Jul 04, 2013 at 16:19:15 +0100, Daniel Berrange wrote: On Thu, Jul 04, 2013 at 05:02:00PM +0200, Jiri Denemark wrote: Caused by 763973607ddace04562da1a1e545ab6692d5175f. --- src/libxl/libxl_driver.c | 3 ++- src/qemu/qemu_driver.c | 6 -- 2 files changed, 6 insertions

[libvirt] [PATCH] Paused domain should remain paused after migration

https://bugzilla.redhat.com/show_bug.cgi?id=981139 If a domain is paused before migration starts, we need to tell that to the destination libvirtd to prevent it from resuming the domain at the end of migration. This regression was introduced by commit 5379bb0. --- src/libvirt.c | 22

[libvirt] [PATCH] Don't spam logs with port 0 must be in range errors

Whenever virPortAllocatorRelease is called with port == 0, it complains that the port is not in an allowed range, which is expectable as the port was never allocated. Let's make virPortAllocatorRelease ignore 0 ports in a similar way free() ignores NULL pointers. --- src/qemu/qemu_migration.c |

[libvirt] [PATCH] qemu: Release correct websocket port

--- src/qemu/qemu_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index df0ac72..114e885 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -4222,7 +4222,7 @@ retry: } if

Re: [libvirt] [PATCH] Paused domain should remain paused after migration

On Mon, Jul 08, 2013 at 08:58:02 +0200, Peter Krempa wrote: On 07/04/13 20:13, Jiri Denemark wrote: https://bugzilla.redhat.com/show_bug.cgi?id=981139 If a domain is paused before migration starts, we need to tell that to the destination libvirtd to prevent it from resuming the domain

Re: [libvirt] [PATCH] qemu: Release correct websocket port

On Mon, Jul 08, 2013 at 08:55:31 +0200, Peter Krempa wrote: On 07/04/13 21:45, Jiri Denemark wrote: --- src/qemu/qemu_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ACK. Peter Pushed, thanks. Jirka -- libvir-list mailing list libvir-list@redhat.com https

Re: [libvirt] [PATCH] Don't spam logs with port 0 must be in range errors

On Fri, Jul 05, 2013 at 09:46:26 +0200, Michal Privoznik wrote: On 04.07.2013 21:46, Jiri Denemark wrote: Whenever virPortAllocatorRelease is called with port == 0, it complains that the port is not in an allowed range, which is expectable as the port was never allocated. Let's make

Re: [libvirt] [PATCH 0/3] qemu: Make setting memory limits consistent

On Fri, Jun 28, 2013 at 17:04:27 +0200, Jiri Denemark wrote: We need to set memory limits in several cases: - when setting hard_limit in memory cgroup - when starting a domain with a VFIO PCI device attached - when hotplugging a VFIO PCI device - when memoryBacking/locked is used

[libvirt] [PATCH] qemu: Slightly increase memory limit

For low-memory domains (roughly under 400MB) our automatic memory limit computation comes up with a limit that's too low. This is because the 0.5 multiplication does not add enough for such small values. Let's increase the constant part of the computation to fix this. --- src/qemu/qemu_domain.c |

Re: [libvirt] [PATCH] qemu: Slightly increase memory limit

On Tue, Jul 09, 2013 at 14:56:05 -0400, Laine Stump wrote: On 07/08/2013 09:20 AM, Jiri Denemark wrote: For low-memory domains (roughly under 400MB) our automatic memory limit computation comes up with a limit that's too low. This is because the 0.5 multiplication does not add enough

Re: [libvirt] [PATCH v3 00/10] Re-enable memballoon driver statistics reporting

On Thu, Jul 11, 2013 at 19:55:50 -0400, John Ferlan wrote: This patch set replaces: https://www.redhat.com/archives/libvir-list/2013-July/msg00435.html Changes 07 - 09- Remove the flags, Flags, FLAGS (learned something new!) Just remember to do the same in the subject of those patches

[libvirt] [PATCH 09/12] Add virDomainDefFindDevice for looking up a device by its alias

--- src/conf/domain_conf.c | 41 + src/conf/domain_conf.h | 4 src/libvirt_private.syms | 1 + 3 files changed, 46 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 602c9a6..1520ec5 100644 ---

[libvirt] [PATCH 06/12] qemu: Separate controller removal into a standalone function

--- src/qemu/qemu_hotplug.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 6db789d..0093245 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -2139,6 +2139,28 @@

[libvirt] [PATCH 11/12] qemu: Remove devices only after DEVICE_DELETED event

--- src/qemu/qemu_domain.h | 2 + src/qemu/qemu_hotplug.c | 101 +--- src/qemu/qemu_hotplug.h | 3 ++ src/qemu/qemu_process.c | 41 4 files changed, 142 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_domain.h

[libvirt] [PATCH 07/12] qemu: Separate net device removal into a standalone function

--- src/qemu/qemu_hotplug.c | 101 +--- 1 file changed, 62 insertions(+), 39 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 0093245..26a6d42 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@

[libvirt] [PATCH 05/12] qemu: Separate disk device removal into a standalone function

--- src/qemu/qemu_driver.c | 31 +--- src/qemu/qemu_hotplug.c | 127 ++-- src/qemu/qemu_hotplug.h | 4 +- 3 files changed, 73 insertions(+), 89 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 495867a..436ce6a

[libvirt] [PATCH 04/12] qemu: Add qemuDomainReleaseDeviceAddress to remove any address

--- src/qemu/qemu_command.c | 35 --- src/qemu/qemu_command.h | 8 +++--- src/qemu/qemu_hotplug.c | 75 - 3 files changed, 47 insertions(+), 71 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index

[libvirt] [PATCH 02/12] examples: Handle VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED event

--- examples/domain-events/events-c/event-test.c | 23 +- examples/domain-events/events-python/event-test.py | 4 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/examples/domain-events/events-c/event-test.c

[libvirt] [PATCH 00/12] Remove devices only after DEVICE_DELETED event

wanted to get some feedback on this series as soon as possible. Path 3/12 explains how I decided to deal with backward compatibility of the virDomainDetachDeviceFlags API. No libvirt client/app should see any real difference in behavior after this series unless they want to. Jiri Denemark (12

[libvirt] [PATCH 08/12] qemu: Separate host device removal into a standalone function

--- src/qemu/qemu_hotplug.c | 240 1 file changed, 142 insertions(+), 98 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 26a6d42..169cce2 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@

[libvirt] [PATCH 12/12] qemu: Emit VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED events

--- src/qemu/qemu_hotplug.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 8c2f756..ea62e71 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -2105,6 +2105,7 @@

[libvirt] [PATCH 10/12] qemu: Add support for DEVICE_DELETED event

--- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_monitor.c | 13 + src/qemu/qemu_monitor.h | 5 + src/qemu/qemu_monitor_json.c | 15 +++ 5 files changed, 36 insertions(+) diff --git a/src/qemu/qemu_capabilities.c

[libvirt] [PATCH 01/12] Add VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED event

--- daemon/remote.c | 32 + include/libvirt/libvirt.h.in | 18 python/libvirt-override-virConnect.py | 9 python/libvirt-override.c | 52 - src/conf/domain_event.c | 85

[libvirt] [PATCH 03/12] Clarify virDomainDetachDeviceFlags documentation

--- src/libvirt.c | 12 1 file changed, 12 insertions(+) diff --git a/src/libvirt.c b/src/libvirt.c index 4dc91d7..860188b 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -10825,6 +10825,18 @@ error: * block copy operation on the device being detached; in that case, * use

Re: [libvirt] [PATCH 11/12] qemu: Remove devices only after DEVICE_DELETED event

On Mon, Jul 15, 2013 at 18:25:58 +0100, Daniel Berrange wrote: On Mon, Jul 15, 2013 at 07:11:12PM +0200, Jiri Denemark wrote: --- src/qemu/qemu_domain.h | 2 + src/qemu/qemu_hotplug.c | 101 +--- src/qemu/qemu_hotplug.h | 3 ++ src

Re: [libvirt] [PATCH 3/4] cpu: Clean up code style

On Mon, Jul 15, 2013 at 18:24:46 +0200, Peter Krempa wrote: --- src/conf/cpu_conf.c | 4 ++-- src/cpu/cpu_x86.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) ACK Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1/4] conf: Clean up error reporting in cpu definition parsing

On Mon, Jul 15, 2013 at 18:24:44 +0200, Peter Krempa wrote: Use VIR_ERR_XML_ERROR instead of VIR_ERR_INTERNAL_ERROR in XML parsing code and move %s formating strings right after the error code. --- src/conf/cpu_conf.c | 74 ++--- 1 file

Re: [libvirt] [PATCH 2/4] cpu: Add virCPUDefUpdateFeature()

On Mon, Jul 15, 2013 at 18:24:45 +0200, Peter Krempa wrote: This new function updates or adds a feature to a existing cpu model definition. This function will be helpful to allow tuning of host-model features in later patches. --- src/conf/cpu_conf.c | 38

Re: [libvirt] [PATCH 4/4] cpu: Allow fine tuning of host-model cpu

On Mon, Jul 15, 2013 at 18:24:47 +0200, Peter Krempa wrote: https://bugzilla.redhat.com/show_bug.cgi?id=799354 Until now, the host-model cpu mode couldn't be influenced. This patch allows to use the feature elements to either enable or disable specific CPU flags. This can be used to force

Re: [libvirt] [PATCH 04/12] qemu: Add qemuDomainReleaseDeviceAddress to remove any address

On Tue, Jul 16, 2013 at 10:54:50 +0100, Daniel Berrange wrote: On Mon, Jul 15, 2013 at 07:11:05PM +0200, Jiri Denemark wrote: --- src/qemu/qemu_command.c | 35 --- src/qemu/qemu_command.h | 8 +++--- src/qemu/qemu_hotplug.c | 75

Re: [libvirt] [PATCH 05/12] qemu: Separate disk device removal into a standalone function

On Tue, Jul 16, 2013 at 10:56:13 +0100, Daniel Berrange wrote: On Mon, Jul 15, 2013 at 07:11:06PM +0200, Jiri Denemark wrote: --- src/qemu/qemu_driver.c | 31 +--- src/qemu/qemu_hotplug.c | 127 ++-- src/qemu/qemu_hotplug.h | 4

Re: [libvirt] [PATCH 08/12] qemu: Separate host device removal into a standalone function

On Tue, Jul 16, 2013 at 10:58:11 +0100, Daniel Berrange wrote: On Mon, Jul 15, 2013 at 07:11:09PM +0200, Jiri Denemark wrote: --- src/qemu/qemu_hotplug.c | 240 1 file changed, 142 insertions(+), 98 deletions(-) ACK Pushed, thanks

Re: [libvirt] [PATCH 07/12] qemu: Separate net device removal into a standalone function

On Tue, Jul 16, 2013 at 10:57:45 +0100, Daniel Berrange wrote: On Mon, Jul 15, 2013 at 07:11:08PM +0200, Jiri Denemark wrote: --- src/qemu/qemu_hotplug.c | 101 +--- 1 file changed, 62 insertions(+), 39 deletions(-) ACK Pushed, thanks

Re: [libvirt] [PATCH 06/12] qemu: Separate controller removal into a standalone function

On Tue, Jul 16, 2013 at 10:56:55 +0100, Daniel Berrange wrote: On Mon, Jul 15, 2013 at 07:11:07PM +0200, Jiri Denemark wrote: --- src/qemu/qemu_hotplug.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) ACK Pushed, thanks. Jirka -- libvir-list mailing

[libvirt] [PATCH] maint: Make ctags work out of the box

The .ctags file specifies default options for ctags so that it does not ignore libvirt.h.in and ignores uninteresting files. As a result, you can just run ctags and navigating to a public API won't get you to a useless entry in api.html. --- .ctags | 5 + 1 file changed, 5 insertions(+)

Re: [libvirt] [PATCH] maint: Make ctags work out of the box

On Wed, Jul 17, 2013 at 05:33:00 -0600, Eric Blake wrote: On 07/17/2013 05:10 AM, Jiri Denemark wrote: The .ctags file specifies default options for ctags so that it does not ignore libvirt.h.in and ignores uninteresting files. As a result, you can just run ctags and navigating to a public

[libvirt] [PATCH v2 3/8] examples: Handle VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED event

--- Notes: Already ACKed in version 1 Version 2: - no change examples/domain-events/events-c/event-test.c | 23 +- examples/domain-events/events-python/event-test.py | 4 2 files changed, 26 insertions(+), 1 deletion(-) diff --git

[libvirt] [PATCH v2 0/8] Remove devices only after DEVICE_DELETED event

This is a second version of the series updated according to the comments. It still does not check if any device finished unplug while libvirtd was not running but I'm working on it and it can be applied separately. Jiri Denemark (8): qemu: Separate char device removal into a standalone function

[libvirt] [PATCH v2 1/8] qemu: Separate char device removal into a standalone function

--- Notes: Version 2: - new patch src/qemu/qemu_hotplug.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 788ad47..f2dddc8 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@

[libvirt] [PATCH v2 6/8] qemu: Add support for DEVICE_DELETED event

--- Notes: Already ACKed in version 1 Version 2: - no change src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_monitor.c | 13 + src/qemu/qemu_monitor.h | 5 + src/qemu/qemu_monitor_json.c | 15 +++ 5

[libvirt] [PATCH v2 5/8] Add virDomainDefFindDevice for looking up a device by its alias

--- Notes: Already ACKed in version 1 Version 2: - no change src/conf/domain_conf.c | 41 + src/conf/domain_conf.h | 4 src/libvirt_private.syms | 1 + 3 files changed, 46 insertions(+) diff --git a/src/conf/domain_conf.c

[libvirt] [PATCH v2 8/8] qemu: Emit VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED events

--- Notes: Version 2: - update qemuhotplugtest to initialize domainEventState src/qemu/qemu_hotplug.c | 30 -- tests/qemuhotplugtest.c | 3 +++ 2 files changed, 31 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c

[libvirt] [PATCH v2 7/8] qemu: Remove devices only after DEVICE_DELETED event

--- Notes: Version 2: - DEVICE_DELETED event handler always removes the device - wait for up to 5 seconds after device_del returns to make async removal synchronous in normal cases src/qemu/qemu_domain.c | 4 ++ src/qemu/qemu_domain.h | 3 + src/qemu/qemu_hotplug.c | 159

[libvirt] [PATCH v2 2/8] Add VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED event

--- Notes: Already ACKed in version 1 Version 2: - no change daemon/remote.c | 32 + include/libvirt/libvirt.h.in | 18 python/libvirt-override-virConnect.py | 9 python/libvirt-override.c | 52

[libvirt] [PATCH v2 4/8] Clarify virDomainDetachDeviceFlags documentation

--- Notes: Version 2: - document limited waiting to make most async removal synchronous src/libvirt.c | 16 1 file changed, 16 insertions(+) diff --git a/src/libvirt.c b/src/libvirt.c index 0cdac0d..1f44a28 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -10889,6

Re: [libvirt] [PATCH v2 8/8] qemu: Emit VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED events

On Thu, Jul 18, 2013 at 11:44:20 +0100, Daniel Berrange wrote: On Thu, Jul 18, 2013 at 12:03:50PM +0200, Jiri Denemark wrote: --- Notes: Version 2: - update qemuhotplugtest to initialize domainEventState src/qemu/qemu_hotplug.c | 30 -- tests

Re: [libvirt] [PATCH v2 8/8] qemu: Emit VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED events

On Thu, Jul 18, 2013 at 12:01:21 +0100, Daniel Berrange wrote: Ok, I've re-read the earlier patches understand this now. ACK Thanks for the reviews. I pushed this series. Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 2/4] conf: Make error reporting in virDomainDefFindDevice optional

--- src/conf/domain_conf.c | 11 --- src/conf/domain_conf.h | 3 ++- src/qemu/qemu_process.c | 2 +- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 57cd9b1..308a96b 100644 --- a/src/conf/domain_conf.c +++

[libvirt] [PATCH 1/4] util: Non-existent string array does not contain any string

Make virStringArrayHasString return false when called on a non-existent string array. --- src/util/virstring.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/util/virstring.c b/src/util/virstring.c index 1f4850e..d11db5c 100644 --- a/src/util/virstring.c +++ b/src/util/virstring.c @@

[libvirt] [PATCH 0/3] Several cleanups for cpu driver

Jiri Denemark (3): cpu_x86: Use x86-specific CPU data structure Replace union cpuData with virCPUData cpu: Store arch in virCPUData src/cpu/cpu.c| 31 +++-- src/cpu/cpu.h| 62 - src/cpu/cpu_arm.c| 8 +- src/cpu/cpu_powerpc.c

[libvirt] [PATCH 0/4] qemu: Unplug devices that disappeared when libvirtd was down

In case libvirtd is asked to unplug a device but the device is actually unplugged later when libvirtd is not running, we need to detect that and remove such device when libvirtd starts again and reconnects to running domains. Jiri Denemark (4): util: Non-existent string array does not contain

[libvirt] [PATCH 2/3] Replace union cpuData with virCPUData

--- src/cpu/cpu.c| 22 +-- src/cpu/cpu.h| 51 ++-- src/cpu/cpu_arm.c| 8 +++ src/cpu/cpu_powerpc.c| 8 +++ src/cpu/cpu_s390.c | 8 +++ src/cpu/cpu_x86.c

[libvirt] [PATCH 3/4] qemu: Introduce qemuMonitorGetDeviceAliases

This API provides a NULL-terminated list of devices which are currently attached to a QEMU domain. --- src/qemu/qemu_monitor.c | 21 +++ src/qemu/qemu_monitor.h | 4 +++ src/qemu/qemu_monitor_json.c | 38 +++ src/qemu/qemu_monitor_json.h | 4 +++

[libvirt] [PATCH 4/4] qemu: Unplug devices that disappeared when libvirtd was down

In case libvirtd is asked to unplug a device but the device is actually unplugged later when libvirtd is not running, we need to detect that and remove such device when libvirtd starts again and reconnects to running domains. --- src/qemu/qemu_domain.c | 56

[libvirt] [PATCH 1/3] cpu_x86: Use x86-specific CPU data structure

--- src/cpu/cpu.h | 2 +- src/cpu/cpu_x86.c | 271 ++ 2 files changed, 173 insertions(+), 100 deletions(-) diff --git a/src/cpu/cpu.h b/src/cpu/cpu.h index cba7149..b2c02db 100644 --- a/src/cpu/cpu.h +++ b/src/cpu/cpu.h @@ -33,7 +33,7 @@

[libvirt] [PATCH 3/3] cpu: Store arch in virCPUData

--- src/cpu/cpu.c| 11 +-- src/cpu/cpu.h| 19 +++ src/cpu/cpu_powerpc.c| 4 ++-- src/cpu/cpu_x86.c| 34 -- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_command.c | 5 ++---

[libvirt] [PATCH] cpu: Let explicit features override model features

Until now CPU features inherited from a specified CPU model could only be overridden with 'disable' policy. With this patch, any explicitly specified feature always overrides the same feature inherited from a CPU model regardless on the specified policy. The CPU in x86-exact-force-Haswell.xml

[libvirt] [PATCH 4/3] Remove arch parameter from cpuHasFeature()

--- This patch should be squashed in 3/3. src/cpu/cpu.c| 10 -- src/cpu/cpu.h| 3 +-- src/qemu/qemu_command.c | 4 ++-- src/vmware/vmware_conf.c | 6 +++--- tests/cputest.c | 2 +- 5 files changed, 11 insertions(+), 14 deletions(-) diff --git

[libvirt] [PATCH 5/3] vmware: Fix bogus CPU arch copy

--- src/vmware/vmware_conf.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c index 7734872..23da92d 100644 --- a/src/vmware/vmware_conf.c +++ b/src/vmware/vmware_conf.c @@ -80,10 +80,7 @@ vmwareCapsInit(void) if

Re: [libvirt] [PATCH 4/4] qemu: Unplug devices that disappeared when libvirtd was down

On Mon, Jul 22, 2013 at 11:13:30 +0200, Peter Krempa wrote: On 07/19/13 19:00, Jiri Denemark wrote: In case libvirtd is asked to unplug a device but the device is actually unplugged later when libvirtd is not running, we need to detect that and remove such device when libvirtd starts again

Re: [libvirt] [PATCH 5/3] vmware: Fix bogus CPU arch copy

On Mon, Jul 22, 2013 at 11:30:33 +0200, Peter Krempa wrote: On 07/22/13 00:18, Jiri Denemark wrote: --- src/vmware/vmware_conf.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) ACK. Thanks, I pushed this series. Jirka -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] cpu: Let explicit features override model features

On Mon, Jul 22, 2013 at 13:41:44 +0200, Peter Krempa wrote: On 07/21/13 14:37, Jiri Denemark wrote: Until now CPU features inherited from a specified CPU model could only be overridden with 'disable' policy. With this patch, any explicitly specified feature always overrides the same feature

[libvirt] [PATCH] tests: Free test at the end of GetDeviceAliases JSON test

Commit 58b147ad07c9432b53e66ca20aff74d812647c57 added a test for qemuMonitorGetDeviceAliases but forgot to free the test object at the end which causes all sort of weird errors and failures when new tests are added after the GetDeviceAliases. --- tests/qemumonitorjsontest.c | 1 + 1 file changed,

Re: [libvirt] [PATCH] tests: Free test at the end of GetDeviceAliases JSON test

On Mon, Jul 22, 2013 at 16:19:18 +0200, Michal Privoznik wrote: On 22.07.2013 15:57, Jiri Denemark wrote: Commit 58b147ad07c9432b53e66ca20aff74d812647c57 added a test for qemuMonitorGetDeviceAliases but forgot to free the test object at the end which causes all sort of weird errors

Re: [libvirt] [Qemu-devel] [Question] why x2apic's set by default without host support(on Nehalem CPU).

On Tue, Jul 23, 2013 at 10:44:48 +0800, Peter Huang(Peng) wrote: libvirt's host-passthrough uses -cpu host', and it -cpu host enables every feature that can be enabled on the host. From my test results, I found that even when use host-passthrough mode, VM's cpu features are very different

Re: [libvirt] [PATCH] qemu: Take error path if acquiring of job fails in qemuDomainSaveInternal

On Tue, Jul 23, 2013 at 16:21:10 +0200, Peter Krempa wrote: Due to a goto statement missed when refactoring in 2771f8b74c1bf50d1fa when acquiring of a domain job failed the error path was not taken. This resulted into a crash afterwards as a extra reference was removed from a s/as a/as an/

[libvirt] [PATCH 0/7] Probe QEMU binary for host CPU and use it for computations

Since QEMU and kvm may filter some host CPU features or add efficiently emulated features, asking QEMU binary for host CPU data provides better results when we later use the data for building guest CPUs. Jiri Denemark (7): cpu: Add support for loading and storing CPU data cpu: Export few x86

[libvirt] [PATCH 6/7] qemu: Probe QEMU binary for host CPU

Since QEMU and kvm may filter some host CPU features or add efficiently emulated features, asking QEMU binary for host CPU data provides better results when we later use the data for building guest CPUs. --- src/qemu/qemu_capabilities.c | 44 +++-

[libvirt] [PATCH 1/7] cpu: Add support for loading and storing CPU data

--- src/cpu/cpu.c| 41 ++ src/cpu/cpu.h| 13 + src/cpu/cpu_x86.c| 135 +++ src/libvirt_private.syms | 2 + 4 files changed, 170 insertions(+), 21 deletions(-) diff --git a/src/cpu/cpu.c

[libvirt] [PATCH 4/7] qemu: Add monitor APIs to fetch CPUID data from QEMU

--- src/qemu/qemu_monitor.c| 21 +++ src/qemu/qemu_monitor.h| 3 + src/qemu/qemu_monitor_json.c | 162 + src/qemu/qemu_monitor_json.h | 6 + tests/Makefile.am

[libvirt] [PATCH 5/7] qemu: Make QMP probing process reusable

--- src/qemu/qemu_capabilities.c | 192 +++ 1 file changed, 120 insertions(+), 72 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 5dc3c9e..9440396 100644 --- a/src/qemu/qemu_capabilities.c +++

[libvirt] [PATCH 2/7] cpu: Export few x86-specific APIs

--- src/cpu/cpu_x86.c| 21 ++--- src/cpu/cpu_x86.h| 10 ++ src/libvirt_private.syms | 7 +++ 3 files changed, 35 insertions(+), 3 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 560a2a9..dbbcfd2 100644 --- a/src/cpu/cpu_x86.c +++

[libvirt] [PATCH 7/7] qemu: Use host CPU from QEMU for computations

Use the host CPU data probed by the current emulator when updating a guest CPU according to a host CPU or when checking whether they are compatible. --- src/qemu/qemu_command.c | 32 ++-- src/qemu/qemu_domain.c | 21 +++-- 2 files changed, 41

[libvirt] [PATCH 3/7] x86: Ignore CPUID functions greater than 10

We don't need to store any CPUID data for function we know nothing about. However, this limit may need to be increased in the future when libvirt learns features described by a CPUID function greater than 10. The comparison is done after subtracting high-bits prefix, so currently functions

Re: [libvirt] [PATCH 6/7] qemu: Probe QEMU binary for host CPU

On Tue, Jul 23, 2013 at 17:19:03 +0100, Daniel Berrange wrote: On Tue, Jul 23, 2013 at 06:11:35PM +0200, Jiri Denemark wrote: Since QEMU and kvm may filter some host CPU features or add efficiently emulated features, asking QEMU binary for host CPU data provides better results when we later

Re: [libvirt] [PATCH 1/7] cpu: Add support for loading and storing CPU data

On Tue, Jul 23, 2013 at 17:27:41 +0100, Daniel Berrange wrote: On Tue, Jul 23, 2013 at 06:11:30PM +0200, Jiri Denemark wrote: Could use a more verbose commit message. Looking at later patches, I see cpuDataFormat used in the test suite, but I don't see cpuDataParse used anywhere

Re: [libvirt] [PATCH 4/7] qemu: Add monitor APIs to fetch CPUID data from QEMU

On Tue, Jul 23, 2013 at 17:32:42 +0100, Daniel Berrange wrote: On Tue, Jul 23, 2013 at 06:11:33PM +0200, Jiri Denemark wrote: --- src/qemu/qemu_monitor.c| 21 +++ src/qemu/qemu_monitor.h| 3 + src/qemu/qemu_monitor_json.c

Re: [libvirt] [PATCH 4/7] qemu: Add monitor APIs to fetch CPUID data from QEMU

On Tue, Jul 23, 2013 at 19:28:38 +0200, Jiri Denemark wrote: On Tue, Jul 23, 2013 at 17:32:42 +0100, Daniel Berrange wrote: On Tue, Jul 23, 2013 at 06:11:33PM +0200, Jiri Denemark wrote: --- src/qemu/qemu_monitor.c| 21 +++ src/qemu/qemu_monitor.h

Re: [libvirt] [PATCH 1/3] qemu: handle new 'setup' migration state

On Fri, Jul 26, 2013 at 13:47:43 -0400, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com Previously, QEMU's 'setup' state was no a formal state in their state machine, but it is now. This state is used by RDMA to optionally perform memory pinning. This state is now

Re: [libvirt] [PATCH 2/3] qemu: RDMA migration support using 'x-rdma' URI

On Fri, Jul 26, 2013 at 13:47:44 -0400, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com QEMU has in tree now for version 1.6 support for RDMA Live migration. Full documenation of the feature: http://wiki.qemu.org/Features/RDMALiveMigration This patch includes

Re: [libvirt] [PATCH 1/1] cpu: Fix one compile error for PPC.

On Mon, Jul 29, 2013 at 15:41:19 +0800, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com CPU data structure is refined, which causes one compile error for PPC. Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com --- src/cpu/cpu_powerpc.c | 8 1 file changed, 4

Re: [libvirt] [PATCH 1/1] cpu: Fix one compile error for PPC.

On Mon, Jul 29, 2013 at 13:23:23 +0200, Jiri Denemark wrote: On Mon, Jul 29, 2013 at 15:41:19 +0800, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com CPU data structure is refined, which causes one compile error for PPC. Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com

[libvirt] [PATCH] spec: Cat test-suite.log if make check fails

Current automake enables parallel test by default, which means test details are only logged in test-suite.log and not printed to stderr. This patch makes test failures directly visible in RPM build logs even when parallel tests are turned on. --- libvirt.spec.in | 6 +- 1 file changed, 5

Re: [libvirt] [PATCH] spec: Cat test-suite.log if make check fails

On Mon, Jul 29, 2013 at 09:51:54 -0600, Eric Blake wrote: On 07/29/2013 09:44 AM, Jiri Denemark wrote: Current automake enables parallel test by default, which means test details are only logged in test-suite.log and not printed to stderr. This patch makes test failures directly visible

Re: [libvirt] [PATCH] Remove VIR_DOMAIN_SHUTDOWN_CRASHED from public API

On Mon, Jul 29, 2013 at 17:48:15 +0100, Daniel Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The VIR_DOMAIN_SHUTDOWN_CRASHED state constant does not appear to be used in the QEMU code anyway. It also doesn't make much (any) sense, since the 'shutdown' state is a transient

Re: [libvirt] [PATCH v2] Fix dbus message reading code on big endian hosts

On Mon, Jul 29, 2013 at 17:57:55 +0100, Daniel Berrange wrote: On Mon, Jul 29, 2013 at 10:46:25AM -0600, Eric Blake wrote: On 07/29/2013 10:40 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The way we were casting small (32bit) integers was broken on big

[libvirt] [PATCH] tests: Put a mock library at the start of LD_PRELOAD

This fixes vircgrouptest when run in a sandbox which already overrides open() and others. --- tests/testutils.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/testutils.h b/tests/testutils.h index 27af5da..8583747 100644 --- a/tests/testutils.h +++

Re: [libvirt] [PATCH] Delete obsolete / unused python test files

On Tue, Jul 30, 2013 at 11:27:58 +0100, Daniel Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The python/tests directory contains a number of so called tests for the python API. These are all hardcoded to look for Xen and cannot be run in any automated fashion, and no one is

[libvirt] [PATCH] spec: RHEL-7 does not have sanlock on i686

--- libvirt.spec.in | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 6236c08..e74f774 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -245,11 +245,16 @@ %if 0%{?fedora} = 16 %define with_sanlock

[libvirt] [PATCH] spec: Disable libssh2 support for RHEL

From: Peter Krempa pkre...@redhat.com https://bugzilla.redhat.com/show_bug.cgi?id=905513 Libssh2 isn't reliable enough to support the libvirt transport using it. The problems include mishandling of known_hosts files that may confuse users. --- libvirt.spec.in | 2 +- 1 file changed, 1

[libvirt] [PATCH] spec: Use --enable-werror on RHEL

As RHEL provides a stable tool chain, we don't have to worry about frequent changes in reported compiler warnings (which prevents us from enabling -Werror unconditionally). --- libvirt.spec.in | 9 + 1 file changed, 9 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index

[libvirt] [PATCH] spec: Don't mix commands with macro definitions

%build section should first define all required macros and then run commands. Interleaving them makes it harder to spot what commands are run. --- libvirt.spec.in | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 6d6203b..0fdba54

Re: [libvirt] [PATCH] spec: Don't mix commands with macro definitions

On Tue, Jul 30, 2013 at 08:55:53 -0600, Eric Blake wrote: On 07/30/2013 08:07 AM, Jiri Denemark wrote: %build section should first define all required macros and then run commands. Interleaving them makes it harder to spot what commands are run. --- libvirt.spec.in | 9 + 1

Re: [libvirt] [PATCH] spec: Disable libssh2 support for RHEL

On Tue, Jul 30, 2013 at 06:50:28 -0600, Eric Blake wrote: On 07/30/2013 05:45 AM, Jiri Denemark wrote: From: Peter Krempa pkre...@redhat.com https://bugzilla.redhat.com/show_bug.cgi?id=905513 Libssh2 isn't reliable enough to support the libvirt transport using it. The problems

<    1   2   3   4   5   6   7   8   9   10   >