On Thu, Jun 07, 2012 at 06:22:12 -0600, Eric Blake wrote:
On 06/07/2012 02:24 AM, Martin Kletzander wrote:
On 06/07/2012 05:32 AM, Eric Blake wrote:
The command 'make -C tests check' takes forever, because it is calling
this lengthy virsh command and ignoring the failures:
$ time
When libvirtd forks off a new child, the child then calls virLogReset(),
which ends up closing file descriptors used as log outputs. However, we
recently started logging closed file descriptors, which means we need to
lock logging mutex which was already logged by virLogReset(). We don't
really
On Thu, Jun 07, 2012 at 12:03:02 -0600, Eric Blake wrote:
On 06/05/2012 02:36 AM, Guannan Ren wrote:
Bugzilla:https://bugzilla.redhat.com/show_bug.cgi?id=822839
add two general virsh options to support keepalive message protocol
-i | --keepalive_interval interval time value (default 5
On Fri, Jun 08, 2012 at 10:19:37 +0200, Gerd Hoffmann wrote:
qemu 1.1 features a xhci controller,
this patch adds support for it.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
src/conf/domain_conf.c |3 ++-
src/conf/domain_conf.h |1 +
by one line than the current
broken version :-)
Jiri Denemark (12):
client rpc: Improve debug messages in virNetClientIO
client rpc: Use event loop for writing
client rpc: Don't drop non-blocking calls
client rpc: Just queue non-blocking call if another thread has the
buck
client rpc
As non-blocking calls are no longer dropped, we don't really need to
care that much about their faith and wait for the thread with the buck
to process them. If another thread has the buck, we can just push a
non-blocking call to the queue and be done with it.
---
src/rpc/virnetclient.c | 74
So far, we were dropping non-blocking calls whenever sending them would
block. In case a client is sending lots of stream calls (which are not
supposed to generate any reply), the assumption that having other calls
in a queue is sufficient to get a reply from the server doesn't work. I
tried to
Add virKeepAliveTimeout and virKeepAliveTrigger APIs that can be used to
set poll timeouts and trigger keepalive timer. virKeepAliveTrigger
checks if it is called to early and does nothing in that case.
---
src/rpc/virkeepalive.c | 61
When analyzing our debug log, I'm always confused about what each of the
pointers mean. Let's be explicit.
---
src/rpc/virnetclient.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c
index 14f806f..c62e045 100644
The code that needs to be run every keepalive interval of inactivity was
only called from a timer and thus from the main event loop. We will need
to call the code directly from another place.
---
src/rpc/virkeepalive.c | 57 +---
1 file changed, 35
This makes it possible to create and queue new calls while we are
running IO loop.
---
src/rpc/virnetclient.c | 85 ++--
1 file changed, 54 insertions(+), 31 deletions(-)
diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c
index
When a libvirt API is called from the main event loop (which seems to be
common in event-based glib apps), the client IO loop would properly
handle keepalive requests sent by a server but will not actually send
them because the main event loop is blocked with the API. This patch
gets rid of
As we never drop non-blocking calls, the return value that used to
indicate a call was dropped is no longer needed.
---
src/rpc/virnetclient.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c
index
The previous commit removed the only usage of ``all'' parameter in
virKeepAliveStopInternal, which was actually the only reason for having
virKeepAliveStopInternal. This effectively reverts most of commit
6446a9e20cc65561ce6061742baf35a3a63d5ba1.
---
src/libvirt_probes.d |2 +-
Normally, when every call has a thread associated with it, the thread
may get the buck and be in charge of sending all calls until its own
call is done. When we introduced non-blocking calls, we had to add
special handling of new non-blocking calls. This patch uses event loop
to send data if there
We don't need to add or remove filters when client object is already
locked anymore. There's no reason to keep the *Locked variants of those
APIs.
---
src/rpc/virnetserverclient.c | 39 ---
1 file changed, 12 insertions(+), 27 deletions(-)
diff --git
In addition to keepalive responses, we also need to send keepalive
requests from client IO loop to properly detect dead connection in case
a libvirt API call is called from the main loop, which prevents any
timers to be called.
---
src/rpc/virnetclient.c | 12
1 file changed, 12
On Wed, Jun 13, 2012 at 09:30:30 +0100, Daniel P. Berrange wrote:
On Wed, Jun 13, 2012 at 01:29:20AM +0200, Jiri Denemark wrote:
Normally, when every call has a thread associated with it, the thread
may get the buck and be in charge of sending all calls until its own
call is done. When we
On Wed, Jun 13, 2012 at 09:43:54 +0100, Daniel P. Berrange wrote:
On Wed, Jun 13, 2012 at 10:40:48AM +0200, Jiri Denemark wrote:
On Wed, Jun 13, 2012 at 09:30:30 +0100, Daniel P. Berrange wrote:
On Wed, Jun 13, 2012 at 01:29:20AM +0200, Jiri Denemark wrote:
Normally, when every call has
On Wed, Jun 13, 2012 at 10:54:02 +0100, Daniel P. Berrange wrote:
On Wed, Jun 13, 2012 at 01:29:18AM +0200, Jiri Denemark wrote:
In case a client is sending lots of stream calls (which are not supposed to
generate any reply), the assumption that having other calls in a queue is
sufficient
On Tue, Jul 03, 2012 at 16:58:40 +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The callback that is invoked when a new RPC client is
initialized does not have any opaque parameter. Add
one so that custom data can be passed into the callback
Signed-off-by:
On Tue, Jul 03, 2012 at 16:58:42 +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Currently the build of libvirt_lxc will cause recompilation
of all sources under src/util, src/conf, src/security and
more. Switch the libvirt_lxc process to link against the
On Tue, Jul 03, 2012 at 16:58:43 +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The LXC controller code is having to pass around an ever increasing
number of parameters between methods. To make the code more managable
introduce a virLXCControllerPtr to hold all
On Tue, Jul 03, 2012 at 16:58:41 +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Refactor the RPC server dispatcher code so that if 'max_workers==0'
the entire server will run single threaded. This is useful for
use cases where there will only ever be 1 client
On Tue, Jul 03, 2012 at 16:58:44 +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Move the veth device name state into the virLXCControllerPtr
object and stop passing it around. Also use size_t instead
of unsigned int for the array length parameters.
On Tue, Jul 03, 2012 at 16:58:45 +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Keep a record of the init PID in the virLXCController object
and create a virLXCControllerStopInit method for killing this
process
Signed-off-by: Daniel P. Berrange
On Wed, Jul 04, 2012 at 13:30:52 +0200, Peter Krempa wrote:
On 07/04/12 12:23, Peter Krempa wrote:
In vshSnapshotListCollect() vshCalloc was called with swapped nmemb and
size argument. This caused division by zero in xalloc_oversized as the
macro doesn't expect size to be zero.
---
On Tue, Jul 03, 2012 at 16:58:46 +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Turn 'struct lxc_console' into virLXCControllerConsolePtr and make it
a part of virLXCControllerPtr
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
On Tue, Jul 03, 2012 at 16:58:47 +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Keep the FD uses to handshake with the libvirtd daemon in the
s/uses/used/
virLXCControllerPtr object.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
On Tue, Jul 03, 2012 at 16:58:48 +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Move the list of loop device FDs into the virLXCControllerPtr
object and make sure that virLXCControllerStopInit will
close them all
Signed-off-by: Daniel P. Berrange
On Tue, Jul 03, 2012 at 16:58:49 +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Move the security manager object into the virLXCControllerPtr
object. Also simplify the code creating it in the first place
Signed-off-by: Daniel P. Berrange berra...@redhat.com
On Tue, Jul 03, 2012 at 16:58:50 +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The virLXCControllerRun method is getting a little too large,
and about 50% of its code is related to setting up a /dev/pts
mount. Move the latter out into a dedicated method
On Tue, Jul 03, 2012 at 16:58:51 +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Move the monitor FDs into the virLXCControllerPtr object
removing the need for the 'struct lxcMonitor' object
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
On Tue, Jul 03, 2012 at 16:58:53 +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
While it is not currently used elsewhere in libvirt, the code
for finding a free loop device associating a file with it
is not LXC specific. Move it into the viffile.{c,h} file
On Tue, Jul 03, 2012 at 16:58:52 +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Move the cgroup object into virLXCControllerPtr and rename
all the setup methods to include 'Cgroup' in their name
if appropriate
Signed-off-by: Daniel P. Berrange
On Tue, Jul 03, 2012 at 16:58:54 +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
In preparation for introducing a full RPC protocol for
libvirt_lxc, switch over to using the virNetServer APIs
for the monitor connection
Signed-off-by: Daniel P. Berrange
On Mon, Jul 09, 2012 at 14:18:58 +0200, Gerd Hoffmann wrote:
qemu 1.1 features a xhci controller,
this patch adds support for it.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
docs/formatdomain.html.in |4 ++--
docs/schemas/domaincommon.rng |1 +
src/conf/domain_conf.c
I know I'm late in this vendor_id stuff but it hasn't been released yet so I'm
not too late. I assume the reason for introducing it is to be able to lie to a
guest. Please, correct me, if this is not the case.
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index
On Wed, Jul 11, 2012 at 09:00:05 +0200, Hendrik Schwartke wrote:
On 10.07.2012 21:57, Jiri Denemark wrote:
I know I'm late in this vendor_id stuff but it hasn't been released yet so
I'm
not too late. I assume the reason for introducing it is to be able to lie
to a
guest. Please
When host CPU could not be properly detected, virConnectCompareCPU will
just report that any CPU is incompatible with host CPU instead of
failing.
---
src/qemu/qemu_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
When --direct is used when migrating a domain running on a hypervisor
that does not support direct migration (such as QEMU), the caller would
get the following error message:
this function is not supported by the connection driver:
virDomainMigrateToURI2
which is a complete nonsense
On Thu, Jul 12, 2012 at 10:58:12 -0400, Chuck Short wrote:
Adding CPU encoder/decoder for armhf to avoid runtime error messages.
Can you be more specific about the error messages you are trying to fix with
this patch?
Signed-off-by: Chuck Short chuck.sh...@canonical.com
---
src/Makefile.am
On Thu, Jul 12, 2012 at 13:39:02 -0500, Chuck Short wrote:
Adding CPU encoder/decoder for armhf to avoid runtime error messages.
I would still be interested in the exact error messages you get when you try
to start a domain on an arm machine without this patch :-)
Jirka
--
libvir-list mailing
On Thu, Jul 12, 2012 at 13:43:26 -0600, Eric Blake wrote:
On 07/12/2012 08:23 AM, Jiri Denemark wrote:
When --direct is used when migrating a domain running on a hypervisor
that does not support direct migration (such as QEMU), the caller would
get the following error message
Even though qemu-kvm binaries can be used in TCG mode, libvirt would
only detect them if /dev/kvm was available. Thus, one would need to make
a /usr/bin/qemu symlink to be able to use TCG mode with qemu-kvm in an
environment without KVM support.
And even though QEMU is able to make use of KVM,
On Fri, Jul 13, 2012 at 09:19:42 -0600, Eric Blake wrote:
On 07/13/2012 09:00 AM, Jiri Denemark wrote:
Even though qemu-kvm binaries can be used in TCG mode, libvirt would
only detect them if /dev/kvm was available. Thus, one would need to make
a /usr/bin/qemu symlink to be able to use TCG
On Sat, Jul 14, 2012 at 23:31:52 +0300, Dan Kenigsberg wrote:
On Thu, Jul 12, 2012 at 01:06:08PM +0200, Jiri Denemark wrote:
When host CPU could not be properly detected, virConnectCompareCPU will
just report that any CPU is incompatible with host CPU instead of
failing.
---
src/qemu
On Fri, Jul 13, 2012 at 11:58:23 -0400, Chuck Short wrote:
On Fri, 13 Jul 2012 09:14:47 +0200
Jiri Denemark jdene...@redhat.com wrote:
On Thu, Jul 12, 2012 at 13:39:02 -0500, Chuck Short wrote:
Adding CPU encoder/decoder for armhf to avoid runtime error
messages.
I would still
---
Can't we just get rid of this horrific and mostly unmaintained xenapi code
completely? :-)
src/xenapi/xenapi_driver.c | 3 ++-
src/xenapi/xenapi_utils.c | 36 ++--
2 files changed, 16 insertions(+), 23 deletions(-)
diff --git a/src/xenapi/xenapi_driver.c
On Tue, Jul 17, 2012 at 09:47:13 -0600, Eric Blake wrote:
On 07/17/2012 09:24 AM, Jiri Denemark wrote:
---
Can't we just get rid of this horrific and mostly unmaintained xenapi code
completely? :-)
Wouldn't it be nice? That may be a question worth asking on the
announce list, to see
Remote driver needs to make sure the driver lock is released before
entering client IO loop as that may block indefinitely in poll(). As a
direct consequence of not following this in stream APIs, tunneled
migration to a destination host which becomes non-responding may block
qemu driver. Luckily,
On Wed, Jul 18, 2012 at 09:46:12 +0200, Michal Privoznik wrote:
On 17.07.2012 19:30, Jiri Denemark wrote:
Remote driver needs to make sure the driver lock is released before
entering client IO loop as that may block indefinitely in poll(). As a
direct consequence of not following
On Wed, Jul 18, 2012 at 17:32:24 +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Allow detection of EOF in virNetClient via an callback
function, triggered from the socket event handler
EOF callback is nice but since we have keepalive, sockets can also be closed
On Wed, Jul 18, 2012 at 19:40:41 +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Update the CPU helper APIs to use virReportError instead
of the virCPUReportError custom macor
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
cfg.mk|
On Wed, Jul 18, 2012 at 19:40:43 +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Update the XenXS shared code to use virReportError instead
of the XENXS_ERROR custom macro
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
cfg.mk|
On Wed, Jul 18, 2012 at 19:40:45 +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Update the libxl driver to use virReportError instead of
the libxlError custom macro
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
cfg.mk |1 -
On Wed, Jul 18, 2012 at 19:40:47 +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Update the lock manager drivers to use virReportError instead
of the virLockError custom macro
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
On Fri, Jul 20, 2012 at 00:40:33 +0800, Osier Yang wrote:
Mainly for later patches' use, to filter the pools by pool type.
include/libvirt/libvirt.h.in: Add enum virStoragePoolType; Add
pool type to virStoragePoolInfo.
src/conf/storage_conf.h: Remove enum virStoragePoolType.
On Fri, Jul 20, 2012 at 21:10:57 +0800, Osier Yang wrote:
On 2012年07月20日 21:01, Daniel P. Berrange wrote:
On Fri, Jul 20, 2012 at 09:00:21PM +0800, Osier Yang wrote:
On 2012年07月20日 20:44, Daniel P. Berrange wrote:
Fortunately no other part of this patch series appears to rely on this
Hi,
On Sat, Jul 21, 2012 at 04:46:18 -0500, Jared wrote:
I'm having a weird problem where libvirt/qemu/kvm won't let me use the model
processor I have defined in my domain's config file. Instead, I get the
error message in libvirtd.log that:
warning : x86Decode:1346 : Preferred CPU model
On Fri, Jul 20, 2012 at 16:55:22 +0100, Daniel P. Berrange wrote:
On Fri, Jul 20, 2012 at 09:46:42AM -0600, Eric Blake wrote:
One remark up there, but no biggie.
I had to hunt for that remark among 70k of verbatim patch. Not only is
it okay to trim portions of the patch that you are
This adds several tests for remaining hash APIs (custom
hasher/comparator functions are not covered yet, though).
All tests pass both before and after the Simplify hash implementation.
---
src/util/hash.c | 18 +++
src/util/hash.h |1 +
tests/hashdata.h | 237
Remove the artificial minimum of 4096 KB for guest memory. It's drivers'
job to set the limit if needed.
---
src/libvirt.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index 9e6784b..10c3cdf 100644
--- a/src/libvirt.c
+++
On Thu, Apr 21, 2011 at 06:40:58 -0600, Eric Blake wrote:
On 04/21/2011 06:21 AM, Jiri Denemark wrote:
Remove the artificial minimum of 4096 KB for guest memory. It's drivers'
job to set the limit if needed.
---
src/libvirt.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions
On Fri, Apr 22, 2011 at 09:58:38 +0200, Michal Privoznik wrote:
The patch which moved libpciaccess initialization to one place caused
regression - we were not able to run on system with no PCI bus, like
s390(x). This patch fix it.
---
src/node_device/node_device_udev.c |6 ++
1
This patch makes the options --crash and --live of virsh dump mutually
exclusive
diff --git a/tools/virsh.c b/tools/virsh.c
index 2e35021..ef77d7f 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -1869,14 +1869,19 @@ cmdDump(vshControl *ctl, const vshCmd *cmd)
flags |=
On Fri, Apr 22, 2011 at 09:54:03 -0600, Eric Blake wrote:
On 04/22/2011 04:03 AM, Jiri Denemark wrote:
---
src/qemu/qemu_driver.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index f6e503a..f35616d 100644
On Fri, Apr 22, 2011 at 09:57:46 -0600, Eric Blake wrote:
@@ -2379,6 +2379,12 @@ virDomainCoreDump(virDomainPtr domain, const char
*to, int flags)
goto error;
}
+if ((flags VIR_DUMP_CRASH) (flags VIR_DUMP_LIVE)) {
+
Check for audit_encode_nv_string in libaudit so that ancient audit
library is ignored rather than trying to compile with libaudit support
and failing.
---
configure.ac |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index 190bf40..25cc15b
Currently the build fails if /usr/local/include does not exist since
its use is hardcoded in configure.ac
---
configure.ac | 86 ++---
1 files changed, 21 insertions(+), 65 deletions(-)
diff --git a/configure.ac b/configure.ac
index
On Tue, Apr 26, 2011 at 10:11:27 -0600, Eric Blake wrote:
On 04/19/2011 07:22 AM, Jiri Denemark wrote:
This adds several tests for remaining hash APIs (custom
hasher/comparator functions are not covered yet, though).
All tests pass both before and after the Simplify hash implementation
On Tue, Apr 12, 2011 at 13:10:15 -0600, Eric Blake wrote:
On 04/12/2011 11:25 AM, Jiri Denemark wrote:
So far first entries for each hash key are stored directly in the hash
table while other entries mapped to the same key are linked through
pointers. As a result of that, the code
On Wed, Apr 27, 2011 at 20:58:40 -0600, Eric Blake wrote:
On 04/27/2011 03:25 AM, Jiri Denemark wrote:
Check for audit_encode_nv_string in libaudit so that ancient audit
library is ignored rather than trying to compile with libaudit support
and failing.
---
configure.ac |2 +-
1
On Wed, Apr 27, 2011 at 20:57:52 -0600, Eric Blake wrote:
On 04/27/2011 04:34 AM, Jiri Denemark wrote:
Currently the build fails if /usr/local/include does not exist since
its use is hardcoded in configure.ac
---
configure.ac | 86
On Wed, Apr 27, 2011 at 16:57:43 +0200, Michal Privoznik wrote:
---
src/conf/cpu_conf.c|4 +-
src/conf/domain_conf.c | 100 ++-
src/conf/interface_conf.c |2 +-
src/conf/network_conf.c|2 +-
---
src/driver.h |5 +
src/esx/esx_driver.c |1 +
src/libxl/libxl_driver.c |1 +
src/lxc/lxc_driver.c |1 +
src/openvz/openvz_driver.c |1 +
src/phyp/phyp_driver.c |1 +
src/qemu/qemu_driver.c |1 +
src/remote/remote_driver.c |
---
src/libvirt.c | 47 +++
1 files changed, 47 insertions(+), 0 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index e74e977..5cd20ce 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -3173,6 +3173,53 @@ error:
}
/**
+ *
the reply. In case of
qemu driver, this translates to the driver being stuck in comunication with
qemu monitor. I'm not sure if we should somehow integrate this into
virDomainGetState API. Probably not.
Jiri Denemark (8):
virDomainGetState public API
Internal driver API for virDomainGetState
This API is supposed to replace virDomainGetInfo when the only purpose
of calling it is getting current domain status.
---
include/libvirt/libvirt.h.in| 55 +++
python/generator.py |1 +
python/libvirt-override-api.xml |5 +++
---
tools/virsh.c | 195 +++--
1 files changed, 162 insertions(+), 33 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 5d8b025..6dae9fa 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -223,6 +223,8 @@ typedef struct __vshControl
---
daemon/remote.c | 33 +
daemon/remote_dispatch_prototypes.h |8
daemon/remote_dispatch_table.h |5 +
src/remote/remote_protocol.c| 20
src/remote/remote_protocol.h| 16
---
src/remote/remote_driver.c | 31 ++-
1 files changed, 30 insertions(+), 1 deletions(-)
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 9796bb5..3baedf0 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -2861,6
Reason is currently always set to 0 (i.e., *_UNKNOWN).
---
src/esx/esx_driver.c | 54 -
src/libxl/libxl_driver.c | 31 +-
src/lxc/lxc_driver.c | 33 ++-
src/openvz/openvz_driver.c | 32 ++-
src/phyp/phyp_driver.c
They were not used anywhere so far so nobody noticed they are broken.
---
src/util/json.c | 11 ++-
src/util/json.h |4 ++--
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/src/util/json.c b/src/util/json.c
index 0daeae9..df4771d 100644
--- a/src/util/json.c
+++
On Wed, May 04, 2011 at 10:45:33 -0600, Eric Blake wrote:
On 05/04/2011 08:45 AM, Jiri Denemark wrote:
This API is supposed to replace virDomainGetInfo when the only purpose
of calling it is getting current domain status.
@@ -674,6 +726,9 @@ int virDomainCoreDump
On Wed, May 04, 2011 at 10:40:38 -0600, Eric Blake wrote:
On 05/04/2011 08:45 AM, Jiri Denemark wrote:
This new API solves several problems:
- calling virDomainGetInfo for just getting domain status is an overkill
since
it may result in sending requests to guest OS
- since
Hi all,
After commit f09accc (buf: add virBufferVasprintf) libvirt no longer compiles
with -Werror because of the following error:
CC libvirt_util_la-macvtap.lo
cc1: warnings being treated as errors
/usr/include/netlink/object.h:58: error: inline function 'nl_object_priv'
declared but
On Wed, May 04, 2011 at 17:35:42 -0600, Eric Blake wrote:
+bool noGetState;/* virDomainGetState is not supported in
+ * current connection */
Nice - remembering the failure once, so you don't have to repeat it.
However, I don't like double
On Fri, May 06, 2011 at 16:33:13 -0600, Eric Blake wrote:
On 05/06/2011 01:18 PM, Jiri Denemark wrote:
We discussed more on IRC. The problem is due to a bug in out-of-the-box
libnl headers, and has been patched in most distros to just delete the
'inline' as then you don't have to worry about
On Sat, May 07, 2011 at 14:18:35 +0200, Matthias Bolte wrote:
2011/5/7 Eric Blake ebl...@redhat.com:
* src/Makefile.am (REMOTE_DRIVER_GENERATED): Generated files
should live in $(srcdir). Update rules to reflect this.
---
This still doesn't fix the fact that 'make dist' under
On Thu, May 05, 2011 at 13:13:13 -0600, Eric Blake wrote:
On 05/05/2011 07:10 AM, Jiri Denemark wrote:
They were not used anywhere so far so nobody noticed they are broken.
---
src/util/json.c | 11 ++-
src/util/json.h |4 ++--
2 files changed, 8 insertions(+), 7
virsh didn't call virInitialize(), which (among other things)
initializes virLastErr thread local variable. As a result of that, virsh
could just segfault in virEventRegisterDefaultImpl() since that is the
first call that touches (resets) virLastErr.
I have no idea what lucky coincidence made
---
Notes:
Version 2:
- rebased
- unsigned int flags
src/libvirt.c | 51 +++
1 files changed, 51 insertions(+), 0 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index abacf85..571eb97 100644
--- a/src/libvirt.c
+++
- simplified implementation in esx driver per Matthias' suggestion
- call internal xen drivers directly instead of going through xenUnifiedDriver
- fixed || vs typo in domain_conf.c
- new patch 9/9: qemu: Update domain state when reconnecting monitor
Jiri Denemark (9):
virDomainGetState public API
---
Notes:
Version 2:
- rebased
- unsigned int flags
daemon/remote.c | 33 +
daemon/remote_generator.pl |3 ++-
src/remote/remote_protocol.x | 13 -
src/remote_protocol-structs |8
4 files changed, 55
---
Notes:
Version 2:
- rebased
- unsigned int flags
- noGetState renamed as useGetInfo
tools/virsh.c | 195 +++--
1 files changed, 162 insertions(+), 33 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index
---
Notes:
Version 2:
- rebased
- unsigned int flags parameter
- avoid changing xenUnifiedDriver internal callback struct
src/driver.h |6 ++
src/esx/esx_driver.c |1 +
src/libxl/libxl_driver.c |1 +
src/lxc/lxc_driver.c |1 +
---
Notes:
Version 2:
- rebased
- unsigned int flags
daemon/remote_generator.pl |3 ++-
src/remote/remote_driver.c | 35 ++-
2 files changed, 36 insertions(+), 2 deletions(-)
diff --git a/daemon/remote_generator.pl b/daemon/remote_generator.pl
This API is supposed to replace virDomainGetInfo when the only purpose
of calling it is getting current domain status.
---
Notes:
Version 2:
- rebased
- unsigned int flags parameter
- updated version info in public.syms
include/libvirt/libvirt.h.in| 56
Reason is currently always set to 0 (i.e., *_UNKNOWN).
---
Notes:
Version 2:
- rebased
- unsigned int flags
- simplified implementation in esx driver per Matthias' suggestion
- call internal xen drivers directly instead of going through
xenUnifiedDriver
src/esx/esx_driver.c
801 - 900 of 7240 matches
Mail list logo
