On 07/11/2013 10:05 AM, Michal Privoznik wrote:
On 08.07.2013 21:20, John Ferlan wrote:
At vm startup, reconnect, and attach - check for the presence of the balloon
driver and save the path in the private area of the driver. This path will
remain constant throughout the life of the domain
On 07/11/2013 12:02 PM, Daniel P. Berrange wrote:
On Thu, Jul 11, 2013 at 11:16:22AM -0400, John Ferlan wrote:
v1:
https://www.redhat.com/archives/libvir-list/2013-July/msg00691.html
Changes over v1:
* Add additional files to patch #2 to include other places were
sysconf(_SC_OPEN_MAX
. In 04, all
one could do would be virsh edit
John Ferlan (10):
Add qemuMonitorJSONGetObjectListPaths() method for QMP qom-list
command
Add qemuMonitorJSONGetObjectProperty() method for QMP qom-get command
Add qemuMonitorJSONSetObjectProperty() method for QMP qom-set command
Add a new qemuMonitorJSONGetObjectListPaths() method to support invocation
of the 'qom-list' JSON monitor command with a provided path.
The returned list of paired data fields of name and type that can
be used to peruse QOM configuration data and eventually utilize for the
balloon statistics.
Add a new qemuMonitorJSONSetObjectProperty() method to support invocation
of the 'qom-set' JSON monitor command with a provided path, property, and
expected data type to set.
The test code uses the same /machine/i440fx property as the get test and
attempts to set the realized property to true
At vm startup and attach attempt to set the balloon driver statistics
collection period based on the value found in the domain xml file. This
is not done at reconnect since it's possible that a collection period
was set on the live guest and making the set period call would reset to
whatever value
Add new API in order to set the balloon memory driver statistics collection
period in order to allow dynamic period adjustment for the virsh dommemstats to
display balloon stats data
---
include/libvirt/libvirt.h.in | 3 +++
src/driver.h | 6 +
src/libvirt.c|
Use the virDomainSetMemoryStatsPeriodFlags() to pass a period defined by
usage of a new --period option in order to set the collection period for the
balloon driver. This may enable or disable the collection based on the value.
Add the --current, --live, --config options to dommemstat.
---
Add a new qemuMonitorJSONGetObjectProperty() method to support invocation
of the 'qom-get' JSON monitor command with a provided path, property, and
expected data type return. The qemuMonitorJSONObjectProperty is similar to
virTypedParameter; however, a future patch will extend it a bit to include
Wire up the remote protocol
---
src/remote/remote_driver.c | 1 +
src/remote/remote_protocol.x | 15 ++-
src/remote_protocol-structs | 6 ++
3 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index
Implement the new API that will handle setting the balloon driver statistics
collection period in order to enable or disable the collection dynamically.
---
src/qemu/qemu_driver.c | 65 ++
1 file changed, 65 insertions(+)
diff --git
This patch will add the qemuMonitorJSONGetMemoryStats() to execute a
guest-stats on the balloonpath using get-qom replacing the former
mechanism which looked through the query-ballon returned data for
the fields. The query-balloon code only returns 'actual' memory.
Rather than duplicating the
Add a period in seconds to allow/enable statistics gathering from the
Balloon driver for 'virsh dommemstat domain'.
---
docs/formatdomain.html.in | 10 ++
docs/schemas/domaincommon.rng | 7 +++
src/conf/domain_conf.c| 38 +++---
On 07/12/2013 08:39 AM, Daniel P. Berrange wrote:
On Thu, Jul 11, 2013 at 07:55:55PM -0400, John Ferlan wrote:
At vm startup and attach attempt to set the balloon driver statistics
collection period based on the value found in the domain xml file. This
is not done at reconnect since it's
On 07/12/2013 08:35 AM, Daniel P. Berrange wrote:
ps, forgot to mention last time that you need to add a test case
for this new XML - or just add the XML to
1. Copied qemuxml2argv-balloon-device.xml to
qemuxml2argv-balloon-device-period.xml, adding
stats period='10'/
2. Copied
On 07/12/2013 08:39 AM, Daniel P. Berrange wrote:
On Thu, Jul 11, 2013 at 07:55:55PM -0400, John Ferlan wrote:
At vm startup and attach attempt to set the balloon driver statistics
collection period based on the value found in the domain xml file. This
is not done at reconnect since it's
On 07/12/2013 08:45 AM, Daniel P. Berrange wrote:
On Thu, Jul 11, 2013 at 07:56:00PM -0400, John Ferlan wrote:
...snip...
index 5fbd32c..4cbf105 100644
--- a/tools/virsh-domain-monitor.c
+++ b/tools/virsh-domain-monitor.c
@@ -314,6 +314,23 @@ static const vshCmdOptDef opts_dommemstat
On 07/12/2013 08:42 AM, Daniel P. Berrange wrote:
On Thu, Jul 11, 2013 at 07:55:56PM -0400, John Ferlan wrote:
This patch will add the qemuMonitorJSONGetMemoryStats() to execute a
guest-stats on the balloonpath using get-qom replacing the former
mechanism which looked through the query-ballon
On 07/10/2013 01:02 PM, Michal Privoznik wrote:
The function being introduced is responsible for creating command
line argument for '-device' for given character device. Based on
the chardev type, it calls appropriate qemuBuild.*ChrDeviceStr(),
e.g. qemuBuildSerialChrDeviceStr() for serial
On 07/12/2013 11:57 AM, Eric Blake wrote:
On 07/12/2013 06:35 AM, Daniel P. Berrange wrote:
On Thu, Jul 11, 2013 at 07:55:53PM -0400, John Ferlan wrote:
Add a new qemuMonitorJSONSetObjectProperty() method to support invocation
of the 'qom-set' JSON monitor command with a provided path
On 07/15/2013 05:57 AM, Jiri Denemark wrote:
On Thu, Jul 11, 2013 at 19:55:50 -0400, John Ferlan wrote:
This patch set replaces:
https://www.redhat.com/archives/libvir-list/2013-July/msg00435.html
Changes
07 - 09- Remove the flags, Flags, FLAGS (learned something new!)
Just remember
Generate and use the virStoragePoolAuthTypeType{To|From}String helpers
---
src/conf/storage_conf.c | 19 +++
src/conf/storage_conf.h | 3 +++
2 files changed, 14 insertions(+), 8 deletions(-)
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index 524a4d6..9bcfced
Split processing of auth into its own function
---
src/conf/storage_conf.c | 65 +++--
1 file changed, 41 insertions(+), 24 deletions(-)
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index 9bcfced..1097de8 100644
---
are for all intents
the same except for a few letters ('eph' and 'hap')
* Updated Osier's change to storage_backend_iscsi.c in order to remove
the 'login'/'passwd' options.
Ran 'make' 'make check' each step along the way. Also tested with valgrind
with no new errors.
John Ferlan (6
Split out the _virStoragePoolAuthSecret data from _virStoragePoolAuthCephx
into its own structure
---
src/conf/storage_conf.h | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/src/conf/storage_conf.h b/src/conf/storage_conf.h
index 98339ef..5fbecf4 100644
---
From: Osier Yang jy...@redhat.com
Although the XML for chap authentication with plain password
was introduced long ago, the function was never implemented.
This patch completes it by performing the authentication during
findPoolSources() processing of pools with an authType of
Move the auth-username processing into virStoragePoolDefParseAuth
save the resulting username into chap/cephx specific data
---
src/conf/storage_conf.c | 30 ++
1 file changed, 14 insertions(+), 16 deletions(-)
diff --git a/src/conf/storage_conf.c
The existing 'chap' XML logic was never used - just defined. Rather than
try to insert a square peg into a round hole, blow it up and rewrite the
logic to follow the 'ceph' format.
Remove the former chap.login and chap.passwd fields and replace
with chap.username and chap.secret in
Merge virStoragePoolDefParseAuthChap and virStoragePoolDefParseAuthCephx
into a common virStoragePoolDefParseAuthSecret. Change the output to be
common for both by putting 'type' first followed by 'username'.
Need to adjust a test output for that too.
---
src/conf/storage_conf.c | 60
On 07/15/2013 08:11 AM, Daniel P. Berrange wrote:
On Fri, Jul 12, 2013 at 07:23:58PM +0200, Michal Privoznik wrote:
It's caller's responsibility to free return value of
qemuBuildChrDeviceStr().
---
src/qemu/qemu_command.c | 1 +
1 file changed, 1 insertion(+)
diff --git
On 07/15/2013 10:16 AM, Osier Yang wrote:
On 10/07/13 03:10, John Ferlan wrote:
From: Osier Yang jy...@redhat.com
...snip...
diff --git a/src/storage/storage_backend_iscsi.c
b/src/storage/storage_backend_iscsi.c
index 0a4cd22..673ca16 100644
--- a/src/storage/storage_backend_iscsi.c
+++ b
On 07/15/2013 11:00 AM, Daniel P. Berrange wrote:
On Mon, Jul 15, 2013 at 09:04:34AM -0400, John Ferlan wrote:
Merge virStoragePoolDefParseAuthChap and virStoragePoolDefParseAuthCephx
into a common virStoragePoolDefParseAuthSecret. Change the output to be
common for both by putting 'type
On 07/15/2013 11:11 AM, Osier Yang wrote:
On 15/07/13 23:01, John Ferlan wrote:
On 07/15/2013 10:16 AM, Osier Yang wrote:
On 10/07/13 03:10, John Ferlan wrote:
From: Osier Yang jy...@redhat.com
...snip...
i think the chap auth iscsi pool won't be able to start with this
change
On 07/11/2013 07:55 PM, John Ferlan wrote:
This patch set replaces:
https://www.redhat.com/archives/libvir-list/2013-July/msg00435.html
Changes
01 - No change
02 03 - Adjust typecaste to switch() and remove default:
04 - Use unsigned int as requested
05 - Add
On 07/15/2013 09:04 AM, John Ferlan wrote:
Based on review comments of v2 posting (see 2/7 for specifics):
https://www.redhat.com/archives/libvir-list/2013-July/msg00554.html
I rewrote the storage_conf.c chap parsing code. I think the first 6
patches could be squashed into 1 for a final
'secretGetValue' directly rather than
through the virSecretGetValue() API.
Using the same connection paradigm for the chap/iscsi authentication path
in order to access the secret driver 'secretGetValue' directly rather than
through the virSecretGetValue() API.
John Ferlan (3):
Add a privileged field
Although the XML for CHAP authentication with plain password
was introduced long ago, the function was never implemented. This
patch replaces the login/password mechanism by following the
'ceph' (or RBD) model of using a 'username' with a 'secret' which
has the authentication information.
This
Use the privileged value in order to generate a connection which could
be passed to the various storage backend drivers.
In particular, the iSCSI driver will need a connect in order to perform
pool authentication using the 'chap' secrets. Additionally, the RBD backend
utilizes the connection
Update virStorageBackendRBDOpenRADOSConn() to use the internal API to the
secret driver in order to get the secret value instead of the external
virSecretGetValue() path. Without the flag VIR_SECRET_GET_VALUE_INTERNAL_CALL
there is no way to get the value of private secret.
This also requires
On 07/16/2013 05:31 AM, Daniel P. Berrange wrote:
On Tue, Jul 16, 2013 at 09:44:52AM +0100, Daniel P. Berrange wrote:
On Mon, Jul 15, 2013 at 04:26:10PM -0400, John Ferlan wrote:
Use the privileged value in order to generate a connection which could
be passed to the various storage backend
On 07/11/2013 07:55 PM, John Ferlan wrote:
This patch set replaces:
https://www.redhat.com/archives/libvir-list/2013-July/msg00435.html
Changes
01 - No change
02 03 - Adjust typecaste to switch() and remove default:
04 - Use unsigned int as requested
05 - Add
From: Osier Yang jy...@redhat.com
There are two ways to use a iSCSI LUN as disk source for qemu.
* The LUN's path as it shows up on host, e.g.
/dev/disk/by-path/ip-$ip:3260-iscsi-$iqn-fc18:iscsi.iscsi0-lun-1
* The libiscsi URI, e.g.
iscsi://demo.org:6000/iqn.1992-01.com.example/1
For a
Introduce a new helper to check if the disk source is of block type
---
src/conf/domain_conf.c | 41 +
src/conf/domain_conf.h | 3 +++
src/libvirt_private.syms | 1 +
src/qemu/qemu_command.c | 5 ++---
src/qemu/qemu_conf.c | 23
From: Osier Yang jy...@redhat.com
virDomainDiskDefForeachPath is not only used by the security
setting helpers, also used by cgroup setting helpers, so this
is to ignore the volume type disk with mode=uri for cgroup
setting.
---
src/conf/domain_conf.c | 5 -
1 file changed, 4 insertions(+),
The difference with already supported pool types (dir, fs, block)
is: there are two modes for iscsi pool (or network pools in future),
one can specify it either to use the volume target path (the path
showed up on host) with mode='host', or to use the remote URI qemu
supports (e.g.
Although they produce no seclabel data, add some tests for coverage of
various network and volume disk definitions
---
tests/securityselinuxlabeldata/netdisks.txt | 5 +++
tests/securityselinuxlabeldata/netdisks.xml | 58 +
tests/securityselinuxlabeldata/voldisks.txt
pool that
labels could be attached to, but was unsuccessful.
* Patch 6 7 (formerly 5 6) - no change. Now that I know more about
the code the issue I had with 6 is a no-op
John Ferlan (3):
conf: Introduce virDomainDiskSourceIsBlockType
qemu: Translate the iscsi pool/volume disk source
From: Osier Yang jy...@redhat.com
The translation must be done before both of cgroup and security
setting, otherwise since the disk source is not translated yet,
it might be skipped on cgroup and security setting.
---
src/qemu/qemu_process.c | 13 -
1 file changed, 8 insertions(+), 5
On 07/18/2013 11:02 AM, John Ferlan wrote:
Introduce a new helper to check if the disk source is of block type
---
src/conf/domain_conf.c | 41 +
src/conf/domain_conf.h | 3 +++
src/libvirt_private.syms | 1 +
src/qemu/qemu_command.c | 5
There are two ways to use a iSCSI LUN as disk source for qemu.
* The LUN's path as it shows up on host, e.g.
/dev/disk/by-path/ip-$ip:3260-iscsi-$iqn-fc18:iscsi.iscsi0-lun-1
* The libiscsi URI from the storage pool source element host attribute, e.g.
Make sure default iSCSI target is 3260.
---
src/storage/storage_backend_iscsi.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/src/storage/storage_backend_iscsi.c
b/src/storage/storage_backend_iscsi.c
index ba4f388..54bcd14 100644
---
of
qemuAddDiskISCSIUri. Also added a check in the function
that (pooldef-source.nhost != 1) to make sure we at least
have a host defined in the pool and of course that there's
only one.
John Ferlan (5):
storage_iscsi: Reflect the default target port
conf: Introduce new XML tag mode for disk source
From: Osier Yang jy...@redhat.com
The translation must be done before both of cgroup and security
setting, otherwise since the disk source is not translated yet,
it might be skipped on cgroup and security setting.
---
src/qemu/qemu_process.c | 13 -
1 file changed, 8 insertions(+), 5
From: Osier Yang jy...@redhat.com
virDomainDiskDefForeachPath is not only used by the security
setting helpers, also used by cgroup setting helpers, so this
is to ignore the volume type disk with mode=direct for cgroup
setting.
---
src/conf/domain_conf.c | 5 -
1 file changed, 4
The difference with already supported pool types (dir, fs, block)
is: there are two modes for iscsi pool (or network pools in future),
one can specify it either to use the volume target path (the path
showed up on host) with mode='host', or to use the remote URI qemu
supports (e.g.
Introduce a new helper to check if the disk source is of block type
---
src/conf/domain_conf.c | 32
src/conf/domain_conf.h | 3 +++
src/libvirt_private.syms | 1 +
src/qemu/qemu_command.c | 5 ++---
src/qemu/qemu_conf.c | 23 +--
5
Although they produce no seclabel data, add some tests for coverage of
various network and volume disk definitions
---
tests/securityselinuxlabeldata/netdisks.txt | 5 +++
tests/securityselinuxlabeldata/netdisks.xml | 58 +
tests/securityselinuxlabeldata/voldisks.txt
On 07/22/2013 07:06 AM, Osier Yang wrote:
On 19/07/13 20:32, John Ferlan wrote:
Although they produce no seclabel data, add some tests for coverage of
various network and volume disk definitions
---
tests/securityselinuxlabeldata/netdisks.txt | 5 +++
tests/securityselinuxlabeldata
On 07/19/2013 08:32 AM, John Ferlan wrote:
An update to yesterday's posting:
https://www.redhat.com/archives/libvir-list/2013-July/msg01213.html
Changes in v3 over v2
* Update patch 1 per code review
* Use 'direct' instead of 'uri' and supporting documentaiton
* In patch 4, use
During qemuTranslateDiskSourcePool() execution, if the srcpool has been
defined with authentication information, then for iSCSI pools copy the
authentication and host information to virDomainDiskDef.
---
src/qemu/qemu_conf.c | 55
1 file
Update virStorageBackendRBDOpenRADOSConn() to use the internal API to the
secret driver in order to get the secret value instead of the external
virSecretGetValue() path. Without the flag VIR_SECRET_GET_VALUE_INTERNAL_CALL
there is no way to get the value of private secret.
This also requires
Make the secret fetching code common for qemuBuildRBDString() and
qemuBuildDriveURIString() using the virDomainDiskDef.
---
src/qemu/qemu_command.c | 157 +---
1 file changed, 81 insertions(+), 76 deletions(-)
diff --git a/src/qemu/qemu_command.c
Split out into its own separate routine
---
src/qemu/qemu_command.c | 108
1 file changed, 64 insertions(+), 44 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 5bd8e87..ac275c3 100644
--- a/src/qemu/qemu_command.c
for NULL connection. This just stops autostarting
pools from getting authentication. This still needs to be fixed/resolved,
but there just wasn't time in this release for that.
5. Split the rbd authentication code into it's own patch rather than being
part of the iscsi patch 4.
John
Although the XML for CHAP authentication with plain password
was introduced long ago, the function was never implemented. This
patch replaces the login/password mechanism by following the
'ceph' (or RBD) model of using a 'username' with a 'secret' which
has the authentication information.
This
On 07/23/2013 10:18 AM, Ján Tomko wrote:
On 07/22/2013 10:31 PM, John Ferlan wrote:
---
src/storage/storage_backend_iscsi.c | 111
+++-
1 file changed, 110 insertions(+), 1 deletion(-)
I can confirm this works, but it's a shame it doesn't work
On 07/22/2013 04:31 PM, John Ferlan wrote:
This is a reworking and reposting of the authentication patches originally
posted as part of my v3 reworking of Osier's original patches, see:
...snip...
John Ferlan (5):
qemu: Add source pool auth info to virDomainDiskDef for iSCSI
qemu: Create
On 07/23/2013 10:56 AM, Daniel P. Berrange wrote:
...snip...
+++ b/src/storage/storage_backend_iscsi.c
@@ -714,7 +714,8 @@ virStorageBackendISCSISetAuth(const char *portal,
if (!conn) {
virReportError(VIR_ERR_INTERNAL_ERROR, %s,
- _(iscsi 'chap'
Commit id '4421e257' strdup'd devAlias, but didn't free
Running qemuhotplugtest under valgrind resulted in the following:
==7375== 9 bytes in 1 blocks are definitely lost in loss record 11 of 70
==7375==at 0x4A0887C: malloc (vg_replace_malloc.c:270)
==7375==by 0x37C1085D71: strdup
Commit 'c8695053' resulted in the following:
Coverity error seen in the output:
ERROR: REVERSE_INULL
FUNCTION: lxcProcessAutoDestroy
Due to the 'dom' being checked before 'dom-persistent' since 'dom'
is already dereferenced prior to that.
---
src/lxc/lxc_process.c | 2 +-
1 file
:
https://www.redhat.com/archives/libvir-list/2013-July/msg01156.html
and
https://www.redhat.com/archives/libvir-list/2013-July/msg01158.html
but did not completely resolve the failures.
John Ferlan (3):
lxc: Resolve Coverity warning
domain_event: Resolve memory leak found by Valgrind
On 07/23/2013 12:18 PM, Paolo Bonzini wrote:
Il 23/07/2013 18:01, Daniel P. Berrange ha scritto:
On Tue, Jul 23, 2013 at 05:35:57PM +0200, Paolo Bonzini wrote:
Il 23/07/2013 16:14, Daniel P. Berrange ha scritto:
Perhaps the default could be specified in a configuration file (and the
default
On 07/23/2013 12:03 PM, Daniel P. Berrange wrote:
On Tue, Jul 23, 2013 at 11:50:57AM -0400, John Ferlan wrote:
On 07/23/2013 10:56 AM, Daniel P. Berrange wrote:
...snip...
+++ b/src/storage/storage_backend_iscsi.c
@@ -714,7 +714,8 @@ virStorageBackendISCSISetAuth(const char *portal
On 07/23/2013 12:45 PM, Eric Blake wrote:
On 07/23/2013 09:59 AM, John Ferlan wrote:
Update based on recent run/failures seen
---
tests/.valgrind.supp | 60
1 file changed, 60 insertions(+)
diff --git a/tests/.valgrind.supp b/tests
On 07/24/2013 05:57 AM, Daniel P. Berrange wrote:
On Wed, Jul 24, 2013 at 10:25:06AM +0200, Ján Tomko wrote:
...snip...
Both secret and qemu drivers are registered after the storage driver on
libvirtd startup, so autostarting these pools will only work on storage
driver
reload. On libvirtd
Separation allows for dependent drivers to be make a connection during
the AutoStart phase of state initialization.
---
src/driver.h | 4
src/libvirt.c | 23 ++-
2 files changed, 26 insertions(+), 1 deletion(-)
diff --git a/src/driver.h b/src/driver.h
index
opens again.
John Ferlan (2):
Separate out StateAutoStart from StateInitialize
virStateDriver - Separate AutoStart from Initialize
src/driver.h | 4
src/libvirt.c| 23 ++-
src/libxl/libxl_driver.c | 18 +++---
src/lxc
Adjust these drivers to handle their Autostart functionality after each
of the drivers has gone through their Initialization functions
merge
---
src/libxl/libxl_driver.c | 18 +++---
src/lxc/lxc_driver.c | 18 --
src/network/bridge_driver.c | 20
On 07/25/2013 02:41 PM, Daniel P. Berrange wrote:
On Thu, Jul 25, 2013 at 02:32:57PM -0400, John Ferlan wrote:
Adjust these drivers to handle their Autostart functionality after each
of the drivers has gone through their Initialization functions
merge
---
src/libxl/libxl_driver.c | 18
...snip...? diff --git a/tests/storagevolxml2argvtest.c
b/tests/storagevolxml2argvtest.c
index b220994..3c338ce 100644
--- a/tests/storagevolxml2argvtest.c
+++ b/tests/storagevolxml2argvtest.c
@@ -11,10 +11,32 @@
const char create_tool[] = qemu-img;
+/* createVol sets this on volume
On 07/26/2013 07:27 AM, Ján Tomko wrote:
Ignore NULL pool in testSetVolumeType to silence Coverity,
even though we only call it with NULL pool when vol is also NULL.
(13) Event var_deref_model: Passing null pointer inputpool to
function testSetVolumeType(virStorageVolDefPtr,
This is an update to change the 'int' AutoStart function to 'void' as
was discussed in the initial review:
https://www.redhat.com/archives/libvir-list/2013-July/msg01674.html
John Ferlan (2):
Separate out StateAutoStart from StateInitialize
virStateDriver - Separate AutoStart from Initialize
Adjust these drivers to handle their Autostart functionality after each
of the drivers has gone through their Initialization functions
---
src/libxl/libxl_driver.c | 16 +---
src/lxc/lxc_driver.c | 16 ++--
src/network/bridge_driver.c | 18 +-
Separation allows for dependent drivers to be make a connection during
the AutoStart phase of state initialization.
---
src/driver.h | 4
src/libvirt.c | 14 +-
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/src/driver.h b/src/driver.h
index cc03e9f..be64333
On 07/26/2013 07:50 AM, John Ferlan wrote:
This is an update to change the 'int' AutoStart function to 'void' as
was discussed in the initial review:
https://www.redhat.com/archives/libvir-list/2013-July/msg01674.html
John Ferlan (2):
Separate out StateAutoStart from StateInitialize
On 07/30/2013 09:05 AM, Peter Krempa wrote:
This patch exports a few utility functions and adds testing of shutdown
commands of the guest agent.
---
...snip...
+
+static int
+qemuAgentShutdownTestMonitorHandler(qemuMonitorTestPtr test,
+
On 07/30/2013 09:05 AM, Peter Krempa wrote:
...snip...
+/* this allows to add a responder that is able to check
+ * a (shallow) structure of arguments for a command */
+int
+qemuMonitorTestAddItemParams(qemuMonitorTestPtr test,
+ const char *cmdname,
+
On 08/01/2013 10:39 AM, Peter Krempa wrote:
Coverity complained about unused variable that contains the shutdown
mode. The original intention was to check it against the requested mode.
Also the fixed check reveald a mistake in the expected shutdown mode.
Reported by John Ferlan
On 08/01/2013 10:39 AM, Peter Krempa wrote:
When allocation of memory failed the error path didn't call va_end()
causing a coverity failure.
Reported by John Ferlan.
---
tests/qemumonitortestutils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK
John
--
libvir-list mailing
On 08/01/2013 10:39 AM, Peter Krempa wrote:
The shutdown test utilizes waiting for condition to exit the test. This
addition will return an error for the shutdown command to see if the
condition waiting code will not hang.
---
tests/qemuagenttest.c | 23 +++
1 file
of more
traces.
John Ferlan (2):
tests: Coverity found new NULL_RETURNS
valgrind: Adjust filter for _dl_allocate_tls
tests/.valgrind.supp | 6 --
tests/jsontest.c | 8 +++-
2 files changed, 11 insertions(+), 3 deletions(-)
--
1.8.1.4
--
libvir-list mailing list
libvir-list
Coverity reported the existing missing check of the return value and
subsequent use from a call to virJSONValueFromString() in testJSONAddRemove().
---
tests/jsontest.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tests/jsontest.c b/tests/jsontest.c
index
More tests are now using the path - adjust the filter to include any
path from a test through ptrhread_create to _dl_allocate_tls
---
tests/.valgrind.supp | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/.valgrind.supp b/tests/.valgrind.supp
index f04912d..d4fef85
On 08/01/2013 04:06 PM, John Ferlan wrote:
One new Coverity defect was discovered from existing code in this mornings
run. Also recent changes seem to have adjusted tests and provoked valgrind
to find/display potential leaks. That path had already been vetted previously
in a shorter stack
On 08/06/2013 09:52 AM, Stefan Berger wrote:
Since iptables version 1.4.16 '-m state --state NEW' is converted to
'-m conntrack --ctstate NEW'. Therefore, when encountering this or later
versions of iptables use '-m conntrack --ctstate'.
Signed-off-by: Stefan Berger
On 08/06/2013 12:43 PM, Stefan Berger wrote:
On 08/06/2013 11:20 AM, John Ferlan wrote:
On 08/06/2013 09:52 AM, Stefan Berger wrote:
Since iptables version 1.4.16 '-m state --state NEW' is converted to
'-m conntrack --ctstate NEW'. Therefore, when encountering this or later
versions
On 08/06/2013 07:46 PM, Stefan Berger wrote:
Since iptables version 1.4.16 '-m state --state NEW' is converted to
'-m conntrack --ctstate NEW'. Therefore, when encountering this or later
versions of iptables use '-m conntrack --ctstate'.
Signed-off-by: Stefan Berger
When using virsh secret-list - if the secret types are cephx or iscsi,
then allow fetch/print of the usage information. Prior to the change
the following would print:
UUID Usage
---
patches update the documentation
to show how to use secrets, pools, and iSCIS devices in the domain.
John Ferlan (6):
virsh: Print cephx and iscsi usage
qemu_conf: Fix broken logic for adding passthrough iscsi lun
Report secret usage error message similarly
docs: Update the formatdomain
Add more iSCSI examples including having a secret attached. There are 4 new
examples one for each way to have an iSCSI - a network disk using virtio,
a passthrough network lun using scsi, a volume disk using mode='host',
and a volume disk using mode='direct'
---
docs/formatdomain.html.in | 57
301 - 400 of 10575 matches
Mail list logo
