From: Vladimir Sementsov-Ogievskiy
block/dirty-bitmap.c seems to be more appropriate for it and
bdrv_remove_persistent_dirty_bitmap already in it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190920082543.23444-2-vsement...@virtuozzo.com
Signed-off-by: John
From: Vladimir Sementsov-Ogievskiy
bdrv_dirty_bitmap_next is always used in same pattern. So, split it
into _next and _first, instead of combining two functions into one and
add FOR_EACH_DIRTY_BITMAP macro.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id
From: Vladimir Sementsov-Ogievskiy
Reopening bitmaps to RW was broken prior to previous commit. Check that
it works now.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-id: 20190927122355.7344-4-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
tests/qemu-iotests/165 | 57
From: Vladimir Sementsov-Ogievskiy
We'll need reverse-foreach in the following commit, QTAILQ support it,
so move to QTAILQ.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-id: 20190927122355.7344-2-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
include
From: Vladimir Sementsov-Ogievskiy
Add bs field to BdrvDirtyBitmap structure. Drop BlockDriverState
parameter from bitmap APIs where possible.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190916141911.5255-3-vsement...@virtuozzo.com
[Rebased on top of block
From: Vladimir Sementsov-Ogievskiy
It's more comfortable to not deal with local_err.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190920082543.23444-3-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
block/qcow2.h| 5 ++---
include
I already try to make sure all bitmaps patches have been reviewed by both
Red Hat and Virtuozzo anyway, so this formalizes the arrangement.
Fam meanwhile is no longer as active, so I am removing him as a co-maintainer
simply to reflect the current practice.
Signed-off-by: John Snow
Reviewed
USE in the image.
- Consider unexpected bitmap as a corruption and check other
combinations of in-image and in-RAM bitmaps.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-id: 20190927122355.7344-9-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
block/qcow2-bitmap.c |
From: Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-id: 20190927122355.7344-8-vsement...@virtuozzo.com
[Maintainer edit: removed 260 from auto group per Peter Maydell. --js]
Signed-off-by: John Snow
---
tests/qemu-iotests/260 | 89
bitmaps rw will be fixed in the following
patches.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190927122355.7344-7-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
block/qcow2.h| 3 ++-
block/qcow2-bitmap.c | 49
aps_rw did a wrong
check for being writable, when actually it only need writable file
child not self.
So, as it's fixed, let's move things to correct place.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Acked-by: Max Reitz
Message-id: 20190927122355.7344-10-v
This parameter has been deprecated since 2.12.0 and is eligible for
removal. Remove this parameter as it is actually completely ignored;
let's not give false hope.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-id: 20191002232411.29968-1-js
From: Vladimir Sementsov-Ogievskiy
The function is unused, drop it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190927122355.7344-6-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
block/qcow2.h| 2 --
block/qcow2-bitmap.c | 15
It's an old compatibility shim that just delegates to ide-cd or ide-hd.
I'd like to refactor these some day, and getting rid of the super-object
will make that easier.
Either way, we don't need this.
Signed-off-by: John Snow
Reviewed-by: Thomas Huth
Reviewed-by: Markus Armbruster
ACKed
-request
for you to fetch changes up to c35564caf20e8d3431786dddf0fa513daa7d7f3c:
hd-geo-test: Add tests for lchs override (2019-10-31 06:11:34 -0400)
Pull request
John
From: Sam Eiderman
Fixing tabbing in block related macros.
Signed-off-by: Sam Eiderman
Signed-off-by: Sam Eiderman
Reviewed-by: Karl Heubaum
Reviewed-by: Arbel Moshe
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: John Snow
---
include/hw/block/block.h | 16
hw/ide
* virtio-blk-pci
In future commits we will use the provided LCHS and pass it to the BIOS
through fw_cfg to be supplied using INT13 routines.
Reviewed-by: Karl Heubaum
Reviewed-by: Arbel Moshe
Signed-off-by: Sam Eiderman
Signed-off-by: Sam Eiderman
Reviewed-by: Philippe Mathieu-Da
-by: Philippe Mathieu-Daudé
Signed-off-by: John Snow
---
include/sysemu/sysemu.h | 3 +++
bootdevice.c| 55 +
2 files changed, 58 insertions(+)
diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
index 44f18eb739..5bc5c79cbc 100644
-Daudé
Signed-off-by: Sam Eiderman
Signed-off-by: Sam Eiderman
Tested-by: Philippe Mathieu-Daudé
Signed-off-by: John Snow
---
bootdevice.c | 61 +---
1 file changed, 34 insertions(+), 27 deletions(-)
diff --git a/bootdevice.c b/bootdevice.c
index
n
Signed-off-by: Sam Eiderman
Tested-by: Philippe Mathieu-Daudé
Signed-off-by: John Snow
---
include/sysemu/sysemu.h | 1 +
bootdevice.c| 31 +++
hw/nvram/fw_cfg.c | 14 +++---
3 files changed, 43 insertions(+), 3 deletions(-)
diff --git a/inc
Reviewed-by: Arbel Moshe
Signed-off-by: Sam Eiderman
Signed-off-by: Sam Eiderman
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
Signed-off-by: John Snow
---
hw/block/virtio-blk.c | 6 ++
hw/ide/qdev.c | 5 +
hw/scsi/scsi-disk.c | 12
3
-off-by: John Snow
---
include/hw/scsi/scsi.h | 1 +
hw/scsi/scsi-bus.c | 16
2 files changed, 17 insertions(+)
diff --git a/include/hw/scsi/scsi.h b/include/hw/scsi/scsi.h
index d77a92361b..332ef602f4 100644
--- a/include/hw/scsi/scsi.h
+++ b/include/hw/scsi/scsi.h
@@ -59,6
.
Reviewed-by: Karl Heubaum
Reviewed-by: Arbel Moshe
Signed-off-by: Sam Eiderman
Signed-off-by: Sam Eiderman
Signed-off-by: John Snow
---
tests/hd-geo-test.c| 551 +
tests/Makefile.include | 2 +-
2 files changed, 552 insertions(+), 1 deletion(-)
diff
This parameter has been deprecated since 2.12.0 and is eligible for
removal. Remove this parameter as it is actually completely ignored;
let's not give false hope.
Signed-off-by: John Snow
---
qemu-deprecated.texi | 20 +++-
qapi/block-core.json | 6 +-
blockdev.c
happens if we
actually stop dropping features we claimed were deprecated.
John Snow (1):
dirty-bitmaps: remove deprecated autoload parameter
qemu-deprecated.texi | 20 +++-
qapi/block-core.json | 6 +-
blockdev.c | 6 --
3 files changed, 16 insertions(+), 16
On 8/20/19 6:25 PM, John Snow wrote:
> Hi, downstream here at Red Hat I've been fielding some questions about
> the usability and feature readiness of Bitmaps (and related features) in
> QEMU.
>
> Here are some questions I answered internally that I am copying to the
> li
On 9/25/19 3:20 AM, Vladimir Sementsov-Ogievskiy wrote:
> 25.09.2019 2:01, John Snow wrote:
>> This parameter has been deprecated since 2.12.0 and is eligible for
>> removal. Remove this parameter as it is actually completely ignored;
>> let's not give false hope.
>>
On 9/25/19 11:11 AM, Vladimir Sementsov-Ogievskiy wrote:
> 25.09.2019 16:52, John Snow wrote:
>>
>>
>> On 8/20/19 6:25 PM, John Snow wrote:
>>> Hi, downstream here at Red Hat I've been fielding some questions about
>>> the usability and feature rea
It's an old compatibility shim that just delegates to ide-cd or ide-hd.
I'd like to refactor these some day, and getting rid of the super-object
will make that easier.
Either way, we don't need this.
Signed-off-by: John Snow
---
qemu-deprecated.texi | 5 +
hw/ide/qdev.c
John Snow (1):
IDE: deprecate ide-drive
qemu-deprecated.texi | 5 +
hw/ide/qdev.c | 3 +++
tests/qemu-iotests/051.pc.out | 6 --
3 files changed, 12 insertions(+), 2 deletions(-)
--
2.21.0
--
libvir-list mailing list
libvir-list@redhat.com
https
On 10/7/19 5:49 AM, Markus Armbruster wrote:
> John Snow writes:
>
>> It's an old compatibility shim that just delegates to ide-cd or ide-hd.
>> I'd like to refactor these some day, and getting rid of the super-object
>> will make that easier.
>
> Device &q
It's an old compatibility shim that just delegates to ide-cd or ide-hd.
I'd like to refactor these some day, and getting rid of the super-object
will make that easier.
Either way, we don't need this.
Libvirt-checked-by: Peter Krempa
Signed-off-by: John Snow
---
qemu-deprecated.texi
V2: Change phrasings and spellings as Markus suggested.
John Snow (1):
IDE: deprecate ide-drive
qemu-deprecated.texi | 5 +
hw/ide/qdev.c | 3 +++
tests/qemu-iotests/051.pc.out | 6 --
3 files changed, 12 insertions(+), 2 deletions(-)
--
2.21.0
--
libvir
On 10/8/19 2:51 AM, Markus Armbruster wrote:
>> I'll respin to hit the tests with a stiffer scrub-brush.
> Thanks!
051 is the only test I can find that uses ide-drive, and the non-pc
version of the test doesn't seem to use it, so this actually seems
sufficient.
I'd like to keep the test for
On 10/10/19 7:54 AM, Peter Krempa wrote:
> On Thu, Oct 10, 2019 at 13:42:26 +0200, Philippe Mathieu-Daudé wrote:
>> On 10/10/19 1:26 PM, Peter Krempa wrote:
>>> On Thu, Oct 10, 2019 at 13:22:37 +0200, Philippe Mathieu-Daudé wrote:
>>>> On 10/10/19 12:43 AM, John
On 10/2/19 7:24 PM, John Snow wrote:
> This parameter has been deprecated since 2.12.0 and is eligible for
> removal. Remove this parameter as it is actually completely ignored;
> let's not give false hope.
>
> Signed-off-by: John Snow
> Reviewed-by: Eric Blake
>
This parameter has been deprecated since 2.12.0 and is eligible for
removal. Remove this parameter as it is actually completely ignored;
let's not give false hope.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
V2: Change 2.12.0 -> 4.
On 10/2/19 7:22 PM, John Snow wrote:
> This parameter has been deprecated since 2.12.0 and is eligible for
> removal. Remove this parameter as it is actually completely ignored;
> let's not give false hope.
>
> Signed-off-by: John Snow
> Reviewed-by: Eric Blake
>
This parameter has been deprecated since 2.12.0 and is eligible for
removal. Remove this parameter as it is actually completely ignored;
let's not give false hope.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
V2: Change 2.12.0 -> 4.
USE in the image.
- Consider unexpected bitmap as a corruption and check other
combinations of in-image and in-RAM bitmaps.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-id: 20190927122355.7344-9-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
block/qcow2-bitmap.c |
aps_rw did a wrong
check for being writable, when actually it only need writable file
child not self.
So, as it's fixed, let's move things to correct place.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Acked-by: Max Reitz
Message-id: 20190927122355.7344-10-v
From: Vladimir Sementsov-Ogievskiy
Add bs field to BdrvDirtyBitmap structure. Drop BlockDriverState
parameter from bitmap APIs where possible.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190916141911.5255-3-vsement...@virtuozzo.com
Signed-off-by: John Snow
From: Vladimir Sementsov-Ogievskiy
We'll need reverse-foreach in the following commit, QTAILQ support it,
so move to QTAILQ.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-id: 20190927122355.7344-2-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
include
reopen commit. Reverse
reopen order to fix it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Acked-by: Max Reitz
Acked-by: John Snow
Message-id: 20190927122355.7344-3-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
block.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions
From: Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-id: 20190927122355.7344-8-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
tests/qemu-iotests/260 | 89 ++
tests/qemu-iotests/260.out | 52
From: Vladimir Sementsov-Ogievskiy
The function is unused, drop it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190927122355.7344-6-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
block/qcow2.h| 2 --
block/qcow2-bitmap.c | 15
I already try to make sure all bitmaps patches have been reviewed by both
Red Hat and Virtuozzo anyway, so this formalizes the arrangement.
Fam meanwhile is no longer as active, so I am removing him as a co-maintainer
simply to reflect the current practice.
Signed-off-by: John Snow
Reviewed
bitmaps rw will be fixed in the following
patches.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190927122355.7344-7-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
block/qcow2.h| 3 ++-
block/qcow2-bitmap.c | 49
This parameter has been deprecated since 2.12.0 and is eligible for
removal. Remove this parameter as it is actually completely ignored;
let's not give false hope.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-id: 20191002232411.29968-1-js
drop IN_USE flag
for unchanged bitmaps in the image.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190927122355.7344-5-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
include/block/dirty-bitmap.h | 1 -
block/dirty-bitmap.c | 12
On 10/11/19 5:12 AM, Peter Krempa wrote:
> On Thu, Oct 10, 2019 at 14:08:12 -0400, John Snow wrote:
>> On 10/10/19 7:54 AM, Peter Krempa wrote:
>>> On Thu, Oct 10, 2019 at 13:42:26 +0200, Philippe Mathieu-Daudé wrote:
>>>> On 10/10/19 1:26 PM, Peter Krempa wrote:
John Snow (2):
MAINTAINERS: Add Vladimir as a reviewer for bitmaps
dirty-bitmaps: remove deprecated autoload parameter
Vladimir Sementsov-Ogievskiy (17):
util/hbitmap: strict hbitmap_reset
block: move bdrv_can_store_new_dirty_bitmap to block/dirty-bitmap.c
block/dirty-bitmap: return
From: Vladimir Sementsov-Ogievskiy
block/dirty-bitmap.c seems to be more appropriate for it and
bdrv_remove_persistent_dirty_bitmap already in it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190920082543.23444-2-vsement...@virtuozzo.com
Signed-off-by: John
ore obvious that it's not per-bitmap
lock. Still, for simplicity, leave bdrv_dirty_bitmap_lock/unlock
functions as an external API.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190916141911.5255-4-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
block/di
From: Vladimir Sementsov-Ogievskiy
Drop meta bitmaps, as they are unused.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190916141911.5255-2-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
include/block/dirty-bitmap.h | 5
block/dirty-bitmap.c
From: Vladimir Sementsov-Ogievskiy
It's more comfortable to not deal with local_err.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190920082543.23444-3-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
block/qcow2.h| 5 ++---
include
qcow2_can_store_new_dirty_bitmap and
qcow2_remove_persistent_dirty_bitmap to coroutine context.
Since we work in coroutines in correct aio context, we don't need
context acquiring in blockdev.c anymore, drop it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id
hb->orig_size.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id: <20190806152611.280389-1-vsement...@virtuozzo.com>
[Maintainer edit: Max's suggestions from on-list. --js]
Signed-off-by: John Snow
---
include/qemu/hbitmap.h | 5 +
tests/test-hbitmap.c
From: Vladimir Sementsov-Ogievskiy
Reopening bitmaps to RW was broken prior to previous commit. Check that
it works now.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-id: 20190927122355.7344-4-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
tests/qemu-iotests/165 | 57
From: Vladimir Sementsov-Ogievskiy
bdrv_dirty_bitmap_next is always used in same pattern. So, split it
into _next and _first, instead of combining two functions into one and
add FOR_EACH_DIRTY_BITMAP macro.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id
On 10/11/19 5:48 PM, Eric Blake wrote:
> On 10/11/19 4:25 PM, John Snow wrote:
>> From: Vladimir Sementsov-Ogievskiy
>>
>> hbitmap_reset has an unobvious property: it rounds requested region up.
>> It may provoke bugs, like in recently fixed write-blocking mode of
qcow2_can_store_new_dirty_bitmap and
qcow2_remove_persistent_dirty_bitmap to coroutine context.
Since we work in coroutines in correct aio context, we don't need
context acquiring in blockdev.c anymore, drop it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id
From: Vladimir Sementsov-Ogievskiy
Add bs field to BdrvDirtyBitmap structure. Drop BlockDriverState
parameter from bitmap APIs where possible.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190916141911.5255-3-vsement...@virtuozzo.com
[Rebased on top of block
From: Vladimir Sementsov-Ogievskiy
Reopening bitmaps to RW was broken prior to previous commit. Check that
it works now.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-id: 20190927122355.7344-4-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
tests/qemu-iotests/165 | 57
I already try to make sure all bitmaps patches have been reviewed by both
Red Hat and Virtuozzo anyway, so this formalizes the arrangement.
Fam meanwhile is no longer as active, so I am removing him as a co-maintainer
simply to reflect the current practice.
Signed-off-by: John Snow
Reviewed
From: Vladimir Sementsov-Ogievskiy
We'll need reverse-foreach in the following commit, QTAILQ support it,
so move to QTAILQ.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-id: 20190927122355.7344-2-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
include
USE in the image.
- Consider unexpected bitmap as a corruption and check other
combinations of in-image and in-RAM bitmaps.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-id: 20190927122355.7344-9-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
block/qcow2-bitmap.c |
aps_rw did a wrong
check for being writable, when actually it only need writable file
child not self.
So, as it's fixed, let's move things to correct place.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Acked-by: Max Reitz
Message-id: 20190927122355.7344-10-v
From: Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-id: 20190927122355.7344-8-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
tests/qemu-iotests/260 | 89 ++
tests/qemu-iotests/260.out | 52
From: Vladimir Sementsov-Ogievskiy
The function is unused, drop it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190927122355.7344-6-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
block/qcow2.h| 2 --
block/qcow2-bitmap.c | 15
From: Vladimir Sementsov-Ogievskiy
It's more comfortable to not deal with local_err.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190920082543.23444-3-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
block/qcow2.h| 5 ++---
include
reopen commit. Reverse
reopen order to fix it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Acked-by: Max Reitz
Acked-by: John Snow
Message-id: 20190927122355.7344-3-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
block.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions
From: Vladimir Sementsov-Ogievskiy
block/dirty-bitmap.c seems to be more appropriate for it and
bdrv_remove_persistent_dirty_bitmap already in it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190920082543.23444-2-vsement...@virtuozzo.com
Signed-off-by: John
ore obvious that it's not per-bitmap
lock. Still, for simplicity, leave bdrv_dirty_bitmap_lock/unlock
functions as an external API.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190916141911.5255-4-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
block/di
From: Vladimir Sementsov-Ogievskiy
Drop meta bitmaps, as they are unused.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190916141911.5255-2-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
include/block/dirty-bitmap.h | 5
block/dirty-bitmap.c
hb->orig_size.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id: <20190806152611.280389-1-vsement...@virtuozzo.com>
[Maintainer edit: Max's suggestions from on-list. --js]
[Maintainer edit: Eric's suggestion for aligned macro. --js]
Signed-off-by: John S
John Snow (2):
MAINTAINERS: Add Vladimir as a reviewer for bitmaps
dirty-bitmaps: remove deprecated autoload parameter
Vladimir Sementsov-Ogievskiy (17):
util/hbitmap: strict hbitmap_reset
block: move bdrv_can_store_new_dirty_bitmap to block/dirty-bitmap.c
block/dirty-bitmap
On 10/11/19 7:18 PM, John Snow wrote:
>
>
> On 10/11/19 5:48 PM, Eric Blake wrote:
>> On 10/11/19 4:25 PM, John Snow wrote:
>>> From: Vladimir Sementsov-Ogievskiy
>>>
>>> hbitmap_reset has an unobvious property: it rounds requested region up.
>&
drop IN_USE flag
for unchanged bitmaps in the image.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190927122355.7344-5-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
include/block/dirty-bitmap.h | 1 -
block/dirty-bitmap.c | 12
This parameter has been deprecated since 2.12.0 and is eligible for
removal. Remove this parameter as it is actually completely ignored;
let's not give false hope.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-id: 20191002232411.29968-1-js
From: Vladimir Sementsov-Ogievskiy
bdrv_dirty_bitmap_next is always used in same pattern. So, split it
into _next and _first, instead of combining two functions into one and
add FOR_EACH_DIRTY_BITMAP macro.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id
bitmaps rw will be fixed in the following
patches.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Message-id: 20190927122355.7344-7-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
block/qcow2.h| 3 ++-
block/qcow2-bitmap.c | 49
becomes clean enough
to not require any comment.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-id: 20200205112041.6003-10-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
nbd/server.c | 59 +---
1 file changed, 19
From: Vladimir Sementsov-Ogievskiy
store_bitmap_data() loop does bdrv_set_dirty_iter() on each iteration,
which means that we actually don't need iterator itself and we can use
simpler bitmap API.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Reviewed-by: John Snow
Signed-off-by: John Snow
---
nbd/server.c | 210 +--
1 file changed, 118 insertions(+), 92 deletions(-)
diff --git a/nbd/server.c b/nbd/server.c
index 3106aaf3b4..f90bb33a75 100644
--- a/nbd/server.c
+++ b/nbd/server.c
@@ -1909,27 +1909,98 @@ static
images, which can't
exceed INT64_MAX anyway.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: John Snow
Message-id: 20200205112041.6003-2-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
util/hbitmap.c | 2 ++
1 file changed, 2 insertions
From: Vladimir Sementsov-Ogievskiy
The function is definitely internal (it's not used by third party and
it has complicated interface). Move it to .c file.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Reviewed-by: John Snow
Message-id: 20200205112041.6003-3-vsement
From: Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Reviewed-by: John Snow
Message-id: 20200205112041.6003-5-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
include/qemu/hbitmap.h | 21
tests/test-hbitmap.c | 115
.
Reported-by: Peter Maydell
Signed-off-by: Eric Blake
Reviewed-by: John Snow
Message-id: 20200317175534.196295-1-ebl...@redhat.com
Signed-off-by: John Snow
---
configure | 20
1 file changed, 20 insertions(+)
diff --git a/configure b/configure
index 06fcd070fb..479336bf6e
some new checks.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Reviewed-by: John Snow
Message-id: 20200205112041.6003-7-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
include/block/dirty-bitmap.h | 2 +
include/qemu/hbitmap.h | 13
block/dirty-bitmap.c
The following changes since commit d649689a8ecb2e276cc20d3af6d416e3c299cb17:
Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging
(2020-03-17 18:33:05 +)
are available in the Git repository at:
https://github.com/jnsnow/qemu.git tags/bitmaps-pull-request
for
with hbitmap_next_zero, therefore we want
hbitmap_next_zero parameter type to be int64_t too.
So, for convenience update all parameters of *_next_zero and
*_next_dirty_area to be int64_t.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Reviewed-by: John Snow
Message-id
y to limit resulting area size, not
limiting searching area. This will be used in NBD code in further
commit. (Note that now bdrv_dirty_bitmap_next_dirty_area is unused)
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Reviewed-by: John Snow
Message-id: 20200205112041.6003
From: Vladimir Sementsov-Ogievskiy
Function is internal and even commented as internal. Drop its
definition from .h file.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Reviewed-by: John Snow
Message-id: 20200205112041.6003-4-vsement...@virtuozzo.com
Signed-off-by: John
On 3/19/20 1:57 PM, Peter Maydell wrote:
> On Wed, 18 Mar 2020 at 20:24, John Snow wrote:
>>
>> The following changes since commit d649689a8ecb2e276cc20d3af6d416e3c299cb17:
>>
>> Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into
>> s
The following changes since commit 6e8a73e911f066527e775e04b98f31ebd19db600:
Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into
staging (2020-03-11 14:41:27 +)
are available in the Git repository at:
https://github.com/jnsnow/qemu.git tags/bitmaps-pull-request
Signed-off-by: John Snow
---
nbd/server.c | 210 +--
1 file changed, 118 insertions(+), 92 deletions(-)
diff --git a/nbd/server.c b/nbd/server.c
index 3106aaf3b4..f90bb33a75 100644
--- a/nbd/server.c
+++ b/nbd/server.c
@@ -1909,27 +1909,98 @@ static
From: Vladimir Sementsov-Ogievskiy
store_bitmap_data() loop does bdrv_set_dirty_iter() on each iteration,
which means that we actually don't need iterator itself and we can use
simpler bitmap API.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Reviewed-by: John Snow
From: Vladimir Sementsov-Ogievskiy
The function is definitely internal (it's not used by third party and
it has complicated interface). Move it to .c file.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Reviewed-by: John Snow
Message-id: 20200205112041.6003-3-vsement
becomes clean enough
to not require any comment.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-id: 20200205112041.6003-10-vsement...@virtuozzo.com
Signed-off-by: John Snow
---
nbd/server.c | 59 +---
1 file changed, 19
101 - 200 of 240 matches
Mail list logo