Signed-off-by: Jonathon Jongsma
---
src/bhyve/bhyve_capabilities.h | 11 ---
src/bhyve/bhyve_command.h | 15 ++-
src/bhyve/bhyve_conf.h | 7 ++-
src/bhyve/bhyve_device.h| 11 ---
src/bhyve/bhyve_domain.h| 11 ---
src/bhyve
uggestions welcome.
I'll follow up with the remaining changes if this division looks acceptable.
Jonathon Jongsma (19):
Use #pragma once in driver headers
src/access: use #pragma once in headers
src/admin: use #pragma once in headers
src/bhyve: use #pragma once in headers
conf: domain: use #p
Signed-off-by: Jonathon Jongsma
---
src/interface/interface_driver.h | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/interface/interface_driver.h b/src/interface/interface_driver.h
index 242e00a824..eee01d4aec 100644
--- a/src/interface/interface_driver.h
+++ b/src
Signed-off-by: Jonathon Jongsma
---
src/datatypes.h | 89 -
1 file changed, 43 insertions(+), 46 deletions(-)
diff --git a/src/datatypes.h b/src/datatypes.h
index 87f3d5e095..36d4cb9314 100644
--- a/src/datatypes.h
+++ b/src/datatypes.h
@@ -19,15
Signed-off-by: Jonathon Jongsma
---
src/hyperv/hyperv_driver.h | 5 +
src/hyperv/hyperv_private.h | 13 +---
src/hyperv/hyperv_util.h| 9 +++--
src/hyperv/hyperv_wmi.h | 21 +---
src/hyperv/hyperv_wmi_classes.h | 27
Signed-off-by: Jonathon Jongsma
---
src/internal.h | 295 -
1 file changed, 146 insertions(+), 149 deletions(-)
diff --git a/src/internal.h b/src/internal.h
index 5a868bb00c..f718895460 100644
--- a/src/internal.h
+++ b/src/internal.h
@@ -18,101
Signed-off-by: Jonathon Jongsma
---
src/esx/esx_driver.h| 5 +---
src/esx/esx_interface_driver.h | 7 ++
src/esx/esx_network_driver.h| 7 ++
src/esx/esx_private.h | 15 +---
src/esx/esx_storage_backend_iscsi.h | 7 ++
src/esx
Signed-off-by: Jonathon Jongsma
---
src/libxl/libxl_capabilities.h | 29 +-
src/libxl/libxl_conf.h | 101 -
src/libxl/libxl_domain.h | 29 +-
src/libxl/libxl_driver.h | 5 +-
src/libxl/libxl_logger.h | 7 +--
src
Signed-off-by: Jonathon Jongsma
---
src/conf/node_device_conf.h | 31 ++-
src/conf/node_device_event.h | 11 ---
src/conf/node_device_util.h | 7 ++-
src/conf/virnodedeviceobj.h | 13 +
4 files changed, 25 insertions(+), 37 deletions
Signed-off-by: Jonathon Jongsma
---
src/conf/capabilities.h | 23 +---
src/conf/cpu_conf.h | 23 +---
src/conf/device_conf.h | 33 +
src/conf/interface_conf.h | 23
Signed-off-by: Jonathon Jongsma
---
src/conf/storage_adapter_conf.h | 11 -
src/conf/storage_capabilities.h | 8 ++-
src/conf/storage_conf.h | 41 +++--
src/conf/storage_event.h| 11 -
src/conf/virstorageobj.h| 11
Signed-off-by: Jonathon Jongsma
---
src/cpu/cpu.h| 19 ++---
src/cpu/cpu_arm.h| 7 ++---
src/cpu/cpu_map.h| 7 ++---
src/cpu/cpu_ppc64.h | 7 ++---
src/cpu/cpu_ppc64_data.h | 8 ++
src/cpu/cpu_s390.h | 7 ++---
src/cpu/cpu_x86.h| 9
Signed-off-by: Jonathon Jongsma
---
src/admin/admin_server.h | 9 +++--
src/admin/admin_server_dispatch.h | 11 ---
2 files changed, 7 insertions(+), 13 deletions(-)
diff --git a/src/admin/admin_server.h b/src/admin/admin_server.h
index 43f2b85fc1..1d5cbec55f 100644
Signed-off-by: Jonathon Jongsma
---
src/conf/domain_addr.h | 16 +++---
src/conf/domain_audit.h| 10 ++--
src/conf/domain_capabilities.h | 15 +++---
src/conf/domain_conf.h | 91 --
src/conf/domain_event.h| 11 ++--
src/conf
Signed-off-by: Jonathon Jongsma
---
src/driver-hypervisor.h | 12
src/driver-interface.h | 12
src/driver-network.h| 12
src/driver-nodedev.h| 12
src/driver-nwfilter.h | 12
src/driver-secret.h | 12
Signed-off-by: Jonathon Jongsma
---
src/conf/nwfilter_conf.h | 93 ++--
src/conf/nwfilter_ipaddrmap.h| 5 +-
src/conf/nwfilter_params.h | 28 -
src/conf/virnwfilterbindingdef.h | 13 ++--
src/conf/virnwfilterbindingobj.h | 11
Signed-off-by: Jonathon Jongsma
---
src/conf/netdev_bandwidth_conf.h | 15
src/conf/netdev_vlan_conf.h | 13 +++
src/conf/netdev_vport_profile_conf.h | 14 +++-
src/conf/network_conf.h | 52 +---
src/conf/network_event.h
Signed-off-by: Jonathon Jongsma
---
src/access/viraccessdriver.h | 10 +++---
src/access/viraccessdrivernop.h| 7 ++-
src/access/viraccessdriverpolkit.h | 7 ++-
src/access/viraccessdriverstack.h | 7 ++-
src/access/viraccessmanager.h | 26
Signed-off-by: Jonathon Jongsma
---
src/logging/log_daemon.h | 9 +++--
src/logging/log_daemon_config.h | 7 ++-
src/logging/log_daemon_dispatch.h | 7 ++-
src/logging/log_handler.h | 9 +++--
src/logging/log_manager.h | 9 +++--
5 files changed, 13
Signed-off-by: Jonathon Jongsma
---
src/libvirt_internal.h | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/libvirt_internal.h b/src/libvirt_internal.h
index 8be1257814..3f012fdd4b 100644
--- a/src/libvirt_internal.h
+++ b/src/libvirt_internal.h
@@ -22,10 +22,9
On Fri, 2019-06-14 at 08:07 +0200, Ján Tomko wrote:
> On Thu, Jun 13, 2019 at 10:23:30AM -0500, Eric Blake wrote:
> > On 6/13/19 10:06 AM, Ján Tomko wrote:
> >
> > > > Jonathon Jongsma (19):
> > > > Use #pragma once in driver headers
> > > > s
Signed-off-by: Jonathon Jongsma
---
src/locking/domain_lock.h | 11 ---
src/locking/lock_daemon.h | 9 +++--
src/locking/lock_daemon_config.h | 7 ++-
src/locking/lock_daemon_dispatch.h | 7 ++-
src/locking/lock_driver.h | 18
Signed-off-by: Jonathon Jongsma
---
src/util/viratomic.h | 91 +---
1 file changed, 44 insertions(+), 47 deletions(-)
diff --git a/src/util/viratomic.h b/src/util/viratomic.h
index 0b2b3df081..35800dafcd 100644
--- a/src/util/viratomic.h
+++ b/src/util
Signed-off-by: Jonathon Jongsma
---
src/remote/remote_daemon.h | 35 +---
src/remote/remote_daemon_config.h | 7 ++
src/remote/remote_daemon_dispatch.h | 11 -
src/remote/remote_daemon_stream.h | 7 ++
src/remote/remote_driver.h
Signed-off-by: Jonathon Jongsma
---
src/secret/secret_driver.h | 5 +
src/secret/secret_util.h | 8 +++-
2 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/src/secret/secret_driver.h b/src/secret/secret_driver.h
index b7e46ee045..3dcf420792 100644
--- a/src/secret
Signed-off-by: Jonathon Jongsma
---
src/nwfilter/nwfilter_dhcpsnoop.h | 6 ++
src/nwfilter/nwfilter_driver.h| 9 +++--
src/nwfilter/nwfilter_ebiptables_driver.h | 13 +
src/nwfilter/nwfilter_gentech_driver.h| 11 ---
src/nwfilter
Signed-off-by: Jonathon Jongsma
---
src/lxc/lxc_cgroup.h| 13 +---
src/lxc/lxc_conf.h | 47 +++--
src/lxc/lxc_container.h | 37 +++-
src/lxc/lxc_domain.h| 13 +---
src/lxc/lxc_driver.h| 5 +
src
Signed-off-by: Jonathon Jongsma
---
src/network/bridge_driver.h | 15 ++-
src/network/bridge_driver_platform.h | 15 ++-
2 files changed, 12 insertions(+), 18 deletions(-)
diff --git a/src/network/bridge_driver.h b/src/network/bridge_driver.h
index 44c79f555e
Signed-off-by: Jonathon Jongsma
---
src/util/vircommand.h | 11 ---
src/util/vircommandpriv.h | 7 ++-
2 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/src/util/vircommand.h b/src/util/vircommand.h
index c03da43f25..c9a8d3c41c 100644
--- a/src/util/vircommand.h
Signed-off-by: Jonathon Jongsma
---
src/util/virstring.h | 37 +
1 file changed, 17 insertions(+), 20 deletions(-)
diff --git a/src/util/virstring.h b/src/util/virstring.h
index b2cd8ea53c..5e64ad1bb9 100644
--- a/src/util/virstring.h
+++ b/src/util
Signed-off-by: Jonathon Jongsma
---
src/util/virarptable.h | 7 ++
src/util/viraudit.h | 15 +---
src/util/virauth.h | 8 +++---
src/util/virauthconfig.h | 9 +++
src/util/virautoclean.h | 17 ++---
src/util/virbitmap.h | 11
Signed-off-by: Jonathon Jongsma
---
src/util/virmacaddr.h | 17 +++--
src/util/virmacmap.h | 5 +
2 files changed, 8 insertions(+), 14 deletions(-)
diff --git a/src/util/virmacaddr.h b/src/util/virmacaddr.h
index 55f9d61abe..55cfd12164 100644
--- a/src/util/virmacaddr.h
+++ b
Signed-off-by: Jonathon Jongsma
---
src/util/vircgroup.h| 10 --
src/util/vircgroupbackend.h | 15 ++-
src/util/vircgroupv1.h | 5 +
src/util/vircgroupv2.h | 5 +
4 files changed, 12 insertions(+), 23 deletions(-)
diff --git a/src/util/vircgroup.h
Signed-off-by: Jonathon Jongsma
---
src/util/virfirewall.h | 11 ---
src/util/virfirewalld.h | 7 ++-
src/util/virfirewalldpriv.h | 7 ++-
src/util/virfirewallpriv.h | 7 ++-
4 files changed, 10 insertions(+), 22 deletions(-)
diff --git a/src/util/virfirewall.h
Signed-off-by: Jonathon Jongsma
---
src/openvz/openvz_conf.h | 21 +
src/openvz/openvz_driver.h | 11 ---
src/openvz/openvz_util.h | 5 +
3 files changed, 14 insertions(+), 23 deletions(-)
diff --git a/src/openvz/openvz_conf.h b/src/openvz/openvz_conf.h
Signed-off-by: Jonathon Jongsma
---
src/security/security_apparmor.h | 13 +
src/security/security_dac.h | 7 ++-
src/security/security_driver.h | 11 ---
src/security/security_manager.h | 13 +
src/security/security_nop.h | 7 ++-
src
Signed-off-by: Jonathon Jongsma
---
src/util/viralloc.h | 101 +---
1 file changed, 49 insertions(+), 52 deletions(-)
diff --git a/src/util/viralloc.h b/src/util/viralloc.h
index 92c71d9a1a..2b82096fde 100644
--- a/src/util/viralloc.h
+++ b/src/util
Signed-off-by: Jonathon Jongsma
---
src/util/virhostcpu.h | 17 +++--
src/util/virhostcpupriv.h | 11 ---
src/util/virhostdev.h | 19 ---
src/util/virhostmem.h | 7 ++-
4 files changed, 21 insertions(+), 33 deletions(-)
diff --git a/src/util
Signed-off-by: Jonathon Jongsma
---
src/util/virarch.h | 41 +++--
1 file changed, 19 insertions(+), 22 deletions(-)
diff --git a/src/util/virarch.h b/src/util/virarch.h
index 638ca9f484..233b83f31b 100644
--- a/src/util/virarch.h
+++ b/src/util/virarch.h
Signed-off-by: Jonathon Jongsma
---
src/util/virsocketaddr.h | 45 +++-
1 file changed, 21 insertions(+), 24 deletions(-)
diff --git a/src/util/virsocketaddr.h b/src/util/virsocketaddr.h
index 5230cddf64..b2ecb3c748 100644
--- a/src/util/virsocketaddr.h
+++ b
Signed-off-by: Jonathon Jongsma
---
tools/nss/libvirt_nss.h | 27 -
tools/virsh-completer.h | 6 +-
tools/virsh-console.h| 11 ++--
tools/virsh-domain-monitor.h | 7 +--
tools/virsh-domain.h | 7 +--
tools/virsh-host.h
Signed-off-by: Jonathon Jongsma
---
src/phyp/phyp_driver.h | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/phyp/phyp_driver.h b/src/phyp/phyp_driver.h
index 52a5d2bd17..d7076e3697 100644
--- a/src/phyp/phyp_driver.h
+++ b/src/phyp/phyp_driver.h
@@ -19,9 +19,6
Signed-off-by: Jonathon Jongsma
---
src/util/virstorageencryption.h | 17 +++--
src/util/virstoragefile.h| 31 ++-
src/util/virstoragefilebackend.h | 9 +++--
3 files changed, 24 insertions(+), 33 deletions(-)
diff --git a/src/util
Signed-off-by: Jonathon Jongsma
---
src/util/virdbus.h | 22 ++
src/util/virdbuspriv.h | 11 ---
2 files changed, 14 insertions(+), 19 deletions(-)
diff --git a/src/util/virdbus.h b/src/util/virdbus.h
index c1e5de31ab..083c074d59 100644
--- a/src/util/virdbus.h
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_agent.h| 8 ++-
src/qemu/qemu_alias.h| 13 ++---
src/qemu/qemu_block.h| 17 +++---
src/qemu/qemu_blockjob.h | 9 ++--
src/qemu/qemu_capabilities.h | 23
src/qemu
Signed-off-by: Jonathon Jongsma
---
src/rpc/virkeepalive.h| 9 +++-
src/rpc/virnetclient.h| 41 ---
src/rpc/virnetclientprogram.h | 15 +
src/rpc/virnetclientstream.h | 9 +++-
src/rpc/virnetdaemon.h| 21
Signed-off-by: Jonathon Jongsma
---
src/util/virfile.h | 61 ++
1 file changed, 29 insertions(+), 32 deletions(-)
diff --git a/src/util/virfile.h b/src/util/virfile.h
index 641960e2ca..094c92e2b9 100644
--- a/src/util/virfile.h
+++ b/src/util
Signed-off-by: Jonathon Jongsma
---
src/util/virnetdev.h | 33 +++-
src/util/virnetdevbandwidth.h| 8 +++-
src/util/virnetdevbridge.h | 8 +++-
src/util/virnetdevip.h | 9 +++--
src/util/virnetdevmacvlan.h | 22
Signed-off-by: Jonathon Jongsma
---
src/util/virthread.h | 19 ---
src/util/virthreadjob.h | 6 +-
src/util/virthreadpool.h | 9 +++--
3 files changed, 12 insertions(+), 22 deletions(-)
diff --git a/src/util/virthread.h b/src/util/virthread.h
index 218d1fcd3f
script now enforces using '#ifndef/#define/#endif' for public headers and
'#pragma once' for
internal headers.
Jonathon Jongsma (46):
src/locking: use #pragma once in headers
src/lxc: use #pragma once in headers
src/network: use #pragma once in headers
src/nwfilter: use #pragma once in headers
Signed-off-by: Jonathon Jongsma
---
src/util/virprobe.h | 63 +
1 file changed, 30 insertions(+), 33 deletions(-)
diff --git a/src/util/virprobe.h b/src/util/virprobe.h
index 5635e58252..80a5f48ec8 100644
--- a/src/util/virprobe.h
+++ b/src/util
Signed-off-by: Jonathon Jongsma
---
src/util/virxml.h | 33 +++--
1 file changed, 15 insertions(+), 18 deletions(-)
diff --git a/src/util/virxml.h b/src/util/virxml.h
index 38031b62c5..6208977dd1 100644
--- a/src/util/virxml.h
+++ b/src/util/virxml.h
@@ -18,18 +18,17
Signed-off-by: Jonathon Jongsma
---
src/util/virnetlink.h | 37 +
1 file changed, 17 insertions(+), 20 deletions(-)
diff --git a/src/util/virnetlink.h b/src/util/virnetlink.h
index 1bc075a86f..6419a775e1 100644
--- a/src/util/virnetlink.h
+++ b/src/util
Signed-off-by: Jonathon Jongsma
---
src/util/virerror.h | 41 +++--
src/util/virerrorpriv.h | 5 +
2 files changed, 20 insertions(+), 26 deletions(-)
diff --git a/src/util/virerror.h b/src/util/virerror.h
index 8f51510dc2..4cfb0c18dd 100644
--- a/src
Signed-off-by: Jonathon Jongsma
---
src/vmware/vmware_conf.h | 19 ---
src/vmware/vmware_driver.h | 5 +
2 files changed, 9 insertions(+), 15 deletions(-)
diff --git a/src/vmware/vmware_conf.h b/src/vmware/vmware_conf.h
index 93b424ef2f..deeed22300 100644
--- a/src/vmware
Signed-off-by: Jonathon Jongsma
---
src/vz/vz_driver.h | 5 +
src/vz/vz_sdk.h| 9 +++--
src/vz/vz_utils.h | 37 +
3 files changed, 21 insertions(+), 30 deletions(-)
diff --git a/src/vz/vz_driver.h b/src/vz/vz_driver.h
index 593a585075
Signed-off-by: Jonathon Jongsma
---
src/vmx/vmx.h | 21 +
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/src/vmx/vmx.h b/src/vmx/vmx.h
index 8c068b4cb2..18478ac0ae 100644
--- a/src/vmx/vmx.h
+++ b/src/vmx/vmx.h
@@ -19,14 +19,13 @@
*
*/
-#ifndef
Signed-off-by: Jonathon Jongsma
---
src/xenapi/xenapi_driver.h | 5 +
src/xenapi/xenapi_driver_private.h | 17 +++--
src/xenapi/xenapi_utils.h | 15 ++-
src/xenconfig/xen_common.h | 17 +++--
src/xenconfig/xen_sxpr.h
Signed-off-by: Jonathon Jongsma
---
tests/qemumonitortestutils.h | 19 +++---
tests/qemusecuritytest.h | 7 +-
tests/testutils.h| 45 ++--
tests/testutilshostcpus.h| 11 ++-
tests/testutilslxc.h | 11 ++-
tests/testutilsqemu.h| 21 +++---
tests
Internal headers should use #pragma once instead of the standard #ifndef
guard. Public headers still require the existing header guard.
Signed-off-by: Jonathon Jongsma
---
build-aux/header-ifdef.pl | 35 ++-
1 file changed, 26 insertions(+), 9 deletions(-)
diff
Signed-off-by: Jonathon Jongsma
---
src/util/virobject.h | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/src/util/virobject.h b/src/util/virobject.h
index d13fc4b1ac..fe5dbe7326 100644
--- a/src/util/virobject.h
+++ b/src/util/virobject.h
@@ -19,11 +19,10
Signed-off-by: Jonathon Jongsma
---
src/util/virsysinfo.h | 13 +
src/util/virsysinfopriv.h | 5 +
2 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/src/util/virsysinfo.h b/src/util/virsysinfo.h
index c0015834bc..f30809294b 100644
--- a/src/util/virsysinfo.h
Signed-off-by: Jonathon Jongsma
---
src/util/virscsi.h | 11 ---
src/util/virscsihost.h | 7 ++-
src/util/virscsivhost.h | 13 +
3 files changed, 11 insertions(+), 20 deletions(-)
diff --git a/src/util/virscsi.h b/src/util/virscsi.h
index 907948455e..6cc68835b7
Signed-off-by: Jonathon Jongsma
---
src/storage/storage_backend.h | 13 -
src/storage/storage_backend_disk.h | 5 +---
src/storage/storage_backend_fs.h| 5 +---
src/storage/storage_backend_gluster.h | 5 +---
src/storage/storage_backend_iscsi.h
Signed-off-by: Jonathon Jongsma
---
src/util/virlog.h | 55 ++-
1 file changed, 26 insertions(+), 29 deletions(-)
diff --git a/src/util/virlog.h b/src/util/virlog.h
index 775a726b06..a30b760fb4 100644
--- a/src/util/virlog.h
+++ b/src/util/virlog.h
Signed-off-by: Jonathon Jongsma
---
src/util/virhash.h | 8 ++--
src/util/virhashcode.h | 7 ++-
2 files changed, 4 insertions(+), 11 deletions(-)
diff --git a/src/util/virhash.h b/src/util/virhash.h
index d2156a5ce0..ed3774e693 100644
--- a/src/util/virhash.h
+++ b/src/util
Signed-off-by: Jonathon Jongsma
---
src/test/test_driver.h | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/test/test_driver.h b/src/test/test_driver.h
index ff7803da7f..8c8a462db7 100644
--- a/src/test/test_driver.h
+++ b/src/test/test_driver.h
@@ -19,11 +19,8
Signed-off-by: Jonathon Jongsma
---
src/vbox/vbox_MSCOMGlue.h | 11 +--
src/vbox/vbox_common.h| 161 +-
src/vbox/vbox_driver.h| 19 ++--
src/vbox/vbox_get_driver.h| 7 +-
src/vbox/vbox_glue.h | 15 ++--
src/vbox
On Thu, 2019-06-13 at 10:23 -0500, Eric Blake wrote:
> On 6/13/19 10:06 AM, Ján Tomko wrote:
>
> > > Jonathon Jongsma (19):
> > > Use #pragma once in driver headers
> > > src/access: use #pragma once in headers
> > > src/admin: use #pragma once in
Internal headers should use #pragma once instead of the standard #ifndef
guard. Public headers still require the existing header guard.
Signed-off-by: Jonathon Jongsma
---
Changes in v2:
- fix error messages when no header guard is found (#ifndef for public
headers, #pragma for
internal
Signed-off-by: Jonathon Jongsma
---
src/conf/domain_conf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index d06e094b11..8604ba63d4 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -21375,7 +21375,7
to qemu), but is displayed in the XML definition. So by
changing this default value to 0, it will also be omitted from the XML
definition of the domain.
Fixes: rhbz#1447831
Signed-off-by: Jonathon Jongsma
---
This is an attempt to apply the fix suggested by Gerd at
https://bugzilla.redhat.com
On Fri, 2019-06-21 at 08:13 +0200, Peter Krempa wrote:
> On Thu, Jun 20, 2019 at 14:51:12 -0500, Jonathon Jongsma wrote:
> > Since the cirrus vga memory size isn't configurable, we can ignore
> > any
> > 'vram' attribute when parsing a domain definition. However, when no
&
On Fri, 2019-06-21 at 17:05 +0200, Peter Krempa wrote:
> On Fri, Jun 21, 2019 at 09:53:59 -0500, Jonathon Jongsma wrote:
> > On Fri, 2019-06-21 at 08:13 +0200, Peter Krempa wrote:
> > > On Thu, Jun 20, 2019 at 14:51:12 -0500, Jonathon Jongsma wrote:
> > > > Since th
Fix a filename and add a couple missing words.
Signed-off-by: Jonathon Jongsma
---
docs/api_extension.html.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/api_extension.html.in b/docs/api_extension.html.in
index d7fbbd6e90..3bbaf4893c 100644
--- a/docs
-by: Jonathon Jongsma
---
Note that the documentation may need to be changed depending on which version
the patch makes it
into. I suppose it'll miss 5.5.0 since we're in freeze right now.
Note: depending on which distribution you're using, you may need to copy the
vgabios into place in
order to test
in
qemuDomainDeviceCalculatePCIConnectFlags
Jonathon Jongsma (3):
qemu: Add bochs-display capability
qemu: minor refactor of video device string handling
conf: add 'bochs' video display type
docs/formatdomain.html.in | 5 +--
docs/schemas/domaincommon.rng
-by: Jonathon Jongsma
---
src/qemu/qemu_command.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 688dc324c6..2f98efd6bf 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -4748,13 +4748,12
Check whether qemu supports the bochs-display device and set a
capability. Update tests.
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_capabilities.c | 4
src/qemu/qemu_capabilities.h | 3 +++
tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml
Update schema and configuration to allow specifying new video type of
'bochs'. Add implementation and tests for qemu.
Signed-off-by: Jonathon Jongsma
---
docs/formatdomain.html.in | 5 +--
docs/schemas/domaincommon.rng | 1 +
src/conf/domain_conf.c
Add API for querying logged-in users from a domain implemented via
guest agent.
Signed-off-by: Jonathon Jongsma
---
include/libvirt/libvirt-domain.h | 18 ++
src/driver-hypervisor.h | 6
src/libvirt-domain.c | 62
src
Signed-off-by: Jonathon Jongsma
---
tools/virsh-domain.c | 76
tools/virsh.pod | 4 +++
2 files changed, 80 insertions(+)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 828ae30789..b964608987 100644
--- a/tools/virsh-domain.c
This function fetches the list of logged-in users from the qemu agent
and converts them into a form that can be used internally in libvirt.
Also add some basic tests for the function.
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_agent.c | 92 +++
src/qemu
Add daemon and client code to serialize/deserialize virDomainUserInfo
Signed-off-by: Jonathon Jongsma
---
src/remote/remote_daemon_dispatch.c | 89 +
src/remote/remote_driver.c | 82 +-
src/remote/remote_protocol.x| 26
was modelled on the implementation of
guest-get-fsinfo, which also returns an array of info structures. Since this is
my first time adding API or dealing with libvirt RPC stuff, I anticipate
several rounds of the series.
This series addresses https://bugzilla.redhat.com/show_bug.cgi?id=1704761
Jonathon
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_driver.c | 38 ++
1 file changed, 38 insertions(+)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 5a75f23981..27fcdd393d 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
On Thu, 2019-07-11 at 13:42 +0200, Peter Krempa wrote:
> On Thu, Jul 11, 2019 at 12:09:23 +0100, Daniel Berrange wrote:
> > On Wed, Jul 10, 2019 at 03:07:43PM -0500, Jonathon Jongsma wrote:
> > > Add API for querying logged-in users from a domain implemented
> >
Update schema and configuration to allow specifying new video type of
'bochs'. Add implementation and tests for qemu.
Signed-off-by: Jonathon Jongsma
---
docs/formatdomain.html.in | 5 ++-
docs/schemas/domaincommon.rng | 1 +
src/conf/domain_conf.c
Changes from v2:
- fix version number in documentation
- move bochs to its own case in virDomainVideoDefaultRAM()
- use pcieFlags instead of pciFlags in
qemuDomainDeviceCalculatePCIConnectFlags()
- use DO_TEST_CAPS_LATEST() in test
Jonathon Jongsma (2):
qemu: Add bochs-display capability
Check whether qemu supports the bochs-display device and set a
capability. Update tests.
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_capabilities.c | 4
src/qemu/qemu_capabilities.h | 3 +++
tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml
or not.
See https://bugzilla.redhat.com/show_bug.cgi?id=1699274
Signed-off-by: Jonathon Jongsma
---
NOTES:
- an argument could be made that we should simply do nothing here. mdevctl does
have support for automatically activating the mediated device when the parent
device becomes available (via udev
for a
missing mediated device.
Signed-off-by: Jonathon Jongsma
---
NOTE:
- previous patch which attempted to start missing devices using mdevctl has
been withdrawn.
src/util/virmdev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/util/virmdev.c b/src/util/virmdev.c
index
On Wed, 2019-08-14 at 16:14 +0200, Boris Fiuczynski wrote:
> On 8/14/19 12:02 AM, Jonathon Jongsma wrote:
> > When a host is rebooted, mediated devices disappear from
> > sysfs. mdevctl
> > (https://github.com/mdevctl/mdevctl) is a utility for managing and
> &g
This function queries the guest operating system information and adds
the returned information to an array of typed parameters with field
names intended to be returned in virDomainGetGuestInfo().
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_agent.c | 53 ++
src/qemu
This function adds the complete filesystem information returned by the
qemu agent to an array of typed parameters with field names intended to
to be returned by virDomainGetGuestInfo()
---
src/qemu/qemu_agent.c | 89 ++
src/qemu/qemu_agent.h | 5 +
tests/qemuagenttest.c | 210
This function queries timezone information within the guest and adds
the information to an array of typed parameters with field names
intended to be returned to virDomainGetGuestInfo()
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_agent.c | 46 ++
src/qemu
Add daemon and client code to serialize/deserialize
virDomainGetGuestInfo().
Signed-off-by: Jonathon Jongsma
---
src/remote/remote_daemon_dispatch.c | 41 ++
src/remote/remote_driver.c | 53 +
src/remote/remote_protocol.x| 21
er, if you specifically request an info category that is not supported by
the guest agent:
virsh # guestinfo --user fedora24
error: internal error: unable to execute QEMU agent command 'guest-get-users':
The command guest-get-users has not been found
Jonathon Jongsma (9):
lib: add virDomainGe
information will be used within
virDomainGetGuestInfo().
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_agent.c | 203 +-
1 file changed, 182 insertions(+), 21 deletions(-)
diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
index d7c00250ea..d5519cb243
The 'guestinfo' command uses the new virDomainGetGuestInfo() API to
query information about the specified domain and print it out for the
user. The output is modeled roughly on the 'domstats' command.
Signed-off-by: Jonathon Jongsma
---
tools/virsh-domain.c | 85
1 - 100 of 1088 matches
Mail list logo