e files are required.
Signed-off-by: Ani Sinha
Reviewed-by: Laine Stump
except that it needs rebasing since upstream has added another
capability in the meantime.
---
src/qemu/qemu_capabilities.c | 6 ++
src/qemu/qemu_capabilities.h
On 9/23/21 4:46 PM, Laine Stump wrote:
On 9/11/21 11:26 PM, Ani Sinha wrote:
Hi all:
This patchset introduces libvirt xml support for the following two pm
conf
options:
(before I get into a more radical discussion about different options -
since we aren't exactly duplicating
On 9/11/21 11:26 PM, Ani Sinha wrote:
Hi all:
This patchset introduces libvirt xml support for the following two pm conf
options:
(before I get into a more radical discussion about different options -
since we aren't exactly duplicating the QEMU option name anyway, what if
we
ches. Aside from that
Reviewed-by: Laine Stump
for the series.
On 9/22/21 4:55 PM, Ján Tomko wrote:
Signed-off-by: Ján Tomko
---
src/ch/ch_monitor.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/src/ch/ch_monitor.c b/src/ch/ch_monitor.c
index 3504c21f9d..804704e66d 100644
--- a/src/ch/ch_monitor.c
+++
On 9/22/21 4:55 PM, Ján Tomko wrote:
Signed-off-by: Ján Tomko
---
src/ch/ch_monitor.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/src/ch/ch_monitor.c b/src/ch/ch_monitor.c
index d241d30b10..9c562fdd0f 100644
--- a/src/ch/ch_monitor.c
+++
On 9/22/21 4:55 PM, Ján Tomko wrote:
Signed-off-by: Ján Tomko
---
src/ch/ch_monitor.c | 27 ++-
1 file changed, 10 insertions(+), 17 deletions(-)
diff --git a/src/ch/ch_monitor.c b/src/ch/ch_monitor.c
index 876a553f74..d241d30b10 100644
--- a/src/ch/ch_monitor.c
+++
On 9/17/21 3:22 AM, Peter Krempa wrote:
On Thu, Sep 16, 2021 at 21:16:03 -0400, Laine Stump wrote:
On 9/13/21 11:38 AM, Peter Krempa wrote:
On Fri, Sep 10, 2021 at 11:18:20 -0400, Laine Stump wrote:
On 9/10/21 3:30 AM, Peter Krempa wrote:
On Thu, Sep 09, 2021 at 13:46:41 -0400, Laine Stump
On 9/13/21 11:38 AM, Peter Krempa wrote:
On Fri, Sep 10, 2021 at 11:18:20 -0400, Laine Stump wrote:
On 9/10/21 3:30 AM, Peter Krempa wrote:
On Thu, Sep 09, 2021 at 13:46:41 -0400, Laine Stump wrote:
The ACPI index of a device in a running guest can't be modified, and
libvirt doesn't actually
The Linux kernel has recently added support for device-specific VFIO
drivers to be used (instead of the current generic, one-size-fits-all
vfio_pci driver) when assigning a device to a guest with VFIO. The
intent of this is to (for example) support APIs for device-specific
setup that needs to
On 9/10/21 3:30 AM, Peter Krempa wrote:
On Thu, Sep 09, 2021 at 13:46:41 -0400, Laine Stump wrote:
The ACPI index of a device in a running guest can't be modified, and
libvirt doesn't actually attempt to modify it, but it was possible for
a user to request such a modification, and libvirt
On 8/19/21 6:50 AM, Ani Sinha wrote:
Hi:
I added some negative xml2argv tests as well as new xml2xml tests. In the
process,
I also fixed a bug where I had not added appropriate code to generate the output
xml correctly.
The patch series is sent again as v2. Kindly, please provide inputs and
The next patch will add another check similar to the existing check
for a change in alias name. This patch reformats the code in
preparation so that the next patch's purpose will be clear.
Signed-off-by: Laine Stump
---
src/conf/domain_conf.c | 15 ---
1 file changed, 8 insertions
: https://bugzilla.redhat.com/1998920
Signed-off-by: Laine Stump
---
src/conf/domain_conf.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index fefc527901..7ff890d8b7 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
This isn't possible (acpi index is set when devices are probed at
guest startup) and libvirt wasn't even trying to communicate the
change to the guest in any way, but instead of logging an error, we
were just pretending the request had succeeded.
Laine Stump (2):
conf: reformat
On 9/9/21 10:28 AM, Ján Tomko wrote:
On a Monday in 2021, Laine Stump wrote:
On 9/4/21 4:44 PM, Ján Tomko wrote:
@@ -319,9 +308,9 @@ testFileIsSharedFSType(const void *opaque
G_GNUC_UNUSED)
return EXIT_AM_SKIP;
#else
const struct testFileIsSharedFSType *data = opaque;
+ int ret
On 8/31/21 11:04 PM, renlei1...@163.com wrote:
From: Ren Lei
the length of LINE_ENDING is static, it's a waste to call
strlen every time.
AFAIK gcc optimizes out calls to strlen of a literal constant string,
making this hand-optimization unnecessary.
Signed-off-by: Ren Lei
---
insertions(+), 1226 deletions(-)
Beer-worthy statistics!
I had a couple random comments beyond the one up above, but that's the
only one that needs any action. Once you've fixed that, series:
Reviewed-by: Laine Stump
On 9/4/21 4:44 PM, Ján Tomko wrote:
6 files changed, 51 insertions(+), 105 deletions(-)
diff --git a/tests/qemuagenttest.c b/tests/qemuagenttest.c
index 10d02bd1b4..bef6dfd152 100644
--- a/tests/qemuagenttest.c
+++ b/tests/qemuagenttest.c
@@ -471,51 +471,39 @@
On 9/4/21 4:44 PM, Ján Tomko wrote:
Signed-off-by: Ján Tomko
---
tests/vmx2xmltest.c | 19 +++
tests/xml2vmxtest.c | 15 +--
2 files changed, 12 insertions(+), 22 deletions(-)
diff --git a/tests/vmx2xmltest.c b/tests/vmx2xmltest.c
index b7f232eb77..0974168cb4
On 9/4/21 4:44 PM, Ján Tomko wrote:
diff --git a/tests/xmconfigtest.c b/tests/xmconfigtest.c
index bd23e5fd5d..c99d1f2bd9 100644
--- a/tests/xmconfigtest.c
+++ b/tests/xmconfigtest.c
@@ -41,7 +41,6 @@ testCompareParseXML(const char *xmcfg, const char *xml)
{
g_autofree char
On 9/4/21 4:44 PM, Ján Tomko wrote:
Signed-off-by: Ján Tomko
---
tests/vshtabletest.c | 71 +---
1 file changed, 28 insertions(+), 43 deletions(-)
diff --git a/tests/vshtabletest.c b/tests/vshtabletest.c
index 569d7a852f..716b11dbc0 100644
---
On 9/4/21 4:44 PM, Ján Tomko wrote:
@@ -319,9 +308,9 @@ testFileIsSharedFSType(const void *opaque G_GNUC_UNUSED)
return EXIT_AM_SKIP;
#else
const struct testFileIsSharedFSType *data = opaque;
+int ret = -1;
g_autofree char *mtabFile = NULL;
bool actual;
-int
On 8/18/21 4:21 AM, Michal Prívozník wrote:
On 8/18/21 12:31 AM, Jim Fehlig wrote:
On 8/17/21 12:11 PM, Jim Fehlig wrote:
On 8/17/21 4:13 AM, Michal Prívozník wrote:
On 8/13/21 11:36 PM, Jim Fehlig wrote:
Attaching a newly created vhostuser port to a VM fails due to an
apparmor denial
On 7/29/21 5:42 AM, Michal Prívozník wrote:
On 7/28/21 6:17 PM, Kristina Hanicova wrote:
When we try to migrate vm, we check if it contains only devices
that are able to migrate. If a hostdev device is not able to
migrate we raise an error with , but it can actually be
, so we need to check if
On 7/16/21 8:51 AM, Daniel P. Berrangé wrote:
On Fri, Jul 16, 2021 at 09:49:40PM +0900, Motohiro Kawahito wrote:
From: "Daniel P. Berrangé"
To: Motohiro Kawahito
Cc: libvir-list@redhat.com
Date: 2021/07/16 17:22
Subject: [EXTERNAL] Re: Question about skipping
virDomainDiskDefAssignAddress
On 6/16/21 4:15 PM, Daniel Henrique Barboza wrote:
On 6/9/21 4:38 PM, Manish Mishra wrote:
Hi Everyone,
We want to add extra options to device xml to skip reattach of pci
passthrough devices. Following is xml format for pci passthrough
devices added to domain as of now.
interfaces jumps to cleanup.
Resolves: https://bugzilla.redhat.com/1972991
Fixes: 7b8bec45601b6570f6a7413e94d291986d2663f1
(any other tags I should add?)
Signed-off-by: Laine Stump
---
src/qemu/qemu_hotplug.c | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git
Stack upgrades. I'm not convinced
this is the case, but it does appear that there is no reason to carry
this workaround in libvirt any longer, so this patch reverts the code
back to the original behavior (using "--may-exist" instead of
"--if-exists del-port").
Signed-off-by: Lain
On 5/26/21 11:16 AM, Ján Tomko wrote:
On a Wednesday in 2021, Daniel P. Berrangé wrote:
We have helper methods that return boolans for ro/user/autostart
booleans (or bools if you want to be pedantic)
properties. We then pack them into a flags parameter, and later
unpack them again. This
and re-adjust if the hotplug fails.
This fixes a bug found during testing of
https://bugzilla.redhat.com/1939776, which was supposed to be resolved
by commit 98e22ff749, but failed to account for the case of device
hotplug.
Signed-off-by: Laine Stump
---
src/qemu/qemu_hotplug.c | 12
) with a call to
the new virDomainNetRemoveByObj(), which looks for the device on both
nets and hostdevs lists, and removes it where it finds it.
Signed-off-by: Laine Stump
---
src/qemu/qemu_hotplug.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git
have code paths earlier in the function that goto cleanup, this should
not cause any new problem.
Signed-off-by: Laine Stump
---
src/qemu/qemu_hotplug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index c6f275e11d..244cf65
in the nets list, and deletes that if it is found.
As with virDomainNetRemove() it always unconditionally tries to remove
the device from the hostdevs list (in case it is the ridiculous
combined net+hostdev device created for ).
Signed-off-by: Laine Stump
---
src/conf/domain_conf.c | 16
see patch 4 for the why.
Found during testing of https://bugzilla.redhat.com/1939776
Laine Stump (4):
qemu_hotplug.c: don't skip cleanup on failures of
qemuDomainAttachNetDevice
conf: new function virDomainNetRemoveByObj()
qemu_hotplug.c: add net devices to the domain list earlier
.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1942367
Signed-off-by: Kristina Hanicova
Looks okay to me.
Reviewed-by: Laine Stump
I'll push it shortly.
---
src/conf/domain_conf.c | 67 --
1 file changed, 25 insertions(+), 42 deletions
On 5/19/21 8:37 AM, Kristina Hanicova wrote:
On Wed, May 19, 2021 at 9:58 AM Michal Prívozník <mailto:mpriv...@redhat.com>> wrote:
On 5/18/21 6:07 PM, Laine Stump wrote:
> On 5/18/21 5:44 AM, Kristina Hanicova wrote:
>> Resolves: https://bugzilla.redhat.c
Reviewed-by: Laine Stump
I'll push when the CI on my review branch is finished.
On 5/18/21 11:04 AM, Tim Wiederhake wrote:
For background, see
https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html
Tim Wiederhake (10):
virDomainHostdevDef: Change type of startupPolicy
On 5/18/21 11:04 AM, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
---
src/conf/domain_conf.c | 23 +--
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 734fa584a4..661fa53206 100644
---
On 5/18/21 5:44 AM, Kristina Hanicova wrote:
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1942367
Signed-off-by: Kristina Hanicova
---
src/conf/domain_conf.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/src/conf/domain_conf.c
/conf/numa_conf.c | 305 ++
.../hugepages-memaccess-invalid.err | 2 +-
3 files changed, 110 insertions(+), 241 deletions(-)
Reviewed-by: Laine Stump
I'll push them as soon as simple smoke test build has completed
On 5/11/21 11:01 AM, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
Reviewed-by: Laine Stump
---
src/conf/storage_conf.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index 10b46ac368
On 5/11/21 11:01 AM, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
Reviewed-by: Laine Stump
---
src/conf/storage_conf.c | 31 ---
1 file changed, 8 insertions(+), 23 deletions(-)
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index
On 5/11/21 11:01 AM, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
Reviewed-by: Laine Stump
On 5/11/21 11:01 AM, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
Reviewed-by: Laine Stump
---
src/conf/storage_adapter_conf.c | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/src/conf/storage_adapter_conf.c b/src/conf/storage_adapter_conf.c
On 5/11/21 11:01 AM, Tim Wiederhake wrote:
}
VIR_FREE(nodes);
if ((n = virXPathNodeSet("./cpu/numa[1]/interconnects[1]/latency|"
"./cpu/numa[1]/interconnects[1]/bandwidth", ctxt,
)) <
Again, the VIR_FREE(nodes) points out that you're
On 5/11/21 11:01 AM, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
---
src/conf/numa_conf.c | 42 --
1 file changed, 4 insertions(+), 38 deletions(-)
diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c
index 531bdc6eba..e631bfa341 100644
On 5/11/21 11:01 AM, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
---
src/conf/numa_conf.c | 33 ++---
1 file changed, 14 insertions(+), 19 deletions(-)
diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c
index bae59ac7b8..531bdc6eba 100644
---
On 5/11/21 11:01 AM, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
---
src/conf/node_device_conf.c | 34 +-
1 file changed, 13 insertions(+), 21 deletions(-)
diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
index
libvirtd is
stopped? the FDB entry wouldn't get removed and your patch would end up
being required anyway.
Signed-off-by: Jiri Denemark
Reviewed-by: Laine Stump
It might be nice to mention https://bugzilla.redhat.com/1603155 (and
also to note the commit ID of this patch in that BZ once it's
On 4/19/21 7:54 AM, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
Reviewed-by: Laine Stump
I pushed all 5 patches.
to verify the
problem and the fix, so...)
Signed-off-by: Tim Wiederhake
Reviewed-by: Laine Stump
On 4/19/21 7:54 AM, Tim Wiederhake wrote:
Fixes: 3caa28dc50df7ec215713075d669b20bef6473a2
Signed-off-by: Tim Wiederhake
Reviewed-by: Laine Stump
On 4/19/21 7:54 AM, Tim Wiederhake wrote:
Fixes: 94013ee04e3945307a71f5c4897d78729e7eaff4
While not necessary, a short explanation would have led to less time
spent loooking into the original patch.
Signed-off-by: Tim Wiederhake
Reviewed-by: Peter Krempa
---
src/conf/domain_conf.c | 2
DOMAIN_TIMER_MODE_PARAVIRT;
def->clock.timers[def->clock.ntimers - 1] = timer;
+VIR_FREE(tscmode);
I think this ^^^ was left over from V1
With that removed
Reviewed-by: Laine Stump
}
-if (xenConfigGetString(conf, "passthrough", , NULL) < 0)
+
On 4/13/21 4:39 PM, Jonathon Jongsma wrote:
From: Erik Skultety
Now that we have a generic mdevctl command generator, we can unify the
test infrastructure as well.
Signed-off-by: Erik Skultety
Reviewed-by: Laine Stump
ments. Instead, keep the wrappers, but let them call a single
global translator that handles all the mdevctl command differences and
commonalities.
Signed-off-by: Erik Skultety
Signed-off-by: Jonathon Jongsma
Reviewed-by: Laine Stump
.
Signed-off-by: Jonathon Jongsma
Reviewed-by: Laine Stump
s also a word, so... :-)
use
virMdevctlCreate in scenarios where XML description is passed to
libvirt and a transient device is supposed to be created.
Signed-off-by: Erik Skultety
Signed-off-by: Jonathon Jongsma
Reviewed-by: Laine Stump
On 4/13/21 4:39 PM, Jonathon Jongsma wrote:
Rather than specifying a UUID string to some test macros, just pass a
filename to an xml definition. This helps work toward unifying the test
macros and making it more maintainable.
Signed-off-by: Jonathon Jongsma
Reviewed-by: Laine Stump
On 4/14/21 6:49 AM, Erik Skultety wrote:
On Tue, Apr 13, 2021 at 03:39:36PM -0500, Jonathon Jongsma wrote:
Erik recommended several changes to the mdev series that was just merged and
suggested to address them in a follow-up patch series. They're mostly related
to simplifying the testing, and
On 4/13/21 4:39 PM, Jonathon Jongsma wrote:
rather than using short opentions (e.g. "-p :00:02.0"), use long
options everywhere (e.g. "--parent=:00:02.0")
Signed-off-by: Jonathon Jongsma
Reviewed-by: Laine Stump
-by: Laine Stump
---
src/node_device/node_device_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/node_device/node_device_driver.c
b/src/node_device/node_device_driver.c
index 4cf4e4214f..1d1eaa9561 100644
--- a/src/node_device/node_device_driver.c
+++ b/src
On 4/13/21 4:39 PM, Jonathon Jongsma wrote:
The calling function will log the error. Just return NULL if a device
cannot be found.
Signed-off-by: Jonathon Jongsma
Reviewed-by: Laine Stump
---
src/node_device/node_device_driver.c | 5 +
1 file changed, 1 insertion(+), 4 deletions
On 4/13/21 4:49 PM, Jonathon Jongsma wrote:
Coverity reported that this function can return NULL, so it should be
handled properly.
Signed-off-by: Jonathon Jongsma
Reviewed-by: Laine Stump
---
src/node_device/node_device_driver.c | 11 ++-
1 file changed, 10 insertions(+), 1
. That's unnecessary extra string
manipulation for *GroupNum(). Reverse the implementations and make
*GroupDev() call *GroupNum().
Seems like potato potahto to me (I guess you eliminated 4 lines), but
sure, okay.
Reviewed-by: Laine Stump
\
Signed-off-by: Jonathon Jongsma
---
src/util
sPath"?
Reviewed-by: Laine Stump
either with this single change, or with all three.
-
iommu_path = g_strdup_printf("%s/iommu_group", dev_path);
if (!virFileExists(iommu_path)) {
On 4/7/21 8:40 AM, Daniel P. Berrangé wrote:
On Wed, Apr 07, 2021 at 09:23:50AM +0200, Peter Krempa wrote:
On Wed, Apr 07, 2021 at 09:17:36 +0200, Peter Krempa wrote:
On Tue, Apr 06, 2021 at 16:31:32 +0100, Daniel Berrange wrote:
PCI devices can be associated with a unique integer index that
On 4/6/21 11:31 AM, Daniel P. Berrangé wrote:
PCI devices can be associated with a unique integer index that is
exposed via ACPI. In Linux OS with systemd, this value is used for
provide a NIC device naming scheme that is stable across changes
in PCI slot configuration.
Signed-off-by: Daniel P.
On 3/24/21 6:27 AM, Michal Privoznik wrote:
Generated by the following spatch:
@@
expression a, b;
@@
+ b = g_steal_pointer();
- b = a;
... when != a
- a = NULL;
Signed-off-by: Michal Privoznik
---
src/conf/capabilities.c | 3 +--
. This patch modifies that code to also increase the
limit if there are any vDPA devices present.
Resolves: https://bugzilla.redhat.com/1939776
Signed-off-by: Laine Stump
---
src/qemu/qemu_domain.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu
if not
then a) the additional check for mdev devices gained by using
qemuDomainNeedsVFIO() in place of open coding will be an effective
NOP, and b) if mdev devices are supported on PPC64 in the future, this
function will be prepared for it).
Signed-off-by: Laine Stump
---
src/qemu/qemu_domain.c | 9
We recently learned that vDPA devices may/will need to pin/lock all of
guest memory, and so just as we do for VFIO devices, we need to
increase the locked memory limit when a vDPA device is present.
https://bugzilla.redhat.com/1939776
Laine Stump (4):
conf: new function virDomainDefHasVDPANet
This function goes through a loop checking if each hostdev is a VFIO
or mdev device, and then later it calls virDomainDefHasNVMEDisk(). The
function qemuDomainNeedsVFIO() does exactly the same thing, so let's
just call that instead.
Signed-off-by: Laine Stump
---
src/qemu/qemu_domain.c | 17
This function returns true if the domain has any interfaces that are
type='vdpa'.
Signed-off-by: Laine Stump
---
src/conf/domain_conf.c | 14 ++
src/conf/domain_conf.h | 3 +++
src/libvirt_private.syms | 1 +
3 files changed, 18 insertions(+)
diff --git a/src/conf
On 3/23/21 8:44 AM, Michal Privoznik wrote:
Honestly, this is not the most beautiful patch I've seen, but also I
don't have any idea how to make it look better,
I didn't like writing it either.
Anyway, I like Dan's idea better - "that's not a regression, it's a
bonus bugfix for a bug that
On 3/23/21 5:37 AM, Daniel P. Berrangé wrote:
On Mon, Mar 22, 2021 at 05:30:34PM -0400, Laine Stump wrote:
Commit 114e3b42 modified virDomainNetFindIdx() to compare the alias
name of the being matched (in addition to already-existing
match of MAC address and PCI/CCW address). This was done
of adventurous souls have used GPtrArray, but so far nobody has used
GArray, and I decided this was a good chance to try that out. It went
okay.
Reported-by: Yalan Zhang
Signed-off-by: Laine Stump
---
I realized while writing this patch that an update-device test case in
qemuhotplugtest would have
On 3/9/21 1:23 PM, Andrea Bolognani wrote:
On Tue, 2021-03-09 at 17:44 +, Daniel P. Berrangé wrote:
One of the conventions we have had since the early days of libvirt is
that every struct typedef, has a corresponding "Ptr" typedef too.
For example
typedef struct _virDomainDef
Ahem.. Hello? Is this thing on?? :-)
On 3/3/21 3:34 PM, Laine Stump wrote:
ping
On 2/23/21 10:35 PM, Laine Stump wrote:
Some SRIOV PFs don't have a netdev associated with them (the spec
apparently doesn't require it). In most cases when libvirt is dealing
with an SRIOV VF, that VF must have
/show_bug.cgi?id=1912210
Signed-off-by: Michal Privoznik
Reviewed-by: Laine Stump
On 3/1/21 10:54 AM, Ján Tomko wrote:
On a Thursday in 2021, Michal Privoznik wrote:
On 2/25/21 1:20 PM, Ján Tomko wrote:
On a Tuesday in 2021, Kristina Hanicova wrote:
In: vshTableRowNew(), vshTablePrint(), vshTablePrintToStdout().
Signed-off-by: Kristina Hanicova
---
tools/vsh-table.c | 16
ping
On 2/23/21 10:35 PM, Laine Stump wrote:
Some SRIOV PFs don't have a netdev associated with them (the spec
apparently doesn't require it). In most cases when libvirt is dealing
with an SRIOV VF, that VF must have a PF, and the PF *must* have an
associated netdev (the only way to set the MAC
/conf/domain_conf.c| 3 +-
src/conf/networkcommon_conf.c | 90 +++
src/lxc/lxc_native.c | 10 ++--
src/vz/vz_sdk.c | 3 +-
4 files changed, 44 insertions(+), 62 deletions(-)
Reviewed-by: Laine Stump
(for all 3) and pushed.
a massive buffer.
Signed-off-by: Peter Krempa
and good riddance!
Reviewed-by: Laine Stump
---
build-aux/syntax-check.mk | 8
src/libvirt_private.syms | 1 -
src/util/virerror.c | 22 --
src/util/virerror.h | 8
4 files changed, 39
On 2/24/21 11:17 AM, Peter Krempa wrote:
The function has also non-OOM failure case when the passed string has 0
length, so reporting OOM error is not correct.
Signed-off-by: Peter Krempa
---
src/vmx/vmx.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git
On 2/24/21 11:16 AM, Peter Krempa wrote:
Out of memory isn't the only reason the function can fail. Add a message
stating that copying of a XML node failed.
Could it still fail due to OOM as well, though? And if so, is there any
way of differentiating? (I previously looked into this for some
On 2/24/21 11:16 AM, Peter Krempa wrote:
'virReportOOMError' is nowadays mostly useless since an OOM error will
trigger yet another allocation failure in the logger when attempting to
log the error.
Additionally it was also used in few places which can fail with other
failures than OOM.
To
On 2/23/21 12:24 PM, Kristina Hanicova wrote:
In files: src/lxc/lxc_native: in lxcAddNetworkRouteDefinition(),
src/conf/networkcommon_conf: in virNetDevIPRouteCreate() and
virNetDevIPRouteParseXML()
Signed-off-by: Kristina Hanicova
Reviewed-by: Laine Stump
evIPRoute) route = NULL;
Interesting. So this function uses route multiple times (once for IPv4
and once for IPv6), but it's clearing out the first usage by stealing
the pointer into and array of routes rather than freeing it. I guess
that's okay, though.
Anyway:
Reviewed-by: Laine Stump
I'
On 2/23/21 12:24 PM, Kristina Hanicova wrote:
Signed-off-by: Kristina Hanicova
---
src/conf/networkcommon_conf.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/src/conf/networkcommon_conf.c b/src/conf/networkcommon_conf.c
index 26eeb6dbda..e82dbc3d3d
(for one of the callers it *is* still an error,
so the error message is moved there, but for the other it is okay to
continue), and our spurious error messages are a thing of the past.
Resolves: https://bugzilla.redhat.com/1924616
Fixes: 6452e2f5e1837bd753ee465e6607ed3c4f62b815
Signed-off-by: Laine
the fix ACKed and
pushed in time for the release.
Laine Stump (2):
qemu: allow migration of generic with
docs: fix bad cut/paste in example
docs/formatdomain.rst | 3 +--
src/qemu/qemu_migration.c | 16 ++--
2 files changed, 11 insertions(+), 8 deletions(-)
--
2.29.2
://bugzilla.redhat.com/1927984
Fixes: db64acfbda59ad22b671580fda13968c60bb8c1a
Reported-by: Yalan Zhang
Signed-off-by: Laine Stump
---
docs/formatdomain.rst | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index e23bcc3e5a..937b0da012 100644
to modify qemuMigrationSrcIsAllowedHostdev() to allow
migration when the generic has a element.
https://bugzilla.redhat.com/1927984
Fixes: 010ed0856bb06f439e6fdf44e4f529f53441c398
Reported-by: Yalan Zhang
Signed-off-by: Laine Stump
---
src/qemu/qemu_migration.c | 16 ++--
1 file changed
On 2/22/21 4:11 PM, Daniel Henrique Barboza wrote:
I learned this 20+ years ago and
forgot it along the road. Heavy metal lyrics and World of Warcraft public
chat aren't the best sources for learning proper English grammar, so it
seems.
I learned Turkish from taxi drivers and random people at
lock them, since that could theoretically lead to a deadlock. I
haven't even thought beyond this single function to figure out if it's
even a possibility in this case, but still would feel better if you
unlocked in the opposite order that you lock.
With that fixed:
Reviewed-by: Laine
rather than just referencing it directly. I'd forgotten that
virPCIDevice is one of those rare "private structures" in libvirt -
defined only in a single .c file.
Anyway,
Reviewed-by: Laine Stump
VIR_DEBUG("Not detach
On 1/18/21 2:53 PM, Daniel Henrique Barboza wrote:
Signed-off-by: Daniel Henrique Barboza
Reviewed-by: Laine Stump
On 1/18/21 2:53 PM, Daniel Henrique Barboza wrote:
This change will allow us to remove PCI devices from a list
without the need of a PCI Device object, which will be need
in the next patch.
Signed-off-by: Daniel Henrique Barboza
Reviewed-by: Laine Stump
301 - 400 of 6183 matches
Mail list logo
