This controller provides a single PCIe port on a new root. It is
similar to pci-expander-bus, intended to provide a bus that can be
associated with a guest-identifiable NUMA node, but is for
machinetypes with PCIe rather than PCI (e.g. q35-based machinetypes).
Aside from PCIe vs. PCI, the other ma
nwfilter.rng defines uint16range and uint32range, but in a different
manner (it also allows a variable name as the value, rather than just
a decimal or hex number). I wanted to add uint16range to
basictypes.rng, but my desired definition was parallel to those for
uint8range and uint24range which ar
The pcie-switch-downstream-port and pcie-root-port controllers have
only a single slot, numbered 0, and the greate majority of all guest
PCI devices are plugged into function 0 of whatever slot they're
using. The parser makes these optional, setting them to 0 when not
specified, and it's logical fo
The flags used to determine which devices could be plugged into which
controllers were quite confusing, as they tried to create classes of
connections, then put particular devices into possibly multiple
classes, while sometimes setting multiple flags for the controllers
themselves. The attempt to h
This is especially useful for "bus", since the bus of a device's pci
address is matched to the "index" of a controller to determine which
bus it will be connected to, and "index" is always specified in
decimal - being able to specify both in decimal at least makes it
easier to assure a device is be
This is backed by the qemu device pxb-pcie, which will be available in
qemu 2.6.0.
As with pci-expander-bus (which uses qemu's pxb device), the busNr
attribute and subelement of are used to set the bus_nr
and numa_node options.
During post-parse we validate that the domain's machinetype is
q35-
This is a standard PCI root bus (not a bridge) that can be added to a
440fx-based domain. Although it uses a PCI slot, this is *not* how it
is connected into the PCI bus hierarchy, but is only used for
control. Each pci-expander-bus provides 32 slots (0-31) that can
accept hotplug of standard PCI d
Every other maxSlot was either set to 0 or to
VIR_PCI_ADDRESS_SLOT_LAST, but this one was for some reason set to the
literal value 31 (which is the same as VIR_PCI_ADDRESS_SLOT_LAST).
This makes them all consistent.
---
src/conf/domain_addr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Since every PCI controller model has to have a default model name set,
put it in a separate function to clean up qemuDomainAssignPCIAddresses
a bit.
---
src/qemu/qemu_domain_address.c | 54 +++---
1 file changed, 40 insertions(+), 14 deletions(-)
diff --git a/s
After the patches that added tracking of in-use macvtap names (commit
370608, first appearing in libvirt-1.3.2), if the function to allocate
a new macvtap device came to a device name created outside libvirt, it
would retry the same device name MACVLAN_MAX_I (8191) times before
finally giving up in
On 03/28/2016 06:43 AM, Shanzhi Yu wrote:
in commit 370608b, bitmap of in-used macvtap devices was introduced.
if there is already macvtap device created not by libvirt,
virNetDevMacVLanCreateWithVPortProfile will failed after try
MACVLAN_MAX_ID times call virNetDevMacVLanReleaseID
Resolves: htt
On 03/28/2016 10:42 AM, Laine Stump wrote:
On 03/28/2016 06:43 AM, Shanzhi Yu wrote:
in commit 370608b, bitmap of in-used macvtap devices was introduced.
if there is already macvtap device created not by libvirt,
virNetDevMacVLanCreateWithVPortProfile will failed after try
MACVLAN_MAX_ID times
On 03/28/2016 07:52 AM, John Ferlan wrote:
While reviewing patch:
http://www.redhat.com/archives/libvir-list/2016-March/msg00194.html
I noted that the order of operations during the code path was slightly
different and could cause issues if the reattachment code was called
first. It would seem
On 03/29/2016 08:24 AM, Daniel P. Berrange wrote:
On Mon, Mar 28, 2016 at 10:27:18AM +0300, Roman Bogorodskiy wrote:
Bhyve supports ACPI shutdown by issuing SIGTERM signal to the bhyve
process. Add the bhyveDomainShutdown() function and
virBhyveProcessShutdown() helper function that just sends S
On 03/30/2016 05:05 AM, Michal Privoznik wrote:
On 24.03.2016 20:25, Laine Stump wrote:
The pcie-switch-downstream-port and pcie-root-port controllers have
only a single slot, numbered 0, and the greate majority of all guest
s/greate/great/
PCI devices are plugged into function 0 of whatever
On 03/30/2016 05:05 AM, Michal Privoznik wrote:
On 24.03.2016 20:25, Laine Stump wrote:
This is especially useful for "bus", since the bus of a device's pci
address is matched to the "index" of a controller to determine which
bus it will be connected to, and "
On 03/30/2016 05:05 AM, Michal Privoznik wrote:
On 24.03.2016 20:25, Laine Stump wrote:
These two controllers are used to create a new root bus on a 440fx
(pxb) or q35 (pxb-pie) virtual machine. There may be other use cases,
but the main reason for me taking the time to support a separate root
On 03/29/2016 07:45 AM, Moshe Levi wrote:
Hi,
I was testing Host device assignment in OpenStack environment where
the driver name is vfio or kvm.
My setup is as follow:
1.Fedora 21
2.Libvirt 1.3.0 which I compiled
3.OpenStack master
I have also other setups with older Libvirt version a
ed: (obj->ref > 0)
*From:*sendmail [mailto:justsendmailnothinge...@gmail.com] *On Behalf
Of *Laine Stump
*Sent:* Wednesday, March 30, 2016 9:25 PM
*To:* Libvirt
*Cc:* Moshe Levi
*Subject:* Re: [libvirt] Host device assignment driver name vfio/ kvm
On 03/29/2016 07:45 AM, Moshe Levi wrote:
On 03/31/2016 05:23 AM, Vasiliy Tolstov wrote:
2016-03-23 20:46 GMT+03:00 Laine Stump :
Since there is no documentation included with the patch, and the wrong RNG
file has been modified, I'm not clear on exactly why a libvirt virtual
network would use a peer address.
Normally libvirt net
On 03/31/2016 05:22 AM, Vasiliy Tolstov wrote:
Allow to use ip address and routes elements inside network ethernet.
Also allow to configure point-to-point address for host side device.
In order to allow for possible backporting of parts of this feature
without requiring backports of the rest,
On 04/01/2016 09:38 AM, Andrea Bolognani wrote:
This reverts commit ee4cfb56436b50345b072c706b87aff82e06d760.
Since we're still not persisting our bookkeeping lists across
daemon restarts, we might have lost some information
virPCIDeviceReattach() relies on, for example whether the
device needs
Starting with commit f8e712fe, if you start a domain that has an
where the network is a pool of devices for hostdev assignment), when
you later try to add *another* interface (of any kind) with hotplug,
the function qemuAssignDeviceNetAlias() fails as soon as it sees a
"hostdevN" alias in the list
There are times when it's necessary to learn the actual type of a
network connection before any resources have been allocated
(e.g. during qemuProcessPrepareDomain()), but in the past it was
necessary to call networkAllocateActualDevice() in order to have the
actual type filled in.
This new functi
In certain cases, we need to assign a hostdevN-style alias in a case
when we don't have a virDomainHostdevDefPtr (instead we have a
virDomainNetDefPtr). Since qemuAssignDeviceHostdevAlias() doesn't use
anything in the virDomainHostdevDef except the alias string itself
anyway, this patch just change
bsequently trying to hotplug another interface of any kind.
This is solved by adding a new function that lets us learn the type of
any interface prior to setting it up, then using that function to
change the behavior when assigning aliases.
This *really* should be pushed before 1.3.3 is relea
On 04/01/2016 11:39 AM, Martin Kletzander wrote:
On Fri, Apr 01, 2016 at 11:54:30AM +0800, Daniel Veillard wrote:
I pushed the rc2 tag in git head and signed tarball and rpms to the
usual place:
ftp://libvrt.org/libvirt/
I didn't really had time to test it TBH, seems we don't have too
muc
ng on signal
15 from pid 6866
[2] root@r-dcs78:/var/log/libvirt/qemu# ls -l /dev/vfio/
total 0
crw-rw-rw- 1 root root 10, 196 Mar 29 11:11 vfio
*From:*sendmail [mailto:justsendmailnothinge...@gmail.com] *On Behalf
Of *Laine Stump
*Sent:* Thursday, March 31, 2016 7:07 PM
*To:* Libvirt
*Cc:* M
On 01/06/2015 09:31 AM, Luyao Huang wrote:
>
> On 01/06/2015 10:11 PM, Michal Privoznik wrote:
>> On 22.12.2014 08:21, Luyao Huang wrote:
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1176503
>>>
>>> When guest start failed, libvirt will keep the current vm->def,
>>> this will make a issue that w
On 12/30/2014 05:27 AM, Cédric Bosdonnat wrote:
> Network interfaces devices and host devices with net capabilities can
> now have IPv4 and/or an IPv6 routes configured.
> ---
> docs/formatdomain.html.in| 19 -
> docs/schemas/domaincommon.rng| 31
> src/conf/doma
On 01/08/2015 04:40 AM, hong-hua@freescale.com wrote:
> Hi Laine,
>
> Sorry to disturb you.
> It seemed this issue had been fixed in libvirt-1.2.2/libnl-3.2.22/linux-3.12.
> But we still got the error on PowerPC platform.
> I'll appreciate if you could give any suggestion. We are not sure if
On 01/12/2015 05:09 AM, hong-hua@freescale.com wrote:
> Hi Laine,
>
> I'm not sure if /usr/include/linux/rtnetlink.h is necessary in the filesystem
> on host machine.
>
> In our scenario, both host machine and iNIC card are both PowerPC boards.
> I just checked the linux source code we used
>
On 01/09/2015 11:47 AM, Cédric Bosdonnat wrote:
> Made the network configuration schemas and codes for the route element
> reusable.
> Created networkcommon_conf.[ch] files containing pieces to be used in both
> domain
> and network configurations.
>
> Replaced the brand new domain route configu
On 01/13/2015 11:11 AM, Laine Stump wrote:
> On 01/09/2015 11:47 AM, Cédric Bosdonnat wrote:
>> @@ -4359,11 +4359,7 @@ qemu-kvm -net nic,model=? /dev/null
>>
>> Since 1.2.12 route elements can also be added
>> to define the network routes to use for the n
On 01/13/2015 10:58 AM, John Ferlan wrote:
>
> On 01/07/2015 12:31 PM, Michal Privoznik wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1165993
>>
>> So, there are still plenty of vNIC types that we don't know how to set
>> bandwidth on. Let's fail explicitly in case user has requested it
>>
On 01/12/2015 11:10 PM, zhang bo wrote:
> It works well if we use qmp command to directly interact with qemu 2.1 to
> hot-add vhost-user network card. However, libvirt seems not support
> hotplugging well.
>
> Steps to use qmp commands to directly(without libvirtd) interact with qemu
> 2.1 :
> 1
On 01/15/2015 04:25 AM, Cédric Bosdonnat wrote:
> ---
> docs/schemas/basictypes.rng | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/schemas/basictypes.rng b/docs/schemas/basictypes.rng
> index 9ddd92b..efc9da4 100644
> --- a/docs/schemas/basictypes.rng
> +++ b/docs/sc
On 01/15/2015 07:11 AM, Cedric Bosdonnat wrote:
> On Thu, 2015-01-15 at 11:58 +0100, Michal Privoznik wrote:
>> On 15.01.2015 10:25, Cédric Bosdonnat wrote:
>>> Moving network route to the network common schema will allow reusing it.
>>> ---
>>> docs/schemas/network.rng | 20 +---
(Gene - I Cc'ed you because of one question I have for you down in the
bowels of the review. Just search for "Gene" and you'll get to it).
On 01/15/2015 04:25 AM, Cédric Bosdonnat wrote:
> Moving code for parsing and formatting network routes to
> networkcommon_conf helps reusing those routes for
On 01/15/2015 04:25 AM, Cédric Bosdonnat wrote:
> ---
> docs/formatdomain.html.in | 9 +-
> docs/schemas/domaincommon.rng | 29 +-
> docs/schemas/network.rng | 2 +-
> docs/schemas/networkcommon.rng|
On 01/15/2015 04:25 AM, Cédric Bosdonnat wrote:
> If 0.0.0.0 address is provided, then the returned prefix should be 0,
> rather than 8.
> ---
> src/util/virsocketaddr.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c
> index c5584
On 01/15/2015 04:25 AM, Cédric Bosdonnat wrote:
> From: John Ferlan
>
> Commit id 'aa2cc721' added call to virSocketAddrFormat
> and did not VIR_FREE() the returned memory.
>
> Signed-off-by: John Ferlan
> ---
> src/conf/domain_conf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/
On 01/15/2015 04:25 AM, Cédric Bosdonnat wrote:
> From: John Ferlan
>
> Commit id 'aa2cc721' added calls to virSocketAddrFormat but did not
> check for a NULL (error) return which could lead to bad output
> in the XML file. Need to check for NULL return and cause failure.
>
> Signed-off-by: John
On 01/15/2015 09:48 AM, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1182486
>
> When updating a network and adding new ip-dhcp-host entry, the deamon
> may crash. The problem is, we iterate over existing entries
> trying to compare MAC addresses to see if there's already
On 01/16/2015 02:45 AM, Cedric Bosdonnat wrote:
> Hi Laine,
>
> On Thu, 2015-01-15 at 13:34 -0500, Laine Stump wrote:
>> (Gene - I Cc'ed you because of one question I have for you down in the
>> bowels of the review. Just search for "Gene" and you'
On 01/16/2015 09:51 AM, Cédric Bosdonnat wrote:
> ---
> src/util/virsocketaddr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c
> index 91bcadf..67ed330 100644
> --- a/src/util/virsocketaddr.c
> +++ b/src/util/virsocketa
On 01/16/2015 01:00 PM, Gary R Hook wrote:
> Warning: possibly rhetorical or already answered question ahead.
>
> Why is the git repository that is located here:
> http://libvirt.org/git/?p=libvirt-appdev-guide.git;a=summary
> which is pointed to by this page here:
> http://www.libvirt.org/
By specifying parentIndex in a call to virNetworkUpdate(), it was
possible to direct libvirt to add a dhcp range or static host of a
non-matching address family to the element of an . For
example, given:
you could provide a static host entry with an IPv4 address, and
specify that it be added
libvirt's dnsmasq, so I can
> easily resolve guest names from outside. But if libvirt's dnsmasq
> doesn't know a name and forwards it to the host, I'd get an endless
> forwarding loop. Now I can set localOnly="yes" to prevent the loop.
>
> Signed-off-by:
On 01/19/2015 11:18 AM, akrow...@linux.vnet.ibm.com wrote:
> From: Tony Krowiak
>
> This patch provides the utility functions needed to synchronize
> the rxfilter changes made to a guest domain with the corresponding
> macvtap devices on the host:
>
> * Get/set PROMISC flag
> * Get/set ALLMULTI, M
(I didn't try make syntax-check, but am assuming you have and that it
passes)
On 01/19/2015 11:18 AM, akrow...@linux.vnet.ibm.com wrote:
> From: Tony Krowiak
>
> This patch supplies the funtionality of synchronizing the host macvtap
> device options with the guest device's in response to the
> N
On 01/22/2015 03:47 AM, Ján Tomko wrote:
> On 01/19/2015 11:04 PM, Laine Stump wrote:
>> By specifying parentIndex in a call to virNetworkUpdate(), it was
>> possible to direct libvirt to add a dhcp range or static host of a
>> non-matching address family to the element o
e562a61a0739 added these two new helper functions and only used them
within virnetdev.c, but declared them in the .h file. If some
currently unsupported interface flags need to be accessed in the
future, it will make more sense to write the appropriate higher level
function rather than require us t
On 02/03/2015 08:27 AM, Pavel Hrdina wrote:
> Commit e562a61a introduced new function to get/set interface state but
> there was misuse of ATTRIBUTE_NONNULL on non-pointer attributes and also
> we need to wrap that functions by #ifdef to not break mingw build.
>
> Signed-off-by: Pavel Hrdina
> ---
On 02/02/2015 09:08 AM, Lin Ma wrote:
> It constructs a temporary static config of the network, Obtains all of
> attached interfaces information through netcf, Then removes the config.
>
> Signed-off-by: Lin Ma
> ---
> include/libvirt/libvirt-network.h| 1 +
> src/Makefile.am
On 02/02/2015 09:08 AM, Lin Ma wrote:
> * add --system flag for net-dumpxml to show information about the
> attached interfaces of the virtual network.
I don't like this extra flag - I think it is unnecessary. If we're going
to more info to the status, then we can just always add it to the statu
On 02/03/2015 11:47 AM, Michal Privoznik wrote:
> On 02.02.2015 15:08, Lin Ma wrote:
>> * Get the live state info of a virtual network through netcf in
>> networkGetXMLDesc.
>> * Add --system flag for net-dumpxml to show the live state info.
>> * Check the live state info in net-destroy.
>> * Add
On 02/03/2015 11:39 AM, Michal Privoznik wrote:
> On 02.02.2015 15:08, Lin Ma wrote:
>> By checking transient interfaces, It obtains the live information of
>> attached interfaces to see if the bridge is in use.
>>
>> Signed-off-by: Lin Ma
>> ---
>> tools/virsh-interface.c | 25 ++
On 02/04/2015 09:58 AM, Daniel P. Berrange wrote:
> On Wed, Feb 04, 2015 at 02:21:18AM -0500, Laine Stump wrote:
>> On 02/03/2015 11:47 AM, Michal Privoznik wrote:
>>> On 02.02.2015 15:08, Lin Ma wrote:
>>>> * Get the live state info of a virtual network through ne
On 02/04/2015 10:57 AM, Jim Fehlig wrote:
> Laine Stump wrote:
>> (BTW, I'm still curious about Suse's use of netcf, as there have been no
>> updates to the Suse driver in netcf since the initial port was imported
>> several years ago. Are there downstream ch
When defining and creating networks, we have been checking to make
sure there is only a single "default" portgroup, but haven't verified
that no two portgroups have the same name. We *do* check for multiple
definitions when updating the portgroups in an existing network
though.
This patch adds a c
On 02/09/2015 08:19 AM, Ján Tomko wrote:
> On Mon, Feb 09, 2015 at 10:58:29AM +0100, Michal Privoznik wrote:
>> Instead of verbose string to enum conversion (if STREQ() else if
>> STREQ() else if STREQ() ...) lets use awesome VIR_ENUM_* macros.
>>
>> Signed-off-by: Michal Privoznik
>> ---
>> tool
o the code as written
isn't what was intended. Patch 1 takes care of that. Patch 2 fixes two
theoretical memory leaks (which never happen in real life, but could
some day if the functions are used differently).
Laine Stump (2):
domain: backfill listen address to parent listen attribute
Prior to 0.9.4, libvirt only supported a single listen, and it had to
be an IP address:
Starting with 0.9.4, a graphics element could have a
subelement (actually the grammar supports multiples, but all of the
drivers only support a single per ), and that
listen element can be of type='addre
virDomainGraphicsListenSetAddress() and
virDomainGraphicsListenSetNetwork() both set their respective char* to
NULL directly when asked to set it to NULL, which is okay as long as
it's already set to NULL. If these functions are ever called to clear
a listen object that has a valid string in addres
does that:
https://www.redhat.com/archives/libvir-list/2015-February/msg00332.html
Between the two patches, we will have fixed the problem for all versions
of server, as long as the client is new enough.
>From 5f8800d93375ee67dd94bf50a87ed75f44ca2b19 Mon Sep 17 00:00:00 2001
From: Laine Stump
Da
Prior to commit 7d5bf484747 (first appearing in libvirt 1.2.2), the
status XML of a domain's interface was missing a lot of important
information; mainly it just output the config of the interface, plus
the name of the tap device and qemu device alias. Commit 7d5bf484747
changed the status XML to i
On 02/12/2015 04:50 PM, John Ferlan wrote:
>
> On 02/09/2015 10:20 AM, Michal Privoznik wrote:
>> v2
>>
>> Michal Privoznik (4):
>> libvirt_private.syms: Expose virDomainNetTypeFromString
>> virsh attach-interface: Use enum instead of arbitrary integers
>> virsh attach-interface: Use virDomai
On 02/16/2015 08:46 PM, Antoni Segura Puimedon wrote:
> From: Antoni Segura Puimedon
>
> Midonet is an opensource virtual networking that over lays the IP
> network between hypervisors. Currently, such networks can be made
> with the openvswitch virtualport type. With this patch, one will
> be abl
On 02/17/2015 09:42 PM, Antoni Segura Puimedon wrote:
> Use the utilities introduced in the previous patches so the qemu
> driver is able to create tap devices that are bound (and unbound
> on domain destroyal) to Midonet virtual ports.
>
> Signed-off-by: Antoni Segura Puimedon
> ---
> src/conf/d
On 02/17/2015 09:42 PM, Antoni Segura Puimedon wrote:
> Adds the port type definitions and methods that will be used to bind
> interfaces to the Midonet virtual ports.
>
> virtnetdevmidonet.c adds the way to bind and unbind the ports by
> calling into the Midonet Host Agent control command line (in
On 02/19/2015 10:21 AM, Antoni Segura Puimedon wrote:
>
> Thanks a lot for the review Laine. I'll send the updated v3 today.
>
And I'll try to reply in a more timely fashion :-)
(BTW, I'm assuming that you have run "make syntax-check" and "make
check" on each patch individually; I haven't done th
On 02/17/2015 09:42 PM, Antoni Segura Puimedon wrote:
> Midonet is an opensource virtual networking that over lays the IP
> network between hypervisors. Currently, such networks can be made
> with the openvswitch virtualport type.
>
> This patch, defines the schema and documentation that will serve
The function that parses the subelement of a network used to
fail/log an error if the network definition contained both a
element as well as at least one or element. That
check was present because the configuration of a network should have
either one , one or more , or one or more ,
but never c
On 02/19/2015 02:26 PM, John Ferlan wrote:
>
> On 02/19/2015 11:24 AM, Martin Kletzander wrote:
>> When editing a domain with 'virsh edit' and failing validation, the
>> usual message pops up:
>>
>> Failed. Try again? [y,n,f,?]:
>>
>> Turning of validation can be ussable, mainly for testing (but
Commit f7afeddc added code to report to systemd an array of interface
indexes for all tap devices used by a guest. Unfortunately it not only
didn't add code to report the ifindexes for macvtap interfaces
(interface type='direct') or the tap devices used by type='ethernet',
it ended up sending "-1"
You'd think that I would know this, since I'm the person who reviewed
jrobson's patch adding support for the nativeMode attribute to the vlan
tag element. But you'd be wrong. Here is what the config looks like:
I understand that trunk='yes' means that packets with any
The patch I posted failed to pass make check for two reasons:
1) There are valid use cases when the interface object is
type='ethernet' but has no ifname. Apparently if you provide an "ifup"
script name for -netdev but don't specify a tap device name, qemu will
create a tap device for you, and in
On 02/20/2015 05:33 PM, Florin Stingaciu wrote:
> Hello,
>
> For the last little while I've been trying to configure a VM with a
> passthrough interface using SR-IOV. I've managed to configure SR-IOV
> on the hypervisor correctly. I'm working with a Mellanox ConnectX3
> card with two infiniband po
On 02/23/2015 08:48 PM, YAMAMOTO Takashi wrote:
>> On Tue, Feb 24, 2015 at 2:20 AM, YAMAMOTO Takashi
>> wrote:
>>
Adds the port type definitions and methods that will be used to bind
interfaces to the Midonet virtual ports.
virtnetdevmidonet.c adds the way to bind and unbind th
On 02/24/2015 12:42 PM, John Ferlan wrote:
>
> On 02/13/2015 02:17 AM, Luyao Huang wrote:
>> If a interface or network have both ipv6 and ipv4 address which can be used,
>> we do not know use which be a listen address. So introduce a new attribute
>> to help us chose this.
>>
>> graphics XML will l
On 02/24/2015 01:48 PM, John Ferlan wrote:
>
> On 02/24/2015 01:09 PM, Laine Stump wrote:
>> On 02/24/2015 12:42 PM, John Ferlan wrote:
> <...snip...>
>
>>> I see family as a "tristate" value. That is not provided is 0 and not
>>> printed... Th
On 02/12/2015 04:17 AM, Zhang Bo wrote:
> If we assign a VF, which has already been used by an active guest, to another
> guest, and try to start the 2nd guest later on, the 2nd guest would not
> start, and the VF won't work anymore.
>
> Steps to reproduce the problem:
> 1 Assign a VF to guest A, a
pushed *before* the nicindex fix patch).
Laine Stump (2):
network: only clear bandwidth if it has been set
util: check for null ifname inside virNetDevBandwidthSet()
src/conf/netdev_bandwidth_conf.c | 6 --
src/lxc/lxc_driver.c | 7 ++-
src/network/bridge_driver.c | 6
libvirt was unconditionally calling virNetDevBandwidthClear() for
every interface (and network bridge) of a type that supported
bandwidth, whether it actually had anything set or not. This doesn't
hurt anything (unless ifname == NULL!), but is wasteful.
This patch makes sure that all calls to virN
Previously this function relied on having ATTRIBUTE_NONNULL(1) in its
prototype rather than explicitly checking for a null
ifname. Unfortunately, ATTRIBUTE_NONNULL is just a hint to the
optimizer and code analyzers like Coverity, it doesn't actually check
anything at execution time, so the result w
On 02/17/2015 04:03 PM, John Ferlan wrote:
> Add virDomainGetIOThreadsInfo in order to return a list of
> virDomainIOThreadsInfoPtr structures which list the IOThread ID,
> the CPU Affinity map, and associated resources for each IOThread
> for the domain. For an active domain, the live data will be
On 02/25/2015 04:50 AM, lhuang wrote:
>
>
> And i also thought about another issue after your reminding: An
> interface can have more than one IPv6 address. But i still couldn't
> find a good way until now to chose which IPv6 address if we find more
> than one IPv6 address in one interface (maybe u
On 02/25/2015 06:12 AM, Michal Privoznik wrote:
> On 24.02.2015 20:39, Laine Stump wrote:
>> libvirt was unconditionally calling virNetDevBandwidthClear() for
>> every interface (and network bridge) of a type that supported
>> bandwidth, whether it actually had anything set
On 02/25/2015 04:40 AM, Martin Kletzander wrote:
> On Tue, Feb 24, 2015 at 02:39:52PM -0500, Laine Stump wrote:
>> When John Ferlan ran the Coverity static checker on my patches to fix
>> the problem with nicindexes, it began complaining about calling the
>> virNetDevBandwi
On 02/25/2015 11:37 AM, Michal Privoznik wrote:
> On 25.02.2015 17:29, Laine Stump wrote:
>> On 02/25/2015 06:12 AM, Michal Privoznik wrote:
>>> On 24.02.2015 20:39, Laine Stump wrote:
>>>> libvirt was unconditionally calling virNetDevBandwidthClear() for
>>&g
On 02/26/2015 08:53 AM, Ján Tomko wrote:
> Commit 6992994 started filling the listen attribute
> of the parent elements from type='network' listens.
>
> When this XML is passed to UpdateDevice, parsing fails:
> XML error: graphics listen attribute 10.20.30.40 must match
> address attribute of firs
On 02/26/2015 10:11 AM, Francesco Romani wrote:
> Hi,
>
> - Original Message -
>> From: "Laine Stump"
>> To: libvir-list@redhat.com
>> Cc: "Ján Tomko" , from...@redhat.com
>> Sent: Thursday, February 26, 2015 3:57:22 PM
>> Subjec
On 02/26/2015 11:39 AM, Ján Tomko wrote:
> On Thu, Feb 26, 2015 at 04:29:53PM +0100, Martin Kletzander wrote:
>> On Thu, Feb 26, 2015 at 09:57:22AM -0500, Laine Stump wrote:
>>> On 02/26/2015 08:53 AM, Ján Tomko wrote:
>>>> Commit 6992994 started filling the liste
On 03/02/2015 05:43 AM, Daniel P. Berrange wrote:
> On Mon, Mar 02, 2015 at 06:04:44PM +0800, Luyao Huang wrote:
>> When we start a vm which have rawio = 'yes' settings without
>> any file caps settings for qemu, qemu process still cannot use
>> this caps (CAP_SYS_RAWIO) and the /proc/pidofqemu/sta
On 03/04/2015 10:27 AM, Raymond Durand wrote:
> I read this in the context of direct device assignment: "All of the
> guest's memory must kept permanently in memory. This is because the
> guest may program the device with any address in its address space and
> the hypervisor has no way of handling
Commit 4bbe1029f fixed a problem in commit f7afeddc by moving the call
to virNetDevGetIndex() to a location common to all interface types (so
that the niceindex array would be filled in for macvtap as well as tap
interfaces), but the location was *too* common, as the original call
to virNetDevGetIn
On 03/10/2015 04:39 AM, Richard W.M. Jones wrote:
> On Tue, Mar 10, 2015 at 02:32:04AM -0400, Laine Stump wrote:
>> Commit 4bbe1029f fixed a problem in commit f7afeddc by moving the call
>> to virNetDevGetIndex() to a location common to all interface types (so
>> that the nic
On 02/24/2015 04:17 AM, Antoni Segura Puimedon wrote:
>
>
> On Tue, Feb 24, 2015 at 3:30 AM, Laine Stump <mailto:la...@redhat.com>> wrote:
>
> On 02/23/2015 08:48 PM, YAMAMOTO Takashi wrote:
> >> On Tue, Feb 24, 2015 at 2:20 AM, YAMAMOTO Takashi
&g
On 02/23/2015 03:54 PM, Antoni Segura Puimedon wrote:
> Adds the port type definitions and methods that will be used to bind
> interfaces to the Midonet virtual ports.
>
> virtnetdevmidonet.c adds the way to bind and unbind the ports by
> calling into the Midonet Host Agent control command line (in
601 - 700 of 6271 matches
Mail list logo
