[PATCH] test_driver: Implement virDomainGetSecurityLabelList

Signed-off-by: Luke Yue --- src/test/test_driver.c | 41 + 1 file changed, 41 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 611ec6d7ec..ae1b8ebc23 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[PATCH] test_driver: Implement virDomainGetMessages

Signed-off-by: Luke Yue --- src/test/test_driver.c | 53 ++ 1 file changed, 53 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index ae1b8ebc23..a7ea05464d 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

Re: [PATCH] test_driver: Implement virDomainGetMessages

On Tue, 2021-06-15 at 10:09 +0200, Martin Kletzander wrote: > On Mon, Jun 14, 2021 at 09:13:17PM +0800, Luke Yue wrote: > > Signed-off-by: Luke Yue > > --- > > src/test/test_driver.c | 53 > > ++ > > 1 file changed, 53

Re: [PATCH] test_driver: Implement virDomainGetSecurityLabelList

On Tue, 2021-06-15 at 10:08 +0200, Martin Kletzander wrote: > On Mon, Jun 14, 2021 at 09:12:57PM +0800, Luke Yue wrote: > > Signed-off-by: Luke Yue > > --- > > src/test/test_driver.c | 41 > > + > > 1 file changed, 41 inserti

[PATCH v2 0/3] Implement virDomainGetMessages for test driver

Implement virDomainGetMessages API for test driver. v2: Introduce testDomainObjCheckTaint to test the API. Luke Yue (3): test_driver: Implement virDomainGetMessages test_driver: Introduce testDomainObjCheckTaint tests: Add messages for virshtest src/test/test_driver.c | 110

[PATCH v2 1/3] test_driver: Implement virDomainGetMessages

Signed-off-by: Luke Yue --- src/test/test_driver.c | 53 ++ 1 file changed, 53 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 65710b78ef..dff96bceb6 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[PATCH v2 3/3] tests: Add messages for virshtest

As we introduced testDomainObjCheckTaint for test driver, the `dominfo` command in virshtest will now print tainting messages, so add them for test. Signed-off-by: Luke Yue --- tests/virshtest.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/virshtest.c b/tests/virshtest.c index

[PATCH v2 2/3] test_driver: Introduce testDomainObjCheckTaint

In order to test the virDomainGetMessages for test driver, we need to check some taints or deprecations, so introduce testDomainObjCheckTaint for checking taints. Signed-off-by: Luke Yue --- src/test/test_driver.c | 57 ++ 1 file changed, 57 insertions

Re: [PATCH] test_driver: Implement virDomainGetMessages

On Wed, 2021-06-23 at 00:09 +0200, Martin Kletzander wrote: > [Another one of those lost e-mails] > > On Wed, Jun 16, 2021 at 05:23:36PM +0800, Luke Yue wrote: > > On Tue, 2021-06-15 at 10:09 +0200, Martin Kletzander wrote: > > > On Mon, Jun 14, 2021 at 09:13:17

Re: [PATCH] test_driver: Implement virDomainGetSecurityLabelList

On Wed, 2021-06-23 at 00:07 +0200, Martin Kletzander wrote: > [Just found out I got couple of mails lost, so resending even though > it was sent >   a week ago] > > On Wed, Jun 16, 2021 at 05:21:17PM +0800, Luke Yue wrote: > > On Tue, 2021-06-15 at 10:08 +0200, Ma

[PATCH] tests: Replace deprecated ASN1 code

This fixes compiler warnings when building with libtasn1 4.17.0. Signed-off-by: Luke Yue --- tests/pkix_asn1_tab.c| 2 +- tests/virnettlshelpers.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/pkix_asn1_tab.c b/tests/pkix_asn1_tab.c index

[PATCH v2 0/2] Replace some libvirt handling function with GLib APIs

Compared to original: - Ensure the virFindFileInPath() return an absolute path (tried to use glibcompat, failed to solve some Windows related issue) - Just remove virFileAbsPath() and use g_canonicalize_filename() instead Luke Yue (2): Replace virFileAbsPath

[PATCH 1/2] Replace virFileAbsPath() with g_canonicalize_filename()

Signed-off-by: Luke Yue --- src/libvirt-domain.c | 16 src/libvirt_private.syms | 1 - src/util/virfile.c | 23 +-- src/util/virfile.h | 3 --- src/util/virlog.c| 2 +- 5 files changed, 10 insertions(+), 35 deletions(-) diff --git

[PATCH 2/2] test_driver: Implement virDomainGetSecurityLabel

Signed-off-by: Luke Yue --- src/test/test_driver.c | 31 +++ tests/virshtest.c | 2 ++ 2 files changed, 33 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2651301629..611ec6d7ec 100644 --- a/src/test/test_driver.c +++ b/src/test

[PATCH 2/2] virfile: Simplify virFindFileInPath() with g_find_program_in_path()

Signed-off-by: Luke Yue --- src/util/virfile.c | 48 +++--- 1 file changed, 3 insertions(+), 45 deletions(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 7fe357ab16..14b45f4e1b 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c

[PATCH 0/2] test_driver: Implement some Security related APIs

Luke Yue (2): test_driver: Implement virNodeGetSecurityModel test_driver: Implement virDomainGetSecurityLabel src/test/test_driver.c | 63 ++ tests/virshtest.c | 4 +++ 2 files changed, 67 insertions(+) -- 2.31.1

[PATCH 1/2] test_driver: Implement virNodeGetSecurityModel

Signed-off-by: Luke Yue --- src/test/test_driver.c | 32 tests/virshtest.c | 2 ++ 2 files changed, 34 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index ea5a5005e7..2651301629 100644 --- a/src/test/test_driver.c +++ b/src

Re: [PATCH 2/3] virfile: Simplify virFindFileInPath() with g_find_program_in_path()

On Fri, 2021-06-04 at 12:26 +0200, Martin Kletzander wrote: > On Mon, May 31, 2021 at 09:48:23AM +0800, Luke Yue wrote: > > The behavior is a little bit different when using > > g_find_program_in_path(), when the `file` contains a relative path, > > the > > ori

Re: [PATCH 3/3] virfile: Use g_canonicalize_file() to simplify virFileAbsPath()

On Fri, 2021-06-04 at 12:28 +0200, Martin Kletzander wrote: > On Mon, May 31, 2021 at 09:48:24AM +0800, Luke Yue wrote: > > Though the comment says that the function may return -1 on error, > > but it > > seems that now it will never return -1 now. So just use &g

[PATCH 1/3] virfile: Use g_build_filename() when building paths

The g_build_filename() would decide which separator to use instead of hardcoding in g_strdup_printf(). Related issue: https://gitlab.com/libvirt/libvirt/-/issues/12 Signed-off-by: Luke Yue --- src/util/virfile.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions

[PATCH 0/3] Replace some libvirt handling functions with GLib APIs

the function is a better choice? Related issue: https://gitlab.com/libvirt/libvirt/-/issues/12 Luke Yue (3): virfile: Use g_build_filename() when building paths virfile: Simplify virFindFileInPath() with g_find_program_in_path() virfile: Use g_canonicalize_file() to simplify virFileAbsPath() src

[PATCH 3/3] virfile: Use g_canonicalize_file() to simplify virFileAbsPath()

Though the comment says that the function may return -1 on error, but it seems that now it will never return -1 now. So just use g_canonicalize_file() to simplify the implementation. Signed-off-by: Luke Yue --- src/util/virfile.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions

[PATCH 2/3] virfile: Simplify virFindFileInPath() with g_find_program_in_path()

g_find_program_in_path() to simplify the implementation. Note that when PATH is not set, g_find_program_in_path() will search in `/bin:/usr/bin:.`. Signed-off-by: Luke Yue --- src/util/virfile.c | 42 ++ 1 file changed, 6 insertions(+), 36 deletions(-) diff --git

[PATCH v3 1/3] test_driver: Implement virDomainGetMessages

Signed-off-by: Luke Yue --- src/test/test_driver.c | 53 ++ 1 file changed, 53 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index ef0ddab54d..35742fcde3 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[PATCH v3 2/3] test_driver: Introduce testDomainObjCheckTaint

them for test. Signed-off-by: Luke Yue --- src/test/test_driver.c | 57 ++ tests/virshtest.c | 2 ++ 2 files changed, 59 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 35742fcde3..06ba7c4cd2 100644 --- a/src/test

[PATCH v3 3/3] conf: domain: Introduce and use virDomainObjGetMessages()

The test driver and qemu driver share the same code in virDomainGetMessages(), so extract it to a function. Signed-off-by: Luke Yue --- src/conf/domain_conf.c | 53 src/conf/domain_conf.h | 5 src/libvirt_private.syms | 1 + src/qemu

[PATCH v3 0/3] Implement virDomainGetMessages for test driver

v3: - Squash tests commit - Extract the same code in test driver and qemu driver to a function Luke Yue (3): test_driver: Implement virDomainGetMessages test_driver: Introduce testDomainObjCheckTaint conf: domain: Introduce and use virDomainObjGetMessages() src/conf/domain_conf.c | 53

Re: [PATCH v2 1/3] test_driver: Implement virDomainGetMessages

On Mon, 2021-06-28 at 16:12 +0200, Martin Kletzander wrote: > On Mon, Jun 28, 2021 at 10:45:38AM +0800, Luke Yue wrote: > > On Thu, 2021-06-24 at 17:19 +0200, Martin Kletzander wrote: > > > On Thu, Jun 24, 2021 at 06:59:59PM +0800, Luke Yue wrote: > > >

Re: [PATCH v3 1/3] test_driver: Implement virDomainGetMessages

On Fri, 2021-07-09 at 15:10 +0200, Martin Kletzander wrote: > On Wed, Jun 30, 2021 at 10:53:44AM +0800, Luke Yue wrote: > > Signed-off-by: Luke Yue > > --- > > src/test/test_driver.c | 53 > > ++ > > 1 file changed, 53 ins

Re: [PATCH v3 2/3] test_driver: Introduce testDomainObjCheckTaint

On Fri, 2021-07-09 at 15:07 +0200, Martin Kletzander wrote: > On Wed, Jun 30, 2021 at 10:53:45AM +0800, Luke Yue wrote: > > In order to test the virDomainGetMessages for test driver, we need > > to > > check some taints or deprecations, so introduce > > testDomainObj

[PATCH v4 3/4] test_driver: Introduce testDomainObjCheckTaint

them for test. Signed-off-by: Luke Yue --- src/test/test_driver.c | 77 ++ tests/virshtest.c | 2 ++ 2 files changed, 79 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index ef406a3d99..ca9c2fa2fb 100644 --- a/src/test

[PATCH v4 1/4] conf: domain: Introduce and use virDomainObjGetMessages()

The test driver and qemu driver could share the same code in virDomainGetMessages(), so extract it to a function. Signed-off-by: Luke Yue --- src/conf/domain_conf.c | 53 src/conf/domain_conf.h | 5 src/libvirt_private.syms | 1 + src/qemu

[PATCH v4 4/4] examples: test: Add a new test xml with more tainted configs for testing

Signed-off-by: Luke Yue --- examples/xml/test/testdomfc5.xml | 51 ++ examples/xml/test/testnode.xml | 1 + examples/xml/test/testnodeinline.xml | 51 ++ tests/virshtest.c| 54 +++- 4 files

[PATCH v4 2/4] test_driver: Implement virDomainGetMessages

Signed-off-by: Luke Yue --- src/test/test_driver.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 65710b78ef..ef406a3d99 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -9331,6 +9331,26

[PATCH v4 0/4] Implement virDomainGetMessages for test driver

v4: - Move testDomainObjCheckTaint to testParseDomains() - Add CPU tainted and deprecation check - Add a new xml with more tainted configs Luke Yue (4): conf: domain: Introduce and use virDomainObjGetMessages() test_driver: Implement virDomainGetMessages test_driver: Introduce

Re: [PATCH v4 1/4] conf: domain: Introduce and use virDomainObjGetMessages()

On Mon, 2021-07-12 at 19:32 +0800, Luke Yue wrote: > The test driver and qemu driver could share the same code in > virDomainGetMessages(), so extract it to a function. > > Signed-off-by: Luke Yue > --- >  src/conf/domain_conf.c   | 53 > +++

Re: [PATCH v2 1/3] test_driver: Implement virDomainGetMessages

On Thu, 2021-06-24 at 17:19 +0200, Martin Kletzander wrote: > On Thu, Jun 24, 2021 at 06:59:59PM +0800, Luke Yue wrote: > > Signed-off-by: Luke Yue > > --- > > src/test/test_driver.c | 53 > > ++ > > 1 file changed, 53 insert

Re: [PATCH v2 3/3] tests: Add messages for virshtest

On Thu, 2021-06-24 at 17:14 +0200, Martin Kletzander wrote: > On Thu, Jun 24, 2021 at 07:00:01PM +0800, Luke Yue wrote: > > As we introduced testDomainObjCheckTaint for test driver, the > > `dominfo` > > command in virshtest will now print tainting messages, so add

[PATCH 0/5] Implement some IOThread related APIs for test driver

- Implement virDomainAddIOThread - Implement virDomainDelIOThread - Implement virDomainGetIOThreadInfo - Add tests for these APIs Luke Yue (5): conf: domain: Introduce and use virDomainAddIOThreadCheck() test_driver: Implement virDomainAddIOThread and virDomainDelIOThread conf: domain

[PATCH 1/5] conf: domain: Introduce and use virDomainAddIOThreadCheck()

The test driver can share the same code with qemu driver when implement testDomainAddIOThreadCheck and testDomainDelIOThreadCheck, so extract them for test driver to use. Signed-off-by: Luke Yue --- src/conf/domain_conf.c | 66 src/conf/domain_conf.h

[PATCH 3/5] conf: domain: Introduce and use virDomainGetIOThreadsConfig()

The test driver can share the same code with qemu driver when implement testDomainGetIOThreadsConfig, so extract it for test driver to use. Signed-off-by: Luke Yue --- src/conf/domain_conf.c | 60 src/conf/domain_conf.h | 4 +++ src

[PATCH 5/5] tests: Test IOThread related functions for test driver

Signed-off-by: Luke Yue --- examples/xml/test/testdomfc4.xml | 4 tests/virshtest.c| 40 2 files changed, 44 insertions(+) diff --git a/examples/xml/test/testdomfc4.xml b/examples/xml/test/testdomfc4.xml index 26b7f25a06..25ad45365a 100644

[PATCH 2/5] test_driver: Implement virDomainAddIOThread and virDomainDelIOThread

Signed-off-by: Luke Yue --- src/test/test_driver.c | 160 + 1 file changed, 160 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index ef0ddab54d..6573ee3d61 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[PATCH 4/5] test_driver: Implement virDomainGetIOThreadInfo

Signed-off-by: Luke Yue --- src/test/test_driver.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 6573ee3d61..20aee59f98 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -9304,6 +9304,31

[PATCH] virfile: Replace AbsPath judgement method with g_path_is_absolute()

The g_path_is_absolute() considers more situations than just a simply "path[0] == '/'". Related issue: https://gitlab.com/libvirt/libvirt/-/issues/12 Signed-off-by: Luke Yue --- src/util/virfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virfile.c

GSoC 2021 Introduction

Hello, I'm Zelong Yue from East China Normal University. I am majoring in Software Engineering. I want to apply for the idea "Test driver API coverage" of libvirt community. I've noticed that there are requirements for application and I try to complete them. The small upstream contribution: I

[PATCH resend] virfile: Replace AbsPath judgement method with g_path_is_absolute()

The g_path_is_absolute() considers more situations than just a simply "path[0] == '/'". Related issue: https://gitlab.com/libvirt/libvirt/-/issues/12 Signed-off-by: Luke Yue --- src/util/virfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virfile.c

[PATCH 0/1] replace the method in several files

Using `git grep -n "\[0\].*'/'"` to find files that may need the treatment, then judge and replace. There may be some files replaced by mistake though. Luke Yue (1): Replace AbsPath judgement method with g_path_is_absolute() src/conf/backup_conf.c| 2 +- src/conf/snaps

[PATCH 1/1] Replace AbsPath judgement method with g_path_is_absolute()

The g_path_is_absolute() considers more situations than just a simply "path[0] == '/'". Related issue: https://gitlab.com/libvirt/libvirt/-/issues/12 Signed-off-by: Luke Yue --- src/conf/backup_conf.c| 2 +- src/conf/snapshot_conf.c | 2 +- src/conf/storage_sou

Re: [PATCH resend] virfile: Replace AbsPath judgement method with g_path_is_absolute()

? Zelong Michal Privoznik 于2021年4月13日周二 下午7:11写道： > > On 4/12/21 4:04 PM, Luke Yue wrote: > > The g_path_is_absolute() considers more situations > > than just a simply "path[0] == '/'". > > > > Related issue: https://gitlab.com/libvirt/libvirt/-/i

Re: [PATCH resend] virfile: Replace AbsPath judgement method with g_path_is_absolute()

OK, I got it, thanks! Zelong Michal Privoznik 于2021年4月13日周二 下午9:40写道： > > On 4/13/21 3:38 PM, Luke Yue wrote: > > Thanks for the review! > > > > I will look into them in my spare time, and I have a small question. > > Do I need to create a series of little patches?

Re: [PATCH 1/1] Replace AbsPath judgement method with g_path_is_absolute()

On Wed, 2021-04-21 at 10:03 +0200, Michal Privoznik wrote: > On 4/20/21 6:44 AM, Luke Yue wrote: > > The g_path_is_absolute() considers more situations > > than just a simply "path[0] == '/'". > > > > Related issue: https://gitlab.com/libvirt/libvirt/-/issue

[PATCH v3 5/5] virshtest: add test for domjobinfo and domjobabort

e completed job info should be deleted, so should get none next time. In testCompareDomJobAbortByName, domjobabort should set type to cancelled and preserve the operation. Signed-off-by: Luke Yue --- tests/virshtest.c | 89 +++ 1 file changed, 89 inser

[PATCH v3 2/5] test_driver: Implement virDomainGetJobStats

Signed-off-by: Luke Yue --- src/test/test_driver.c | 135 +++-- 1 file changed, 131 insertions(+), 4 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index ae6422c955..9899976966 100644 --- a/src/test/test_driver.c +++ b/src/test

[PATCH v3 0/5] Implement some job related APIs for test driver

v3: - Fix virDomainGetJobStats when use completed flags - Introduce testDomainSetDummyData - Add and refine some tests Luke Yue (5): test_driver: Implement virDomainGetJobInfo test_driver: Implement virDomainGetJobStats test_driver: Implement virDomainAbortJob test_driver: Introduce

[PATCH v3 3/5] test_driver: Implement virDomainAbortJob

As we are using jobState to store dummy job type, so just change it to VIR_DOMAIN_JOB_CANCELLED when try to abort a job. Signed-off-by: Luke Yue --- src/test/test_driver.c | 29 + 1 file changed, 29 insertions(+) diff --git a/src/test/test_driver.c b/src/test

Re: [PATCH 3/3] tests: Test BlkioParameters related functions for test driver

On Wed, 2021-08-18 at 14:37 +0200, Martin Kletzander wrote: > On Tue, Jul 13, 2021 at 01:42:14PM +0800, Luke Yue wrote: > > Signed-off-by: Luke Yue > > --- > > examples/xml/test/testdomfv0.xml | 11 + > > examples/xml/test/testnodeinline.xml | 11

[PATCH v3 1/5] test_driver: Implement virDomainGetJobInfo

Signed-off-by: Luke Yue --- src/test/test_driver.c | 89 ++ 1 file changed, 89 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index b096d49ac6..ae6422c955 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[PATCH v3 4/5] test_driver: Introduce testDomainSetDummyData

being changed, in order to test virDomainGetJobInfo and virDomainGetJobStats (domjobinfo in virsh). Signed-off-by: Luke Yue --- src/test/test_driver.c | 29 + 1 file changed, 29 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 3535

[PATCH v2 06/12] conf: Add tpm helpers for future use

Signed-off-by: Luke Yue --- src/conf/domain_conf.c | 67 src/conf/domain_conf.h | 6 src/libvirt_private.syms | 2 ++ 3 files changed, 75 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 6667426b9a..7f3d207a3e

[PATCH v2 07/12] test_driver: add TPM support for testDomainDetachDeviceLiveAndConfig

Signed-off-by: Luke Yue --- src/hypervisor/domain_driver.c | 18 ++ src/hypervisor/domain_driver.h | 3 +++ src/libvirt_private.syms | 1 + src/test/test_driver.c | 7 ++- 4 files changed, 28 insertions(+), 1 deletion(-) diff --git a/src/hypervisor

[PATCH v2 10/12] examples: xml: test: add xml for testing devices related APIs

Signed-off-by: Luke Yue --- examples/xml/test/testdevcontroller.xml | 1 + examples/xml/test/testdevdiskcdrom.xml | 5 +++ examples/xml/test/testdevfs.xml | 6 +++ examples/xml/test/testdevhostdev.xml| 5 +++ examples/xml/test/testdevif.xml | 6 +++ examples/xml/test

[PATCH v2 12/12] tests: Test detach-device and detach-device-alias for test driver

Signed-off-by: Luke Yue --- tests/virshtest.c | 78 +++ 1 file changed, 78 insertions(+) diff --git a/tests/virshtest.c b/tests/virshtest.c index 0d2ffd960a..c37d24e900 100644 --- a/tests/virshtest.c +++ b/tests/virshtest.c @@ -159,6 +159,8 @@ static

[PATCH v2 02/12] domain_driver: extract DetachXXXDeviceConfig related functions and use them

libxl / lxc / qemu drivers share some common codes in their DomainDetachDeviceConfig functions, so extract them to domain_driver and reuse them. Signed-off-by: Luke Yue --- src/hypervisor/domain_driver.c | 267 + src/hypervisor/domain_driver.h | 41 + src

[PATCH v2 05/12] test_driver: Implement virDomainDetachDevice

Signed-off-by: Luke Yue --- src/test/test_driver.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 6cabf78e7c..c6aead09c9 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -9747,6 +9747,14

[PATCH v2 11/12] virshtest: add expectError parameter to testCompareOutputLit

-by: Luke Yue --- tests/virshtest.c | 53 ++- 1 file changed, 29 insertions(+), 24 deletions(-) diff --git a/tests/virshtest.c b/tests/virshtest.c index 87da1f5889..0d2ffd960a 100644 --- a/tests/virshtest.c +++ b/tests/virshtest.c @@ -109,7 +109,7

[PATCH v2 01/12] conf: Introduce virDomainInputDefRemove and fix memory leak

Signed-off-by: Luke Yue --- src/conf/domain_conf.c | 12 src/conf/domain_conf.h | 2 ++ src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 3 ++- 4 files changed, 17 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

[PATCH v2 04/12] test_driver: Implement virDomainDetachDeviceAlias

Signed-off-by: Luke Yue --- src/test/test_driver.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 5e4d6d37ef..6cabf78e7c 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -9737,6 +9737,16

[PATCH v2 00/12] Implement detach device related APIs for test driver

s - Refine tests Luke Yue (12): conf: Introduce virDomainInputDefRemove and fix memory leak domain_driver: extract DetachXXXDeviceConfig related functions and use them test_driver: Implement virDomainDetachDeviceFlags test_driver: Implement virDomainDetachDeviceAlias test_driver:

[PATCH v2 03/12] test_driver: Implement virDomainDetachDeviceFlags

Introduce testDomainChgDevice for further development (just like what we did for IOThread). And introduce testDomainDetachDeviceLiveAndConfig for detaching devices. Signed-off-by: Luke Yue --- src/test/test_driver.c | 201 + 1 file changed, 201 insertions

[PATCH v2 08/12] conf: Add a memballoon helper for future use

Signed-off-by: Luke Yue --- src/conf/domain_conf.c | 24 src/conf/domain_conf.h | 4 src/libvirt_private.syms | 1 + 3 files changed, 29 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7f3d207a3e..62bb6669e8 100644 --- a/src

[PATCH v2 09/12] test_driver: add memballoon support for testDomainDetachDeviceLiveAndConfig

As the memballoon device shouldn't be hot-(un)pluggable, so error if try to remove it on a running domain, for removing from config, it's fine. Signed-off-by: Luke Yue --- src/hypervisor/domain_driver.c | 18 ++ src/hypervisor/domain_driver.h | 3 +++ src/libvirt_private.syms

Re: [PATCH v2 2/4] test_driver: Implement virDomainGetJobStats

On Tue, 2021-08-17 at 13:48 +0200, Martin Kletzander wrote: > On Mon, Aug 16, 2021 at 07:13:35PM +0800, Luke Yue wrote: > > Signed-off-by: Luke Yue > > --- > > src/test/test_driver.c | 105 > > + > > 1 file changed, 105

Re: [PATCH v2 4/4] virshtest: add test for domjobinfo

On Tue, 2021-08-17 at 13:52 +0200, Martin Kletzander wrote: > On Mon, Aug 16, 2021 at 07:13:37PM +0800, Luke Yue wrote: > > Signed-off-by: Luke Yue > > --- > > tests/virshtest.c | 11 +++ > > 1 file changed, 11 insertions(+) > > > > diff --git

Re: [PATCH 1/5] test_driver: Implement virDomainDetachDeviceFlags

On Tue, 2021-08-17 at 14:13 +0200, Martin Kletzander wrote: > On Mon, Aug 16, 2021 at 07:19:45PM +0800, Luke Yue wrote: > > Introduce testDomainChgDevice for further development (just like > > what we > > did for IOThread). And introduce > > testDomainDetachDeviceLive

Re: [PATCH 4/5] examples: xml: test: add xml for testing devices related APIs

On Tue, 2021-08-17 at 14:18 +0200, Martin Kletzander wrote: > On Mon, Aug 16, 2021 at 07:19:48PM +0800, Luke Yue wrote: > > Signed-off-by: Luke Yue > > --- > > examples/xml/test/testdevcontroller.xml |  1 + > > examples/xml/test/testdevdiskcdrom.xml  |  5 +++ > >

Re: [PATCH 5/5] tests: Test detach-device and detach-device-alias for test driver

On Tue, 2021-08-17 at 14:22 +0200, Martin Kletzander wrote: > On Mon, Aug 16, 2021 at 07:19:49PM +0800, Luke Yue wrote: > > Signed-off-by: Luke Yue > > --- > > tests/virshtest.c | 24 > > 1 file changed, 24 insertions(+) > > > >

[PATCH 5/5] tests: Test detach-device and detach-device-alias for test driver

Signed-off-by: Luke Yue --- tests/virshtest.c | 24 1 file changed, 24 insertions(+) diff --git a/tests/virshtest.c b/tests/virshtest.c index 53db2aa19a..273596d636 100644 --- a/tests/virshtest.c +++ b/tests/virshtest.c @@ -291,6 +291,22 @@ static int

[PATCH v2 1/4] test_driver: Implement virDomainGetJobInfo

off-by: Luke Yue --- src/test/test_driver.c | 89 ++ 1 file changed, 89 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 00cc13511a..9306f0e104 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -380,6 +380

[PATCH v2 4/4] virshtest: add test for domjobinfo

Signed-off-by: Luke Yue --- tests/virshtest.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/virshtest.c b/tests/virshtest.c index 53db2aa19a..0c46496c74 100644 --- a/tests/virshtest.c +++ b/tests/virshtest.c @@ -291,6 +291,13 @@ static int testCompareDomControlInfoByName

[PATCH v2 3/4] test_driver: Implement virDomainAbortJob

As we are using jobState to store dummy job type, so just change it to VIR_DOMAIN_JOB_CANCELLED when try to abort a job. Signed-off-by: Luke Yue --- src/test/test_driver.c | 29 + 1 file changed, 29 insertions(+) diff --git a/src/test/test_driver.c b/src/test

[PATCH v2 0/4] Implement some job related APIs for test driver

v2: - Change to priv->jobState to store job type directly instead of using time - Use priv->jobOperation to store job operation for virDomainGetJobStats Luke Yue (4): test_driver: Implement virDomainGetJobInfo test_driver: Implement virDomainGetJobStats test_driver: Imp

[PATCH v2 2/4] test_driver: Implement virDomainGetJobStats

Signed-off-by: Luke Yue --- src/test/test_driver.c | 105 + 1 file changed, 105 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 9306f0e104..93aeec7105 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[PATCH 2/5] test_driver: Implement virDomainDetachDeviceAlias

Signed-off-by: Luke Yue --- src/test/test_driver.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2ebdbaa604..e2463876fa 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -9721,6 +9721,16

[PATCH 0/5] Implement detach device related APIs for test driver

Luke Yue (5): test_driver: Implement virDomainDetachDeviceFlags test_driver: Implement virDomainDetachDeviceAlias test_driver: Implement virDomainDetachDevice examples: xml: test: add xml for testing devices related APIs tests: Test detach-device and detach-device-alias for test driver

[PATCH 1/5] test_driver: Implement virDomainDetachDeviceFlags

Introduce testDomainChgDevice for further development (just like what we did for IOThread). And introduce testDomainDetachDeviceLiveAndConfig for detaching devices. Signed-off-by: Luke Yue --- src/test/test_driver.c | 270 + 1 file changed, 270 insertions

[PATCH 3/5] test_driver: Implement virDomainDetachDevice

Signed-off-by: Luke Yue --- src/test/test_driver.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index e2463876fa..21e813db8f 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -9731,6 +9731,14

[PATCH 4/5] examples: xml: test: add xml for testing devices related APIs

Signed-off-by: Luke Yue --- examples/xml/test/testdevcontroller.xml | 1 + examples/xml/test/testdevdiskcdrom.xml | 5 +++ examples/xml/test/testdevfs.xml | 6 examples/xml/test/testdevhostdev.xml| 5 +++ examples/xml/test/testdevif.xml | 6 examples/xml/test

[PATCH v2 3/3] tests: Test BlkioParameters related functions for test driver

Signed-off-by: Luke Yue --- examples/xml/test/testdomfv0.xml | 11 ++ examples/xml/test/testnodeinline.xml | 11 ++ tests/virshtest.c| 55 3 files changed, 77 insertions(+) diff --git a/examples/xml/test/testdomfv0.xml b/examples/xml

[PATCH v2 1/3] test_driver: Implement virDomainGetBlkioParameters

Signed-off-by: Luke Yue --- src/test/test_driver.c | 47 ++ 1 file changed, 47 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index b096d49ac6..23176000b6 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[PATCH v2 0/3] Implement some blkio related APIs for test driver

v2: - Rebase to current master branch - Refine the tests Luke Yue (3): test_driver: Implement virDomainGetBlkioParameters test_driver: Implement virDomainSetBlkioParameters tests: Test BlkioParameters related functions for test driver examples/xml/test/testdomfv0.xml | 11

[PATCH v2 2/3] test_driver: Implement virDomainSetBlkioParameters

Signed-off-by: Luke Yue --- src/test/meson.build | 1 + src/test/test_driver.c | 49 ++ 2 files changed, 50 insertions(+) diff --git a/src/test/meson.build b/src/test/meson.build index f54585adfd..c0174ad856 100644 --- a/src/test/meson.build +++ b/src

[PATCH 2/3] virsh: Add '--full-seclabels' option for dominfo

There is no virsh command uses virDomainGetSecurityLabelList API, so add an option for dominfo to call it and print full list of security labels. Also realign some outputs as it's now "Security labels:" instead of "Security label:". Signed-off-by: Luke Yue --- docs/manpages

[PATCH 1/3] test_driver: Implement virDomainGetSecurityLabelList

Signed-off-by: Luke Yue --- src/test/test_driver.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2f19b7c520..1b5914c890 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[PATCH 3/3] tests: Add test for virDomainGetSecurityLabelList

Signed-off-by: Luke Yue --- tests/virshtest.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/virshtest.c b/tests/virshtest.c index 0d703f3765..4fb4799456 100644 --- a/tests/virshtest.c +++ b/tests/virshtest.c @@ -69,6 +69,7 @@ Managed save:no\n\ Security model

Re: [PATCH v3 0/5] Implement some job related APIs for test driver

On Wed, 2021-08-18 at 22:17 +0800, Luke Yue wrote: > v3: > - Fix virDomainGetJobStats when use completed flags > - Introduce testDomainSetDummyData > - Add and refine some tests > > Luke Yue (5): >   test_driver: Implement virDomainGetJobInfo >   test_driver: Implem

[PATCH 0/3] Add an option to use virDomainGetSecurityLabelList and test it

Luke Yue (3): test_driver: Implement virDomainGetSecurityLabelList virsh: Add '--full-seclabels' option for dominfo tests: Add test for virDomainGetSecurityLabelList docs/manpages/virsh.rst | 5 +- src/test/test_driver.c | 42 + tests/virsh-undefine | 8

[PATCH v4 06/11] test_driver: Implement virDomainGetIOThreadInfo

() as bitmap_size instead. Signed-off-by: Luke Yue --- src/test/test_driver.c | 29 + 1 file changed, 29 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index b588bbc32e..0971661c89 100644 --- a/src/test/test_driver.c +++ b/src/test

[PATCH v4 08/11] test_driver: Implement testDomainSetIOThreadParams

Signed-off-by: Luke Yue --- src/test/test_driver.c | 90 ++ 1 file changed, 90 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 43c0822c87..7cff26776a 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[PATCH v4 07/11] test_driver: Implement virDomainPinIOThread

Signed-off-by: Luke Yue --- src/test/test_driver.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 0971661c89..43c0822c87 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

  1   2   >