[libvirt] [PATCH 1/3] qemu: hot-plug: Fix broken SCSI disk hot-plug

oris Fiuczynski <fiu...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> --- src/qemu/qemu_hotplug.c | 20 1 file changed, 20 insertions(+) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu

[libvirt] [PATCH 3/3] tests: Add test cases for SCSI disk hot-plug with QEMU

Verify that SCSI controllers get created automatically when a SCSI disk is hot-plugged to a domain that doesn't have a matching SCSI controller defined already. Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com>

[libvirt] [PATCH 0/3] qemu: Fix auto-generation of SCSI controllers for hot-plugged SCSI disks and add tests

This patch series fixes the auto-generation of SCSI controllers for hot-plugged SCSI disks and hot-plugged SCSI hostdevs. Additionally this patch series adds test cases for the auto-generation of SCSI controllers to the test suite. Marc Hartmayer (3): qemu: hot-plug: Fix broken SCSI disk hot

[libvirt] [PATCH 2/3] qemu: SCSI hostdev hot-plug: Fix automatic creation of SCSI controllers

Ensure that the given controller and all controllers with a smaller index exist; there must not be any missing index in between. Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> Signed-off-by: Marc Hartmayer <mhart...@lin

Re: [libvirt] [PATCH python 2/2] event-test: Add node device lifecycle event tests

On Thu, Jul 28, 2016 at 02:14 PM +0200, Jovanka Gulicoska wrote: > --- > examples/event-test.py | 16 > 1 file changed, 16 insertions(+) > > diff --git a/examples/event-test.py b/examples/event-test.py > index 1bcea07..e06ebc6 100755 > ---

Re: [libvirt] [PATCH] examples: If parameters count is zero we have nothing to do

On Sat, Jul 09, 2016 at 11:02 AM +0200, Michal Privoznik <mpriv...@redhat.com> wrote: > On 06.07.2016 15:47, Marc Hartmayer wrote: >> The virDomainGetCPUStats() API contract permits nparams == >> 0. print_cpu_usage() assumes nparams > 0 because the domtop example >>

[libvirt] [PATCH 3/3] tests: Add test cases for the empty bitmap

ed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> --- tests/virbitmaptest.c | 17 + 1 file changed, 17 insertions(+) diff --git a/tests/virbitmaptest.c b/tests/virbitmaptest.c index 009fa0d..a17ef82 100644 ---

[libvirt] [PATCH 2/3] util: bitmap: Mention the size == 0 handling

Bjoern Walk <bw...@linux.vnet.ibm.com> Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> --- src/util/virbitmap.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/util/virbitmap.c b/src/util/virbitmap.c index 2029a73..3b85c16 100644 --- a/src/ut

[libvirt] [PATCH 1/3] util: bitmap: clarify virBitmapLastSetBit() behavior for empty bitmaps

y: Bjoern Walk <bw...@linux.vnet.ibm.com> Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> --- src/util/virbitmap.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/util/virbitmap.c b/src/util/virbitmap.c index 3276763..2029a73 100644 --- a/

[libvirt] [PATCH 0/3] bitmap: Clarify and add tests for empty bitmap

This patch series clarifies the virBitmapLastSetBit function and adds some tests for the empty bitmap. It also clarifies the documentations of virBitmapNewQuiet and virBitmapNew. Marc Hartmayer (3): util: bitmap: clarify virBitmapLastSetBit() behavior for empty bitmaps util: bitmap: Mention

[libvirt] [PATCH] examples: If parameters count is zero we have nothing to do

ris Fiuczynski <fiu...@linux.vnet.ibm.com> Reviewed-by: Sascha Silbe <si...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> --- examples/domtop/domtop.c | 5 + 1 file changed, 5 insertions(+) d

[libvirt] [PATCH] virsystemd: Fix error check

stemd: don't report an error if the guest is already terminated") Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Sascha Silbe <si...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> --- src/util/virsystemd.c | 2 +- 1 fil

Re: [libvirt] [PATCH 1/3] qemu: hot-plug: Fix broken SCSI disk hot-plug

On Thu, Jun 30, 2016 at 12:34 PM +0200, Peter Krempa wrote: >> qemuDomainObjPrivatePtr priv = vm->privateData; >> +virDomainControllerDefPtr cont = NULL; > > This variable isn't necessary. >> +/* Let's make sure the disk has a controller defined and loaded before

Re: [libvirt] [PATCH 2/2] tests: qemuhotplug: Don't free the monitor object as part of @vm

nitor with 'priv->mon = qemuMonitorTestGetMonitor(data->mon);' (testQemuHotplugCpuPrepare in tests/qemuhotplugtest.c). Shouldn't we use 'priv->mon = virObjectRef(qemuMonitorTestGetMonitor(data->mon));' for getting the reference (and later on 'virObjectUnref(priv->mon); priv->mon = NULL;')

Re: [libvirt] [PATCH 00/10] Another set of qemu namespace fixes

> > -- > libvir-list mailing list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list > Tested the patch series and the problems with v3.0.0 - starting domains with hostdev devices - hot plugging seem to be fixed. -- Beste Grüße / Kind regards

Re: [libvirt] [PATCH] remote generator: handle remoteDomainCreateWithFlags()

On Thu, Jan 19, 2017 at 09:17 PM +0100, Marc Hartmayer <mhart...@linux.vnet.ibm.com> wrote: > This commit removes the handcrafted code for > remoteDomainCreateWithFlags() and lets it auto generate. > > A little bit of history repeating... > Commit 03d813bbcd7b4a18360105

[libvirt] [PATCH] qemu: Fix deadlock across fork() in QEMU driver

in the same way as it is described in commit 61b52d2e3813cc8c9ff3ab67f232bd0c65f7318d. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> --- src/qemu/qemu_domain.c | 73 +++

Re: [libvirt] [PATCH v2] node_device: Check return value for udev_new()

On Mon, Feb 20, 2017 at 02:48 PM +0100, Martin Kletzander <mklet...@redhat.com> wrote: > On Fri, Feb 10, 2017 at 10:44:44AM +0100, Marc Hartmayer wrote: >>The comment was actually wrong as >>https://www.freedesktop.org/software/systemd/man/udev_new.html# >>me

Re: [libvirt] [PATCH] qemuProcessInit: Jump onto correct label in case of error

On Thu, Feb 23, 2017 at 05:46 PM +0100, Michal Privoznik <mpriv...@redhat.com> wrote: > On 02/23/2017 05:40 PM, Marc Hartmayer wrote: >> On Thu, Feb 23, 2017 at 05:15 PM +0100, Michal Privoznik >> <mpriv...@redhat.com> wrote: >>> After eca76884ea in case o

[libvirt] [PATCH 2/2] qemu: Validate the domain after marking the current domain as transient

Validate the domain that actually will be started. It's semantically more clear and also it can detect failures that may have happened in virDomainObjSetDefTransient(). Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com&

[libvirt] [PATCH 1/2] qemu: Fix incorrect jump labels in error paths

Fix incorrect jump labels in error paths as the stop jump is only needed if the driver has already changed the state. For example 'virAtomicIntInc(>nactive)' will be 'reverted' in the qemuProcessStop call. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Boris F

[libvirt] [PATCH 0/2] qemu: Small fix and validate the domain that actually will be started

Marc Hartmayer (2): qemu: Fix incorrect jump labels in error paths qemu: Validate the domain after marking the current domain as transient src/qemu/qemu_process.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) -- 2.5.5 -- libvir-list mailing list libvir

Re: [libvirt] [PATCH 2/2] qemu: Validate the domain after marking the current domain as transient

On Thu, Feb 23, 2017 at 03:33 PM +0100, Michal Privoznik <mpriv...@redhat.com> wrote: > On 02/23/2017 10:44 AM, Marc Hartmayer wrote: >> Validate the domain that actually will be started. It's semantically >> more clear and also it can detect failures t

Re: [libvirt] [PATCH] qemuProcessInit: Jump onto correct label in case of error

ably more safe :) > +} > } else { > vm->def->id = qemuDriverAllocateID(driver); > qemuDomainSetFakeReboot(driver, vm, false); > -- > 2.11.0 > Beste Grüße / Kind regards Marc Hartmayer IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsr

Re: [libvirt] [PATCH 1/2] qemu: Fix incorrect jump labels in error paths

On Thu, Feb 23, 2017 at 03:33 PM +0100, Michal Privoznik <mpriv...@redhat.com> wrote: > On 02/23/2017 10:44 AM, Marc Hartmayer wrote: >> Fix incorrect jump labels in error paths as the stop jump is only >> needed if the driver has already changed the state. For exampl

[libvirt] [PATCH v2] node_device: Check return value for udev_new()

The comment was actually wrong as https://www.freedesktop.org/software/systemd/man/udev_new.html# mentions that on failure NULL is returned. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> --- src/node_device/node_device_udev.c | 11 +-- 1 file changed, 5 insertions

Re: [libvirt] [PATCH 4/4] rpc: Fix potentially segfaults

On Thu, Feb 09, 2017 at 08:17 PM +0100, Laine Stump <la...@laine.org> wrote: > On 02/09/2017 09:21 AM, Marc Hartmayer wrote: >> On Thu, Feb 09, 2017 at 03:13 PM +0100, Marc Hartmayer >> <mhart...@linux.vnet.ibm.com> wrote: >>> We have to allocate first and i

Re: [libvirt] [PATCH] remote generator: handle remoteDomainCreateWithFlags()

On Thu, Feb 09, 2017 at 11:39 PM +0100, John Ferlan <jfer...@redhat.com> wrote: > On 01/19/2017 03:17 PM, Marc Hartmayer wrote: >> This commit removes the handcrafted code for >> remoteDomainCreateWithFlags() and lets it auto generate. >> >> A little bit

[libvirt] [PATCH 0/4] Fixes for segmentation faults

This patch series fixes some segmentation faults. Marc Hartmayer (4): qemu: Check if virQEMUCapsNewCopy(...) has failed conf: Fix libvirtd free() segfault if virDomainChrSourceDefNew(...) fails util: reset the counters to zero rpc: Fix potentially segfaults src/conf/domain_conf.c

Re: [libvirt] [PATCH 1/4] qemu: Check if virQEMUCapsNewCopy(...) has failed

On Thu, Feb 09, 2017 at 03:13 PM +0100, Marc Hartmayer <mhart...@linux.vnet.ibm.com> wrote: > Check if virQEMUCapsNewCopy(...) has failed, thus a segmentation fault > in virQEMUCapsFilterByMachineType(...) will be avoided. > > Signed-off-by: Marc Hartmayer <mhart...@linux.vne

[libvirt] [PATCH 4/4] rpc: Fix potentially segfaults

refore it was possible that virNetServerServiceDispose was called => segmentation fault. For safeness NULL pointer check were added in virNetServerServiceDispose(). Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> Reviewe

[libvirt] [PATCH 3/4] util: reset the counters to zero

all of 'virNetDevIPInfoClear(>guestIP)') and the resulting call of virDomainNetDefFree(def) in the error path of virDomainNetDefParseXML() (this leads to the second call of virNetDevIPInfoClear(>guestIP), and finally to the segmentation fault). Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.c

[libvirt] [PATCH 2/4] conf: Fix libvirtd free() segfault if virDomainChrSourceDefNew(...) fails

If virDomainChrSourceDefNew(xmlopt) fails, it will lead to free()ing the uninitialized pointer bus. The fix for this is to initialize bus with NULL. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> Reviewed-by: Bjo

Re: [libvirt] [PATCH 4/4] rpc: Fix potentially segfaults

On Thu, Feb 09, 2017 at 03:13 PM +0100, Marc Hartmayer <mhart...@linux.vnet.ibm.com> wrote: > We have to allocate first and if, and only if, it was successful we > can set the count. A segfault has occurred in > virNetServerServiceNewPostExecRestart() when VIR_ALLOC_N(svc->sock

[libvirt] [PATCH 1/4] qemu: Check if virQEMUCapsNewCopy(...) has failed

Check if virQEMUCapsNewCopy(...) has failed, thus a segmentation fault in virQEMUCapsFilterByMachineType(...) will be avoided. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- src/qemu/qemu_capabilities.c | 4 1

Re: [libvirt] Availability of libvirt-3.0.0 release candidate 2

On Tue, Jan 17, 2017 at 04:41 PM +0100, Michal Privoznik <mpriv...@redhat.com> wrote: > On 01/17/2017 04:28 PM, Marc Hartmayer wrote: >> On Tue, Jan 17, 2017 at 03:28 PM +0100, Michal Privoznik >> <mpriv...@redhat.com> wrote: >>> [Dropping libvirt-announce] &

Re: [libvirt] [PATCH] qemu: catch failure of drive_add

RATION_FAILED, "%s", > + reply); > +goto cleanup; > +} > + > ret = 0; > > cleanup: > -- > 2.9.3 > > -- > libvir-list mailing list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-li

Re: [libvirt] Availability of libvirt-3.0.0 release candidate 2

|---| | 0 | 0 | 1 | | 0 | 1 | 1 | | 1 | 0 | 1 | | 1 | 1 | 0 | -- Beste Grüße / Kind regards Marc Hartmayer IBM Deutschland Research & Development

Re: [libvirt] Availability of libvirt-3.0.0 release candidate 2

Update: It's a SELinux labeling problem and seems to be introduced by the QEMU namespace patches. On Tue, Jan 17, 2017 at 11:18 AM +0100, Marc Hartmayer <mhart...@linux.vnet.ibm.com> wrote: > Hey, > > I have tried to live hot plug a disk backed on a qcow2 disk (see XML > snippe

Re: [libvirt] Availability of libvirt-3.0.0 release candidate 2

Hey, I have tried to live hot plug a disk backed on a qcow2 disk (see XML snippet below) on a s390 system and I've got the following error message: internal error: unable to execute QEMU command 'device_add': Property 'scsi-hd.drive' can't find value 'drive-scsi0-0-0-0'

[libvirt] [PATCH] remote generator: handle remoteDomainCreateWithFlags()

() 'remote_domain_create_with_flags_args ret;' but in fact it has to be 'remote_domain_create_with_flags_ret ret;'. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> --- src/remo

Re: [libvirt] [PATCH 1/4] Unify checking for machine1 systemd service

edesktop.machine1"); > -if (ret < 0) > -goto cleanup; > - > -if ((ret = virDBusIsServiceRegistered("org.freedesktop.systemd1")) < 0) > +if ((ret = virSystemdHasCreateMachine()) < 0) > goto cleanup; > > ret

Re: [libvirt] [PATCH 2/2] qemu: Validate the domain after marking the current domain as transient

On Thu, Feb 23, 2017 at 05:36 PM +0100, "Daniel P. Berrange" <berra...@redhat.com> wrote: > On Thu, Feb 23, 2017 at 05:22:44PM +0100, Marc Hartmayer wrote: >> On Thu, Feb 23, 2017 at 03:33 PM +0100, Michal Privoznik >> <mpriv...@redhat.com> wrote: >&g

Re: [libvirt] [PATCH 1/2] conf: Detect misconfiguration between disk bus and disk address

On Wed, Nov 16, 2016 at 09:09 AM +0100, Peter Krempa wrote: >> +{ >> +if (addressType == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) >> +return true; >> + >> +switch (bus) { >> +case VIR_DOMAIN_DISK_BUS_SATA: >> +case VIR_DOMAIN_DISK_BUS_SCSI: >> +case

[libvirt] [PATCH 2/2] tests: Add tests for disk configuration validation

Add tests for controller based disks to check disk address compatibility with disk bus types. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- .../qem

[libvirt] [PATCH 0/2] Detect misconfiguration between disk bus and disk address

function, as it is already implemented in virDomainDeviceDefPostParse(), for example. Marc Hartmayer (2): conf: Detect misconfiguration between disk bus and disk address tests: Add tests for disk configuration validation src/conf/domain_conf.c | 46

[libvirt] [PATCH 2/3] virutil: fix trailing '/' for path prefixes

From: Bjoern Walk <bw...@linux.vnet.ibm.com> The path prefixes for sysfs trees are always prepended by paths beginning with a slash, making the trailing slash in the prefix redundant. Signed-off-by: Bjoern Walk <bw...@linux.vnet.ibm.com> Reviewed-by: Marc Hartmayer <mhart...@lin

[libvirt] [PATCH 3/3] qemu: Removed an outdated comment in qemuDomainSaveImageStartVM()

Removed the comment 'Set the migration source' as it isn't valid anymore and 'start it up' isn't useful as qemuProcessStart() is already a speaking name. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> --- src/qemu/qemu_driver.c | 1 - 1 file changed, 1 deletion(-) diff --git

[libvirt] [PATCH 0/3] Couple of small fixes and improvements

Fixed trailing '/' for path, removed an obsolete comment, and removed a useless warning. Bjoern Walk (1): virutil: fix trailing '/' for path prefixes Marc Hartmayer (2): virfile: Only generate a warning if there is something to report qemu: Removed an outdated comment

[libvirt] [PATCH 1/3] virfile: Only generate a warning if there is something to report

Only generate a warning if there is something to report. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> --- src/util/virfile.c | 2 +- 1 file changed,

[libvirt] [PATCH 1/2] conf: Detect misconfiguration between disk bus and disk address

are compatible or not. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- src/conf/domain_conf.c | 46 ++ 1 file changed, 46 insertions(+) diff --git a/src/conf/domain_conf.

[libvirt] [PATCH 2/3] util: Add virHostdevIsSCSIDevice()

Add the function virHostdevIsSCSIDevice() which detects whether a hostdev is a SCSI device or not. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ib

[libvirt] [PATCH 0/3] Fix improper union member access on hostdevs and refactoring

This patch series fixes improper union member accesses on hostdevs. Additionally, it adds a util function which checks whether a hostdev is a SCSI device or not. This function is used to simplify and clarify the code. Marc Hartmayer (3): qemu: Fix improper union member access on hostdevs util

[libvirt] [PATCH 1/3] qemu: Fix improper union member access on hostdevs

Add missing checks if a hostdev is a subsystem/SCSI device before access the union member 'subsys'/'scsi'. Also fix indentation and simplify qemuDomainObjCheckHostdevTaint(). Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com&

[libvirt] [PATCH 3/3] Refactoring: Use virHostdevIsSCSIDevice()

Use the util function virHostdevIsSCSIDevice() to simplify if statements. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> --- src/Makefile.am

[libvirt] [PATCH 0/2] qemuDomainDiskChangeSupported: Add missing 'address' check

Disk->info is not live updatable so add a check for this. Otherwise libvirt reports success even though no data was updated. Marc Hartmayer (2): conf: Make virDomainDeviceInfoAddressIsEqual() public qemu: qemuDomainDiskChangeSupported: Add missing 'address' check src/conf/domain_con

[libvirt] [PATCH 2/2] qemu: qemuDomainDiskChangeSupported: Add missing 'address' check

Disk->info is not live updatable so add a check for this. Otherwise libvirt reports success even though no data was updated. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@

[libvirt] [PATCH 1/2] conf: Make virDomainDeviceInfoAddressIsEqual() public

This function will be needed by the QEMU driver in an upcoming patch. Additionally, removed a useless empty line. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> --- src/conf/domain_conf.c | 3 +-- src/conf/domain_conf.h | 5 + src/libvirt_private.syms | 1 + 3 files c

Re: [libvirt] [PATCH] news: document drive addresses fix

On Thu, Jan 12, 2017 at 11:42 AM +0100, Andrea Bolognani <abolo...@redhat.com> wrote: > On Thu, 2017-01-12 at 10:58 +0100, Marc Hartmayer wrote: >> Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> >> --- >> docs/news.xml | 9 + >>

[libvirt] [PATCH] news: document drive addresses fix

Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 8175fd0..92e39f9 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -195,6 +195,15 @@ separate path

[libvirt] [PATCH v2 1/2] conf: Detect misconfiguration between disk bus and disk address

are compatible or not. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- src/conf/domain_conf.c | 56 ++ 1 file changed, 56 insertions(+) diff --git a/src/conf/domain_conf.

[libvirt] [PATCH v2 0/2] Detect misconfiguration between disk bus and disk address

function, as it is already implemented in virDomainDeviceDefPostParse(), for example. Changelog: - v1 -> v2: + Use full enumeration of the bus types + Add warning for unexpected bus type Marc Hartmayer (2): conf: Detect misconfiguration between disk bus and disk address tests: Add te

[libvirt] [PATCH v2 2/2] tests: Add tests for disk configuration validation

Add tests for controller based disks to check disk address compatibility with disk bus types. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- .../qem

[libvirt] [PATCH 5/5] tests: add test cases for address conflicts

Add test cases for address conflicts between disks and hostdevs that are using drive addresses. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> --- .../qemuxml2argv-disk-drive-address-conflic

[libvirt] [PATCH 1/5] conf: simplify functions virDomainSCSIDriveAddressIsUsedBy*()

Pass the virDomainDeviceDriveAddress as a struct instead of individual arguments. Reworked the function descriptions. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> --- src/conf/domain

[libvirt] [PATCH 2/5] conf: virDomainDriveAddressIsUsedByDisk: Rename type to bus_type

Comparing the parameter 'type' against the member 'bus' instead of against the member 'type' is quite confusing. Rename the parameter 'type' to 'bus_type' to clarify its meaning. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vne

[libvirt] [PATCH 4/5] conf: add global check for duplicate drive addresses

(virDomainDefParseFlags) to disable this validation while updating or detaching a disk or hostdev. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> --- src/conf/domain_conf.c | 104 +

[libvirt] [PATCH 3/5] tests: don't use duplicate disk addresses

Don't use duplicate disk addresses in test cases unless it's useful. At least the test case will break once we have a check for uniqueness of addresses at time of domain definition. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> --- tests/qemuxml2argvdata/qemuxml2argv-se

[libvirt] [PATCH 0/5] Reject duplicate drive addresses

. Marc Hartmayer (5): conf: simplify functions virDomainSCSIDriveAddressIsUsedBy*() conf: virDomainDriveAddressIsUsedByDisk: Rename type to bus_type tests: don't use duplicate disk addresses conf: add global check for duplicate drive addresses tests: add test cases for address conflicts

[libvirt] [PATCH] node_device: Check return value for udev_new()

The comment was actually wrong as https://www.freedesktop.org/software/systemd/man/udev_new.html mentions that on failure NULL is returned. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> Reviewed-by: Boris Fiu

Re: [libvirt] [PATCH 0/5] Reject duplicate drive addresses

he release, if you don't mind. > > I've just pushed these. Thank you for the contribution. > > Michal > Thanks. Marc -- Beste Grüße / Kind regards Marc Hartmayer IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz Geschäftsf

Re: [libvirt] [PATCH] node_device: Check return value for udev_new()

On Wed, Nov 30, 2016 at 04:25 PM +0100, Martin Kletzander <mklet...@redhat.com> wrote: > On Wed, Nov 30, 2016 at 01:45:32PM +0100, Marc Hartmayer wrote: >>The comment was actually wrong as >>https://www.freedesktop.org/software/systemd/man/udev_new.html >>mentions that

Re: [libvirt] [PATCH v2 0/2] Detect misconfiguration between disk bus and disk address

s it is already implemented in >> > virDomainDeviceDefPostParse(), for example. >> > >> > Changelog: >> >  - v1 -> v2: >> >+ Use full enumeration of the bus types >> >+ Add warning for unexpected bus type >> > >> > Marc Ha

Re: [libvirt] [PATCH] node_device: Check return value for udev_new()

On Thu, Dec 08, 2016 at 01:48 PM +0100, Martin Kletzander <mklet...@redhat.com> wrote: > On Thu, Dec 01, 2016 at 01:52:03PM +0100, Marc Hartmayer wrote: >>On Wed, Nov 30, 2016 at 04:25 PM +0100, Martin Kletzander >><mklet...@redhat.com> wrote: >>> On Wed, No

Re: [libvirt] [PATCH 0/2] qemuDomainDiskChangeSupported: Add missing 'address' check

On Tue, Dec 20, 2016 at 11:33 AM +0100, Michal Privoznik <mpriv...@redhat.com> wrote: > On 06.12.2016 15:30, Marc Hartmayer wrote: >> Disk->info is not live updatable so add a check for this. Otherwise >> libvirt reports success even though no data was updated.

Re: [libvirt] [PATCH v2 0/2] Detect misconfiguration between disk bus and disk address

On Tue, Dec 20, 2016 at 11:54 AM +0100, Michal Privoznik <mpriv...@redhat.com> wrote: > On 29.11.2016 13:11, Marc Hartmayer wrote: >> This patch series adds the functionality to detect a misconfiguration >> between disk bus type and disk address type for disks that are usin

Re: [libvirt] [PATCH 2/2] qemu: Validate the domain after marking the current domain as transient

On Wed, Mar 08, 2017 at 10:41 AM +0100, "Daniel P. Berrange" <berra...@redhat.com> wrote: > On Wed, Mar 08, 2017 at 10:32:32AM +0100, Marc Hartmayer wrote: >> On Mon, Feb 27, 2017 at 11:20 AM +0100, "Daniel P. Berrange" >> <berra...@redhat.com>

[libvirt] [PATCH 4/5] qemu: remove ATTRIBUTE_UNUSED in qemuProcessHandleMonitorEOF

This attribute is not needed here, since @mon is in use. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- src/qemu/qemu_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_pro

[libvirt] [PATCH 5/5] refactoring: Use the return value of virObjectRef directly

Use the return value of virObjectRef directly. This way, it's easier for another reader to identify the reason why the additional reference is required. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- src

[libvirt] [PATCH 2/5] qemu: Turn qemuDomainLogContext into virObject

This way qemuDomainLogContextRef() and qemuDomainLogContextFree() is no longer needed. The naming qemuDomainLogContextFree() was also somewhat misleading. Additionally, it's easier to turn qemuDomainLogContext in a self-locking object. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.

[libvirt] [PATCH 3/5] qemu: Implement qemuMonitorRegister()

Implement qemuMonitorRegister() as there is already a qemuMonitorUnregister() function. This way it may be easier to understand the code paths. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- src/qemu/qemu_mo

[libvirt] [PATCH 1/5] qemu: Fix two use-after-free situations

ccur are fixed as well (qemuMigrationFinish, qemuProcessStart, and qemuDomainSaveImageStartVM). Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reported-by: Sascha Silbe <si...@linux.vnet.ibm.com> --- src/qemu/qemu_monitor.c | 44 ++-- src/qemu

[libvirt] [PATCH 0/5] Use-after-free fix and cleanups

While looking at a use-after-free situation going through how the QEMU monitor is set up I noticed some things. These cleanups and the fix for the use-after-free are the result of that. Marc Hartmayer (5): qemu: Fix two use-after-free situations qemu: Turn qemuDomainLogContext into virObject

Re: [libvirt] [PATCH 1/2] qemu: hotplug: Add debug log when dispatching device removal to existing thread

ainObjBroadcast(vm); > -- > 2.12.0 > > -- > libvir-list mailing list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list > -- Beste Grüße / Kind regards Marc Hartmayer IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: M

Re: [libvirt] [PATCH 0/5] Use-after-free fix and cleanups

On Mon, Apr 10, 2017 at 02:52 PM +0200, Michal Privoznik <mpriv...@redhat.com> wrote: > On 04/03/2017 10:24 AM, Marc Hartmayer wrote: >> While looking at a use-after-free situation going through how the QEMU >> monitor is set up I noticed some things. These cleanups and t

Re: [libvirt] [PATCH v3 2/4] conf: Parse virtio-crypto in the domain XML

if (def->queues) > +virBufferAsprintf(buf, " queues='%u'", def->queues); > + > +virBufferAddLit(buf, "/>\n"); > +break; > + > +case VIR_DOMAIN_CRYPTO_BACKEND_LAST: > +break; > +} > + > +if (vir

Re: [libvirt] [PATCH v3 0/4] Virtio-crypto device support

l2argv-virtio-crypto.args > create mode 100644 > tests/qemuxml2xmloutdata/qemuxml2xmlout-virtio-crypto-builtin.xml > > -- > 1.8.3.1 > > > -- > libvir-list mailing list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list Everything for 'qe

Re: [libvirt] [PATCH 3/3] Use ATTRIBUTE_FALLTHROUGH

On Tue, Jun 13, 2017 at 01:17 AM +0200, John Ferlan <jfer...@redhat.com> wrote: > On 06/07/2017 04:46 AM, Marc Hartmayer wrote: >> Use ATTRIBUTE_FALLTHROUGH, introduced by commit >> 5d84f5961b8e28e802f600bb2d2c6903e219092e, instead of comments to >> indicate that the fal

Re: [libvirt] [PATCH 1/7] node_device: Use the iterator variable

On Thu, May 25, 2017 at 08:37 PM +0200, John Ferlan <jfer...@redhat.com> wrote: > On 05/22/2017 02:38 AM, Bjoern Walk wrote: >> From: Marc Hartmayer <mhart...@linux.vnet.ibm.com> >> >> As the switch statement checks data.type of the iterator variable

[libvirt] [PATCH 1/3] rpc: first allocate the memory and then set the count

Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- src/rpc/virnetclientprogram.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

[libvirt] [PATCH 2/3] qemu: add a comment for mon->watch

Add a comment for mon->watch to make clear what's the purpose of this value. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- src/qemu/qemu_monitor.c | 6 ++ 1 file changed, 6 insertions(+) diff -

[libvirt] [PATCH 0/3] Small patches

Marc Hartmayer (3): rpc: first allocate the memory and then set the count qemu: add a comment for mon->watch Use ATTRIBUTE_FALLTHROUGH src/conf/domain_conf.c| 2 +- src/conf/nwfilter_conf.c | 14 +++--- src/cpu/cpu_ppc64.c | 2 +- src/libvirt-domai

[libvirt] [PATCH 3/3] Use ATTRIBUTE_FALLTHROUGH

Use ATTRIBUTE_FALLTHROUGH, introduced by commit 5d84f5961b8e28e802f600bb2d2c6903e219092e, instead of comments to indicate that the fall through is an intentional behavior. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vne

[libvirt] Question about the host-model CPU mode

of the domain). Is this behavior expected? There are some ways to avoid this problem: - CPU model expansion is performed at domain definition time - host-model is related to the machine type of a domain Thank you in advance. Beste Grüße / Kind regards Marc Hartmayer IBM Deutschland Research

Re: [libvirt] [RFC PATCH 1/4] util: Add virCommandGetGID and virCommandGetUID

On Mon, Oct 09, 2017 at 10:04 PM +0200, Cedric Bosdonnat <cbosdon...@suse.com> wrote: > On Mon, 2017-10-09 at 21:14 +0200, Marc Hartmayer wrote: >> These functions are used by an upcoming commit. >> >> Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com>

[libvirt] [RFC PATCH 4/4] lxc: Fixed indentation

Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> --- src/lxc/lxc_container.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/lxc

[libvirt] [RFC PATCH 0/4] Deadlock fix and some minor fixes

The first patch is a preparatory patch for the deadlock fix (patch 2). The cleanup path for 'virExecCommon' may now be superflous. Patches 3-4 are only minor fixes. Important: there may still be a deadlock for LXC (see the TODO in patch 2) Marc Hartmayer (4): util: Add virCommandGetGID

[libvirt] [RFC PATCH 1/4] util: Add virCommandGetGID and virCommandGetUID

These functions are used by an upcoming commit. Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> --- src/libvirt_private.syms | 2 ++ src/util/vircommand.c| 14 ++ src/util/vircommand.h| 4 +

[libvirt] [RFC PATCH 3/4] lxc: Fixed a typo

Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> --- src/lxc/lxc_container.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/lxc

Re: [libvirt] [PATCH 2/4] conf: Introduce virCPUDefFindFeature

libvirt_private.syms > @@ -75,6 +75,7 @@ virCPUDefCopy; > virCPUDefCopyModel; > virCPUDefCopyModelFilter; > virCPUDefCopyWithoutModel; > +virCPUDefFindFeature; > virCPUDefFormat; > virCPUDefFormatBuf; > virCPUDefFormatBufFull; > -- > 2.14.2 > > -- > lib

  1   2   3   4   5   >