Igor Mammedov writes:
> '-numa mem' option has a number of issues and mgmt often defaults
> to it. Unfortunately it's no possible to replace it with an alternative
> '-numa memdev' without breaking migration compatibility.
To be precise: -numa node,mem=... and -numa node,memdev=... Correct?
>
Igor Mammedov writes:
> Add in the command output object's property values right after creation
> (i.e. state of the object returned by object_new() or equivalent).
>
> Follow up patch will add machine property 'numa-mem-supported', which
> would allow mgmt to introspect which machine types
Igor Mammedov writes:
> QEMU will crash when device-memory-region-size property is read if
> ms->device_memory
> wasn't initialized yet (ex: property being inspected during preconfig time).
Reproduced:
$ qemu-system-x86_64 -nodefaults -S -display none -preconfig -qmp stdio
{"QMP":
Igor Mammedov writes:
> Changes since v3:
> - simplify series by dropping idea of showing property values in
> "qom-list-properties"
> and use MachineInfo in QAPI schema instead
Where did "[PATCH v3 1/6] pc: fix possible NULL pointer dereference in
Igor Mammedov writes:
> Legacy '-numa node,mem' option has a number of issues and mgmt often
> defaults to it. Unfortunately it's no possible to replace it with
> an alternative '-numa memdev' without breaking migration compatibility.
> What's possible though is to deprecate it, keeping option
We've discussed possible solutions. Is anyone working or intending to
work on patches?
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Eduardo Habkost writes:
> On Fri, Jun 07, 2019 at 07:39:17PM +0200, Markus Armbruster wrote:
>> This is correct when the TYPE_VIRT_MACHINE, TYPE_PC_MACHINE and
>> TYPE_SPAPR_MACHINE are exactly the machines supporting NUMA. How could
>> I check that?
>
> parse_nu
at are using
> it.
>
> Signed-off-by: Igor Mammedov
Reviewed-by: Markus Armbruster
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Igor Mammedov writes:
> Fallback might affect guest or worse whole host performance
> or functionality if backing file were used to share guest RAM
> with another process.
>
> Patch deprecates fallback so that we could remove it in future
> and ensure that QEMU will provide expected behavior and
Igor Mammedov writes:
> On Mon, 24 Jun 2019 10:17:33 +0200
> Markus Armbruster wrote:
>
>> Igor Mammedov writes:
>>
>> > Fallback might affect guest or worse whole host performance
>> > or functionality if backing file were used to share guest RAM
>
Daniel P. Berrangé writes:
> On Mon, May 13, 2019 at 01:29:34PM +0100, Dr. David Alan Gilbert wrote:
>> * Daniel P. Berrangé (berra...@redhat.com) wrote:
>> > On Wed, May 08, 2019 at 02:44:07PM +0200, Markus Armbruster wrote:
>> > > Daniel P. Berrangé writes:
&
Daniel P. Berrangé writes:
> On Wed, May 08, 2019 at 02:44:07PM +0200, Markus Armbruster wrote:
[...]
>> Double-checking: do you propose to encode *all* numbers as strings, or
>> just certain "problematic" numbers?
>>
>> If the latter, I guess your idea o
Eric Blake writes:
> On 5/13/19 8:53 AM, Markus Armbruster wrote:
>
>>> We have a few options
>>>
>>> 1. Use string format for values > 2^53-1, int format below that
>>> 2. Use string format for all fields which are 64-bit ints whether
>>
Andrea Bolognani writes:
> On Mon, 2019-05-13 at 13:19 +0100, Daniel P. Berrangé wrote:
>> On Mon, May 13, 2019 at 02:00:28PM +0200, Andrea Bolognani wrote:
>> > One possible complication is that we would not be able to use any
>> > of the GLib types in our public API... I think the way we
Eric Blake writes:
> On 5/13/19 8:28 AM, Michal Privoznik wrote:
>> On 5/13/19 12:17 PM, Daniel P. Berrangé wrote:
>>> This is a long mail about ENOMEM (OOM) handling in libvirt. The executive
>>> summary is that it is not worth the maint cost because:
>>>
>
>>> The long answer follows...
>>
>>
Daniel P. Berrangé writes:
> On Tue, Apr 30, 2019 at 03:45:46PM +0100, Dr. David Alan Gilbert wrote:
>> * Daniel P. Berrangé (berra...@redhat.com) wrote:
>> > The QEMU QMP service is based on JSON which is nice because that is a
>> > widely supported "standard" data format.
>> >
>> >
Eric Blake writes:
> On 5/7/19 4:39 AM, Daniel P. Berrangé wrote:
>
>>> JSON is terrible at interoperability, so good luck with that.
>>>
>>> If you reduce your order to "the commonly used JSON libraries we know",
>>> we can talk.
>>
>> I don't particularly want us to rely on semantics of small
Daniel P. Berrangé writes:
> On Tue, May 07, 2019 at 10:47:06AM +0200, Markus Armbruster wrote:
>
>> > The Golang JSON parser decodes JSON numbers to float64 by default so
>> > will have this precision limitation too, though at least they provide
>> > a
expected behavior and fail if
> it can't use user provided backing file.
>
> Signed-off-by: Igor Mammedov
> ---
> v2:
> * improve text language
> (Markus Armbruster )
>
> numa.c | 6 --
> qemu-deprecated.texi | 9 +
> 2 files chang
Kevin Wolf writes:
> Am 15.08.2019 um 21:24 hat Markus Armbruster geschrieben:
[...]
>> Let's assume all libvirt ever does with deprecation notices is logging
>> them. Would that solve the problem of reliably alerting libvirt
>> developers to deprecation issues? Nop
John Snow writes:
> On 8/14/19 6:07 AM, Vladimir Sementsov-Ogievskiy wrote:
>> To get rid of implicit filters related workarounds in future let's
>> deprecate them now.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy
>> ---
[...]
>> diff --git a/blockdev.c b/blockdev.c
>> index
Peter Krempa writes:
> On Thu, Aug 15, 2019 at 12:49:28 +0200, Kevin Wolf wrote:
>> Am 14.08.2019 um 21:27 hat John Snow geschrieben:
>
> [...]
>
>> > example:
>> >
>> > { "return": {},
>> > "deprecated": True,
>> > "warning": "Omitting filter-node-name parameter is deprecated, it will
>> >
Kevin Wolf writes:
> Am 15.08.2019 um 18:07 hat John Snow geschrieben:
>>
>>
>> On 8/15/19 6:49 AM, Kevin Wolf wrote:
>> > Am 14.08.2019 um 21:27 hat John Snow geschrieben:
>> >>
>> >>
>> >> On 8/14/19 6:07 AM, Vladimir Sementsov-Ogievskiy wrote:
>> >>> To get rid of implicit filters related
John Snow writes:
> From: Vladimir Sementsov-Ogievskiy
>
> Let's add a possibility to query dirty-bitmaps not only on root nodes.
> It is useful when dealing both with snapshots and incremental backups.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> [Added deprecation information. --js]
>
John Snow writes:
> On 7/24/19 12:47 AM, Markus Armbruster wrote:
>> John Snow writes:
>>
>>> From: Vladimir Sementsov-Ogievskiy
>>>
>>> Let's add a possibility to query dirty-bitmaps not only on root nodes.
>>> It is useful when
Vladimir Sementsov-Ogievskiy writes:
> 07.11.2019 21:52, Philippe Mathieu-Daudé wrote:
[...]
>> Pre-release period, time to deprecate some stuffs :)
>>
>> How should we proceed? Do you have something in mind?
>>
>> There are older threads about this. Should we start a new thread? Gather the
Paolo Bonzini writes:
> On 31/10/19 11:58, John Snow wrote:
>> It's an old compatibility shim that just delegates to ide-cd or ide-hd.
>> I'd like to refactor these some day, and getting rid of the super-object
>> will make that easier.
>>
>> Either way, we don't need this.
>
> Good idea. I
Rewriting the parapgraph for clarity would be
better, though.
>> reboot anyways? If it doesn't reboot then -1 should mean to not put
>>
> I think they use the same defaults and will not reboot by default. That can
> be checked by
> the code before and after qemu commit ee5d0
Eduardo Habkost writes:
> +Markus
>
> On Tue, Dec 03, 2019 at 03:43:03PM +0100, Igor Mammedov wrote:
>> On Tue, 3 Dec 2019 09:56:15 +0100
>> Thomas Huth wrote:
>>
>> > On 02/12/2019 22.00, Eduardo Habkost wrote:
>> > > On Mon, Dec 02, 2019 at 08:39:48AM +0100, Igor Mammedov wrote:
>> > >> On
Thomas Huth writes:
> Now that the "name" parameter is gone, there is hardly any difference
> between NetLegacy and Netdev anymore. Drop NetLegacy and always use
> Netdev to simplify the code quite a bit.
>
> Signed-off-by: Thomas Huth
Took me a minute to see the actual difference.
Here's
quot;not at all".
> { 'struct': 'NetLegacy',
>'data': {
> '*id': 'str',
> -'*name': 'str',
> 'opts': 'NetLegacyOptions' } }
>
> ##
[...]
History:
$ git-log -S"dropped in" -- qapi qapi-schema.json
commit ffaee83bcb28913b8b854aeab78b1a1
Thomas Huth writes:
> These have been on the deprecation list since a year now, so it's
> time to finally remove the pc-0.x machine types.
>
> We then can also remove some compatibility hacks in the devices, i.e.
> the "use_broken_id" in ac97 and "command_serr_enable" in PCI devices.
>
> Note
ds") to satisfy another immediate need (commit
d76744e65e "qapi: Allow introspecting fix for savevm's cooperation
with blockdev").
Add them to the remaining definitions: enumeration types, union types,
alternate types, and events.
Signed-off-by: Markus Armbruster
---
docs/devel/qap
Signed-off-by: Markus Armbruster
---
qapi/qmp-dispatch.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
index a69d5b5a96..d1643fe37a 100644
--- a/qapi/qmp-dispatch.c
+++ b/qapi/qmp-dispatch.c
@@ -151,31 +151,31
the command is removed, the error will change to
<--- {"error": {"class": "CommandNotFound", "desc": "The command query-cpus
has not been found"}}
The policy thus permits "testing the future".
Signed-off-by: Markus Armbruster
---
qapi/
Signed-off-by: Markus Armbruster
---
tests/test-qmp-event.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/test-qmp-event.c b/tests/test-qmp-event.c
index d64066139c..7dd0053190 100644
--- a/tests/test-qmp-event.c
+++ b/tests/test-qmp-event.c
@@ -26,6 +26,7
Locally defined helper qdict_cmp_simple() implements just enough of a
comparison to serve here. Replace it by qobject_is_equal(), which
implements all of it.
Signed-off-by: Markus Armbruster
---
tests/test-qmp-event.c | 66 +-
1 file changed, 1 insertion
getting the request ID into qmp_dispatch_check_obj().
Signed-off-by: Markus Armbruster
---
qapi/qmp-dispatch.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
index d1643fe37a..0cbb663097 100644
--- a/qapi/qmp-dispatch.c
Both functions check @request is a QDict, and both have code for
QCO_NO_SUCCESS_RESP. This wasn't the case back when they were
created. It's a sign of muddled responsibilities. Inline. The next
commits will clean up some more.
Signed-off-by: Markus Armbruster
---
qapi/qmp-dispatch.c | 90
rns, and the command line. Extending it to experimental
interfaces may make sense.
FIXME Documentation and help need some work
Signed-off-by: Markus Armbruster
---
qapi/common.json | 48
include/qapi/compat-policy.h | 20 +++
qapi/qmp-disp
This policy suppresses deprecated events, and thus permits "testing
the future".
No QMP event is deprecated right now.
Signed-off-by: Markus Armbruster
---
qapi/common.json | 4 ++--
tests/test-qmp-event.c | 17 +
qemu-options.hx| 4 +++-
scripts/qapi
Unlike regular feature flags, the new special feature flag
"deprecated" is recognized by the QAPI generator. For now, it's only
permitted with commands and events. It will be put to use shortly.
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.txt
This policy calls abort() when a deprecated command is received.
Crashing should reliably[*] fail existing integration tests with very
little additional work (just pass the option).
[*] Bugs in tests can conceivably mask even crashes, but that seems
unlikely.
Signed-off-by: Markus Armbruster
-ID: <87mur0ls8o@dusky.pond.sub.org>
https://lists.nongnu.org/archive/html/qemu-devel/2018-10/msg05828.html
Markus Armbruster (19):
tests/test-qmp-cmds: Factor out qmp_dispatch() test helpers
tests/test-qmp-cmds: Check responses more thoroughly
tests/test-qmp-cmds: Simplify tes
Signed-off-by: Markus Armbruster
---
qapi/qmp-dispatch.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
index 0cbb663097..55bc224c61 100644
--- a/qapi/qmp-dispatch.c
+++ b/qapi/qmp-dispatch.c
@@ -164,7 +164,11 @@ QDict
Building requests with qdict_put() & friends is tedious to write and
hard to read. Parse them from string literals with
qdict_from_vjsonf_nofail() instead.
Signed-off-by: Markus Armbruster
---
tests/test-qmp-cmds.c | 93 ++-
1 file changed, 38 insert
Building expected data with qdict_put() & friends is tedious to write
and hard to read. Parse them from string literals with
qdict_from_jsonf_nofail() instead.
While there, use initializers instead of assignments for initializing
aggregate event arguments.
Signed-off-by: Markus Armbru
cated-input=... to set
policy for these commands. So far, the only available policy is
"accept", which doesn't change behavior. The next few commits will
provide more interesting policies.
Command deprecation becomes visible in introspection. Management
applications
Signed-off-by: Markus Armbruster
---
scripts/qapi/commands.py | 6 +++---
scripts/qapi/doc.py| 10 +-
scripts/qapi/introspect.py | 10 +-
scripts/qapi/schema.py | 36 --
scripts/qapi/types.py | 4
Signed-off-by: Markus Armbruster
---
tests/test-qmp-cmds.c | 23 +--
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/tests/test-qmp-cmds.c b/tests/test-qmp-cmds.c
index e738bead86..667e03cb1b 100644
--- a/tests/test-qmp-cmds.c
+++ b/tests/test-qmp-cmds.c
Checking the value of qmp_dispatch() is repetitive. Factor out
helpers do_qmp_dispatch() and do_qmp_dispatch_error(). Without this,
the next commit would make things even more repetitive.
Signed-off-by: Markus Armbruster
---
tests/test-qmp-cmds.c | 72
ame warning should be included in a deprecated event.
* Emitting the same warning over and over again might be annoying or
slow. Perhaps warning just once would be better.
Signed-off-by: Markus Armbruster
---
qapi/qmp-dispatch.c | 8
tests/test-qmp-cmds.c | 43
Daniel P. Berrangé writes:
> On Thu, Oct 24, 2019 at 02:34:58PM +0200, Markus Armbruster wrote:
>> This policy suppresses deprecated events, and thus permits "testing
>> the future".
>
> One thing that occurs to me is that this is a fairly passive impa
Daniel P. Berrangé writes:
> On Thu, Oct 24, 2019 at 02:34:57PM +0200, Markus Armbruster wrote:
>> Looks like this
>>
>> ---> {"execute": "query-cpus"}
>> <--- {"return": [...], "warnings": [{"class
Reviving this old thread, because I'd like to connect it to more recent
discussions.
Christophe de Dinechin writes:
> Markus Armbruster writes:
>
>> Peter Krempa writes:
>>
> [...]
>>> From my experience users report non-fatal messages mostly only if it is
&g
John Snow writes:
> It's an old compatibility shim that just delegates to ide-cd or ide-hd.
> I'd like to refactor these some day, and getting rid of the super-object
> will make that easier.
Device "scsi-disk" is similar. However, it's still used by the
scsi_bus_legacy_add_drive() magic. Not
John Snow writes:
> On 10/7/19 5:49 AM, Markus Armbruster wrote:
>> John Snow writes:
>>
>>> It's an old compatibility shim that just delegates to ide-cd or ide-hd.
>>> I'd like to refactor these some day, and getting rid of the super-object
>>> will
Signed-off-by: John Snow
Reviewed-by: Markus Armbruster
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Markus Armbruster writes:
> Based-on: <20200227144531.24309-1-arm...@redhat.com>
>
> This series extends QMP introspection to cover deprecation.
> Additionally, new option -compat lets you configure what to do when
> deprecated interfaces get used. This is inten
Commit 6a8c0b5102 "qapi: Add feature flags to struct types" neglected
to update section "Client JSON Protocol introspection", and commit
23394b4c39 "qapi: Add feature flags to commands" didn't either. Make
up for that.
Signed-off-by: Markus Armbruster
---
doc
Signed-off-by: Markus Armbruster
---
tests/test-qmp-event.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/test-qmp-event.c b/tests/test-qmp-event.c
index d64066139c..7dd0053190 100644
--- a/tests/test-qmp-event.c
+++ b/tests/test-qmp-event.c
@@ -26,6 +26,7
Signed-off-by: Markus Armbruster
---
qapi/qmp-dispatch.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
index a588072523..550d1fe8d2 100644
--- a/qapi/qmp-dispatch.c
+++ b/qapi/qmp-dispatch.c
@@ -106,7
Building expected data with qdict_put() & friends is tedious to write
and hard to read. Parse them from string literals with
qdict_from_jsonf_nofail() instead.
While there, use initializers instead of assignments for initializing
aggregate event arguments.
Signed-off-by: Markus Armbru
Policy "crash" calls abort() when deprecated input is received.
Bugs in integration tests may mask the error from policy "reject".
Provide a larger hammer: crash outright. Masking that seems unlikely.
Signed-off-by: Markus Armbruster
---
qapi/compat.json
QAPISchema._make_features() takes a definition expression, and
extracts its 'features' member. The other ._make_FOO() leave
destructuring expressions to their callers. Change ._make_features()
to match them.
Signed-off-by: Markus Armbruster
---
scripts/qapi/schema.py | 17 +
1
eprecating stuff
Date: Fri, 26 Oct 2018 16:03:51 +0200
Message-ID: <87mur0ls8o@dusky.pond.sub.org>
https://lists.nongnu.org/archive/html/qemu-devel/2018-10/msg05828.html
Markus Armbruster (30):
qemu-doc: Belatedly document QMP command arg & result deprecation
qapi: Be
Mention SchemaInfo variant member "allow-oob" defaults to false.
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt
index 59d6973e1e..
Unlike regular feature flags, the new special feature flag
"deprecated" is recognized by the QAPI generator. For now, it's only
permitted with commands, events, and struct members. It will be put
to use shortly.
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-co
Locally defined helper qdict_cmp_simple() implements just enough of a
comparison to serve here. Replace it by qobject_is_equal(), which
implements all of it.
Signed-off-by: Markus Armbruster
---
tests/test-qmp-event.c | 66 +-
1 file changed, 1 insertion
Signed-off-by: Markus Armbruster
---
qapi/qmp-dispatch.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
index 112d29a9ab..fb53687ce9 100644
--- a/qapi/qmp-dispatch.c
+++ b/qapi/qmp-dispatch.c
@@ -164,7 +164,11 @@ QDict
, we missed a few more:
* Commit 3c605f4074 "commit: Add top-node/base-node options" (v3.1.0)
deprecated block-commit arguments @base and @top.
* Commit 4db6ceb0b5 "block/dirty-bitmap: add recording and busy
properties" (v4.0.0) deprecated query-named-block-nodes result
@dirt
QAPISchemaEntity calls doc.connect_feature() in .check(). Improper
since commit ee1e6a1f6c8 split .connect_doc() off .check(). Move the
call. Requires making the children call super().connect_doc() as they
should.
Signed-off-by: Markus Armbruster
---
scripts/qapi/schema.py | 13
quot;: 0, "thread-id":
0, "socket-id": 0}, "qom-path": "/machine/unattached/device[0]", "cpu-index":
0, "target": "x86_64"}]}
Note the absence of deprecated member "arch".
No QMP event is deprecated right now.
Signed-
Commit a9b305ba29 "socket: allow wait=false for client socket"
deprecated use of @wait for client socket chardevs, but neglected to
update char.json's doc comment. Make up for that.
Signed-off-by: Markus Armbruster
---
qapi/char.json | 1 +
1 file changed, 1 insertion(+)
diff --
commit", "arguments": {"device": "virtio0", "top":
"/tmp/snap1.qcow2"}}
<--- {"error": {"class": "GenericError", "desc": "Deprecated parameter
'top' disabled by policy"}}
Whe
Move QAPISchemaAlternateType up some, so that all QAPISchemaFOOType
are together. Move QAPISchemaObjectTypeVariants right behind its
users.
Signed-off-by: Markus Armbruster
---
scripts/qapi/schema.py | 284 -
1 file changed, 142 insertions(+), 142
QAPISchemaObjectTypeVariants represents both object type and alternate
type variants. Rename to QAPISchemaVariants.
Rename QAPISchemaObjectTypeVariant the same way.
Signed-off-by: Markus Armbruster
---
scripts/qapi/schema.py | 22 +++---
1 file changed, 11 insertions(+), 11
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.txt| 4 +++-
tests/qapi-schema/doc-good.texi | 2 ++
qapi/introspect.json| 6 +-
scripts/qapi/expr.py| 3 ++-
scripts/qapi/introspect.py | 2 +-
scripts
Signed-off-by: Markus Armbruster
---
tests/test-qmp-cmds.c | 23 +--
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/tests/test-qmp-cmds.c b/tests/test-qmp-cmds.c
index b31064b064..464b370189 100644
--- a/tests/test-qmp-cmds.c
+++ b/tests/test-qmp-cmds.c
getting the request ID into qmp_dispatch_check_obj().
Signed-off-by: Markus Armbruster
---
qapi/qmp-dispatch.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
index 550d1fe8d2..112d29a9ab 100644
--- a/qapi/qmp-dispatch.c
sult @dirty-bitmaps, query-named-block-nodes result
@encryption_key_missing and result @dirty-bitmaps's member @status.
Same for query-block result @inserted, which mirrors
query-named-block-nodes.
Signed-off-by: Markus Armbruster
---
qapi/block-core.json | 69 +
The value of @qmp_schema_qlit is generated from an expression tree.
Tree nodes are created in several places. Factor out the common code
into _make_tree(). This isn't much of a win now. It will pay off
when we add feature flags in the next few commits.
Signed-off-by: Markus Armbruster
s "accept". Policies other than "accept" are implemented
later in this series.
For now, -compat covers only syntactic aspects of QMP, i.e. stuff
tagged with feature 'deprecated'. We may want to extend it to cover
semantic aspects, CLI, and experimental features.
The option is experiment
The .connect_doc() of classes that have QAPISchemaMember connect them
to their documentation. Change them to delegate the actual work to
new QAPISchemaMember.connect_doc(). Matches the .connect_doc() that
already exist.
Signed-off-by: Markus Armbruster
---
scripts/qapi/schema.py | 23
Checking the value of qmp_dispatch() is repetitive. Factor out
helpers do_qmp_dispatch() and do_qmp_dispatch_error(). Without this,
the next commit would make things even more repetitive.
Signed-off-by: Markus Armbruster
---
tests/test-qmp-cmds.c | 72
ags to commands") to satisfy another immediate need (commit
d76744e65e "qapi: Allow introspecting fix for savevm's cooperation
with blockdev").
Add them to the remaining definitions: enumeration types, union types,
alternate types, and events.
Signed-off-by: Markus Armbruster
---
put, and "qlit" only for output: rename to_qlit() to
_tree_to_qlit(), ._qlits to ._trees, ._gen_qlit() to ._gen_tree().
Signed-off-by: Markus Armbruster
---
scripts/qapi/introspect.py | 35 ++-
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/script
Both functions check @request is a QDict, and both have code for
QCO_NO_SUCCESS_RESP. This wasn't the case back when they were
created. It's a sign of muddled responsibilities. Inline. The next
commits will clean up some more.
Signed-off-by: Markus Armbruster
---
qapi/qmp-dispatch.c | 90
Signed-off-by: Markus Armbruster
---
scripts/qapi/commands.py | 6 +++---
scripts/qapi/doc.py| 10 +-
scripts/qapi/introspect.py | 10 +-
scripts/qapi/schema.py | 36 --
scripts/qapi/types.py | 4
Building requests with qdict_put() & friends is tedious to write and
hard to read. Parse them from string literals with
qdict_from_vjsonf_nofail() instead.
Signed-off-by: Markus Armbruster
---
tests/test-qmp-cmds.c | 93 ++-
1 file changed, 38 insert
Peter Maydell writes:
> On Tue, 3 Mar 2020 at 16:37, Markus Armbruster wrote:
>>
>> Based-on: <20200227144531.24309-1-arm...@redhat.com>
>>
>> This series extends QMP introspection to cover deprecation.
>> Additionally, new option -compat lets you
Peter Maydell writes:
> On Wed, 4 Mar 2020 at 08:18, Markus Armbruster wrote:
>> Peter Maydell writes:
>> > How much do you think this is likely to affect the
>> > generate-rst-from-qapi-docs series? I'd really like
>> > that to go in for this release, but
-1153,6 +1155,7 @@
>'base': { 'type' : 'DisplayType',
> '*full-screen' : 'bool',
> '*window-close' : 'bool',
> +'*show-cursor' : 'bool',
> '*gl': 'DisplayGLMode' },
>'discriminator' : 'type',
>'data': { 'gtk': 'DisplayGTK',
Acked-by: Markus Armbruster
bool',
> '*window-close' : 'bool',
> +'*show-cursor' : 'bool',
> '*gl': 'DisplayGLMode' },
>'discriminator' : 'type',
> 'data': { 'gtk': 'DisplayGTK',
With the doc comment tidied up:
Reviewed-by: Markus Armbruster
zhenwei pi writes:
> Add bit 1 for pvpanic. This bit means that guest hits a panic, but
> guest wants to handle error by itself. Typical case: Linux guest runs
> kdump in panic. It will help us to separate the abnormal reboot from
> normal operation.
>
> Signed-off-by: zhenwei pi
> ---
>
zhenwei pi writes:
> Handle bit 1 write, then post event to monitor.
>
> Suggested by Paolo, declear a new event, using GUEST_PANICKED could
> cause upper layers to react by shutting down or rebooting the guest.
>
> In advance for extention, add GuestPanicInformation in event message.
>
>
Paolo Bonzini writes:
> On 21/01/20 09:22, Markus Armbruster wrote:
>> zhenwei pi writes:
>>
>>> Add bit 1 for pvpanic. This bit means that guest hits a panic, but
>>> guest wants to handle error by itself. Typical case: Linux guest runs
>>> k
org/archive/html/qemu-devel/2018-10/msg05828.html
Cc: Lukáš Doktor
Cc: libgues...@redhat.com
Cc: libvir-list@redhat.com
Cc: Daniel P. Berrange
Cc: Peter Krempa
Markus Armbruster (34):
qemu-doc: Belatedly document QMP command arg & result deprecation
qapi: Belatedly update doc comment f
Peter Krempa writes:
> On Tue, Mar 17, 2020 at 12:54:25 +0100, Markus Armbruster wrote:
>> This series extends QMP introspection to cover deprecation.
>> Additionally, new option -compat lets you configure what to do when
>> deprecated interfaces get used. This is inten
Gerd Hoffmann writes:
> Hi,
>
>> Initialization order looks tricky though. I'd have to create pcspk
>> early, simliar to flash, in pc_machine_initfn(). Problem is I don't
>> have a isa bus yet at that point (flash is sysbus and doesn't have this
>> problem). I'm open to suggestions hiow do
201 - 300 of 518 matches
Mail list logo
