Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/conf/domain_conf.c | 39 +++
src/conf/domain_conf.h | 4
src/libvirt_private.syms | 1 +
3 files changed, 44 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
This element specifies similar settings as the memory element,
although memnode can be used per guest NUMA node.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
docs/formatdomain.html.in | 15 +++
docs/schemas/domaincommon.rng | 17
src/conf/domain_conf.c| 220
.
That is incompatible with automatic numa placement (numad) since that
makes no sense. Also this disables any live changes to numa
parameters (the /domain/numatune/memory settings) since we cannot
change the settings given to qemu.
Martin Kletzander (6):
conf, schema: add 'id' field for cells
conf, schema
for the 'memory-ram' object, so
let's use that.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_cgroup.c | 18 ++-
src/qemu/qemu_command.c| 141 +++--
src/qemu/qemu_command.h
The numa patch series in qemu adds memory-ram object type by which
we can tell whether we can use such objects.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/src
On Wed, Jun 04, 2014 at 04:07:06PM +0100, Daniel P. Berrange wrote:
On Wed, Jun 04, 2014 at 04:56:28PM +0200, Martin Kletzander wrote:
@@ -43,9 +43,17 @@ typedef virNumaTuneDef *virNumaTuneDefPtr;
struct _virNumaTuneDef {
struct {
virBitmapPtr nodemask;
-int mode
On Wed, Jun 04, 2014 at 10:14:24AM -0600, Eric Blake wrote:
On 06/04/2014 07:01 AM, Martin Kletzander wrote:
Based on discussion with Eric:
https://www.redhat.com/archives/libvir-list/2014-March/msg01001.html
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
v2:
- rebase on current
On Tue, Jun 03, 2014 at 09:46:31AM -0600, Eric Blake wrote:
On 06/03/2014 09:40 AM, Martin Kletzander wrote:
New gettext-0.19 doesn't like it and we can't build without it.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
I'm *not* pushing it as a build-breaker as it's
v3 -- use the whole VC_LIST_EXCEPT, create exception for necessities
and clear the rest
v2 -- s/FILENAME:1:/FILENAME :1:/
Martin Kletzander (2):
Remove unnecessary empty first lines
maint: prohibit empty first lines
cfg.mk| 10
Based on discussion with Eric:
https://www.redhat.com/archives/libvir-list/2014-March/msg01001.html
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
I've kept the first output (list of files) to stdout to sope with the
rest of grep checks, but I have no problem changing
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
docs/generic.css | 1 -
docs/libvirt.css | 2 --
src/locking/lockd.conf| 1 -
src/locking/sanlock.conf | 1 -
tests
On Fri, Jun 06, 2014 at 11:40:24AM +0200, Ján Tomko wrote:
This option only makes sense with -fstack-protector.
With -fstack-protector-all, even functions with buffers
smaller than this are protected.
https://bugzilla.redhat.com/show_bug.cgi?id=1105456
---
m4/virt-compile-warnings.m4 | 8
On Fri, Jun 06, 2014 at 06:44:07AM -0600, Eric Blake wrote:
On 06/06/2014 03:20 AM, Martin Kletzander wrote:
v3 -- use the whole VC_LIST_EXCEPT, create exception for necessities
and clear the rest
v2 -- s/FILENAME:1:/FILENAME :1:/
Martin Kletzander (2):
Remove unnecessary empty first
On Mon, Jun 09, 2014 at 09:39:44AM +0200, Peter Krempa wrote:
4d06af97d38c3648937eb8f732704379b3cd9e59 introduced a possible memory
leak of the memory allocated into the cpu pointer in
parallelsBuildCapabilities in the case nodeGetInfo() would fail right
after the allocation. Rearrange the code
On Tue, Jun 10, 2014 at 08:52:19AM -0600, Eric Blake wrote:
From: Chen Fan chen.fan.f...@cn.fujitsu.com
the 'migration_host' description may be a bit difficult to
understand for some users, so enhance the manual
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
Signed-off-by: Eric Blake
On Tue, Jun 10, 2014 at 01:21:49PM -0600, Eric Blake wrote:
On 06/10/2014 12:18 PM, Roman Bogorodskiy wrote:
+sc_prohibit_empty_first_line:
+ @awk 'BEGIN { fail=0; } \
+ FNR == 1 { if ($$0 == ) { print FILENAME :1:; fail=1; } } \
+
On Tue, Jun 10, 2014 at 01:39:03PM -0600, Eric Blake wrote:
Roman Bogorodskiy reported a syntax-check failure when using
FreeBSD; complaining that:
prohibit_empty_first_line
tools/libvirt_win_icon_16x16.ico:1:
tools/libvirt_win_icon_32x32.ico:1:
tools/libvirt_win_icon_48x48.ico:1:
On Wed, Jun 11, 2014 at 09:48:34AM -0400, Shivaprasad G Bhat wrote:
When saving domain with relabel=no, the file that gets created must have the
context set anyway. That way restore can be successful without the need of
relabeling the file.
Signed-off-by: Shivaprasad G Bhat
On Fri, Jun 06, 2014 at 12:54:17PM +0200, Michal Privoznik wrote:
These functions will handle PCIe devices and their link capabilities
to query some info about it.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/libvirt_private.syms | 3 ++
src/util/virpci.c| 81
On Fri, Jun 06, 2014 at 12:54:18PM +0200, Michal Privoznik wrote:
This new element is there to represent PCI-Express capabilities
of a PCI devices, like link speed, number of lanes, etc.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
docs/formatnode.html.in|
On Thu, Jun 12, 2014 at 11:27:31AM +0200, Michal Privoznik wrote:
With one of my recent patches (1c70277) libvirt's capable of
reporting NUMA node locality for PCI devices. The node ID is
stored in pci_dev.numa_node variable. However, since zero is
valid NUMA node ID, the default is -1 as it is
On Thu, Jun 12, 2014 at 12:08:08PM +0200, Michal Privoznik wrote:
On 12.06.2014 10:56, Martin Kletzander wrote:
On Fri, Jun 06, 2014 at 12:54:17PM +0200, Michal Privoznik wrote:
These functions will handle PCIe devices and their link capabilities
to query some info about it.
Signed-off
On Thu, Jun 12, 2014 at 02:30:50PM +0100, Daniel P. Berrange wrote:
On Tue, Jun 10, 2014 at 07:21:12PM +0200, Michal Privoznik wrote:
There are two places where you'll find info on huge pages. The first
one is under cpu/ element, where all supported huge page sizes are
listed. Then the second
On Fri, Jun 13, 2014 at 08:46:59AM +0200, Michal Privoznik wrote:
The kernel's more broken than one would think. Various drivers report
various (usually spurious) values if the interface is down. While on
some we experience -EINVAL when read()-ing the speed sysfs file, with
other drivers we
On Fri, Jun 13, 2014 at 10:31:53AM +0300, Laine Stump wrote:
On 06/13/2014 10:10 AM, Martin Kletzander wrote:
On Fri, Jun 13, 2014 at 08:46:59AM +0200, Michal Privoznik wrote:
The kernel's more broken than one would think. Various drivers report
various (usually spurious) values
On Fri, Jun 13, 2014 at 04:30:41PM +0200, Michal Privoznik wrote:
On 13.06.2014 10:28, Daniel P. Berrange wrote:
On Thu, Jun 12, 2014 at 07:21:47PM +0200, Martin Kletzander wrote:
On Thu, Jun 12, 2014 at 02:30:50PM +0100, Daniel P. Berrange wrote:
On Tue, Jun 10, 2014 at 07:21:12PM +0200
On Thu, Jun 12, 2014 at 05:27:34PM +0200, Michal Privoznik wrote:
These functions will handle PCIe devices and their link capabilities
to query some info about it.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/libvirt_private.syms | 3 ++
src/util/virpci.c| 96
On Thu, Jun 12, 2014 at 05:27:35PM +0200, Michal Privoznik wrote:
This new element is there to represent PCI-Express capabilities
of a PCI devices, like link speed, number of lanes, etc.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
[...]
diff --git a/docs/schemas/nodedev.rng
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
To be honest, I have no idea why this fails for me in one situation,
but it prevents the following error during compilation:
/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.0/../../../../x86_64-pc-linux-gnu/bin/ld:
../src
On Wed, Jun 25, 2014 at 09:57:32AM +0800, Chen Hanxiao wrote:
Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com
---
src/lxc/lxc_cgroup.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/lxc/lxc_cgroup.c b/src/lxc/lxc_cgroup.c
index 8dfdc60..39e30ad 100644
---
On Thu, Jun 26, 2014 at 01:50:22AM +, chen.fan.f...@cn.fujitsu.com wrote:
On Wed, 2014-06-04 at 16:56 +0200, Martin Kletzander wrote:
Currently we are only able to bind the whole domain to some host nodes
using the /domain/numatune/memory element. Numerous requests were
made to support
On Mon, Jun 23, 2014 at 04:08:42PM +0200, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
To be honest, I have no idea why this fails for me in one situation,
but it prevents the following error during compilation:
/usr/lib/gcc/x86_64-pc-linux
On Thu, Jun 26, 2014 at 11:05:55AM +0800, Daniel Veillard wrote:
As stated yesterday, we just entered freeze for libvirt-1.2.6,
I have pushed a first release candidate tarball and signed rpms
at the usual place:
ftp://libvirt.org/libvirt/
I gave it a try and with my limited testing it looks
On Wed, Jun 18, 2014 at 05:59:47PM -0400, Tucker DiNapoli wrote:
This is my initial definition of a new internal job control api. I am
working on this as a part of the google summer of code. These patches
contain the core job control api and deal only with managing individual
jobs. I am
the clearing of
VIR_QEMU_PROCESS_STOP_NO_RELABEL from stop_flags right after the
handshare after hook.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1113327
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_process.c | 69
On Thu, Jun 26, 2014 at 12:42:52PM +0100, Daniel P. Berrange wrote:
On Thu, Jun 26, 2014 at 01:20:02PM +0200, Martin Kletzander wrote:
If locking the domain failed, files were already labelled and thus we
restored the previous label on them. Having disks on NFS means the
domain having the lock
regressions exist since late 2009 and nobody found that (until
now), so I'm only fixing the first one.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1112066
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_command.c | 2 +-
tests
On Thu, Jun 26, 2014 at 04:48:23PM +0200, Ján Tomko wrote:
On 06/26/2014 04:36 PM, Martin Kletzander wrote:
Since commit d86c876a66e320b55220d00113027c9ad6199cff we are using
guestfwd=tcp:IP:PORT,chardev=ID for guestfwd specification, however,
that has not changed in qemu, so guestfwd does
On Fri, Jun 27, 2014 at 10:53:10PM +0200, Michele Paolino wrote:
This patch enables the possibility to run a qemu virtual machine with the
share option for the memory-backend-file. The xml description looks like:
memdev type='file' share='on'
nameram0/name
source mem-path='/hugetlbfs'/
On Sat, Jun 28, 2014 at 08:52:32AM +0300, David kiarie wrote:
Hi there,
Just a silly question, do we have a simpler way of checking where
exactly a test is failing.The tests are failing after hacking stuff
around.
I have this error
../build-aux/test-driver: line 95: 20128 Segmentation fault
On Mon, Jun 30, 2014 at 12:05:06PM +0200, Giuseppe Scrivano wrote:
The IDE bus doesn't support readonly disks, so inform the user with an
error message instead of let qemu fail with a more obscure Device
'ide-hd' could not be initialized error message.
Closes:
On Mon, Jun 30, 2014 at 01:54:09PM +0200, Peter Krempa wrote:
Commit 55bbb011b965c7962933604c70f61cef45e8ec04 introduced a regression
where we forgot to save the persistent domain configuration after a
s/after a/after an/
external snapshot. This would make libvirt forget the snapshots and
On Wed, Jun 25, 2014 at 11:12:52AM -0600, Eric Blake wrote:
On 06/25/2014 10:59 AM, Peter Krempa wrote:
On 06/25/14 18:53, Eric Blake wrote:
Thanks to Dan's recent work in libvirt.git, it is much easier to
develop against uninstalled libvirt. Mention how.
* README: More details.
On Mon, Jun 30, 2014 at 02:05:39PM +0100, Daniel P. Berrange wrote:
On Mon, Jun 30, 2014 at 02:53:04PM +0200, Martin Kletzander wrote:
On Wed, Jun 25, 2014 at 11:12:52AM -0600, Eric Blake wrote:
On 06/25/2014 10:59 AM, Peter Krempa wrote:
On 06/25/14 18:53, Eric Blake wrote:
Thanks to Dan's
On Mon, Jun 30, 2014 at 02:28:54PM +0100, Daniel P. Berrange wrote:
On Mon, Jun 30, 2014 at 03:23:40PM +0200, Giuseppe Scrivano wrote:
Martin Kletzander mklet...@redhat.com writes:
Q On Mon, Jun 30, 2014 at 12:05:06PM +0200, Giuseppe Scrivano wrote:
The IDE bus doesn't support readonly disks
On Tue, Jul 01, 2014 at 09:40:00AM +0200, Giuseppe Scrivano wrote:
Martin Kletzander mklet...@redhat.com writes:
If the user updates from QEMU without DRIVE_READONLY to newer one,
that supports that flag, than XML with readonly IDE HDD will stop
working even though it worked before the update
On Mon, Jun 30, 2014 at 03:26:07PM -0600, Eric Blake wrote:
On 06/30/2014 01:46 PM, Scott Sullivan wrote:
I've tested the v1.2.6-rc2 git tag, im getting this build error:
CC util/libvirt_util_la-virnuma.lo
util/virnuma.c: In function 'virNumaNodeIsAvailable':
util/virnuma.c:428: error:
On Tue, Jul 01, 2014 at 03:28:49PM +0200, Michal Privoznik wrote:
In the test, the snapshot XML is written into a file that's located
under:
abs_srcdir/vboxsnapshotxmldata/testResult.vbox
However, the abs_srcdir doesn't have to be necessarily writable. It
should have been abs_builddir
-by: Martin Kletzander mklet...@redhat.com
---
This is a v2 of:
https://www.redhat.com/archives/libvir-list/2014-June/msg01322.html
If this gets ACKed for th 1.2.6 release, please push this as well
since I won't be available before DV makes the release, thank you.
---
src/Makefile.am | 3 ++-
1 file
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
Pushed as trivial.
src/util/viralloc.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/util/viralloc.h b/src/util/viralloc.h
index 55372e5..7125e67 100644
--- a/src/util/viralloc.h
+++ b/src/util
On Fri, Jul 04, 2014 at 10:52:19AM +0200, Michal Privoznik wrote:
The rationale is to not duplicate code which is done in
packet-libvirt.h for instance. Moreover, this way we can drop
__attribute_((unused)) used int packet-libvirt.c in favor of
ATTRIBUTE_UNUSED.
Signed-off-by: Michal Privoznik
On Fri, Jul 04, 2014 at 10:52:18AM +0200, Michal Privoznik wrote:
With the new wireshark installed I've noticed couple of build breaks. This
fixes the problems I've seen.
Michal Privoznik (2):
wireshark: Include more of libvirt internals
wireshark: Honor API change coming with 1.12 release
On Fri, Jul 04, 2014 at 04:12:47PM +0200, Michele Paolino wrote:
The link to the page how to get your code into an open source
project has been fixed.
Signed-off-by: Michele Paolino m.paol...@virtualopensystems.com
---
docs/hacking.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On Fri, Jul 04, 2014 at 04:12:46PM +0200, Michele Paolino wrote:
replaced link in haking.html.in and fixed XML tags in
formatdomain.html.in
Michele Paolino (2):
docs: Fix broken link in the HACKING page
docs: formatdomain.html fixes
docs/formatdomain.html.in | 8
docs/hacking.html.in
On Mon, Jul 07, 2014 at 08:33:37AM +0200, Ján Tomko wrote:
Commits e18a80a and 57e5c3c switched from a getenv wrapper which
does not allocate a string to virFileFindResource which does not,
without freeing it.
https://bugzilla.redhat.com/show_bug.cgi?id=1116427
---
On Mon, Jul 07, 2014 at 02:26:57PM +0800, Chen Hanxiao wrote:
We invoked virCgroupHasController twice for checking
VIR_CGROUP_CONTROLLER_DEVICES
in lxcDomainAttachDeviceDiskLive.
Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com
---
src/lxc/lxc_driver.c | 6 --
1 file changed, 6
On Mon, Jul 07, 2014 at 10:05:22AM +0200, Peter Krempa wrote:
For the regular dump operation we migrate the VM to a file. This won't
work when the VM has passthrough devices assigned. Rather than reporting
a cryptic error from qemu run our check whether it can be migrated.
This does not
On Mon, Jul 07, 2014 at 01:44:06PM +0200, Pavel Hrdina wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1076098
We support vram option for video devices in domain xml, but so far
only for QXL it had some effect. VGA video device in QEMU can also
accept the size of video ram and we should pass
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_command.c| 26 ++--
.../qemuxml2argv-cpu-numa-disjoint.args| 6 +
.../qemuxml2argv-cpu-numa-disjoint.xml | 28 ++
tests
to ease the review of commits to follow.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_command.c | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index fb64cda..aed7411
That can be lately achieved with by having .param == NULL in the
virQEMUCapsCommandLineProps struct.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_capabilities.c | 10 --
src/qemu/qemu_monitor.c | 6 --
src/qemu/qemu_monitor.h | 3 ++-
src/qemu
The numa patch series in qemu adds memory-backend-ram object type by
which we can tell whether we can use such objects.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_capabilities.c | 3 +++
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 4 insertions(+)
diff --git
for the 'memory-backend-ram' object,
so let's use that.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_command.c| 59 +-
.../qemuxml2argv-numatune-memnode-no-memory.args | 8 +++
.../qemuxml2argv-numatune-memnode.args
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
docs/formatdomain.html.in | 15 ++
docs/schemas/domaincommon.rng | 17 ++
src/conf/numatune_conf.c | 183 +++--
.../qemuxml2argv-numatune-memnode
with it. And the
last patch, number 16, fixes a bug with KVM and cgroups.
One last note, APIs for handling the memnode settings will be added
later. I'm sending this to prepare the ground for Michal's work with
hugepages.
Martin Kletzander (16):
qemu: purely a code movement
qemu: remove useless error check
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/conf/numatune_conf.c | 111 ---
src/conf/numatune_conf.h | 14 --
src/libvirt_private.syms | 1 +
src/lxc/lxc_cgroup.c | 3 +-
src/qemu/qemu_cgroup.c | 2 +-
src/qemu
not restrict kernel allocations.
This patch leaves the userspace numa_set_membind() in place and moves
the cpuset.mems setting after the point where monitor comes up, but
before vcpu and emulator sub-groups are created.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
Another
/virDomainNumatune/g
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/conf/domain_conf.c | 20 ++--
src/conf/domain_conf.h | 2 +-
src/conf/numatune_conf.c | 4 ++--
src/conf/numatune_conf.h | 20 ++--
src/libvirt_private.syms | 4 ++--
src/lxc
patch.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_1.6.50-1.caps| 1 +
tests/qemucapabilitiesdata/caps_1.6.50-1.replies | 5 +
4
is dealt with, all
the internals are now accessible directly only in numatune_conf.c and
outside this file accessors must be used.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
po/POTFILES.in | 1 +
src/conf/domain_conf.c
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_cgroup.c | 29 -
1 file changed, 24 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index ff268fb..eebe9e9 100644
--- a/src/qemu/qemu_cgroup.c
+++ b/src
to ease the review of commits to follow.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/conf/domain_conf.c | 52 +-
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index
There are many places with numatune-related code that should be put
into special numatune_conf and this patch creates a basis for that.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/Makefile.am | 3 ++-
src/conf/domain_conf.h | 2 +-
src/conf/numatune_conf.c
Excerpt from the virCommandAddArgBuffer() description: Correctly
transfers memory errors or contents from buf to cmd.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_command.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu
' attribute they are parsed and formatted according to
that field. This will be useful when we have tuning settings for
particular guest NUMA node.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
docs/formatdomain.html.in | 11 +++---
docs/schemas/domaincommon.rng
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
Pushed as trivial
src/conf/domain_conf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 70f1103..b80e7cf 100644
--- a/src/conf/domain_conf.c
+++ b
On Tue, Jul 08, 2014 at 05:40:40PM +0200, Peter Krempa wrote:
Commit 48f44510098cead629ede9a49ea4e840a28ccca introduced a helper
You probably meant a48f44510098cead629ede9a49ea4e840a28ccca.
Martin
signature.asc
Description: Digital signature
--
libvir-list mailing list
or disabled in qemu.conf), we error out with weird
message even though we could continue starting the domain.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1097028
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_cgroup.c | 12 ++--
1 file changed, 10
://bugzilla.redhat.com/show_bug.cgi?id=1085706
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
tools/virsh-domain.c | 3 ++-
tools/virsh.pod | 8 +---
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index b5b9f91..5a17aff 100644
On Wed, Jul 09, 2014 at 01:07:47PM +0200, Ján Tomko wrote:
On 07/09/2014 10:15 AM, Martin Kletzander wrote:
When creating cgroups for vcpu and emulator threads whilst starting a
domain, we explicitly skip creating those cgroups in case priv-cgroup
is NULL (cgroups not supported) because
On Fri, Jul 11, 2014 at 05:11:05PM +0200, Michal Privoznik wrote:
On 08.07.2014 13:50, Martin Kletzander wrote:
In XML format, by definition, order of fields should not matter, so
order of parsing the elements doesn't affect the end result. When
specifying guest NUMA cells, we depend only
On Fri, Jul 11, 2014 at 05:11:00PM +0200, Michal Privoznik wrote:
On 08.07.2014 13:50, Martin Kletzander wrote:
There were numerous places where numatune configuration (and thus
domain config as well) was changed in different ways. On some
places this even resulted in persistent domain
On Tue, Jul 15, 2014 at 04:32:03PM +0800, Jincheng Miao wrote:
In virObjectLockableNew, when virMutexInit fails,
virReportSystemError should use errno to get the right
error number, instead of VIR_ERR_INTERNAL_ERROR.
Signed-off-by: Jincheng Miao jm...@redhat.com
---
src/util/virobject.c | 2 +-
On Tue, Jul 15, 2014 at 04:32:01PM +0800, Jincheng Miao wrote:
In lxcContainerStart, when user namespace is not supported,
the virReportSystemError is called. But the first argument
should be ENOTSUPP, instead of VIR_ERR_CONFIG_UNSUPPORTED.
Signed-off-by: Jincheng Miao jm...@redhat.com
---
On Fri, Jul 11, 2014 at 05:10:53PM +0200, Michal Privoznik wrote:
On 08.07.2014 13:50, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
docs/formatdomain.html.in | 15 ++
docs/schemas/domaincommon.rng | 17
On Fri, Jul 11, 2014 at 05:11:02PM +0200, Michal Privoznik wrote:
On 08.07.2014 13:50, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/conf/numatune_conf.c | 111 ---
src/conf/numatune_conf.h | 14 --
src
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
docs/formatdomain.html.in | 15 ++
docs/schemas/domaincommon.rng | 17 ++
src/conf/numatune_conf.c | 187 +++--
.../qemuxml2argv-numatune-memnode
for the 'memory-backend-ram' object,
so let's use that.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_command.c| 59 +-
.../qemuxml2argv-numatune-memnode-no-memory.args | 8 +++
.../qemuxml2argv-numatune-memnode.args
On Tue, Jul 15, 2014 at 02:38:36PM +0200, Michal Privoznik wrote:
Up to now it's possible to do something like this:
const char *ptr;
ptr = strdup(my example string);
VIR_FREE(ptr);
The problem is, const char * pointers should not be modified (and
freeing them is kind of modification). We
On Tue, Jul 15, 2014 at 02:59:50PM +0200, Ján Tomko wrote:
Split into two patches, as we might want to backport the first one somewhere.
Ján Tomko (2):
Fix error on fs pool build failure
Fix assignment of comparison against zero
src/storage/storage_backend_fs.c | 2 +-
On Tue, Jul 15, 2014 at 10:47:04PM -0400, Jincheng Miao wrote:
- Original Message -
I'm not sure errno is set when using our virMutexInit(). Most of the
code uses virReportError instead, I suggest using that. This should
Actually, the implement of virMutexInit() already set errno
v3 of https://www.redhat.com/archives/libvir-list/2014-July/msg00372.html
v3:
- Michal's suggestions worked in
- rebased on current master
Martin Kletzander (16):
qemu: purely a code movement
qemu: remove useless error check
conf: purely a code movement
conf, schema: add 'id' field
' attribute they are parsed and formatted according to
that field. This will be useful when we have tuning settings for
particular guest NUMA node.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
docs/formatdomain.html.in | 17 +
docs/schemas/domaincommon.rng
to ease the review of commits to follow.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/conf/domain_conf.c | 52 +-
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index
That can be lately achieved with by having .param == NULL in the
virQEMUCapsCommandLineProps struct.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_capabilities.c | 10 --
src/qemu/qemu_monitor.c | 6 --
src/qemu/qemu_monitor.h | 3 ++-
src/qemu
Excerpt from the virCommandAddArgBuffer() description: Correctly
transfers memory errors or contents from buf to cmd.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_command.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu
The numa patch series in qemu adds memory-backend-ram object type by
which we can tell whether we can use such objects.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_capabilities.c | 3 +++
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 4 insertions(+)
diff --git
patch.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_1.6.50-1.caps| 1 +
tests/qemucapabilitiesdata/caps_1.6.50-1.replies | 5 +
4
There are many places with numatune-related code that should be put
into special numatune_conf and this patch creates a basis for that.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/Makefile.am | 3 ++-
src/conf/domain_conf.h | 2 +-
src/conf/numatune_conf.c
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/conf/numatune_conf.c | 111 ---
src/conf/numatune_conf.h | 14 --
src/libvirt_private.syms | 1 +
src/lxc/lxc_cgroup.c | 3 +-
src/qemu/qemu_cgroup.c | 2 +-
src/qemu
1101 - 1200 of 5738 matches
Mail list logo
