On 05/24/2013 11:08 AM, Osier Yang wrote:
---
src/qemu/qemu_cgroup.c | 55
+-
1 file changed, 36 insertions(+), 19 deletions(-)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index bb1b235..cf46993 100644
---
On 06/06/2013 12:13 PM, Daniel P. Berrange wrote:
On Thu, Jun 06, 2013 at 11:19:18AM +0200, Guido Günther wrote:
On Mon, Jun 03, 2013 at 11:47:10PM +0800, Osier Yang wrote:
On 01/06/13 16:05, Martin Kletzander wrote:
commit 416247880399f88ec382a16c7cebc5460d6b67ad
Author: Martin Kletzander
On 05/24/2013 11:08 AM, Osier Yang wrote:
When either cpuset of vcpu is specified, or the placement of
vcpu is auto, only setting the cpuset.mems might cause the guest
starting to fail. E.g. (placement of both vcpu and numatune is
auto):
After spending a lot of time with this, I'm still not
On 05/24/2013 11:08 AM, Osier Yang wrote:
I don't see any reason to getting the numa parameters if mode is
not strict, as long as setNumaParameters doesn't allow to set
nodeset if the mode is not strict, and cpuset.mems only understand
strict mode.
NACK, this makes sense for 'interleave' as
On 05/30/2013 02:24 PM, John Ferlan wrote:
Since commit '632f78ca' the 'virsh schedinfo domain' command returns:
Scheduler : Unknown
error: Requested operation is not valid: cgroup CPU controller is not mounted
Prior to that change a non running domain would return:
Scheduler
On 06/07/2013 12:19 PM, Daniel P. Berrange wrote:
On Thu, May 30, 2013 at 08:24:59AM -0400, John Ferlan wrote:
Since commit '632f78ca' the 'virsh schedinfo domain' command returns:
Scheduler : Unknown
error: Requested operation is not valid: cgroup CPU controller is not mounted
Prior
-off-by: Martin Kletzander mklet...@redhat.com
---
src/util/virstoragefile.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index b985df4..b083530 100644
--- a/src/util/virstoragefile.c
+++ b/src/util/virstoragefile.c
On 06/10/2013 11:25 AM, Peter Krempa wrote:
On 06/10/13 09:58, Martin Kletzander wrote:
Fallback to possible storage format after nothing else than magic has
matched, since this is likely theformat user wants even though we
don't know any better.
Also fix a comment which wasn't very clear
On 06/10/2013 02:10 PM, Ján Tomko wrote:
Split out option string generation to make adding new options easier
and simplify the code.
---
src/storage/storage_backend.c | 111
++
1 file changed, 59 insertions(+), 52 deletions(-)
[...]
@@ -795,65
On 06/12/2013 04:29 PM, chandrashekar shastri wrote:
Hi All,
Upstream : virt-install and virt-manager fails to install the guest with
the error qemu: could not load PC BIOS 'bios.bin'
You are missing bios package for that. This depends on the distro
you're using, but probably
On 06/10/2013 02:10 PM, Ján Tomko wrote:
Just to reduce the indentation levels. Remove the unneeded
NULL check for disk-file, as virBufferEscapeString doesn't
print anything with NULL arguments.
---
src/conf/snapshot_conf.c | 53
++--
1 file
On 06/10/2013 02:10 PM, Ján Tomko wrote:
Add features and compat elements to volume target XML.
compat is a string which for qcow2 represents the QEMU version
it should be compatible with. Valid values are 0.10 and 1.1.
1.1 is implicit if the features element is present, otherwise
qemu-img
On 06/10/2013 02:10 PM, Ján Tomko wrote:
Add -o compat= and -o lazy_refcounts options for qemu-img.
---
src/storage/storage_backend.c | 36
+++--
tests/storagevolxml2argvdata/qcow2-1.1.argv | 1 +
tests/storagevolxml2argvdata/qcow2-lazy.argv|
On 06/14/2013 02:34 PM, Viktor Mihajlovski wrote:
Implicit controllers may be dependent on device definitions altered
in a post-parse callback. E.g., if a console device is
defined without the target type, the type will be set in QEMU's
callback. In the case of s390, this is virtio, which
On 06/19/2013 05:24 PM, Ján Tomko wrote:
Detect qcow2 images with version 3 in the image header as
VIR_STORAGE_FILE_QCOW2.
These images have a feature bitfield, with just one feature supported
so far: lazy_refcounts.
The header length changed too, moving the location of the backing
On 06/19/2013 05:24 PM, Ján Tomko wrote:
Add -o compat= and -o lazy_refcounts options for qemu-img.
---
src/storage/storage_backend.c | 62
++---
tests/storagevolxml2argvdata/qcow2-1.1.argv | 1 +
tests/storagevolxml2argvdata/qcow2-lazy.argv|
On 06/19/2013 05:24 PM, Ján Tomko wrote:
Add features and compat elements to volume target XML.
compat is a string which for qcow2 represents the QEMU version
it should be compatible with. Valid values are 0.10 and 1.1.
1.1 is implicit if the features element is present, otherwise
qemu-img
On 06/19/2013 05:24 PM, Ján Tomko wrote:
Add features and compat elements to snapshot disk XML.
compat is a string which for qcow2 represents the QEMU version
it should be compatible with. Valid values are 0.10 and 1.1.
1.1 is implicit if the features element is present, otherwise
qemu-img
On 06/06/2013 02:29 PM, Michal Privoznik wrote:
For now, only these three helpers are needed:
virDomainChrFind - to find a duplicate chardev within VM def
virDomainChrInsert - wrapper for inserting a new chardev into VM def
virDomainChrRemove - wrapper for removing chardev from VM def
There
On 06/06/2013 02:29 PM, Michal Privoznik wrote:
There are two levels on which a device may be hotplugged: config
and live. The config level requires just an insert or remove from
internal domain definition structure, which is what this patch
exactly does. There is currently no implementation
On 05/24/2013 10:25 PM, Martin Kletzander wrote:
There were some places in the code, where files were being opened with
uid:gid of the daemon instead of the qemu process related to the file.
First patch exposes the parseIds() function in order for it to be used
somewhere else in the code
On 06/06/2013 02:30 PM, Michal Privoznik wrote:
The function being introduced is responsible for creating command
line argument for '-device' for given character device. Based on
the chardev type, it calls appropriate qemuBuild.*ChrDeviceStr(),
e.g. qemuBuildSerialChrDeviceStr() for serial
On 06/24/2013 02:28 PM, Ján Tomko wrote:
We can only pass values up to LLONG_MAX through JSON
and QEMU checks if the int64_t number is not negative
at startup since 1.5.0.
https://bugzilla.redhat.com/show_bug.cgi?id=974010
---
src/qemu/qemu_driver.c | 7 +++
1 file changed, 7
On 06/06/2013 02:30 PM, Michal Privoznik wrote:
Since previous patches has prepared everything for us, we may now
s/has/have/
implement live hotplug of a character device.
---
src/qemu/qemu_driver.c | 10 +
src/qemu/qemu_hotplug.c | 102
On 06/25/2013 05:44 PM, Michal Novotny wrote:
Implement check whether (maximum) vCPUs doesn't exceed machine
type's cpu-max settings.
Differences between v3 and v4 (this one):
- Rebased to latest libvirt version
- Capability XML output extended by maxCpus field
- Extended
On 06/26/2013 04:20 PM, Michal Novotny wrote:
On 06/26/2013 04:17 PM, Martin Kletzander wrote:
On 06/25/2013 05:44 PM, Michal Novotny wrote:
Implement check whether (maximum) vCPUs doesn't exceed machine
type's cpu-max settings.
Differences between v3 and v4 (this one):
- Rebased
On 06/26/2013 05:46 PM, Michal Novotny wrote:
Implement check whether (maximum) vCPUs doesn't exceed machine
type's cpu-max settings.
Differences between v4 and v5 (this one):
- Changed type to unsigned int
- Renamed variable to maxCpus to match previous naming
- When machines types are
On 06/03/2013 06:22 PM, Osier Yang wrote:
On 03/06/13 23:05, Martin Kletzander wrote:
When using logical pools, we had to trust the target-pth provided.
s/pth/path/,
This parameter, however, can be completely ommited and we can get the
correct path using 'lvdisplay' command.
Resolves
the pool anyway.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=952973
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
v2:
- don't drop target.path, but fix it instead to '/dev/source.name'
Thanks to the change from v1, we can now safely drop all the hunks
On 06/26/2013 05:46 PM, Michal Novotny wrote:
Implement check whether (maximum) vCPUs doesn't exceed machine
type's cpu-max settings.
Differences between v4 and v5 (this one):
- Changed type to unsigned int
- Renamed variable to maxCpus to match previous naming
- When machines types are
and for no more than one graphics, there is no
reason to hardcode one graphics into this part of the code as well.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_migration.c | 29 ++---
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git a/src
Commit 23e8b5d8e7a92bac85b7fd2aca8992501bf680ee forgot to check the
return value for all calls to qemuDomainChangeGraphicsPasswords().
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_process.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src
We added support for dula graphics, but there were places in the
code which still needed to be adapted. Two tiny patches seem to fix
it all. Tested, works fine.
Martin Kletzander (2):
qemu: Don't miss errors when changing graphics passwords
qemu: Allow seamless migration for domains
On 07/03/2013 02:11 PM, Jiri Denemark wrote:
On Wed, Jul 03, 2013 at 12:10:23 +0100, Daniel Berrange wrote:
On Tue, Jul 02, 2013 at 03:46:01PM +0200, Martin Kletzander wrote:
Since commit 23e8b5d8, the code is refactored in a way that supports
domains with multiple graphics elements and commit
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
[...]
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index 13fd162..f7f05fd 100644
--- a/src/util/vircgroup.c
+++ b/src/util/vircgroup.c
@@ -1212,8 +1211,6 @@ static int virCgroupSetPartitionSuffix(const char
*path, char **res)
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
---
src/test/test_driver.c | 91
--
1 file changed, 28 insertions(+), 63 deletions(-)
ACK,
Martin
--
libvir-list mailing list
libvir-list@redhat.com
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
[...]
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index ba93233..7288ce7 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -10289,7 +10186,7 @@ virDomainDefPtr qemuParseCommandLine(virCapsPtr
qemuCaps,
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
---
src/parallels/parallels_driver.c | 65
+++
src/parallels/parallels_network.c | 24 ---
src/parallels/parallels_storage.c | 50 +-
src/parallels/parallels_utils.c
On 07/04/2013 02:06 PM, Michal Privoznik wrote:
---
src/phyp/phyp_driver.c | 95
+-
1 file changed, 24 insertions(+), 71 deletions(-)
ACK,
Martin
--
libvir-list mailing list
libvir-list@redhat.com
On 07/03/2013 02:43 PM, Peter Krempa wrote:
---
src/security/security_selinux.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
ACK,
Martin
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 07/03/2013 02:43 PM, Peter Krempa wrote:
The imagelabel SELinux label was only generated when relabeling was
enabled. This prohibited labeling of files created by libvirt that need
to be labeled even if relabeling is turned off.
The only codepath this change has direct impact on is
/archives/libvir-list/2013-June/msg00419.html
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=836676
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/util/virstoragefile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virstoragefile.c b/src/util
On 07/09/2013 03:44 PM, Ján Tomko wrote:
On 07/09/2013 03:20 PM, Martin Kletzander wrote:
Initially proposed as [1], but then changed to comment fix only. VMDK
can have internal version set to 2 when there are few features added
which do not affect us. Thanks to Jan's commit a1ee8e18
On 07/10/2013 12:51 PM, Ján Tomko wrote:
Remove assignment of the string freed by virURIFree
to hostname, since it's not used anywhere.
Double free introduced by ddf8ad8, useless code
introduced by f03dcc5.
https://bugzilla.redhat.com/show_bug.cgi?id=977961
---
On 07/10/2013 12:59 PM, Ján Tomko wrote:
CVE-2013-2230
Don't overwrite the callback ID returned by
virDomainEventStateRegisterID in ret by 0.
Introduced by abf75aea.
---
src/qemu/qemu_driver.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git
We never check for disks with duplicate targets connected to the same
controller/bus/etc. That means we go ahead, create the same IDs for
them and pass them to qemu, which subsequently fails to start.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=968899
Signed-off-by: Martin Kletzander
On 07/10/2013 02:39 PM, Daniel P. Berrange wrote:
On Wed, Jul 10, 2013 at 02:34:30PM +0200, Martin Kletzander wrote:
We never check for disks with duplicate targets connected to the same
controller/bus/etc. That means we go ahead, create the same IDs for
them and pass them to qemu, which
On 07/10/2013 04:03 PM, Daniel P. Berrange wrote:
On Wed, Jul 10, 2013 at 03:51:45PM +0200, Martin Kletzander wrote:
On 07/10/2013 02:39 PM, Daniel P. Berrange wrote:
On Wed, Jul 10, 2013 at 02:34:30PM +0200, Martin Kletzander wrote:
We never check for disks with duplicate targets connected
On 07/11/2013 11:47 AM, Daniel P. Berrange wrote:
[...]
Huh, that doesn't make any sense. The 'alias' data is not user specified.
If they attempt to set it in the XML, it'll be dropped by the parser. The
alias names are assigned by the QEMU driver unconditionally and unless
that code is broken
for scsi controller
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=974943
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_command.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 0e517f2..aff1768 100644
On 06/24/2013 12:19 PM, Martin Kletzander wrote:
On 05/24/2013 10:25 PM, Martin Kletzander wrote:
There were some places in the code, where files were being opened with
uid:gid of the daemon instead of the qemu process related to the file.
First patch exposes the parseIds() function in order
the pool anyway.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=952973
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
v3:
- just rebase
v2:
- don't drop target.path, but fix it instead to '/dev/source.name'
Thanks to the change from v1, we can now
On 07/01/2013 07:46 PM, Laine Stump wrote:
I recently patches the callers to virPCIDeviceReset() to not call it
if the current driver for a device was vfio-pci (since that driver
will always reset the device itself when appropriate. At the time, Dan
Berrange suggested that I could instead
On 07/01/2013 07:46 PM, Laine Stump wrote:
virPCIDeviceGetDriverPathAndName is a static function that will need
to be called by another function that occurs above it in the
file. This patch reorders the static functions so that a forward
declaration isn't needed.
---
src/util/virpci.c | 177
On 07/15/2013 02:27 PM, Daniel P. Berrange wrote:
On Mon, Jul 15, 2013 at 10:30:16AM +0200, Martin Kletzander wrote:
When using logical pools, we had to trust the target-path provided.
This parameter, however, can be completely ommited and we can get the
correct path using 'lvdisplay' command
On 07/15/2013 02:24 PM, Daniel P. Berrange wrote:
On Mon, Jul 15, 2013 at 09:50:45AM +0200, Martin Kletzander wrote:
When user does not specify any model for scsi controller, or worse, no
controller at all, but libvirt automatically adds scsi controller with
no model, we are not searching
On 07/02/2013 11:35 AM, Guannan Ren wrote:
Add startupPolicy attribute policy for harddisk with type file,
block and dir. The network type disk is still not supported.
---
docs/schemas/domaincommon.rng | 6 ++
src/conf/domain_conf.c| 20 +---
2 files changed, 19
s/doesn't/don't/ in $SUBJ
On 07/02/2013 11:35 AM, Guannan Ren wrote:
If one of backing files for disk source doesn't exist, the guest will not
be able to find and use the disk even though the disk still exists in
guest xml definition. So reporting an error make more sense.
Adding
When using logical pools, we had to trust the target-path provided.
This parameter, however, can be completely ommited and we can use
'/dev/source.name' safely and populate it to target.path.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=952973
Signed-off-by: Martin Kletzander mklet
On 07/15/2013 05:01 PM, Guannan Ren wrote:
On 07/15/2013 09:31 PM, Martin Kletzander wrote:
On 07/02/2013 11:35 AM, Guannan Ren wrote:
Add startupPolicy attribute policy for harddisk with type file,
block and dir. The network type disk is still not supported.
---
docs/schemas
On 07/15/2013 05:31 PM, Ján Tomko wrote:
On 07/02/2013 11:35 AM, Guannan Ren wrote:
If one of backing files for disk source doesn't exist, the guest will not
be able to find and use the disk even though the disk still exists in
guest xml definition. So reporting an error make more sense.
On 07/16/2013 10:40 AM, Daniel P. Berrange wrote:
On Tue, Jul 16, 2013 at 08:14:54AM +0200, Martin Kletzander wrote:
On 07/15/2013 05:31 PM, Ján Tomko wrote:
On 07/02/2013 11:35 AM, Guannan Ren wrote:
If one of backing files for disk source doesn't exist, the guest will not
be able to find
On 07/16/2013 11:48 AM, Daniel P. Berrange wrote:
On Mon, Jul 15, 2013 at 04:29:54PM +0200, Martin Kletzander wrote:
When using logical pools, we had to trust the target-path provided.
This parameter, however, can be completely ommited and we can use
'/dev/source.name' safely and populate
On 07/16/2013 11:08 AM, Daniel P. Berrange wrote:
[...]
Which BZ are you referring to ? I read BZ 977706 to be about not causing
errors during pool-refresh if a 2nd node has deleted the volume while
the first node is in the middle of refresh. This isn't about keeping
deleted volumes visible.
On 07/18/2013 12:49 PM, Peter Krempa wrote:
---
src/qemu/qemu_cgroup.c | 69
+++---
1 file changed, 38 insertions(+), 31 deletions(-)
ACK,
Martin
--
libvir-list mailing list
libvir-list@redhat.com
On 07/18/2013 12:49 PM, Peter Krempa wrote:
From: Osier Yang jy...@redhat.com
When either cpuset of vcpu is specified, or the placement of
vcpu is auto, only setting the cpuset.mems might cause the guest
starting to fail. E.g. (placement of both vcpu and numatune is
auto):
[...]
diff
On 07/18/2013 12:49 PM, Peter Krempa wrote:
These helpers use the remembered host capabilities to retrieve the cpu
map rather than query the host again. The intended usage for this
helpers is to fix automatic NUMA placement with strict memory alloc. The
code doing the prepare needs to pin the
On 07/18/2013 02:57 PM, Peter Krempa wrote:
On 07/18/13 14:39, Martin Kletzander wrote:
[...]
ACK with these two nits fixed.
I noticed that the last hunk of the patch would actually leak the caps
in case of cgroups fail. I will be pushing this with the following patch
squashed in:
diff
cannot block).
Lock logging is disabled while logging because that would either
recurse or deadlock.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
configure.ac| 19 +++
src/Makefile.am | 3 ++-
src/libvirt_private.syms| 1 +
src/util
On 07/22/2013 06:31 PM, Eric Blake wrote:
On 07/22/2013 07:58 AM, Daniel P. Berrange wrote:
I'm really inclined to say that anyone wanting todo lock debugging
should just use systemtap / dtrace todo it, since it is better in
every way.
I tend to agree on that point, with one caveat - we
On Wed 24 Jul 2013 10:56:56 AM CEST, Michal Privoznik wrote:
On 24.05.2013 22:25, Martin Kletzander wrote:
There were some places in the code, where files were being opened with
uid:gid of the daemon instead of the qemu process related to the file.
First patch exposes the parseIds() function
On 07/24/2013 03:02 PM, Roman Bogorodskiy wrote:
link_addr detection in configure always reports that
link_addr is missing because it uses link_addr(NULL, NULL) in
AC_LINK_IFELSE check with limited set of headers that doesn't
s/doesn't/don't/
define NULL.
Fix by replacing 'NULL' with just
On 07/24/2013 02:30 PM, Roman Bogorodskiy wrote:
virCgroupAvailable() implementation calls getmntent_r
without checking if HAVE_GETMNTENT_R is defined, so it fails
to build on platforms without getmntent_r support.
Make virCgroupAvailable() just return false without
HAVE_GETMNTENT_R.
---
On 07/18/2013 01:32 PM, Guannan Ren wrote:
Refactor this function to make it focus on disk presence checking,
including diskchain checking, and not only for CDROM and Floppy.
This change is good for the following patches.
---
src/qemu/qemu_domain.c | 99
On 07/18/2013 01:32 PM, Guannan Ren wrote:
s/doesn't/don't/ in $SUBJ
Adding virFileAccessibleAs() to check if the backing file described in
disk meta exist in real path. If not, report error. The uid and gid
arguments don't take effect on F_OK mode for access, so use gid and gid
of current
On 07/18/2013 01:32 PM, Guannan Ren wrote:
For disk with startupPolicy support, such as cdrom and floppy
when its chain is broken, the startup policy will apply,
otherwise, report error on chain issue.
Force to collect diskchain metadata when qemu process start
everytime.
---
On 07/26/2013 11:19 AM, Alex Jia wrote:
Signed-off-by: Alex Jia a...@redhat.com
---
src/conf/domain_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 10cb7f6..0e74039 100644
--- a/src/conf/domain_conf.c
+++
On 07/26/2013 11:46 AM, Michal Privoznik wrote:
Interestingly, we had codefloorcode ... /codeoutbound/code which
results in much larger block of text to be written in code style that
intended.
---
docs/formatdomain.html.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
On 07/26/2013 11:46 AM, Michal Privoznik wrote:
The outbound/@peak is ignored (since QoS was introduced). This is due to
kernel limitation of know allowing ingress filters to have peak just
average rate. However, we should document this limitation to not confuse
users.
---
On Fri 26 Jul 2013 11:50:17 AM CEST, Michal Privoznik wrote:
On 26.07.2013 11:19, Alex Jia wrote:
Signed-off-by: Alex Jia a...@redhat.com
---
src/conf/domain_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index
On 07/26/2013 02:37 PM, Guannan Ren wrote:
Refactor this function to make it focus on disk presence checking,
including diskchain checking, and not only for CDROM and Floppy.
This change is good for the following patches.
---
src/qemu/qemu_domain.c | 98
On 07/26/2013 02:37 PM, Guannan Ren wrote:
*src/util/virstoragefile.c: Add a helper function to get
the first name of missing backing files, if the name is NULL,
it means the diskchain is not broken.
*src/qemu/qemu_domain.c: qemuDiskChainCheckBroken(disk) to
check if its chain is broken
---
On 07/26/2013 02:37 PM, Guannan Ren wrote:
For disk with startupPolicy support, such as cdrom and floppy
when its chain is broken, the startup policy will apply,
otherwise, report an error on chain issue.
---
src/qemu/qemu_domain.c | 21 -
src/qemu/qemu_process.c | 6
On Mon 29 Jul 2013 02:51:15 PM CEST, Guannan Ren wrote:
*src/util/virstoragefile.c: Add a helper function to get
the first name of missing backing files, if the name is NULL,
it means the diskchain is not broken.
*src/qemu/qemu_domain.c: qemuDiskChainCheckBroken(disk) to
check if its chain is
On 07/30/2013 08:26 AM, Guannan Ren wrote:
For disk with startupPolicy support, such as cdrom and floppy
when its chain is broken, the startup policy will apply,
otherwise, report an error.
---
src/qemu/qemu_domain.c | 31 +--
src/qemu/qemu_process.c | 6 --
On 07/31/2013 09:51 AM, Guannan Ren wrote:
Add startupPolicy attribute policy for harddisk with type file,
s/policy//
block and dir. 'requisite' is not supported currently for
hardisk.
s/hardisk/harddisk/
---
docs/formatdomain.html.in | 8 ++--
docs/schemas/domaincommon.rng |
On 07/31/2013 09:51 AM, Guannan Ren wrote:
Go through disks of guest, if one disk doesn't exist or its backing
chain is broken, with 'optional' startupPolicy, for CDROM and Floppy
we only discard its source path definition in xml, for disks we drop
it from disk list and free it.
---
On 08/02/2013 04:38 PM, Jiri Denemark wrote:
As both /var/lib/libvirt/qemu and /var/lib/libvirt/qemu/channel/target
are owned by us, the intermediate /var/lib/libvirt/qemu/channel should
be owned by us too.
---
libvirt.spec.in | 1 +
1 file changed, 1 insertion(+)
diff --git
On 08/02/2013 08:37 AM, Guannan Ren wrote:
Go through disks of guest, if one disk doesn't exist or its backing
chain is broken, with 'optional' startupPolicy, for CDROM and Floppy
we only discard its source path definition in xml, for disks we drop
it from disk list and free it.
---
On 08/08/2013 10:48 AM, Alex Jia wrote:
Valgrind defects memory error:
==16759== 1 errors in context 1 of 8:
==16759== Invalid free() / delete / delete[] / realloc()
==16759==at 0x4A074C4: free (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==16759==by 0x83CD329:
On 08/08/2013 01:26 PM, Viktor Mihajlovski wrote:
From: Eric Farman far...@linux.vnet.ibm.com
Hotplugging a single SCSI device works, but adding additional ones
result in an error from QEMU:
[root@gpok197 ~]# virsh attach-device guest01 blah.xml
Device attached successfully
[root@gpok197
On 08/09/2013 12:29 AM, Eric Blake wrote:
On 08/08/2013 04:09 PM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Use a seperate keyfile name for the two TLS test suites so that
s/seperate/separate/
they don't clash when running tests in parallel
Signed-off-by:
On 08/13/2013 04:20 AM, Eric Blake wrote:
On 08/09/2013 03:23 AM, Daniel P. Berrange wrote:
Anyway, why I'm saying this is that one more filename should be renamed
in order to avoid a race (which I was unable to reproduce, though).
I have reproduced the race.
ACK, yes this is also
On 08/14/2013 01:08 AM, Laine Stump wrote:
This resolves the issue that prompted the filing of
https://bugzilla.redhat.com/show_bug.cgi?id=928638
(although the request there is for something much larger and more
general than this patch).
commit f3868259ca0517212e439a65c9060868f673b6c9
() into vshInitDebug() and vshInit().
One simple memleak of ctl-name is fixed as a part of this patch,
since it is related to the issue it's fixing.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=999323
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
tools/virsh.c | 28
On 08/21/2013 12:00 PM, Daniel P. Berrange wrote:
On Wed, Aug 21, 2013 at 11:15:39AM +0200, Martin Kletzander wrote:
Commit abfff210 changed the order of vshParseArgv() and vshInit() in
order to make fix debugging of parameter parsing. However, vshInit()
did a vshReconnect() even though ctl
Commit a0b6a36f is fixing what commit abfff210 broke, so to avoid having
to deal with this issue again, I present you The uriprecedencetest.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
tests/Makefile.am | 2 ++
tests/uriprecedencetest | 77
Commit a0b6a36f is fixing what commit abfff210 broke, so to avoid having
to deal with this issue again, herec comes virsh-uriprecedence.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
v2:
- Changed the name to virsh-uriprecedence
- Using $PWD instead of temporary
On 08/22/2013 02:56 PM, Daniel P. Berrange wrote:
On Thu, Aug 22, 2013 at 02:19:56PM +0200, Martin Kletzander wrote:
Commit a0b6a36f is fixing what commit abfff210 broke, so to avoid having
to deal with this issue again, herec comes virsh-uriprecedence.
Signed-off-by: Martin Kletzander mklet
On Thu 22 Aug 2013 03:15:48 PM CEST, Eric Blake wrote:
On 08/22/2013 06:19 AM, Martin Kletzander wrote:
Commit a0b6a36f is fixing what commit abfff210 broke, so to avoid having
to deal with this issue again, herec comes virsh-uriprecedence.
Signed-off-by: Martin Kletzander mklet...@redhat.com
201 - 300 of 5738 matches
Mail list logo
