Re: [libvirt] Information needed regarding libvirt error

2013-08-27 Thread Martin Kletzander
the new libvirt 1.0.6 with qemu-1.6.0 but we are facing some compiling issues because of depedencies between latest qemu code with glib. Please let us know your comments. Thanks in advance. BR Abhinay On Tue, Aug 27, 2013 at 8:06 AM, Martin Kletzander mklet...@redhat.comwrote: [cc'ing

[libvirt] [PATCH] virsh: Fix debugging

2013-08-27 Thread Martin Kletzander
, we need to initialize the debugging twice, once before debugging (so we can debug option parsing properly) and then again after these options are parsed. Signed-off-by: Martin Kletzander mklet...@redhat.com --- tools/virsh.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/virsh.c b

Re: [libvirt] [PATCH] virsh: Fix debugging

2013-08-27 Thread Martin Kletzander
On 08/27/2013 01:19 PM, Martin Kletzander wrote: Commit a0b6a36f fixed what abfff210 broke (URI precedence), but there was still one more thing missing to fix. When using virsh parameters to setup debugging, those weren't honored, because at the time debugging was initializing, arguments

Re: [libvirt] [PATCH] virsh: Fix debugging

2013-08-28 Thread Martin Kletzander
On 08/28/2013 08:22 AM, Ján Tomko wrote: On 08/28/2013 03:39 AM, Eric Blake wrote: On 08/27/2013 06:27 AM, Martin Kletzander wrote: diff --git a/tools/virsh.c b/tools/virsh.c index ac77156..34f5c4a 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -2321,10 +2321,9 @@ vshInitDebug(vshControl

Re: [libvirt] [PATCH] virsh: Fix debugging

2013-08-28 Thread Martin Kletzander
On Wed 28 Aug 2013 11:18:43 AM CEST, Michal Privoznik wrote: On 28.08.2013 08:22, Ján Tomko wrote: On 08/28/2013 03:39 AM, Eric Blake wrote: On 08/27/2013 06:27 AM, Martin Kletzander wrote: diff --git a/tools/virsh.c b/tools/virsh.c index ac77156..34f5c4a 100644 --- a/tools/virsh.c +++ b

Re: [libvirt] Information needed regarding libvirt error

2013-08-28 Thread Martin Kletzander
.libvirt-qemu/vcpu0/ This ^^ should do after the command fails. Anyway, I'd definitely suggest trying this on 1.1.1 or current upstream. We might be chasing a bug that's been removed for some time. Have a nice day, Martin On Tue, Aug 27, 2013 at 10:04 AM, Martin Kletzander mklet

Re: [libvirt] [PATCH] examples: Add script to parse topology from capabilities output

2013-09-03 Thread Martin Kletzander
On 09/02/2013 04:57 PM, Peter Krempa wrote: Add a demo script originally written by Amador Pahim to parse topology of the host from data provided in the capabilities XML. --- examples/python/topology.py | 45 + 1 file changed, 45 insertions(+)

Re: [libvirt] [PATCH] qemu: Handle huge number of queues correctly

2013-09-03 Thread Martin Kletzander
On 09/02/2013 04:25 PM, Michal Privoznik wrote: Currently, kernel supports up to 8 queues for a multiqueue tap device. However, if user tries to enter a huge number (e.g. one million) the tap allocation fails, as expected. But what is not expected is the log full of warnings: warning :

Re: [libvirt] [PATCH 1/3] tools: rename console.[ch] to virsh-console.[ch] and fix coding style

2013-09-03 Thread Martin Kletzander
On 08/29/2013 06:36 PM, Peter Krempa wrote: --- cfg.mk | 2 +- po/POTFILES.in | 2 +- tools/Makefile.am| 2 +- tools/{console.c = virsh-console.c} | 73 ++-- tools/{console.h =

Re: [libvirt] [PATCH 2/3] virsh: Rename vshMakeStdinRaw to vshTTYMakeRaw and move it to virsh.c

2013-09-03 Thread Martin Kletzander
On 08/29/2013 06:36 PM, Peter Krempa wrote: Move the function to virsh.c to the rest of the TTY managing functions and change the code so that it mirrors the rest. --- tools/virsh-console.c | 50 +- tools/virsh-console.h | 7 +++

[libvirt] [PATCH] [RFC] docs: Add OpenStack into references

2013-09-04 Thread Martin Kletzander
diff --git a/docs/apps.html.in b/docs/apps.html.in index 46e5dca..9f22df8 100644 --- a/docs/apps.html.in +++ b/docs/apps.html.in @@ -244,6 +244,15 @@ integrates libvirt for VM monitoring, live migration, and life-cycle management. /dd + + dta

Re: [libvirt] [PATCH] build: shut up automake warnings

2013-09-05 Thread Martin Kletzander
On Wed 04 Sep 2013 06:48:46 PM CEST, Eric Blake wrote: I'm tired of seeing screenfuls of messages like these when using automake 1.13 (Fedora 19): configure.ac:2121: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and its use is discouraged. configure.ac:2121: You should use the

Re: [libvirt] [PATCH] [RFC] docs: Add OpenStack into references

2013-09-05 Thread Martin Kletzander
On 09/04/2013 03:56 PM, Osier Yang wrote: On 04/09/13 20:50, Eric Blake wrote: On 09/04/2013 01:26 AM, Martin Kletzander wrote: diff --git a/docs/apps.html.in b/docs/apps.html.in index 46e5dca..9f22df8 100644 --- a/docs/apps.html.in +++ b/docs/apps.html.in @@ -244,6 +244,15

[libvirt] [v0.9.12-maint 02/11] security: Fix libvirtd crash possibility

2013-09-11 Thread Martin Kletzander
Fix for CVE-2012-4423. When generating RPC protocol messages, it's strictly needed to have a continuous line of numbers or RPC messages. However in case anyone tries backporting some functionality and will skip a number, there is a possibility to make the daemon segfault with newer virsh (version

Re: [libvirt] rpmbuild libvirt 1.1.2 problem

2013-09-12 Thread Martin Kletzander
On 09/11/2013 07:18 PM, Nehal J Wani wrote: On Wed, Sep 11, 2013 at 10:17 AM, jsjshaowen...@21cn.com wrote: hi: i build rpm in centos 6.2, libvirt version 1.1.2,i found an error FAIL: virsh-uriprecedence Details in the attachment,thanks !Wait for a response Reproducible on

[libvirt] [PATCH] Allow root users to have their own configuration file

2013-09-12 Thread Martin Kletzander
is root or not. This patch modifies the mentioned behavior for root only, allowing him to set his own configuration files without changing anything in system-wide configuration folders. This also makes the virsh-uriprecedence test pass its first test case when ran as root. Signed-off-by: Martin

Re: [libvirt] [PATCH] Allow root users to have their own configuration file

2013-09-12 Thread Martin Kletzander
On 09/12/2013 11:53 AM, Martin Kletzander wrote: Currently, we have two configuration file paths, one global (where global means root-only and we're probably not changing this in near future) and one per-user. Unfortunately root user cannot use the second option because until now we were

Re: [libvirt] [PATCH] Allow root users to have their own configuration file

2013-09-12 Thread Martin Kletzander
On 09/12/2013 12:00 PM, Daniel P. Berrange wrote: On Thu, Sep 12, 2013 at 11:53:32AM +0200, Martin Kletzander wrote: Currently, we have two configuration file paths, one global (where global means root-only and we're probably not changing this in near future) and one per-user. Unfortunately

[libvirt] [PATCH 2/2] tests: Don't test user config file if ran as root

2013-09-12 Thread Martin Kletzander
Signed-off-by: Martin Kletzander mklet...@redhat.com --- tests/virsh-uriprecedence | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/virsh-uriprecedence b/tests/virsh-uriprecedence index f4d84a4..aa90efe 100755 --- a/tests/virsh-uriprecedence +++ b/tests/virsh

Re: [libvirt] [PATCH] Allow root users to have their own configuration file

2013-09-12 Thread Martin Kletzander
On Thu 12 Sep 2013 12:12:22 PM CEST, Daniel P. Berrange wrote: On Thu, Sep 12, 2013 at 12:07:54PM +0200, Martin Kletzander wrote: On 09/12/2013 12:00 PM, Daniel P. Berrange wrote: On Thu, Sep 12, 2013 at 11:53:32AM +0200, Martin Kletzander wrote: Currently, we have two configuration file paths

Re: [libvirt] [PATCH 2/2] tests: Don't test user config file if ran as root

2013-09-13 Thread Martin Kletzander
On 09/12/2013 05:02 PM, Eric Blake wrote: On 09/12/2013 06:47 AM, Daniel P. Berrange wrote: ACK if you can answer the question either way. Thanks, should I wait for ACK on 1/2 before pushing or have you seen that in the archives? Odd, I've not see any cover letter or 1/2 patch arrive.

[libvirt] [PATCH 0/2] tests: Fix virsh-uriprecedence when ran as root

2013-09-13 Thread Martin Kletzander
Basically v2 of http://www.redhat.com/archives/libvir-list/2013-September/msg00689.html Martin Kletzander (2): test-lib: Make case skipping possible tests: Don't test user config file if ran as root tests/test-lib.sh | 18 ++ tests/virsh-uriprecedence | 6 +- 2

[libvirt] [PATCH 1/2] test-lib: Make case skipping possible

2013-09-13 Thread Martin Kletzander
Signed-off-by: Martin Kletzander mklet...@redhat.com --- tests/test-lib.sh | 18 ++ 1 file changed, 18 insertions(+) diff --git a/tests/test-lib.sh b/tests/test-lib.sh index 2f79706..e612f8f 100644 --- a/tests/test-lib.sh +++ b/tests/test-lib.sh @@ -41,6 +41,24 @@ test_intro

Re: [libvirt] [PATCH 2/2] tests: Don't test user config file if ran as root

2013-09-13 Thread Martin Kletzander
On 09/12/2013 01:35 PM, Daniel P. Berrange wrote: On Thu, Sep 12, 2013 at 01:28:45PM +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander mklet...@redhat.com --- tests/virsh-uriprecedence | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/virsh

Re: [libvirt] [PATCH 3/3] cleanup: Kill usage of access(PATH, F_OK) in favor of virFileExists()

2013-09-13 Thread Martin Kletzander
On 09/13/2013 04:19 PM, Peter Krempa wrote: Semantics of the libvirt helper are more clear. This change also allows to clean up some pieces of code. --- src/openvz/openvz_conf.c | 2 +- src/parallels/parallels_storage.c | 2 +- src/qemu/qemu_capabilities.c | 4 ++--

Re: [libvirt] rpmbuild libvirt 1.1.2 problem

2013-09-13 Thread Martin Kletzander
, Alex - Original Message - From: Martin Kletzander mklet...@redhat.com To: Nehal J Wani nehaljw.k...@gmail.com Cc: libvir-list libvir-list@redhat.com, jsjshaowen...@21cn.com Sent: Thursday, September 12, 2013 4:29:32 PM Subject: Re: [libvirt] rpmbuild libvirt 1.1.2 problem On 09/11

Re: [libvirt] [PATCH] qemu: Add support for changing timeout value to open unix monitor socket

2014-01-02 Thread Martin Kletzander
On Mon, Dec 30, 2013 at 07:23:00PM +0200, Pavel Fux wrote: Hi, I am talking about *Bug 987088*https://bugzilla.redhat.com/show_bug.cgi?id=987088, I have added a patch and a description of the fix, this is a copy of my comment on the bug: the default code behavior is wait for 3 seconds

Re: [libvirt] [PATCH] event: don't overwrite registration error message

2014-01-02 Thread Martin Kletzander
On Tue, Dec 31, 2013 at 07:22:53AM -0700, Eric Blake wrote: Prior to this patch, an attempt to register an event without an event loop started results in the vague: libvirt: Remote Driver error : adding cb to list Now it gives the much nicer: libvirt: error : internal error: could not

Re: [libvirt] [PATCH] event: don't overwrite registration error message

2014-01-02 Thread Martin Kletzander
On Thu, Jan 02, 2014 at 05:52:59AM -0700, Eric Blake wrote: On 01/02/2014 03:20 AM, Martin Kletzander wrote: On Tue, Dec 31, 2013 at 07:22:53AM -0700, Eric Blake wrote: Prior to this patch, an attempt to register an event without an event loop started results in the vague: libvirt

Re: [libvirt] [PATCH] event: improve public API docs

2014-01-02 Thread Martin Kletzander
On Tue, Dec 31, 2013 at 08:21:29AM -0700, Eric Blake wrote: Since libvirt 0.9.3, the entire virevent.c file has been a public API, so improve the documentation in this file. Also, fix a potential core dump - it could only be triggered by bogus use of the API and would only affect the caller

Re: [libvirt] [PATCH] event: improve public API docs

2014-01-02 Thread Martin Kletzander
On Wed, Jan 01, 2014 at 03:54:14PM -0700, Eric Blake wrote: On 12/31/2013 08:21 AM, Eric Blake wrote: Since libvirt 0.9.3, the entire virevent.c file has been a public API, so improve the documentation in this file. Also, fix a potential core dump - it could only be triggered by bogus use

Re: [libvirt] [PATCHV2] qemu: Add support for changing timeout value to open unix monitor socket

2014-01-07 Thread Martin Kletzander
On Tue, Jan 07, 2014 at 10:28:41AM +, Richard W.M. Jones wrote: On Thu, Jan 02, 2014 at 06:29:35PM +0200, Pavel Fux wrote: Adding an option to change monitor socket opening timeout the current default is 3 seconds and in some cases it's not enough This should change the *default* to

Re: [libvirt] [PATCHV2] qemu: Add support for changing timeout value to open unix monitor socket

2014-01-07 Thread Martin Kletzander
On Tue, Jan 07, 2014 at 10:39:26AM +, Richard W.M. Jones wrote: On Tue, Jan 07, 2014 at 11:37:11AM +0100, Martin Kletzander wrote: On Tue, Jan 07, 2014 at 10:28:41AM +, Richard W.M. Jones wrote: On Thu, Jan 02, 2014 at 06:29:35PM +0200, Pavel Fux wrote: Adding an option to change

[libvirt] [PATCH] conf: trivial typo fix

2014-01-08 Thread Martin Kletzander
Signed-off-by: Martin Kletzander mklet...@redhat.com --- Notes: Pushed as trivial. src/conf/domain_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e65f3e3..416d96e 100644 --- a/src/conf/domain_conf.c +++ b

[libvirt] [PATCH 0/2] Try to get rid of most monitor timeout errors

2014-01-09 Thread Martin Kletzander
This is basically v3 of the patch Pavel Fux sent [1] with the addition of changing the default as discussed in the same thread [2]. Martin [1] https://www.redhat.com/archives/libvir-list/2014-January/msg00060.html [2] https://www.redhat.com/archives/libvir-list/2014-January/msg00367.html Martin

[libvirt] [PATCH 1/2] qemu: Add support for changing timeout value to open unix monitor socket

2014-01-09 Thread Martin Kletzander
From: Pavel Fux pa...@stratoscale.com Adding an option to change monitor socket opening timeout the current default is 3 seconds and in some cases it's not enough Signed-off-by: Pavel Fux pa...@stratoscale.com Signed-off-by: Martin Kletzander mklet...@redhat.com --- Notes: I modified

[libvirt] [PATCH 2/2] qemu: Change the default unix monitor timeout

2014-01-09 Thread Martin Kletzander
the timeout right to 30 seconds. Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/qemu/qemu.conf | 2 +- src/qemu/qemu_monitor.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index 6217b49..4936d88 100644 --- a/src

[libvirt] [PATCH] storage: fix crash when listing volumes or undefining a pool

2014-01-09 Thread Martin Kletzander
dereferenced. Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/storage/storage_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index aaa0f02..85fc0f2 100644 --- a/src/storage/storage_driver.c +++ b/src

Re: [libvirt] [PATCH] storage: fix crash when listing volumes or undefining a pool

2014-01-09 Thread Martin Kletzander
On Thu, Jan 09, 2014 at 08:41:11AM -0700, Eric Blake wrote: On 01/09/2014 08:35 AM, Martin Kletzander wrote: The commit cad3cf9a951d26da9d2ee0f5b52fb1a2dbb74af1 introduced a crash due to wrong order of parameters being passed to the function. When deleting an element, the function

Re: [libvirt] [PATCH 1/2] qemu: Add support for changing timeout value to open unix monitor socket

2014-01-10 Thread Martin Kletzander
On Fri, Jan 10, 2014 at 02:18:37PM +, Daniel P. Berrange wrote: On Thu, Jan 09, 2014 at 09:22:05AM +0100, Martin Kletzander wrote: From: Pavel Fux pa...@stratoscale.com Adding an option to change monitor socket opening timeout the current default is 3 seconds and in some cases it's

Re: [libvirt] [PATCH 2/2] storage: FS: Tweak some comments and fix typo

2014-01-13 Thread Martin Kletzander
On Fri, Jan 10, 2014 at 12:09:49PM +0100, Peter Krempa wrote: --- src/storage/storage_backend_fs.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) I'd reword some of those probably, but this patch is supposed to be merely a formatting cleanup, I guess. So ACK.

Re: [libvirt] [PATCHv2] storage: FS: Tweak some comments and fix typos

2014-01-13 Thread Martin Kletzander
On Mon, Jan 13, 2014 at 11:47:20AM +0100, Peter Krempa wrote: --- Notes: Version 2: - tweak most of the messages I'm not going to push this without a review as I'm not a native speaker. Me neither, but I guess 2 proofreaders might be enough in case of reformatting comments.

Re: [libvirt] [PATCH] lxc: do cleanup when failed to create new string

2014-01-14 Thread Martin Kletzander
On Tue, Jan 14, 2014 at 05:31:03PM +0800, Chen Hanxiao wrote: From: Chen Hanxiao chenhanx...@cn.fujitsu.com Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- src/lxc/lxc_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/lxc_process.c

Re: [libvirt] [PATCH] lxc: do cleanup when failed to create new string

2014-01-14 Thread Martin Kletzander
On Wed, Jan 15, 2014 at 09:47:53AM +0800, Chen Hanxiao wrote: -Original Message- From: Martin Kletzander [mailto:mklet...@redhat.com] Sent: Tuesday, January 14, 2014 9:24 PM To: Chen Hanxiao Cc: libvir-list@redhat.com Subject: Re: [libvirt] [PATCH] lxc: do cleanup when failed

Re: [libvirt] [PATCH 2/2] qemu: Change the default unix monitor timeout

2014-01-16 Thread Martin Kletzander
On Thu, Jan 16, 2014 at 04:11:07PM +, Daniel P. Berrange wrote: On Thu, Jan 09, 2014 at 09:22:06AM +0100, Martin Kletzander wrote: There is a number of reported issues when we fail starting a domain. Turns out that, in some scenarios like high load, 3 second timeout is not enough

Re: [libvirt] [PATCH 1/2] qemu: Add support for changing timeout value to open unix monitor socket

2014-01-16 Thread Martin Kletzander
Ping? Can we at least change the default [2/2] or should I send a v2 for that one? Martin On Fri, Jan 10, 2014 at 04:27:40PM +0100, Martin Kletzander wrote: On Fri, Jan 10, 2014 at 02:18:37PM +, Daniel P. Berrange wrote: On Thu, Jan 09, 2014 at 09:22:05AM +0100, Martin Kletzander wrote

Re: [libvirt] [PATCH 1/2] Make syntax check notice assignments w/o surrounding spaces.

2014-01-20 Thread Martin Kletzander
On Mon, Jan 20, 2014 at 12:27:28PM +0100, Thorsten Behrens wrote: --- build-aux/bracket-spacing.pl | 8 1 file changed, 8 insertions(+) diff --git a/build-aux/bracket-spacing.pl b/build-aux/bracket-spacing.pl index 802a640..fd7438e 100755 --- a/build-aux/bracket-spacing.pl +++

Re: [libvirt] [PATCH 2/2] maint: align whitespace with project conventions.

2014-01-20 Thread Martin Kletzander
On Mon, Jan 20, 2014 at 12:27:29PM +0100, Thorsten Behrens wrote: --- examples/object-events/event-test.c | 20 +-- src/conf/nwfilter_conf.c| 72 ++--- src/esx/esx_vi.c| 2 +- src/libvirt.c | 2

Re: [libvirt] [PATCHv2 2/2] qemu: snapshot: Avoid libvirtd crash when qemu crashes while snapshotting

2014-01-20 Thread Martin Kletzander
On Mon, Jan 20, 2014 at 06:09:33PM +0100, Peter Krempa wrote: We shouldn't access the domain definition while we are in the monitor section as the domain is unlocked. Additionaly after we exit from the monitor we need to check if the VM is still alive. Not doing so resulted into crash if qemu

[libvirt] [PATCH] lxc: Fix coverity

2014-01-21 Thread Martin Kletzander
Commit 399394ab74ebf3f6e60771044fda0ee69a2acf67 removed some coverity comments which skipped the dead code, so add them back. Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/lxc/lxc_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lxc/lxc_driver.c b/src/lxc

Re: [libvirt] [PATCH] lxc: Fix coverity

2014-01-21 Thread Martin Kletzander
On Tue, Jan 21, 2014 at 09:43:07AM +0100, Ján Tomko wrote: On 01/21/2014 09:04 AM, Martin Kletzander wrote: Commit 399394ab74ebf3f6e60771044fda0ee69a2acf67 removed some coverity comments which skipped the dead code, so add them back. Signed-off-by: Martin Kletzander mklet...@redhat.com

Re: [libvirt] [PATCH 1/2] virNetServer: Introduce unauth clients counter

2014-01-22 Thread Martin Kletzander
On Mon, Dec 09, 2013 at 03:35:52PM +0100, Michal Privoznik wrote: The counter gets incremented on each unauthenticated client added to the server and decremented whenever the client authenticates. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- daemon/remote.c| 21

Re: [libvirt] [PATCH 2/2] daemon: Introduce max_anonymous_clients

2014-01-23 Thread Martin Kletzander
On Mon, Dec 09, 2013 at 03:35:53PM +0100, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=981729 This config tunable allows users to determine the maximum number of accepted but yet not authenticated users. Signed-off-by: Michal Privoznik mpriv...@redhat.com ---

Re: [libvirt] [PATCH] storage: Fix the memory leak

2014-01-23 Thread Martin Kletzander
On Thu, Jan 23, 2014 at 06:23:32PM +0800, Osier Yang wrote: The return value of virGetFCHostNameByWWN is a strdup'ed string. Also add comments to declare that the caller should take care of freeing it. --- src/storage/storage_backend_scsi.c | 15 ++- src/util/virutil.c

Re: [libvirt] [question]Is there a good way to get the mac of guest interface after I attached it to a guest

2014-01-23 Thread Martin Kletzander
On Fri, Jan 24, 2014 at 10:37:20AM +0800, Sheldon wrote: Now I working on a new KVM management tool base on html5 and libvirt we will support a REST API for detach and attach guest interface. we want to use mac as the identifier of the network interface. That meas we should get the mac

Re: [libvirt] [question]Is there a good way to get the mac of guest interface after I attached it to a guest

2014-01-24 Thread Martin Kletzander
On Fri, Jan 24, 2014 at 04:34:12PM +0800, Sheldon wrote: On 01/24/2014 03:55 PM, Martin Kletzander wrote: On Fri, Jan 24, 2014 at 10:37:20AM +0800, Sheldon wrote: Now I working on a new KVM management tool base on html5 and libvirt we will support a REST API for detach and attach guest

Re: [libvirt] [PATCH 1/2] qemu: Add support for changing timeout value to open unix monitor socket

2014-01-24 Thread Martin Kletzander
On Fri, Jan 24, 2014 at 12:56:43PM +, Daniel P. Berrange wrote: On Thu, Jan 23, 2014 at 07:47:54PM +0200, Pavel Fux wrote: there are 8 servers with 8 vms on each server. all the qcow images are on the nfs share on the same external server. we are starting all 64 vms at the same time.

Re: [libvirt] [question]Is there a good way to get the mac of guest interface after I attached it to a guest

2014-01-24 Thread Martin Kletzander
On Sat, Jan 25, 2014 at 12:06:10AM +0800, Sheldon wrote: On 01/24/2014 05:30 PM, Martin Kletzander wrote: On Fri, Jan 24, 2014 at 04:34:12PM +0800, Sheldon wrote: On 01/24/2014 03:55 PM, Martin Kletzander wrote: On Fri, Jan 24, 2014 at 10:37:20AM +0800, Sheldon wrote: Now I working

Re: [libvirt] [virt-tools-list] ANNOUNCE: virt-xml: Edit libvirt XML with command line options

2014-01-27 Thread Martin Kletzander
On Sun, Jan 26, 2014 at 01:24:59PM -0500, Cole Robinson wrote: I've just pushed a new tool to virt-manager.git called virt-xml. virt-xml uses virt-install's command line options to allow building and editing domain XML. Best way to describe what it can do is with a bunch of examples: Hi, good

Re: [libvirt] [PATCH 0/2] support compression with dumping guest memory

2014-01-28 Thread Martin Kletzander
On Tue, Jan 28, 2014 at 02:50:51PM +0800, Qiao Nuohan wrote: Hello, Do you have some comments on this? Hi, I can't find this series in ML, neither in archives, can you resend it, please? It'd be enough to send it to the list(s), I think there is no need to Cc all people more-or-less

[libvirt] [PATCH] qemu: minor cleanups

2014-01-31 Thread Martin Kletzander
Some cleanups around serial chardevs and miscellaneous things I've found inconsistent or not very clean. Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/conf/domain_conf.c | 43 ++- src/qemu/qemu_capabilities.c | 4 ++-- src/qemu

[libvirt] [PATCH] spice: don't force user to specify spicevmc channel

2014-01-31 Thread Martin Kletzander
. Signed-off-by: Martin Kletzander mklet...@redhat.com --- I extended the context to see what I meant by the code is already prepared to use the default one. src/qemu/qemu_command.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 2db745a

Re: [libvirt] [PATCH] spice: don't force user to specify spicevmc channel

2014-02-03 Thread Martin Kletzander
On Mon, Feb 03, 2014 at 09:25:57AM +0100, Christophe Fergeau wrote: On Fri, Jan 31, 2014 at 05:08:33PM +0100, Martin Kletzander wrote: We support only one spicevmc channel name anyway and the code is prepared to use the default one, there's only one check missing. I'm not adding

[libvirt] [PATCH] qemu: introduce spiceport serial backend

2014-02-03 Thread Martin Kletzander
Signed-off-by: Martin Kletzander mklet...@redhat.com --- Notes: This applies on top of qemu: minor cleanups: https://www.redhat.com/archives/libvir-list/2014-January/msg01584.html docs/formatdomain.html.in | 22 + docs/schemas/domaincommon.rng

Re: [libvirt] [PATCH] qemu: minor cleanups

2014-02-03 Thread Martin Kletzander
On Mon, Feb 03, 2014 at 06:52:49PM +0100, Christophe Fergeau wrote: On Fri, Jan 31, 2014 at 05:08:32PM +0100, Martin Kletzander wrote: Some cleanups around serial chardevs and miscellaneous things I've found inconsistent or not very clean. A few comments below, I'd tend to split at least

Re: [libvirt] [PATCH] qemu: minor cleanups

2014-02-03 Thread Martin Kletzander
On Mon, Feb 03, 2014 at 11:10:10AM -0700, Eric Blake wrote: On 02/03/2014 10:52 AM, Christophe Fergeau wrote: On Fri, Jan 31, 2014 at 05:08:32PM +0100, Martin Kletzander wrote: Some cleanups around serial chardevs and miscellaneous things I've found inconsistent or not very clean. A few

Re: [libvirt] [PATCH] Write up the project governance process

2014-02-03 Thread Martin Kletzander
On Mon, Feb 03, 2014 at 06:30:24PM +, Daniel P. Berrange wrote: The project has historically operated as a meritocratic consensus based community. Formally document what has always been an unwritten assumption amongst the community participants. Also include an explicit code of conduct to

Re: [libvirt] [PATCH 01/15] Introduce virDomainSuspendFlags

2014-02-03 Thread Martin Kletzander
On Mon, Feb 03, 2014 at 10:12:58AM -0700, Eric Blake wrote: On 02/03/2014 09:16 AM, Michal Privoznik wrote: So far, we have just bare virDomainSuspend() API that suspends a domain. However, in the future there might occur a case, in which we may want to modify suspend behavior slightly. In

[libvirt] [PATCH] build: Fix 'make rpm' in VPATH with wireshark

2014-02-04 Thread Martin Kletzander
Signed-off-by: Martin Kletzander mklet...@redhat.com --- tools/wireshark/Makefile.am | 1 + tools/wireshark/src/Makefile.am | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/wireshark/Makefile.am b/tools/wireshark/Makefile.am index b6fa57c..28e6ed8 100644 --- a/tools

Re: [libvirt] [PATCH] build: Fix 'make rpm' in VPATH with wireshark

2014-02-04 Thread Martin Kletzander
On Tue, Feb 04, 2014 at 11:14:34AM +0100, Christophe Fergeau wrote: On Tue, Feb 04, 2014 at 10:57:45AM +0100, Martin Kletzander wrote: Signed-off-by: Martin Kletzander mklet...@redhat.com --- tools/wireshark/Makefile.am | 1 + tools/wireshark/src/Makefile.am | 2 +- 2 files changed

Re: [libvirt] [PATCH] qemu: introduce spiceport serial backend

2014-02-04 Thread Martin Kletzander
On Tue, Feb 04, 2014 at 01:34:38PM +0100, Christophe Fergeau wrote: Hey, Not a full review yet as I have only been looking at the doc so far. On Mon, Feb 03, 2014 at 05:41:00PM +0100, Martin Kletzander wrote: Signed-off-by: Martin Kletzander mklet...@redhat.com --- Notes

Re: [libvirt] [PATCH python] Fix calling of virStreamSend method

2014-02-05 Thread Martin Kletzander
On Tue, Feb 04, 2014 at 06:31:26AM -0700, Eric Blake wrote: On 02/04/2014 03:21 AM, Daniel P. Berrange wrote: On Mon, Feb 03, 2014 at 02:32:27PM -0700, Eric Blake wrote: On 01/23/2014 07:25 AM, Daniel P. Berrange wrote: Change d40861 removed the 'len' argument from the virStreamSend C

Re: [libvirt] [PATCH] qemu: introduce spiceport serial backend

2014-02-05 Thread Martin Kletzander
On Wed, Feb 05, 2014 at 03:38:49PM +0100, Christophe Fergeau wrote: On Mon, Feb 03, 2014 at 05:41:00PM +0100, Martin Kletzander wrote: signed-off-by: martin kletzander mklet...@redhat.com --- notes: this applies on top of qemu: minor cleanups: https://www.redhat.com/archives

[libvirt] [PATCH] qemu: keep pre-migration domain state after failed migration

2014-02-06 Thread Martin Kletzander
Couple of codepaths shared the same code which can be moved out to a function and on one of such places, qemuMigrationConfirmPhase(), the domain was resumed even if it wasn't running before the migration started. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1057407 Signed-off-by: Martin

Re: [libvirt] [PATCH] qemu: keep pre-migration domain state after failed migration

2014-02-07 Thread Martin Kletzander
On Thu, Feb 06, 2014 at 06:23:43PM +0100, Jiri Denemark wrote: On Thu, Feb 06, 2014 at 17:33:14 +0100, Martin Kletzander wrote: Couple of codepaths shared the same code which can be moved out to a function and on one of such places, qemuMigrationConfirmPhase(), the domain was resumed even

Re: [libvirt] [PATCH] Skip the 'copyright-check' on -maint branches

2014-02-07 Thread Martin Kletzander
On Thu, Feb 06, 2014 at 04:30:52PM -0700, Eric Blake wrote: On 02/04/2014 06:51 AM, Daniel P. Berrange wrote: The maint branches will often have out of date copyright headers so we must skip the 'sc_copyright_check' rule there. Is that the only rule, or are there others? But yeah, that's

[libvirt] [PATCH v2] qemu: introduce spiceport serial backend

2014-02-07 Thread Martin Kletzander
if there is no spice to use (with test for that as well). For this I moved the def-graphics caounting to the start of the function so its results can be used in rest of the code even in the future. Signed-off-by: Martin Kletzander mklet...@redhat.com --- Notes: v2: - No longer applies

Re: [libvirt] [PATCH v2] qemu: introduce spiceport serial backend

2014-02-09 Thread Martin Kletzander
On Fri, Feb 07, 2014 at 01:10:42PM -0700, Eric Blake wrote: On 02/07/2014 04:37 AM, Martin Kletzander wrote: Adding a new backend that makes the chardev available to be backed up by a port in spice connection (different to spicevmc). This can be used (as well as other backends) for any

[libvirt] [PATCH v3 0/4] Introduce spiceport chardev backend

2014-02-10 Thread Martin Kletzander
BLURB/ Martin Kletzander (4): conf: introduce spiceport chardev backend qemu: rework '-serial none' qemu: remove pointless condition qemu: introduce spiceport chardev backend docs/formatdomain.html.in | 18 docs/schemas/domaincommon.rng

[libvirt] [PATCH v3 3/4] qemu: remove pointless condition

2014-02-10 Thread Martin Kletzander
This patch is here just to ease the code review and make related changes look more sensible. Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/qemu/qemu_command.c | 44 +--- 1 file changed, 21 insertions(+), 23 deletions(-) diff --git a/src

[libvirt] [PATCH v3 4/4] qemu: introduce spiceport chardev backend

2014-02-10 Thread Martin Kletzander
(with test for that as well). For this I moved the def-graphics counting to the start of the function so its results can be used in rest of the code even in the future. Signed-off-by: Martin Kletzander mklet...@redhat.com --- src/qemu/qemu_capabilities.c | 13 ++- src/qemu

[libvirt] [PATCH v3 1/4] conf: introduce spiceport chardev backend

2014-02-10 Thread Martin Kletzander
Add a new character device backend called 'spiceport' that uses spice's channel for communications and apart from spicevmc can be used as a backend for any character device from libvirt's point of view. Signed-off-by: Martin Kletzander mklet...@redhat.com --- docs/formatdomain.html.in | 18

[libvirt] [PATCH v3 2/4] qemu: rework '-serial none'

2014-02-10 Thread Martin Kletzander
), we'll fail to attach '-serial none' to the command-line (when skipping the device's command-line building and the device being the only one). Since there is no such device, this patch doesn't actually do anything, but enables easier future additions in this manner. Signed-off-by: Martin Kletzander

Re: [libvirt] [PATCH] tests: Fix the build failure on s390

2014-02-11 Thread Martin Kletzander
On Tue, Feb 11, 2014 at 11:10:16AM +0800, Osier Yang wrote: On 11/02/14 00:48, Eric Blake wrote: On 02/10/2014 06:35 AM, Osier Yang wrote: The build works fine on other architectures with commit 0b4f76fc5, but for s390: TEST: virscsitest 1) test1 ... OK 2) test2 ... libvirt:

Re: [libvirt] [PATCH v3 3/4] qemu: remove pointless condition

2014-02-11 Thread Martin Kletzander
On Tue, Feb 11, 2014 at 12:13:43PM +0100, Christophe Fergeau wrote: On Mon, Feb 10, 2014 at 03:03:06PM +0100, Martin Kletzander wrote: This patch is here just to ease the code review and make related changes look more sensible. Hehe this description actually made things not as easy

Re: [libvirt] [PATCH v3 0/4] Introduce spiceport chardev backend

2014-02-11 Thread Martin Kletzander
On Tue, Feb 11, 2014 at 12:13:54PM +0100, Christophe Fergeau wrote: Series still looks good to me, ACK. Thanks for the review, pushed now. Martin On Mon, Feb 10, 2014 at 03:03:03PM +0100, Martin Kletzander wrote: BLURB/ Martin Kletzander (4): conf: introduce spiceport chardev

Re: [libvirt] [PATCH] spec: require libvirt-wireshark from libvirt metapackage

2014-02-12 Thread Martin Kletzander
On Wed, Feb 12, 2014 at 01:28:43PM -0700, Eric Blake wrote: In general, the 'libvirt' metapackage should pull in all subpackages. Fix this for the wireshark subpackage created in commit f9ada9f. * libvirt.spec.in (Requires): Add dependency. Signed-off-by: Eric Blake ebl...@redhat.com ---

Re: [libvirt] [PATCHv2] spec: add missing dep of libvirt-daemon-config-network

2014-02-12 Thread Martin Kletzander
On Wed, Feb 12, 2014 at 01:25:11PM -0700, Eric Blake wrote: From: Thierry Parmentelat thierry.parmente...@inria.fr When building modules, libvirt-daemon-config-network requires libvirt-daemon-driver-network to ensure the 'default' network is setup properly Signed-off-by: Eric Blake

Re: [libvirt] [PATCH] spec: add missing dep of libvirt-daemon-config-nwfilter

2014-02-13 Thread Martin Kletzander
On Wed, Feb 12, 2014 at 02:34:50PM -0700, Eric Blake wrote: Similar to cf76c4b, if modules are used, then nwfilter configuration requires the nwfilter driver module. Signed-off-by: Eric Blake ebl...@redhat.com --- libvirt.spec.in | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [libvirt] [Question] Is it a bug about cpu model Westmere?

2014-02-13 Thread Martin Kletzander
On Thu, Feb 13, 2014 at 08:02:34AM +, Wangyufei (James) wrote: Hello, I find that the cpu model Westmere defined in recently qemu has the cupid CPUID_EXT_PCLMULQDQ, but the cpu model Westmere defined in libvirt doesn't have it, SandyBridge defined in libvirt has it. In my opinion,

Re: [libvirt] [PATCH] cpu: break out when a right cpuCandidate found

2014-02-13 Thread Martin Kletzander
On Thu, Feb 13, 2014 at 07:44:20AM +, Wangyufei (James) wrote: From 8123c5d64f940fa0fb0de32fc5e68035980b6b01 Mon Sep 17 00:00:00 2001 From: WangYufei james.wangyu...@huawei.com Date: Thu, 13 Feb 2014 07:17:11 + Subject: [PATCH] cpu: break out when a right cpuCandidate found In

Re: [libvirt] [PATCH] Fix stream related spelling mistakes

2014-02-13 Thread Martin Kletzander
On Thu, Feb 13, 2014 at 09:41:54AM +0100, Philipp Hahn wrote: Remove double is. Consistent spelling of all-uppercase I/O. Signed-off-by: Philipp Hahn h...@univention.de --- ACK pushed, Martin signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] Fix stream related spelling mistakes

2014-02-13 Thread Martin Kletzander
On Thu, Feb 13, 2014 at 09:46:19AM +0100, Philipp Hahn wrote: Consistent spelling of all-uppercase I/O. Signed-off-by: Philipp Hahn h...@univention.de --- libvirt-override-virStream.py | 4 ++-- According to the file changed, I guess this is for libvirt-python, so I'm taking it there, but

Re: [libvirt] [PATCH] spec: require libvirt-wireshark from libvirt metapackage

2014-02-13 Thread Martin Kletzander
On Thu, Feb 13, 2014 at 10:55:11AM +, Daniel P. Berrange wrote: On Thu, Feb 13, 2014 at 10:17:26AM +0100, Michal Privoznik wrote: On 12.02.2014 21:28, Eric Blake wrote: In general, the 'libvirt' metapackage should pull in all subpackages. Fix this for the wireshark subpackage created in

Re: [libvirt] [PATCH RFC 0/2] support compression with dumping guest memory

2014-02-13 Thread Martin Kletzander
On Thu, Feb 13, 2014 at 11:08:50AM +0800, Qiao Nuohan wrote: On 01/29/2014 10:04 AM, qiaonuohan wrote: --memory-only option is introduced without compression supported. Therefore, this is a freature regression of virsh dump. This patchset is used to add compression support in libvirt side

Re: [libvirt] [PATCHv3 1/2] Split out bind() from virPortAllocatorAcquire

2014-02-13 Thread Martin Kletzander
On Thu, Feb 06, 2014 at 05:43:13PM +0100, Ján Tomko wrote: --- src/util/virportallocator.c | 72 - 1 file changed, 45 insertions(+), 27 deletions(-) ACK, Martin signature.asc Description: Digital signature -- libvir-list mailing list

Re: [libvirt] [PATCH] lxc: Add virCgroupSetOwner()

2014-02-13 Thread Martin Kletzander
On Thu, Feb 13, 2014 at 05:15:22PM +, Daniel P. Berrange wrote: From: Richard Weinberger rich...@nod.at Add a new helper function to change the permissions of a control group. This function is needed for user namespaces, we need to chmod() the cgroup to the initial uid/gid such that

Re: [libvirt] [PATCH v1 1/4] Introduce virDomain{Get,Set}Time APIs

2014-02-13 Thread Martin Kletzander
On Thu, Feb 13, 2014 at 07:51:42PM +0100, Michal Privoznik wrote: These APIs allow users to get or set time in a domain, which may come handy if the domain has been resumed just recently and NTP is not configured or hasn't kicked in yet and the guest is running something time critical. In

Re: [libvirt] [PATCH] lxc: Add virCgroupSetOwner()

2014-02-14 Thread Martin Kletzander
On Fri, Feb 14, 2014 at 08:47:37AM +0100, Richard Weinberger wrote: Am 14.02.2014 08:10, schrieb Martin Kletzander: On Thu, Feb 13, 2014 at 05:15:22PM +, Daniel P. Berrange wrote: From: Richard Weinberger rich...@nod.at Add a new helper function to change the permissions of a control

Re: [libvirt] [PATCH v1 2/4] remote: Implement remote{Get,Set}Time

2014-02-14 Thread Martin Kletzander
On Thu, Feb 13, 2014 at 07:51:43PM +0100, Michal Privoznik wrote: This is also adding new ACL permission to check 'set_time'. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- daemon/remote.c | 35 +++ src/access/viraccessperm.c | 2 +-

<    1   2   3   4   5   6   7   8   9   10   >