On Thu, Feb 13, 2014 at 07:51:44PM +0100, Michal Privoznik wrote:
These APIs are exposed under new virsh command 'domtime' which both gets
and sets (not at the same time of course :)).
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
tools/virsh-domain-monitor.c | 126
On Thu, Feb 13, 2014 at 07:51:45PM +0100, Michal Privoznik wrote:
One caveat though, qemu-ga is expecting time and returning time
in nanoseconds. With all the buffering and propagation delay, the
time is already wrong once it gets to the qemu-ga, but there's
nothing we can do about it.
On Thu, Feb 20, 2014 at 02:46:03PM +0100, Peter Krempa wrote:
Hi,
with my recent work into snapshots with native libgfapi support I've run
into an issue with libvirt APIs used to delete snapshots by management apps.
The management apps use the APIs to do the job:
int
, that
needs to be filtered out using a try-except when converting the value.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
generator.py | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/generator.py b/generator.py
index 42f3913..0e9600f 100755
On Thu, Feb 20, 2014 at 04:19:54PM +, Daniel P. Berrange wrote:
On Thu, Feb 20, 2014 at 05:15:08PM +0100, Martin Kletzander wrote:
When enum type has '_LAST' in its name, but is not the last type in
that enum, it's skipped even though it shouldn't be. Currently, this
is the case
On Mon, Feb 24, 2014 at 02:12:34PM +0800, shyu wrote:
There will be memory leak when lookup pool list with invalid type option
https://bugzilla.redhat.com/show_bug.cgi?id=1069068
==23060== Memcheck, a memory error detector
==23060== Copyright (C) 2002-2012, and GNU GPL'd, by Julian Seward et
On Mon, Feb 24, 2014 at 05:33:31PM +0530, Avanti Ajay wrote:
Hello,
I am trying to run event-test.c code available in libvirt-0.10.2 package
under the folder
/examples/domain-events/events-c.
I am getting the following error
/usr/bin/ld: cannot find -lvirt
collect2: ld returned 1 exit
On Mon, Feb 24, 2014 at 12:25:28PM +, Daniel P. Berrange wrote:
From: Richard Weinberger rich...@nod.at
This function is needed for user namespaces, where we need to chmod()
the cgroup to the initial uid/gid such that systemd is allowed to
use the cgroup.
Signed-off-by: Richard
On Wed, Feb 26, 2014 at 01:09:48PM +0100, Peter Krempa wrote:
RHEL still uses the 3.4.0 package of libgfapi and the package is built
only for x86_64.
---
libvirt.spec.in | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
On Wed, Feb 26, 2014 at 01:25:09PM +0100, Michal Privoznik wrote:
If user wants to grep some info from domain, e.g. disk paths:
# virsh -q domblklist win7 | awk '{print $2}'
Source
/var/lib/libvirt/images/windows.qcow2
On Wed, Feb 26, 2014 at 02:21:11PM +0100, Peter Krempa wrote:
In commit 72f7658ba24491672e6b81118f892400916e9404 I've added a few
macros with bad bracing. Although they work as expected fix them so that
we use uniform syntax.
---
libvirt.spec.in | 4 ++--
1 file changed, 2 insertions(+), 2
On Tue, Feb 25, 2014 at 09:19:34AM -0500, Qiang Fu wrote:
Hi all,
I am trying to use virsh to get the memory and storage usage for KVM domain.
Right now we can get domain memory statistics through the following virsh
cmds:
1. dumpxml: this returns memory and currentMemory
This are
On Fri, Feb 28, 2014 at 10:18:09AM +0100, Michal Privoznik wrote:
As of 0bd2ccdec an empty disk path for virDomainBlockStats (or the one
with Flags) is allowed meaning get me overall summarized statistics.
However, running 'virsh domblkstat $dom' throws a misleading error:
# ./tools/virsh
On Fri, Feb 28, 2014 at 10:18:21AM +0100, Michal Privoznik wrote:
Compare:
# virsh domblkstat freebsd hdd
error: Failed to get block stats freebsd hdd
error: invalid argument: invalid path: hdd
with:
# virsh domblkstat freebsd hdd
error: Failed to get block stats for domain
This is actaully a proper setting since we're not checking
session-mode related XMLs.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
tests/qemuxml2argvtest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index
).
Given the above it seems reasonable to reject such unsupported
settings.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
Few questions came to my mind while writing the commit message:
1) Would helper function (macro) be preferred so the code looks
cleaner
On Mon, Mar 03, 2014 at 06:33:19PM +0100, Ján Tomko wrote:
Include dlfcn.h before checking if RTLD_NEXT is defined
---
tests/virportallocatortest.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
ACK
Martin
diff --git a/tests/virportallocatortest.c
On Mon, Mar 03, 2014 at 10:18:30AM +0100, Steven Malin wrote:
Hello,
I want to provide a patch which allows RFC 2782 compliant dns srv
records in the network configs. If you have questions, please contact me.
Kind Regards,
Steven Malin
Please change the commit message in order for it to
On Mon, Mar 03, 2014 at 12:19:07PM -0700, Eric Blake wrote:
On 03/03/2014 10:21 AM, Martin Kletzander wrote:
This is actaully a proper setting since we're not checking
s/actaully/actually/
session-mode related XMLs.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
tests
On Tue, Mar 04, 2014 at 10:15:00AM +0100, Peter Krempa wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1071264
Reverting of external snapshots is not supported currently. The check
that is present doesn't properly check for all aspects that make a
snapshot external. Use
On Tue, Mar 04, 2014 at 10:38:29AM +0100, Peter Krempa wrote:
In qemuMonitorJSONExtractCPUInfo an error message hinted on missing
character device data which is wrong.
Also a comment states that only qemu-kvm tree includes the thread_id
field. This is no longer true.
---
ACK
Martin
On Tue, Mar 04, 2014 at 10:47:38AM +0100, Michal Privoznik wrote:
As I did previously in 4f588a1b46, libvirt needs to set virtio vectors.
Previously, we were advised to use vectors=N, where
N = 2 * (number of queues) + 1
However, just recently this advisory has changed on the Multiquue wiki
On Tue, Mar 04, 2014 at 06:44:01AM -0700, Eric Blake wrote:
On 03/03/2014 10:21 AM, Martin Kletzander wrote:
When domain is started with setting that cannot be done, i.e. those
that require cgroups, there is no error reported and it succeeds
without any message whatsoever.
When setting
).
Given the above it seems reasonable to reject such unsupported
settings.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1023366
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
v2:
- Allow CPU pinning since setting affinity should still work.
- Remove bogus 'cfg
On Tue, Mar 04, 2014 at 02:13:15PM +0100, Ján Tomko wrote:
---
src/lxc/lxc_cgroup.c | 13 ++---
src/lxc/lxc_driver.c | 6 +-
src/qemu/qemu_cgroup.c | 12 +---
src/qemu/qemu_driver.c | 7 ++-
4 files changed, 30 insertions(+), 8 deletions(-)
ACK,
Martin
On Tue, Mar 04, 2014 at 02:13:14PM +0100, Ján Tomko wrote:
Currently, cputuneshares0/shares/cputune is treated
as if it were not specified.
s/were/was/ in this particular case, I guess.
ACK,
Martin
signature.asc
Description: Digital signature
--
libvir-list mailing list
On Tue, Mar 04, 2014 at 02:04:05PM -0700, Eric Blake wrote:
On 03/04/2014 07:15 AM, Martin Kletzander wrote:
When domain is started with setting that cannot be done, i.e. those
that require cgroups, there is no error reported and it succeeds
without any message whatsoever.
When setting
On Wed, Mar 05, 2014 at 06:12:41AM -0700, Eric Blake wrote:
On 03/05/2014 03:37 AM, Martin Kletzander wrote:
On Tue, Mar 04, 2014 at 02:04:05PM -0700, Eric Blake wrote:
On 03/04/2014 07:15 AM, Martin Kletzander wrote:
When domain is started with setting that cannot be done, i.e. those
On Thu, Mar 06, 2014 at 03:46:42PM +0100, Ján Tomko wrote:
[To be squashed in the previous commit]
I've found two more places where shareSpecified should be checked
and added a test.
And you can find another one in qemuBuildCommandLine(), see commit
45ad1adb4a5ae5ce46287c570e87abab6ffe62d6
Man page, help output and also parsing is sorted in order to find
options smoothly.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
tools/virsh.c | 64 -
tools/virsh.pod | 38 +-
2 files changed
driver or remote server). If not explicitely requested, a debug
message is printed (hence the addition to virsh-optparse test).
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1073506
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=822839
Signed-off-by: Martin Kletzander mklet
*** BLURB ***
Martin Kletzander (4):
virsh: Sort options alphabetically
virsh: Add keepalive in new vshConnect function
virsh: Prohibit virConnectOpen* functions in virsh
[DO_NOT_APPLY_UPSTREAM] virsh: add connection monitoring into
vshWatchJob
cfg.mk | 8 ++-
tests
Addition of vshConnect() makes virConnectOpen() functions obsolete in
virsh. Thus all virsh-*.[ch] files should be left only with
vshConnect() in the case of need.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
cfg.mk | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff
, but it would require much more wiring and overhead, I
guess.
Unless anyone has any idea what I might have done wrong and helps me
turn into wrong direction, of course.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
tools/virsh-domain.c | 19 ++-
tools/virsh.c| 2
On Fri, Mar 07, 2014 at 01:59:31PM +0100, Michal Privoznik wrote:
On 07.03.2014 12:59, Daniel P. Berrange wrote:
There is a forever growing list of test cases. It is just
not worth listing each one individually when a wildcard
can do the job.
Signed-off-by: Daniel P. Berrange
On Fri, Mar 07, 2014 at 04:50:51PM +0100, Michal Privoznik wrote:
On 07.03.2014 11:49, Martin Kletzander wrote:
Introducing keepalive similarly to Guannan around 2 years ago. Since
we want to introduce keepalive for every connection, it makes sense to
wrap the connecting function into new
On Sun, Mar 09, 2014 at 03:23:25PM +, Richard W.M. Jones wrote:
from src/qemu/qemu_command.c:
if (disk-discard) {
if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DRIVE_DISCARD)) {
virBufferAsprintf(opt, ,discard=%s,
On Fri, Mar 07, 2014 at 04:50:55PM +0100, Michal Privoznik wrote:
On 07.03.2014 11:49, Martin Kletzander wrote:
Man page, help output and also parsing is sorted in order to find
options smoothly.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
tools/virsh.c | 64
This series adds client keepalive support into virsh. This was
previously almost done by Guannan around 2 years ago, but not
finished.
Martin Kletzander (3):
virsh: Add keepalive in new vshConnect function
virsh: Prohibit virConnectOpen* functions in virsh
[DO_NOT_APPLY_UPSTREAM] virsh
Addition of vshConnect() makes virConnectOpen() functions obsolete in
virsh. Thus all virsh-*.[ch] files should be left only with
vshConnect() in the case of need.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
cfg.mk | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff
, but it would require much more wiring and overhead, I
guess.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
tools/virsh-domain.c | 19 ++-
tools/virsh.c| 2 +-
tools/virsh.h| 2 ++
3 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/tools/virsh
and after GetSpiceMigrationStatus
mangled its internal data, the daemon crashed.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1009886
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_migration.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
On Fri, Sep 20, 2013 at 05:37:58PM +0200, Ján Tomko wrote:
On 09/20/2013 05:13 PM, Martin Kletzander wrote:
Since the wait is done during migration (still inside
QEMU_ASYNC_JOB_MIGRATION_OUT), the code should enter the monitor as such
in order to prohibit all other jobs from interfering
On Fri, Sep 27, 2013 at 05:43:50PM +0200, Christophe Fergeau wrote:
Hey Martin,
Your reply wasn't sent to the mailing list, I'm assuming this was
unintentional.
Yes, sorry, that happened to me with 2 ACKs today :-(
On Fri, Sep 27, 2013 at 12:08:27PM +0200, Martin Kletzander wrote:
On Wed
On Thu, Sep 26, 2013 at 10:59:04AM +0800, Hongwei Bi wrote:
Check return value of virStreamNew when called by
cmdVolUpload and cmdVolDownload.
---
tools/virsh-volume.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/virsh-volume.c
-by: Martin Kletzander mklet...@redhat.com
---
Notes:
I checked that Marian's patch works as expected and that it really
fixes the issue.
python/libvirt-override.c | 4
1 file changed, 4 insertions(+)
diff --git a/python/libvirt-override.c b/python/libvirt-override.c
index 4800d1d..2e58bf9
On RHEL 5, make syntax-check was failing because even strings like
'int isTempChain' matched the 'int i' rule. To be honest, I haven't
found the root cause, but the change added makes it work as expected
and keeps the proper behavior on newer systems as well.
Signed-off-by: Martin Kletzander
On Tue, Oct 22, 2013 at 05:32:34PM +0200, Ján Tomko wrote:
On 10/22/2013 05:21 PM, Martin Kletzander wrote:
From: Marian Neagul mar...@info.uvt.ro
Commit d76227be added functions virDomainCreateWithFiles and
virDomainCreateXMLWithFiles, but there was a little piece missing in
python
On Tue, Oct 22, 2013 at 09:52:30PM +0100, Eric Blake wrote:
On 10/22/2013 05:19 PM, Martin Kletzander wrote:
On RHEL 5, make syntax-check was failing because even strings like
'int isTempChain' matched the 'int i' rule. To be honest, I haven't
found the root cause, but the change added
On Tue, Oct 22, 2013 at 04:42:31PM +0100, Eric Blake wrote:
On 10/21/2013 06:03 PM, Marian Neagul wrote:
Dear All,
While working on a component handling container management I stumbled on a
bug
in the libvirt python bindings: basically the python bindings fail in
properly
... the same way we ignore other TAGS
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
.gitignore | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.gitignore b/.gitignore
index db5abcd..e372876 100644
--- a/.gitignore
+++ b/.gitignore
@@ -233,6 +233,9 @@
/tools/virt-*-validate
On Wed, Oct 23, 2013 at 11:21:07AM +0200, Claudio Bley wrote:
At Wed, 23 Oct 2013 10:07:48 +0100,
Martin Kletzander wrote:
... the same way we ignore other TAGS
ACK
Thanks, pushed.
Martin
signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list
-off-by: Martin Kletzander mklet...@redhat.com
---
src/libxl/libxl_driver.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index e2a6d44..4928695 100644
--- a/src/libxl/libxl_driver.c
+++ b/src/libxl/libxl_driver.c
On Wed, Oct 23, 2013 at 10:46:14AM -0700, Jeremy Fitzhardinge wrote:
Hi all,
I posted this bug (https://bugzilla.redhat.com/show_bug.cgi?id=1013045)
to the Redhat Bugzilla a while ago, and the only response has been to
post a note to this list about the bug.
Summary below, but it looks
On Thu, Oct 24, 2013 at 10:57:37AM +0100, Daniel P. Berrange wrote:
On Thu, Oct 24, 2013 at 10:50:02AM +0100, Martin Kletzander wrote:
According to the following valgrind output, there seems to be a
invalid limit for the iterator (captured on Fedora 19):
==3945== Invalid read of size 1
On Fri, Oct 18, 2013 at 06:59:51AM -0400, John Ferlan wrote:
Commit '922b7fda' resulted in two DEADCODE warnings from Coverity in
remoteDispatchAuthPolkit and virAccessDriverPolkitFormatProcess.
Commit '604ae657' modified the daemon.c code to remove the deadcode
issue, but did not do so for
On Thu, Oct 24, 2013 at 05:55:59PM +0800, Chen Hanxiao wrote:
Subject: Re: [libvirt] [PATCH]lxc: improve readability of
lxcContainer[Send|Waitfor]Continue
On 16.10.2013 08:27, Chen Hanxiao wrote:
From: Chen Hanxiao chenhanx...@cn.fujitsu.com
I think this can be achieved
On Mon, Oct 28, 2013 at 03:50:20PM -0600, Eric Blake wrote:
Since we haven't quite frozen yet, it's time to pick up some
fixes. I know at least cygwin benefits from this update.
* .gnulib: Update to latest, in part for cygwin compilation.
Even though that's not your fault, this might
On Tue, Oct 29, 2013 at 02:12:00PM -0600, Eric Blake wrote:
[adding bug-gnulib]
On 10/29/2013 11:15 AM, Martin Kletzander wrote:
On Mon, Oct 28, 2013 at 03:50:20PM -0600, Eric Blake wrote:
Since we haven't quite frozen yet, it's time to pick up some
fixes. I know at least cygwin
On Wed, Oct 23, 2013 at 02:20:17AM +0800, Hongwei Bi wrote:
fix the if statement coding stype
s/stype/style/
both here and in the subject.
Signed-off-by: Hongwei Bi hwbi2...@gmail.com
---
src/xenapi/xenapi_driver.c | 63
++
1 file changed,
On Fri, Oct 25, 2013 at 02:03:41PM +0100, Michal Privoznik wrote:
Among with this test introduce virpcimock as we need to mock some
syscalls, e.g. redirect open() of a file under /sys/bus/pci to a
stub sysfs tree.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
.gitignore
On Fri, Oct 25, 2013 at 02:03:43PM +0100, Michal Privoznik wrote:
This test will reattach the PCI device detached in the previous test.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
tests/virpcitest.c | 37 +
1 file changed, 37 insertions(+)
On Thu, Oct 31, 2013 at 11:23:40AM +, Michal Privoznik wrote:
This test will reattach the PCI device detached in the previous test.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
tests/virpcitest.c | 37 +
1 file changed, 37 insertions(+)
On Thu, Oct 31, 2013 at 11:23:41AM +, Michal Privoznik wrote:
s/not binded/unbinded/ in $SUBJ
If a PCI deivce is not binded to any driver (e.g. there's yet no PCI
driver in the linux kernel) but still users want to passthru the device
we fail the whole operation as we fail to resolve the
On Thu, Oct 31, 2013 at 11:23:39AM +, Michal Privoznik wrote:
This commit introduces yet another test under virpcitest:
virPCIDeviceDetach. However, in order to be able to do this, the
virpcimock needs to be extended to model the kernel behavior on PCI
device binding and unbinding (create
On Thu, Oct 31, 2013 at 11:23:42AM +, Michal Privoznik wrote:
This just introduces the test for bug fixed in the previous patch.
I was once warned that previous, next and 4/5 are not good
pointers in a comit message as the commit might be cherry-picked,
rebased or commited somewhere
On Thu, Sep 26, 2013 at 10:50:16AM +0200, Ján Tomko wrote:
Since qemu-kvm 1.1 [1] (since 1.3. in upstream QEMU [2])
'-no-kvm-pit-reinjection' has been deprecated.
Use -global kvm-pit.lost_tick_policy=discard instead.
https://bugzilla.redhat.com/show_bug.cgi?id=978719
[1]
On Mon, Nov 04, 2013 at 02:30:50PM -0700, Eric Blake wrote:
A qcow2 file with a backing file of 'gluster://host/vol/file' should
not try to look for a directory named './gluster:/' in the file system.
* src/util/virstoragefile.c (virBackingStoreIsFile): Broaden check
to include all
On Tue, Nov 05, 2013 at 09:08:33AM +0100, Sandro Bonazzola wrote:
Hi,
I had to reinstall ovirt yesterday and now it seems that it doesn't work
anymore.
I'm running nightly on Fedora 18.
kernel-3.11.4-101.fc18.x86_64
sanlock-2.8-1.fc18.x86_64
libvirt-1.1.4-1.fc18.x86_64
On Tue, Nov 05, 2013 at 02:19:18PM +0100, Ján Tomko wrote:
Since qemu-kvm 1.1 [1] (since 1.3. in upstream QEMU [2])
'-no-kvm-pit-reinjection' has been deprecated.
Use -global kvm-pit.lost_tick_policy=discard instead.
https://bugzilla.redhat.com/show_bug.cgi?id=978719
[1]
On Tue, Nov 05, 2013 at 12:49:19PM +0100, Giuseppe Scrivano wrote:
The PyList_SET_ITEM macro, differently from PyList_SetItem, doesn't do
any error checking and overwrites anything that was previously stored
in the list at the chosen destination position.
PyList_SET_ITEM is usually faster
On Tue, Nov 05, 2013 at 08:42:08AM -0700, Eric Blake wrote:
On 11/05/2013 01:13 AM, Martin Kletzander wrote:
On Mon, Nov 04, 2013 at 02:30:50PM -0700, Eric Blake wrote:
A qcow2 file with a backing file of 'gluster://host/vol/file' should
not try to look for a directory named './gluster
On Tue, Nov 05, 2013 at 05:00:53PM +0100, Giuseppe Scrivano wrote:
Martin Kletzander mklet...@redhat.com writes:
Not that it has any connection to your patch, but I noticed that,
somewhere, we check the return value of PyList_New(), but somewhere we
don't... I guess we should do
On Thu, Nov 07, 2013 at 01:10:39PM +0200, Laine Stump wrote:
This resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=1025397
When libvirt creates the list of an SRIOV Physical Function's (PF)
Virtual Functions (VF), it assumes that the order of virtfn* links
returned by readdir()
On Mon, Nov 11, 2013 at 10:40:11AM +, Daniel P. Berrange wrote:
On Fri, Nov 08, 2013 at 08:54:39AM +0100, Michal Privoznik wrote:
On 08.11.2013 06:27, Daniel P. Berrange wrote:
On Thu, Nov 07, 2013 at 11:39:27AM +0100, Michal Privoznik wrote:
Similarly to VIR_FREE() we can set the
On Thu, Nov 07, 2013 at 03:44:22PM +0100, Giuseppe Scrivano wrote:
The PyList_SET_ITEM macro, differently from PyList_SetItem, doesn't do
any error checking and overwrites anything that was previously stored
in the list at the chosen destination position.
PyList_SET_ITEM is usually faster
On Thu, Nov 07, 2013 at 03:44:23PM +0100, Giuseppe Scrivano wrote:
Signed-off-by: Giuseppe Scrivano gscri...@redhat.com
---
python/libvirt-override.c | 88
+--
1 file changed, 70 insertions(+), 18 deletions(-)
diff --git
On Tue, Nov 12, 2013 at 07:00:30AM -0700, Eric Blake wrote:
On 11/12/2013 06:53 AM, Martin Kletzander wrote:
@@ -2621,7 +2630,8 @@ libvirt_virDomainSnapshotListChildrenNames(PyObject
*self ATTRIBUTE_UNUSED,
return VIR_PY_NONE;
}
}
-py_retval
On Thu, Nov 14, 2013 at 10:51:11AM +0100, Michal Privoznik wrote:
In the function an helper to build the dnsmasq config file is used. The
content to be stored then into the config file is kept in @configstr
variable. However, once written, it's never freed and as soon as the
control reaches
On Thu, Nov 14, 2013 at 10:51:12AM +0100, Michal Privoznik wrote:
The name of the dnsmasq's config file is initialized and passed to
virCommand. However, the virCommand creates a copy, so we are
responsible for freeing the @configfile ourselves.
Squashing with 1/1 would've been fine too ;)
On Thu, Nov 14, 2013 at 10:51:14AM +0100, Michal Privoznik wrote:
Even though currently we are freeing the pool of worker threads at the
daemon very end, nothing holds us back in joining the worker threads.
s/daemon/daemon's/ ???
Unless the thread is blocked, right? Not that it should
On Thu, Nov 14, 2013 at 10:51:13AM +0100, Michal Privoznik wrote:
These two chunks had to be part of df4283a55bf. But for some unclear
reason, the weren't. Anyway, these two variables are not used anywhere
within function. They're initialized to NULL and then VIR_FREE()-d. And
there's no
On Thu, Nov 14, 2013 at 10:51:15AM +0100, Michal Privoznik wrote:
The @list-callbacks is an array that is inflated whenever a new event
is added, e.g. via virDomainEventCallbackListAddID(). However, when we
are freeing the array, we free the items within it but forgot to
actually free it.
On Thu, Nov 14, 2013 at 10:51:16AM +0100, Michal Privoznik wrote:
In the qemuProcessReconnectHelper() a new thread that do all the
s/do/does/
interesting work is spawned. The rationale is to not block the daemon
startup process in case of unresponsive qemu. However, the thread
handler is a
On Wed, Nov 13, 2013 at 06:01:40PM +0100, Ján Tomko wrote:
Introduced by 7b4a630.
---
src/qemu/qemu_process.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index e34f542..1365b59 100644
--- a/src/qemu/qemu_process.c
+++
On Wed, Nov 13, 2013 at 06:01:41PM +0100, Ján Tomko wrote:
This allows its error messages to be more specific.
---
src/libxl/libxl_driver.c | 3 ++-
src/qemu/qemu_driver.c | 9 ++---
src/util/virportallocator.c | 9 +++--
src/util/virportallocator.h | 3 ++-
On Wed, Nov 13, 2013 at 06:01:42PM +0100, Ján Tomko wrote:
Report the error in virPortAllocatorAcquire instead
of doing it in every caller.
The error contains the port range name instead of the intended
use for the port, e.g.:
Unable to find an unused port in range 'display' (65534-65535)
On Tue, Nov 05, 2013 at 03:59:55PM +0100, Ján Tomko wrote:
---
tests/jsontest.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/tests/jsontest.c b/tests/jsontest.c
index 6add816..808a2ea 100644
--- a/tests/jsontest.c
+++ b/tests/jsontest.c
@@ -145,6 +145,10 @@
On Tue, Nov 05, 2013 at 03:59:56PM +0100, Ján Tomko wrote:
---
src/util/virjson.c | 9 -
tests/jsontest.c | 5 +
2 files changed, 13 insertions(+), 1 deletion(-)
ACK,
Martin
signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
On Tue, Nov 19, 2013 at 10:32:01AM -0600, Doug Goldstein wrote:
The case label for VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED did not have its
own break statement but relied on falling through which we probably
don't want.
---
python/libvirt-override.c | 1 +
1 file changed, 1 insertion(+)
diff
On Fri, Nov 22, 2013 at 10:24:17AM +, Daniel P. Berrange wrote:
On Fri, Nov 22, 2013 at 06:01:44AM +0100, Martin Kletzander wrote:
There are few places where we know about port getting opened even
though it was not allocated on any virPortAllocator (or we know it was
reserved like
On Sun, Nov 24, 2013 at 10:46:13AM -0600, Doug Goldstein wrote:
On Sat, Nov 23, 2013 at 3:15 PM, Don Dugger n0...@n0ano.com wrote:
This Python interface code is returning a -1 on errors for the
`baselineCPU' API. Since this API is supposed to return a pointer
the error return value
On Tue, Nov 19, 2013 at 09:36:49AM -0500, Shivaprasad G Bhat wrote:
Version 2:
Fixed the string formatting errors in v1.
Version 1:
The patch contains the fix for defect 1009880 reported at redhat bugzilla.
Version changes are great to have, but it's good to add them as a
'footnote' or as
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
setup.py | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100644 = 100755 setup.py
diff --git a/setup.py b/setup.py
old mode 100644
new mode 100755
--
1.8.4.3
--
libvir-list mailing list
libvir-list@redhat.com
https
without the need to install libvirt into the system.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
setup.py | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/setup.py b/setup.py
index 17b4722..566c210 100755
--- a/setup.py
+++ b/setup.py
@@ -109,7 +109,17
On Tue, Nov 26, 2013 at 10:15:50AM +, Daniel P. Berrange wrote:
On Tue, Nov 26, 2013 at 10:58:13AM +0100, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
setup.py | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100644 = 100755
On Tue, Nov 26, 2013 at 10:14:36AM +, Daniel P. Berrange wrote:
On Tue, Nov 26, 2013 at 10:58:25AM +0100, Martin Kletzander wrote:
Adding a support for LIBVIRT_API_PATH evironment variable, which can
control where the script should look for the 'libvirt-api.xml' file.
This allows
On Tue, Nov 26, 2013 at 07:59:31PM +0530, Shivaprasad G Bhat wrote:
Version 3:
Addressed comments on V2.
Version 2:
Fixed the string formatting errors in v1.
The patch contains the fix for defect 1009880 reported at redhat bugzilla.
The root cause is, ever since the
On Tue, Dec 03, 2013 at 06:30:26AM -0500, Shivaprasad G Bhat wrote:
Version 4:
cpuset/mems modification moved to a new funtion and removed duplicate code as
per the comments on v3.
Version 3:
Addressed comments on V2.
Version 2:
Fixed the string formatting errors in v1.
The patch
To see what changed in the kernel, see explanation in PATCH 1/3.
First two patches make proper use of VIR_DOMAIN_MEMORY_PARAM_UNLIMITED,
the third one just fixes a typo.
Martin Kletzander (3):
cgroups: Redefine what unlimited means wrt memory limits
qemu: Report
401 - 500 of 5738 matches
Mail list logo
