-off-by: Martin Kletzander mklet...@redhat.com
---
src/util/vircgroup.c | 57 +++-
1 file changed, 39 insertions(+), 18 deletions(-)
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index 9674328..43eb649 100644
--- a/src/util/vircgroup.c
+++ b
For dead domains that have no memtune limits, we return 0 instead of
unlimited, this patch fixes it to return PARAM_UNLIMITED.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_driver.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 4b93c02..a55c762 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -7948,7
On Mon, Dec 09, 2013 at 03:43:55PM +0100, Jiri Denemark wrote:
Mention the need to set memtune/hard_limit.
https://bugzilla.redhat.com/show_bug.cgi?id=1035954
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
docs/formatdomain.html.in | 5 -
1 file changed, 4 insertions(+), 1
limit makes no sense.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
This patch efectively completes my previous patch on PARAM_UNLIMITED
[1], but I discovered it just now and found out that the behavior
hasn't changed in between.
[1] https://www.redhat.com
On Tue, Dec 10, 2013 at 08:59:50AM +0100, Michal Privoznik wrote:
On 09.12.2013 09:22, Martin Kletzander wrote:
To see what changed in the kernel, see explanation in PATCH 1/3.
First two patches make proper use of VIR_DOMAIN_MEMORY_PARAM_UNLIMITED,
the third one just fixes a typo
On Tue, Dec 10, 2013 at 09:12:25AM +0100, Martin Kletzander wrote:
On Tue, Dec 10, 2013 at 09:08:43AM +0100, Michal Privoznik wrote:
On 10.12.2013 08:43, Martin Kletzander wrote:
When changing memtune limits to unlimited with AFFECT_CONFIG, the
values in virDomainDef are set
On Wed, Dec 11, 2013 at 08:30:53PM +0800, Chen Hanxiao wrote:
From: Chen Hanxiao chenhanx...@cn.fujitsu.com
s/pausde/paused
Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com
---
include/libvirt/libvirt.h.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Wed, Dec 11, 2013 at 04:31:46PM +, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
This updates autobuild.sh to test the python3 build process.
The RPM specfile is changed to build a libvirt-python3 RPM
on Fedora 18
Signed-off-by: Daniel P. Berrange
On Thu, Dec 12, 2013 at 06:04:01PM +, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The domain events demo program isn't really tied to domain
events anymore, so rename it to object events.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
Makefile.am
On Thu, Dec 12, 2013 at 06:04:02PM +, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
---
examples/object-events/event-test.c | 45
+++--
1 file changed, 43 insertions(+), 2 deletions(-)
ACK,
Martin
signature.asc
Description:
On Thu, Dec 12, 2013 at 06:04:04PM +, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Inject a virNetworkEvent class between virObjectEvent
and virNetworkEventLifecycle to mirror virDomainEvent.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
On Thu, Dec 12, 2013 at 06:04:06PM +, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The event namespace concept is mostly redundant information.
With the re-written dispatcher, the namespace is only used
for equality comparisons between event IDs. This can be
On Thu, Dec 12, 2013 at 06:04:05PM +, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Instead of having the object event code have to know about each
type of event and their dispatch functions, associate a dispatch
function with the object instance. The dispatch
On Fri, Dec 13, 2013 at 11:07:57AM +0100, Martin Kletzander wrote:
On Thu, Dec 12, 2013 at 06:04:01PM +, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The domain events demo program isn't really tied to domain
events anymore, so rename it to object events
On Thu, Dec 12, 2013 at 06:04:07PM +, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/conf/object_event.c | 5 +
1 file changed, 5 insertions(+)
Trivial, ACK,
Martin
signature.asc
Description:
On Thu, Dec 12, 2013 at 06:04:03PM +, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
While the public API wire protocol included the 'detail'
arg for network lifecycle events, the internal event handling
code did not process it. This meant that if a future
On Thu, Dec 12, 2013 at 12:29:34PM -0700, Eric Blake wrote:
On 12/12/2013 04:19 AM, Daniel P. Berrange wrote:
+++ b/autobuild.sh
@@ -13,6 +13,12 @@ python setup.py build
python setup.py test
python setup.py install --root=$AUTOBUILD_INSTALL_ROOT
I haven't tested it, but shouldn't
On Fri, Dec 13, 2013 at 07:16:22AM -0500, Zhenfeng Wang wrote:
Hi
I met a issue that while shutdown/reboot a guest which was in pmsuspended
status with the acpi mode,
the virsh command appears executed successfully, actually, the guest keep in
pmsuspended status and
it didn't shutoff the
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_capabilities.c | 1 +
tests/qemucapabilitiesdata/caps_1.5.3-1.caps | 1 +
tests/qemucapabilitiesdata/caps_1.6.0-1.caps | 1 +
tests/qemucapabilitiesdata/caps_1.6.50-1.caps | 1 +
4 files changed, 4 insertions
Consider this changed:
s/machine=/machine in $SUBJ
On Fri, Dec 13, 2013 at 03:08:59PM +0100, Martin Kletzander wrote:
The support for boot rebootTimeout=12345/ was added before we were
checking for qemu command line options in QMP, so we haven't properly
adapted virQEMUCaps when using
On Fri, Dec 13, 2013 at 07:12:23AM -0700, Eric Blake wrote:
On 12/13/2013 07:08 AM, Martin Kletzander wrote:
The support for boot rebootTimeout=12345/ was added before we were
checking for qemu command line options in QMP, so we haven't properly
adapted virQEMUCaps when using it and thus we
On Mon, Dec 16, 2013 at 02:29:15PM +0100, Michal Privoznik wrote:
From: Wang Sen wang...@linux.vnet.ibm.com
Currently, 'vol-resize --allocate' allocates new space at the
vol-capacity offset. But the vol-capacity is not necessarily the same
as vol-allocation. For instance:.
Disks have type='drive', not type='disk'.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
docs/formatdomain.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 0067e8f..2b8bc8f 100644
--- a/docs
On Mon, Dec 16, 2013 at 05:36:00PM +0100, Peter Krempa wrote:
On 12/16/13 17:31, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_process.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Trivial. ACK.
Of course
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_process.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index bd9546e..d0fde54 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
On Mon, Dec 16, 2013 at 10:11:28AM -0700, Eric Blake wrote:
On 12/16/2013 09:06 AM, Martin Kletzander wrote:
Disks have type='drive', not type='disk'.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
docs/formatdomain.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion
On Tue, Dec 17, 2013 at 06:43:25PM +0100, Dario Faggioli wrote:
Starting from commit 2e82c18c in Xen (will be included in Xen 4.4)
libxl_get_max_cpus() start returning a proper libxl error code, in
case of failure. It returning 0 is now basically impossible but,
theoretically, still wrong, not
be, but the option is
wrong.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
configure.ac | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/configure.ac b/configure.ac
index 5446634..2ebb941 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2035,14 +2035,14
When test-locking is enabled, CFLAGS have -Dbool=char, which makes
pipefd[bool] fail (obviously). Forcing the subscript to be bool by
double negation fixes the build breaker.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
I still can't build with '--enable-test-locking
On Wed, Dec 18, 2013 at 06:05:15AM -0700, Eric Blake wrote:
On 12/18/2013 12:03 AM, Martin Kletzander wrote:
Our option '--with-test-suite' could have never worked since it was
defined as AC_ARG_ENABLE([with-test-suite], ...), thus working only as
'--enable-with-test-suite', but documented
On Wed, Dec 18, 2013 at 06:09:40AM -0700, Eric Blake wrote:
On 12/18/2013 02:35 AM, Martin Kletzander wrote:
When test-locking is enabled, CFLAGS have -Dbool=char, which makes
Huh? bool should never be defined to char in CFLAGS; it should only be
replaced if gnulib thinks the compiler
On Wed, Dec 18, 2013 at 06:34:43AM -0700, Eric Blake wrote:
On 12/18/2013 06:25 AM, Martin Kletzander wrote:
pipefd[bool] fail (obviously). Forcing the subscript to be bool by
double negation fixes the build breaker.
I don't get how this could possibly make a difference. The 'output
').
Signed-off-by: Dario Faggioli dario.faggi...@citrix.com
Cc: Jim Fehlig jfeh...@suse.com
Cc: Ian Jackson ian.jack...@eu.citrix.com
Cc: Martin Kletzander mklet...@redhat.com
---
Changes from v1:
* taking care of libxl_get_max_nodes() too
---
src/libxl/libxl_driver.c | 15
On Wed, Dec 18, 2013 at 04:16:17PM +, Daniel P. Berrange wrote:
Old versions of CIL did not understand the 'bool' data type,
but at least 1.7.3 does now cope. We can remove the old hack
which redefined bool and no longer compiles successfully.
Signed-off-by: Daniel P. Berrange
On 12/07/2012 12:29 PM, Peter Krempa wrote:
When restarting CPUs after an external snapshot, the restarting function
was called without the appropriate async job type. This caused that a
new sync job wasn't created and allowed races in the monitor.
---
src/qemu/qemu_driver.c | 2 +-
1 file
On 12/12/2012 04:45 PM, Daniel P. Berrange wrote:
Many years ago when the QEMU driver was first written for libvirt the
daemon was single threaded, so we didn't have to worry about locking
at all. Then we introduced threads and so we had to have locking.
Since then locking has been done at
On 12/17/2012 12:22 PM, Peter Krempa wrote:
From: Ken ICHIKAWA ichikawa@jp.fujitsu.com
This patch fixes a problem that vendor_id attribute can not be defined
when fallback attribute is not defined.
If I define domain xml like below:
domain
cpu
model
On 12/17/2012 12:22 PM, Peter Krempa wrote:
The field was not freed from the cpu definition.
---
src/conf/cpu_conf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c
index 6157ed7..7528980 100644
--- a/src/conf/cpu_conf.c
+++
On 12/17/2012 12:22 PM, Peter Krempa wrote:
---
src/conf/cpu_conf.c | 22 --
1 file changed, 12 insertions(+), 10 deletions(-)
ACK,
Martin
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 12/17/2012 12:22 PM, Peter Krempa wrote:
This patch simplifies the code that parses the fallback and vendor_id
attributes from the domain xml cpu definition.
Changes done:
- free temp variables in the cleanup section instead of local use
- remove checking for presence of the attribute to
This patch fixes just the word Affinites to Affinities (it's really
painful to search in TAGS without being able to find the right
function).
---
src/libxl/libxl_driver.c | 4 ++--
src/qemu/qemu_process.c | 8
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git
My cleanup branch got up to 5 commits so in order to get rid of it,
I'm sending it. Some of them could be most probably pushed as
trivial, but since some are older (even though the commit date is
new), I'm sending it in the pack together.
Martin Kletzander (5):
fix typo in the word affinities
On few places there are too many levels of indentation when some of
them can be fixed with negating the option they are in or omitting
useless condition altogether.
---
src/conf/domain_conf.c | 65 +-
1 file changed, 32 insertions(+), 33
Removing exempli gratia when there should be dots afterwards, also
Uppercase letter should be present when starting a sentence. Sorry
for the double line in the last hunk even though it's just adding a
word, but it would require to have new sentence starting on a newline
and that didn't seem very
We can use VIR_REALLOC_N with NULL pointer, which behaves the same way
as VIR_ALLOC_N in that case, so no need for a condition that's
checking if some data are allocated already.
---
I tried to find other parts of the code similar to this, so I can do a
full cleanup for the whole repository, so
Commit 60b176c3d0f0d5037acfa5e27c7753f657833a0b introduced a bug that
when editing an XML with cputune similar to this:
...
vcpu placement='static' current='1'2/vcpu
cputune
vcpupin vcpu=1 cpuset=0/
/cputune
...
results in formatted XML that looks like this:
...
vcpu
On 12/18/2012 04:01 AM, Osier Yang wrote:
On 2012年12月17日 23:17, Martin Kletzander wrote:
Commit 60b176c3d0f0d5037acfa5e27c7753f657833a0b introduced a bug that
when editing an XML with cputune similar to this:
Thanks for fixing this.
...
vcpu placement='static' current='1'2/vcpu
On 12/18/2012 04:29 AM, Osier Yang wrote:
On 2012年12月17日 23:17, Martin Kletzander wrote:
Removing exempli gratia when there should be dots afterwards, also
Uppercase letter should be present when starting a sentence. Sorry
for the double line in the last hunk even though it's just adding
On 12/18/2012 12:39 PM, Osier Yang wrote:
On 2012年12月18日 19:20, Martin Kletzander wrote:
On 12/18/2012 04:01 AM, Osier Yang wrote:
On 2012年12月17日 23:17, Martin Kletzander wrote:
Commit 60b176c3d0f0d5037acfa5e27c7753f657833a0b introduced a bug that
when editing an XML with cputune similar
On 01/15/2013 07:12 PM, John Ferlan wrote:
Check status when attempting to set SO_REUSEADDR flag on outgoing connection
On failure, VIR_WARN(), but continue to connect. This code path is on the
sender side where the setting is just a hint and would only take effect if
the sender is overflowed
On 01/15/2013 07:12 PM, John Ferlan wrote:
---
src/util/virbuffer.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/util/virbuffer.c b/src/util/virbuffer.c
index 969dcbf..693e4b2 100644
--- a/src/util/virbuffer.c
+++ b/src/util/virbuffer.c
@@ -153,10 +153,9
On 01/15/2013 07:12 PM, John Ferlan wrote:
---
tools/virsh.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index eadc519..669c9c9 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -536,6 +536,8 @@
On 01/15/2013 07:12 PM, John Ferlan wrote:
---
src/xen/xend_internal.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c
index 959225c..038dd1e 100644
--- a/src/xen/xend_internal.c
+++ b/src/xen/xend_internal.c
@@
On 01/19/2013 12:06 AM, Peter Krempa wrote:
---
src/conf/capabilities.c | 43 +--
1 file changed, 25 insertions(+), 18 deletions(-)
diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c
index 365c511..0d2512e 100644
---
On 01/19/2013 12:06 AM, Peter Krempa wrote:
---
docs/schemas/basictypes.rng | 6 ++
docs/schemas/domaincommon.rng | 5 -
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/docs/schemas/basictypes.rng b/docs/schemas/basictypes.rng
index 38cab16..8e44e8d 100644
---
On 01/19/2013 12:06 AM, Peter Krempa wrote:
This will allow storing additional topology data in the NUMA topology
definition.
This patch changes the storage type and fixes fallback of the change
across the drivers using it.
This patch also changes semantics of adding new NUMA cell
On 01/21/2013 02:10 PM, Peter Krempa wrote:
On 01/21/13 12:31, Martin Kletzander wrote:
[...]
Because this and [PATCH 5/5] both require [PATCH 3/5] to be in, I'm
cond-ACKing this patch with the same condition as [PATCH 3/5].
I assume that you mean patch 2/5 :)
Sorry, of course I meant
On 01/19/2013 12:06 AM, Peter Krempa wrote:
This patch adds data gathering to the NUMA gathering files and adds
support for outputting the data. The test driver and xend driver need to
be adapted to fill sensible data to the structure.
---
src/conf/capabilities.c | 14 +++--
On 01/21/2013 10:10 PM, Peter Krempa wrote:
Forbid the names to match the loading procedure of snapshots.
---
src/qemu/qemu_driver.c | 24 +---
1 file changed, 17 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index
On 01/23/2013 12:18 AM, Peter Krempa wrote:
On 01/22/13 23:25, Eric Blake wrote:
On 01/22/2013 02:30 PM, Peter Krempa wrote:
The documentation comment virBitmapParse didn't document the @sep
parameter.
---
src/util/virbitmap.c | 16 +---
1 file changed, 9 insertions(+), 7
On 12/14/2012 05:03 PM, Christophe Fergeau wrote:
This guarantees that the string will be nul-terminated. Coverity
warned about this issue.
---
libvirt-gobject/libvirt-gobject-connection.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 12/14/2012 05:03 PM, Christophe Fergeau wrote:
fetch_list implementations in libvirt-gobject-connection.c and
libvirt-gobject-storage-pool.c can misbehave in error situations
or when the call is cancelled:
- when the call is cancelled, 'lst' will be NULL and 'n' non-0 so
we'll try to
When doing checks with automake, there are 'testname.trs' files left
behind, that might or might not be usable, however these show up in
'git status' even though we definitely don't want them to be tracked
in the repository'. Automake adds the '--trs-files' option by default
since commit
Adding dots inside exempli gratia where missing. While on that, I
took the liberty of changing it where found with simple grep.
---
v2:
- I git grep'd the whole repo and fixed it everywhere, not just in
HACKING
---
HACKING | 10 +-
docs/firewall.html.in | 2 +-
Commit 60b176c3d0f0d5037acfa5e27c7753f657833a0b introduced a bug that
when editing an XML with cputune similar to this:
...
vcpu placement='static' current='1'2/vcpu
cputune
vcpupin vcpu=1 cpuset=0/
/cputune
...
results in formatted XML that looks like this:
...
vcpu
This is basically v2 of long lost [1] with fixes for what Osier found
out and with one one-liner patch added.
[1] http://www.redhat.com/archives/libvir-list/2012-December/msg01043.html
Martin Kletzander (3):
conf: Don't format cputune element when not needed
docs: aesthetical cleanups
On 01/29/2013 08:49 PM, Eric Blake wrote:
On 01/29/2013 09:12 AM, Martin Kletzander wrote:
This is basically v2 of long lost [1] with fixes for what Osier found
out and with one one-liner patch added.
[1] http://www.redhat.com/archives/libvir-list/2012-December/msg01043.html
Martin
After one last-minute change, only HACKING was updated and not
hacking.html.in, so this patch synchronizes that.
---
Pushed under the 'trivial' rule.
---
docs/hacking.html.in | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/docs/hacking.html.in b/docs/hacking.html.in
Hello everyone.
Trying to create new interface for the libvirt daemon, mainly for
connection monitoring, I came across few things I'd like to
propose/discuss. This interface will be used to manage active
connections of the daemon (list/kill) and other until-now impossible
things (e.g. changing
On 02/04/2013 09:23 AM, Hu Tao wrote:
---
src/driver.h | 4 ---
src/libvirt.c | 70
+-
src/libvirt_internal.h | 2 --
3 files changed, 69 insertions(+), 7 deletions(-)
diff --git a/src/driver.h b/src/driver.h
index
QEMU is fully capable of handling VDI images and we just refuse to
work with them. As qemu-img knows and supports this, there should be
no problem with this addition.
This is of course, just basic functionality, without searching for any
backing files, etc.
---
It's very much possible that I
On 02/04/2013 04:53 PM, Daniel P. Berrange wrote:
On Mon, Feb 04, 2013 at 04:46:53PM +0100, Martin Kletzander wrote:
[...]
+
+/* not fully supported, but qemu knows it, so we should be able to
+ * handle this at least basically */
+[VIR_STORAGE_FILE_VDI] = { NULL, .vdi
On 02/04/2013 07:03 PM, Daniel P. Berrange wrote:
On Mon, Feb 04, 2013 at 06:53:34PM +0100, Martin Kletzander wrote:
On 02/04/2013 04:53 PM, Daniel P. Berrange wrote:
On Mon, Feb 04, 2013 at 04:46:53PM +0100, Martin Kletzander wrote:
[...]
+
+/* not fully supported, but qemu knows it, so
Some files have the magic shifted to some offset other than 0, so we
have to support that. I also cleaned up some lines to be more
readable and added missing magic for iso file format.
---
src/util/virstoragefile.c | 55 ++-
1 file changed, 31
This is basically v2 for:
https://www.redhat.com/archives/libvir-list/2013-February/msg00151.html
Very small series, so there's not much more to say ;)
Martin Kletzander (2):
Support shifted magic in storage files
Add basic support for VDI images
src/util/virstoragefile.c | 70
QEMU is fully capable of handling VDI images and we just refuse to
work with them. As qemu-img knows and supports this, there should be
no problem with this addition.
This is of course, just basic functionality, without searching for any
backing files, etc.
---
src/util/virstoragefile.c | 15
On 02/04/2013 11:06 PM, Eric Blake wrote:
On 02/04/2013 02:49 PM, Martin Kletzander wrote:
QEMU is fully capable of handling VDI images and we just refuse to
work with them. As qemu-img knows and supports this, there should be
no problem with this addition.
This is of course, just basic
On 02/05/2013 01:56 PM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The previous change to the generator, changed too much - only
the functions are in 'virerror.c', the constants remained in
'virerror.h' which could not be renamed for API compat reasons.
Add a
On 02/07/2013 06:46 PM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
To enable locking to be introduced to the security manager
objects later, turn virSecurityManager into a virObjectLockable
class
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
Since the BQDL has been broken, this patch tries to cleanup some
information about it in various comments.
---
To be applied after Dan's patch [1] which removes unnecessary
qemuDriverLocks.
[1] https://www.redhat.com/archives/libvir-list/2013-February/msg00641.html
src/qemu/THREADS.txt |
On 02/07/2013 05:51 PM, Michal Privoznik wrote:
---
tools/virsh-domain-monitor.c | 86 ++-
tools/virsh-domain.c | 581
+++
tools/virsh-host.c | 95 +--
tools/virsh-interface.c | 114 ++---
tools/virsh-network.c
On 02/07/2013 05:51 PM, Michal Privoznik wrote:
I wonder if there's any syntax-check rule that we could use
to enforce this style.
AFAIK, gcc handles '-Wno-old-initializer', but that's the exact
opposite. And 'gcc --help=warnings' doesn't have a clue about that, so
nothing else found. Hope
On 02/12/2013 04:17 PM, Daniel P. Berrange wrote:
On Tue, Feb 12, 2013 at 08:14:40AM -0700, Eric Blake wrote:
On 02/12/2013 05:52 AM, Martin Kletzander wrote:
Since the BQDL has been broken, this patch tries to cleanup some
information about it in various comments.
---
To be applied after
On 02/07/2013 05:51 PM, Michal Privoznik wrote:
I wonder if there's any syntax-check rule that we could use
to enforce this style.
Michal Privoznik (13):
virsh: Switch to c99 initialization of vshCmdDef
virsh.c: Switch to c99 initialization of vshCmdInfo
virsh-domain-monitor.c:
On 02/17/2013 11:50 AM, Alon Levy wrote:
Hi Martin,
On 02/04/2013 04:16 PM, Christophe Fergeau wrote:
QXL devices have an associated 'revision' which is raised when
new features have been introduced which would break migration
to older versions. This commit makes it possible to set this
On 02/18/2013 12:38 PM, Daniel P. Berrange wrote:
On Mon, Feb 18, 2013 at 12:29:03PM +0100, Michal Privoznik wrote:
The field is there to store the original label of device,
so we can restore it when domain is shutting down.
---
src/conf/domain_conf.c | 20 +++-
The defines QEMU_VNC_PORT_MIN and QEMU_VNC_PORT_MAX were used to find
free port when starting domains. As this was hardcoded to the same
ports as default VNC servers, there were races with these other
programs. This patch includes the possibility to change the default
starting port as well as the
On 05/22/2012 07:22 PM, Dave Allan wrote:
On Tue, May 22, 2012 at 09:09:55AM -0600, Eric Blake wrote:
On 05/22/2012 09:00 AM, Dave Allan wrote:
On Tue, May 22, 2012 at 04:10:03PM +0200, Martin Kletzander wrote:
The defines QEMU_VNC_PORT_MIN and QEMU_VNC_PORT_MAX were used to find
free port
On 04/20/2012 09:27 AM, Wen Congyang wrote:
dump-guest-memory is a new dump mechanism, and it can work when the
guest uses host devices. This patch adds a API to use this new
monitor command.
---
src/qemu/qemu_monitor.c | 38 ++
On 05/23/2012 11:17 AM, Wen Congyang wrote:
At 05/23/2012 04:56 PM, Martin Kletzander Wrote:
On 04/20/2012 09:27 AM, Wen Congyang wrote:
dump-guest-memory is a new dump mechanism, and it can work when the
guest uses host devices. This patch adds a API to use this new
monitor command
On 05/25/2012 12:12 PM, Wen Congyang wrote:
If we lock the qemu_driver, we should call qemuDomainObjBeginJobWithDriver()
not qemuDomainObjBeginJob().
---
src/qemu/qemu_driver.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/qemu/qemu_driver.c
accel3d was specified twice, the second one is obviously accel2d
---
Pushed under trivial rule.
docs/formatdomain.html.in |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 3875167..5d4cc36 100644
---
When getting number of CPUs the host has assigned, there was always
number 1 returned. Even though all lxc domains with no pinning
launched by libvirt run on all pCPUs (by default, no matter what's the
number), we should at least return the same number as the user
specified when creating the
I added libvirt_qemu_probes.h into BUILT_SOURCES. That makes it
generated, but most probably it is not the clearest way how to do
that, but it fixes the build.
---
Feel free to clean this, but for the time being, I'm pushing this as a
build breaker.
src/Makefile.am |1 +
1 files changed, 1
On 05/29/2012 06:39 PM, Eric Blake wrote:
On 05/29/2012 01:12 AM, Martin Kletzander wrote:
When getting number of CPUs the host has assigned, there was always
number 1 returned. Even though all lxc domains with no pinning
launched by libvirt run on all pCPUs (by default, no matter what's
On 05/30/2012 03:02 PM, Eric Blake wrote:
On 05/30/2012 06:43 AM, Eric Blake wrote:
On 05/30/2012 04:15 AM, Martin Kletzander wrote:
I added libvirt_qemu_probes.h into BUILT_SOURCES. That makes it
generated, but most probably it is not the clearest way how to do
that, but it fixes the build
This series cleans up the libvirt-snmp codebase with some visual
(whitespaces) and semantic (memory leaks) cleanups.
Martin Kletzander (2):
cleanup: whitespaces removed from ends of lines
Stop event thread on server stop
autogen.sh |4 +-
docs
---
autogen.sh |4 +-
docs/libvirtMib_subagent.pod |4 +-
src/LIBVIRT-MIB.txt|4 +-
src/libvirtGuestTable-README-FIRST.txt |6 +-
When C-c is sent to the process, the main thread (server) receives it
and sets keep_running to 0, but the second thread is still
running. Also, the second thread is not cleaned up after
pthread_join() or pthread_destroy().
This patch adds the cleanup function before all exit points of the
program
501 - 600 of 5738 matches
Mail list logo
