Re: [libvirt] [PATCH2 2/1] build: fix testing of augeas files in VPATH builds

2012-05-30 Thread Martin Kletzander
On 05/30/2012 12:03 AM, Eric Blake wrote: Without this fix, a VPATH build (such as used by ./autobuild.sh) fails with messages like: make[3]: Entering directory `/home/remote/eblake/libvirt-tmp2/build/daemon' ../../build-aux/augeas-gentest.pl libvirtd.conf ../../daemon/test_libvirtd.aug.in

Re: [libvirt] [PATCH] build: silence warning from autoconf

2012-05-30 Thread Martin Kletzander
On 05/29/2012 04:18 PM, Eric Blake wrote: Autoconf 2.60 and later insist on using ${datarootdir}, rather than the derived ${datadir} (although the latter defaults to the former, it is possible to set configure arguments so that they differ): config.status: creating libvirt.pc config.status:

Re: [libvirt] [PATCH 3/1] build: use same perl binary throughout build

2012-05-30 Thread Martin Kletzander
On 05/30/2012 12:03 AM, Eric Blake wrote: Some of our rules used $(PERL), while others used 'perl'. Always using the variable allows a developer to point to a different (often better) perl than the default one found on $PATH. * daemon/Makefile.am ($(srcdir)/remote_dispatch.h):

Re: [libvirt] [PATCH 3/1] build: use same perl binary throughout build

2012-05-30 Thread Martin Kletzander
On 05/30/2012 01:05 AM, Eric Blake wrote: On 05/29/2012 04:03 PM, Eric Blake wrote: Some of our rules used $(PERL), while others used 'perl'. Always using the variable allows a developer to point to a different (often better) perl than the default one found on $PATH. * daemon/Makefile.am

Re: [libvirt] [snmp PATCH 2/2] Stop event thread on server stop

2012-05-30 Thread Martin Kletzander
On 05/30/2012 04:53 PM, Michal Privoznik wrote: On 30.05.2012 15:29, Martin Kletzander wrote: When C-c is sent to the process, the main thread (server) receives it and sets keep_running to 0, but the second thread is still running. Also, the second thread is not cleaned up after pthread_join

[libvirt] [PATCH] Fixes for check and rpm builds without sanlock (and qemu)

2012-05-30 Thread Martin Kletzander
Apart from the non-sanlock check build, there is also a little fix for qemu (EXTRA_DIST had qemu.conf and others inside even if the build was supposed to be without qemu). --- libvirt.spec.in |5 + src/Makefile.am |6 +- 2 files changed, 10 insertions(+), 1 deletions(-) diff

Re: [libvirt] [PATCH2 2/1] build: fix testing of augeas files in VPATH builds

2012-05-30 Thread Martin Kletzander
On 05/30/2012 05:34 PM, Eric Blake wrote: On 05/30/2012 08:39 AM, Martin Kletzander wrote: On 05/30/2012 12:03 AM, Eric Blake wrote: Without this fix, a VPATH build (such as used by ./autobuild.sh) fails with messages like: make[3]: Entering directory `/home/remote/eblake/libvirt-tmp2/build

Re: [libvirt] [PATCH] Fixes for check and rpm builds without sanlock (and qemu)

2012-05-30 Thread Martin Kletzander
On 05/30/2012 05:50 PM, Eric Blake wrote: On 05/30/2012 09:35 AM, Martin Kletzander wrote: Apart from the non-sanlock check build, there is also a little fix for qemu (EXTRA_DIST had qemu.conf and others inside even if the build was supposed to be without qemu). --- libvirt.spec.in |5

[libvirt] [PATCH] tools: make virt-pki-validate work with acls and xattrs

2012-05-31 Thread Martin Kletzander
This patch makes virt-pki-validate work with certificates that have acl or xattr set. Otherwise it failing due to wrong permissions. --- tools/virt-pki-validate.in |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/virt-pki-validate.in b/tools/virt-pki-validate.in

Re: [libvirt] [PATCH] tools: make virt-pki-validate work with acls and xattrs

2012-05-31 Thread Martin Kletzander
On 05/31/2012 04:49 PM, Eric Blake wrote: On 05/31/2012 03:02 AM, Martin Kletzander wrote: This patch makes virt-pki-validate work with certificates that have acl or xattr set. Otherwise it failing due to wrong permissions. --- tools/virt-pki-validate.in |6 -- 1 files changed, 4

Re: [libvirt] [Fwd: error: this function is not supported by the connection driver : virConnectNumOfStoragePool]

2012-06-01 Thread Martin Kletzander
On 05/31/2012 08:33 AM, Onkar wrote: Hello All, Any idea on this issue ? Regards, Onkar Forwarded Message From: Onkar kern...@gmail.com To: libvir-list libvir-list@redhat.com Subject: error: this function is not supported by the connection driver :

Re: [libvirt] [PATCH] Fixes for check and rpm builds without sanlock (and qemu)

2012-06-04 Thread Martin Kletzander
On 06/04/2012 09:54 AM, Alex Jia wrote: Martin help me find a root reason, I don't know when the src/locking/test_libvirt_sanlock.aug.in is deleted from my git repo, in fact, I have never manually done it by myself except running 'make', 'make clean' or 'make rpm' ago, it's weird for me.

[libvirt] [PATCH] qemu: better detection of crashed domains

2012-06-06 Thread Martin Kletzander
When libvirtd is started and there is an unusable/not-connectable leftover from earlier started machine, it's more reasonable to say that the machine crashed if we know it was started with -no-shutdown. This patch fixes that and also changes the other result (when machine was started without

Re: [libvirt] [PATCH] qemu: better detection of crashed domains

2012-06-07 Thread Martin Kletzander
On 06/06/2012 05:22 PM, Eric Blake wrote: On 06/06/2012 09:03 AM, Martin Kletzander wrote: When libvirtd is started and there is an unusable/not-connectable leftover from earlier started machine, it's more reasonable to say that the machine crashed if we know it was started with -no-shutdown

Re: [libvirt] pointless time-consuming test 'virsh-all'

2012-06-07 Thread Martin Kletzander
On 06/07/2012 05:32 AM, Eric Blake wrote: The command 'make -C tests check' takes forever, because it is calling this lengthy virsh command and ignoring the failures: $ time tools/virsh -c test:///default connect error: Failed to connect to the hypervisor error: Failed to connect socket to

Re: [libvirt] pointless time-consuming test 'virsh-all'

2012-06-07 Thread Martin Kletzander
On 06/07/2012 02:22 PM, Eric Blake wrote: On 06/07/2012 02:24 AM, Martin Kletzander wrote: On 06/07/2012 05:32 AM, Eric Blake wrote: The command 'make -C tests check' takes forever, because it is calling this lengthy virsh command and ignoring the failures: $ time tools/virsh -c test

Re: [libvirt] pointless time-consuming test 'virsh-all'

2012-06-08 Thread Martin Kletzander
On 06/07/2012 04:37 PM, Eric Blake wrote: On 06/07/2012 06:31 AM, Martin Kletzander wrote: $ time tools/virsh -c test:///default connect error: Failed to connect to the hypervisor error: Failed to connect socket to '/run/user/eblake/libvirt/libvirt-sock': No such file or directory Odd

Re: [libvirt] libvirt modification

2012-06-12 Thread Martin Kletzander
On 06/11/2012 05:22 PM, Patrick Raad wrote: Hello, I am not that expert in development, but I am working on a project for migrating VM between hosts and I need to add a function to libvirt in order to send a certain message. Hi, I don't know what kind of message you want to send nor how

Re: [libvirt] [PATCH 2/3 v5] qemu: allow the client to choose the vmcore's format

2012-06-13 Thread Martin Kletzander
On 06/12/2012 05:06 AM, Wen Congyang wrote: This patch updates qemu driver to allow the client to choose the vmcore's format: memory only or including device state. --- include/libvirt/libvirt.h.in |1 + src/qemu/qemu_capabilities.c |5 +++ src/qemu/qemu_capabilities.h |1 +

Re: [libvirt] [PATCH 1/3 v5] qemu: implement qemu's dump-guest-memory

2012-06-13 Thread Martin Kletzander
On 06/12/2012 05:04 AM, Wen Congyang wrote: dump-guest-memory is a new dump mechanism, and it can work when the guest uses host devices. This patch adds a API to use this new monitor command. We will always use json mode if qemu's version is = 0.15, so I don't implement the API for text mode.

Re: [libvirt] [PATCH 3/3 v5] virsh: allow the user to specify vmcore's format

2012-06-13 Thread Martin Kletzander
On 06/12/2012 05:07 AM, Wen Congyang wrote: Add a new parameter --memory-only for 'virsh dump' command. So the user can decide the vmcore's format. --- tools/virsh.c |3 +++ tools/virsh.pod |5 - 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c

Re: [libvirt] [PATCH 2/3 v5] qemu: allow the client to choose the vmcore's format

2012-06-13 Thread Martin Kletzander
On 06/13/2012 02:57 PM, Martin Kletzander wrote: On 06/12/2012 05:06 AM, Wen Congyang wrote: This patch updates qemu driver to allow the client to choose the vmcore's format: memory only or including device state. --- include/libvirt/libvirt.h.in |1 + src/qemu/qemu_capabilities.c

[libvirt] [PATCH 2.5/4] qemu: add one more check for remote_display_port options

2012-06-18 Thread Martin Kletzander
To be squashed into PATCH 2/4 --- Sorry for the confusion, but after I sent the series, I realized that this one check is missing. src/qemu/qemu_conf.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index

Re: [libvirt] [PATCH 2/4] docs: fix 404 page when fetched from different location

2012-06-21 Thread Martin Kletzander
On 06/21/2012 12:24 PM, Daniel P. Berrange wrote: On Thu, Jun 21, 2012 at 12:18:12PM +0200, Martin Kletzander wrote: Error 404 page had relative paths specified for both the image and stylesheets which caused a problem when requested URL included a subfolder (e.g. http://libvirt.org/asdf/asdf

Re: [libvirt] [PATCH 0/4] qemu: configurable port boundaries for remote displays

2012-07-17 Thread Martin Kletzander
bump? On 06/18/2012 01:10 PM, Martin Kletzander wrote: This series introduces a possibility to change default minimal and maximal port numbers that are used to specify a remote display port for both VNC and SPICE. Because the code was a bit messy, PATCH 1/4 cleans up few things needed

Re: [libvirt] [PATCH 16/23] Replace use of PHYP_ERROR with virReportError

2012-07-20 Thread Martin Kletzander
On 07/18/2012 08:40 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Update the Power-Hypervisor driver to use virReportError instead of the PHYP_ERROR custom macro Signed-off-by: Daniel P. Berrange berra...@redhat.com --- cfg.mk |1 -

Re: [libvirt] [PATCH] qemu: Set swap_hard_limit before hard_limit

2012-07-23 Thread Martin Kletzander
On 07/12/2012 11:37 AM, Osier Yang wrote: On 2012年07月12日 17:19, Hu Tao wrote: On Thu, Jul 12, 2012 at 05:03:52PM +0800, Osier Yang wrote: Setting hard_limit larger than previous swap_hard_limit must fail, it's not that good if one wants to change the swap_hard_limit and hard_limit together.

[libvirt] [PATCH] fixed segfault in virauth

2012-07-23 Thread Martin Kletzander
No check for conn-uri being NULL in virAuthGetConfigFilePath (valid state) made the client segfault. This happens with fresh defalt VDSM configuration for example. The check ought to be enough as conn-uri being NULL is valid in later code. --- src/util/virauth.c | 20 +++- 1

[libvirt] [PATCH] virsh: fixed domdisplay command

2012-07-23 Thread Martin Kletzander
The 'domdisplay' command didn't properly evaluate '--include-password' option. --- tools/virsh.c | 35 +++ 1 files changed, 23 insertions(+), 12 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 5888d6c..e0765ba 100644 --- a/tools/virsh.c +++

Re: [libvirt] [PATCH] virsh: fixed domdisplay command

2012-07-24 Thread Martin Kletzander
On 07/23/2012 09:42 PM, Daniel P. Berrange wrote: On Mon, Jul 23, 2012 at 02:25:23PM -0500, Doug Goldstein wrote: On Mon, Jul 23, 2012 at 1:51 PM, Martin Kletzander mklet...@redhat.com wrote: The 'domdisplay' command didn't properly evaluate '--include-password' option. --- tools/virsh.c

Re: [libvirt] [PATCH] virsh: fixed domdisplay command

2012-07-24 Thread Martin Kletzander
On 07/23/2012 09:42 PM, Eric Blake wrote: On 07/23/2012 12:51 PM, Martin Kletzander wrote: The 'domdisplay' command didn't properly evaluate '--include-password' option. --- tools/virsh.c | 35 +++ 1 files changed, 23 insertions(+), 12 deletions

Re: [libvirt] [PATCH] virsh: fixed domdisplay command

2012-07-24 Thread Martin Kletzander
On 07/24/2012 09:58 AM, Daniel P. Berrange wrote: On Tue, Jul 24, 2012 at 09:16:38AM +0200, Martin Kletzander wrote: On 07/23/2012 09:42 PM, Daniel P. Berrange wrote: On Mon, Jul 23, 2012 at 02:25:23PM -0500, Doug Goldstein wrote: On Mon, Jul 23, 2012 at 1:51 PM, Martin Kletzander mklet

[libvirt] [PATCH v2] virsh: fixed domdisplay command

2012-07-24 Thread Martin Kletzander
The 'domdisplay' command didn't properly evaluate '--include-password' option. --- v2: - switched to using 'flags' - kept the second condition in place - fixed indentation after virAsprintf tools/virsh.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git

[libvirt] [PATCH v2] fixed SegFault in virauth

2012-07-24 Thread Martin Kletzander
No check for conn-uri being NULL in virAuthGetConfigFilePath (valid state) made the client segfault. This happens for example with these settings: - no virtualbox driver installed (modifies conn-uri) - no default URI set (VIRSH_DEFAULT_CONNECT_URI=, LIBVIRT_DEFAULT_URI=, uri_default=) -

Re: [libvirt] [PATCH v2] virsh: fixed domdisplay command

2012-07-24 Thread Martin Kletzander
On 07/24/2012 04:49 PM, Peter Krempa wrote: On 07/24/12 16:06, Martin Kletzander wrote: The 'domdisplay' command didn't properly evaluate '--include-password' option. --- v2: - switched to using 'flags' - kept the second condition in place - fixed indentation after virAsprintf

Re: [libvirt] [PATCH v2] virsh: fixed domdisplay command

2012-07-25 Thread Martin Kletzander
On 07/24/2012 06:09 PM, Doug Goldstein wrote: On Tue, Jul 24, 2012 at 9:06 AM, Martin Kletzander mklet...@redhat.com wrote: The 'domdisplay' command didn't properly evaluate '--include-password' option. --- v2: - switched to using 'flags' - kept the second condition in place - fixed

Re: [libvirt] [PATCH v2] fixed SegFault in virauth

2012-07-25 Thread Martin Kletzander
On 07/24/2012 11:40 PM, Eric Blake wrote: On 07/24/2012 08:08 AM, Martin Kletzander wrote: No check for conn-uri being NULL in virAuthGetConfigFilePath (valid state) made the client segfault. This happens for example with these settings: - no virtualbox driver installed (modifies conn-uri

[libvirt] [PATCH 1/1] Added check for maximum number of vcpus exceeding topology limit

2012-01-11 Thread Martin Kletzander
Earlier, when the number of vcpus was greater than the topology allowed, libvirt didn't raise an error and continued, resulting in running qemu with parameters making no sense. Even though qemu did not report any error itself, the number of vcpus was set to maximum allowed by the topology. ---

[libvirt] [PATCH v2 1/1] Added check for maximum number of vcpus exceeding topology limit

2012-01-12 Thread Martin Kletzander
Earlier, when the number of vcpus was greater than the topology allowed, libvirt didn't raise an error and continued, resulting in running qemu with parameters making no sense. Even though qemu did not report any error itself, the number of vcpus was set to maximum allowed by the topology. --- v2:

Re: [libvirt] cpu models for AMD Bulldozer and Sandy Bridge

2012-01-15 Thread Martin Kletzander
On 01/15/12 15:48, Shahar Havivi wrote: Hi, what are the cpu models for AMD Bulldozer and Sandy Bridge? There are BZs for that: - Sandy Bridge -- https://bugzilla.redhat.com/show_bug.cgi?id=761005 - AMD Bulldozer -- https://bugzilla.redhat.com/show_bug.cgi?id=767364 The latter is still

[libvirt] [PATCH] Fixed dumxml of iotune parameters

2012-01-17 Thread Martin Kletzander
The output of dumpxml for iotune settings was misformatted, this patch just adds missing newlines. --- src/conf/domain_conf.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d474551..f84e76d 100644 ---

[libvirt] [PATCH] Permission change for systemtap examples.

2012-01-17 Thread Martin Kletzander
Execute bit on *.stp files in examples/systemtap/ caused dependency when building RPM packages. Disabling execute permission should help the auto dependency resolver to see that systemtap is not needed. --- 0 files changed, 0 insertions(+), 0 deletions(-) mode change 100755 = 100644

[libvirt] [PATCH] Added capability checking for block iotune setting.

2012-01-18 Thread Martin Kletzander
There was missing capability for blkiotune and thus specifying these settings caused libvirt to run qemu with invalid parameters and then reporting qemu error instead of the standard libvirt one. --- src/qemu/qemu_capabilities.c |6 ++ src/qemu/qemu_capabilities.h |2 ++

Re: [libvirt] [PATCH] Added capability checking for block iotune setting.

2012-01-18 Thread Martin Kletzander
On 01/18/12 17:13, Eric Blake wrote: On 01/18/2012 09:01 AM, Martin Kletzander wrote: There was missing capability for blkiotune and thus specifying these settings caused libvirt to run qemu with invalid parameters and then reporting qemu error instead of the standard libvirt one. --- src

[libvirt] [PATCH v2] Added capability checking for block iotune setting.

2012-01-18 Thread Martin Kletzander
There was missing capability for blkiotune and thus specifying these settings caused libvirt to run qemu with invalid parameters and then reporting qemu error instead of the standard libvirt one. The support for blkiotune setting was added in upstream qemu repo under commit

[libvirt] [PATCH 2/2] Added RSS reporting

2012-01-23 Thread Martin Kletzander
Added RSS information gathering into qemuMemoryStats into qemu driver and the reporting into virsh dommemstat. --- include/libvirt/libvirt.h.in |7 ++- src/qemu/qemu_driver.c | 21 + tools/virsh.c|2 ++ 3 files changed, 25 insertions(+), 5

[libvirt] [PATCH 1/2] Added RSS information gathering into qemudGetProcessInfo

2012-01-23 Thread Martin Kletzander
One more parameter added into the function parsing /proc/pid/stat and the call of the function is fixed as well. --- src/qemu/qemu_driver.c | 25 ++--- 1 files changed, 18 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

[libvirt] [PATCH 0/2] Added RSS reporting for qemu

2012-01-23 Thread Martin Kletzander
This patch enables reporting of Resident Set Size for qemu process. It is available through qemudDomainMemoryStats and qemudGetProcessInfo. The reporting is also added into virsh dommemstat command. Martin Kletzander (2): Added RSS information gathering into qemudGetProcessInfo Added RSS

[libvirt] [PATCH v2 1/2] Added RSS information gathering into qemudGetProcessInfo

2012-01-24 Thread Martin Kletzander
One more parameter added into the function parsing /proc/pid/stat and the call of the function is fixed as well. --- v2: - correction of the format in fscanf in qemudGetProcessInfo src/qemu/qemu_driver.c | 25 ++--- 1 files changed, 18 insertions(+), 7 deletions(-) diff

[libvirt] [PATCH v2 2/2] Added RSS reporting

2012-01-24 Thread Martin Kletzander
Added RSS information gathering into qemuMemoryStats into qemu driver and the reporting into virsh dommemstat. --- v2: - fixed sign for the ret variable (can be negative) include/libvirt/libvirt.h.in |7 ++- src/qemu/qemu_driver.c | 23 ++- tools/virsh.c

[libvirt] [PATCH] Support for cpu64-rhel* qemu cpu models

2012-01-30 Thread Martin Kletzander
In qemu there are 2 cpu models (cpu64-rhel5 and cpu64-rhel6) not supported by libvirt. This patch adds the support with the flags specifications from /usr/share/qemu-kvm/cpu-model/cpu-x86_64.conf --- src/cpu/cpu_map.xml | 94 +++ 1 files changed,

[libvirt] [PATCH v2] Support for cpu64-rhel* qemu cpu models

2012-01-30 Thread Martin Kletzander
In qemu there are 2 cpu models (cpu64-rhel5 and cpu64-rhel6) not supported by libvirt. This patch adds the support with the flags specifications from /usr/share/qemu-kvm/cpu-model/cpu-x86_64.conf --- v2: - removed duplicated entries src/cpu/cpu_map.xml | 66

[libvirt] [PATCH v3] Support for cpu64-rhel* qemu cpu models

2012-01-30 Thread Martin Kletzander
In qemu there are 2 cpu models (cpu64-rhel5 and cpu64-rhel6) not supported by libvirt. This patch adds the support with the flags specifications from /usr/share/qemu-kvm/cpu-model/cpu-x86_64.conf --- v3: - fixed sse3 naming (it's 'pni' in the features) v2: - removed duplicated entries

[libvirt] [PATCH] Added missing memory reporting into python bindings

2012-02-03 Thread Martin Kletzander
Two types of memory stats were not reported by python bindings. This patch fixes both of them. --- python/libvirt-override.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/python/libvirt-override.c b/python/libvirt-override.c index 18849f8..289a9bb 100644 ---

[libvirt] [PATCH] Fixed connection definition for non-SELinux builds

2012-02-03 Thread Martin Kletzander
This patch fixes the access of variable con in two files where the variable was declared only on SELinux builds and thus the build failed without SELinux. It's a rather nasty fix but helps fix the build quickly and without any major changes to the code. --- src/lxc/lxc_container.c |2 ++

[libvirt] [PATCH] Fixed URI parsing

2012-02-09 Thread Martin Kletzander
Function virParseURI was added. This function is wrapper around xmlParseURI. In this wrapper we are fixing what doesn't seems to be fixed in libxml2 in the near future. The wrapper is written in such way that if anything gets fixed in libxml2, it'll still work. File changes: - src/util/xml.h

[libvirt] [PATCH] Cleanup of the quick dirty fix from last week

2012-02-09 Thread Martin Kletzander
I tried lots of different solutions and this seems like the most clean and readable one. --- src/lxc/lxc_container.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index e93fda5..c55f264 100644 ---

Re: [libvirt] [PATCH] Fixed URI parsing

2012-02-09 Thread Martin Kletzander
On 02/09/2012 04:38 PM, Laine Stump wrote: On 02/09/2012 09:43 AM, Martin Kletzander wrote: Function virParseURI was added. This function is wrapper around xmlParseURI. In this wrapper we are fixing what doesn't seems to be fixed in libxml2 in the near future. The wrapper is written

[libvirt] [PATCH v2] Cleanup of the quick dirty fix from last week

2012-02-10 Thread Martin Kletzander
Just a cleanup of commit 32f881c6c42f94da70a3782fe20a058fe3dc39cc. --- src/lxc/lxc_container.c | 17 +++-- 1 files changed, 11 insertions(+), 6 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index e93fda5..2282eb0 100644 --- a/src/lxc/lxc_container.c

Re: [libvirt] [PATCH v3] Support for cpu64-rhel* qemu cpu models

2012-02-10 Thread Martin Kletzander
On 01/30/2012 05:25 PM, Martin Kletzander wrote: In qemu there are 2 cpu models (cpu64-rhel5 and cpu64-rhel6) not supported by libvirt. This patch adds the support with the flags specifications from /usr/share/qemu-kvm/cpu-model/cpu-x86_64.conf Bump up, could somebody please have a look

Re: [libvirt] [PATCH] Fixed URI parsing

2012-02-13 Thread Martin Kletzander
On 02/09/2012 06:53 PM, Laine Stump wrote: The problems I can see with that: 1) That would require you to once again modify the server string in-place, but you can't rely on it still having the 2 extra bytes, so you would have to create a new string. Modifying the server is not a

[libvirt] RFC: Post-install behavior of libvirt(-client)

2012-02-14 Thread Martin Kletzander
Hello everyone, I have a small bug #786770 [1] assigned and I discussed this with few people from our team but I'm still not sure what should be the proper fix for this bug. To sumarize the bug, the problem described and discussed there [1] is that when there's a fresh installation of RHEL system

Re: [libvirt] RFC: Post-install behavior of libvirt(-client)

2012-02-15 Thread Martin Kletzander
On 02/15/2012 11:57 AM, Daniel P. Berrange wrote: On Tue, Feb 14, 2012 at 03:17:40PM -0700, Eric Blake wrote: On 02/14/2012 01:37 AM, Martin Kletzander wrote: Hello everyone, I have a small bug #786770 [1] assigned and I discussed this with few people from our team but I'm still not sure

Re: [libvirt] Support for older libxml2 [Was: [PATCH] Fixed URI parsing]

2012-02-15 Thread Martin Kletzander
On 02/13/2012 10:57 AM, Martin Kletzander wrote: But as I say, I think this is the worst option considering the real problem is with brackets around IPv6 in libxml2 and fixing it there would save us from dealing with lots of bugs. Let's suppose bug #624626 [1] will be fixed soon

Re: [libvirt] RFC: Post-install behavior of libvirt(-client)

2012-02-23 Thread Martin Kletzander
On 02/20/2012 06:55 PM, Eric Blake wrote: On 02/14/2012 03:17 PM, Eric Blake wrote: On 02/14/2012 01:37 AM, Martin Kletzander wrote: Hello everyone, I have a small bug #786770 [1] assigned and I discussed this with few people from our team but I'm still not sure what should be the proper

[libvirt] [PATCH v4] Support for cpu64-rhel* qemu cpu models

2012-02-24 Thread Martin Kletzander
In qemu there are 2 cpu models (cpu64-rhel5 and cpu64-rhel6) not supported by libvirt. This patch adds the support with the flags specifications from /usr/share/qemu-kvm/cpu-model/cpu-x86_64.conf The only difference is that AMD-specific features are removed so the processor type is not

[libvirt] [PATCH] Fixed service handling in specfile

2012-02-24 Thread Martin Kletzander
After adding the libvirt-guests service into usual runlevels, we used to start the libvirt-guests service. However this is usually not a good practice. As mentioned on fedoraproject wiki, the installations can be in changeroots, in an installer context, or in other situations where we don't want

Re: [libvirt] RFC: Post-install behavior of libvirt(-client)

2012-02-24 Thread Martin Kletzander
On 02/23/2012 04:23 PM, Eric Blake wrote: On 02/23/2012 07:25 AM, Martin Kletzander wrote: To me it seems more reasonable to just don't start anything. I don't want any service on my system started just because I installed it. I think we've reached a state of violent agreement :) I didn't

[libvirt] [PATCH v2] Fixed URI parsing

2012-02-24 Thread Martin Kletzander
Function xmlParseURI does not remove square brackets around IPv6 address when parsing. One of the solutions is making wrappers around functions working with xmlURI*. This assures that uri-server will be always properly assigned and it doesn't have to be changed when used on some new place in the

Re: [libvirt] [PATCH 01/13] virsh: Move definition of cmds and cmd groups right at the top of main

2012-07-25 Thread Martin Kletzander
On 07/24/2012 11:18 AM, Osier Yang wrote: This will avoid many conflicts if moving the codes for each command group into separate files in later patches. --- tools/virsh.c | 967 - 1 files changed, 483 insertions(+), 484 deletions(-)

Re: [libvirt] [PATCH 02/13] virsh: Split cmds for domain monitoring from virsh.c

2012-07-25 Thread Martin Kletzander
On 07/24/2012 11:18 AM, Osier Yang wrote: This splits commands commands to monitor domain status into virsh-domain-monitor.c. The helpers not for common use are moved too. Standard copyright is added. * tools/virsh.c: Remove commands for domain monitoring group and a few helpers (

Re: [libvirt] [PATCH 06/13] virsh: Split cmds to manage network from virsh.c

2012-07-25 Thread Martin Kletzander
On 07/24/2012 11:18 AM, Osier Yang wrote: Commands to manage network are moved from virsh.c to virsh-network.c, with a few helpers for network command use. * virsh.c: Remove network commands and a few helpers. * virsh-network.c: New file, filled with network commands its helpers. s/its/and

Re: [libvirt] [PATCH 08/13] virsh: Split cmds to manage network filter from virsh.c

2012-07-25 Thread Martin Kletzander
On 07/24/2012 11:18 AM, Osier Yang wrote: Commands to manage network filter are moved from virsh.c to virsh-nwfilter.c, with a few helpers for network filter command use. * virsh.c: Remove network filter commands and a few helpers. (vshCommandOptNWFilter, and

Re: [libvirt] [PATCH 09/13] virsh: Split cmds to manage secret from virsh.c

2012-07-25 Thread Martin Kletzander
On 07/24/2012 11:18 AM, Osier Yang wrote: Commands to manage secret are moved from virsh.c to virsh-secret.c, with a few helpers for secret command use. * virsh.c: Remove secret commands and helper (vshCommandOptSecret). * virsh-secret.c: New file, filled with secret commands and its helper.

Re: [libvirt] [PATCH 13/13] virsh: Move command group definition into its own file

2012-07-25 Thread Martin Kletzander
...@redhat.com From: Martin Kletzander mklet...@redhat.com Date: Wed, 25 Jul 2012 17:59:45 +0200 Subject: [PATCH] fixup --- cfg.mk |7 --- po/POTFILES.in | 11 +++ tools/virsh-domain-monitor.c |4 +++- tools/virsh-domain.c |2

Re: [libvirt] [PATCHv2 1/2] virsh: Refactor error clearing on graceful fallback paths

2012-07-27 Thread Martin Kletzander
On 07/26/2012 02:48 PM, Peter Krempa wrote: Virsh uses an error handler to save errors from libvirt. On some code paths it's needed to clear libvirt errors and continue on fallback code paths without reporting failure. This patch adds function vshResetLibvirtError() that clears error

Re: [libvirt] [PATCHv2 2/2] virsh: Fix error resetting on fallback paths

2012-07-27 Thread Martin Kletzander
On 07/26/2012 02:48 PM, Peter Krempa wrote: On some fallback paths in virsh, error reported by the previously failed API is cleared by virResetLastError() that doesn'd free error stored by s/doesn'd/doesn't/ virsh. This patch changes this to clear it using vshResetLibvirtError(). ACK,

[libvirt] [PATCH] Add support for disabling S3 and S4 states

2012-07-30 Thread Martin Kletzander
There a two new elements in features implemented, which control what ACPI sleeping states will be advertised. The default is to have both states enabled, so this means no change for current machines. --- docs/schemas/domaincommon.rng | 10 ++ src/conf/domain_conf.c

Re: [libvirt] [PATCH] Add support for disabling S3 and S4 states

2012-07-30 Thread Martin Kletzander
On 07/30/2012 02:33 PM, Daniel P. Berrange wrote: On Mon, Jul 30, 2012 at 02:25:04PM +0200, Martin Kletzander wrote: There a two new elements in features implemented, which control what ACPI sleeping states will be advertised. The default is to have both states enabled, so this means no change

Re: [libvirt] [PATCH] Add support for disabling S3 and S4 states

2012-07-30 Thread Martin Kletzander
On 07/30/2012 04:48 PM, Daniel P. Berrange wrote: On Mon, Jul 30, 2012 at 02:43:33PM +0200, Martin Kletzander wrote: On 07/30/2012 02:33 PM, Daniel P. Berrange wrote: On Mon, Jul 30, 2012 at 02:25:04PM +0200, Martin Kletzander wrote: There a two new elements in features implemented, which

Re: [libvirt] [PATCH] build: distribute virsh related source files

2012-07-31 Thread Martin Kletzander
On 07/31/2012 05:57 AM, Guannan Ren wrote: In virsh.c, it includes multiple virsh source files, we need to have them distributed. --- tools/Makefile.am | 13 +++-- 1 files changed, 11 insertions(+), 2 deletions(-) diff --git a/tools/Makefile.am b/tools/Makefile.am index

[libvirt] Generating our docs/search.php with xsltproc

2012-08-01 Thread Martin Kletzander
Hi everyone. TL;DR is there a way to keep PHP code untouched in XSL transformed XML? For a while now, I'm trying to make our 'search.php' file generated like all the '*.html' files (with all the fancy stuff like up-to-date menu, headers and so on). The problem I've been facing looks like an

[libvirt] [PATCH v2 2/3] qemu: Add support for S3/S4 state configuration

2012-08-02 Thread Martin Kletzander
This patch adds support for running qemu guests with the required parameters to forcefully enable or disable BIOS advertising of S3 and S4 states. The support for this is added to capabilities and there is also a qemu command parameter parsing implemented. --- src/qemu/qemu_capabilities.c |7

[libvirt] [PATCH v2 1/3] Add per-guest S3/S4 state configuration

2012-08-02 Thread Martin Kletzander
There is a new pm/ element implemented that can control what ACPI sleeping states will be advertised by BIOS and allowed to be switched to by libvirt. The default keeps defaults on hypervisor, otherwise forces chosen setting. --- docs/schemas/domaincommon.rng | 33 ++

[libvirt] [PATCH v2 3/3] tests: Add tests for qemu S3/S4 state configuration

2012-08-02 Thread Martin Kletzander
Few tests were added which are checking whether the parsing of the xml and command-line arguments is working and compatible with each other. --- tests/qemuargv2xmltest.c |3 ++ .../qemuxml2argv-misc-disable-s3.args |4 +++

[libvirt] [PATCH v2 0/3] Per-guest S3/S4 configuration

2012-08-02 Thread Martin Kletzander
, checking before sending the signals through guest agent and also tests. -- v2: - Modified the patch to reflect danpb's notes (according to qemu people the setting the disable_s[34] parameter to 0/1 ensures that the states will be enabled/disabled respectively) Martin Kletzander (3): Add per

Re: [libvirt] [PATCH v2 1/3] Add per-guest S3/S4 state configuration

2012-08-03 Thread Martin Kletzander
On 08/03/2012 07:16 AM, Doug Goldstein wrote: On Thu, Aug 2, 2012 at 3:36 PM, Eric Blake ebl...@redhat.com wrote: On 08/02/2012 06:05 AM, Martin Kletzander wrote: There is a new pm/ element implemented that can control what ACPI sleeping states will be advertised by BIOS and allowed

Re: [libvirt] [PATCH v2 1/3] Add per-guest S3/S4 state configuration

2012-08-03 Thread Martin Kletzander
On 08/03/2012 09:46 AM, Paolo Bonzini wrote: Il 03/08/2012 07:16, Doug Goldstein ha scritto: You are proposing /domain/pm; but we also have /domain/os/bios, would this be better as a subelement /domain/os/bios/pm, since it is related to bios options? I would say that /domain/os/bios/pm isn't

Re: [libvirt] [PATCH v2 2/3] qemu: Add support for S3/S4 state configuration

2012-08-03 Thread Martin Kletzander
On 08/02/2012 10:48 PM, Eric Blake wrote: On 08/02/2012 06:05 AM, Martin Kletzander wrote: This patch adds support for running qemu guests with the required parameters to forcefully enable or disable BIOS advertising of S3 and S4 states. The support for this is added to capabilities

Re: [libvirt] [PATCH] virsh: console: Avoid using stream after being freed.

2012-08-03 Thread Martin Kletzander
On 08/03/2012 01:28 PM, Peter Krempa wrote: The stream object wasn't freed causing a double free attempt. --- tools/console.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tools/console.c b/tools/console.c index afece27..fee2ce3 100644 --- a/tools/console.c +++

[libvirt] [PATCH] json: fix interface locale dependency

2012-08-06 Thread Martin Kletzander
libvirt creates invalid commands if wrong locale is selected. For example with locale that uses comma as a decimal point, JSON commands created with decimal numbers are invalid because comma separates the entries in JSON. But even when decimal point is affected, grouping is not, because for

Re: [libvirt] [PATCH] json: fix interface locale dependency

2012-08-06 Thread Martin Kletzander
On 08/06/2012 11:13 AM, Michal Privoznik wrote: On 06.08.2012 10:12, Martin Kletzander wrote: libvirt creates invalid commands if wrong locale is selected. For example with locale that uses comma as a decimal point, JSON commands created with decimal numbers are invalid because comma

Re: [libvirt] [PATCH] json: fix interface locale dependency

2012-08-06 Thread Martin Kletzander
On 08/06/2012 02:52 PM, Eric Blake wrote: On 08/06/2012 06:24 AM, Daniel P. Berrange wrote: On Mon, Aug 06, 2012 at 10:12:17AM +0200, Martin Kletzander wrote: libvirt creates invalid commands if wrong locale is selected. For example with locale that uses comma as a decimal point, JSON

Re: [libvirt] [PATCH] json: fix interface locale dependency

2012-08-06 Thread Martin Kletzander
On 08/06/2012 04:35 PM, Daniel P. Berrange wrote: On Mon, Aug 06, 2012 at 03:59:42PM +0200, Martin Kletzander wrote: On 08/06/2012 02:52 PM, Eric Blake wrote: On 08/06/2012 06:24 AM, Daniel P. Berrange wrote: GLib has a g_ascii_dtostr() which forces uses of '.' as separator. Since GLib

Re: [libvirt] [PATCH] examples: Update strings for event details

2012-08-08 Thread Martin Kletzander
On 08/08/2012 04:20 PM, Jiri Denemark wrote: --- examples/domain-events/events-c/event-test.c | 2 +- examples/domain-events/events-python/event-test.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) ACK, I noticed that as well. Martin -- libvir-list mailing list

[libvirt] [PATCH v3 2/4] qemu: Add support for S3/S4 state configuration

2012-08-09 Thread Martin Kletzander
This patch adds support for running qemu guests with the required parameters to forcefully enable or disable BIOS advertising of S3 and S4 states. The support for this is added to capabilities and there is also a qemu command parameter parsing implemented. --- src/qemu/qemu_capabilities.c |7

[libvirt] [PATCH v3 3/4] tests: Add tests for qemu S3/S4 state configuration

2012-08-09 Thread Martin Kletzander
Few tests were added which are checking whether the parsing of the xml and command-line arguments is working and compatible with each other. --- tests/qemuargv2xmltest.c |3 ++ .../qemuxml2argv-misc-disable-s3.args |4 +++

[libvirt] [PATCH v3 0/4] Per-guest S3/S4 configuration

2012-08-09 Thread Martin Kletzander
ensures that the states will be enabled/disabled respectively) Martin Kletzander (4): Add per-guest S3/S4 state configuration qemu: Add support for S3/S4 state configuration tests: Add tests for qemu S3/S4 state configuration docs: Add pm element into documentation docs

[libvirt] [PATCH v3 1/4] Add per-guest S3/S4 state configuration

2012-08-09 Thread Martin Kletzander
There is a new pm/ element implemented that can control what ACPI sleeping states will be advertised by BIOS and allowed to be switched to by libvirt. The default keeps defaults on hypervisor, otherwise forces chosen setting. --- docs/schemas/domaincommon.rng | 33 ++

[libvirt] [PATCH v3 4/4] docs: Add pm element into documentation

2012-08-09 Thread Martin Kletzander
--- docs/formatdomain.html.in | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index f97c630..50c4783 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -922,6 +922,27 @@

<    2   3   4   5   6   7   8   9   10   11   >