[libvirt] [PATCH v2] json: fix interface locale dependency

2012-08-09 Thread Martin Kletzander
libvirt creates invalid commands if wrong locale is selected. For example with locale that uses comma as a decimal point, JSON commands created with decimal numbers are invalid because comma separates the entries in JSON. Fortunately even when decimal point is affected, thousands grouping is not,

[libvirt] [PATCH 1/3] docs: fix 404 page when fetched from different location

2012-08-09 Thread Martin Kletzander
Error 404 page had relative paths specified for both the image and stylesheets which caused a problem when requested URL included a subfolder (e.g. http://libvirt.org/asdf/asdf ). This patch corrects this behaviour by modifying href_base to '/' and changing the src of the image. ---

[libvirt] [PATCH 0/3] Minor docs fixes

2012-08-09 Thread Martin Kletzander
change it or not. Martin Kletzander (3): docs: fix 404 page when fetched from different location docs: autogenerate search.php docs/virsh: various minor fixes .gitignore |1 + docs/404.html.in|2 +- docs/Makefile.am

[libvirt] [PATCH 3/3] docs/virsh: various minor fixes

2012-08-09 Thread Martin Kletzander
List: - some old libvir/libvirt rename leftovers (the only problem can be if somebody parses 'virsh version' output really badly) - remove pointless tags specified in some pages that are not used --- docs/api_extension.html.in |4 docs/pending.html.in |4

[libvirt] [PATCH 2/3] docs: autogenerate search.php

2012-08-09 Thread Martin Kletzander
This patch makes search.php autogenerated from search.php.in, thus removing hardcoded menus, footer etc. and the search.php is added to .gitignore. There is new rule added for *.php files (to make it bit less hardcoded) that takes *.php.code.in and injects it inside the generated *.php (xslt was

Re: [libvirt] [PATCH 1/3] docs: fix 404 page when fetched from different location

2012-08-10 Thread Martin Kletzander
On 08/09/2012 04:25 PM, Eric Blake wrote: On 08/09/2012 08:17 AM, Martin Kletzander wrote: Error 404 page had relative paths specified for both the image and stylesheets which caused a problem when requested URL included a subfolder (e.g. http://libvirt.org/asdf/asdf ). This patch corrects

Re: [libvirt] [PATCH 2/3] docs: autogenerate search.php

2012-08-10 Thread Martin Kletzander
On 08/09/2012 05:00 PM, Eric Blake wrote: On 08/09/2012 08:17 AM, Martin Kletzander wrote: This patch makes search.php autogenerated from search.php.in, thus removing hardcoded menus, footer etc. and the search.php is added to .gitignore. There is new rule added for *.php files (to make

Re: [libvirt] [PATCH 3/3] docs/virsh: various minor fixes

2012-08-10 Thread Martin Kletzander
On 08/09/2012 04:31 PM, Eric Blake wrote: On 08/09/2012 08:18 AM, Martin Kletzander wrote: List: - some old libvir/libvirt rename leftovers (the only problem can be if somebody parses 'virsh version' output really badly) - remove pointless tags specified in some pages that are not used

Re: [libvirt] [PATCH v2] json: fix interface locale dependency

2012-08-10 Thread Martin Kletzander
On 08/09/2012 06:17 PM, Eric Blake wrote: virCasprintf() seems like overkill, for now. Since printing a floating point value is the only case where locale matters, we should be able to provide a single helper function that guarantees a formatted float, rather than trying to provide a generic

Re: [libvirt] [PATCH v2] json: fix interface locale dependency

2012-08-11 Thread Martin Kletzander
On 08/10/2012 05:39 PM, Eric Blake wrote: On 08/10/2012 03:43 AM, Martin Kletzander wrote: I'm still worried about whether 'struct lconv' will compile on mingw. Then again, any system that lacks localeconf() probably also lacks any locale that would use ',' for the decimal separator, so maybe

[libvirt] [PATCH v3] json: fix interface locale dependency

2012-08-12 Thread Martin Kletzander
) there is no need for special-formatting with C locale unless the result is being parsed by machine in which case the '%lf' is always sufficient. Martin Kletzander (1): json: fix interface locale dependency bootstrap.conf |1 + configure.ac |2 +- src

[libvirt] [PATCH v3.1] json: fix interface locale dependency

2012-08-12 Thread Martin Kletzander
libvirt creates invalid commands if wrong locale is selected. For example with locale that uses comma as a decimal point, JSON commands created with decimal numbers are invalid because comma separates the entries in JSON. Fortunately even when decimal point is affected, thousands grouping is not,

[libvirt] [PATCH v3.2] json: fix interface locale dependency

2012-08-12 Thread Martin Kletzander
libvirt creates invalid commands if wrong locale is selected. For example with locale that uses comma as a decimal point, JSON commands created with decimal numbers are invalid because comma separates the entries in JSON. Fortunately even when decimal point is affected, thousands grouping is not,

[libvirt] [PATCH v3 0/4] qemu: configurable port boundaries for remote displays

2012-08-13 Thread Martin Kletzander
the change to both VNC and SPICE sessions Martin Kletzander (4): qemu: Unify port-wise SPICE and VNC behavior qemu: configurable remote display port boundaries qemu: modify 3 error messages qemu: allow searching for all open ports src/conf/domain_conf.c |2 +- src/qemu

[libvirt] [PATCH v3 2/4] qemu: configurable remote display port boundaries

2012-08-13 Thread Martin Kletzander
The defines QEMU_REMOTE_PORT_MIN and QEMU_REMOTE_PORT_MAX were used to find free port when starting domains. As this was hard-coded to the same ports as default VNC servers, there were races with these other programs. This patch includes the possibility to change the default starting port as well

[libvirt] [PATCH v3 3/4] qemu: modify 3 error messages

2012-08-13 Thread Martin Kletzander
After the cleanup of remote display port allocation, I noticed some messages that didn't make a lot of sense the way they were written. So I rephrased them. --- src/qemu/qemu_process.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_process.c

[libvirt] [PATCH v3 4/4] qemu: allow searching for all open ports

2012-08-13 Thread Martin Kletzander
This patch allows to specify a flag 'rotate' saying that the search for next port should not be limited from the 'startPort' upwards. This is subsequently used in the search for open SPICE TLS port when none is specified and TLS is enabled. --- src/qemu/qemu_process.c | 24

[libvirt] [PATCH v3 1/4] qemu: Unify port-wise SPICE and VNC behavior

2012-08-13 Thread Martin Kletzander
Port allocations for SPICE and VNC behave almost the same (with default ports), but there is some mess in the code. This patch clears these inconsistencies and makes sure the same behavior will be used when ports for remote displays are changed. Changes: - hard-coded number 5900 removed (handled

[libvirt] [PATCH v4] json: fix interface locale dependency

2012-08-13 Thread Martin Kletzander
libvirt creates invalid commands if wrong locale is selected. For example with locale that uses comma as a decimal point, JSON commands created with decimal numbers are invalid because comma separates the entries in JSON. Fortunately even when decimal point is affected, thousands grouping is not,

Re: [libvirt] [PATCH v3.1] json: fix interface locale dependency

2012-08-13 Thread Martin Kletzander
On 08/13/2012 05:51 PM, Eric Blake wrote: Of the two alternatives, I prefer this one for now. If we ever have need for further enhancements down the road, we can add them at that time. No need to add code that will be unused by being more flexible than our current needs. I see I've sent

Re: [libvirt] [PATCH v4] json: fix interface locale dependency

2012-08-13 Thread Martin Kletzander
On 08/13/2012 07:27 PM, Eric Blake wrote: On 08/13/2012 10:02 AM, Martin Kletzander wrote: libvirt creates invalid commands if wrong locale is selected. For example with locale that uses comma as a decimal point, JSON commands created with decimal numbers are invalid because comma separates

[libvirt] [PATCH] util: typos in fallback code fo virDoubleToStr

2012-08-14 Thread Martin Kletzander
Fixes for some typos that somehow didn't get to the final push of the commit 43bfa23e6f968be9a8c134a4b5c3cfb6da3816d9. --- Pushing as a build-breaker. src/util/util.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/util.c b/src/util/util.c index

Re: [libvirt] [PATCH v3 1/4] qemu: Unify port-wise SPICE and VNC behavior

2012-08-14 Thread Martin Kletzander
On 08/14/2012 11:42 AM, Daniel P. Berrange wrote: On Mon, Aug 13, 2012 at 03:21:22PM +0200, Martin Kletzander wrote: Port allocations for SPICE and VNC behave almost the same (with default ports), but there is some mess in the code. This patch clears these inconsistencies and makes sure

[libvirt] [PATCH v4] qemu: Unify port-wise SPICE and VNC behavior

2012-08-14 Thread Martin Kletzander
Port allocations for SPICE and VNC behave almost the same (with default ports), but there is some mess in the code. This patch clears these inconsistencies and makes sure the same behavior will be used when ports for remote displays are changed. Changes: - hard-coded number 5900 removed (handled

[libvirt] [PATCH 3/4] tests: Add tests for dump-core option

2012-08-15 Thread Martin Kletzander
--- tests/qemuargv2xmltest.c |2 + .../qemuxml2argv-machine-core-off.args |5 .../qemuxml2argv-machine-core-off.xml | 26 .../qemuxml2argv-machine-core-on.args |5

[libvirt] [PATCH 4/4] docs: Document dump-core memory feature

2012-08-15 Thread Martin Kletzander
--- docs/formatdomain.html.in | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index bb225b1..af44742 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -474,9 +474,16 @@

[libvirt] [PATCH 1/4] Add support for limiting guest coredump

2012-08-15 Thread Martin Kletzander
Sometimes when guest machine crashes, coredump can get huge due to the guest memory. This can be limited using madvise(2) system call and is being used in QEMU hypervisor. This patch adds an option for configuring that in the domain XML. --- docs/schemas/domaincommon.rng |8

[libvirt] [PATCH 0/4] Support for limiting guest coredumps

2012-08-15 Thread Martin Kletzander
can reduce the coredump by a reasonable size. Martin [1] https://www.redhat.com/archives/libvir-list/2012-August/msg00572.html [2] http://lists.nongnu.org/archive/html/qemu-devel/2012-08/msg00554.html Martin Kletzander (4): Add support for limiting guest coredump qemu: add support for dump

[libvirt] [PATCH 2/4] qemu: add support for dump-guest-core option

2012-08-15 Thread Martin Kletzander
The dump-guest-core' option is new option for the machine type (-machine pc,dump-guest-core) that controls whether the guest memory will be marked as dumpable. While testing this, I've found out that the value for the '-M' options is not parsed correctly when additional parameters are used.

Re: [libvirt] [PATCH v2] qemu: Set swap_hard_limit before hard_limit

2012-08-16 Thread Martin Kletzander
On 08/16/2012 12:37 PM, Osier Yang wrote: Setting hard_limit larger than previous swap_hard_limit must fail, it's not that good if one wants to change the swap_hard_limit and hard_limit together. E.g. % virsh memtune rhel6 hard_limit : 100 soft_limit : 100 swap_hard_limit:

Re: [libvirt] [PATCH 2/7] add qemuAgentArbitraryCommand() for general qemu agent command.

2012-08-16 Thread Martin Kletzander
On 08/15/2012 03:36 AM, MATSUDA Daiki wrote: add qemuAgentArbitraryCommand() for general qemu agent command. Twice the same line in the message, could be less brief, maybe :) Signed-off-by: MATSUDA Daiki matsuda...@intellilink.co.jp --- src/qemu/qemu_agent.c | 31

Re: [libvirt] [PATCH 1/7] Add @seconds vaiable to qemuAgentSend()

2012-08-16 Thread Martin Kletzander
On 08/15/2012 03:36 AM, MATSUDA Daiki wrote: Add @seconds variable to qemuAgentSend(). When @tiemout is true, @seconds controls how long to wait for a response (if @seconds is VIR_DOMAIN_QEMU_AGENT_COMMAND_DEFAULT, default to QEMU_AGENT_WAIT_TIME). If @timeout is false, @seconds is

Re: [libvirt] [PATCH 3/7] add virAgentCommand()

2012-08-16 Thread Martin Kletzander
On 08/15/2012 03:36 AM, MATSUDA Daiki wrote: diff --git a/include/libvirt/libvirt-qemu.h b/include/libvirt/libvirt-qemu.h index 013ed5a..60b83ef 100644 --- a/include/libvirt/libvirt-qemu.h +++ b/include/libvirt/libvirt-qemu.h @@ -50,6 +50,9 @@ typedef enum {

Re: [libvirt] [PATCH 5/7] add qemuAgentCommand() for .qemuAgentCommand to remote driver

2012-08-16 Thread Martin Kletzander
On 08/15/2012 03:36 AM, MATSUDA Daiki wrote: diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 353a153..3c60709 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -5368,6 +5368,7 @@ static virDriver remote_driver = { .domainSetMetadata =

Re: [libvirt] [PATCH v3] qemu: Set swap_hard_limit before hard_limit

2012-08-17 Thread Martin Kletzander
On 08/17/2012 09:34 AM, Osier Yang wrote: Setting hard_limit larger than previous swap_hard_limit must fail, it's not that good if one wants to change the swap_hard_limit and hard_limit together. E.g. % virsh memtune rhel6 hard_limit : 100 soft_limit : 100 swap_hard_limit:

Re: [libvirt] [test-API][PATCH 3/3] Target path should not with lines in pool xml

2012-08-17 Thread Martin Kletzander
On 08/17/2012 12:06 PM, Wayne Sun wrote: The xml for define and create pool is with line switch in target path. For aa.xml: pool type=netfs namenetfs_pool/name source host name=192.168.0.121/ dir path=/dir/ format type=nfs/ /source target path

Re: [libvirt] [test-API][PATCH 2/3] Modify function name to avoid key word 'check' in framework

2012-08-17 Thread Martin Kletzander
On 08/17/2012 12:06 PM, Wayne Sun wrote: Modfiy the function name to avoid generating check case and doing params check before the case run. Signed-off-by: Wayne Sun g...@redhat.com --- repos/domain/cpu_topology.py |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

Re: [libvirt] [test-API][PATCH 1/3] Delete the duplicate function

2012-08-17 Thread Martin Kletzander
On 08/17/2012 12:06 PM, Wayne Sun wrote: Signed-off-by: Wayne Sun g...@redhat.com --- utils/utils.py | 18 -- 1 files changed, 0 insertions(+), 18 deletions(-) diff --git a/utils/utils.py b/utils/utils.py index eade10d..b174a58 100644 --- a/utils/utils.py +++

Re: [libvirt] [PATCH 1/7] Add @seconds vaiable to qemuAgentSend()

2012-08-20 Thread Martin Kletzander
On 08/20/2012 02:10 AM, MATSUDA, Daiki wrote: (2012/08/16 21:58), Martin Kletzander wrote: On 08/15/2012 03:36 AM, MATSUDA Daiki wrote: Add @seconds variable to qemuAgentSend(). When @tiemout is true, @seconds controls how long to wait for a response (if @seconds

Re: [libvirt] [PATCH 3/7] add virAgentCommand()

2012-08-20 Thread Martin Kletzander
On 08/20/2012 02:16 AM, MATSUDA, Daiki wrote: (2012/08/16 22:13), Martin Kletzander wrote: On 08/15/2012 03:36 AM, MATSUDA Daiki wrote: [...] +char * +virAgentCommand(virDomainPtr domain, +const char *cmd, +int timeout, +unsigned int flags

Re: [libvirt] [PATCH 5/7] add qemuAgentCommand() for .qemuAgentCommand to remote driver

2012-08-20 Thread Martin Kletzander
On 08/20/2012 02:20 AM, MATSUDA, Daiki wrote: (2012/08/16 22:25), Martin Kletzander wrote: On 08/15/2012 03:36 AM, MATSUDA Daiki wrote: diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 353a153..3c60709 100644 --- a/src/remote/remote_driver.c +++ b/src/remote

Re: [libvirt] [PATCH v4] qemu: Unify port-wise SPICE and VNC behavior

2012-08-21 Thread Martin Kletzander
On 08/21/2012 11:36 AM, Daniel P. Berrange wrote: On Tue, Aug 14, 2012 at 02:52:19PM +0200, Martin Kletzander wrote: Port allocations for SPICE and VNC behave almost the same (with default ports), but there is some mess in the code. This patch clears these inconsistencies and makes sure

Re: [libvirt] [PATCH v3 4/4] docs: Add pm element into documentation

2012-08-22 Thread Martin Kletzander
On 08/22/2012 05:08 PM, Eric Blake wrote: On 08/22/2012 07:37 AM, Michal Privoznik wrote: On 09.08.2012 10:26, Martin Kletzander wrote: --- docs/formatdomain.html.in | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/docs/formatdomain.html.in b

[libvirt] [PATCH v4 0/3] Per-guest S3/S4 configuration

2012-08-23 Thread Martin Kletzander
(formatdomain) v2: - Modified the patch to reflect danpb's notes (according to qemu people the setting the disable_s[34] parameter to 0/1 ensures that the states will be enabled/disabled respectively) *** BLURB HERE *** Martin Kletzander (3): Add per-guest S3/S4 state configuration

[libvirt] [PATCH v4 1/3] Add per-guest S3/S4 state configuration

2012-08-23 Thread Martin Kletzander
There is a new pm/ element implemented that can control what ACPI sleeping states will be advertised by BIOS and allowed to be switched to by libvirt. The default keeps defaults on hypervisor, otherwise forces chosen setting. The documentation of the pm element is added as well. ---

[libvirt] [PATCH v4 2/3] qemu: Add support for S3/S4 state configuration

2012-08-23 Thread Martin Kletzander
This patch adds support for running qemu guests with the required parameters to forcefully enable or disable BIOS advertising of S3 and S4 states. The support for this is added to capabilities and there is also a qemu command parameter parsing implemented. --- src/qemu/qemu_capabilities.c | 7

[libvirt] [PATCH v4 3/3] tests: Add tests for qemu S3/S4 state configuration

2012-08-23 Thread Martin Kletzander
Few tests were added which are checking whether the parsing of the xml and command-line arguments is working and compatible with each other. --- tests/qemuargv2xmltest.c | 3 +++ .../qemuxml2argv-misc-disable-s3.args | 4 +++

Re: [libvirt] [PATCH 0/2] virsh: Check for connection usability before each command

2012-08-24 Thread Martin Kletzander
On 08/24/2012 02:42 PM, Peter Krempa wrote: Some commands in virsh forgot to do this check before executing remote commands and printed unexpected error messages. This series moves the connection check to a central point so that these mistakes don't happen. Also it's a nice cleanup :).

[libvirt] [PATCH] qemu: fix regression with pinning

2012-08-27 Thread Martin Kletzander
Commit 4b03d59167f4a4c6ec57def315a61d977466e75b changed the pinning behavior in a way that makes some machine non-startable. The comment mentioning that we cannot control each vcpu when there is no VCPU-PID mapping available is true, however, this isn't necessarily an error, because this can be

Re: [libvirt] [PATCH] virsh: fix missing return value

2012-08-27 Thread Martin Kletzander
On 08/27/2012 08:07 AM, Alex Jia wrote: Although virsh command raises a correct error information, the command status returns 0(true), this patch is used for fixing this issue. Signed-off-by: Alex Jia a...@redhat.com --- tools/virsh-host.c |3 +++ 1 files changed, 3 insertions(+), 0

[libvirt] [PATCH] qemu: fix regression with spice tls port allocation

2012-08-27 Thread Martin Kletzander
In my quest for reusing variables I failed to edit one variable when fixing details between two patch versions. That results in a failure to start qemu with autoport and spice tls, because qemu is trying to bind two sockets to the same port. --- src/qemu/qemu_process.c | 2 +- 1 file changed, 1

Re: [libvirt] [PATCH] qemu: fix regression with spice tls port allocation

2012-08-27 Thread Martin Kletzander
On 08/27/2012 10:07 AM, Peter Krempa wrote: On 08/27/12 09:51, Martin Kletzander wrote: In my quest for reusing variables I failed to edit one variable when fixing details between two patch versions. That results in a failure to start qemu with autoport and spice tls, because qemu is trying

Re: [libvirt] [PATCH] qemu: fix regression with pinning

2012-08-27 Thread Martin Kletzander
On 08/27/2012 10:18 AM, Peter Krempa wrote: On 08/27/12 08:09, Martin Kletzander wrote: Commit 4b03d59167f4a4c6ec57def315a61d977466e75b changed the pinning behavior in a way that makes some machine non-startable. s/machine/machines/ OK, fixed. The comment mentioning that we cannot

Re: [libvirt] [PATCH] rpc: fix segmentation fault caused by null client-sock

2012-08-27 Thread Martin Kletzander
On 08/27/2012 11:09 AM, Guannan Ren wrote: BZ:https://bugzilla.redhat.com/show_bug.cgi?id=851423 The client-sock could have been set to NULL by eventloop thread after async event fired. --- src/rpc/virnetclient.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH 1/2] Introduce new VIR_ERR_AGENT_UNRESPONSIVE error code

2012-08-27 Thread Martin Kletzander
On 08/27/2012 01:57 PM, Michal Privoznik wrote: Currently, when guest agent is configure but not responsive s/configure/configured/ (e.g. due to appropriate service not running in the guest) we return VIR_ERR_INTERNAL_ERROR or VIR_ERR_ARGUMENT_UNSUPPORTED. There is no

Re: [libvirt] [PATCH 2/2] qemu_agent: Switch to virReportSystemError() on system error

2012-08-27 Thread Martin Kletzander
On 08/27/2012 01:57 PM, Michal Privoznik wrote: Currently, if a syscall in qemu_agent.c fails we report an internal error even though we should be reporting the system error. s/the/a/ ACK, Martin -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH] docs: CPU allocation and pinning clarification

2012-08-27 Thread Martin Kletzander
There was a request for clarifying this part of the documentation. This also fixes a case used with CPU. --- docs/formatdomain.html.in | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index e671e36..468fc62

Re: [libvirt] [PATCH] docs: CPU allocation and pinning clarification

2012-08-28 Thread Martin Kletzander
On 08/28/2012 10:32 AM, Peter Krempa wrote: On 08/27/12 16:37, Martin Kletzander wrote: There was a request for clarifying this part of the documentation. This also fixes a case used with CPU. --- docs/formatdomain.html.in | 11 +++ 1 file changed, 7 insertions(+), 4 deletions

[libvirt] [PATCH] qemu: fix remote port searching

2012-08-31 Thread Martin Kletzander
After fixing the last review comments on remote port searching (commit a14b4aea512d6c3a42af56207a65ef10ac4a12a1), the commit right after that wasn't modified accordingly, therefore two values weren't changed as they should and the configurable ports don't work as expected. This simple commit

Re: [libvirt] [PATCH] qemu: fix remote port searching

2012-08-31 Thread Martin Kletzander
On 08/31/2012 04:06 PM, Jiri Denemark wrote: On Fri, Aug 31, 2012 at 15:48:19 +0200, Martin Kletzander wrote: After fixing the last review comments on remote port searching (commit a14b4aea512d6c3a42af56207a65ef10ac4a12a1), the commit right after that wasn't modified accordingly, therefore two

Re: [libvirt] [PATCH] qemu: fix remote port searching

2012-08-31 Thread Martin Kletzander
On 08/31/2012 04:29 PM, Daniel Veillard wrote: On Fri, Aug 31, 2012 at 04:09:39PM +0200, Martin Kletzander wrote: On 08/31/2012 04:06 PM, Jiri Denemark wrote: On Fri, Aug 31, 2012 at 15:48:19 +0200, Martin Kletzander wrote: After fixing the last review comments on remote port searching (commit

[libvirt] [PATCH v4 3/3] tests: Add tests for qemu S3/S4 state configuration

2012-08-31 Thread Martin Kletzander
Few tests were added which are checking whether the parsing of the xml and command-line arguments is working and compatible with each other. --- tests/qemuargv2xmltest.c | 3 +++ .../qemuxml2argv-misc-disable-s3.args | 4 +++

[libvirt] [PATCH v4 0/3] Per-guest S3/S4 configuration

2012-08-31 Thread Martin Kletzander
names are change according to Eric and Doug - Added docs (formatdomain) v2: - Modified the patch to reflect danpb's notes (according to qemu people the setting the disable_s[34] parameter to 0/1 ensures that the states will be enabled/disabled respectively) Martin Kletzander (3): Add per

[libvirt] [PATCH v4 1/3] Add per-guest S3/S4 state configuration

2012-08-31 Thread Martin Kletzander
There is a new pm/ element implemented that can control what ACPI sleeping states will be advertised by BIOS and allowed to be switched to by libvirt. The default keeps defaults on hypervisor, otherwise forces chosen setting. The documentation of the pm element is added as well. ---

[libvirt] [PATCH v4 2/3] qemu: Add support for S3/S4 state configuration

2012-08-31 Thread Martin Kletzander
This patch adds support for running qemu guests with the required parameters to forcefully enable or disable BIOS advertising of S3 and S4 states. The support for this is added to capabilities and there is also a qemu command parameter parsing implemented. --- src/qemu/qemu_capabilities.c | 7

Re: [libvirt] [PATCH v4 1/3] Add per-guest S3/S4 state configuration

2012-09-03 Thread Martin Kletzander
On 08/31/2012 07:42 PM, Eric Blake wrote: On 08/31/2012 07:59 AM, Martin Kletzander wrote: There is a new pm/ element implemented that can control what ACPI sleeping states will be advertised by BIOS and allowed to be switched to by libvirt. The default keeps defaults on hypervisor, otherwise

Re: [libvirt] [PATCH v4 3/3] tests: Add tests for qemu S3/S4 state configuration

2012-09-03 Thread Martin Kletzander
On 08/31/2012 08:01 PM, Eric Blake wrote: On 08/31/2012 07:59 AM, Martin Kletzander wrote: Few tests were added which are checking whether the parsing of the xml and command-line arguments is working and compatible with each other. --- tests/qemuargv2xmltest.c | 3

Re: [libvirt] [PATCH v4 2/3] qemu: Add support for S3/S4 state configuration

2012-09-03 Thread Martin Kletzander
On 08/31/2012 07:49 PM, Eric Blake wrote: On 08/31/2012 07:59 AM, Martin Kletzander wrote: This patch adds support for running qemu guests with the required parameters to forcefully enable or disable BIOS advertising of S3 and S4 states. The support for this is added to capabilities

Re: [libvirt] VM Migration with IEEE802.1Qbh and IEEE802.1Qbg

2012-09-04 Thread Martin Kletzander
On 09/02/2012 01:53 PM, Jagath Weerasinghe wrote: Hi All, Can a VM connected as IEEE802.1Qbh be migrated to a destination host as it were connected as IEEE802.1Qbg? What I wanted to know is, is it possible to change the configuration from IEEE802.1Qbh to IEEE802.1Qbg on the fly? IIUC,

[libvirt] [PATCH] conf: describe security_driver behavior

2012-09-04 Thread Martin Kletzander
As a request was raised for this, I added few lines in the Notes part of the security_driver comments about allowed values. --- The related bug for this patch is here: https://bugzilla.redhat.com/show_bug.cgi?id=853925 src/qemu/qemu.conf | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

[libvirt] [PATCH] docs: correct dompmwakeup description

2012-09-04 Thread Martin Kletzander
The command 'dompmwakeup' can wakeup any pmsuspended domain, not only domains suspended previously by dompmsuspend and this patch fixed the man page and help string for that. --- tools/virsh-domain.c | 6 +++--- tools/virsh.pod | 7 --- 2 files changed, 7 insertions(+), 6 deletions(-)

[libvirt] [PATCH] qemu: don't pin all the cpus

2012-09-04 Thread Martin Kletzander
This is another fix for the emulator-pin series. When going through the cputune pinning settings, the current code is trying to pin all the CPUs, even when not all of them are specified. This causes error in the subsequent function which, of course, cannot find the cpu to pin. Since it's enough to

Re: [libvirt] [PATCH] conf: describe security_driver behavior

2012-09-04 Thread Martin Kletzander
On 09/04/2012 04:51 PM, Eric Blake wrote: On 09/04/2012 08:23 AM, Martin Kletzander wrote: As a request was raised for this, I added few lines in the Notes part of the security_driver comments about allowed values. --- The related bug for this patch is here: https://bugzilla.redhat.com

Re: [libvirt] [PATCH] docs: correct dompmwakeup description

2012-09-04 Thread Martin Kletzander
On 09/04/2012 04:52 PM, Eric Blake wrote: On 09/04/2012 08:23 AM, Martin Kletzander wrote: The command 'dompmwakeup' can wakeup any pmsuspended domain, not only domains suspended previously by dompmsuspend and this patch fixed the man page and help string for that. --- tools/virsh-domain.c

Re: [libvirt] [PATCH] build: use re-entrant functions in virsh

2012-09-05 Thread Martin Kletzander
On 09/05/2012 01:36 AM, Eric Blake wrote: Today's patches pointed out that virsh was still using localtime(), which is not thread-safe, even though virsh is definitely multi-threaded. * cfg.mk (exclude_file_name_regexp--sc_prohibit_nonreentrant): Tighten the rule. * tools/virsh.c

Re: [libvirt] [PATCH] maint: avoid doubled name in syntax check failures

2012-09-05 Thread Martin Kletzander
On 09/05/2012 01:41 AM, Eric Blake wrote: Based on a similar gnulib patch; use of $(_sc_search_regexp) already injects $(ME) into any output messages, so a failure of these rules would look like this, pre-patch: ./config.status: ./config.status: use virStrToLong_*, not strtol variants *

[libvirt] S4 event, states and caveats

2012-09-05 Thread Martin Kletzander
Hi everybody, I'm going to add support for S4 event for libvirt and I'm thinking for a while now how to do that, so I'd like to discuss this here on the list before doing something wrong and mainly to eliminate bothering you guys with reviews of PATCH v5 etc. QEMU emits SUSPEND_DISK event before

Re: [libvirt] [PATCH] qemu: don't pin all the cpus

2012-09-05 Thread Martin Kletzander
On 09/05/2012 07:11 PM, Michal Privoznik wrote: On 04.09.2012 16:23, Martin Kletzander wrote: This is another fix for the emulator-pin series. When going through the cputune pinning settings, the current code is trying to pin all the CPUs, even when not all of them are specified. This causes

Re: [libvirt] [PATCH] Fix location of SELinux mount during RPM builds

2012-09-07 Thread Martin Kletzander
On 09/06/2012 04:24 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com When building RPMs the host kernel cannot be assumed to match the target OS kernel. Thus auto-detecting /selinux vs /sys/fs/selinux based on the host kernel can result in the This line ... wrong

Re: [libvirt] [libvirt-designer][PATCH 1/4] Load osinfo DB on init

2012-09-07 Thread Martin Kletzander
On 09/05/2012 11:27 AM, Michal Privoznik wrote: as we need this DB later to find an OS or hypervisor and supported devices. --- libvirt-designer/Makefile.am |1 + libvirt-designer/libvirt-designer-domain.c |5 +++- libvirt-designer/libvirt-designer-internal.h |

Re: [libvirt] [libvirt-designer][PATCH 2/4] domain: Introduce disk support

2012-09-07 Thread Martin Kletzander
On 09/05/2012 11:27 AM, Michal Privoznik wrote: Let users add either files or devices as disks to domains. --- libvirt-designer/libvirt-designer-domain.c | 244 libvirt-designer/libvirt-designer-domain.h |7 + libvirt-designer/libvirt-designer.sym |

Re: [libvirt] [libvirt-designer][PATCH 3/4] examples: Create an example of usage program

2012-09-07 Thread Martin Kletzander
On 09/05/2012 11:27 AM, Michal Privoznik wrote: --- .gitignore |1 + Makefile.am |2 +- configure.ac |6 +- examples/Makefile.am | 23 examples/virtxml.c | 334 ++ 5 files changed, 364

Re: [libvirt] [libvirt-designer][PATCH 4/4] domain: Introduce interface support

2012-09-07 Thread Martin Kletzander
On 09/05/2012 11:27 AM, Michal Privoznik wrote: Let users add NICs to domains. --- examples/virtxml.c | 96 libvirt-designer/libvirt-designer-domain.c | 53 +++ libvirt-designer/libvirt-designer-domain.h |3 +

Re: [libvirt] [libvirt-designer][PATCH 4/4] domain: Introduce interface support

2012-09-10 Thread Martin Kletzander
On 09/10/2012 11:19 AM, Christophe Fergeau wrote: Hey, On Fri, Sep 07, 2012 at 03:56:34PM +0200, Martin Kletzander wrote: On 09/05/2012 11:27 AM, Michal Privoznik wrote: + +static const gchar * +gvir_designer_domain_get_preferred_nic_model(GVirDesignerDomain *design

Re: [libvirt] [libvirt-designer][PATCH v2 2/4] domain: Introduce disk support

2012-09-10 Thread Martin Kletzander
On 09/10/2012 03:58 PM, Michal Privoznik wrote: Let users add either files or devices as disks to domains. --- libvirt-designer/libvirt-designer-domain.c | 259 libvirt-designer/libvirt-designer-domain.h |7 + libvirt-designer/libvirt-designer.sym |

Re: [libvirt] [libvirt-designer][PATCH v2 3/4] examples: Create an example of usage program

2012-09-10 Thread Martin Kletzander
On 09/10/2012 03:58 PM, Michal Privoznik wrote: --- .gitignore |1 + Makefile.am |2 +- configure.ac | 12 ++- examples/Makefile.am | 21 examples/virtxml.c | 317 ++ 5 files changed, 351

Re: [libvirt] [libvirt-designer][PATCH v2 4/4] domain: Introduce interface support

2012-09-10 Thread Martin Kletzander
On 09/10/2012 03:58 PM, Michal Privoznik wrote: Let users add NICs to domains. --- examples/virtxml.c | 78 ++ libvirt-designer/libvirt-designer-domain.c | 83 libvirt-designer/libvirt-designer-domain.h |3

Re: [libvirt] [PATCH] docs: hacking.html.in: fix table of contents

2012-09-11 Thread Martin Kletzander
On 09/11/2012 02:01 PM, Ján Tomko wrote: Two sections didn't have a working link in the TOC. --- docs/hacking.html.in |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/hacking.html.in b/docs/hacking.html.in index eb79953..a97dc22 100644 ---

Re: [libvirt] [PATCH] docs: page.xsl: fix FAQ link in subdirectories

2012-09-11 Thread Martin Kletzander
On 09/11/2012 04:43 PM, Ján Tomko wrote: Links to the FAQ didn't work on pages in subdirectories, like devhelp/libvirt-virterror.html or internals/command.html, because they have had href_base prepended to them. --- docs/page.xsl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [libvirt] question about the commands: domhostname and hostname

2012-09-12 Thread Martin Kletzander
On 09/12/2012 07:59 AM, Li Zhang wrote: Sorry for wrong subject prefix of my mail, correct it. -:) The [libvirt] tag in the prefix is done automatically, you don't have to do that ;) On Wed, Sep 12, 2012 at 1:57 PM, Li Zhang zhlci...@gmail.com wrote: Hi all, I am testing the virsh

Re: [libvirt] question about the commands: domhostname and hostname

2012-09-12 Thread Martin Kletzander
On 09/12/2012 08:50 AM, Li Zhang wrote: On Wed, Sep 12, 2012 at 2:40 PM, Martin Kletzander mklet...@redhat.com wrote: On 09/12/2012 07:59 AM, Li Zhang wrote: Sorry for wrong subject prefix of my mail, correct it. -:) The [libvirt] tag in the prefix is done automatically, you don't have

Re: [libvirt] [PATCH v2 1/1] Backcompt for console devices in virDomainDeviceInfoIterate

2012-09-12 Thread Martin Kletzander
On 09/11/2012 04:57 AM, Li Zhang wrote: Histrically, the first console element is treated as the s/Histrically/Historically/ alias of a serial device. In the virDomainDeviceInfoIterate, This situation is not considered. It still handles the first console element as another devices, which

Re: [libvirt] [PATCH v2 1/1] Backcompt for console devices in virDomainDeviceInfoIterate

2012-09-12 Thread Martin Kletzander
On 09/12/2012 10:32 AM, Osier Yang wrote: On 2012年09月12日 16:06, Martin Kletzander wrote: On 09/11/2012 04:57 AM, Li Zhang wrote: Histrically, the firstconsole element is treated as the s/Histrically/Historically/ alias of aserial device. In the virDomainDeviceInfoIterate, This situation

Re: [libvirt] 'virsh snapshot-list' throws a segfault [with libvirt-0.9.13-3]

2012-09-12 Thread Martin Kletzander
On 09/12/2012 11:56 AM, Kashyap Chamarthy wrote: Hi, After creating a couple of external snapshots, running 'virsh snapshot-list $name' fails with a segfault. I wonder what's going on here: Hi, I believe you're hitting a bug #837544 [1]. Try newer version. Have a nice day, Martin [1]

[libvirt] [PATCH] Fix libvirtd crash possibility

2012-09-12 Thread Martin Kletzander
When generating RPC protocol messages, it's strictly needed to have continuousline of numbers or RPC messages. However in case anyone tries backporting some functionality and will skip a number, there is a possibility to make the daemon segfault with newer virsh (version of the library, rpc call,

[libvirt] [PATCH v2] Fix libvirtd crash possibility

2012-09-12 Thread Martin Kletzander
When generating RPC protocol messages, it's strictly needed to have continuousline of numbers or RPC messages. However in case anyone tries backporting some functionality and will skip a number, there is a possibility to make the daemon segfault with newer virsh (version of the library, rpc call,

Re: [libvirt] [libvirt-designer][PATCH 0/3] Another cleanup

2012-09-13 Thread Martin Kletzander
On 09/12/2012 05:09 PM, Michal Privoznik wrote: to address Chritophe's improvements hints. Michal Privoznik (3): init_check: Ignore DB loading errors get_supported_disk_bus_types: NULL is valid list add_disk_full: Only set error if !NULL libvirt-designer/libvirt-designer-domain.c

[libvirt] [PATCH 1/2] Add support for EOI with APIC

2012-09-13 Thread Martin Kletzander
New options is added to support EOI (End of Interrupt) exposure for guests. As it makes sense only when APIC is enabled, I added this into the apic element in features because this should be tri-state option (cannot be handled as standalone feature). --- docs/formatdomain.html.in | 7 +++

[libvirt] [PATCH 2/2] qemu: Add support for EOI with APIC

2012-09-13 Thread Martin Kletzander
This patch adds full support for EOI setting for domains. Because this is CPU feature (flag), the model needs to be added even when it's not specified. Fortunately this problem was already solved with kvmclock, so this patch simply abuses that. And due to the size of the patch (17 lines) I dared

Re: [libvirt] [PATCH 2/2] qemu: Add support for EOI with APIC

2012-09-14 Thread Martin Kletzander
On 09/13/2012 04:52 PM, Michal Privoznik wrote: On 13.09.2012 16:12, Martin Kletzander wrote: This patch adds full support for EOI setting for domains. Because this is CPU feature (flag), the model needs to be added even when it's not specified. Fortunately this problem was already solved

<    3   4   5   6   7   8   9   10   11   12   >