This patch fixes building a command-line for QEMU machines without KVM
acceleration and is based on following assumptions:
- QEMU_CAPS_KVM flag means that QEMU is capable of running KVM
accelerated machine (not that it knows about KVM at all, even
though there is probably no QEMU that
This patch fixes building a command-line for QEMU machines without KVM
acceleration and is based on following assumptions:
- QEMU_CAPS_KVM flag means that QEMU is running KVM accelerated
machines by default (without explicitely requesting that using a
command-line option). It is the
On 10/29/2012 07:07 AM, liguang wrote:
ignore *.patch, cscope.po.out, cscope.in.out
Signed-off-by: liguang lig.f...@cn.fujitsu.com
---
.gitignore |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/.gitignore b/.gitignore
index 1cd2d45..d2d6657 100644
---
On 10/29/2012 10:38 AM, Jiri Denemark wrote:
On Thu, Oct 25, 2012 at 16:37:37 +0200, Ján Tomko wrote:
In the XML warning, this prints uuids for domain names with special
characters in them and shell-escaped names for other elements (like
snapshosts and networks) with special names.
---
When
After separating 5.x and 5.1 versions of ESX, we forgot to add 5.1
into the list of allowed connections, so connections to 5.1 fail since
v1.0.0-rc1-5-g1e7cd39
---
src/esx/esx_driver.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c
index
On 10/30/2012 08:49 AM, Michal Privoznik wrote:
On 30.10.2012 08:35, Martin Kletzander wrote:
After separating 5.x and 5.1 versions of ESX, we forgot to add 5.1
into the list of allowed connections, so connections to 5.1 fail since
v1.0.0-rc1-5-g1e7cd39
---
src/esx/esx_driver.c | 2 ++
1
On 10/29/2012 04:18 PM, Michal Privoznik wrote:
through which user set under what permissions does sanlock
daemon run so libvirt will set the same permissions for
files exposed to it.
---
diff to v1:
-update spec file so sanlock dir is installed with root:sanlock
iff group sanlock exists
On 10/31/2012 12:44 AM, Eric Blake wrote:
On 10/28/2012 06:55 AM, Martin Kletzander wrote:
When there is no 'qemu-kvm' binary and the emulator used for a machine
is, for example, 'qemu-system-x86_64' that, by default, runs without
kvm enabled, libvirt still supplies '-no-kvm' option
On 10/31/2012 11:19 AM, Peter Krempa wrote:
There are multiple reasons canonicalize_file_name() used in
absolutePathFromBaseFile helper can fail. This patch enhances error
reporting from that helper.
---
src/util/storage_file.c | 35 ---
1 file changed, 24
On 10/31/2012 01:29 PM, Leonardo Arena wrote:
Hi,
I was invited to show up here regarding BZ 871756. I'm the maintainer of
libvirt on Alpine Linux [1], an uclibc-based distro.
Hi, thanks for looking at it. It's good to hear there is only one
function missing when building on uclibc.
https://bugzilla.redhat.com/show_bug.cgi?id=871312
Recent fixes made almost all the right steps to make emulator pinned
to the cpuset of the whole domain in case emulatorpin isn't
specified, but qemudDomainGetEmulatorPinInfo still reports all the
CPUs even when cpuset is specified. This patch
On 10/31/2012 04:11 PM, Jiri Denemark wrote:
On Wed, Oct 31, 2012 at 16:03:53 +0100, Martin Kletzander wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=871312
Recent fixes made almost all the right steps to make emulator pinned
to the cpuset of the whole domain in case emulatorpin isn't
On 10/31/2012 03:42 PM, Eric Blake wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=871756
Commit cd1e8d1 assumed that systems new enough to have journald
also have mkostemp; but this is not true for uclibc.
For that matter, use of mkstemp[s] is unsafe in a multi-threaded
program. We
On 10/31/2012 04:48 PM, Michal Privoznik wrote:
---
.gitignore |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/.gitignore b/.gitignore
index 98ce398..79a055b 100644
--- a/.gitignore
+++ b/.gitignore
@@ -193,6 +193,7 @@ results.log
stamp-h
stamp-h.in
On 10/31/2012 04:48 PM, Eric Blake wrote:
Commit 905be03d2 quit using the abstract namespace, but didn't
update the --help text to match.
* daemon/libvirtd.c (daemonUsage): Correct socket listing.
---
See also:
https://www.redhat.com/archives/libvirt-users/2012-October/msg00152.html
On 11/01/2012 04:53 PM, Leonardo Arena wrote:
On Thu, 2012-11-01 at 14:51 +0100, Martin Kletzander wrote:
On 11/01/2012 02:32 PM, Leonardo Arena wrote:
On Wed, 2012-10-31 at 10:10 -0600, Eric Blake wrote:
On 10/31/2012 09:45 AM, Martin Kletzander wrote:
On 10/31/2012 03:42 PM, Eric Blake
On 11/02/2012 12:15 PM, Jiri Denemark wrote:
An obsolete version of the patch that fixed building on systems with
uclibc (4dbd6e96) was accidentally pushed as part of the release commit
(2b435c15). Since this obsolete patch made syntax-check, commit 30b398d5
was pushed to fix that issue. But
On 11/05/2012 08:04 AM, Osier Yang wrote:
QEMU supports to set vendor and product strings for disk since
1.2.0 (only scsi-disk, scsi-hd, scsi-cd support it), this patch
exposes it with new XML elements vendor and product of disk
device.
---
docs/formatdomain.html.in
On 11/05/2012 05:59 AM, liguang wrote:
ignore cscope.in.out, cscope.po.out
Signed-off-by: liguang lig.f...@cn.fujitsu.com
---
.gitignore |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/.gitignore b/.gitignore
index 79a055b..12fbe0e 100644
--- a/.gitignore
+++
After the connection to ESX 5.1 being broken since g1e7cd39, the fix
in bab7752c helped a bit, but still missed a spot, so the connection
is now successful, but some APIs (for example defineXML) don't work.
Two cases missing are added in this patch to avoid that.
---
src/esx/esx_vi.c | 4 +++-
1
On 11/06/2012 11:00 AM, Peter Krempa wrote:
On 11/06/12 10:22, Martin Kletzander wrote:
After the connection to ESX 5.1 being broken since g1e7cd39, the fix
in bab7752c helped a bit, but still missed a spot, so the connection
is now successful, but some APIs (for example defineXML) don't work
On 11/01/2012 11:53 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
[...]
---
build-aux/bracket-spacing.pl | 116
+++
cfg.mk | 7 ++-
docs/hacking.html.in | 49 ++
3 files
On 11/08/2012 02:52 AM, Dave Allan wrote:
On Thu, Nov 08, 2012 at 09:28:06AM +0800, Osier Yang wrote:
On 2012年11月08日 05:04, Dave Allan wrote:
On Wed, Nov 07, 2012 at 11:24:43PM +0800, Osier Yang wrote:
On 2012年11月05日 21:34, Martin Kletzander wrote:
On 11/05/2012 08:04 AM, Osier Yang wrote
On 11/11/2012 10:25 AM, Toralf Förster wrote:
I've a stable Gentoo Linux, the build log is attached.
It's hard to say from the log, but you can check yourselves what the
problem is by running the particular test like this:
VIR_TEST_DEBUG=1 ./virdrivermoduletest
in the tests/ directory after
The error ... but the cause is unknown appeared for XMLs similar to
this:
disk type='file' device='cdrom'
driver name='qemu' type='raw'/
source file='/dev/zero'/
target dev='sr0'/
/disk
Notice unsupported disk type (for the driver), but also no address
specified. The first part is not
On 11/20/2012 03:27 PM, Peter Krempa wrote:
On 11/20/12 14:55, Martin Kletzander wrote:
The error ... but the cause is unknown appeared for XMLs similar to
this:
disk type='file' device='cdrom'
driver name='qemu' type='raw'/
source file='/dev/zero'/
target dev='sr0'/
/disk
On 11/20/2012 03:45 PM, Daniel P. Berrange wrote:
On Tue, Nov 20, 2012 at 02:55:28PM +0100, Martin Kletzander wrote:
The error ... but the cause is unknown appeared for XMLs similar to
this:
disk type='file' device='cdrom'
driver name='qemu' type='raw'/
source file='/dev/zero
The error ... but the cause is unknown appeared for XMLs similar to
this:
disk type='file' device='cdrom'
driver name='qemu' type='raw'/
source file='/dev/zero'/
target dev='sr0'/
/disk
Notice unsupported disk type (for the driver), but also no address
specified. The first part is not
The 'virsh domdisplay' command is able to display the password
configured for spice, but it was missing for vnc type graphics.
This is just a simple patch for that to work properly.
---
tools/virsh-domain.c | 17 +
1 file changed, 17 insertions(+)
diff --git
On 11/21/2012 04:39 PM, Daniel P. Berrange wrote:
On Wed, Nov 21, 2012 at 04:37:35PM +0100, Martin Kletzander wrote:
The 'virsh domdisplay' command is able to display the password
configured for spice, but it was missing for vnc type graphics.
This is just a simple patch for that to work
On 11/21/2012 05:06 PM, Ján Tomko wrote:
On 11/21/12 16:37, Martin Kletzander wrote:
The 'virsh domdisplay' command is able to display the password
configured for spice, but it was missing for vnc type graphics.
This is just a simple patch for that to work properly.
---
tools/virsh-domain.c
On 11/21/2012 11:50 PM, Doug Goldstein wrote:
On Wed, Nov 21, 2012 at 10:13 AM, Martin Kletzander mklet...@redhat.com
wrote:
On 11/21/2012 05:06 PM, Ján Tomko wrote:
On 11/21/12 16:37, Martin Kletzander wrote:
The 'virsh domdisplay' command is able to display the password
configured
On 11/22/2012 11:03 AM, Peter Krempa wrote:
When the value of memspec was empty taking of a snapshot failed without
reporting an error.
---
This is only a quick fix. I think we should improve vshCommandOptStr to detect
this for us and report an appropriate error, but this change will require
On 11/22/2012 02:10 PM, Peter Krempa wrote:
On 11/22/12 11:34, Martin Kletzander wrote:
The 'virsh domdisplay' command is able to display the password
configured for spice, but it was missing for vnc type graphics.
Also, there were some inconsistencies that are cleaned now
On 11/22/2012 02:16 PM, Peter Krempa wrote:
On 11/20/12 16:20, Martin Kletzander wrote:
The error ... but the cause is unknown appeared for XMLs similar to
this:
disk type='file' device='cdrom'
driver name='qemu' type='raw'/
source file='/dev/zero'/
target dev='sr0'/
/disk
On 11/22/2012 03:05 PM, Peter Krempa wrote:
The new model supports following features in addition to those supported
by SandyBridge:
fma, movbe, fsgsbase, bmi1, hle, avx2, smep, bmi2, erms, invpcid, rtm
missing 'pcid' flag
---
Based on:
Just a little rewrite of the cmdDomDisplay function to make it
consistent and hopefully more readable. This also fixes a problem
with password not being displayed for vnc even with the
--include-password option.
---
tools/virsh-domain.c | 132 +--
On 11/22/2012 05:48 PM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The docs for virDiskNameToIndex claim it ignores partition
numbers. In actual fact though, a code ordering buy means
s/buy/bug/
that a partition number will cause the code to accidentally
On 11/22/2012 04:48 PM, Peter Krempa wrote:
On 11/22/12 15:52, Martin Kletzander wrote:
On 11/22/2012 03:05 PM, Peter Krempa wrote:
[...]
According to the qemu patch, the model should be only adding features,
but I see rdtscp disappeared between SandyBridge and Haswell. The
question
On 11/22/2012 05:48 PM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The virLXCControllerClientCloseHook method was mistakenly
assuming that the private data associated with the network
client was the virLXCControllerPtr. In fact it was just a
dummy int, so we were
On 11/23/2012 09:02 AM, Osier Yang wrote:
---
src/util/pci.c | 14 ++
1 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/src/util/pci.c b/src/util/pci.c
index d1ad121..191f99d 100644
--- a/src/util/pci.c
+++ b/src/util/pci.c
@@ -1860,10 +1860,9 @@
On 11/22/2012 05:48 PM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
It is possible for there to be deleted timers when we
calculate the next timeout, and they must be skipped.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/util/event_poll.c | 2
On 11/23/2012 09:20 AM, Christophe Fergeau wrote:
On Thu, Nov 22, 2012 at 11:32:38AM +0100, Ján Tomko wrote:
On 11/22/12 11:03, Martin Kletzander wrote:
I'll rework it to make it as URI as possible then. Just one question,
though (for anyone, I guess); why do we append port as a parameter
On 11/22/2012 02:41 PM, Peter Krempa wrote:
When the value of memspec was empty taking of a snapshot failed without
reporting an error.
---
tools/virsh-snapshot.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/tools/virsh-snapshot.c
On 11/28/2012 06:08 AM, Laine Stump wrote:
This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=879473
The name attribute is required for portgroup elements (yes, the RNG
specifies that), and there is code in libvirt that assumes it is
non-null. Unfortunately, the portgroup parsing
On 11/28/2012 09:08 AM, Ján Tomko wrote:
In qemuDomainSaveMemory, wrapperFd might be NULL and should be checked before
calling virFileWrapperFdCatchError. Same in doCoreDump.
Bug: https://bugzilla.redhat.com/show_bug.cgi?id=880919
---
src/qemu/qemu_driver.c |6 --
1 files changed,
On 11/28/2012 04:37 AM, Hu Tao wrote:
On Mon, Nov 26, 2012 at 03:25:04PM -0700, Eric Blake wrote:
Although we require various C99 features, we don't yet require a
complete C99 compiler. On RHEL 5, compilation complained:
qemu/qemu_command.c: In function 'qemuBuildGraphicsCommandLine':
On 11/28/2012 02:38 PM, Peter Krempa wrote:
On 11/22/12 16:24, Martin Kletzander wrote:
[...]
+/* We can query this info for all the graphics types since we'll
+ * get nothing for the unsupported ones (just rdp for now).
+ * Also the parameter '--include-password
On 11/28/2012 05:55 PM, Laine Stump wrote:
On 11/28/2012 04:19 AM, Martin Kletzander wrote:
On 11/28/2012 06:08 AM, Laine Stump wrote:
This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=879473
The name attribute is required for portgroup elements (yes, the RNG
specifies
This is a request for adding a VMmanager application as requested and
described by Ksenya Phil.
Signed-off-by: Ksenya Phil philka2...@mail.ru
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
docs/apps.html.in | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/apps.html.in
On Thu, Mar 06, 2014 at 09:35:47AM +, qiaonuo...@cn.fujitsu.com wrote:
--memory-only option is introduced without compression supported. Therefore,
this is a freature regression of virsh dump. Now qemu has support dumping
memory
s/freature/feature/
but I would not use the word regression
On Thu, Mar 06, 2014 at 09:35:47AM +, qiaonuo...@cn.fujitsu.com wrote:
s/to/for/ in the $SUBJ or you can rephrase it to:
qemu: add support for virDomainCoreDumpWithFormat API
This patch makes qemu driver supprot virDomainCoreDumpWithFormat API.
s/supprot/support/
And again like with
On Thu, Mar 06, 2014 at 09:35:47AM +, qiaonuo...@cn.fujitsu.com wrote:
This patch is used to add --compress and [--compression-format] string
to
s/is used to add/adds/
virsh dump --memory-only. And virsh dump --memory-only is going be
implemented by new virDomainCoreDumpWithFormat API.
On Wed, Mar 12, 2014 at 11:15:43AM -0600, Eric Blake wrote:
Revisiting an older thread
On 11/26/2013 07:38 AM, Martin Kletzander wrote:
On Tue, Nov 26, 2013 at 10:14:36AM +, Daniel P. Berrange wrote:
On Tue, Nov 26, 2013 at 10:58:25AM +0100, Martin Kletzander wrote:
Adding a support
On Wed, Mar 12, 2014 at 06:57:30AM -0600, Eric Blake wrote:
On 03/12/2014 01:30 AM, Martin Kletzander wrote:
This is a request for adding a VMmanager application as requested and
described by Ksenya Phil.
Signed-off-by: Ksenya Phil philka2...@mail.ru
Signed-off-by: Martin Kletzander
On Wed, Mar 12, 2014 at 05:18:22PM +, Daniel P. Berrange wrote:
On Thu, Mar 06, 2014 at 09:35:47AM +, qiaonuo...@cn.fujitsu.com wrote:
This patch is used to add --compress and [--compression-format]
string to
virsh dump --memory-only. And virsh dump --memory-only is going be
On Wed, Mar 12, 2014 at 09:29:55AM -0600, Eric Blake wrote:
On 03/12/2014 09:04 AM, Martin Kletzander wrote:
On Thu, Mar 06, 2014 at 09:35:47AM +, qiaonuo...@cn.fujitsu.com wrote:
--memory-only option is introduced without compression supported.
Therefore,
this is a freature
On Thu, Mar 13, 2014 at 09:22:30AM +, qiaonuo...@cn.fujitsu.com wrote:
On 03/13/2014 03:40 PM, Martin Kletzander wrote:
On Wed, Mar 12, 2014 at 05:18:22PM +, Daniel P. Berrange wrote:
On Thu, Mar 06, 2014 at 09:35:47AM +,qiaonuo...@cn.fujitsu.com
wrote:
This patch
On Thu, Mar 13, 2014 at 09:20:09AM +, qiaonuo...@cn.fujitsu.com wrote:
On 03/12/2014 11:04 PM, Martin Kletzander wrote:
diff --git c/src/test/test_driver.c i/src/test/test_driver.c
index 39b3066..20f7bb3 100644
--- c/src/test/test_driver.c
+++ i/src/test/test_driver.c
@@ -2436,6
On Thu, Mar 13, 2014 at 09:26:16AM +, Wangrui (K) wrote:
From 81de0ce710bad91a2df18247e681b5a83872b8d5 Mon Sep 17 00:00:00 2001
From: Wang Rui moon.wang...@huawei.com
Date: Thu, 13 Mar 2014 17:05:03 +
Subject: [PATCH] hotplug:Fix log mistake in qemuMonitorAddNetdev
VIR_DEBUG in
On Mon, Mar 17, 2014 at 09:37:46AM +, Daniel P. Berrange wrote:
On Thu, Mar 13, 2014 at 08:42:40AM +0100, Martin Kletzander wrote:
On Wed, Mar 12, 2014 at 09:29:55AM -0600, Eric Blake wrote:
On 03/12/2014 09:04 AM, Martin Kletzander wrote:
On Thu, Mar 06, 2014 at 09:35:47AM +
On Mon, Mar 17, 2014 at 11:40:39AM +, Daniel P. Berrange wrote:
The ebiptablesCreateRuleInstanceIterate creates a
virNWFilterVarCombIterPtr instance and iterates over
it. Unfortunately in doing so, it discards the original
pointer. At the end of the method it will thus effectively
do
On Mon, Mar 17, 2014 at 12:33:24PM +, Daniel P. Berrange wrote:
On Mon, Mar 17, 2014 at 11:40:39AM +, Daniel P. Berrange wrote:
The ebiptablesCreateRuleInstanceIterate creates a
virNWFilterVarCombIterPtr instance and iterates over
it. Unfortunately in doing so, it discards the
On Mon, Mar 17, 2014 at 12:34:21PM +, Daniel P. Berrange wrote:
The virNWFilterVarCombIterNext method will free its
parameter when it gets to the end of the iterator.
This is somewhat misleading design, making it appear
as if the caller has a memory leak. Remove the free'ing
of the
This patch is not trying to fix every switch, just the ones I worked
with last time, because some of these were especially unreadable.
Covers enums virDomainGraphicsType and virDomainChrType (where
applicable).
Also sort it's cases by their value.
Signed-off-by: Martin Kletzander mklet
Eliminate all the code re-use which checks for priv-agentError or
priv-agent.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_domain.c | 22 +
src/qemu/qemu_domain.h | 4 ++
src/qemu/qemu_driver.c | 121 ++---
3 files
Commit a1cbe4b5 added a check for spaces around assignments and this
patch extends it to checks for spaces around '=='. One exception is
virAssertCmpInt where comma after '==' is aceptable (since it is a
macro and '==' is its argument).
Signed-off-by: Martin Kletzander mklet...@redhat.com
If there should be some sort of separator it is better to use comment
with the filename, copyright, description, license information and
authors.
Found by:
git grep -nH '^$' | grep '\.[ch]:1:'
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
If any reviewer wants I can add
When ran, cil is throwing out some errors and warnings for obsolete
'or' unused variables and wrong module name (it should not contain a
hyphen; hence the rename).
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
I still can't run it successfully, but no matter what we'll do
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/conf/domain_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index e566140..2a7d78f 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -6495,7
On Tue, Mar 18, 2014 at 12:07:17AM -0600, Laine Stump wrote:
A patch submitted by Steven Malin last week pointed out a problem with
libvirt's DNS SRV record configuration:
https://www.redhat.com/archives/libvir-list/2014-March/msg00536.html
When searching for that message later, I found
On Tue, Mar 18, 2014 at 08:05:51AM +0100, Michal Privoznik wrote:
On 10.03.2014 12:26, Martin Kletzander wrote:
Addition of vshConnect() makes virConnectOpen() functions obsolete in
virsh. Thus all virsh-*.[ch] files should be left only with
vshConnect() in the case of need.
Signed-off
On Tue, Mar 18, 2014 at 08:05:54AM +0100, Michal Privoznik wrote:
On 10.03.2014 12:26, Martin Kletzander wrote:
Introducing keepalive similarly to Guannan around 2 years ago. Since
we want to introduce keepalive for every connection, it makes sense to
wrap the connecting function into new
On Tue, Mar 18, 2014 at 01:02:24PM +0530, Nehal J Wani wrote:
While running qemuxml2xmltest, it was found that valgrind pointed out
the following memory leak:
==21905== 26 bytes in 1 blocks are definitely lost in loss record 23 of 69
==21905==at 0x4A069EE: malloc
On Mon, Mar 17, 2014 at 09:25:13AM -0600, Eric Blake wrote:
On 03/17/2014 08:39 AM, Martin Kletzander wrote:
Although not explicitly requested, we are using KR (or Kernel)
indentation for curly braces around functions in HACKING file and most
of the code. The rest is inconsistent
On Tue, Mar 18, 2014 at 09:26:08AM +0100, Michal Privoznik wrote:
In the setPyVirTypedParameter we try to produce virTypedParameter
array from a pyhthon dictionary. However, when copying field name into
s/pyhthon/python/
item in returned array, we use strncpy() as the field name is fixed
On Tue, Mar 18, 2014 at 09:26:09AM +0100, Michal Privoznik wrote:
The @ret value is built in a loop. However, if in one iteration
there's an error, we should free all the fields built so far. For
instance, if there's an error and the previous item was
type of VIR_TYPED_PARAM_STRING we
On Mon, Mar 17, 2014 at 09:16:07AM -0600, Eric Blake wrote:
On 03/17/2014 08:39 AM, Martin Kletzander wrote:
Eliminate all the code re-use which checks for priv-agentError or
priv-agent.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_domain.c | 22
On Mon, Mar 17, 2014 at 09:19:02AM -0600, Eric Blake wrote:
On 03/17/2014 08:39 AM, Martin Kletzander wrote:
When ran, cil is throwing out some errors and warnings for obsolete
'or' unused variables and wrong module name (it should not contain a
hyphen; hence the rename).
Signed-off
On Mon, Mar 17, 2014 at 09:27:14AM -0600, Eric Blake wrote:
On 03/17/2014 08:39 AM, Martin Kletzander wrote:
If there should be some sort of separator it is better to use comment
with the filename, copyright, description, license information and
authors.
Found by:
git grep -nH
On Mon, Mar 17, 2014 at 09:40:46AM -0600, Eric Blake wrote:
On 03/17/2014 08:39 AM, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/conf/domain_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK
Pushed, thanks.
Martin
diff
On Tue, Mar 18, 2014 at 11:15:01AM +0100, Pavel Hrdina wrote:
On 17.3.2014 16:38, Eric Blake wrote:
On 03/17/2014 08:39 AM, Martin Kletzander wrote:
This patch is not trying to fix every switch, just the ones I worked
with last time, because some of these were especially unreadable
On Mon, Mar 17, 2014 at 09:44:45AM -0600, Eric Blake wrote:
On 03/17/2014 08:39 AM, Martin Kletzander wrote:
Commit a1cbe4b5 added a check for spaces around assignments and this
patch extends it to checks for spaces around '=='. One exception is
virAssertCmpInt where comma after
Just to align the backslashes with most of the file.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
Pushed as 'trivial'.
cfg.mk | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/cfg.mk b/cfg.mk
index e75323e..319210b 100644
--- a/cfg.mk
+++ b/cfg.mk
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/network/bridge_driver.c | 54 ++---
1 file changed, 36 insertions(+), 18 deletions(-)
diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index 59b6c09..20930f3 100644
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
tests/commandhelper.c| 5 +++--
tests/qemuargv2xmltest.c | 3 ++-
tests/shunloadhelper.c | 5 +++--
tests/testutils.c| 15 +-
tests/testutilslxc.c | 3 ++-
tests/testutilsqemu.c| 3 ++-
tests
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/util/vircgroup.c | 9 ++---
src/util/virconf.c | 5 +++--
src/util/virdbus.c | 8 +---
src/util/virerror.c | 3 ++-
src/util/vireventpoll.c | 29
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/xen/xen_driver.c | 6 --
src/xen/xen_hypervisor.c | 5 +++--
src/xen/xm_internal.c | 10 +++---
src/xenapi/xenapi_utils.c | 5 +++--
src/xenxs/xen_xm.c| 35 +++
5 files
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/rpc/virnetserver.c | 8 +---
src/rpc/virnetserverclient.c | 5 +++--
src/rpc/virnettlscontext.c | 5 +++--
3 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c
index
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/uml/uml_conf.c | 5 ++--
src/uml/uml_driver.c | 78 ++--
2 files changed, 55 insertions(+), 28 deletions(-)
diff --git a/src/uml/uml_conf.c b/src/uml/uml_conf.c
index 3567b03..53a880f
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/lxc/lxc_driver.c | 30 --
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
index 1ae04c5..3104bf9 100644
--- a/src/lxc/lxc_driver.c
+++ b/src/lxc
Although not explicitly requested, we are using KR (or Kernel)
indentation for curly braces around functions in HACKING file and most
of the code. Using grep -P, this patch add the syntax-check rule for
it (while skipping all the false positives with foreach constructs).
Signed-off-by: Martin
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/qemu/qemu_agent.c| 5 ++-
src/qemu/qemu_command.c | 6 ++-
src/qemu/qemu_driver.c | 94 +---
src/qemu/qemu_migration.c| 3 +-
src/qemu/qemu_monitor.c | 3 +-
src
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/openvz/openvz_conf.c | 15 ++-
src/openvz/openvz_driver.c | 45 ++---
2 files changed, 40 insertions(+), 20 deletions(-)
diff --git a/src/openvz/openvz_conf.c b/src/openvz
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/conf/domain_conf.c | 9 +---
src/conf/domain_nwfilter.c | 13 +++
src/conf/interface_conf.c | 54 ++
src/conf/nwfilter_conf.c | 30 +-
src/conf
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/vbox/vbox_driver.c | 5 +-
src/vbox/vbox_tmpl.c | 188 +
2 files changed, 132 insertions(+), 61 deletions(-)
diff --git a/src/vbox/vbox_driver.c b/src/vbox/vbox_driver.c
index e26b10a
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/nwfilter/nwfilter_driver.c| 32 +++-
src/nwfilter/nwfilter_ebiptables_driver.c | 3 ++-
src/nwfilter/nwfilter_learnipaddr.c | 41 ---
3 files changed, 50 insertions
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/test/test_driver.c | 135 -
1 file changed, 90 insertions(+), 45 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 5716449..d88d3fc 100644
--- a/src/test
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/storage/storage_backend_fs.c | 12 ---
src/storage/storage_driver.c | 78 ++--
2 files changed, 60 insertions(+), 30 deletions(-)
diff --git a/src/storage/storage_backend_fs.c b/src/storage
On Tue, Mar 18, 2014 at 09:45:14PM -0400, Stefan Berger wrote:
From: Stefan Berger stef...@linux.vnet.ibm.com
https://bugzilla.redhat.com/show_bug.cgi?id=1071181
Commit 49b59a15 fixed one problem but masks another one related to pointer
freeing.
Use virAtomicIntGet() to test for 0 rather
901 - 1000 of 5738 matches
Mail list logo
