On 07.12.2015 20:25, Vasiliy Tolstov wrote:
> 07 дек. 2015 г. 18:13 пользователь "Daniel P. Berrange"
> написал:
>>
>> On Mon, Dec 07, 2015 at 04:04:40PM +0100, Michal Privoznik wrote:
>>> On 07.12.2015 14:51, Daniel P. Berrange wrote:
>>>>
On 07.12.2015 14:06, Daniel P. Berrange wrote:
> On Mon, Dec 07, 2015 at 02:01:11PM +0100, Michal Privoznik wrote:
>> On 07.12.2015 13:58, Daniel P. Berrange wrote:
>>> On Mon, Dec 07, 2015 at 01:57:20PM +0100, Michal Privoznik wrote:
>>>> On 07.12.2015 13:55, Daniel
ned-off-by: Michal Privoznik
---
src/util/virnetdevmacvlan.c | 34 --
1 file changed, 4 insertions(+), 30 deletions(-)
diff --git a/src/util/virnetdevmacvlan.c b/src/util/virnetdevmacvlan.c
index 9384b9f..4657ff2 100644
--- a/src/util/virnetdevmacvlan.c
+++
Patches 1, 2, 3, 6, 7 have been ACKed in previous round. However, I did
slightly change them to reflect Laine's review suggestions.
Patch 4 has not been ACKed yet, patch 5 is new.
Michal Privoznik (7):
virNetDevMacVLanCreateWithVPortProfile: Turn vnet_hdr into flag
virNetDevMacVLanTa
For the multiqueue on macvtaps we are going to need to open
the device multiple times. Currently, this is not supported.
Rework the function, so that upper layers can be reworked too.
Signed-off-by: Michal Privoznik
---
src/util/virnetdevmacvlan.c | 57
So yet again one of integer arguments that we use as a boolean.
Since the argument count of the function is unbearably long
enough, lets turn those booleans into flags.
Signed-off-by: Michal Privoznik
---
src/lxc/lxc_process.c | 2 +-
src/qemu/qemu_command.c | 5 ++---
src/util
For the multiqueue on macvtaps we are going to need to open
the device multiple times. Currently, this is not supported.
Rework the function, so that upper layers can be reworked too.
Signed-off-by: Michal Privoznik
---
src/util/virnetdevmacvlan.c | 66
for
TUN/TAP devices.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_command.c | 45 ++---
src/qemu/qemu_command.h | 2 ++
src/qemu/qemu_hotplug.c | 16 +---
3 files changed, 41 insertions(+), 22 deletions(-)
diff --git a/src/qemu
On 10.12.2015 17:52, Laine Stump wrote:
> On 12/10/2015 02:38 AM, Michal Privoznik wrote:
>> Patches 1, 2, 3, 6, 7 have been ACKed in previous round. However, I did
>> slightly change them to reflect Laine's review suggestions.
>> Patch 4 has not been ACKed yet, pa
vlan.lo] Error 1
So, whenever user wants us to enable the feature on such systems,
we will just throw a runtime error instead.
Signed-off-by: Michal Privoznik
---
src/util/virnetdevmacvlan.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/util/virnetdevmacvlan.c b/src/util/virn
re even passing down to the function, we can
move the condition into the function and drop useless argument.
Signed-off-by: Michal Privoznik
---
src/util/virnetdevmacvlan.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/src/util/virnetdevmacvl
Like we are doing for TUN/TAP devices, we should do the same for
macvtaps. Although, it's not as critical as in that case, we
should do it for the consistency.
Signed-off-by: Michal Privoznik
---
src/util/virnetdevmacvlan.c | 40 ++--
1 file change
For the multiqueue on macvtaps we are going to need to open
the device multiple times. Currently, this is not supported.
Rework the function, so that upper layers can be reworked too.
Signed-off-by: Michal Privoznik
---
src/lxc/lxc_process.c | 1 +
src/qemu/qemu_command.c | 21
On 14.12.2015 11:23, Ian Campbell wrote:
> Hello,
>
> On Thu, 2015-12-10 at 08:38 +0100, Michal Privoznik wrote:
>> Like we are doing for TUN/TAP devices, we should do the same for
>> macvtaps. Although, it's not as critical as in that case, we
>> should do it f
-off-by: Michal Privoznik
---
src/qemu/qemu_monitor_json.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index 84c0be2..4ae63cf 100644
--- a/src/qemu/qemu_monitor_json.c
+++ b/src/qemu/qemu_monitor_json.c
On 15.12.2015 11:08, Pavel Hrdina wrote:
> Commit 256496e1 introduced a detection if "is locked" in error replay
> from qemu monitor. Commit c4073657 fixed a memory leak, but it was
> pointed out by Peter, that this could be done cleaner without
> stringifing the replay.
>
> Signed-off-by: Pavel H
On 02.12.2015 10:50, Vasiliy Tolstov wrote:
> Hi! I'm happy with libvirt volume download/upload ability, but also i
> need to download snapshot, what is the best way to do that?
> Define volume from snapshot? Or write libvirt function for this?
>
Defining a volume would be just to workaround the
On 07.12.2015 21:47, John Ferlan wrote:
> Rework virStorageBackendLogicalFindPoolSources a bit to create a
> helper virStorageBackendLogicalGetPoolSources that will make the
> pvs call in order to generate a list of associated pv_name and vg_name's.
>
> A future patch will make use of this for sta
On 07.12.2015 21:47, John Ferlan wrote:
> Refactor code to use standard return functioning with respect to setting
> a ret value and going to cleanup.
>
> Signed-off-by: John Ferlan
> ---
> src/storage/storage_backend_fs.c | 12
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
>
On 07.12.2015 21:47, John Ferlan wrote:
> Refactor the code that builds the pool source string during the FS
> storage pool mount to be a separate helper.
>
> A future patch will use the helper in order to validate the mounted
> FS matches the pool's expectation during poolCheck processing
>
> Si
On 07.12.2015 21:47, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1025230
>
> Add a new helper virStorageBackendLogicalMatchPoolSource to compare the
> pool's source name against the output from a 'pvs' command to list all
> volume group physical volume data on the host. In ad
On 07.12.2015 21:47, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1025230
>
> When determining whether a FS pool is mounted, rather than assuming that
> the FS pool is mounted just because the target.path is in the mount list,
> let's make sure that the FS pool source matches w
On 08.12.2015 15:17, Dmitry Andreev wrote:
> Found this message right after I'v sent the patch.
> https://www.redhat.com/archives/libvir-list/2015-January/msg00446.html
Right. When I came across this patch set I recalled having some
discussion about it a long time ago (in fact as it turns out mere
On 09.12.2015 16:48, Mikhail Feoktistov wrote:
> ---
>
> diff from v1.
> Remove call of vzDomainSuspend() in case of VIR_DOMAIN_START_PAUSED flag is
> set.
> Now we don't support to create instance in stopped state.
>
> src/vz/vz_driver.c | 24
> 1 file changed, 24 i
On 25.11.2015 20:11, John Ferlan wrote:
> Rather than continually cut/paste the "pool" option for pool command
> option structures, generate a macro which will commonly define it for
> any command. Then of course use that macro.
>
> Signed-off-by: John Ferlan
> ---
> tools/virsh-pool.c | 91
>
On 25.11.2015 20:11, John Ferlan wrote:
> Although not currently used in more than one command, it soon will be
> so create a common macro to be used in the new command location.
>
> Additionally, add the ".flags = 0," for both to match the expections
> of the structure being predefined.
>
> Sign
On 25.11.2015 20:11, John Ferlan wrote:
> Although they both are the same now, a future patch will add new options
> to pool-create-as. So create a common macro to capture commonality, then
> use that in the command specific structure.
>
> Signed-off-by: John Ferlan
> ---
> tools/virsh-pool.c |
On 25.11.2015 20:11, John Ferlan wrote:
> Rather than continually cut/paste the "file" option for pool command
> option structures, generate a macro which will commonly define it for
> any command. Then of course use that macro.
>
> Signed-off-by: John Ferlan
> ---
> tools/virsh-pool.c | 21 +++
On 25.11.2015 20:11, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=830056
>
> Utilize recently added VIR_STORAGE_POOL_CREATE_WITH_BUILD* flags in
> order to pass the flags along to the virStoragePoolCreateXML and
> virStoragePoolCreate API's.
>
> This affects the 'virsh pool-cr
On 25.11.2015 20:11, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=830056
>
> Add flags handling to the virStoragePoolCreate and virStoragePoolCreateXML
> API's which will allow the caller to provide the capability for the storage
> pool create API's to also perform a pool build
On 10.12.2015 07:34, Leno Hou wrote:
> 1. When switching CPUs to offline/online in a system more than 128 cpus
> 2. When using virsh to destroy domain in a system with more interface
>
> All of above happens nl_recv returned with error: No buffer space available.
> This patch set socket buffer siz
same story with network based
volumes, copy-on-write filesystems, and so on. Since there is no
way that an userland application can write onto specific areas on
disk, all that we can do is document the fact.
Signed-off-by: Michal Privoznik
---
src/libvirt-storage.c | 16 +---
1 file ch
On 15.12.2015 22:32, Jim Fehlig wrote:
> Hi All,
>
> Ian Campbell recently attempted [1] to fix and issue around MAX_VIRT_VPUS
> on ARM that required adding a new XEND_CONFIG_VERSION. After some
> discussion [2] we decided to drop support for all of the old xend config
> versions and go with the v
On 16.12.2015 18:01, John Ferlan wrote:
> Commit id '71b803ac' assumed that the storage pool source device path
> was required for a 'logical' pool. This resulted in a failure to start
> a pool without any device path defined.
>
> So, adjust the virStorageBackendLogicalMatchPoolSource logic to
> r
On 17.12.2015 13:56, Ján Tomko wrote:
> Allow and anywhere under , not just at the top:
>
> error:XML document failed to validate against schema: Unable to validate
> doc against /usr/share/libvirt/schemas/domain.rng
> Expecting an element name, got nothing
> Invalid sequence in interleave
> Ele
On 24.11.2015 10:44, Cédric Bosdonnat wrote:
> Add a configure option to disable virt-login-shell build even if lxc is
> enabled.
> ---
> Diff to V1:
>
> * moved the configure.ac code into m4/virt-login-shell.m4
> * allow building virt-login-shell without lxc
> * Introduce WITH_SETUID_RPC_CLIEN
On 17.12.2015 16:23, Andrea Bolognani wrote:
> This replaces the virPCIKnownStubs string array that was used
> internally for stub driver validation.
>
> Advantages:
>
> * possible values are well-defined
> * typos in driver names will be detected at compile time
> * avoids having several c
On 17.12.2015 16:20, Andrea Bolognani wrote:
> While working on v2 of my series[1] intended to fix
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1272300
>
> I'm running into some smaller stuff that isn't necessarily strictly
> related to the issue at hand. The idea is to have this smaller pat
On 17.12.2015 16:23, Andrea Bolognani wrote:
> Since we don't detach unmanaged devices before attaching them to a
> domain, we shouldn't reattach them to rollback an error either.
> ---
> src/util/virhostdev.c | 14 --
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a
On 15.12.2015 23:20, Jim Fehlig wrote:
> From: Ian Campbell
>
> xend prior to 4.0 understands vcpus as maxvcpus and vcpu_avail
> as a bit map of which cpus are online (default is all).
>
> xend from 4.0 onwards understands maxvcpus as maxvcpus and
> vcpus as the number which are online (from 0..
On 17.12.2015 18:59, Andrea Bolognani wrote:
> This replaces the virPCIKnownStubs string array that was used
> internally for stub driver validation.
>
> Advantages:
>
> * possible values are well-defined
> * typos in driver names will be detected at compile time
> * avoids having several c
On 03.12.2015 00:18, John Ferlan wrote:
> Commit id '3c7590e0' added the ability to delete snapshots for rbd backends,
> but did not provide the virsh commands in order to handle that option.
>
> The first two patches fix a couple of minor nits - not using virCheckFlags
> in virStorageBackendRBDDe
On 17.12.2015 17:55, John Ferlan wrote:
> As a follow on to a recent series which created macros for various
> virsh-*.c command options, see:
>
> http://www.redhat.com/archives/libvir-list/2015-December/msg00672.html
>
> (although best to view by index since there are varying opinions on
> the m
Signed-off-by: Michal Privoznik
---
Changes | 4 +++-
Virt.xs | 5 +
lib/Sys/Virt/StoragePool.pm | 28
3 files changed, 36 insertions(+), 1 deletion(-)
diff --git a/Changes b/Changes
index 0b3e659..05643b5 100644
--- a
On 18.12.2015 20:30, John Ferlan wrote:
>
>
> On 12/17/2015 05:10 AM, Michal Privoznik wrote:
>> So you have a libvirt volume that you want to wipe out. But lets
>> say that the volume is actually a file stored on a journaled
>> filesystem. Overwriting it with zeroes
We have a build failure on mingw platform:4
https://ci.centos.org/job/libvirt-mingw/899/console
Michal Privoznik (3):
sysconf: Include unistd.h
tools: Include PIE_LDFLAGS at the correct place
tools: Disable virt-login-shell on mingw
m4/virt-login-shell.m4 | 18 +++---
src
:23: note: each undeclared identifier is
reported only once for each function it appears in
cc1: all warnings being treated as errors
While we could workaround sysconf(_SC_OPEN_MAX) issue, the binary
itself makes no sense on systems where no LXC can be spawned.
Signed-off-by: Michal Pri
The manpage for sysconf() suggest including unistd.h as the
function is declared there. Even though we are not hitting any
compile issues currently, let's include the correct header file
instead of relying on some hidden include chain.
Signed-off-by: Michal Privoznik
---
src/nodei
This is no functional change, but I find it disturbing that
something_LDADD contains PIE_LDFLAGS while something_LDFLAGS
doesn't.
Signed-off-by: Michal Privoznik
---
tools/Makefile.am | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/Makefile.am b/tools/Makefi
On 21.12.2015 11:20, Vasiliy Tolstov wrote:
> 2015-12-21 10:18 GMT+03:00 Michal Privoznik :
>> None that I know of. It's just that I've came across some discussion in
>> the office about volWipe and it just appeared to me that we ought to
>> have this documented.
&g
et iff the capability is
NOT set.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_capabilities.c | 2 +
src/qemu/qemu_capabilities.h | 1 +
src/qemu/qemu_process.c | 66 ++--
tests/qemucapabilitiesdata/cap
On 21.12.2015 18:17, Laine Stump wrote:
> virNetDevVPortProfileGetStatus() would log the following error:
>
>Could not find netlink response with expected parameters
>
> anytime a port profile DISASSOCIATE operation was done for 802.1Qbh,
> even though the disassociate had been successfully c
On 21.12.2015 18:17, Laine Stump wrote:
> These are all related to excessive, misleading, or missing info in
> logs when trying to debug problems with SR-IOV network
> devices.
>
>
> Patch 2 does change the logging to eliminate an error message when no
> error has occurred (or prevent overwriting
On 21.12.2015 18:17, Laine Stump wrote:
> The previous error message just indicated that the desired response
> couldn't be found, this patch tells what was desired, as well as
> listing out the entire table that had been in the netlink response, to
> give some kind of idea why it failed.
> ---
>
On 21.12.2015 16:07, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1293351
>
> I've came across a bit of a silly scenario, but long story short:
> after domain was resumed, the virDomainSetTime() API hung for 5
> seconds after which it failed with a
et iff the capability is
NOT set.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
src/qemu/qemu_domain.c | 11 ---
src/qemu/qemu_domain.h |
In the pkg-config file for libvirt-glib we have a typo:
Libs.private: @LIBVIRT_LIBS @GLIB2_LIBS@
Noticed the missing '@' after LIBVIRT_LIBS? Well, I just did.
Signed-off-by: Michal Privoznik
---
libvirt-glib-1.0.pc.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
While 'perl test-wrap-argv.pl' is not too long,
'./test-wrap-argv.pl' is shorter.
Signed-off-by: Michal Privoznik
---
tests/test-wrap-argv.pl | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100644 => 100755 tests/test-wrap-argv.pl
diff --git a/tests/te
On 23.12.2015 17:14, Andrea Bolognani wrote:
> Hi all,
>
> libvirt currently doesn't allow you to configure a guest with something
> like
>
>
>
>
>
>
>
This says you are configuring GUEST NUMA nodes, and last time I checked
qemu did not support non-continuous NUMA
In the upcoming patch we will need yet another #ifdef code block
depending on wireshark version. Instead of defining
WIRESHARK_COMPAT2 or something lets just compare the version
right at the place so that we can clearly see what version broke
API.
Signed-off-by: Michal Privoznik
---
tools
d-off-by: Michal Privoznik
---
tools/wireshark/src/packet-libvirt.c | 2 +-
tools/wireshark/util/genxdrstub.pl | 7 +--
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/tools/wireshark/src/packet-libvirt.c
b/tools/wireshark/src/packet-libvirt.c
index f7aa7ed..3103562 100644
handle this. I mean, at
wireshark they don't seem so committed to API stability as we are. Therefore
this patch set. In the long term I don't see us adapting to every single API
change, or do I? Although I am not sure what are our options here.
Michal Privoznik (5):
wiresha
ed in 84cc3daa (v1.10.0), however,
was not exposed until 5c05c9e0 (v1.10.0). Since we already are
requiring 1.11.3 or higher no other change is needed.
Signed-off-by: Michal Privoznik
---
tools/wireshark/src/packet-libvirt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/wire
d-off-by: Michal Privoznik
---
tools/wireshark/src/packet-libvirt.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/tools/wireshark/src/packet-libvirt.c
b/tools/wireshark/src/packet-libvirt.c
index ac120b5..aa1c323 100644
--- a/tools/wireshark/src/packet-libvirt.c
+++ b/tools/wireshar
In wireshak commit 22149c55 (v.1.11.3) the API was renamed.
Follow the change in our code too. Since the wireshark change was
made in the very same version that we require at least we are
good to go.
Signed-off-by: Michal Privoznik
---
tools/wireshark/src/packet-libvirt.c | 4 ++--
1 file
On 31.12.2015 07:04, Michael Chapman wrote:
> Valgrind reported a couple of memory leaks and jumps conditional on
> uninitialized values.
>
> Happy New Year!
To you too!
>
> Michael Chapman (3):
> qemu: do not copy out non-existent block job info
> qemu: do not leak NBD disk data in migrati
On 24.12.2015 13:34, Wido den Hollander wrote:
> This used to return 'unkown' and that was not correct.
>
> A vol-dumpxml now returns:
>
>
> image3
> libvirt/image3
>
>
> 10737418240
> 10737418240
>
> libvirt/image3
>
>
>
>
> The RBD driver will now error out if a
On 04.01.2016 15:20, Andrea Bolognani wrote:
> Commit 1b43885 modified one of the callers of this function to take
> into account the possible return value of 0 when the block job can't be
> found.
>
> This commit finishes the job by updating the remaining caller.
> ---
> src/qemu/qemu_driver.c |
hich means success. Since the
scenario can be hardly considered successful, we should return a
value meaning error.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 304165c..1161aa0 10
On 04.01.2016 16:28, Peter Krempa wrote:
> On Tue, Dec 22, 2015 at 15:41:16 +0100, Michal Privoznik wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1293351
>>
>> I've came across a bit of a silly scenario, but long story short:
>> after domain was resumed, the
=6879==by 0x54FA680: virLogMessage (virlog.c:531)
==6879==by 0x54FBBF4: virLogParseOutputs (virlog.c:1130)
==6879==by 0x11CB4F: daemonSetupLogging (libvirtd.c:685)
==6879==by 0x11E137: main (libvirtd.c:1297)
Signed-off-by: Michal Privoznik
---
src/util/virlog.c | 1 +
1 file chang
I've found them by pure chance and they were easy to fix.
Michal Privoznik (2):
virLogHostnameString: Don't leak hostname
virLogVMessage: Don't leak rawinitmsg
src/util/virlog.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
--
2.4.10
--
libvir-li
(virlog.c:645)
==6879==by 0x54FA680: virLogMessage (virlog.c:531)
==6879==by 0x54FBBF4: virLogParseOutputs (virlog.c:1130)
==6879==by 0x11CB4F: daemonSetupLogging (libvirtd.c:685)
==6879==by 0x11E137: main (libvirtd.c:1297)
Signed-off-by: Michal Privoznik
---
src/util/virlog.c | 14
https://bugzilla.redhat.com/show_bug.cgi?id=1266088
We are missing this value for cdrom-image device. Honestly, I
have no idea whether it can happen for other disk devices too.
Signed-off-by: Michal Privoznik
---
src/vmx/vmx.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src
This function may be called with @dconnuri == NULL, e.g. from
virDomainMigrateToURI3() if the flags are missing
VIR_MIGRATE_PEER2PEER flag. Moreover, all later functions called
from here do wrap it into NULLSTR() so why not do the same here?
Signed-off-by: Michal Privoznik
---
src/libvirt
On 29.12.2015 02:09, Jim Fehlig wrote:
> Both xm and xl config have long supported specifying vif rate
> limiting, e.g.
>
> vif = [ 'mac=00:16:3E:74:3d:76,bridge=br0,rate=10MB/s' ]
>
> Add support for mapping rate to and from in the xenconfig
> parser and formatter. rate is mapped to the require
On 08.01.2016 06:11, Jim Fehlig wrote:
> On 01/07/2016 07:48 AM, Michal Privoznik wrote:
>> On 29.12.2015 02:09, Jim Fehlig wrote:
>>> The libxl_device_nic structure supports specifying an outgoing rate
>>> limit based on a time interval and bytes allowed per interv
On 05.01.2016 02:08, Jim Fehlig wrote:
> Happy New Year!
>
> This small series adds support for specifying vif outgoing rate limits
> in Xen. The first patch adds support for converting rate limits between
> sexpr config and domXML. The second patch does the same for xl/xm config.
> The third patc
On 30.12.2015 11:30, Yaniv Kaul wrote:
> Hi,
>
Hey,
sorry for getting to you so late.
> I'm trying to debug this issue, which may be affecting my inability to
> perform live snapshot.
> 1. I'm not sure what 'Waking up a tragedian" in the debug log means - what
> exactly is a tragedian?
It's t
On 08.01.2016 14:26, Martin Kletzander wrote:
> The commit was clearing the socket path even when parsing status XML.
> This series should fix that.
>
>
> Martin Kletzander (2):
> Provide parse flags to PostParse functions
> Don't clear libvirt-internal paths when parsing status XML
>
> src
diff to v2:
- completely reworked, new approach
Michal Privoznik (5):
qemu: Set virtio channel state sooner
qemu: Rename qemuProcessReconnectRefreshChannelVirtioState
qemu: change qemuFindAgentConfig return type
qemu: Introduce QEMU_CAPS_VSERPORT_CHANGE
qemu: Connect to guest agent iff
. Pass const pointer
instead.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_agent.c | 2 +-
src/qemu/qemu_agent.h | 2 +-
src/qemu/qemu_domain.c | 11 ---
src/qemu/qemu_domain.h | 2 +-
src/qemu/qemu_process.c | 4 ++--
5 files changed, 9 insertions(+), 12 deletions(-)
diff
state in
internal structure. Due to a bug in our code it may happen that
we got the event but failed to set it in internal structure
representing the channel.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_driver.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a
This capability tells if qemu is capable of vserport_change
events.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_capabilities.c | 3 +++
src/qemu/qemu_capabilities.h | 3 +++
tests/qemucapabilitiesdata/caps_2.1.1-1.caps | 1 +
tests/qemucapabilitiesdata
This function is going to called from other areas not just
reconnect. New name is qemuProcessRefreshChannelState. At the
same time expose the function as it's going to be needed very
soon.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_process.c | 8
src/qemu/qemu_process.
fore we resume vCPUs, ask qemu
whether somebody is listening on the socket and if so, connect
to it.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_driver.c| 21 -
src/qemu/qemu_migration.c | 20
src/qemu/qemu_process.c | 9 +
3 files ch
This API does not change domain state. It's merely like
virDomainGetXMLDesc() - and we don't reject RO connections there.
There's no reason to reject them here.
Signed-off-by: Michal Privoznik
---
src/libvirt-domain.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/libvirt
On 11.01.2016 13:11, Daniel P. Berrange wrote:
> On Mon, Jan 11, 2016 at 12:52:36PM +0100, Michal Privoznik wrote:
>> This API does not change domain state. It's merely like
>> virDomainGetXMLDesc() - and we don't reject RO connections there.
>> There's no reaso
We have a policy that if API may end up talking to a guest agent
it should require RW connection. We don't obey the rule in
virDomainGetTime().
Signed-off-by: Michal Privoznik
---
src/libvirt-domain.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/libvirt-domain.c b/src/li
diff to v1:
- After some discussion with Daniel, allow virDomainInterfaceAddresses on RO
only if it does not end up talking to guest agent.
- Also fix virDomainGetTime
Michal Privoznik (2):
virDomainInterfaceAddresses: Allow API on RO connection too
virDomainGetTime: Deny on RO connections
This API does not change domain state. However, we have a policy
that an API talking to a guest agent requires RW access. But that
happens only if source == VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_AGENT.
Signed-off-by: Michal Privoznik
---
src/libvirt-domain.c | 3 ++-
1 file changed, 2 insertions
On 11.01.2016 13:26, Daniel P. Berrange wrote:
> On Mon, Jan 11, 2016 at 01:20:38PM +0100, Michal Privoznik wrote:
>> On 11.01.2016 13:11, Daniel P. Berrange wrote:
>>> On Mon, Jan 11, 2016 at 12:52:36PM +0100, Michal Privoznik wrote:
>>>> This API does not change
On 11.01.2016 13:31, Vasiliy Tolstov wrote:
> libvirt_domain_create_xml miss ability to pass flags when create domain,
> fixing it.
>
> Signed-off-by: Vasiliy Tolstov
> ---
> src/libvirt-php.c | 13 +++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/src/libvirt-ph
d-off-by: Michal Privoznik
---
docs/Makefile.am | 2 +-
examples/Makefile.am | 6 +++---
include/Makefile.am | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/docs/Makefile.am b/docs/Makefile.am
index 5f531ea..fb53a45 100644
--- a/docs/Makefile.am
+++ b/docs/Makefi
On 11.01.2016 00:06, Cole Robinson wrote:
> Just handle it all in tools/Makefile.am. I verified the generated output
> looks similar to the pre patch output, but I didn't test it.
> ---
> Makefile.am | 2 +-
> configure.ac| 4 +---
> tools/Makefile.am
On 12.01.2016 17:34, Cole Robinson wrote:
> On 01/12/2016 10:31 AM, Michal Privoznik wrote:
>> So after da176bf6b756 and friend we have switched to $(wildcard
>> some/path/*.xml) instead of enumerating the files explicitly.
>> This is nice, however it makes distcheck build fr
Like everything we install, it should be prefixed with DESTDIR.
Signed-off-by: Michal Privoznik
---
m4/virt-wireshark.m4 | 8
tools/Makefile.am| 1 +
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/m4/virt-wireshark.m4 b/m4/virt-wireshark.m4
index 199317e..ac2e44c
On 12.01.2016 17:42, Alexander Burluka wrote:
> We decide to make a global per domain bandwidth setting
> as were discussed in mailing list earlier.
> This patchset implements hierarchy top level cpu.cfs_period_us
> and cpu.cfs_quota_us control knob. I've named this parameters
> as global_period an
Like everything we install, it should be prefixed with DESTDIR.
Signed-off-by: Michal Privoznik
---
m4/virt-wireshark.m4 | 8
tools/Makefile.am| 1 +
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/m4/virt-wireshark.m4 b/m4/virt-wireshark.m4
index 199317e..ac2e44c
0x568BF41: virNetServerProgramDispatchCall
(virnetserverprogram.c:437)
==8085== Address 0x0 is not stack'd, malloc'd or (recently) free'd
==8085==
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_process.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -
701 - 800 of 15145 matches
Mail list logo
