Since we already make sure before that the domain configuration is
valid we may execute it always at the cost of doing 0 iterations of the
for loop.
This patch will simplify later refactor as it will avoid whitespace
changes.
---
src/qemu/qemu_command.c | 47 +++---
Peter Krempa (10):
conf: Make @def const in virDomainDefGetMemoryInitial
conf: Turn targetNode in struct virDomainMemoryDef to signed
qemu: command: Make qemuBuildMemoryBackendStr usable without NUMA
qemu: command: Always execute memory device formatter
qemu: domain: Add common function
Prepare the command line generator for the possibility that in some
configurations the target NUMA node info will be missing.
---
src/qemu/qemu_command.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 5e7b052..98
We check that is present when we have memory devices at the
time we start the VM or add the device, so we can remove it from the
post parse callback to be more tolerant to users.
---
src/qemu/qemu_domain.c | 8
1 file changed, 8 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qem
ppc64 guests don't require adding a NUMA node for hotplug memory to
work. Lift the requirement and add test cases.
---
src/qemu/qemu_domain.c | 32 ++
.../qemuxml2argv-memory-hotplug-ppc64-nonuma.args | 19 +++
.../qemuxml2argv-memory-hotplug-pp
Later on, we will need to know whether the user specified the target
node or not. Turn the variable into a signed value. We already treat it
as signed in various parts of the qemu driver.
---
src/conf/domain_conf.c | 10 ++
src/conf/domain_conf.h | 2 +-
2 files changed, 7 insertions(+),
Aggregate the checks of the dimm device into the verification function
rather than having them in the formatter.
---
src/qemu/qemu_command.c | 65 ++
src/qemu/qemu_command.h | 4 +--
src/qemu/qemu_domain.c | 83 -
On Tue, Oct 20, 2015 at 09:36:29 -0400, John Ferlan wrote:
>
>
> On 10/16/2015 08:11 AM, Peter Krempa wrote:
> > Later on, we will need to know whether the user specified the target
> > node or not. Turn the variable into a signed value. We already treat it
> > as sig
On Wed, Oct 21, 2015 at 10:48:13 +0200, Michal Privoznik wrote:
> So, consider following scenario:
>
> virsh # migrate --help
>
> In this case migrate help is printed out. So far so good.
> However, you start writing this long migrate command (I bet you
> know the arguments there can get quite
On Thu, Oct 22, 2015 at 11:24:02 -0400, Laine Stump wrote:
> On 10/21/2015 08:22 AM, Pavel Hrdina wrote:
> > While parsing device addresses we should use correct base and don't
> > count on auto-detect. For example, PCI address uses hex numbers, but
> > each number starting with 0 will be auto-det
On Fri, Oct 23, 2015 at 15:38:25 +0530, Prerna wrote:
> When libvirt is compiled without yajl-devel, virnetdaemontest fails.
> This causes 'make check' to fail with nondescript errors, such as following:
> [snip]...
> PASS: read-bufsiz
> PASS: read-non-seekable
> PASS: s
On Mon, Oct 26, 2015 at 11:06:21 -0400, John Ferlan wrote:
> If we have a shutdown of a VM by a qemu agent while an agent EOF occurs
> at relatively the same time, it's possible that a deadlock occurs depending
> on what happens first.
>
> Assume qemuProcessHandleAgentEOF runs first, with the vm->
On Mon, Oct 26, 2015 at 17:28:57 -0400, John Ferlan wrote:
>
>
> On 10/26/2015 11:37 AM, Peter Krempa wrote:
> > On Mon, Oct 26, 2015 at 11:06:21 -0400, John Ferlan wrote:
> >> If we have a shutdown of a VM by a qemu agent while an agent EOF occurs
> >> at relati
On Fri, Oct 23, 2015 at 23:14:55 +0530, Shivaprasad bhat wrote:
> Hi Peter,
>
> Went through the series and gave a try. The series looks good.
>
> One thing I wonder, should we allow the dimms without targetNode info
> in the xml be hotplugged when
> the guest is actually configured with NUMA nod
On Tue, Oct 27, 2015 at 10:37:27 +0100, Pavel Hrdina wrote:
> new in v2:
> - used git format-patch -b
I think Jan meant that it was hard to review with that option due to the
fact that it contains both whitespace and functional changes, not that
you should actually use it to send patches. They ca
On Thu, Oct 29, 2015 at 14:02:28 +0800, Qiaowei Ren wrote:
> Some Intel processor families (e.g. the Intel Xeon processor E5 v3
> family) introduced CMT (Cache Monitoring Technology) to measure the
> usage of cache by applications running on the platform. This patch
> add it into x86 part of cpu_ma
On Thu, Oct 29, 2015 at 14:43:08 +0100, Matthias Gatto wrote:
> Create virStorageSourceGetBackingStore function in
> preparation for quorum:
> Actually, if we want to get a backing store inside a virStorageSource
> we have to do it manually(src->backingStore = backingStore).
> The problem is that w
On Thu, Oct 29, 2015 at 14:43:10 +0100, Matthias Gatto wrote:
> As explained for virStorageSourceGetBackingStore, quorum allows
> multiple backing store, this make the operation to set bs complex
> because we have to check if the backingStore is used as an array
> or a pointer, and set it different
On Thu, Oct 29, 2015 at 14:43:09 +0100, Matthias Gatto wrote:
> Uniformize backing store usage by calling virStorageSourceGetBackingStore
> instead of setting backing store manually.
>
> Signed-off-by: Matthias Gatto
> Signed-off-by: John Ferlan
> ---
> src/conf/domain_conf.c|
On Thu, Oct 29, 2015 at 14:43:19 +0100, Matthias Gatto wrote:
> For now we block all snapshot operations with quorum, because it would require
> a lot more code, espacially because Qemu doesn't really suport it.
Snapshots aren't the only thing that will not work. Basically every
other block operat
On Thu, Oct 29, 2015 at 14:43:12 +0100, Matthias Gatto wrote:
> The backingStore field was a virStorageSourcePtr.
> Because a quorum can contain more that one backingStore at the same level,
> it's now an array of 'virStorageSourcePtr'.
>
> This patch rename src->backingStore to src->backingStore
On Mon, Nov 02, 2015 at 03:18:20 +0530, Shivaprasad G Bhat wrote:
> The checks to known stubs can be easily done having this
> implementation and easy to reuse.
>
> Signed-off-by: Shivaprasad G Bhat
> ---
> src/util/virpci.c | 28 ++--
> 1 file changed, 18 insertions(+)
On Mon, Nov 02, 2015 at 03:19:13 +0530, Shivaprasad G Bhat wrote:
> The stubDriver name can be used to make useful decisions if readily available.
> Set it if bound to a valid one during initialisation.
>
> Signed-off-by: Shivaprasad G Bhat
> ---
> src/util/virpci.c |9 +
> 1 file ch
On Mon, Nov 02, 2015 at 03:21:13 +0530, Shivaprasad G Bhat wrote:
> The iommu group number need not be fetched from the sysfs
> everytime as it remains constant. Fetch it once during
> allocation. Add a helper to set the value to set it from tests.
>
> Signed-off-by: Shivaprasad G Bhat
> ---
> s
On Mon, Nov 02, 2015 at 03:23:26 +0530, Shivaprasad G Bhat wrote:
> The reprobe needs to be called multiple times for vfio devices for each
> device in the iommu group in future patch. So split the reprobe into a
> new function. No functional change.
>
> Signed-off-by: Shivaprasad G Bhat
> ---
>
On Mon, Nov 02, 2015 at 03:28:00 +0530, Shivaprasad G Bhat wrote:
> There could be a delay of 1 or 2 seconds before the vfio-pci driver
> is unbound and the device file /dev/vfio/ is actually
> removed. If the file exists, the host driver probing the device
> can lead to crash. So, wait and avoid t
On Mon, Nov 02, 2015 at 10:34:35 +0100, Andrea Bolognani wrote:
> This guards against code such as
>
> cleanup :
>
> which is happily accepted by the compiler but does not conform
> to our style guidelines.
> ---
> cfg.mk | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/cfg.mk b/
On Thu, Oct 29, 2015 at 14:43:15 +0100, Matthias Gatto wrote:
> Add the capabiltty to libvirt to parse and format the quorum syntax
> as described here:
> http://www.redhat.com/archives/libvir-list/2014-May/msg00533.html
>
> As explain Peter Krempa in the V5, we need a different
On Thu, Oct 29, 2015 at 14:43:16 +0100, Matthias Gatto wrote:
> Allow libvirt to build the quorum string used by quemu.
>
> Add 2 static functions: qemuBuildRAIDStr and
> qemuBuildRAIDFileSourceStr.
> qemuBuildRAIDStr is made because a quorum can have another quorum
> as a child, so we may need to
On Mon, Nov 02, 2015 at 14:34:44 +0300, rodinasop...@gmail.com wrote:
> From: sonya
>
> ---
> tools/virsh-edit.h | 44
> 1 file changed, 44 insertions(+)
> create mode 100644 tools/virsh-edit.h
>
> diff --git a/tools/virsh-edit.h b/tools/virsh-edit.
On Mon, Nov 02, 2015 at 14:34:43 +0300, rodinasop...@gmail.com wrote:
> From: sonya
The commit message is used to explain the changes.
>
> ---
> tools/Makefile.am | 1 +
> tools/virsh-domain.c| 195
>
> tools/virsh-edit.c | 97
On Tue, Nov 03, 2015 at 09:08:04 +0100, Michal Privoznik wrote:
> Funny things happen when you try to do a VPATH build and pass
> --disable-dependency-tracking argument to the configure script.
> Not only the directory structure is not created at the end of
> configure phase, but also contradictory
On Tue, Nov 03, 2015 at 10:40:50 +0100, Peter Krempa wrote:
> On Tue, Nov 03, 2015 at 09:08:04 +0100, Michal Privoznik wrote:
> > Funny things happen when you try to do a VPATH build and pass
> > --disable-dependency-tracking argument to the configure script.
> > Not only th
On Tue, Nov 03, 2015 at 10:55:31 +0100, Peter Krempa wrote:
> On Tue, Nov 03, 2015 at 10:40:50 +0100, Peter Krempa wrote:
> > On Tue, Nov 03, 2015 at 09:08:04 +0100, Michal Privoznik wrote:
> > > Funny things happen when you try to do a VPATH build and pass
> > > --
On Tue, Nov 03, 2015 at 16:04:20 +, Daniel Berrange wrote:
> Add a virRotatingFile object which allows writing to a file
> with automation rotation to N backup files when a size limit
> is reached. This is useful for guest logging when a guaranteed
> finite size limit is required. Use of extern
On Tue, Nov 03, 2015 at 16:04:24 +, Daniel Berrange wrote:
> Currently the QEMU stdout/stderr streams are written directly to
> a regular file (eg /var/log/libvirt/qemu/$GUEST.log). While those
> can be rotated by logrotate (using copytruncate option) this is
> not very efficient. It also leave
For VFIO passthrough the guest memory including the device memory to be
resident in memory. Previously we used a magic constant of 1GiB that we
added to the current memory size of the VM to accomodate all this. It is
possible though that the device that is passed through exposes more than
that. To
On Wed, Nov 04, 2015 at 08:43:34 -0700, Alex Williamson wrote:
> On Wed, 2015-11-04 at 16:14 +0100, Peter Krempa wrote:
> > For VFIO passthrough the guest memory including the device memory to be
> > resident in memory. Previously we used a magic constant of 1GiB that we
> >
The code reported that a migration flag is unsupported but didn't jump
to the error label. Probably an oversight in commit f88af9dc that
introduced the flag checking.
---
src/qemu/qemu_migration.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migrati
Since the flag was not enabled when 'eating' the migration cookie,
libvirt reported a bogus error when memory hotplug was enabled:
unsupported migration cookie feature memory-hotplug
The error was ignored though due to a bug in the code so it slipped
through testing.
Resolves: https://bugzilla.
Peter Krempa (2):
qemu: migration: Properly parse memory hotplug migration flag
qemu: migration: Actually error out on unsupported migration flag
src/qemu/qemu_migration.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--
2.6.2
--
libvir-list mailing list
libvir-list@redhat.com
On Wed, Nov 04, 2015 at 17:16:53 -0700, Alex Williamson wrote:
> On Wed, 2015-11-04 at 16:54 +0100, Peter Krempa wrote:
> > On Wed, Nov 04, 2015 at 08:43:34 -0700, Alex Williamson wrote:
> > > On Wed, 2015-11-04 at 16:14 +0100, Peter Krempa wrote:
[...]
> > Additionally i
On Thu, Nov 05, 2015 at 17:33:52 +, Daniel Berrange wrote:
> The patches for introducing virtlogd will be significantly
> simplified if we don't need to worry about parsing stderr
> during startup. This is required prior to QEMU 0.11 so
> that we can get the dyanamically allocated /dev/pty/NNN
On Thu, Nov 05, 2015 at 08:41:46 -0700, Alex Williamson wrote:
> On Thu, 2015-11-05 at 16:27 +0100, Peter Krempa wrote:
> > On Wed, Nov 04, 2015 at 17:16:53 -0700, Alex Williamson wrote:
[...]
> The power devs will need to speak to what their locked memory
> requirements are a
On Thu, Nov 05, 2015 at 20:37:09 +0100, Jiri Denemark wrote:
> On Thu, Nov 05, 2015 at 15:38:41 +0100, Peter Krempa wrote:
> > Peter Krempa (2):
> > qemu: migration: Properly parse memory hotplug migration flag
> > qemu: migration: Actually error out on unsupported migrati
This is necessary so that VFIO doesn't break killing the guests.
Peter Krempa (2):
qemu: Extract logic to determine the mlock limit size for VFIO
qemu: hotplug: Fix mlock limit handling on memory hotplug
src/qemu/qemu_command.c | 18 ++
src/qemu/qemu_domain.c
New function qemuDomainGetMlockLimitBytes will now handle the
calculation so that it unifies the logic to one place and allows later
reuse.
---
src/qemu/qemu_command.c | 18 ++
src/qemu/qemu_domain.c | 17 +
src/qemu/qemu_domain.h | 2 ++
src/qemu/qemu_hotplug.c
If mlock is required either due to use of VFIO hostdevs or due to the
fact that it's enabled it needs to be tweaked prior to adding new memory
or after removing a module. Add a helper to determine when it's
necessary and reuse it both on hotplug and hotunplug.
Resolves: https://bugzilla.redhat.com
On Fri, Nov 06, 2015 at 13:39:06 -0500, John Ferlan wrote:
> On 11/06/2015 10:47 AM, Peter Krempa wrote:
> > If mlock is required either due to use of VFIO hostdevs or due to the
> > fact that it's enabled it needs to be tweaked prior to adding new memory
> > or afte
Peter Krempa (3):
qemu: Extract logic to determine the mlock limit size for VFIO
qemu: hotplug: Fix mlock limit handling on memory hotplug
qemu: hotplug: Reject VFIO hotplug if setting RLIMIT_MEMLOCK fails
src/qemu/qemu_command.c | 18 ++---
src/qemu/qemu_domain.c | 54
New function qemuDomainGetMlockLimitBytes will now handle the
calculation so that it unifies the logic to one place and allows later
reuse.
---
src/qemu/qemu_command.c | 18 ++
src/qemu/qemu_domain.c | 27 +++
src/qemu/qemu_domain.h | 2 ++
src/qemu/qemu_
If mlock is required either due to use of VFIO hostdevs or due to the
fact that it's enabled it needs to be tweaked prior to adding new memory
or after removing a module. Add a helper to determine when it's
necessary and reuse it both on hotplug and hotunplug.
Resolves: https://bugzilla.redhat.com
Check the return value of virCommandSetMaxMemLock when hotplugging VFIO
PCI hostdevs and reject the hotplug if the memory limit can't be set.
---
src/qemu/qemu_hotplug.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index
On Mon, Nov 09, 2015 at 13:09:59 -0500, John Ferlan wrote:
> On 11/09/2015 07:50 AM, Peter Krempa wrote:
> > New function qemuDomainGetMlockLimitBytes will now handle the
> > calculation so that it unifies the logic to one place and allows
On Mon, Nov 09, 2015 at 13:11:16 -0500, John Ferlan wrote:
> On 11/09/2015 07:50 AM, Peter Krempa wrote:
> > If mlock is required either due to use of VFIO hostdevs or due to the
> > fact that it's enabled it needs to be tweaked prior to adding new memory
> > or afte
On Tue, Oct 20, 2015 at 09:34:05 -0400, John Ferlan wrote:
>
>
> On 10/16/2015 08:11 AM, Peter Krempa wrote:
> > Keep const correctness and allow to use this function in cases where
> > @def is const in the caller.
> > ---
> > src/conf/domain_conf.c | 2 +
On Mon, Nov 09, 2015 at 13:50:14 +0100, Peter Krempa wrote:
> Peter Krempa (3):
> qemu: Extract logic to determine the mlock limit size for VFIO
> qemu: hotplug: Fix mlock limit handling on memory hotplug
> qemu: hotplug: Reject VFIO hotplug if setting RLIMIT_MEMLOCK fails
&g
On Tue, Oct 20, 2015 at 09:57:49 -0400, John Ferlan wrote:
> On 10/16/2015 08:11 AM, Peter Krempa wrote:
> > Since we already make sure before that the domain configuration is
> > valid we may execute it always at the cost of doing 0 iterations of the
> > for loop.
>
On Tue, Oct 20, 2015 at 17:31:57 -0400, John Ferlan wrote:
>
>
> On 10/16/2015 08:11 AM, Peter Krempa wrote:
> > Adjust the config code so that it does not enforce that target memory
> > node is specified. To avoid breakage, adjust the qemu memory hotplug
> > conf
This fixes most of the stuff pointed out in the review.
Peter Krempa (7):
qemu: command: Make qemuBuildMemoryBackendStr usable without NUMA
qemu: command: Always execute memory device formatter
qemu: domain: Add common function to perform memory hotplug checks
qemu: command: Move dimm
ppc64 guests don't require adding a NUMA node for hotplug memory to
work. Lift the requirement and add test cases.
---
src/qemu/qemu_domain.c | 32 ++
.../qemuxml2argv-memory-hotplug-ppc64-nonuma.args | 28
.../qemuxml2argv-memory-hotpl
Make the function usable so that -1 can be passed to it as cell ID so
that we can later enable memory hotplug on non-NUMA guests for certain
architectures.
---
src/qemu/qemu_command.c | 32
1 file changed, 20 insertions(+), 12 deletions(-)
diff --git a/src/qemu/qe
Since we already make sure before that the domain configuration is
valid we may execute it always at the cost of doing 0 iterations of the
for loop.
This patch will simplify later refactor as it will avoid whitespace
changes.
---
src/qemu/qemu_command.c | 47 +++---
Adjust the config code so that it does not enforce that target memory
node is specified. To avoid breakage, adjust the qemu memory hotplug
config checker to disallow such config for now.
---
docs/formatdomain.html.in | 5 +++--
docs/schemas/domaincommon.rng | 8 +---
src/conf/domain_conf
Add a function that will aggregate various checks related to memory
hotplug so that they aren't scattered accross various parts of the
code.
---
src/qemu/qemu_command.c | 26 ++---
src/qemu/qemu_domain.c | 78 +
src/qemu/qemu_domain.h |
Prepare the command line generator for the possibility that in some
configurations the target NUMA node info will be missing.
---
src/qemu/qemu_command.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index e6c240c..8f
Aggregate the checks of the dimm device into the verification function
rather than having them in the formatter.
---
src/qemu/qemu_command.c | 65 ++
src/qemu/qemu_command.h | 4 +--
src/qemu/qemu_domain.c | 92 -
sr
On Tue, Nov 10, 2015 at 13:17:41 +0100, Christian Loehle wrote:
> >From README:
> The jailhouse hypervisor driver for the libvirt project aims to provide
> rudimentary support for managing jailhouse with the libvirt library. The
> main advantage of this is the possibility to use virt-manager as a G
Break early when hard limit is set so that it's not intermixed by other
logic for determining the limit.
---
src/qemu/qemu_domain.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 416ab5b..12517a5 100644
--- a/s
---
src/qemu/qemu_domain.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 11cd39e..7f2783b 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -3673,6 +3673,11 @@ qemuDomainRequiresMlock(virDomainDefPtr def)
{
si
Peter Krempa (3):
qemu: domain: Restructurate control flow in
qemuDomainGetMlockLimitBytes
qemu: Explain mlock limit size more in detail
qemu: Explain why mlock size is modified when def->mem.locked is
enabled
src/qemu/qemu_domain.c | 34 --
1 f
Based on Alex's explanation [1] in the recent discussion let's update
the comment explaining the memory lock limit calculation.
[1]
http://www.redhat.com/archives/libvir-list/2015-November/msg00329.html
---
src/qemu/qemu_domain.c | 19 ---
1 file changed, 16 insertions(+), 3 delet
On Tue, Nov 10, 2015 at 09:40:34 -0700, Alex Williamson wrote:
> On Fri, 2015-11-06 at 08:30 +0100, Peter Krempa wrote:
[...]
> Now the next question is whether this peer-to-peer DMA is useful, or
> even used. I have heard of users assigning multiple AMD cards to a
> system and m
On Thu, Nov 05, 2015 at 16:54:02 +0300, Dmitry Andreev wrote:
>
>
> On 05.11.2015 14:06, Jiri Denemark wrote:
> > On Mon, Oct 26, 2015 at 13:23:32 +0300, Dmitry Andreev wrote:
> >> Add crash CPU feature for Hyper-V. Hyper-V crash MSR's can be used
> >> by Hyper-V based guests to notify about occu
On Wed, Nov 11, 2015 at 15:15:56 +0100, Jiri Denemark wrote:
> Logging current async job while in BeginJob is useful, but the async job
> we want to start is even more interesting.
A little confusing on the first read.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_domain.c | 16 ++
On Wed, Nov 11, 2015 at 15:30:10 +0100, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_process.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
ACK
signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https:/
On Wed, Nov 11, 2015 at 15:26:58 +0100, Jiri Denemark wrote:
> Fixes several style issues and removes "DEF" (what is it supposed to
> mean anyway?) from debug messages.
>
> Signed-off-by: Jiri Denemark
> ---
> src/security/security_dac.c | 22 ++
> 1 file changed, 10 insertio
On Wed, Nov 11, 2015 at 15:23:55 +0100, Andrea Bolognani wrote:
> On Wed, 2015-11-11 at 06:57 +0100, Peter Krempa wrote:
> > Based on Alex's explanation [1] in the recent discussion let's update
> > the comment explaining the memory lock limit calculation.
> >
&g
On Thu, Nov 12, 2015 at 19:37:03 +0100, Jiri Denemark wrote:
> Move the code from qemuMigrationFinish into a dedicated function.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_migration.c | 45 +
> 1 file changed, 29 insertions(+), 16 deletions
On Thu, Nov 12, 2015 at 19:37:04 +0100, Jiri Denemark wrote:
> Move the code from qemuBuildCommandLine into dedicated functions.
>
> Signed-off-by: Jiri Denemark
> ---
>
> Notes:
> Both functions will later be moved to qemu_migration.c
>
> src/qemu/qemu_command.c | 75
> ++
On Fri, Nov 13, 2015 at 10:28:08 +0100, Jiri Denemark wrote:
> On Fri, Nov 13, 2015 at 10:06:08 +0100, Peter Krempa wrote:
> > On Thu, Nov 12, 2015 at 19:37:04 +0100, Jiri Denemark wrote:
> > > Move the code from qemuBuildCommandLine into dedicated functions.
> > >
On Thu, Nov 12, 2015 at 19:37:05 +0100, Jiri Denemark wrote:
> Make callers of qemuBuildCommandLine responsible for providing the URI
> which should be passed as a parameter for -incoming.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_command.c | 32
>
On Thu, Nov 12, 2015 at 19:37:06 +0100, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_command.c | 39 ---
> src/qemu/qemu_command.h | 5 -
> src/qemu/qemu_migration.c | 40
> src/qemu
On Thu, Nov 12, 2015 at 19:37:07 +0100, Jiri Denemark wrote:
> Incoming migration may require quite a few parameters (URI, fd, path) to
> be considered while starting QEMU and we will soon add another one.
> Let's group all of them in a single struct.
>
> Signed-off-by: Jiri Denemark
> ---
> src
On Thu, Nov 12, 2015 at 19:37:08 +0100, Jiri Denemark wrote:
> We only started an async job for incoming migration from another host.
> When we were starting a domain from scratch or restoring from a saved
> state (migration from file) we didn't set any async job. Let's introduce
> a new QEMU_ASYNC
On Thu, Nov 12, 2015 at 19:37:09 +0100, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_monitor.c | 12
> src/qemu/qemu_monitor.h | 3 +++
> src/qemu/qemu_monitor_json.c | 25 +
> src/qemu/qemu_monitor_json.h | 5 +
>
On Thu, Nov 12, 2015 at 19:37:10 +0100, Jiri Denemark wrote:
> Traditionally, we pass incoming migration URI on QEMU command line,
> which has some drawbacks. Depending on the URI QEMU may initialize its
> migration state immediately without giving us a chance to set any
> additional migration para
On Thu, Nov 12, 2015 at 19:37:11 +0100, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_process.c | 22 +++---
> 1 file changed, 11 insertions(+), 11 deletions(-)
ACK
signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@
On Thu, Nov 12, 2015 at 19:37:12 +0100, Jiri Denemark wrote:
> qemuProcessStart is so big that any nontrivial code should be moved to
> dedicated functions to make the code easier to read and maintain.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_process.c | 80
> +
On Thu, Nov 12, 2015 at 19:37:13 +0100, Jiri Denemark wrote:
> qemuProcessStart is so big that any nontrivial code should be moved to
> dedicated functions to make the code easier to read and maintain.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_process.c | 147
>
On Thu, Nov 12, 2015 at 19:37:14 +0100, Jiri Denemark wrote:
> qemuProcessStart is so big that any nontrivial code should be moved to
> dedicated functions to make the code easier to read and maintain.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_process.c | 105
>
On Thu, Nov 12, 2015 at 19:37:15 +0100, Jiri Denemark wrote:
> Move {Enter,Exit}Monitor calls inside qemuProcessSetLinkStates to
> simplify qemuProcessStart.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_process.c | 38 +++---
> 1 file changed, 23 inserti
On Thu, Nov 12, 2015 at 19:37:16 +0100, Jiri Denemark wrote:
> qemuProcessStart is so big that any nontrivial code should be moved to
> dedicated functions to make the code easier to read and maintain.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_process.c | 56
> +
On Thu, Nov 12, 2015 at 19:37:17 +0100, Jiri Denemark wrote:
> qemuProcessMakeDir is used for creating a per-domain directory in a
> given parent directory.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_process.c | 59
> +
> 1 file change
On Thu, Nov 12, 2015 at 19:37:18 +0100, Jiri Denemark wrote:
> Every caller setting migrateFrom already sets
> VIR_QEMU_PROCESS_START_PAUSED flag anyway.
Indeed.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_process.c | 3 ---
> 1 file changed, 3 deletions(-)
ACK
signature.asc
Desc
On Thu, Nov 12, 2015 at 19:37:19 +0100, Jiri Denemark wrote:
> Remembering to call qemuMonitorSetDomainLog in the right paths before
> calling qemuProcessStop is annoying and easy to forget. And I already
> forget to do so in commit v1.2.8-52-g0389060: logfd may be leaked if
forgot
> QEMU process
On Thu, Nov 12, 2015 at 19:37:20 +0100, Jiri Denemark wrote:
> qemuProcessStart is going to be split in three parts: qemuProcessInit,
> qemuProcessLaunch, and qemuProcessFinish so that migration Prepare phase
> can insert additional code in the process. qemuProcessStart will be a
> small wrapper fo
On Thu, Nov 12, 2015 at 19:37:21 +0100, Jiri Denemark wrote:
> Once qemuProcessInit was called, qemuProcessLaunch will launch a new
> QEMU process with stopped virtual CPUs.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_process.c | 162
>
On Thu, Nov 12, 2015 at 19:37:22 +0100, Jiri Denemark wrote:
> Finishes starting a new domain launched by qemuProcessLaunch.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_process.c | 76
> +
> src/qemu/qemu_process.h | 6
> 2 files
On Thu, Nov 12, 2015 at 19:37:23 +0100, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_migration.c | 154
> +-
> 1 file changed, 85 insertions(+), 69 deletions(-)
>
ACK
signature.asc
Description: Digital signature
--
libv
801 - 900 of 19078 matches
Mail list logo
