[libvirt PATCH v2 6/8] cpu: Replace VIR_ALLOC with g_new0

Signed-off-by: Tim Wiederhake --- src/cpu/cpu.c | 4 +--- src/cpu/cpu_ppc64.c | 19 +-- 2 files changed, 6 insertions(+), 17 deletions(-) diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c index 69e4205e4b..c3eef52c79 100644 --- a/src/cpu/cpu.c +++ b/src/cpu/cpu.c @@ -286,9

[libvirt PATCH v2 4/8] cpu_x86: Use g_auto* in virX86CpuIncompatible

Signed-off-by: Tim Wiederhake --- src/cpu/cpu_x86.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index fdb665b01d..db1b2e55a1 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -1797,7 +1797,7 @@ virCPUx86DataParse

[libvirt PATCH v2 5/8] cpu_map: Remove unnecessary variable in loadData

Signed-off-by: Tim Wiederhake --- src/cpu/cpu_map.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/cpu/cpu_map.c b/src/cpu/cpu_map.c index ac98a14e2e..3fa03e707c 100644 --- a/src/cpu/cpu_map.c +++ b/src/cpu/cpu_map.c @@ -43,7 +43,6 @@ loadData(const char *mapfile

[libvirt PATCH v2 8/8] cpu: Replace VIR_FREE with g_free

Note the use of g_clear_pointer(..., g_free) in ppc64DataClear and virCPUx86Baseline. Signed-off-by: Tim Wiederhake --- src/cpu/cpu.c | 2 +- src/cpu/cpu_ppc64.c | 18 +- src/cpu/cpu_x86.c | 8 3 files changed, 14 insertions(+), 14 deletions(-) diff --git

[libvirt PATCH v2 2/8] cpu_map: Use g_auto* in loadData

Signed-off-by: Tim Wiederhake --- src/cpu/cpu_map.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/cpu/cpu_map.c b/src/cpu/cpu_map.c index 65d244e011..53c8cbba6b 100644 --- a/src/cpu/cpu_map.c +++ b/src/cpu/cpu_map.c @@ -55,8 +55,9 @@ loadData(const char *mapfile

[libvirt PATCH v2 3/8] cpu_map: Use g_auto* in loadIncludes

Signed-off-by: Tim Wiederhake --- src/cpu/cpu_map.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/cpu/cpu_map.c b/src/cpu/cpu_map.c index 53c8cbba6b..ac98a14e2e 100644 --- a/src/cpu/cpu_map.c +++ b/src/cpu/cpu_map.c @@ -125,18 +125,16 @@ loadIncludes

[libvirt PATCH v2 0/8] Replace VIR_{ALLOC, ALLOC_N, FREE} in src/cpu/*.

V1: https://www.redhat.com/archives/libvir-list/2020-September/msg00540.html Tim Wiederhake (8): cpu_ppc64: Use g_auto* in ppc64MakeCPUData cpu_map: Use g_auto* in loadData cpu_map: Use g_auto* in loadIncludes cpu_x86: Use g_auto* in virX86CpuIncompatible cpu_map: Remove unnecessary

[libvirt PATCH v2 7/8] cpu: Replace VIR_ALLOC_N with g_new0

Signed-off-by: Tim Wiederhake Reviewed-by: Ján Tomko --- src/cpu/cpu_ppc64.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index ca2cfa0a67..6477b4bce7 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c

[libvirt PATCH v2 1/8] cpu_ppc64: Use g_auto* in ppc64MakeCPUData

Signed-off-by: Tim Wiederhake --- src/cpu/cpu_ppc64.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index 28fbfea9ae..c0d09db696 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@ -399,7 +399,7 @@ static

[libvirt PATCH 01/21] tests: Use glib memory functions in virpcimock.c

Signed-off-by: Tim Wiederhake --- tests/virpcimock.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/tests/virpcimock.c b/tests/virpcimock.c index 92b6f810d8..6b1f2f2a5a 100644 --- a/tests/virpcimock.c +++ b/tests/virpcimock.c @@ -427,9 +427,7

[libvirt PATCH 14/21] qemu: Use glib memory functions in qemuDomainMasterKeyReadFile

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 0ed132a829..6efc6102bd 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -511,7 +511,7

[libvirt PATCH 10/21] tests: Use glib memory function in testConfRoundTrip

This also fixes a (hypothetical) bug where testConfRoundTrip would return 0 if virConfWriteMem() returned 0 and virTestCompareToFile failed. Signed-off-by: Tim Wiederhake --- tests/virconftest.c | 29 ++--- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git

[libvirt PATCH 12/21] util: Use glib memory functions in virJSONValueGetArrayAsBitmap

Signed-off-by: Tim Wiederhake --- src/util/virjson.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virjson.c b/src/util/virjson.c index 6921eccb60..6511b4e641 100644 --- a/src/util/virjson.c +++ b/src/util/virjson.c @@ -1243,8 +1243,8

[libvirt PATCH 03/21] util: Use glib memory functions in virBitmapNewQuiet

Signed-off-by: Tim Wiederhake --- src/util/virbitmap.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/util/virbitmap.c b/src/util/virbitmap.c index 60fd8491dd..639103e518 100644 --- a/src/util/virbitmap.c +++ b/src/util/virbitmap.c @@ -69,14 +69,8

[libvirt PATCH 20/21] util: Use glib memory functions in virFileGetXAttrQuiet

Signed-off-by: Tim Wiederhake --- src/util/virfile.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 90156845df..61d2c16072 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -4327,8 +4327,7

[libvirt PATCH 11/21] util: Use glib memory functions in virDevMapperGetTargetsImpl

Signed-off-by: Tim Wiederhake --- src/util/virdevmapper.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/util/virdevmapper.c b/src/util/virdevmapper.c index 7c89c2a952..4d27c9f104 100644 --- a/src/util/virdevmapper.c +++ b/src/util/virdevmapper.c @@ -260,9 +260,7

[libvirt PATCH 16/21] qemu: Use glib memory functions in qemuProcessReadLog

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index dd60fb0ddf..b1af35b933 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -2082,7 +2082,7

[libvirt PATCH 18/21] tests: Use glib memory functions in pci_driver_new

Signed-off-by: Tim Wiederhake --- tests/virpcimock.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/virpcimock.c b/tests/virpcimock.c index c8aa8f3f01..787172d24c 100644 --- a/tests/virpcimock.c +++ b/tests/virpcimock.c @@ -701,12 +701,12 @@ pci_driver_new

[libvirt PATCH 17/21] tests: Use glib memory functions in add_fd

Signed-off-by: Tim Wiederhake --- tests/virpcimock.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/virpcimock.c b/tests/virpcimock.c index 6b1f2f2a5a..c8aa8f3f01 100644 --- a/tests/virpcimock.c +++ b/tests/virpcimock.c @@ -305,11 +305,7 @@ add_fd(int fd, const

[libvirt PATCH 04/21] util: Use glib memory functions in virErrorCopyNew

Signed-off-by: Tim Wiederhake --- src/util/virerror.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/util/virerror.c b/src/util/virerror.c index 507a29f50f..4ba99defbb 100644 --- a/src/util/virerror.c +++ b/src/util/virerror.c @@ -223,15 +223,14 @@ virCopyError

[libvirt PATCH 07/21] util: Use glib memory functions in virLogFilterNew

Signed-off-by: Tim Wiederhake --- src/util/virlog.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index f6d0c6c050..de36da1a4a 100644 --- a/src/util/virlog.c +++ b/src/util/virlog.c @@ -1308,7 +1308,6

[libvirt PATCH 00/21] Remove VIR_{ALLOC, ALLOC_N, REALLOC_N}_QUIET macros.

See also https://www.redhat.com/archives/libvir-list/2020-September/msg00540.html and https://www.redhat.com/archives/libvir-list/2020-September/msg00610.html Tim Wiederhake (21): tests: Use glib memory functions in virpcimock.c rpc: Use glib memory functions in virNetMessageSaveError

[libvirt PATCH 06/21] util: Use glib memory functions in virSaveLastError

Signed-off-by: Tim Wiederhake --- src/util/virerror.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virerror.c b/src/util/virerror.c index 99a0855b51..df4205043a 100644 --- a/src/util/virerror.c +++ b/src/util/virerror.c @@ -405,8 +405,7 @@ virSaveLastError(void

[libvirt PATCH 15/21] qemu: Use glib memory functions in qemuDomainLogContextRead

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 6efc6102bd..785cee6f18 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -6357,7 +6357,7 @@ ssize_t

[libvirt PATCH 08/21] util: Use glib memory functions in virThreadCreateFull

Signed-off-by: Tim Wiederhake --- src/util/virthread.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/util/virthread.c b/src/util/virthread.c index 7f23399835..814f5313aa 100644 --- a/src/util/virthread.c +++ b/src/util/virthread.c @@ -253,11 +253,8 @@ int

[libvirt PATCH 21/21] util: Remove VIR_REALLOC_N_QUIET

Signed-off-by: Tim Wiederhake --- src/util/viralloc.h | 15 --- 1 file changed, 15 deletions(-) diff --git a/src/util/viralloc.h b/src/util/viralloc.h index c60148724d..a50cd5d632 100644 --- a/src/util/viralloc.h +++ b/src/util/viralloc.h @@ -105,21 +105,6 @@ void virDisposeString

[libvirt PATCH v3 8/8] cpu: Replace VIR_FREE with g_free

Note the use of g_clear_pointer(..., g_free) in ppc64DataClear and virCPUx86Baseline. Signed-off-by: Tim Wiederhake Reviewed-by: Ján Tomko --- src/cpu/cpu.c | 2 +- src/cpu/cpu_ppc64.c | 18 +- src/cpu/cpu_x86.c | 8 3 files changed, 14 insertions(+), 14

[libvirt PATCH v3 3/8] cpu_map: Use g_auto* in loadIncludes

Signed-off-by: Tim Wiederhake --- src/cpu/cpu_map.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/cpu/cpu_map.c b/src/cpu/cpu_map.c index 53c8cbba6b..743547c6d1 100644 --- a/src/cpu/cpu_map.c +++ b/src/cpu/cpu_map.c @@ -125,18 +125,16 @@ loadIncludes

[libvirt PATCH v3 6/8] cpu: Replace VIR_ALLOC with g_new0

Signed-off-by: Tim Wiederhake Reviewed-by: Ján Tomko --- src/cpu/cpu.c | 4 +--- src/cpu/cpu_ppc64.c | 19 +-- 2 files changed, 6 insertions(+), 17 deletions(-) diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c index 69e4205e4b..c3eef52c79 100644 --- a/src/cpu/cpu.c +++ b/src

[libvirt PATCH v3 1/8] cpu_ppc64: Use g_auto* in ppc64MakeCPUData

Signed-off-by: Tim Wiederhake Reviewed-by: Ján Tomko --- src/cpu/cpu_ppc64.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index 28fbfea9ae..c0d09db696 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@ -399,7

[libvirt PATCH v3 2/8] cpu_map: Use g_auto* in loadData

Signed-off-by: Tim Wiederhake Reviewed-by: Ján Tomko --- src/cpu/cpu_map.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/cpu/cpu_map.c b/src/cpu/cpu_map.c index 65d244e011..53c8cbba6b 100644 --- a/src/cpu/cpu_map.c +++ b/src/cpu/cpu_map.c @@ -55,8 +55,9

[libvirt PATCH v3 7/8] cpu: Replace VIR_ALLOC_N with g_new0

Signed-off-by: Tim Wiederhake Reviewed-by: Ján Tomko --- src/cpu/cpu_ppc64.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index ca2cfa0a67..6477b4bce7 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c

[libvirt PATCH v3 0/8] Replace VIR_{ALLOC, ALLOC_N, FREE} in src/cpu/*.

V1: https://www.redhat.com/archives/libvir-list/2020-September/msg00540.html V2: https://www.redhat.com/archives/libvir-list/2020-September/msg00610.html Tim Wiederhake (8): cpu_ppc64: Use g_auto* in ppc64MakeCPUData cpu_map: Use g_auto* in loadData cpu_map: Use g_auto* in loadIncludes

[libvirt PATCH v3 5/8] cpu_map: Remove unnecessary variable in loadData

Signed-off-by: Tim Wiederhake Reviewed-by: Ján Tomko --- src/cpu/cpu_map.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/cpu/cpu_map.c b/src/cpu/cpu_map.c index 743547c6d1..6baaa6 100644 --- a/src/cpu/cpu_map.c +++ b/src/cpu/cpu_map.c @@ -43,7 +43,6 @@ loadData

[libvirt PATCH v3 4/8] cpu_x86: Use g_auto* in virX86CpuIncompatible

Signed-off-by: Tim Wiederhake Reviewed-by: Ján Tomko --- src/cpu/cpu_x86.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index fdb665b01d..db1b2e55a1 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -1797,7 +1797,7

[libvirt PATCH 09/21] util: Remove VIR_ALLOC_QUIET

Signed-off-by: Tim Wiederhake --- src/util/viralloc.h | 14 -- 1 file changed, 14 deletions(-) diff --git a/src/util/viralloc.h b/src/util/viralloc.h index 833f85f62e..ae967f2556 100644 --- a/src/util/viralloc.h +++ b/src/util/viralloc.h @@ -75,20 +75,6 @@ void virDisposeString(char

[libvirt PATCH 05/21] util: Use glib memory functions in virLastErrorObject

Signed-off-by: Tim Wiederhake --- src/util/virerror.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/util/virerror.c b/src/util/virerror.c index 4ba99defbb..99a0855b51 100644 --- a/src/util/virerror.c +++ b/src/util/virerror.c @@ -237,15 +237,17

[libvirt PATCH 13/21] util: Remove VIR_ALLOC_N_QUIET

Signed-off-by: Tim Wiederhake --- src/util/viralloc.h | 15 --- 1 file changed, 15 deletions(-) diff --git a/src/util/viralloc.h b/src/util/viralloc.h index ae967f2556..c60148724d 100644 --- a/src/util/viralloc.h +++ b/src/util/viralloc.h @@ -90,21 +90,6 @@ void virDisposeString

[libvirt PATCH 19/21] tools: Use glib memory functions in vshCompleterFilter

Signed-off-by: Tim Wiederhake --- tools/vsh.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tools/vsh.c b/tools/vsh.c index 0e8edcd78c..e3c2404a74 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -2709,13 +2709,11 @@ vshCompleterFilter(char ***list, return

[libvirt PATCH 02/21] rpc: Use glib memory functions in virNetMessageSaveError

Signed-off-by: Tim Wiederhake --- src/rpc/virnetmessage.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/rpc/virnetmessage.c b/src/rpc/virnetmessage.c index c4ddafc01d..6423ce67a3 100644 --- a/src/rpc/virnetmessage.c +++ b/src/rpc/virnetmessage.c @@ -539,8 +539,8

[libvirt PATCH 3/7] util: alloc: Remove VIR_REALLOC_N_QUIET

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_domain.c | 4 ++-- src/qemu/qemu_process.c | 2 +- src/util/viralloc.h | 15 --- src/util/virfile.c | 2 +- tests/virpcimock.c | 6 +++--- tools/vsh.c | 2 +- 6 files changed, 8 insertions(+), 23

[libvirt PATCH 7/7] cpu: Replace VIR_FREE with g_free

Signed-off-by: Tim Wiederhake --- src/cpu/cpu.c | 2 +- src/cpu/cpu_map.c | 6 +++--- src/cpu/cpu_ppc64.c | 18 +- src/cpu/cpu_x86.c | 10 +- 4 files changed, 18 insertions(+), 18 deletions(-) diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c index c3eef52c79

[libvirt PATCH 2/7] util: alloc: Remove VIR_ALLOC_N_QUIET

Signed-off-by: Tim Wiederhake --- src/util/viralloc.h | 15 --- src/util/virbitmap.c| 2 +- src/util/virdevmapper.c | 2 +- src/util/virjson.c | 2 +- src/util/virlog.c | 2 +- tests/virconftest.c | 2 +- 6 files changed, 5 insertions(+), 20 deletions

[libvirt PATCH 0/7] Replace VIR_ALLOC and VIR_FREE in src/cpu/*.

This series furthers the transition from VIR_ALLOC, VIR_FREE, etc to glib fun= ctions and removes the "_QUIET" variants of VIR_{ALLOC,ALLOC_N,REALLOC_N,APPEND_ELEMENT}= that by now are aliases to their non-quiet counterparts. Tim Wiederhake (7): util: alloc: Remove VIR_ALLOC_QU

[libvirt PATCH 6/7] cpu: Replace VIR_ALLOC_N with g_new0

Signed-off-by: Tim Wiederhake --- src/cpu/cpu_ppc64.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index ca2cfa0a67..6477b4bce7 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@ -134,9 +134,7

[libvirt PATCH 5/7] cpu: Replace VIR_ALLOC with g_new0

Signed-off-by: Tim Wiederhake --- src/cpu/cpu.c | 4 +--- src/cpu/cpu_ppc64.c | 25 - 2 files changed, 9 insertions(+), 20 deletions(-) diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c index 69e4205e4b..c3eef52c79 100644 --- a/src/cpu/cpu.c +++ b/src/cpu/cpu.c @@ -286,9

[libvirt PATCH 1/7] util: alloc: Remove VIR_ALLOC_QUIET

Signed-off-by: Tim Wiederhake --- src/rpc/virnetmessage.c | 2 +- src/util/viralloc.h | 14 -- src/util/virbitmap.c| 2 +- src/util/virerror.c | 6 +++--- src/util/virlog.c | 2 +- src/util/virthread.c| 2 +- tests/virpcimock.c | 6 +++--- 7 files

[libvirt PATCH 4/7] util: alloc: Remove VIR_APPEND_ELEMENT_QUIET

Signed-off-by: Tim Wiederhake --- src/util/viralloc.h| 4 tests/virfilewrapper.c | 4 ++-- tests/virpcimock.c | 7 +++ 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/src/util/viralloc.h b/src/util/viralloc.h index a50cd5d632..a581a2935e 100644 --- a/src/util

Re: [libvirt PATCH 01/15] cpu_map: Use g_auto* in loadData

Hi Ján! Am Montag, den 07.09.2020, 17:10 +0200 schrieb Ján Tomko: > On a Monday in 2020, Tim Wiederhake wrote: > > Signed-off-by: Tim Wiederhake > > --- > > src/cpu/cpu_map.c | 20 > > 1 file changed, 8 insertions(+), 12 deletions(-) > > >

Re: [libvirt PATCH 06/15] cpu_ppc64: Turn structs ppc64_{vendor, model, map} into typedefs

Am Montag, den 07.09.2020, 12:03 -0400 schrieb Laine Stump: > danielhb had sent similar patches for this file last week, which I > had > planned to review, but didn't get around to before the weekend: > > > https://www.redhat.com/archives/libvir-list/2020-September/msg00124.html > Thank you

[libvirt PATCH v2 1/7] tests: Fix false positive in testConfRoundTrip.

testConfRoundTrip would return 0 (success) if virConfWriteMem returned 0 (nothing written) and virTestCompareToFile failed. Signed-off-by: Tim Wiederhake --- tests/virconftest.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/virconftest.c b/tests/virconftest.c

[libvirt PATCH v2 3/7] util: Use glib memory functions in virLastErrorObject

Signed-off-by: Tim Wiederhake --- src/util/virerror.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/util/virerror.c b/src/util/virerror.c index d89948f198..80a7cfe0ed 100644 --- a/src/util/virerror.c +++ b/src/util/virerror.c @@ -235,10 +235,9 @@ virLastErrorObject

[libvirt PATCH v2 2/7] util: Use glib memory functions in virErrorCopyNew

Signed-off-by: Tim Wiederhake --- src/util/virerror.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/util/virerror.c b/src/util/virerror.c index 6b057057a3..d89948f198 100644 --- a/src/util/virerror.c +++ b/src/util/virerror.c @@ -223,14 +223,8 @@ virCopyError

[libvirt PATCH v2 0/7] Remove VIR_{ALLOC, ALLOC_N, REALLOC_N}_QUIET macros.

V1: https://www.redhat.com/archives/libvir-list/2020-September/msg00633.html Tim Wiederhake (7): tests: Fix false positive in testConfRoundTrip. util: Use glib memory functions in virErrorCopyNew util: Use glib memory functions in virLastErrorObject util: Remove VIR_ALLOC_QUIET tests

[libvirt PATCH v2 4/7] util: Remove VIR_ALLOC_QUIET

Signed-off-by: Tim Wiederhake Reviewed-by: Ján Tomko --- src/util/viralloc.h | 14 -- 1 file changed, 14 deletions(-) diff --git a/src/util/viralloc.h b/src/util/viralloc.h index 3e57d8a603..fa2bc8a2bc 100644 --- a/src/util/viralloc.h +++ b/src/util/viralloc.h @@ -75,20 +75,6

[libvirt PATCH v2 7/7] util: Remove VIR_ALLOC_N_QUIET

Signed-off-by: Tim Wiederhake Reviewed-by: Ján Tomko --- src/util/viralloc.h | 15 --- 1 file changed, 15 deletions(-) diff --git a/src/util/viralloc.h b/src/util/viralloc.h index fa2bc8a2bc..a50cd5d632 100644 --- a/src/util/viralloc.h +++ b/src/util/viralloc.h @@ -90,21 +90,6

[libvirt PATCH v2 6/7] util: Use glib memory functions in virJSONValueGetArrayAsBitmap

Signed-off-by: Tim Wiederhake --- src/util/virjson.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virjson.c b/src/util/virjson.c index 6921eccb60..ba43d6b667 100644 --- a/src/util/virjson.c +++ b/src/util/virjson.c @@ -1243,8 +1243,7

[libvirt PATCH v2 5/7] tests: Use glib memory function in testConfRoundTrip

Signed-off-by: Tim Wiederhake --- tests/virconftest.c | 25 - 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/tests/virconftest.c b/tests/virconftest.c index cac3718495..8269730662 100644 --- a/tests/virconftest.c +++ b/tests/virconftest.c @@ -32,39 +32,30

[libvirt PATCH] cpu_map: Use g_auto* in cpuMapLoad

Signed-off-by: Tim Wiederhake --- src/cpu/cpu_map.c | 33 - 1 file changed, 12 insertions(+), 21 deletions(-) diff --git a/src/cpu/cpu_map.c b/src/cpu/cpu_map.c index 913e34a067..cbf90d1395 100644 --- a/src/cpu/cpu_map.c +++ b/src/cpu/cpu_map.c @@ -169,12 +169,11

[libvirt PATCH v2 2/2] cpu_ppc64: Remove error path in virCPUppc64DriverGetModels

The call to `g_strfreev` is not required, as in both cases no memory has been allocated. Signed-off-by: Tim Wiederhake --- src/cpu/cpu_ppc64.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index 9e6f1e856e..28fbfea9ae

[libvirt PATCH v2 1/2] cpu_map: Use g_auto* in loadData

Signed-off-by: Tim Wiederhake --- src/cpu/cpu_map.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/src/cpu/cpu_map.c b/src/cpu/cpu_map.c index 3abec68c60..65d244e011 100644 --- a/src/cpu/cpu_map.c +++ b/src/cpu/cpu_map.c @@ -39,20 +39,19 @@ loadData(const

[libvirt PATCH v2 0/2] Use g_auto* in src/cpu/*.

V1: https://www.redhat.com/archives/libvir-list/2020-September/msg00355.html Changes since V1: * Most patches already commited, this is the remainder. * Incorporated comment from Ján into patch #1. * Rebased on top of Daniels patches. With these patches, src/cpu/ becomes `goto` free. Tim

[libvirt PATCH 00/15] Use g_auto* in src/cpu/*.

Mostly mechanical changes, the most "interesting" patches are the first (wher= e should the `G_DEFINE_AUTOPTR_CLEANUP_FUN` go?) and the last (removing call to `g_str= freev`, as it should not be necessary). As an added benefit, this removes all `goto` usage in this directory. Tim Wied

[libvirt PATCH 06/15] cpu_ppc64: Turn structs ppc64_{vendor, model, map} into typedefs

This enables us to use g_auto* macros on those types. Signed-off-by: Tim Wiederhake --- src/cpu/cpu_ppc64.c | 91 + 1 file changed, 50 insertions(+), 41 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index 5b34c00a18..c7860cb1b4

[libvirt PATCH 10/15] cpu_ppc64: Use g_auto* in ppc64LoadMap

Signed-off-by: Tim Wiederhake --- src/cpu/cpu_ppc64.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index 44420c9cd5..7b34fe6bbc 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@ -384,19 +384,15

[libvirt PATCH 03/15] cpu_map: Use g_auto* in loadIncludes

Signed-off-by: Tim Wiederhake --- src/cpu/cpu_map.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/src/cpu/cpu_map.c b/src/cpu/cpu_map.c index 1b73249649..372c00a1cd 100644 --- a/src/cpu/cpu_map.c +++ b/src/cpu/cpu_map.c @@ -117,37 +117,31 @@ loadIncludes

[libvirt PATCH 12/15] cpu_ppc64: Use g_auto* in ppc64DriverDecode

Signed-off-by: Tim Wiederhake --- src/cpu/cpu_ppc64.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index aef1418872..d7ccd506fb 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@ -563,8 +563,7

[libvirt PATCH 07/15] cpu_ppc64: Use g_auto* in ppc64ModelCopy

Signed-off-by: Tim Wiederhake --- src/cpu/cpu_ppc64.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index c7860cb1b4..9eaf9c6ae5 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@ -188,23 +188,19

[libvirt PATCH 15/15] cpu_ppc64: Use g_auto* in virCPUppc64DriverGetModels

Signed-off-by: Tim Wiederhake --- src/cpu/cpu_ppc64.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index db59f5adbf..860e959900 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@ -734,33 +734,21

[libvirt PATCH 01/15] cpu_map: Use g_auto* in loadData

Signed-off-by: Tim Wiederhake --- src/cpu/cpu_map.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/src/cpu/cpu_map.c b/src/cpu/cpu_map.c index cbf90d1395..c315ab32b2 100644 --- a/src/cpu/cpu_map.c +++ b/src/cpu/cpu_map.c @@ -32,6 +32,8

[libvirt PATCH 02/15] cpu_map: Use g_auto* in cpuMapLoadInclude

Signed-off-by: Tim Wiederhake --- src/cpu/cpu_map.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/src/cpu/cpu_map.c b/src/cpu/cpu_map.c index c315ab32b2..1b73249649 100644 --- a/src/cpu/cpu_map.c +++ b/src/cpu/cpu_map.c @@ -81,10 +81,9

[libvirt PATCH 04/15] cpu: Use g_auto* in virCPUCompareXML

Signed-off-by: Tim Wiederhake --- src/cpu/cpu.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c index d502c02f51..a84eb10cc4 100644 --- a/src/cpu/cpu.c +++ b/src/cpu/cpu.c @@ -111,21 +111,15 @@ virCPUCompareXML(virArch arch

[libvirt PATCH 05/15] cpu: Use g_auto* in virCPUGetHost

Signed-off-by: Tim Wiederhake --- src/cpu/cpu.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c index a84eb10cc4..69e4205e4b 100644 --- a/src/cpu/cpu.c +++ b/src/cpu/cpu.c @@ -378,7 +378,7 @@ virCPUGetHost(virArch arch

[libvirt PATCH 13/15] cpu_ppc64: Use g_auto* in virCPUppc64GetHost

Signed-off-by: Tim Wiederhake --- src/cpu/cpu_ppc64.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index d7ccd506fb..30dd5a48c5 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@ -605,17 +605,16 @@ static

[libvirt PATCH 08/15] cpu_ppc64: Use g_auto* in ppc64VendorParse

Signed-off-by: Tim Wiederhake --- src/cpu/cpu_ppc64.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index 9eaf9c6ae5..81c3ce8319 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@ -281,8 +281,7

[libvirt PATCH 14/15] cpu_ppc64: Use g_auto* in virCPUppc64Baseline

Signed-off-by: Tim Wiederhake --- src/cpu/cpu_ppc64.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index 30dd5a48c5..db59f5adbf 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@ -653,19

[libvirt PATCH 09/15] cpu_ppc64: Use g_auto* in ppc64ModelParse

Signed-off-by: Tim Wiederhake --- src/cpu/cpu_ppc64.c | 33 + 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index 81c3ce8319..44420c9cd5 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c

[libvirt PATCH 11/15] cpu_ppc64: Use g_auto* in ppc64Compute

Signed-off-by: Tim Wiederhake --- src/cpu/cpu_ppc64.c | 46 - 1 file changed, 16 insertions(+), 30 deletions(-) diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index 7b34fe6bbc..aef1418872 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu

Re: [libvirt PATCH 1/7] util: alloc: Remove VIR_ALLOC_QUIET

On Thu, 2020-09-10 at 12:36 +0100, Daniel P. Berrangé wrote: > On Thu, Sep 10, 2020 at 01:29:19PM +0200, Tim Wiederhake wrote: > > Signed-off-by: Tim Wiederhake > > --- > > src/rpc/virnetmessage.c | 2 +- > > src/util/viralloc.h | 14 -- > &

[libvirt PATCH v4 2/5] cpu: Wire in XML validation

This adds a new value to virConnectCompareCPUFlags, "VIR_CONNECT_CPU_VALIDATE_XML", that governs XML document validation in virCPUDefParseXML. In src/conf/cpu_conf.c, include configmake.h for PKGDATADIR and virfile.h for virFileFindResource. Signed-off-by: Tim Wiederhake --- inclu

[libvirt PATCH v4 4/5] tests: Enable CPU XML validation in the tests.

Signed-off-by: Tim Wiederhake --- docs/schemas/cpu_test.rng | 48 +++ docs/schemas/meson.build | 1 + tests/cputest.c | 2 +- tests/virschematest.c | 1 + 4 files changed, 51 insertions(+), 1 deletion(-) create mode 100644 docs/schemas

[libvirt PATCH v4 3/5] tests: Rename some test files in cputestdata

g the XML. This test is not supposed to fail, as the files contain valid XML. Signed-off-by: Tim Wiederhake --- tests/cputest.c| 10 +- ...t-compat-invalid.xml => ppc64-guest-compat-bad.xml} | 0 ...t-legacy-invalid.xml => ppc64-guest-le

[libvirt PATCH v4 5/5] virsh: Add "validate" argument to [hypervisor-]cpu-compare

Signed-off-by: Tim Wiederhake --- docs/manpages/virsh.rst | 9 ++--- tools/virsh-host.c | 14 ++ 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index c855269041..8fee4c7afe 100644 --- a/docs/manpages

[libvirt PATCH v4 1/5] schema: Make element "topology" in host CPU definition optional

This element is not always present, see e.g. x86_64-cpuid-Xeon-X5460-host.xml, x86_64-cpuid-Pentium-P6100-host.xml, or x86_64-cpuid-EPYC-7601-32-Core-ibpb-host.xml. Signed-off-by: Tim Wiederhake --- docs/schemas/cputypes.rng | 24 +--- 1 file changed, 13 insertions(+), 11

[libvirt PATCH v4 0/5] Make unknown XML elements fail CPU comparison

Some patches from V3 are merged * Changes to commit messages * Perform testing by means of virschematest Tim Wiederhake (5): schema: Make element "topology" in host CPU definition optional cpu: Wire in XML validation tests: Rename some test files in cputestdata tests: Enable C

[libvirt PATCH] docs: Expand on recommendation in hypervisor-cpu-baseline description

On some architectures, e.g. aarch64 and s390x, the output of `virsh capabilities` is not suitable for use in `virsh hypervisor-cpu-baseline`. Expand the description of the man page to make this explicit. https://bugzilla.redhat.com/show_bug.cgi?id=1850654 Signed-off-by: Tim Wiederhake --- docs

[libvirt PATCH 3/3] [DONTMERGE] Sample output of new sync script

Do not merge this commit. This commit contains the changes that would be suggested by the cpu_map sync script (see last commit): ./sync_qemu_i386.py ~/git/qemu/target/i386/cpu.c . Note: * Some models have "signature" / "vendor" added. * Models with multiple "signature"s lose all but one. *

[libvirt PATCH 2/3] cpu_map: Add script to sync from QEMU i386 cpu models

information that cannot be generated from the QEMU data, preventing fully automated usage. The output should nevertheless be helpful for a human in determining potentially interesting changes. Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_i386.py | 361 ++ 1

[libvirt PATCH 0/3] Add script to sync from QEMU i386 cpu models

This hopefully makes synchronization with QEMU faster and less error prone. Patch #3 showcases the changes to the cpu models the script suggests for qemu 8d90bfc5c31ad60f6049dd39be636b06bc00b652. Tim Wiederhake (3): cpu_map: Unify apostrophe and quotation mark usage cpu_map: Add script

Re: [libvirt PATCH 9/9] tests: Add tests for unknown elements and attributes in cpu defintion

On Wed, 2020-09-30 at 14:11 +0200, Peter Krempa wrote: > On Wed, Sep 30, 2020 at 13:54:58 +0200, Tim Wiederhake wrote: > > On Tue, 2020-09-29 at 11:22 +0200, Peter Krempa wrote: > > > On Mon, Sep 21, 2020 at 15:07:32 +0200, Tim Wiederhake wrote: > > > >

[libvirt PATCH v2 3/3] [DONTMERGE] Sample output of new sync script

Do not merge this commit. This commit contains the changes that would be suggested by the cpu_map sync script (see last commit): ./sync_qemu_i386.py ~/git/qemu/target/i386/cpu.c . Note: * Some models have "signature" / "vendor" added. * Models with multiple "signature"s lose all but one. *

[libvirt PATCH v2 0/3] Add script to sync from QEMU i386 cpu models

version: * Use apostrophes instead of quotation marks in XML. Tim Wiederhake (3): cpu_map: Unify apostrophe and quotation mark usage cpu_map: Add script to sync from QEMU i386 cpu models [DONTMERGE] Sample output of new sync script src/cpu_map/arm_vendors.xml | 24 +- src

[libvirt PATCH v2 1/3] cpu_map: Unify apostrophe and quotation mark usage

Usage was mixed. Signed-off-by: Tim Wiederhake --- src/cpu_map/arm_vendors.xml| 24 ++--- src/cpu_map/index.xml | 140 +-- src/cpu_map/x86_Cooperlake.xml | 166 - 3 files changed, 165 insertions(+), 165 deletions(-) diff

[libvirt PATCH v2 2/3] cpu_map: Add script to sync from QEMU i386 cpu models

information that cannot be generated from the QEMU data, preventing fully automated usage. The output should nevertheless be helpful for a human in determining potentially interesting changes. Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_i386.py | 361 ++ 1

[libvirt PATCH 0/4] Some documentation fixes

of the "feature" element in the section about "cpu". Tim Wiederhake (4): tests: Remove references to "cpu_map.xml" in the code qemu: Remove references to "cpu_map.xml" in the code docs: Remove references to "cpu_map.xml" in the documentation doc: F

[libvirt PATCH 4/4] doc: Fix element name in description of "feature"

Actual change is "s/``elements``/``feature`` elements/", rest is reflow. Signed-off-by: Tim Wiederhake --- docs/formatdomain.rst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 0ffb1b7196..df5ac28

[libvirt PATCH 2/4] qemu: Remove references to "cpu_map.xml" in the code

"cpu_map.xml" was moved to a directory "cpu_map" and split up into several files. Signed-off-by: Tim Wiederhake --- src/qemu/qemu_capabilities.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilitie

[libvirt PATCH 1/4] tests: Remove references to "cpu_map.xml" in the code

"cpu_map.xml" was moved to a directory "cpu_map" and split up into several files. Signed-off-by: Tim Wiederhake --- tests/cputest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/cputest.c b/tests/cputest.c index bf5ce84aa7..87ad5825b8 100644 -

[libvirt PATCH 3/4] docs: Remove references to "cpu_map.xml" in the documentation

"cpu_map.xml" was moved to a directory "cpu_map" and split up into several files. Signed-off-by: Tim Wiederhake --- docs/formatdomain.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index cc4f91d4e

Re: [PATCH] spec: Add cpu.rng to %files

On Wed, 2020-10-07 at 19:22 -0400, Cole Robinson wrote: > Fixes: 51v5d325240c645ea6c1a0902c695cf299410b1f90c > > Signed-off-by: Cole Robinson > --- > Pushed as trivial > > libvirt.spec.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libvirt.spec.in b/libvirt.spec.in > index

  1   2   3   4   5   6   7   8   9   10   >