[libvirt PATCH 00/16] Refactor virDomainFeaturesDefParse

Some refactoring in preparation for adding support for qemu's "hv-passthrough" and the yet-to-be-merged "hv-defaults". Tim Wiederhake (16): virDomainFeaturesDefParse: Factor out HyperV parsing into separate function virDomainFeaturesHyperVDefParse: Inline h

[libvirt PATCH 04/16] virDomainFeaturesHyperVDefParse: Remove tautological "if"

Fix some line wrapping in the process. Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 163 +++-- 1 file changed, 77 insertions(+), 86 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b778dfe463..3ba41869ec 100644

[libvirt PATCH 14/16] virDomainFeaturesDefParse: Factor out capabilities parsing into separate function

Cleanup to follow. This removes the last re-use of `nodes` in this function, eliminating two VIR_FREEs. Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 78 +- 1 file changed, 46 insertions(+), 32 deletions(-) diff --git a/src/conf

[libvirt PATCH 15/16] virDomainFeaturesCapabilitiesDefParse: Remove ctxt

Iterating over all child elements of a node does not require xpath. By doing away with xpath for this code, the code can be simplified. Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/src/conf

[libvirt PATCH 07/16] virDomainFeaturesKVMDefParse: Remove tautological "switch"

`feature` is always one of the values listed in the switch, ensured by `virDomainKVMTypeFromString` above. Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf

[libvirt PATCH] docs: Fix some typos

Signed-off-by: Tim Wiederhake --- docs/kbase/live_full_disk_backup.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/kbase/live_full_disk_backup.rst b/docs/kbase/live_full_disk_backup.rst index 1605ec05d2..562a9e87b0 100644 --- a/docs/kbase

Re: [libvirt PATCH v2 0/7] Enable sanitizers

Ping On Tue, 2021-05-18 at 10:41 +0200, Tim Wiederhake wrote: > Ping. > > On Thu, 2021-05-06 at 17:08 +0200, Tim Wiederhake wrote: > > This series enables and adds AddressSanitizer and > > UndefinedBehaviorSanitizer > > builds to the CI. > > > &g

[libvirt PATCH v2 0/6] Refactor more XML parsing boilerplate code, part X

For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Changes since V1: * Split up VIR_FREE'd and reused ´g_autofree xmlNodePtr *´ variables. Tim Wiederhake (6): virNodeDeviceDefParseXML: Use g_auto* virDomainNumatuneNodeParseXML: Use virXMLProp

[libvirt PATCH v2 6/6] virDomainNumaDefParseXML: Use g_autofree

Signed-off-by: Tim Wiederhake --- src/conf/numa_conf.c | 84 +--- 1 file changed, 40 insertions(+), 44 deletions(-) diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c index 9fe4998951..525bc28962 100644 --- a/src/conf/numa_conf.c +++ b/src/conf

[libvirt PATCH v2 3/6] virDomainNumatuneNodeParseXML: Use g_autofree

Signed-off-by: Tim Wiederhake --- src/conf/numa_conf.c | 34 ++ 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c index bae59ac7b8..15bfda3aa1 100644 --- a/src/conf/numa_conf.c +++ b/src/conf/numa_conf.c

[libvirt PATCH v2 1/6] virNodeDeviceDefParseXML: Use g_auto*

Signed-off-by: Tim Wiederhake --- src/conf/node_device_conf.c | 44 +++-- 1 file changed, 18 insertions(+), 26 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index 4477a8d9d2..861f43f6c4 100644 --- a/src/conf

[libvirt PATCH v2 5/6] virDomainNumaDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/numa_conf.c | 128 +- .../hugepages-memaccess-invalid.err | 2 +- 2 files changed, 35 insertions(+), 95 deletions(-) diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c index 60cd7767ef

[libvirt PATCH v2 4/6] virDomainNumaDefNodeDistanceParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/numa_conf.c | 42 -- 1 file changed, 4 insertions(+), 38 deletions(-) diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c index 15bfda3aa1..60cd7767ef 100644 --- a/src/conf/numa_conf.c +++ b/src/conf

[libvirt PATCH v2 2/6] virDomainNumatuneNodeParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/numa_conf.c | 45 +--- 1 file changed, 13 insertions(+), 32 deletions(-) diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c index 932af4a185..bae59ac7b8 100644 --- a/src/conf/numa_conf.c +++ b/src/conf

Re: [libvirt PATCH 04/10] virDomainNumaDefNodeDistanceParseXML: Use virXMLProp*

On Tue, 2021-05-11 at 12:15 -0400, Laine Stump wrote: > On 5/11/21 11:01 AM, Tim Wiederhake wrote: > > Signed-off-by: Tim Wiederhake > > --- > > src/conf/numa_conf.c | 42 --- > > --- > > 1 file changed, 4 insertions(+), 38

Re: [libvirt PATCH v2 0/7] Enable sanitizers

Ping. On Thu, 2021-05-06 at 17:08 +0200, Tim Wiederhake wrote: > This series enables and adds AddressSanitizer and > UndefinedBehaviorSanitizer > builds to the CI. > > See: > https://clang.llvm.org/docs/AddressSanitizer.html and > https://clang.llvm.org/docs/UndefinedB

[libvirt PATCH 04/10] virDomainDiskDef: Change type of geometry.trans to virDomainDiskGeometryTrans

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 5 +++-- src/conf/domain_conf.h | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 86680e0cdb..f55117e849 100644 --- a/src/conf/domain_conf.c +++ b/src/conf

[libvirt PATCH 05/10] virDomainDiskDefGeometryParse: Use virXMLProp*

This strictens the parser to disallow negative values (interpreted as `UINT_MAX + value + 1`) for attributes `cyls`, `heads` and `secs`. Allowing negative numbers to be interpreted this way makes no sense for these attributes. Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 48

[libvirt PATCH 08/10] virDomainAudioCoreAudioParse: Use virXMLProp*

This strictens the parser to disallow negative values (interpreted as `UINT_MAX + value + 1`) for attribute `bufferCount`. Allowing negative numbers to be interpreted this way makes no sense for this attribute. Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 10 ++ 1 file

[libvirt PATCH 07/10] virDomainChrDefParseTargetXML: Use virXMLProp*

This strictens the parser to disallow negative values (interpreted as `UINT_MAX + value + 1`) for attribute `port`. Allowing negative numbers to be interpreted this way makes no sense for this attribute. Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 29

[libvirt PATCH 09/10] virDomainAudioOSSParse: Use virXMLProp*

This strictens the parser to disallow negative values (interpreted as `UINT_MAX + value + 1`) for attribute `bufferCount`. Allowing negative numbers to be interpreted this way makes no sense for this attribute. Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 19 --- 1

[libvirt PATCH 01/10] virDomainHostdevDef: Change type of startupPolicy to virDomainStartupPolicy

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 6 +++--- src/conf/domain_conf.h | 21 ++--- 2 files changed, 13 insertions(+), 14 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7044701fac..734fa584a4 100644 --- a/src/conf

[libvirt PATCH 03/10] virDomainDeviceUSBMasterParseXML: Use virXMLProp*

This strictens the parser to disallow negative values (interpreted as `UINT_MAX + value + 1`) for attribute `startport`. Allowing negative numbers to be interpreted this way makes no sense for this attribute. Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 11 ++- 1 file

[libvirt PATCH 06/10] virDomainChrSourceReconnectDefParseXML: Use virXMLProp*

This strictens the parser to disallow negative values (interpreted as `UINT_MAX + value + 1`) for attribute `timeout`. Allowing negative numbers to be interpreted this way makes no sense for this attribute. Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 29

[libvirt PATCH 10/10] virNodeDevCapPCIDevIommuGroupParseXML: Use virXMLProp*

This strictens the parser to disallow negative values (interpreted as `UINT_MAX + value + 1`) for attribute `number`. Allowing negative numbers to be interpreted this way makes no sense for this attribute. Signed-off-by: Tim Wiederhake --- src/conf/node_device_conf.c | 15 ++- 1

[libvirt PATCH 02/10] virDomainHostdevSubsysUSBDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 734fa584a4..661fa53206 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part XI

For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Tim Wiederhake (10): virDomainHostdevDef: Change type of startupPolicy to virDomainStartupPolicy virDomainHostdevSubsysUSBDefParseXML: Use virXMLProp* virDomainDeviceUSBMasterParseXML: Use

Re: [libvirt PATCH v2 7/7] ci: Enable address and undefined behavior sanitizers

On Fri, 2021-05-07 at 08:36 +0200, Erik Skultety wrote: > On Thu, May 06, 2021 at 05:34:55PM +0200, Peter Krempa wrote: > > On Thu, May 06, 2021 at 17:08:38 +0200, Tim Wiederhake wrote: > > > meson supports the following sanitizers: "address" (e.g. out-of- > >

[libvirt PATCH 08/10] conf: node_device: Register autoptr cleanup function for virNodeDevCapsDef

Signed-off-by: Tim Wiederhake --- src/conf/node_device_conf.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/conf/node_device_conf.h b/src/conf/node_device_conf.h index 85790ad96c..a60562e4fe 100644 --- a/src/conf/node_device_conf.h +++ b/src/conf/node_device_conf.h @@ -377,6 +377,8

[libvirt PATCH 04/10] virNetworkDHCPLeaseTimeDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/network_conf.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index c3c335135b..a9eadff29c 100644 --- a/src/conf/network_conf.c +++ b/src/conf

[libvirt PATCH 03/10] virNetworkDHCPLeaseTimeDef: Make expiry unsigned long long

The width of `unsigned long` differs on 32 bit and 64 bit architectures. There is no compelling reason why the maximum DHCP lease time should depend on the architecture. Signed-off-by: Tim Wiederhake --- src/conf/network_conf.c | 8 src/conf/network_conf.h | 2 +- src/network

[libvirt PATCH 05/10] virPCIEDeviceInfoLinkParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/node_device_conf.c | 34 ++ 1 file changed, 6 insertions(+), 28 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index faa36c1944..ef09ed0a6f 100644 --- a/src/conf/node_device_conf.c

[libvirt PATCH 06/10] virPCIEDeviceInfoLinkParseXML: Remove unused parameter ctxt

Signed-off-by: Tim Wiederhake --- src/conf/node_device_conf.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index ef09ed0a6f..34c8aa988e 100644 --- a/src/conf/node_device_conf.c +++ b/src/conf

[libvirt PATCH 07/10] virNodeDevCapsDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/node_device_conf.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index 34c8aa988e..b3d5bc1515 100644 --- a/src/conf/node_device_conf.c +++ b/src/conf

[libvirt PATCH 09/10] virNodeDevCapsDefParseXML: Use g_autoptr

Signed-off-by: Tim Wiederhake --- src/conf/node_device_conf.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index b3d5bc1515..04014f75dc 100644 --- a/src/conf/node_device_conf.c +++ b/src/conf

[libvirt PATCH 10/10] virNodeDeviceDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/node_device_conf.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index 04014f75dc..4477a8d9d2 100644 --- a/src/conf/node_device_conf.c +++ b/src/conf

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part IX

For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Tim Wiederhake (10): virDomainObjParseXML: Use virXMLProp* virDomainObjParseXML: Use g_autoptr virNetworkDHCPLeaseTimeDef: Make expiry unsigned long long virNetworkDHCPLeaseTimeDefParseXML: Use

[libvirt PATCH 01/10] virDomainObjParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 36 +--- 1 file changed, 13 insertions(+), 23 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e8632e4d73..0d396cbdda 100644 --- a/src/conf/domain_conf.c +++ b/src/conf

[libvirt PATCH 02/10] virDomainObjParseXML: Use g_autoptr

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 30 +- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0d396cbdda..7044701fac 100644 --- a/src/conf/domain_conf.c +++ b/src/conf

[libvirt PATCH v2 6/7] virt-aa-helper: Remove duplicate linking with src/datatypes.o

"virt-aa-helper" links, amongst others, against "datatypes.o" and "libvirt.so". The latter links against "libvirt_driver.a" which in turn also links against "datatypes.o", leading to a One-Definition-Rule violoation for "virConnectClass&q

[libvirt PATCH v2 4/7] openvz: Add missing symbols to libvirt_openvz.syms

Signed-off-by: Tim Wiederhake --- src/libvirt_openvz.syms | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libvirt_openvz.syms b/src/libvirt_openvz.syms index ac0ed0d23e..a1038e51a4 100644 --- a/src/libvirt_openvz.syms +++ b/src/libvirt_openvz.syms @@ -3,10 +3,12 @@ # # openvz

[libvirt PATCH v2 7/7] ci: Enable address and undefined behavior sanitizers

implementations of these sanitizers and have proven to find different issues. Create CI jobs for both. Signed-off-by: Tim Wiederhake --- .gitlab-ci.yml | 35 +++ 1 file changed, 35 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 89f618e678..4de4c30d

[libvirt PATCH v2 5/7] tests: openvzutilstest: Remove duplicate linking with libvirt_openvz.a

"openvzutilstest" links, amongst others, against "libvirt_openvz.a" and "libvirt.so". The latter also links against "libvirt_openvz.a", leading to a One-Definition-Rule violation for "openvzLocateConfFile" in "openvz_conf.c". Signed-o

[libvirt PATCH v2 3/7] tests: virfilemock: realpath: Allow non-null second parameter

When other preloaded libraries wrap and / or make calls to `realpath` (e.g. LLVM's AddessSanitizer), the second parameter is no longer guaranteed to be NULL. Signed-off-by: Tim Wiederhake --- build-aux/syntax-check.mk | 2 +- tests/virfilemock.c | 20 2 files changed

[libvirt PATCH v2 1/7] meson: Allow larger stack frames when instrumenting

When enabling sanitizers, gcc adds some instrumentation to the code that may enlarge stack frames. Some function's stack frames are already close to the limit of 4096 and are enlarged past that threshold, e.g. virLXCProcessStart which reaches a frame size of 4624 bytes. Signed-off-by: Tim

[libvirt PATCH v2 0/7] Enable sanitizers

was fooled by caching. The bug described there is present in Fedora 33, 34, and Rawhide. Cheers, Tim Tim Wiederhake (7): meson: Allow larger stack frames when instrumenting meson: Allow undefined symbols when sanitizers are enabled tests: virfilemock: realpath: Allow non-null second parameter

[libvirt PATCH v2 2/7] meson: Allow undefined symbols when sanitizers are enabled

building with sanitizers enabled. Signed-off-by: Tim Wiederhake --- meson.build | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 997a23f1b0..02feb0e43d 100644 --- a/meson.build +++ b/meson.build @@ -491,9 +491,12 @@ libvirt_nodelete

[libvirt PATCH 05/10] virDomainNumaDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/numa_conf.c | 128 +- .../hugepages-memaccess-invalid.err | 2 +- 2 files changed, 35 insertions(+), 95 deletions(-) diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c index e631bfa341

[libvirt PATCH 09/10] virStoragePoolDefParseSource: Use VIR_XPATH_NODE_AUTORESTORE

Signed-off-by: Tim Wiederhake --- src/conf/storage_conf.c | 41 ++--- 1 file changed, 18 insertions(+), 23 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 435a029b4e..10b46ac368 100644 --- a/src/conf/storage_conf.c +++ b/src

[libvirt PATCH 07/10] virStorageAdapterParseXMLFCHost: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/storage_adapter_conf.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/src/conf/storage_adapter_conf.c b/src/conf/storage_adapter_conf.c index 142489f6cd..6b5a58e1e7 100644 --- a/src/conf/storage_adapter_conf.c

[libvirt PATCH 08/10] virStoragePoolDefParseSource: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/storage_conf.c | 31 --- 1 file changed, 8 insertions(+), 23 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 328650bd6a..435a029b4e 100644 --- a/src/conf/storage_conf.c +++ b/src/conf

[libvirt PATCH 04/10] virDomainNumaDefNodeDistanceParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/numa_conf.c | 42 -- 1 file changed, 4 insertions(+), 38 deletions(-) diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c index 531bdc6eba..e631bfa341 100644 --- a/src/conf/numa_conf.c +++ b/src/conf

[libvirt PATCH 02/10] virDomainNumatuneNodeParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/numa_conf.c | 45 +--- 1 file changed, 13 insertions(+), 32 deletions(-) diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c index 932af4a185..bae59ac7b8 100644 --- a/src/conf/numa_conf.c +++ b/src/conf

[libvirt PATCH 01/10] virNodeDeviceDefParseXML: Use g_auto*

Signed-off-by: Tim Wiederhake --- src/conf/node_device_conf.c | 34 +- 1 file changed, 13 insertions(+), 21 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index 4477a8d9d2..5ac046f768 100644 --- a/src/conf/node_device_conf.c

[libvirt PATCH 06/10] virDomainNumaDefParseXML: Use g_autofree

Signed-off-by: Tim Wiederhake --- src/conf/numa_conf.c | 49 +++- 1 file changed, 21 insertions(+), 28 deletions(-) diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c index 27aac87a8d..abb39a36ac 100644 --- a/src/conf/numa_conf.c +++ b/src/conf

[libvirt PATCH 10/10] virStoragePoolDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/storage_conf.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 10b46ac368..e481cac75c 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part X

For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Tim Wiederhake (10): virNodeDeviceDefParseXML: Use g_auto* virDomainNumatuneNodeParseXML: Use virXMLProp* virDomainNumatuneNodeParseXML: Use g_autofree virDomainNumaDefNodeDistanceParseXML: Use

[libvirt PATCH 03/10] virDomainNumatuneNodeParseXML: Use g_autofree

Signed-off-by: Tim Wiederhake --- src/conf/numa_conf.c | 33 ++--- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c index bae59ac7b8..531bdc6eba 100644 --- a/src/conf/numa_conf.c +++ b/src/conf/numa_conf.c

[libvirt PATCH v2 06/11] qemuMonitorGetBlockInfo: Remove superfluous variable "ret"

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index dd0658f93c..933d4a0154 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -2103,7 +2103,6

[libvirt PATCH v2 07/11] qemuMonitorGetBlockInfo: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 933d4a0154..2253c96cb5 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -2103,7 +2103,7

[libvirt PATCH v2 09/11] qemuMonitorGetChardevInfo: Remove superfluous variable "ret"

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index f2c35ab173..cb59fc7b7b 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -2884,7 +2884,6

[libvirt PATCH v2 05/11] qemuMonitorGetAllBlockStatsInfo: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 6ff7302360..dd0658f93c 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -2155,15 +2155,12

[libvirt PATCH v2 03/11] qemuMonitorGetAllBlockStatsInfo: Assign hash table only on success

`virHashNew` cannot return NULL, the check is not needed. Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 19fcc5658b..d24531832b 100644 --- a/src/qemu

[libvirt PATCH v2 04/11] qemuMonitorGetAllBlockStatsInfo: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index d24531832b..6ff7302360 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c

[libvirt PATCH v2 02/11] qemuMonitorGetAllBlockStatsInfo: Remove superfluous variable initialization

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index df1e41f68f..19fcc5658b 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -2154,7 +2154,7

[libvirt PATCH v2 08/11] qemuMonitorGetBlockInfo: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 2253c96cb5..f2c35ab173 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -2103,13 +2103,10

[libvirt PATCH v2 01/11] qemuMonitorGetAllBlockStatsInfo: Clean up line break

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 8f35b4240f..df1e41f68f 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -2162,8 +2162,7

[libvirt PATCH v2 00/11] virHashNew refactorings

m/archives/libvir-list/2021-July/msg00074.html Changes since v1: * Fixed a memory leak that was introduced in patch #3 and fixed in patch #4 * Split up patches 3 and 4 into three patches Regards, Tim Tim Wiederhake (11): qemuMonitorGetAllBlockStatsInfo: Clean up line break qemuMonitorGetAllBloc

[libvirt PATCH v2 10/11] qemuMonitorGetChardevInfo: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index cb59fc7b7b..4489b809f4 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c

[libvirt PATCH v2 11/11] qemuMonitorGetChardevInfo: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 4489b809f4..ef24b2ca1e 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -2884,16 +2884,13

[libvirt PATCH 1/2] virQEMUCapsGetMachineTypesCaps: Use GPtrArray

This simplyfies the code a bit and removes one "goto", one "VIR_FREE", and one "VIR_INSERT_ELEMENT_COPY". Signed-off-by: Tim Wiederhake --- src/qemu/qemu_capabilities.c | 37 ++-- 1 file changed, 18 insertions(+), 19 delet

[libvirt PATCH 2/2] viralloc: Delete VIR_INSERT_ELEMENT_COPY and VIR_INSERT_ELEMENT_COPY_INPLACE

There are no users left. Signed-off-by: Tim Wiederhake --- src/util/viralloc.h | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/src/util/viralloc.h b/src/util/viralloc.h index 553d2951cf..72e8f13bef 100644 --- a/src/util/viralloc.h +++ b/src/util

[libvirt PATCH 0/2] Remove macros "VIR_INSERT_ELEMENT_COPY" and "VIR_INSERT_ELEMENT_COPY_INPLACE"

There was but one use left, and that is removed in patch 1. Tim Wiederhake (2): virQEMUCapsGetMachineTypesCaps: Use GPtrArray viralloc: Delete VIR_INSERT_ELEMENT_COPY and VIR_INSERT_ELEMENT_COPY_INPLACE src/qemu/qemu_capabilities.c | 37 ++-- src/util

[libvirt PATCH 05/10] iptablesPrivateChainCreate: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/util/viriptables.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/util/viriptables.c b/src/util/viriptables.c index 4189578245..198ece3d71 100644 --- a/src/util/viriptables.c +++ b/src/util/viriptables.c @@ -70,17 +70,12

[libvirt PATCH 06/10] iptablesPrivateChainCreate: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/util/viriptables.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/util/viriptables.c b/src/util/viriptables.c index 198ece3d71..847af9b9d7 100644 --- a/src/util/viriptables.c +++ b/src/util/viriptables.c @@ -70,8 +70,8

[libvirt PATCH 09/10] qemuMonitorGetMemoryDeviceInfo: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 8646efe9c4..3a56ed8ef9 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -4238,7

[libvirt PATCH 07/10] iptablesPrivateChainCreate: Remove superfluous `goto`s

Signed-off-by: Tim Wiederhake --- src/util/viriptables.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/util/viriptables.c b/src/util/viriptables.c index 847af9b9d7..721e1eeae7 100644 --- a/src/util/viriptables.c +++ b/src/util/viriptables.c @@ -73,14 +73,13

[libvirt PATCH 10/10] qemuMonitorGetMemoryDeviceInfo: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 3a56ed8ef9..4506f962d1 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -4238,7 +4238,7

[libvirt PATCH 02/10] virNWFilterCreateVarsFrom: Use automatic memory management

Signed-off-by: Tim Wiederhake --- tests/nwfilterxml2firewalltest.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/nwfilterxml2firewalltest.c b/tests/nwfilterxml2firewalltest.c index 3b7190b5cd..26d4a936ad 100644 --- a/tests/nwfilterxml2firewalltest.c +++ b/tests

[libvirt PATCH 08/10] qemuMonitorGetMemoryDeviceInfo: Assign hash table only on success

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 8f35b4240f..8646efe9c4 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -4238,6

[libvirt PATCH 04/10] virNWFilterRuleDefToRuleInst: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- tests/nwfilterxml2firewalltest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/nwfilterxml2firewalltest.c b/tests/nwfilterxml2firewalltest.c index bdfe858185..75a70e9972 100644 --- a/tests/nwfilterxml2firewalltest.c +++ b/tests

[libvirt PATCH 01/10] virNWFilterCreateVarsFrom: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- tests/nwfilterxml2firewalltest.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/nwfilterxml2firewalltest.c b/tests/nwfilterxml2firewalltest.c index 6709cc15fd..3b7190b5cd 100644 --- a/tests/nwfilterxml2firewalltest.c +++ b/tests

[libvirt PATCH 03/10] virNWFilterCreateVarsFrom: Remove superfluous `goto`s

Signed-off-by: Tim Wiederhake --- tests/nwfilterxml2firewalltest.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/nwfilterxml2firewalltest.c b/tests/nwfilterxml2firewalltest.c index 26d4a936ad..bdfe858185 100644 --- a/tests/nwfilterxml2firewalltest.c +++ b/tests

[libvirt PATCH 00/10] virHashNew refactorings - part II

"virHashNew" cannot return NULL, yet we check for NULL in various places. See https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html. Tim Wiederhake (10): virNWFilterCreateVarsFrom: `virHashNew` cannot return NULL virNWFilterCreateVarsFrom: Use automatic memory

Re: [libvirt PATCH 1/2] virQEMUCapsGetMachineTypesCaps: Use GPtrArray

On Fri, 2021-07-09 at 12:05 +0200, Michal Prívozník wrote: > On 7/8/21 4:28 PM, Tim Wiederhake wrote: > > This simplyfies the code a bit and removes one "goto", one > > "VIR_FREE", > > and one "VIR_INSERT_ELEMENT_COPY". > >

[libvirt PATCH 01/10] testCompareXMLToArgvFiles: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- tests/nwfilterxml2firewalltest.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/nwfilterxml2firewalltest.c b/tests/nwfilterxml2firewalltest.c index 6709cc15fd..1cde8e258e 100644 --- a/tests/nwfilterxml2firewalltest.c +++ b/tests

[libvirt PATCH 06/10] testQemuMonitorJSONqemuMonitorJSONGetBlockInfo: Remove superfluous `goto`s

Signed-off-by: Tim Wiederhake --- tests/qemumonitorjsontest.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index e4a907e5b6..7fd58dc2d1 100644 --- a/tests/qemumonitorjsontest.c +++ b/tests

[libvirt PATCH 07/10] testQemuMonitorJSONqemuMonitorJSONGetBlockInfo: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- tests/qemumonitorjsontest.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index 7fd58dc2d1..89ede3b59a 100644 --- a/tests/qemumonitorjsontest.c +++ b/tests

[libvirt PATCH 08/10] testQemuMonitorJSONqemuMonitorJSONGetChardevInfo: Use automatic memory management

Signed-off-by: Tim Wiederhake --- tests/qemumonitorjsontest.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index 89ede3b59a..89ace3bb33 100644 --- a/tests/qemumonitorjsontest.c +++ b/tests

[libvirt PATCH 09/10] testQemuMonitorJSONqemuMonitorJSONGetChardevInfo: Remove superfluous `goto`s

Signed-off-by: Tim Wiederhake --- tests/qemumonitorjsontest.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index 89ace3bb33..37d878b0ad 100644 --- a/tests/qemumonitorjsontest.c +++ b/tests

Re: [libvirt PATCH] virThreadPoolExpand: Prevent expanding worker pool by zero

On Mon, 2021-07-12 at 10:09 +0200, Peter Krempa wrote: > On Fri, Jul 09, 2021 at 15:43:06 +0200, Tim Wiederhake wrote: > > `virThreadPoolNewFull` may call `virThreadPoolExpand` with > > `prioWorkers` = 0. > > Could you elaborate in which situations this happens? Sure!

[libvirt PATCH 04/10] testQemuMonitorJSONqemuMonitorJSONGetAllBlockStatsInfo: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- tests/qemumonitorjsontest.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index b1332eb1df..8895c7305f 100644 --- a/tests/qemumonitorjsontest.c +++ b/tests/qemumonitorjsontest.c

[libvirt PATCH 05/10] testQemuMonitorJSONqemuMonitorJSONGetBlockInfo: Use automatic memory management

Signed-off-by: Tim Wiederhake --- tests/qemumonitorjsontest.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index 8895c7305f..e4a907e5b6 100644 --- a/tests/qemumonitorjsontest.c +++ b/tests

[libvirt PATCH 02/10] testQemuMonitorJSONqemuMonitorJSONGetAllBlockStatsInfo: Use automatic memory management

Signed-off-by: Tim Wiederhake --- tests/qemumonitorjsontest.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index e6746b806f..e993c30c97 100644 --- a/tests/qemumonitorjsontest.c +++ b/tests/qemumonitorjsontest.c

[libvirt PATCH 10/10] testQemuMonitorJSONqemuMonitorJSONGetChardevInfo: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- tests/qemumonitorjsontest.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index 37d878b0ad..0b321e8ed8 100644 --- a/tests/qemumonitorjsontest.c +++ b/tests

[libvirt PATCH 00/10] virHashNew refactorings - part III

"virHashNew" cannot return NULL, yet we check for NULL in various places. See https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html. Tim Wiederhake (10): testCompareXMLToArgvFiles: `virHashNew` cannot return NULL testQemuMonitorJSONqemuMonitorJSONGetAllBlockStat

[libvirt PATCH 03/10] testQemuMonitorJSONqemuMonitorJSONGetAllBlockStatsInfo: Remove superfluous `goto`s

Signed-off-by: Tim Wiederhake --- tests/qemumonitorjsontest.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index e993c30c97..b1332eb1df 100644 --- a/tests/qemumonitorjsontest.c +++ b/tests

Re: [libvirt][PATCH v4 4/4] Support to query SGX capability

On Thu, 2021-07-01 at 20:10 +0800, Haibin Huang wrote: > 1.Add SGX feature in domain capabilities > 2.Get sgx capabilities by query-sgx-capabilities > 3.Transfer the B to KB for epc_size > 4.Delete sgx1 and sgx2 > 5.add unit test for get capabilities > > Signed-off-by: Haibin Huang > --- >  

Re: [libvirt][PATCH v4 1/4] conf: Introduce SGX related element into domain xml

On Thu, 2021-07-01 at 20:10 +0800, Haibin Huang wrote: > From: Lin Yang > >   >     1024 >   Please also update "docs/schemas/domaincommon.rng". > --- >  src/conf/domain_conf.c  | 106 +- > -- >  src/conf/domain_conf.h  |  10 >  src/conf/virconftypes.h

Re: [libvirt][PATCH v4 3/4] qemu: Add command-line to enable SGX

On Thu, 2021-07-01 at 20:10 +0800, Haibin Huang wrote: > From: Lin Yang > > If SGX is defined in domain, add the argument to enable > SGX in -cpu : > >     -cpu ,+sgx,+sgx-debug,+sgx1,+sgx-encls-c, >     +sgx-enclv,+sgx-exinfo,+sgx-kss,+sgx-mode64, >    

<    1   2   3   4   5   6   7   8   9   10   >