[libvirt PATCH 10/10] virDomainResctrlMonDefParse: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 483df91880..b3ef2db3fa 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

[libvirt PATCH 05/10] virDomainIOThreadPinDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 20 +++- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e95be17989..d7cef00246 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

[libvirt PATCH 02/10] virDomainPerfEventDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 33 + 1 file changed, 9 insertions(+), 24 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 5822f3d85a..8930dc33ce 100644 --- a/src/conf/domain_conf.c +++ b/src/conf

[libvirt PATCH 01/10] virDomainRedirFilterUSBDevDefParseXML: Use g_auto*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0050b952f3..5822f3d85a 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

[libvirt PATCH 06/10] virDomainSchedulerParseCommonAttrs: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 34 ++ 1 file changed, 6 insertions(+), 28 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d7cef00246..8f4fd0e3bc 100644 --- a/src/conf/domain_conf.c +++ b/src/conf

[libvirt PATCH 04/10] virDomainVcpuPinDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b8ac399f5c..e95be17989 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -17273,17

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part VIII

For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Note that patch #1 depends on https://listman.redhat.com/archives/libvir-list/2021-April/msg01260.html from part VII. Tim Wiederhake (10): virDomainRedirFilterUSBDevDefParseXML: Use g_auto

[libvirt PATCH 03/10] virDomainMemoryDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 41 - 1 file changed, 8 insertions(+), 33 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 8930dc33ce..b8ac399f5c 100644 --- a/src/conf/domain_conf.c +++ b/src/conf

[libvirt PATCH 08/10] virDomainVcpuParse: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 84 ++ 1 file changed, 20 insertions(+), 64 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 20cf987176..52d12bfb43 100644 --- a/src/conf/domain_conf.c +++ b/src

[libvirt PATCH 09/10] virDomainCachetuneDefParseCache: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 43 +- 1 file changed, 5 insertions(+), 38 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 52d12bfb43..483df91880 100644 --- a/src/conf/domain_conf.c +++ b/src/conf

[libvirt PATCH 4/6] tests: openvzutilstest: Remove duplicate linking with libvirt_openvz.a

"openvzutilstest" links, amongst others, against "libvirt_openvz.a" and "libvirt.so". The latter also links against "libvirt_openvz.a", leading to a One-Definition-Rule violation for "openvzLocateConfFile" in "openvz_conf.c". Sig

[libvirt PATCH 5/6] virt-aa-helper: Remove duplicate linking with src/datatypes.o

"virt-aa-helper" links, amongst others, against "datatypes.o" and "libvirt.so". The latter links against "libvirt_driver.a" which in turn also links against "datatypes.o", leading to a One-Definition-Rule violoation for "virConnectClass&q

[libvirt PATCH 1/6] meson: Allow larger stack frames when instrumenting

When enabling sanitizers, gcc adds some instrumentation to the code that may enlarge stack frames. Some function's stack frames are already close to the limit of 4096 and are enlarged past that threshold, e.g. virLXCProcessStart which reaches a frame size of 4624 bytes. Signed-off-by: Tim

[libvirt PATCH 0/6] Enable sanitizers

by setting `ASAN_OPTIONS` to verify_asan_link_order=0` for the gcc build. Cheers, Tim Tim Wiederhake (6): meson: Allow larger stack frames when instrumenting meson: Allow undefined symbols when sanitizers are enabled tests: virfilemock: realpath: Allow non-null second parameter tests

[libvirt PATCH 2/6] meson: Allow undefined symbols when sanitizers are enabled

building with sanitizers enabled. Signed-off-by: Tim Wiederhake --- meson.build | 5 + 1 file changed, 5 insertions(+) diff --git a/meson.build b/meson.build index bbdbe4afd8..56c1294e7f 100644 --- a/meson.build +++ b/meson.build @@ -497,6 +497,11 @@ libvirt_no_indirect

[libvirt PATCH 6/6] ci: Enable address and undefined behavior sanitizers

implementations of these sanitizers and have proven to find different issues. Create CI jobs for both. Signed-off-by: Tim Wiederhake --- .gitlab-ci.yml | 35 +++ 1 file changed, 35 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 8b7df68f47..aa537e65

[libvirt PATCH 3/6] tests: virfilemock: realpath: Allow non-null second parameter

When other preloaded libraries wrap and / or make calls to `realpath` (e.g. LLVM's AddessSanitizer), the second parameter is no longer guaranteed to be NULL. Signed-off-by: Tim Wiederhake --- build-aux/syntax-check.mk | 2 +- tests/virfilemock.c | 12 ++-- 2 files changed, 7

Re: [libvirt PATCH 06/11] udevGetIntSysfsAttr: Return -1 for missing attributes

On Thu, 2021-01-28 at 11:44 +0100, Peter Krempa wrote: > On Thu, Jan 28, 2021 at 11:24:36 +0100, Tim Wiederhake wrote: > > If "udevGetDeviceSysfsAttr()" returns NULL, "udevGetIntSysfsAttr" > > would return "0", indicating success, without writing to &qu

[libvirt PATCH 08/19] commandhelper: Factor out printArguments

Signed-off-by: Tim Wiederhake --- tests/commandhelper.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/tests/commandhelper.c b/tests/commandhelper.c index c44322502f..aa346f1dfd 100644 --- a/tests/commandhelper.c +++ b/tests/commandhelper.c @@ -80,6 +80,15

[libvirt PATCH 16/19] commandhelper: Convert parseArguments to g_auto*

Signed-off-by: Tim Wiederhake --- tests/commandhelper.c | 38 +- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/tests/commandhelper.c b/tests/commandhelper.c index 6d5fe04042..e616f92987 100644 --- a/tests/commandhelper.c +++ b/tests

[libvirt PATCH 15/19] commandhelper: Make number of fds variable in parseArguments

Fixes a buffer overflow triggered when more than three "--readfd" arguments were given on the command line. Signed-off-by: Tim Wiederhake --- tests/commandhelper.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/tests/commandhelper

[libvirt PATCH 17/19] commandhelper: Convert printEnvironment to g_auto*

Signed-off-by: Tim Wiederhake --- tests/commandhelper.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/tests/commandhelper.c b/tests/commandhelper.c index e616f92987..26a7de5149 100644 --- a/tests/commandhelper.c +++ b/tests/commandhelper.c @@ -108,16 +108,15

[libvirt PATCH 18/19] commandhelper: Convert printCwd to g_auto*

Signed-off-by: Tim Wiederhake --- tests/commandhelper.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/commandhelper.c b/tests/commandhelper.c index 26a7de5149..3bd7d2b28d 100644 --- a/tests/commandhelper.c +++ b/tests/commandhelper.c @@ -172,7 +172,7 @@ static void

[libvirt PATCH 12/19] commandhelper: Factor out printCwd

Signed-off-by: Tim Wiederhake --- tests/commandhelper.c | 42 ++ 1 file changed, 26 insertions(+), 16 deletions(-) diff --git a/tests/commandhelper.c b/tests/commandhelper.c index 01dd6f9e45..929de7a05d 100644 --- a/tests/commandhelper.c +++ b/tests

[libvirt PATCH 13/19] commandhelper: Factor out printInput

Signed-off-by: Tim Wiederhake --- tests/commandhelper.c | 65 ++- 1 file changed, 39 insertions(+), 26 deletions(-) diff --git a/tests/commandhelper.c b/tests/commandhelper.c index 929de7a05d..d501e33e88 100644 --- a/tests/commandhelper.c +++ b/tests

[libvirt PATCH 14/19] commandhelper: Make number of fds variable in printInput

Fixes a buffer overflow triggered when more than three "--readfd" arguments were given on the command line. Signed-off-by: Tim Wiederhake --- tests/commandhelper.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/tests/commandhelper

[libvirt PATCH 04/19] commandhelper: Consolidate error paths

Preparation for later conversion to g_auto* memory handling. Signed-off-by: Tim Wiederhake --- tests/commandhelper.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/commandhelper.c b/tests/commandhelper.c index 05e3879688..2be121ce2c 100644 --- a/tests

[libvirt PATCH 06/19] commandhelper: Split argument parsing and printing

Signed-off-by: Tim Wiederhake --- tests/commandhelper.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/commandhelper.c b/tests/commandhelper.c index a964420d81..a77bee931f 100644 --- a/tests/commandhelper.c +++ b/tests/commandhelper.c @@ -65,8 +65,6 @@ int main

[libvirt PATCH 09/19] commandhelper: Factor out printEnvironment

Signed-off-by: Tim Wiederhake --- tests/commandhelper.c | 57 +++ 1 file changed, 36 insertions(+), 21 deletions(-) diff --git a/tests/commandhelper.c b/tests/commandhelper.c index aa346f1dfd..14c7302633 100644 --- a/tests/commandhelper.c +++ b/tests

[libvirt PATCH 02/19] commandhelper: Remove numpollfds variable

Signed-off-by: Tim Wiederhake --- tests/commandhelper.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/tests/commandhelper.c b/tests/commandhelper.c index c2040b76f0..2b937979c0 100644 --- a/tests/commandhelper.c +++ b/tests/commandhelper.c @@ -67,7 +67,6

[libvirt PATCH 10/19] commandhelper: Factor out printFds

Signed-off-by: Tim Wiederhake --- tests/commandhelper.c | 37 - 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/tests/commandhelper.c b/tests/commandhelper.c index 14c7302633..fa32f6a435 100644 --- a/tests/commandhelper.c +++ b/tests

[libvirt PATCH 11/19] commandhelper: Factor out printDaemonization

Signed-off-by: Tim Wiederhake --- tests/commandhelper.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/tests/commandhelper.c b/tests/commandhelper.c index fa32f6a435..01dd6f9e45 100644 --- a/tests/commandhelper.c +++ b/tests/commandhelper.c

[libvirt PATCH 19/19] commandhelper: Convert main to g_auto*

Signed-off-by: Tim Wiederhake --- tests/commandhelper.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/tests/commandhelper.c b/tests/commandhelper.c index 3bd7d2b28d..940a979a3f 100644 --- a/tests/commandhelper.c +++ b/tests/commandhelper.c

[libvirt PATCH 00/19] Overhaul test/commandhelper.c

s. Please feel free to comment on whether the copyright year in the file's header should be updated and whether a prefix for the function names and the new type is required. Cheers, Tim Tim Wiederhake (19): commandhelper: Remove origenv variable commandhelper: Remove numpollfds variable com

[libvirt PATCH 01/19] commandhelper: Remove origenv variable

Signed-off-by: Tim Wiederhake --- tests/commandhelper.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/tests/commandhelper.c b/tests/commandhelper.c index ba5681b715..c2040b76f0 100644 --- a/tests/commandhelper.c +++ b/tests/commandhelper.c @@ -60,7 +60,6

[libvirt PATCH 07/19] commandhelper: Factor out parseArguments

Signed-off-by: Tim Wiederhake --- tests/commandhelper.c | 83 +-- 1 file changed, 57 insertions(+), 26 deletions(-) diff --git a/tests/commandhelper.c b/tests/commandhelper.c index a77bee931f..c44322502f 100644 --- a/tests/commandhelper.c +++ b/tests

[libvirt PATCH 03/19] commandhelper: Simplify envsort

Comparing only the keys produces the same result as comparing keys and value. The latter saves two invocations of each `strndup` and `free`. Signed-off-by: Tim Wiederhake --- tests/commandhelper.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/tests

[libvirt PATCH 05/19] commandhelper: Consolidate argument parsing

Signed-off-by: Tim Wiederhake --- tests/commandhelper.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/commandhelper.c b/tests/commandhelper.c index 2be121ce2c..a964420d81 100644 --- a/tests/commandhelper.c +++ b/tests/commandhelper.c @@ -56,6 +56,7 @@ int main(int

Re: [libvirt PATCH 10/11] vircommand: Remove NULL check in virCommandAddArg

On Thu, 2021-01-28 at 11:54 +0100, Peter Krempa wrote: > On Thu, Jan 28, 2021 at 11:24:40 +0100, Tim Wiederhake wrote: > > `val` is declared `ATTRIBUTE_NONNULL`. > > Please see: > > https://gitlab.com/libvirt/libvirt/-/blob/master/src/internal.h#L127 > > ATTRIBUTE_NO

Re: [libvirt PATCH 00/11] Random bits found by clang-tidy

On Thu, 2021-01-28 at 10:35 +, Daniel P. Berrangé wrote: > On Thu, Jan 28, 2021 at 11:24:30AM +0100, Tim Wiederhake wrote: > > clang-tidy is a static code analysis tool under the llvm umbrella. > > It is > > primarily meant to be used on C++ code bases, but s

Re: [libvirt PATCH 0/5] Formalize the deprecation of arguments in virsh

On Tue, 2021-03-23 at 16:55 +, Daniel P. Berrangé wrote: > On Tue, Mar 23, 2021 at 05:23:38PM +0100, Tim Wiederhake wrote: > > On Tue, 2021-03-23 at 15:28 +0100, Peter Krempa wrote: > > > On Tue, Mar 23, 2021 at 15:19:44 +0100, Michal Privoznik wrote: > > > > On

Re: [PATCH 1/1] set vm physical bits(phys_bits)

On Wed, 2021-03-24 at 11:01 +, Wang,Liang(ACG CCN) wrote: > > Set the vm phys_bits through the phys and hostphysbits in XML > corresponds to "-cpu-phys-bits=42" > corresponds to "host-phys-bits=on" > > > > > Please don't forget to change the RNG schema accordingly, see

[libvirt PATCH v3 0/3] qemuProcessUpdateGuestCPU: Check host cpu for forbidden features

V1: https://listman.redhat.com/archives/libvir-list/2021-February/msg01275.ht= ml V2: https://listman.redhat.com/archives/libvir-list/2021-February/msg01289.ht= ml Changes since V2: * Factored out into seperate function in src/cpu/cpu.c * Made virCPUDefFindFeature work on const pointers Tim

[libvirt PATCH v3 1/3] virCPUDefFindFeature: Make first argument const ptr

Signed-off-by: Tim Wiederhake --- src/conf/cpu_conf.c | 2 +- src/conf/cpu_conf.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index 380a74691d..43629068c3 100644 --- a/src/conf/cpu_conf.c +++ b/src/conf/cpu_conf.c @@ -933,7

[libvirt PATCH v3 2/3] cpu: Introduce virCPUCheckForbiddenFeatures

Signed-off-by: Tim Wiederhake --- src/cpu/cpu.c| 37 + src/cpu/cpu.h| 6 ++ src/libvirt_private.syms | 1 + 3 files changed, 44 insertions(+) diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c index dfedf5bbf0..3fd7035f7a 100644

[libvirt PATCH v3 3/3] qemuProcessUpdateGuestCPU: Check host cpu for forbidden features

See https://bugzilla.redhat.com/show_bug.cgi?id=1840770 Signed-off-by: Tim Wiederhake --- src/qemu/qemu_process.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index fedd1f56b1..b74afedd07 100644 --- a/src/qemu/qemu_process.c

Re: [libvirt PATCH 0/5] Formalize the deprecation of arguments in virsh

On Tue, 2021-03-23 at 15:28 +0100, Peter Krempa wrote: > On Tue, Mar 23, 2021 at 15:19:44 +0100, Michal Privoznik wrote: > > On 3/23/21 3:04 PM, Peter Krempa wrote: > > > On Tue, Mar 23, 2021 at 14:50:09 +0100, Michal Privoznik wrote: > > > > On 3/23/21 2:42 PM, Daniel P. Berrangé wrote: > > > > >

Re: [PATCH 1/1] set vm physical bits(phys_bits)

On Thu, 2021-03-25 at 14:45 +0800, Paul Schlacter wrote: > > Set the vm phys_bits through the phys and hostphysbits in XML > > corresponds to "-cpu-phys-bits=42" Is the 43 -> 42 change a typo? I do not see the "-1" in the code below. > > corresponds to "host-phys-bits=on" > > > > > > > >

Re: [libvirt PATCH 00/38] Refactor XML parsing boilerplate code

On Thu, 2021-03-18 at 16:03 +0100, Michal Privoznik wrote: > On 3/18/21 9:00 AM, Tim Wiederhake wrote: > > (...) > > 10 files changed, 314 insertions(+), 663 deletions(-) > > > > Reviewed-by: Michal Privoznik > > Nice cleanup! > > And if you agree with

[libvirt PATCH v2 19/51] domain_conf: Use virXMLPropTristateXXX in virDomainDeviceInfoParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c8411bdf40..91dc00edad 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6620,8

[libvirt PATCH v3 48/51] network_conf: Use virXMLPropTristateXXX in virNetworkForwardNatDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/network_conf.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 4cf4aa4840..bbd18ba163 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c

[libvirt PATCH v3 50/51] storage_adapter_conf: Use virXMLPropTristateXXX in virStorageAdapterParseXMLFCHost

Signed-off-by: Tim Wiederhake --- src/conf/storage_adapter_conf.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/conf/storage_adapter_conf.c b/src/conf/storage_adapter_conf.c index 69062b4b58..a19920c8b2 100644 --- a/src/conf/storage_adapter_conf.c

[libvirt PATCH v3 51/51] storage_conf: Use virXMLPropTristateXXX in virStoragePoolDefParseSource

Signed-off-by: Tim Wiederhake --- src/conf/storage_conf.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 6116b04d44..286cdf105d 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c

[libvirt PATCH v3 18/51] domain_conf: Use virXMLPropTristateXXX in virDomainVirtioOptionsParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 34 ++ 1 file changed, 6 insertions(+), 28 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7dfbca12e5..6997b7d743 100644 --- a/src/conf/domain_conf.c +++ b/src/conf

[libvirt PATCH v3 36/51] domain_conf: Use virXMLPropTristateXXX in virDomainMemballoonDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0b5d8e5164..6b98d34eb4 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

[libvirt PATCH v3 34/51] domain_conf: Use virXMLPropTristateXXX in virDomainAudioOSSParse

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index afd37e3e49..c341091c99 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -13837,18 +13837,12

[libvirt PATCH v3 29/51] domain_conf: Use virXMLPropTristateXXX in virDomainGraphicsDefParseXMLVNC

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 842a134220..35320fe1e5 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -13043,7

[libvirt PATCH v3 21/51] domain_conf: Use virXMLPropTristateXXX in virDomainDiskSourceNVMeParse

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 4fd4fabb3f..f2fb3c8dd5 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8397,7

[libvirt PATCH v3 30/51] domain_conf: Use virXMLPropTristateXXX in virDomainGraphicsDefParseXMLSDL

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 35320fe1e5..4684496522 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

[libvirt PATCH v3 41/51] domain_conf: Use virXMLPropTristateXXX in virDomainVsockDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c7d2e86dfe..3289c9fa12 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -15841,17

[libvirt PATCH v3 39/51] domain_conf: Use virXMLPropTristateXXX in virDomainMemoryDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 4debb895e9..0b009bb237 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -15705,16

[libvirt PATCH v3 16/51] virxml: Add virXMLPropTristateSwitch

Convenience function to return value of an on / off attribute. Signed-off-by: Tim Wiederhake --- src/libvirt_private.syms | 1 + src/util/virxml.c| 41 src/util/virxml.h| 6 +- 3 files changed, 47 insertions(+), 1 deletion(-) diff

[libvirt PATCH v3 25/51] domain_conf: Use virXMLPropTristateXXX in virDomainNetDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 180 +++-- 1 file changed, 49 insertions(+), 131 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7e17ded2a1..97eb1b6f8a 100644 --- a/src/conf/domain_conf.c +++ b/src

[libvirt PATCH v3 38/51] domain_conf: Use virXMLPropTristateXXX in virDomainPerfEventDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ef1a9cdab2..4debb895e9 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -15442,7

[libvirt PATCH v3 37/51] domain_conf: Use virXMLPropTristateXXX in virDomainShmemDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 6b98d34eb4..ef1a9cdab2 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -14358,17

[libvirt PATCH v3 28/51] domain_conf: Use virXMLPropTristateXXX in virDomainChrSourceDefParseLog

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0f3be88235..842a134220 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11812,20

[libvirt PATCH v3 40/51] domain_conf: Use virXMLPropTristateXXX in virDomainIOMMUDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 41 + 1 file changed, 9 insertions(+), 32 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0b009bb237..c7d2e86dfe 100644 --- a/src/conf/domain_conf.c +++ b/src/conf

[libvirt PATCH v3 15/51] virxml: Add virXMLPropTristateBool

Convenience function to return value of a yes / no attribute. Signed-off-by: Tim Wiederhake --- src/libvirt_private.syms | 1 + src/util/virxml.c| 41 src/util/virxml.h| 5 + 3 files changed, 47 insertions(+) diff --git a/src

[libvirt PATCH v3 01/51] conf: Use virTristateXXX in virStorageSource

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 12 src/conf/storage_source_conf.h | 2 +- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7671050134..3d24479f28 100644 --- a/src/conf

[libvirt PATCH v3 13/51] conf: Use virTristateXXX in virStoragePoolSourceDevice

Signed-off-by: Tim Wiederhake --- src/conf/storage_conf.c | 7 --- src/conf/storage_conf.h | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 2e07c81f8a..6116b04d44 100644 --- a/src/conf/storage_conf.c +++ b/src/conf

[libvirt PATCH v3 08/51] conf: Use virTristateXXX in virDomainGraphicsDef

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 6619b9f006..09b697432d 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -1862,7 +1862,7 @@ struct

[libvirt PATCH v3 03/51] conf: Use virTristateXXX in virDomainDeviceInfo

Signed-off-by: Tim Wiederhake --- src/conf/device_conf.h | 4 ++-- src/conf/domain_conf.c | 26 -- src/qemu/qemu_command.c | 3 ++- src/qemu/qemu_hotplug.c | 2 +- 4 files changed, 21 insertions(+), 14 deletions(-) diff --git a/src/conf/device_conf.h b/src/conf

[libvirt PATCH v3 12/51] conf: Use virTristateXXX in virStorageAdapterFCHost

Signed-off-by: Tim Wiederhake --- src/conf/storage_adapter_conf.c | 4 +++- src/conf/storage_adapter_conf.h | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/conf/storage_adapter_conf.c b/src/conf/storage_adapter_conf.c index 77ecb8d5f2..69062b4b58 100644 --- a/src/conf

[libvirt PATCH v3 17/51] domain_conf: Use virXMLPropTristateXXX in virDomainKeyWrapCipherDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9e106b8846..7dfbca12e5 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -1447,10

[libvirt PATCH v3 14/51] conf: Use virTristateXXX in virPCIDeviceAddress

Signed-off-by: Tim Wiederhake --- src/conf/device_conf.c | 16 +--- src/util/virpci.h | 2 +- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 714ac50762..0dd60985e9 100644 --- a/src/conf/device_conf.c +++ b

[libvirt PATCH v3 04/51] conf: Use virTristateXXX in virDomainDiskDef

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 39 --- src/conf/domain_conf.h | 6 +++--- 2 files changed, 27 insertions(+), 18 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 43789fa2c7..014f318dcd 100644

[libvirt PATCH v3 11/51] conf: Use virTristateXXX in virDomainDef

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index d6ca5e9725..25af058241 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2755,7 +2755,7 @@ struct

[libvirt PATCH v3 06/51] conf: Use virTristateXXX in virDomainNetDef

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 17 + src/conf/domain_conf.h | 2 +- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 8e94860b51..9f59756119 100644 --- a/src/conf/domain_conf.c +++ b

[libvirt PATCH v3 02/51] conf: Use virTristateXXX in virStorageSourceNVMeDef

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 4 +++- src/conf/storage_source_conf.h | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 3d24479f28..27eb98d93c 100644 --- a/src/conf/domain_conf.c +++ b

[libvirt PATCH v3 00/51] Refactor XML parsing boilerplate code

its entirety, again. Sorry for the spam! Cheers, Tim Tim Wiederhake (51): conf: Use virTristateXXX in virStorageSource conf: Use virTristateXXX in virStorageSourceNVMeDef conf: Use virTristateXXX in virDomainDeviceInfo conf: Use virTristateXXX in virDomainDiskDef conf: Use vi

[libvirt PATCH v3 07/51] conf: Use virTristateXXX in virDomainChrSourceDef

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 34 +- src/conf/domain_conf.h | 6 +++--- 2 files changed, 24 insertions(+), 16 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9f59756119..e99699028a 100644 --- a/src

Re: [libvirt PATCH v2 09/51] conf: Use virTristateXXX in virDomainMemballoonDef

On Fri, 2021-03-19 at 15:00 +0100, Peter Krempa wrote: > On Fri, Mar 19, 2021 at 14:40:23 +0100, Tim Wiederhake wrote: > > Signed-off-by: Tim Wiederhake > > --- > > src/conf/domain_conf.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > >

[libvirt PATCH v3 09/51] conf: Use virTristateXXX in virDomainMemballoonDef

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 26 -- src/conf/domain_conf.h | 4 ++-- 2 files changed, 18 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e99699028a..0480fc610d 100644 --- a/src/conf

[libvirt PATCH v3 26/51] domain_conf: Use virXMLPropTristateXXX in virDomainChrSourceDefParseTCP

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 97eb1b6f8a..7fb096e6d9 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11703,17

[libvirt PATCH v3 31/51] domain_conf: Use virXMLPropTristateXXX in virDomainGraphicsDefParseXMLSpice

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 75 ++ 1 file changed, 10 insertions(+), 65 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 4684496522..d78d09a4b9 100644 --- a/src/conf/domain_conf.c +++ b/src

[libvirt PATCH v3 05/51] conf: Use virTristateXXX in virDomainActualNetDef

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 17 + src/conf/domain_conf.h | 2 +- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 014f318dcd..8e94860b51 100644 --- a/src/conf/domain_conf.c +++ b

[libvirt PATCH v3 27/51] domain_conf: Use virXMLPropTristateXXX in virDomainChrSourceDefParseFile

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7fb096e6d9..0f3be88235 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11777,20

[libvirt PATCH v3 22/51] domain_conf: Use virXMLPropTristateXXX in virDomainDiskDefDriverParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 36 ++-- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f2fb3c8dd5..f17c979e31 100644 --- a/src/conf/domain_conf.c +++ b/src/conf

[libvirt PATCH v3 23/51] domain_conf: Use virXMLPropTristateXXX in virDomainActualNetDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f17c979e31..6a43fb2588 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -10435,7

[libvirt PATCH v3 19/51] domain_conf: Use virXMLPropTristateXXX in virDomainDeviceInfoParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 6997b7d743..920078a706 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

[libvirt PATCH v3 20/51] domain_conf: Use virXMLPropTristateXXX in virDomainDiskSourceNetworkParse

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 920078a706..4fd4fabb3f 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8274,7

[libvirt PATCH v3 24/51] domain_conf: Use virXMLPropTristateXXX in virDomainChrSourceReconnectDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 6a43fb2588..7e17ded2a1 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -10618,7

[libvirt PATCH v3 32/51] domain_conf: Use virXMLPropTristateXXX in virDomainAudioCommonParse

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d78d09a4b9..dff554874f 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -13716,8

[libvirt PATCH v3 33/51] domain_conf: Use virXMLPropTristateXXX in virDomainAudioJackParse

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index dff554874f..afd37e3e49 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -13822,19

[libvirt PATCH v3 35/51] domain_conf: Use virXMLPropTristateXXX in virDomainAudioDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c341091c99..0b5d8e5164 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

[libvirt PATCH v2 00/51] Refactor XML parsing boilerplate code

bsolete * Changed some member variable types to virTristate(Bool|Switch), that cleaned up the actual conversions significantly * Applied the feedback regarding the new functions in virxml Tim Wiederhake (51): conf: Use virTristateXXX in virStorageSource conf: Use virTristateXXX in virStora

[libvirt PATCH v2 02/51] conf: Use virTristateXXX in virStorageSourceNVMeDef

Signed-off-by: Tim Wiederhake --- src/conf/storage_source_conf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/storage_source_conf.h b/src/conf/storage_source_conf.h index e6702a1ffc..1783dc195e 100644 --- a/src/conf/storage_source_conf.h +++ b/src/conf

[libvirt PATCH v2 03/51] conf: Use virTristateXXX in virDomainDeviceInfo

Signed-off-by: Tim Wiederhake --- src/conf/device_conf.h | 4 ++-- src/qemu/qemu_command.c | 3 ++- src/qemu/qemu_hotplug.c | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/conf/device_conf.h b/src/conf/device_conf.h index a51bdf10ee..289af1153a 100644 --- a/src/conf

[libvirt PATCH v2 01/51] conf: Use virTristateXXX in virStorageSource

Signed-off-by: Tim Wiederhake --- src/conf/storage_source_conf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/storage_source_conf.h b/src/conf/storage_source_conf.h index f42bb1c67d..e6702a1ffc 100644 --- a/src/conf/storage_source_conf.h +++ b/src/conf

[libvirt PATCH v2 09/51] conf: Use virTristateXXX in virDomainMemballoonDef

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 09b697432d..2d342effb1 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -1921,8 +1921,8

<    1   2   3   4   5   6   7   8   9   10   >