[libvirt PATCH v3 0/5] QEMU: support QEMU built without TCG

2020-04-20 Thread Tobin Feldman-Fitzthum
ave a QMP interface for determining whether QEMU is available. Since QEMU_CAPS_TCG_DISABLED is set only when TCG is disabled, we do not have to do any extra work to infer an appropriate value in either of these cases. QEMU_CAPS_TCG_DISABLED is set via QMP command qom-list-types. Tobin Feld

[libvirt PATCH v3 3/5] add virQEMUCapsProbeQMPTCGState function to set QEMU_CAPS_TCG_DISABLED

2020-04-20 Thread Tobin Feldman-Fitzthum
virQEMUCapsProbeQMPTCGState will set QEMU_CAPS_TCG_DISABLED if QEMU version is at least 2.10, KVM is enabled, and qom-list-types does not include tcg-accel. Signed-off-by: Tobin Feldman-Fitzthum --- src/qemu/qemu_capabilities.c | 32 1 file changed, 32

[libvirt PATCH v3 1/5] add QEMU_CAPS_TCG_DISABLED and probe conditionally

2020-04-20 Thread Tobin Feldman-Fitzthum
Only probe QEMU binary with accel=tcg if TCG is not disabled. Similarly, only add a VIR_DOMAIN_VIRT_QEMU guest if TCG is available. Signed-off-by: Tobin Feldman-Fitzthum --- src/qemu/qemu_capabilities.c | 22 ++ src/qemu/qemu_capabilities.h | 1 + 2 files changed, 15

[libvirt PATCH v3 4/5] use new functions when probing

2020-04-20 Thread Tobin Feldman-Fitzthum
Probe for TCG with QMP right after probing for KVM. Signed-off-by: Tobin Feldman-Fitzthum --- src/qemu/qemu_capabilities.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 9abc6e80e7..fa3084484d

[libvirt PATCH v3 2/5] add virQEMUCapsGetVirtType convenience function

2020-04-20 Thread Tobin Feldman-Fitzthum
Signed-off-by: Tobin Feldman-Fitzthum --- src/qemu/qemu_capabilities.c | 14 ++ src/qemu/qemu_capabilities.h | 2 ++ 2 files changed, 16 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index c56b2d8f0e..8a17287076 100644 --- a/src/qemu

[libvirt PATCH 4/5] use new functions when probing

2020-03-27 Thread Tobin Feldman-Fitzthum
Probe for TCG with QMP right after probing for KVM. Signed-off-by: Tobin Feldman-Fitzthum --- src/qemu/qemu_capabilities.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index c84ad0e831..410b58bf47

[libvirt PATCH 1/5] add QEMU_CAPS_TCG_DISABLED and probe conditionally

2020-03-27 Thread Tobin Feldman-Fitzthum
Only probe QEMU binary with accel=tcg if TCG is not disabled. Similarly, only add a VIR_DOMAIN_VIRT_QEMU guest if TCG is available. Signed-off-by: Tobin Feldman-Fitzthum --- src/qemu/qemu_capabilities.c | 21 + src/qemu/qemu_capabilities.h | 1 + 2 files changed, 14

[libvirt PATCH 3/5] add virQEMUCapsProbeQMPTCGState function to set QEMU_CAPS_TCG_DISABLED

2020-03-27 Thread Tobin Feldman-Fitzthum
virQEMUCapsProbeQMPTCGState will set QEMU_CAPS_TCG_DISABLED if QEMU version is at least 2.10, KVM is enabled, and qom-list-types does not include tcg-accel. Signed-off-by: Tobin Feldman-Fitzthum --- src/qemu/qemu_capabilities.c | 32 1 file changed, 32

[libvirt PATCH 2/5] add virQEMUCapsGetVirtType convenience function

2020-03-27 Thread Tobin Feldman-Fitzthum
Signed-off-by: Tobin Feldman-Fitzthum --- src/qemu/qemu_capabilities.c | 14 ++ src/qemu/qemu_capabilities.h | 2 ++ 2 files changed, 16 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 0371ca9b03..9c946339a3 100644 --- a/src/qemu

[libvirt PATCH 0/5] QEMU: support QEMU built without TCG

2020-03-27 Thread Tobin Feldman-Fitzthum
her QEMU is available. Since QEMU_CAPS_TCG_DISABLED is set only when TCG is disabled, we do not have to do any extra work to infer an appropriate value in either of these cases. QEMU_CAPS_TCG_DISABLED is set via QMP command qom-list-types. Tobin Feldman-Fitzthum (5): add QEMU_CAPS_TCG_DISAB

[libvirt PATCH v2 3/5] add virQEMUCapsProbeQMPTCGState function to set QEMU_CAPS_TCG_DISABLED

2020-03-27 Thread Tobin Feldman-Fitzthum
Probe for TCG with QMP right after probing for KVM. Signed-off-by: Tobin Feldman-Fitzthum --- src/qemu/qemu_capabilities.c | 32 1 file changed, 32 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 0b44ee0745

[libvirt PATCH v2 2/5] add virQEMUCapsGetVirtType convenience function

2020-03-27 Thread Tobin Feldman-Fitzthum
Signed-off-by: Tobin Feldman-Fitzthum --- src/qemu/qemu_capabilities.c | 14 ++ src/qemu/qemu_capabilities.h | 2 ++ 2 files changed, 16 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 61123f0e63..0b44ee0745 100644 --- a/src/qemu

[libvirt PATCH v2 1/5] add QEMU_CAPS_TCG_DISABLED and probe conditionally

2020-03-27 Thread Tobin Feldman-Fitzthum
Only probe QEMU binary with accel=tcg if TCG is not disabled. Similarly, only add a VIR_DOMAIN_VIRT_QEMU guest if TCG is available. Signed-off-by: Tobin Feldman-Fitzthum --- src/qemu/qemu_capabilities.c | 22 ++ src/qemu/qemu_capabilities.h | 1 + 2 files changed, 15

[libvirt PATCH v2 4/5] use new functions when probing

2020-03-27 Thread Tobin Feldman-Fitzthum
Probe for TCG with QMP right after probing for KVM. Signed-off-by: Tobin Feldman-Fitzthum --- src/qemu/qemu_capabilities.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 528bf6e504..b3ba1cb079

[libvirt PATCH v2 0/5] QEMU: support QEMU built without TCG

2020-03-27 Thread Tobin Feldman-Fitzthum
QMP interface for determining whether QEMU is available. Since QEMU_CAPS_TCG_DISABLED is set only when TCG is disabled, we do not have to do any extra work to infer an appropriate value in either of these cases. QEMU_CAPS_TCG_DISABLED is set via QMP command qom-list-types. Tobin Feldman-Fitzthum

[libvirt PATCH v4 3/3] add virQEMUCapsProbeQMPTCGState function to set QEMU_CAPS_TCG_DISABLED

2020-04-22 Thread Tobin Feldman-Fitzthum
Add virQEMUCapsProbeQMPTCGState to set TCG_DISABLED cap if version is > 2.10, KVM is enabled, and tcg-accel is not present in qom-list-types result. Signed-off-by: Tobin Feldman-Fitzthum --- src/qemu/qemu_capabilities.c | 34 -- 1 file changed, 32 inserti

[libvirt PATCH v4 2/3] add virQEMUCapsGetVirtType convenience function

2020-04-22 Thread Tobin Feldman-Fitzthum
Signed-off-by: Tobin Feldman-Fitzthum --- src/qemu/qemu_capabilities.c | 25 - src/qemu/qemu_capabilities.h | 2 ++ 2 files changed, 18 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index c56b2d8f0e..e7179ea048

[libvirt PATCH v4 0/3] QEMU: support QEMU built without TCG

2020-04-22 Thread Tobin Feldman-Fitzthum
so that we can reuse the qom call. Rename, virQEMUCapsProbeQMPDevices to virQEMUProbeQMPTypes. All patches compile. Tobin Feldman-Fitzthum (3): add QEMU_CAPS_TCG_DISABLED and probe conditionally add virQEMUCapsGetVirtType convenience function add virQEMUCapsProbeQMPTCGState function to

[libvirt PATCH v4 1/3] add QEMU_CAPS_TCG_DISABLED and probe conditionally

2020-04-22 Thread Tobin Feldman-Fitzthum
Only probe QEMU binary with accel=tcg if TCG is not disabled. Similarly, only add a VIR_DOMAIN_VIRT_QEMU guest if TCG is available. Signed-off-by: Tobin Feldman-Fitzthum --- src/qemu/qemu_capabilities.c | 22 ++ src/qemu/qemu_capabilities.h | 1 + 2 files changed, 15

[PATCH] qemu: softfail for TCG capabilities probe

2020-03-23 Thread Tobin Feldman-Fitzthum
an error if the QEMU binary was built without TCG. This patch allows execution to continue when the second probe fails. Thus libvirt can be used with QEMU built without TCG. First patch. Feedback appreciated. If better solution, please advise. Signed-off-by: Tobin Feldman-Fitzthum --- src/qemu

Re: REST service for libvirt to simplify SEV(ES) launch measurement

2022-03-08 Thread Tobin Feldman-Fitzthum
On 3/3/22 12:40 PM, Daniel P. Berrangé wrote: > On Fri, Feb 25, 2022 at 04:11:27PM -0500, Tobin Feldman-Fitzthum wrote: >> Some comments on the example protocol stuff >> >> On 2/23/22 1:38 PM, Dov Murik wrote: >>> +cc Tobin, James >>> >>&g

Re: REST service for libvirt to simplify SEV(ES) launch measurement

2022-03-08 Thread Tobin Feldman-Fitzthum
On 3/3/22 12:20 PM, Daniel P. Berrangé wrote: > On Fri, Feb 25, 2022 at 03:10:35PM -0500, Tobin Feldman-Fitzthum wrote: >> >> >> On 2/24/22 7:26 AM, Daniel P. Berrangé wrote: >>> On Wed, Feb 23, 2022 at 03:33:22PM -0500, Tobin Feldman-Fitzthum wrote: >>>&g

Re: REST service for libvirt to simplify SEV(ES) launch measurement

2022-02-24 Thread Tobin Feldman-Fitzthum
On 2/23/22 1:38 PM, Dov Murik wrote: > +cc Tobin, James > > On 23/02/2022 19:28, Daniel P. Berrangé wrote: >> Extending management apps using libvirt to support measured launch of >> QEMU guests with SEV/SEV-ES is unreasonably complicated today, both for >> the guest owner and for the cloud

Re: REST service for libvirt to simplify SEV(ES) launch measurement

2022-02-25 Thread Tobin Feldman-Fitzthum
On 2/24/22 7:26 AM, Daniel P. Berrangé wrote: > On Wed, Feb 23, 2022 at 03:33:22PM -0500, Tobin Feldman-Fitzthum wrote: >> >> >> On 2/23/22 1:38 PM, Dov Murik wrote: >>> +cc Tobin, James >>> >>> On 23/02/2022 19:28, Daniel P. Berrangé wro

Re: REST service for libvirt to simplify SEV(ES) launch measurement

2022-02-25 Thread Tobin Feldman-Fitzthum
Some comments on the example protocol stuff On 2/23/22 1:38 PM, Dov Murik wrote: > +cc Tobin, James > > On 23/02/2022 19:28, Daniel P. Berrangé wrote: >> >> >> What could this look like from POV of an attestation server API, if >> we assume HTTPS REST service with a simple JSON payload .>> >> >>