Signed-off-by: Wang Huaqiang
---
docs/news.xml | 12
1 file changed, 12 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 4406aeb..deadb85 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -68,6 +68,18 @@
be viewed via the domain statistics
on the fact that we only support cache monitor now.
Wang Huaqiang (2):
qemu: Report cache occupancy (CMT) with domstats
docs: Updated news.xml for CMT
docs/news.xml | 12
src/libvirt-domain.c | 12
src/qemu/qemu_driver.c | 160
> -Original Message-
> From: Wang, Huaqiang
> Sent: Thursday, November 15, 2018 8:41 PM
> To: John Ferlan ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Ding, Jian-feng feng.d...@intel.com>; Zang, Rui
> Subject: RE: [PATCHv8 16/17] qemu: Report cache occupancy
8 9:49 AM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Subject: Re: [PATCHv10 0/4] Introduce x86 Cache Monitoring Technology
> (CMT)
>
>
>
> On 11/26/18 12:56 PM, Wang Huaqiang wrote:
> > These patches are the remaining part for the CMT enabling series, and
>
> -Original Message-
> From: John Ferlan [mailto:jfer...@redhat.com]
> Sent: Tuesday, November 27, 2018 10:59 AM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Subject: Re: [PATCHv10 0/4] Introduce x86 Cache Monitoring Technology
> (CMT)
>
>
>
> On 11
, the stepping number is not
irrelevant any more. The CPU refresh from Skylake-SP to Cascadelake-SP
is this kind of example.
These two patches firstly introduce the stepping number as another factor
to identify future Intel CPU, then introduce the Cascadelake-SP cpu model.
Wang Huaqiang (2):
cpu: Add x86
, the stepping number is not
irrelevant any more. The CPU refresh from Skylake-SP to Cascadelake-SP
is this kind of example.
This patch add the stepping number as another factor to identify future
Intel CPU.
Signed-off-by: Wang Huaqiang
---
src/cpu/cpu_x86.c | 60
Cascadelake Server CPU is introduced in QEMU
by commit c7a88b52f62b30c04158eeb07f73e3f72221b6a8,
add the CPU model in libvirt accordingly.
Signed-off-by: Wang Huaqiang
---
src/cpu_map/Makefile.inc.am| 1 +
src/cpu_map/index.xml | 1 +
src/cpu_map/x86_Cascadelake
ate a fix
tomorrow if you need.
Huaqiang
> -Original Message-
> From: Wang, Huaqiang
> Sent: Tuesday, November 27, 2018 11:21 AM
> To: 'John Ferlan' ; libvir-list@redhat.com
> Subject: RE: [PATCHv10 0/4] Introduce x86 Cache Monitoring Technology
> (CMT)
>
>
&g
在 11/24/2018 1:33 AM, John Ferlan 写道:
On 11/20/18 8:56 AM, Wang Huaqiang wrote:
Adding the interface in qemu to report CMT statistic information
through command 'virsh domstats --cpu-total'.
Below is a typical output:
# virsh domstats 1 --cpu-total
Domain: 'ubuntu16.04
the names for new data structure and new functions.
-. Merged qemuDomainGetStatsCpuResMonitorPerTag and
qemuDomainGetStatsCpuResMonitor,
and refined new function name based on the fact that we only support cache
monitor now.
Wang Huaqiang (4):
util: Return a list of pointer
The call of virResctrlMonitorGetStats will allocate the memory for
holding cache occupancy or memory bandwidth statistics.
This patch added an function, virResctrlMonitorFreeStats, as the
opposing action of virResctrlMonitorGetStats to free these memory.
Signed-off-by: Wang Huaqiang
---
src
Return a list of virResctrlMonitorStatsPtr instead of
a virResctrlMonitorStats array in virResctrlMonitorGetStats.
Signed-off-by: Wang Huaqiang
---
src/util/virresctrl.c | 10 +-
src/util/virresctrl.h | 4 ++--
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/util
Signed-off-by: Wang Huaqiang
---
docs/news.xml | 12
1 file changed, 12 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 4406aeb..deadb85 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -68,6 +68,18 @@
be viewed via the domain statistics
.bytes=29106176
Signed-off-by: Wang Huaqiang
---
src/libvirt-domain.c | 12
src/qemu/qemu_driver.c | 183 -
tools/virsh.pod| 14
3 files changed, 208 insertions(+), 1 deletion(-)
diff --git a/src/libvirt-domain.c b/src/libvirt
Wednesday, September 12, 2018 1:24 AM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Feng, Shaohe ; Niu, Bing ;
> Ding, Jian-feng ; Zang, Rui
> Subject: Re: [libvirt] [PATCH 02/10] util: add interface retrieving CMT
> capability
>
> [...]
>
> &
to
* Renamed to
- Document for 'reuseThreshold' changed.
- Introduced API virResctrlInfoGetMonitorPrefix
- Added more tests, covering standalone CMT, fake new
feature.
- Creating CMT resource control group will be
subsequent job.
Wang Huaqiang (4):
util: Introduce monitor capability
, such as the last
level cache occupancy and the utilization of memory bandwidth.
Signed-off-by: Wang Huaqiang
---
src/util/virresctrl.c | 124 ++
1 file changed, 124 insertions(+)
diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c
index 4b5442f
this:
...
...
Signed-off-by: Wang Huaqiang
---
docs/schemas/capability.rng| 37 ++-
src/conf/capabilities.c| 68
src/conf/capabilities.h| 4 +
src/libvirt_private.syms
Move all cache banks into one data structure, this allows
us to add other cache component, such as cache monitor.
Signed-off-by: Wang Huaqiang
---
src/conf/capabilities.c | 36 +---
src/conf/capabilities.h | 10 --
2 files changed, 25 insertions(+), 21
Move memory bandwidth capability nodes into one data structure,
this allows us to add a monitor for memory bandwidth.
Signed-off-by: Wang Huaqiang
---
src/conf/capabilities.c | 22 ++
src/conf/capabilities.h | 10 --
2 files changed, 18 insertions(+), 14 deletions
.
5. Extend data structure 'virResctrlMonitorStats' with the capability
to carry multiple statistical information from monitor.
Wang Huaqiang (11):
util,conf: Handle default monitor group of an allocation properly
conf: code cleanup, remove empty line and one space
conf: code cleanup
Remove some redundant space and line.
Signed-off-by: Wang Huaqiang
---
src/conf/domain_conf.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index a3a5141..e3c8aa0 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf
code cleanup for 'virDomainCachetuneDefParse' and
'virDomainMemorytuneDefParse'.
Signed-off-by: Wang Huaqiang
---
src/conf/domain_conf.c | 46 +-
1 file changed, 21 insertions(+), 25 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf
virDomainResctrlMonValidateVcpus to
virDomainResctrlValidateMonitor.
Signed-off-by: Wang Huaqiang
---
src/conf/domain_conf.c | 62 +++---
1 file changed, 38 insertions(+), 24 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 676a2ac..2af81c0
, then it is not necessary
to create monitor group since it is already created. But if
an monitor group is not an allocation default group, you
should create the group under folder
'/sys/fs/resctrl/mon_groups' and fill the vcpu PIDs to 'tasks'
file.
Signed-off-by: Wang Huaqiang
---
src/libvirt_private.syms | 1
Creating object and judging if it is successfully created in fewer
lines.
Signed-off-by: Wang Huaqiang
---
src/conf/domain_conf.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index db25c1f..e4a6dfb 100644
@resctrl object to @def->resctrls.
This kind of replacement is also more efficient and avoiding
a long function calling path.
Signed-off-by: Wang Huaqiang
---
src/conf/domain_conf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/c
Signed-off-by: Wang Huaqiang
---
src/libvirt_private.syms | 1 -
src/util/virresctrl.c| 27 ---
src/util/virresctrl.h| 5 -
3 files changed, 33 deletions(-)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 3a4f526..96de17e 100644
Refactor and rename 'virResctrlMonitorFreeStats' to
'virResctrlMonitorStatsFree' to free one
'virResctrlMonitorStatsPtr' object.
Signed-off-by: Wang Huaqiang
---
src/libvirt_private.syms | 2 +-
src/qemu/qemu_driver.c | 6 +-
src/util/virresctrl.c| 14 --
src/util
Let 'virDomainResctrlVcpuMatch' to retrieve a pointer of
virDomainResctrlDefPtr in its third parameter instead
of virResctrlAllocPtr, if @vcpus is matched with the vcpus
of some resctrl allocation in list of @def->resctrls.
Signed-off-by: Wang Huaqiang
---
src/conf/domain_conf.c |
Export virResctrlMonitorGetStats and make
virResctrlMonitorGetCacheOccupancy obsoleted.
Signed-off-by: Wang Huaqiang
---
src/libvirt_private.syms | 1 +
src/qemu/qemu_driver.c | 33 +
src/util/virresctrl.c| 44
Refactor 'virResctrlMonitorStats' to track multiple statistical
records.
Signed-off-by: Wang Huaqiang
---
src/qemu/qemu_driver.c | 2 +-
src/util/virresctrl.c | 11 ++-
src/util/virresctrl.h | 12 ++--
3 files changed, 21 insertions(+), 4 deletions(-)
diff --git a/src/qemu
code cleanup for 'virDomainCachetuneDefParse' and
'virDomainMemorytuneDefParse'.
Signed-off-by: Wang Huaqiang
---
src/conf/domain_conf.c | 46 +-
1 file changed, 21 insertions(+), 25 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf
Signed-off-by: Wang Huaqiang
---
src/libvirt_private.syms | 1 -
src/util/virresctrl.c| 29 -
src/util/virresctrl.h| 5 -
3 files changed, 35 deletions(-)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 2e3d48c..41733cc 100644
, this role could be replaced with
checking if @n is zero or not.
This replacement is more efficient and avoiding a long function
calling path.
Signed-off-by: Wang Huaqiang
---
src/conf/domain_conf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf
Let 'virDomainResctrlVcpuMatch' return a pointer of
@virDomainResctrlDefPtr in its third parameter.
Signed-off-by: Wang Huaqiang
---
src/conf/domain_conf.c | 33 ++---
1 file changed, 18 insertions(+), 15 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf
Export virResctrlMonitorGetStats and make
virResctrlMonitorGetCacheOccupancy obsoleted.
Signed-off-by: Wang Huaqiang
---
src/libvirt_private.syms | 1 +
src/qemu/qemu_driver.c | 33 +
src/util/virresctrl.c| 46
Remove some redundant space and line.
Signed-off-by: Wang Huaqiang
---
src/conf/domain_conf.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index a3a5141..e3c8aa0 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf
functionality, but with capability to be used for retrieving MBM
statistical information.
4. Refactoring 'virResctrlMonitorFreeStats' for more reusing in code.
5. Extend data structure 'virResctrlMonitorStats' with the capability
to carry multiple statistical information from monitor.
Wang Huaqiang
Refactor 'virResctrlMonitorFreeStats' to let it available to free
the 'virResctrlMonitorStatsPtr' variable.
Signed-off-by: Wang Huaqiang
---
src/qemu/qemu_driver.c | 1 +
src/util/virresctrl.c | 4 +---
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src
In checking if vcpus matches with any exisitng resctrl allocation it
should consider if the allocation exists or not.
'@resctrl->alloc != NULL' means an allocation exists.
Signed-off-by: Wang Huaqiang
---
src/conf/domain_conf.c | 9 -
1 file changed, 4 insertions(+), 5 deleti
Refactor 'virResctrlMonitorStats' to track multiple statistical
records.
Signed-off-by: Wang Huaqiang
---
src/qemu/qemu_driver.c | 2 +-
src/util/virresctrl.c | 17 ++---
src/util/virresctrl.h | 12 ++--
3 files changed, 25 insertions(+), 6 deletions(-)
diff --git a/src
From: Huaqiang
The qsort element is a pointer of virResctrlMonitorStats, and
the comparing function's arguments have a type of pointer of
virResctrlMonitorStatsPtr.
Signed-off-by: Huaqiang
---
src/util/virresctrl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
My bad.
Thanks.
> -Original Message-
> From: Peter Krempa [mailto:pkre...@redhat.com]
> Sent: Monday, April 29, 2019 3:00 PM
> To: Wang, Huaqiang
> Cc: libvir-list@redhat.com
> Subject: Re: [libvirt] [PATCH] CONF: bug, release 'alloc' object in cleanup
>
&
In case error happens before 'alloc' is transferred to 'resctrl',
the 'alloc' object should be released.
Signed-off-by: Wang Huaqiang
---
src/conf/domain_conf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 6331424..7d20276 100644
patches as a whole , I can send them out
shortly.
Br
Huaqiang
> -Original Message-
> From: Wang, Huaqiang
> Sent: Tuesday, June 11, 2019 11:31 AM
> To: libvir-list@redhat.com
> Cc: Wang, Huaqiang ; Su, Tao
>
> Subject: [PATCHv2 00/11] util/resctrl cleanups and r
Hi Michal,
Thanks for review, have a good day!
Br
Huaqiang
> -Original Message-
> From: Michal Privoznik [mailto:mpriv...@redhat.com]
> Sent: Wednesday, July 31, 2019 8:38 PM
> To: Wang, Huaqiang ; libvir-list@redhat.com
> Cc: Su, Tao
> Subject: Re: [libvirt] [P
eed when sharing happens.
Signed-off-by: Wang Huaqiang
---
src/conf/domain_conf.c| 12 +---
tests/genericxml2xmlindata/memorytune.xml | 4
2 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 617c
Hi Cole,
Good catch, I'll fix and make test soon.
Thanks
> -Original Message-
> From: Cole Robinson [mailto:crobi...@redhat.com]
> Sent: Tuesday, August 20, 2019 6:30 AM
> To: Michal Privoznik ; Wang, Huaqiang
> ; libvir-list@redhat.com
> Cc: Su, Tao
> Subject: R
I'll fix it soon.
> -Original Message-
> From: Marc-André Lureau [mailto:marcandre.lur...@gmail.com]
> Sent: Tuesday, August 6, 2019 6:48 PM
> To: Wang, Huaqiang ; Michal Privoznik
>
> Cc: libvir-list@redhat.com; Su, Tao
> Subject: Re: [libvirt] [PATCHv2 09/11] u
Ping.
I am also prepared the MBM(memory bandwidth monitor) patches based on these
cleanups, I
wonder if it is proper to submit it along with these patches, if yes, I'd like
to send out the whole
patches in another thread.
Thanks
Huaqiang
> -Original Message-
> From: Wang, Hu
RDT is the short for Intel Resource Director Technology, consists
of four sub-technologies until now:
-. CAT for cache allocation
-. CMT for cache usage monitoring
-. MBA for memory bandwidth allocation
-. MBM for memory bandwidth usage monitoring
The Linux kernel interface is
From: Huaqiang
Introduce an option '--memory' for showing memory related
information. The memory bandwidth infomatio is listed as:
Domain: 'libvirt-vm'
memory.bandwidth.monitor.count=4
memory.bandwidth.monitor.0.name=vcpus_0-4
memory.bandwidth.monitor.0.vcpus=0-4
From: Huaqiang
Create memory bandwidth monitor.
Following domain configuration changes create two memory bandwidth
monitors: one is monitoring the bandwidth consumed by vCPU 0,
another is for vCPU 5.
```
+
From: Huaqiang
We learned that the hardware features of CAT, CMT, MBA and MBM
are orthogonal ones, if CAT or MBA is not supported in system,
but CMT or MBM are supported, then the cache monitor or
memoryBW monitor features may not be correctly displayed in
host capabilities through command
From: Huaqiang
Originally, inside , it requires the element to
be in the position before , and following configuration is not
permitted by schema, but it is better to let it be valid.
^
|__ Not permitted originally because it is in the place
From: Huaqiang
The underlying resctrl monitoring is actually using 64 bit counters,
not the 32bit one. Correct this by using 64bit interfaces.
Signed-off-by: Huaqiang
---
src/qemu/qemu_driver.c | 4 ++--
src/util/virfile.c | 40
src/util/virfile.h
and accumulatively, this value can easily exceed the 4GB
bound, so I
don’t want to reserve the old 32 bit interface and let user use it, because it
will report incorrect value.
> -Original Message-
> From: Daniel P. Berrangé
> Sent: Friday, December 13, 2019 11:01 PM
> To: Wang, Huaqiang
> -Original Message-
> From: Daniel P. Berrangé
> Sent: Friday, December 13, 2019 11:56 PM
> To: Wang, Huaqiang
> Cc: libvir-list@redhat.com
> Subject: Re: [libvirt] [PATCH 5/5] virsh: show memoryBW info in 'virsh
> domstats' command
>
> On Thu, Nov 14, 201
On 2019/12/16 下午6:12, Daniel P. Berrangé wrote:
On Sun, Dec 15, 2019 at 02:39:20AM +, Wang, Huaqiang wrote:
Hi Daniel,
Thanks for your review.
About patch 1/5, I understand we should be very cautious when we changes the
determined
interface.
I'd like to reserved the old 32bit
. Berrangé <mailto:berra...@redhat.com>>
Date: Wed May 22 14:07:57 2019 +0100
Add new hugetlb memory stats constants
Signed-off-by: Daniel P. Berrangé <mailto:berra...@redhat.com>>
On Wed, Nov 13, 2019 at 6:34 PM Wang Huaqiang <mailto:huaqiang.w...@intel.com>> wrote:
This patch introduced a bug and broke the 'resctrl' feature.
It introduced a 'divide by zero' error if you defined any 'resctrl'
allocation group through .
Reason is 'caps->resctrl' is fully initialized through two steps,
'virResctrlInfoNew'
invokes 'virResctrlGetInfo' completes the first
memory.bandwidth.monitor.1.node.1.id=1
memory.bandwidth.monitor.1.node.1.bytes.total=406044672
memory.bandwidth.monitor.1.node.1.bytes.local=229425152
Signed-off-by: Wang Huaqiang
---
docs/manpages/virsh.rst | 22 ++-
include/libvirt/libvirt-domain.h | 1 +
src/libvirt-domain.c | 21
result, and keeping the interface consistent.
* Add 'virsh domstats --memory' document in file 'virsh.rst'
Wang Huaqiang (2):
util, resctrl: using 64bit interface instead of 32bit for counters
Introduce command 'virsh domstats --memory' for reporting memory BW
docs/manpages/virsh.rst |
reported with a truncated 32bit data type. because, in silicon
world, CPU cache size will never exceed 4GB.
Signed-off-by: Wang Huaqiang
---
src/qemu/qemu_driver.c | 15 +--
src/util/virfile.c | 40
src/util/virfile.h | 2 ++
src/util
Hi Daniel,
Thanks for your hard work and review!
Br
Huaqiang
> -Original Message-
> From: Daniel P. Berrangé
> Sent: Monday, January 6, 2020 10:17 PM
> To: Wang, Huaqiang
> Cc: libvir-list@redhat.com
> Subject: Re: [PATCHv2 2/2] Introduce command 'virsh
Hi Daniel,
Thanks for review!
Br
Huaqiang
> -Original Message-
> From: Daniel P. Berrangé
> Sent: Monday, January 6, 2020 10:16 PM
> To: Wang, Huaqiang
> Cc: libvir-list@redhat.com
> Subject: Re: [PATCHv2 1/2] util, resctrl: using 64bit interface instead of
>
201 - 268 of 268 matches
Mail list logo
