Re: [libvirt] Downloading and wiping assumes volume is a device or file

2012-03-02 Thread Wido den Hollander
Hi, On 02/09/2012 09:27 PM, Eric Blake wrote: On 02/09/2012 01:04 PM, Wido den Hollander wrote: Hi, I'm still working on the RBD (RADOS / Ceph) storage driver for libvirt and I noticed the virStorageVolDownload and virStorageVolWipe methods. I assumed those would be passed on to the storage

[libvirt] [PATCH] Allow byte[] arrays to be set as a secretValue

2012-03-09 Thread Wido den Hollander
Signed-off-by: Wido den Hollander w...@widodh.nl --- src/main/java/org/libvirt/Secret.java | 11 +++ src/main/java/org/libvirt/jna/Libvirt.java |1 + 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/src/main/java/org/libvirt/Secret.java b/src/main/java/org

Re: [libvirt] [PATCH] Allow byte[] arrays to be set as a secretValue

2012-03-09 Thread Wido den Hollander
On 03/09/2012 03:58 PM, Eric Blake wrote: On 03/09/2012 07:23 AM, Wido den Hollander wrote: Signed-off-by: Wido den Hollanderw...@widodh.nl --- src/main/java/org/libvirt/Secret.java | 11 +++ src/main/java/org/libvirt/jna/Libvirt.java |1 + 2 files changed, 12 insertions

[libvirt] [PATCH libvirt-java] Allow byte[] arrays to be set as a secretValue

2012-03-09 Thread Wido den Hollander
Signed-off-by: Wido den Hollander w...@widodh.nl --- src/main/java/org/libvirt/Secret.java | 11 +++ src/main/java/org/libvirt/jna/Libvirt.java |1 + 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/src/main/java/org/libvirt/Secret.java b/src/main/java/org

[libvirt] [PATCH libvirt-java] Return a byte[] array with secretGetValue

2012-03-16 Thread Wido den Hollander
Signed-off-by: Wido den Hollander w...@widodh.nl --- src/main/java/org/libvirt/Secret.java | 11 +-- src/main/java/org/libvirt/jna/Libvirt.java |2 +- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/libvirt/Secret.java b/src/main/java/org

[libvirt] [PATCH] storage backend: Add RBD (RADOS Block Device) support

2012-03-30 Thread Wido den Hollander
000..056059a --- /dev/null +++ b/src/storage/storage_backend_rbd.c @@ -0,0 +1,465 @@ +/* + * storage_backend_rbd.c: storage backend for RBD (RADOS Block Device) handling + * + * Copyright (C) 2012 Wido den Hollander + * + * This library is free software; you can redistribute it and/or + * modify

Re: [libvirt] [PATCH] storage backend: Add RBD (RADOS Block Device) support

2012-04-11 Thread Wido den Hollander
Hi, On 03/30/2012 11:04 AM, Wido den Hollander wrote: This patch adds support for a new storage backend with RBD support. RBD is the RADOS Block Device and is part of the Ceph distributed storage system. It comes in two flavours: Qemu-RBD and Kernel RBD, this storage backend only supports

[libvirt] [PATCH] storage: Allow multiple hosts for a storage pool

2012-04-19 Thread Wido den Hollander
The current storage pools for NFS and iSCSI only require one host to connect to. Future storage pools like RBD and Sheepdog will require multiple hosts. This patch allows multiple source hosts and rewrites the current storage drivers. Signed-off-by: Wido den Hollander w...@widodh.nl --- src

[libvirt] [PATCH] storage: Allow multiple hosts for a storage pool

2012-04-25 Thread Wido den Hollander
The current storage pools for NFS and iSCSI only require one host to connect to. Future storage pools like RBD and Sheepdog will require multiple hosts. This patch allows multiple source hosts and rewrites the current storage drivers. Signed-off-by: Wido den Hollander w...@widodh.nl --- src

Re: [libvirt] [PATCH] storage backend: Add RBD (RADOS Block Device) support

2012-04-25 Thread Wido den Hollander
On 04/18/2012 12:36 PM, Daniel P. Berrange wrote: On Fri, Mar 30, 2012 at 11:04:43AM +0200, Wido den Hollander wrote: This patch adds support for a new storage backend with RBD support. RBD is the RADOS Block Device and is part of the Ceph distributed storage system. It comes in two flavours

[libvirt] [PATCH] qemu: Don't require a block or file when looking for an alias.

2013-04-05 Thread Wido den Hollander
From: root root@kvm01.(none) This for example prohibits you to use iotune for Ceph or Sheepdog devices. Signed-off-by: Wido den Hollander w...@widodh.nl --- src/qemu/qemu_driver.c |4 1 file changed, 4 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

Re: [libvirt] [PATCH] qemu: Don't require a block or file when looking for an alias.

2013-04-05 Thread Wido den Hollander
On 04/05/2013 05:36 PM, Wido den Hollander wrote: From: root root@kvm01.(none) My bad for this one, I noticed it to late. Wido This for example prohibits you to use iotune for Ceph or Sheepdog devices. Signed-off-by: Wido den Hollander w...@widodh.nl --- src/qemu/qemu_driver.c |4

[libvirt] [PATCH] qemu: Don't require a block or file when looking for an alias.

2013-04-05 Thread Wido den Hollander
This for example prohibits you to use iotune for Ceph or Sheepdog devices. Signed-off-by: Wido den Hollander w...@widodh.nl --- src/qemu/qemu_driver.c |4 1 file changed, 4 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 552a81b..464d30a 100644 --- a/src

Re: [libvirt] [PATCH] qemu: Don't require a block or file when looking for an alias.

2013-04-24 Thread Wido den Hollander
Did this one get lost or forgotten? Thanks, Wido On 04/05/2013 06:07 PM, Wido den Hollander wrote: This for example prohibits you to use iotune for Ceph or Sheepdog devices. Signed-off-by: Wido den Hollander w...@widodh.nl --- src/qemu/qemu_driver.c |4 1 file changed, 4

[libvirt] [PATCH] rbd: Do not free the secret if it is not set

2013-07-16 Thread Wido den Hollander
Not all RBD (Ceph) storage pools have cephx authentication turned on, so secret might not be initialized. It could also be that the secret couldn't be located. Only call virSecretFree() if secret is initialized earlier. Signed-off-by: Wido den Hollander w...@widodh.nl --- src/storage

[libvirt] Can I request a new release of libvirt-java?

2013-08-15 Thread Wido den Hollander
release (0.4.9) of libvirt-java doesn't. I don't know if there are any objections, but if possible I'd like to see 0.5.0 released so we get this new functionality for CloudStack. We use maven for building CloudStack and it fetches libvirt-java from libvirt.org/maven2 Thank you, Wido den

[libvirt] [PATCH] rbd: Use different formatter to display disk format

2013-08-30 Thread Wido den Hollander
RBD images are always in RAW format and should be displayed that way Signed-off-by: Wido den Hollander w...@widodh.nl --- src/conf/storage_conf.c |3 ++- src/storage/storage_backend_rbd.c |2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/conf

Re: [libvirt] Can I request a new release of libvirt-java?

2013-08-30 Thread Wido den Hollander
On 08/15/2013 11:00 AM, Wido den Hollander wrote: Hello, In the recent months various new methods were added to libvirt-java which we (Apache CloudStack) would like to use in our KVM code. For example resizing storage volumes, right now we have to do this with Bash scripting since although

Re: [libvirt] [PATCH] rbd: Use different formatter to display disk format

2013-09-12 Thread Wido den Hollander
On 08/30/2013 12:30 PM, Wido den Hollander wrote: RBD images are always in RAW format and should be displayed that way Did anyone get the chance yet to review it? Thanks! Wido Signed-off-by: Wido den Hollander w...@widodh.nl --- src/conf/storage_conf.c |3 ++- src/storage

[libvirt] [PATCH] rbd: Use rbd_create3 to create RBD format 2 images by default

2013-09-12 Thread Wido den Hollander
This new RBD format supports snapshotting and cloning. By having libvirt create images in format 2 end-users of the created images can benefit of the new RBD format. Signed-off-by: Wido den Hollander w...@widodh.nl --- src/storage/storage_backend_rbd.c | 23 +-- 1 file

Re: [libvirt] [PATCH] rbd: Use rbd_create3 to create RBD format 2 images by default

2013-09-12 Thread Wido den Hollander
On 09/12/2013 04:12 PM, Daniel P. Berrange wrote: On Thu, Sep 12, 2013 at 11:27:10AM +0200, Wido den Hollander wrote: This new RBD format supports snapshotting and cloning. By having libvirt create images in format 2 end-users of the created images can benefit of the new RBD format. What's

Re: [libvirt] Can I request a new release of libvirt-java?

2013-09-13 Thread Wido den Hollander
On 09/13/2013 10:29 AM, Daniel Veillard wrote: On Mon, Sep 02, 2013 at 08:14:33AM +0800, Daniel Veillard wrote: On Fri, Aug 30, 2013 at 12:31:55PM +0200, Wido den Hollander wrote: On 08/15/2013 11:00 AM, Wido den Hollander wrote: Hello, In the recent months various new methods were added

Re: [libvirt] Can I request a new release of libvirt-java?

2013-09-13 Thread Wido den Hollander
On 09/13/2013 11:26 AM, Daniel Veillard wrote: On Fri, Sep 13, 2013 at 11:13:53AM +0200, Wido den Hollander wrote: On 09/13/2013 10:29 AM, Daniel Veillard wrote: [...] I'm puzzled, how can the build be successful if the main jar is not generated ??? Odd, I tried building the Deb

Re: [libvirt] Can I request a new release of libvirt-java?

2013-09-16 Thread Wido den Hollander
On 09/16/2013 07:58 AM, Daniel Veillard wrote: Raising this due to maven On Fri, Sep 13, 2013 at 05:26:24PM +0800, Daniel Veillard wrote: On Fri, Sep 13, 2013 at 11:13:53AM +0200, Wido den Hollander wrote: [...] Indeed that was the problem, I just commited the fix, thanks

Re: [libvirt] [PATCH] rbd: Use rbd_create3 to create RBD format 2 images by default

2014-01-02 Thread Wido den Hollander
On 12/11/2013 03:47 PM, Wido den Hollander wrote: This new RBD format supports snapshotting and cloning. By having libvirt create images in format 2 end-users of the created images can benefit of the new RBD format. Older versions of libvirt can work with this new RBD format as long as librbd

Re: [libvirt] [PATCH] rbd: Use rbd_create3 to create RBD format 2 images by default

2014-01-04 Thread Wido den Hollander
On 01/02/2014 08:42 PM, Doug Goldstein wrote: On Thu, Jan 2, 2014 at 10:01 AM, Wido den Hollander w...@widodh.nl wrote: On 12/11/2013 03:47 PM, Wido den Hollander wrote: This new RBD format supports snapshotting and cloning. By having libvirt create images in format 2 end-users

Re: [libvirt] [PATCH] rbd: Use rbd_create3 to create RBD format 2 images by default

2014-01-13 Thread Wido den Hollander
On 12/11/2013 03:47 PM, Wido den Hollander wrote: This new RBD format supports snapshotting and cloning. By having libvirt create images in format 2 end-users of the created images can benefit of the new RBD format. Older versions of libvirt can work with this new RBD format as long as librbd

[libvirt] [PATCH] rbd: Use rbd_create3 to create RBD format 2 images by default

2014-01-30 Thread Wido den Hollander
by librbd since version 0.56 (Ceph Bobtail). Signed-off-by: Wido den Hollander w...@widodh.nl --- src/storage/storage_backend_rbd.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c index

Re: [libvirt] [PATCH] rbd: Use rbd_create3 to create RBD format 2 images by default

2014-02-04 Thread Wido den Hollander
On 01/30/2014 02:02 PM, Ján Tomko wrote: On 12/11/2013 03:47 PM, Wido den Hollander wrote: This new RBD format supports snapshotting and cloning. By having libvirt create images in format 2 end-users of the created images can benefit of the new RBD format. Older versions of libvirt can work

[libvirt] [PATCH 3/3] rbd: Set timeout options for librados

2014-02-12 Thread Wido den Hollander
These timeout values make librados/librbd return -ETIMEDOUT when a operation is blocking due to a failing/unreachable Ceph cluster. By having the operations time out libvirt will not block. --- src/storage/storage_backend_rbd.c | 17 + 1 file changed, 17 insertions(+) diff

[libvirt] [PATCH 1/3] rbd: Include return statusses from librados/librbd in logging

2014-02-12 Thread Wido den Hollander
With this information it's easier for the user to debug what is going wrong. --- src/storage/storage_backend_rbd.c | 119 + 1 file changed, 68 insertions(+), 51 deletions(-) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c

[libvirt] [PATCH 0/3] Various RBD storage pool changes

2014-02-12 Thread Wido den Hollander
these timeout options nothing happens. libvirt compiles and runs just fine, but the timeout simply won't work. Wido den Hollander (3): rbd: Include return statusses from librados/librbd in logging rbd: Simplify opening RADOS IoCTX rbd: Set timeout options for librados src/storage

[libvirt] [PATCH 2/3] rbd: Simplify opening RADOS IoCTX

2014-02-12 Thread Wido den Hollander
Reduces code and brings logging back to one function. --- src/storage/storage_backend_rbd.c | 43 ++--- 1 file changed, 16 insertions(+), 27 deletions(-) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c index bd21873..8d1e320

[libvirt] [PATCH 0/2] Improve RBD storage pool backend

2014-02-25 Thread Wido den Hollander
is down. Librados will then not block for ever, but return a -ETIMEDOUT so libvirt does not block for ever. Wido den Hollander (2): rbd: Include return statusses from librados/librbd in logging rbd: Set timeout options for librados src/storage/storage_backend_rbd.c | 144

[libvirt] [PATCH 1/2] rbd: Include return statusses from librados/librbd in logging

2014-02-25 Thread Wido den Hollander
With this information it's easier for the user to debug what is going wrong. --- src/storage/storage_backend_rbd.c | 127 ++--- 1 file changed, 61 insertions(+), 66 deletions(-) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c

[libvirt] [PATCH 2/2] rbd: Set timeout options for librados

2014-02-25 Thread Wido den Hollander
These timeout values make librados/librbd return -ETIMEDOUT when a operation is blocking due to a failing/unreachable Ceph cluster. By having the operations time out libvirt will not block. --- src/storage/storage_backend_rbd.c | 17 + 1 file changed, 17 insertions(+) diff

Re: [libvirt] Can I request a new release of libvirt-java?

2013-09-17 Thread Wido den Hollander
On 09/16/2013 07:58 AM, Daniel Veillard wrote: Raising this due to maven On Fri, Sep 13, 2013 at 05:26:24PM +0800, Daniel Veillard wrote: On Fri, Sep 13, 2013 at 11:13:53AM +0200, Wido den Hollander wrote: [...] Indeed that was the problem, I just commited the fix, thanks

[libvirt] [PATCH libvirt-java] Set source and target version to Java 1.6

2013-09-17 Thread Wido den Hollander
On platforms with Java 1.7 it will still produce compatible code with Java 1.6 platforms Java 1.6 is still out there and widely used. Signed-off-by: Wido den Hollander w...@widodh.nl --- build.properties |2 ++ build.xml|4 ++-- 2 files changed, 4 insertions(+), 2 deletions

Re: [libvirt] Can I request a new release of libvirt-java?

2013-09-17 Thread Wido den Hollander
On 09/17/2013 09:23 AM, Daniel Veillard wrote: On Tue, Sep 17, 2013 at 09:04:46AM +0200, Wido den Hollander wrote: On 09/16/2013 07:58 AM, Daniel Veillard wrote: Raising this due to maven On Fri, Sep 13, 2013 at 05:26:24PM +0800, Daniel Veillard wrote: On Fri, Sep 13, 2013 at 11:13:53AM

Re: [libvirt] Can I request a new release of libvirt-java?

2013-09-17 Thread Wido den Hollander
On 09/17/2013 11:13 AM, Daniel Veillard wrote: On Tue, Sep 17, 2013 at 10:09:36AM +0200, Wido den Hollander wrote: On 09/17/2013 09:23 AM, Daniel Veillard wrote: On Tue, Sep 17, 2013 at 09:04:46AM +0200, Wido den Hollander wrote: On 09/16/2013 07:58 AM, Daniel Veillard wrote: Raising

Re: [libvirt] [PATCH libvirt-java] Set source and target version to Java 1.6

2013-09-17 Thread Wido den Hollander
On 09/17/2013 01:14 PM, Claudio Bley wrote: At Tue, 17 Sep 2013 10:04:59 +0200, Wido den Hollander wrote: On platforms with Java 1.7 it will still produce compatible code with Java 1.6 platforms Java 1.6 is still out there and widely used. AFAIK, the code is 1.5 compliant which would

Re: [libvirt] [PATCH libvirt-java] Set source and target version to Java 1.6

2013-09-17 Thread Wido den Hollander
On 09/17/2013 02:58 PM, Claudio Bley wrote: At Tue, 17 Sep 2013 13:48:11 +0200, Wido den Hollander wrote: On 09/17/2013 01:14 PM, Claudio Bley wrote: At Tue, 17 Sep 2013 10:04:59 +0200, Wido den Hollander wrote: On platforms with Java 1.7 it will still produce compatible code with Java 1.6

[libvirt] [PATCH] rbd: Use rbd_create3 to create RBD format 2 images by default

2013-12-11 Thread Wido den Hollander
of librbd do. Signed-off-by: Wido den Hollander w...@widodh.nl --- src/storage/storage_backend_rbd.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c index 4b6f18c..f3dd7a0 100644

[libvirt] [PATCH libvirt-java 1/9] Add StorageVol and DomainBlock resize methods

2013-01-05 Thread Wido den Hollander
Signed-off-by: Wido den Hollander w...@widodh.nl --- src/main/java/org/libvirt/jna/Libvirt.java |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/main/java/org/libvirt/jna/Libvirt.java b/src/main/java/org/libvirt/jna/Libvirt.java index e68d9ed..dbd8f6c 100644 --- a/src/main/java/org

[libvirt] [PATCH libvirt-java 3/9] Add virDomainBlockResize to Domain methods

2013-01-05 Thread Wido den Hollander
Signed-off-by: Wido den Hollander w...@widodh.nl --- src/main/java/org/libvirt/Domain.java | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/main/java/org/libvirt/Domain.java b/src/main/java/org/libvirt/Domain.java index fc1f665..4b4c572 100644 --- a/src/main/java

[libvirt] [PATCH libvirt-java 4/9] Add the option to pass flags for snapshotCreateXML

2013-01-05 Thread Wido den Hollander
Signed-off-by: Wido den Hollander w...@widodh.nl --- src/main/java/org/libvirt/Domain.java | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/libvirt/Domain.java b/src/main/java/org/libvirt/Domain.java index 4b4c572..e0be43d 100644

[libvirt] [PATCH libvirt-java 9/9] Add resize flags to StorageVol

2013-01-05 Thread Wido den Hollander
Signed-off-by: Wido den Hollander w...@widodh.nl --- src/main/java/org/libvirt/StorageVol.java |7 +++ 1 file changed, 7 insertions(+) diff --git a/src/main/java/org/libvirt/StorageVol.java b/src/main/java/org/libvirt/StorageVol.java index 66e647f..9ea23c7 100644 --- a/src/main/java

[libvirt] [PATCH libvirt-java 7/9] Use and implement virDomainMigrate2 instead of virDomainMigrate

2013-01-05 Thread Wido den Hollander
This enables use a different XML for running the guest on the target host. Signed-off-by: Wido den Hollander w...@widodh.nl --- src/main/java/org/libvirt/Domain.java | 54 ++-- src/main/java/org/libvirt/jna/Libvirt.java |2 ++ 2 files changed, 54 insertions

[libvirt] [PATCH libvirt-java 6/9] Implement virDomainSnapshotListNames with flags option

2013-01-05 Thread Wido den Hollander
Signed-off-by: Wido den Hollander w...@widodh.nl --- src/main/java/org/libvirt/Domain.java | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/libvirt/Domain.java b/src/main/java/org/libvirt/Domain.java index d393960..932f56c 100644

[libvirt] [PATCH libvirt-java 8/9] Implement and use virDomainMigrateToURI2 instead of virDomainMigrateToURI

2013-01-05 Thread Wido den Hollander
The migrateToURI method now uses virDomainMigrateToURI2 so we can support some more features. Signed-off-by: Wido den Hollander w...@widodh.nl --- src/main/java/org/libvirt/Domain.java | 33 +--- src/main/java/org/libvirt/jna/Libvirt.java |2 ++ 2 files changed

[libvirt] Series of patches for libvirt-java

2013-01-05 Thread Wido den Hollander
Hello, This series of patches adds functionality to libvirt-java for: * block device resizing * snapshot handling * domain migration All these patches originate from the Apache CloudStack project and were written during development of new featurs for CloudStack. Thank you, Wido -- libvir-list

[libvirt] [PATCH libvirt-java 5/9] Implement virDomainUndefineFlags

2013-01-05 Thread Wido den Hollander
Signed-off-by: Wido den Hollander w...@widodh.nl --- src/main/java/org/libvirt/Domain.java | 15 +++ src/main/java/org/libvirt/jna/Libvirt.java |1 + 2 files changed, 16 insertions(+) diff --git a/src/main/java/org/libvirt/Domain.java b/src/main/java/org/libvirt

[libvirt] [PATCH libvirt-java 2/9] Add resize method in StorageVol

2013-01-05 Thread Wido den Hollander
Signed-off-by: Wido den Hollander w...@widodh.nl --- src/main/java/org/libvirt/StorageVol.java | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/main/java/org/libvirt/StorageVol.java b/src/main/java/org/libvirt/StorageVol.java index 1bed6e1..66e647f 100644 --- a/src

Re: [libvirt] [PATCH libvirt-java 8/9] Implement and use virDomainMigrateToURI2 instead of virDomainMigrateToURI

2013-01-08 Thread Wido den Hollander
On 01/08/2013 09:18 AM, Claudio Bley wrote: At Mon, 07 Jan 2013 17:10:16 -0700, Eric Blake wrote: On 01/05/2013 04:48 AM, Wido den Hollander wrote: The migrateToURI method now uses virDomainMigrateToURI2 so we can support some more features. +public int migrateToURI(String dconnuri

[libvirt] [libvirt-java] git commit: Fix memory leaks for libvirt functions returning newly allocated memory. (3220de)

2013-01-11 Thread Wido den Hollander
Hi, I just wanted to build the latest libvirt-java master on my Ubuntu 12.04 laptop and it failed due to this commit. The commit message says: Use JNA's Native.free() method to free memory. This requires JNA version 3.3.0 or later. Ubuntu 12.04 comes with JNA 3.2.7-4, so the build fails.

[libvirt] [PATCH libvirt-java 1/7] Implement virDomainBlockResize

2013-01-13 Thread Wido den Hollander
This adds the blockResize() method to the Domain class Signed-off-by: Wido den Hollander w...@widodh.nl --- src/main/java/org/libvirt/Domain.java | 17 + src/main/java/org/libvirt/jna/Libvirt.java |1 + 2 files changed, 18 insertions(+) diff --git a/src/main/java/org

[libvirt] [libvirt-java] Add various block, snapshot and migrate methods

2013-01-13 Thread Wido den Hollander
Hi, I've sent a series of patches like these about two weeks ago and got some great feedback from Claudio on those! The feedback from Claudio has been used for writing this series of patches. Backwards compatibility has been preserved by still using virDomainMigrate and virtDomainMigrateToUri

[libvirt] [PATCH libvirt-java 3/7] Implement virDomainUndefineFlags by overloading the existing undefine method

2013-01-13 Thread Wido den Hollander
We divert from the one-on-one mapping rule here by not adding the undefineFlags() method Signed-off-by: Wido den Hollander w...@widodh.nl --- src/main/java/org/libvirt/Domain.java | 24 src/main/java/org/libvirt/jna/Libvirt.java |1 + 2 files changed, 25

[libvirt] [PATCH libvirt-java 5/7] Overload Domain.snapshotCreateXML with a method that has a argument for flags

2013-01-13 Thread Wido den Hollander
The original implementation doesn't have a argument for passing flags. It is however still there for backwards compatibility. Signed-off-by: Wido den Hollander w...@widodh.nl --- src/main/java/org/libvirt/Domain.java | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions

Re: [libvirt] [libvirt-java] Add various block, snapshot and migrate methods

2013-01-23 Thread Wido den Hollander
Hello Claudio, On 01/23/2013 04:13 PM, Claudio Bley wrote: Hello Wido, At Sun, 13 Jan 2013 19:09:22 +0100, Wido den Hollander wrote: Hi, I've sent a series of patches like these about two weeks ago and got some great feedback from Claudio on those! The feedback from Claudio has been used

[libvirt] [PATCH] storage backend: Add RBD (RADOS Block Device) support

2012-05-14 Thread Wido den Hollander
/storage_backend_rbd.c @@ -0,0 +1,544 @@ +/* + * storage_backend_rbd.c: storage backend for RBD (RADOS Block Device) handling + * + * Copyright (C) 2012 Wido den Hollander + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License

Re: [libvirt] [PATCH libvirt-java] Return a byte[] array with secretGetValue

2012-05-30 Thread Wido den Hollander
Hi, On 05/26/2012 04:28 AM, Eric Blake wrote: On 03/16/2012 04:08 AM, Wido den Hollander wrote: Signed-off-by: Wido den Hollanderw...@widodh.nl --- No commit message explaining why this is needed? src/main/java/org/libvirt/Secret.java | 11 +-- src/main/java/org/libvirt

[libvirt] Stored secrets seem to get corrupted

2012-06-25 Thread Wido den Hollander
Hi, On one of my systems I'm having troubles with my RBD storage backend. At first I thought it was a problem with my code, but after trying the same code on a second machine I'm a bit confused. The problem is that the storage backend tries to retrieve the value of a secret and base64

[libvirt] [PATCH] qemu: Always set auth_supported for Ceph disks.

2012-06-25 Thread Wido den Hollander
down arguments to Qemu. Signed-off-by: Wido den Hollander w...@widodh.nl --- src/qemu/qemu_command.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 6549f57..1c59695 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c

Re: [libvirt] [PATCH libvirt-java] Allow byte[] arrays to be set as a secretValue

2012-06-26 Thread Wido den Hollander
On 06/26/2012 05:37 AM, Daniel Veillard wrote: On Fri, Mar 09, 2012 at 04:12:46PM +0100, Wido den Hollander wrote: Signed-off-by: Wido den Hollander w...@widodh.nl --- src/main/java/org/libvirt/Secret.java | 11 +++ src/main/java/org/libvirt/jna/Libvirt.java |1 + 2

[libvirt] [PATCH libvirt-java 1/2] Return a byte[] array with secretGetValue

2012-06-26 Thread Wido den Hollander
= conn.secretLookupByUUIDString(uuuid); String value = new String(secret.getValue()); Signed-off-by: Wido den Hollander w...@widodh.nl --- src/main/java/org/libvirt/Secret.java | 13 ++--- src/main/java/org/libvirt/jna/Libvirt.java |2 +- 2 files changed, 11 insertions(+), 4

Re: [libvirt] [PATCH libvirt-java 1/2] Return a byte[] array with secretGetValue

2012-06-26 Thread Wido den Hollander
On 06/26/2012 10:07 AM, Wido den Hollander wrote: We break the API with this, but Java does not support multiple method signatures with different return types. The old method returned a String, but since a secret can be binary data this type is not suited. Users who now that their secret

[libvirt] [PATCH libvirt-java 2/2] Add flags to StoragePoolRefresh

2012-06-26 Thread Wido den Hollander
Signed-off-by: Wido den Hollander w...@widodh.nl --- src/main/java/org/libvirt/StoragePool.java |2 +- src/main/java/org/libvirt/jna/Libvirt.java |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/libvirt/StoragePool.java b/src/main/java/org/libvirt

Re: [libvirt] Stored secrets seem to get corrupted

2012-06-26 Thread Wido den Hollander
On 06/25/2012 04:54 PM, Daniel P. Berrange wrote: On Mon, Jun 25, 2012 at 04:37:48PM +0200, Wido den Hollander wrote: Hi, On one of my systems I'm having troubles with my RBD storage backend. At first I thought it was a problem with my code, but after trying the same code on a second machine

Re: [libvirt] Stored secrets seem to get corrupted

2012-07-03 Thread Wido den Hollander
On 25-06-12 16:54, Daniel P. Berrange wrote: Notice this behavior: root@stack01:~# virsh secret-set-value 322bccea-f2ed-4eae-a7e5-d0793ffb162d AQAE+uJPCFpELBAAkTniQvHabBGj0Quwnu2imA== Secret value set root@stack01:~# md5sum /etc/libvirt/secrets/322bccea-f2ed-4eae-a7e5-d0793ffb162d.base64

Re: [libvirt] Stored secrets seem to get corrupted

2012-07-03 Thread Wido den Hollander
On 03-07-12 15:13, Daniel P. Berrange wrote: That is really bizarre. Can you look at what is actually stored in the .base64 file each time ? And what 'secret-get-value' replies with ? I haven't been able to look into this any further, however: I just downloaded 0.9.13 from the libvirt

Re: [libvirt] Stored secrets seem to get corrupted

2012-07-03 Thread Wido den Hollander
On 03-07-12 16:54, Daniel P. Berrange wrote: On Tue, Jul 03, 2012 at 04:42:54PM +0200, Wido den Hollander wrote: On 03-07-12 15:13, Daniel P. Berrange wrote: That is really bizarre. Can you look at what is actually stored in the .base64 file each time ? And what 'secret-get-value' replies

Re: [libvirt] Stored secrets seem to get corrupted

2012-07-04 Thread Wido den Hollander
On 03-07-12 17:21, Daniel P. Berrange wrote: On Tue, Jul 03, 2012 at 05:11:48PM +0200, Wido den Hollander wrote: Yes, there is memory corruption somewhere. I never used valgrind before, but the output seems to show. I ran libvirtd inside a screen, I've attached the screenlog with all

Re: [libvirt] Stored secrets seem to get corrupted

2012-07-04 Thread Wido den Hollander
On 04-07-12 10:45, Daniel P. Berrange wrote: On Wed, Jul 04, 2012 at 10:24:38AM +0200, Wido den Hollander wrote: On 03-07-12 17:21, Daniel P. Berrange wrote: On Tue, Jul 03, 2012 at 05:11:48PM +0200, Wido den Hollander wrote: Yes, there is memory corruption somewhere. I never used

Re: [libvirt] Stored secrets seem to get corrupted

2012-07-04 Thread Wido den Hollander
On 04-07-12 14:08, Eric Blake wrote: [adding gnulib] On 07/04/2012 02:45 AM, Daniel P. Berrange wrote: ==6825== ==6825== Invalid read of size 4 ==6825==at 0xA57E4B9: base64_encode (in /usr/lib/x86_64-linux-gnu/libroken.so.18.1.0) ==6825==by 0x10DDBC98: base64_encode_alloc

Re: [libvirt] [PATCH libvirt-java 1/2] Return a byte[] array with secretGetValue

2012-07-05 Thread Wido den Hollander
On 05-07-12 10:20, Daniel Veillard wrote: On Tue, Jun 26, 2012 at 10:07:31AM +0200, Wido den Hollander wrote: We break the API with this, but Java does not support multiple method signatures with different return types. The old method returned a String, but since a secret can be binary data

Re: [libvirt] trying to build 0.9.13 on F17: cannot find -lcrypto

2012-07-17 Thread Wido den Hollander
On 12-07-12 14:32, Daniel P. Berrange wrote: On Thu, Jul 12, 2012 at 02:20:11PM +0200, Christophe Fergeau wrote: Hey, On Wed, Jul 11, 2012 at 03:42:20PM +0100, Daniel P. Berrange wrote: On Wed, Jul 11, 2012 at 10:23:21AM -0400, Cole Robinson wrote: I think this comes from rbd support, from

[libvirt] Debian packaging for the Java bindings

2012-07-19 Thread Wido den Hollander
Currently the Java bindings for libvirt do not provide a Debian package. Users with Debian based systems like Ubuntu are now forced to compile from source since no binary distribution of the JAR file is available. This patch adds building Debian packages with ant $ ant deb This will build a

[libvirt] [PATCH libvirt-java] Add debian packaging for the Java bindings

2012-07-19 Thread Wido den Hollander
Signed-off-by: Wido den Hollander w...@widodh.nl --- build.xml | 19 +++ debian/control.in |9 + 2 files changed, 28 insertions(+) create mode 100644 debian/control.in diff --git a/build.xml b/build.xml index 606cdaa..eefd08c 100644 --- a/build.xml +++ b

Re: [libvirt] [PATCH 0/5 v2] Improve Ceph Qemu+RBD support

2011-10-07 Thread Wido den Hollander
Hi, On Mon, 2011-09-19 at 21:13 -0700, Sage Weil wrote: The current support for qemu and Ceph RBD (rados block device) has two main deficiencies: authentication doesn't work, and it relies on environment variables (which don't work with latest upstream). This patch set addresses both those

[libvirt] Access to the secretDriver in a storage backend?

2011-12-31 Thread Wido den Hollander
Hi, I'm working on a storage backend for libvirt which needs credentials to access the storage pool. I want to use the build in secret manager from libvirt, but it seems I do not have access to the secretDriver in a storage backend? static int virStorageBackendRBDRefreshPool(virConnectPtr

Re: [libvirt] Access to the secretDriver in a storage backend?

2012-01-03 Thread Wido den Hollander
On 01/03/2012 12:58 PM, Daniel P. Berrange wrote: On Sat, Dec 31, 2011 at 01:26:54PM +0100, Wido den Hollander wrote: Hi, I'm working on a storage backend for libvirt which needs credentials to access the storage pool. I want to use the build in secret manager from libvirt, but it seems I do

[libvirt] Downloading and wiping assumes volume is a device or file

2012-02-09 Thread Wido den Hollander
Hi, I'm still working on the RBD (RADOS / Ceph) storage driver for libvirt and I noticed the virStorageVolDownload and virStorageVolWipe methods. I assumed those would be passed on to the storage backend, but it doesn't. In the storageDriver the method storageVolumeDownload simply opens a

Re: [libvirt] Downloading and wiping assumes volume is a device or file

2012-02-10 Thread Wido den Hollander
Hi, On 02/09/2012 09:27 PM, Eric Blake wrote: On 02/09/2012 01:04 PM, Wido den Hollander wrote: Hi, I'm still working on the RBD (RADOS / Ceph) storage driver for libvirt and I noticed the virStorageVolDownload and virStorageVolWipe methods. I assumed those would be passed on to the storage

[libvirt] Maven2 packages for libvirt-java

2012-07-31 Thread Wido den Hollander
Hi, Is de /maven2 [0] directory at libvirt.org still maintained? It currently contains up to libvirt-java 0.4.7, while 0.4.8 is out. If it is still maintained, could 0.4.8 be added? Thanks! Wido [0]: http://www.libvirt.org/maven2/org/libvirt/libvirt/ -- libvir-list mailing list

Re: [libvirt] [PATCH libvirt-java] Add debian packaging for the Java bindings

2012-08-01 Thread Wido den Hollander
On 07/19/2012 07:33 PM, Wido den Hollander wrote: Signed-off-by: Wido den Hollander w...@widodh.nl --- build.xml | 19 +++ debian/control.in |9 + 2 files changed, 28 insertions(+) create mode 100644 debian/control.in diff --git a/build.xml b

Re: [libvirt] namespace clean shared libraries

2012-08-02 Thread Wido den Hollander
On 07/08/2012 07:51 PM, Bruno Haible wrote: Daniel P. Berrange wrote: If its better to just do it in libvirt config.h, then we can do that too Yes, doing '#define foo libvirt_foo' in config.h is the preferred way of achieving a namespace clean shared library. There are two ways to generate

Re: [libvirt] namespace clean shared libraries

2012-08-02 Thread Wido den Hollander
On 08/02/2012 01:37 PM, Daniel P. Berrange wrote: On Thu, Aug 02, 2012 at 01:18:12PM +0200, Wido den Hollander wrote: On 07/08/2012 07:51 PM, Bruno Haible wrote: Daniel P. Berrange wrote: If its better to just do it in libvirt config.h, then we can do that too Yes, doing '#define foo

Re: [libvirt] [PATCH libvirt-java] Add debian packaging for the Java bindings

2012-08-06 Thread Wido den Hollander
On 08/02/2012 01:00 AM, Eric Blake wrote: On 08/01/2012 08:51 AM, Wido den Hollander wrote: On 07/19/2012 07:33 PM, Wido den Hollander wrote: Signed-off-by: Wido den Hollander w...@widodh.nl --- build.xml | 19 +++ debian/control.in |9 + 2 files

Re: [libvirt] Maven2 packages for libvirt-java

2012-08-10 Thread Wido den Hollander
On 08/10/2012 07:50 AM, Daniel Veillard wrote: On Tue, Jul 31, 2012 at 10:44:41AM +0200, Wido den Hollander wrote: Hi, Is de /maven2 [0] directory at libvirt.org still maintained? It currently contains up to libvirt-java 0.4.7, while 0.4.8 is out. If it is still maintained, could 0.4.8

[libvirt] [libvirt-java] Upload 0.4.8 to central Maven repository

2012-09-06 Thread Wido den Hollander
Hi, At the CloudStack project we are switching to Maven for building and resolving external dependencies. In the central Maven repository [0] the latest version of libvirt-java is however 0.4.7 Could 0.4.8 be uploaded to this repository? Thank you, Wido [0]:

Re: [libvirt] [libvirt-java] Upload 0.4.8 to central Maven repository

2012-09-06 Thread Wido den Hollander
On 09/06/2012 10:38 AM, Daniel Veillard wrote: On Thu, Sep 06, 2012 at 10:18:22AM +0200, Wido den Hollander wrote: Hi, At the CloudStack project we are switching to Maven for building and resolving external dependencies. In the central Maven repository [0] the latest version of libvirt-java

Re: [libvirt] [libvirt-java] Upload 0.4.8 to central Maven repository

2012-09-06 Thread Wido den Hollander
On 09/06/2012 05:04 PM, Daniel Veillard wrote: On Thu, Sep 06, 2012 at 04:47:45PM +0200, Wido den Hollander wrote: On 09/06/2012 10:38 AM, Daniel Veillard wrote: I added libvirt.org as a manual repository and while fetching the dependencies I saw: [INFO] snapshot org.apache.cloudstack:xapi

Re: [libvirt] [libvirt-java] Upload 0.4.8 to central Maven repository

2012-09-10 Thread Wido den Hollander
On 09/10/2012 02:29 PM, Daniel Veillard wrote: On Thu, Sep 06, 2012 at 04:47:45PM +0200, Wido den Hollander wrote: On 09/06/2012 10:38 AM, Daniel Veillard wrote: it's maven which should fetch data from libvirt.org and i though I had updated everything as needed: http://libvirt.org

Re: [libvirt] [libvirt-java] Upload 0.4.8 to central Maven repository

2012-09-10 Thread Wido den Hollander
On 09/10/2012 03:23 PM, Daniel Veillard wrote: On Mon, Sep 10, 2012 at 03:00:57PM +0200, Wido den Hollander wrote: On 09/10/2012 02:29 PM, Daniel Veillard wrote: any idea how to tell the main maven site to refetch ? Even though we added the checksums, http://search.maven.org still don't show

Re: [libvirt] [libvirt-java] Upload 0.4.8 to central Maven repository

2012-09-14 Thread Wido den Hollander
On 09/13/2012 02:19 PM, Daniel Veillard wrote: On Mon, Sep 10, 2012 at 03:46:43PM +0200, Wido den Hollander wrote: On 09/10/2012 03:23 PM, Daniel Veillard wrote: On Mon, Sep 10, 2012 at 03:00:57PM +0200, Wido den Hollander wrote: On 09/10/2012 02:29 PM, Daniel Veillard wrote: any idea how

Re: [libvirt] [libvirt-java] Upload 0.4.8 to central Maven repository

2012-09-14 Thread Wido den Hollander
On 09/13/2012 02:19 PM, Daniel Veillard wrote: On Mon, Sep 10, 2012 at 03:46:43PM +0200, Wido den Hollander wrote: On 09/10/2012 03:23 PM, Daniel Veillard wrote: On Mon, Sep 10, 2012 at 03:00:57PM +0200, Wido den Hollander wrote: On 09/10/2012 02:29 PM, Daniel Veillard wrote: any idea how

Re: [libvirt] [libvirt-java] Upload 0.4.8 to central Maven repository

2012-09-14 Thread Wido den Hollander
On 09/14/2012 04:59 PM, Daniel Veillard wrote: On Fri, Sep 14, 2012 at 04:18:21PM +0200, Wido den Hollander wrote: On 09/13/2012 02:19 PM, Daniel Veillard wrote: On Mon, Sep 10, 2012 at 03:46:43PM +0200, Wido den Hollander wrote: On 09/10/2012 03:23 PM, Daniel Veillard wrote: On Mon, Sep 10

Re: [libvirt] [libvirt-java] Upload 0.4.8 to central Maven repository

2012-09-17 Thread Wido den Hollander
On 14-09-12 18:09, Daniel Veillard wrote: On Fri, Sep 14, 2012 at 05:36:10PM +0200, Wido den Hollander wrote: On 09/14/2012 04:59 PM, Daniel Veillard wrote: [...] http://repo1.maven.org/maven2/org/apache/maven/maven-ant-tasks/2.1.3/maven-ant-tasks-2.1.3.pom doesn't seems to have any

Re: [libvirt] [libvirt-java] Upload 0.4.8 to central Maven repository

2012-09-17 Thread Wido den Hollander
On 17-09-12 14:20, Daniel Veillard wrote: On Mon, Sep 17, 2012 at 10:35:02AM +0200, Wido den Hollander wrote: On 14-09-12 18:09, Daniel Veillard wrote: On Fri, Sep 14, 2012 at 05:36:10PM +0200, Wido den Hollander wrote: On 09/14/2012 04:59 PM, Daniel Veillard wrote: [...] http://repo1

  1   2   >