Re: [libvirt] Exposing mem-path in domain XML

On Wed, Sep 06, 2017 at 01:35:45PM +0200, Michal Privoznik wrote: > On 09/05/2017 04:07 PM, Daniel P. Berrange wrote: > > On Tue, Sep 05, 2017 at 03:59:09PM +0200, Michal Privoznik wrote: > >> On 07/28/2017 10:59 AM, Daniel P. Berrange wrote: > >>> On Fri, Jul 28, 20

[libvirt] [PATCH python] Post-release version bump to 3.8.0

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Pushed as trivial setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 6e5242d..f33ff1a 100755 --- a/setup.py +++ b/setup.py @@ -334,7 +334,7 @@ class my_clean(clean): _c_m

Re: [libvirt] [PATCH] m4: Disable -Wdisabled-optimization

optimizers are unable > +# > to handle the code effectively. > +# Source: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html > +dontwarn="$dontwarn -Wdisabled-optimization" > > # gcc 4.2 treats attribute(format) as an implicit attribute(nonnull), >

Re: [libvirt] Exposing mem-path in domain XML

On Tue, Sep 05, 2017 at 03:59:09PM +0200, Michal Privoznik wrote: > On 07/28/2017 10:59 AM, Daniel P. Berrange wrote: > > On Fri, Jul 28, 2017 at 10:45:21AM +0200, Michal Privoznik wrote: > >> On 07/27/2017 03:50 PM, Daniel P. Berrange wrote: > >>> On Thu, Jul 27, 20

Re: [libvirt] Yet another RFC for CAT

On Mon, Sep 04, 2017 at 04:14:00PM +0200, Martin Kletzander wrote: > * The current design (finally something libvirt-related, right?) > > The discussion ended with a conclusion of the following (with my best > knowledge, there were so many discussions about so many things that I > would spend too

Re: [libvirt] [PATCH] Makefile.nonreentrant: Rebuild against Fedora 26

olognani <abolo...@redhat.com> > --- > I didn't put too much thought into this, but the results looks > sane enough as we are only *adding* to the list. > > Makefile.nonreentrant | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Reviewed-by: Daniel P.

[libvirt] [PATCH python] Remove unused variables for event callbacks

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt-override.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/libvirt-override.c b/libvirt-override.c index c04ce2e..a3a0508 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -5182,19 +5

[libvirt] [PATCH python] Report an error if registering an event loop twice

The C library will now ignore an attempt to register an event loop twice. It is unable to report an error in this case though due to the C API returning 'void'. To improve this we must manually report an error at the python level. Signed-off-by: Daniel P. Berrange <berra...@redhat.

[libvirt] [PATCH] Add libxslt as build requires for mingw RPMs

The libxslt package is needed since: commit 94d2d6429d686c5af95115d09c01f3c6bd5ea7c6 Author: Daniel P. Berrange <berra...@redhat.com> Date: Wed Jul 26 17:40:44 2017 +0100 docs: make xmllint & xsltproc compulsory The native RPM had it already, but mingw build was missing i

[libvirt] [PATCH] event: ignore attempts to replace the event loop impl

aces even if virConnectClose has been called on open handles, due to delayed deregistration of callbacks during conenction close. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/util/virevent.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/util/vireve

Re: [libvirt] [PATCH 2/3] libvirtaio: add allow for moving callbacks to other event loop

On Fri, Sep 01, 2017 at 01:51:17PM +0200, Wojtek Porczyk wrote: > On Fri, Sep 01, 2017 at 10:08:18AM +0100, Daniel P. Berrange wrote: > > IIUC, you are trying to make it possible to register multiple event > > loop impls. This is *not* supported usage of libvirt. Yo

Re: [libvirt] [PATCH 2/3] libvirtaio: add allow for moving callbacks to other event loop

On Thu, Aug 31, 2017 at 09:40:23PM +0200, Wojtek Porczyk wrote: > The virEvent implementation is tied to a particular loop. When spinning > another loop, the callbacks have to be moved to another implementation, > so they will have a chance to be invoked, should they be scheduled. If > not, file

Re: [libvirt] [PATCH v6 01/13] qemu: Add QEMU 2.10 x86_64 the generated capabilities

On Wed, Aug 30, 2017 at 06:46:01PM -0400, John Ferlan wrote: > For reference, these were generated by updating a local qemu git > repository to the latest upstream and building in order to generate > an "x86_64-softmmu/qemu-system-x86_64" image. > > The image was then provided as input: > >

Re: [libvirt] [PATCH] qemu: handle -1 for pid in qemuDomainGetMachineName

ame(virDomainObjPtr vm) > virQEMUDriverPtr driver = priv->driver; > char *ret = NULL; > > -if (vm->pid) { > +if (vm->pid > 0) { > ret = virSystemdGetMachineNameByPID(vm->pid); > if (!ret) > virResetLastError(); Re

[libvirt] [PATCH] Fix TLS test suites with gnutls 3.6.0

With gnutls 3.6.0, SHA1 is no longer accepted for certificate signatures. We must usw SHA256 instead. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- tests/virnettlshelpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/virnettlshelpers.c b

[libvirt] [PATCH] rpc: avoid ssh interpreting malicious hostname as arguments

a fail from hostname lookup. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/rpc/virnetsocket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index d228c8a8c..23089afef 100644 --- a/src/rpc/virnetsocket.c ++

Re: [libvirt] Entering freeze for libvirt-3.7.0

On Tue, Aug 29, 2017 at 02:12:56PM +0200, Daniel Veillard wrote: > As suggested yesterday (sorry for short notice) I have just tagged the > rc1 in git and pushed signed tarball and rpms to the usual place: > > ftp://libvirt.org/libvirt/ > > Things looks fine for me, jenkins on

Re: [libvirt] New QEMU daemon for persistent reservations

On Tue, Aug 22, 2017 at 06:27:40PM +0200, Paolo Bonzini wrote: > Hi all, > > I am adding a new daemon to QEMU, that QEMU can connect to in order to > issue persistent reservation commands. Can you elaborate on what this daemon does ? IIUC, by 'persistent reservation' you are referring to SCSI

Re: [libvirt] [PATCH 3/3] tests: deterministichash: Make hash tables arch-independent

On Tue, Aug 15, 2017 at 10:02:38AM -0400, John Ferlan wrote: > > > On 08/15/2017 08:01 AM, Peter Krempa wrote: > > On Mon, Aug 14, 2017 at 20:46:10 -0400, John Ferlan wrote: > >> On 08/03/2017 04:50 AM, Peter Krempa wrote: > > > > [ trimmed off-topic part ] > > > >> NB: I didn't dig into the

Re: [libvirt] [PATCH 3/3] tests: deterministichash: Make hash tables arch-independent

On Tue, Aug 15, 2017 at 03:03:07PM +0200, Michal Privoznik wrote: > On 08/15/2017 02:01 PM, Peter Krempa wrote: > > On Mon, Aug 14, 2017 at 20:46:10 -0400, John Ferlan wrote: > >> On 08/03/2017 04:50 AM, Peter Krempa wrote: > > > > [ trimmed off-topic part ] > > > >> NB: I didn't dig into the

Re: [libvirt] [PATCHv2 0/3] exposing busy polling support for vhost-net

On Mon, Jul 17, 2017 at 01:39:13PM +0200, Peter Krempa wrote: > On Mon, Jul 17, 2017 at 07:27:24 -0400, sferd...@redhat.com wrote: > > From: Sahid Orentino Ferdjaoui > > > > In version 2.7.0, QEMU introduced support of busy polling for > > vhost-net [0]. To avoid

[libvirt] [PATCH] m4: workaround clang/glibc problem with isnan()

. Berrange <berra...@redhat.com> --- m4/virt-compile-warnings.m4 | 18 ++ 1 file changed, 18 insertions(+) diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4 index fa0940fc6..7b56115ce 100644 --- a/m4/virt-compile-warnings.m4 +++ b/m4/virt-compile-warni

Re: [libvirt] [PATCH python] rpm: assume python3 is always available

On Thu, Aug 10, 2017 at 02:01:40PM +0200, Martin Kletzander wrote: > On Thu, Aug 10, 2017 at 12:11:00PM +0100, Daniel P. Berrange wrote: > > On Thu, Aug 10, 2017 at 09:27:27AM +0200, Martin Kletzander wrote: > > > On Wed, Aug 09, 2017 at 05:08:44PM +0100, Daniel P. Berrange wro

Re: [libvirt] [PATCH python] rpm: assume python3 is always available

On Thu, Aug 10, 2017 at 09:27:27AM +0200, Martin Kletzander wrote: > On Wed, Aug 09, 2017 at 05:08:44PM +0100, Daniel P. Berrange wrote: > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > > --- > > libvirt-python.spec.in | 17 - >

[libvirt] [PATCH python v2] Change Obsoletes to an explicit version

We only want to obsolete versions which actually had the original name, not all future versions. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Changed in v2: - Fix both sub-rpms libvirt-python.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[libvirt] [PATCH python] Change Obsoletes to an explicit version

We only want to obsolete versions which actually had the original name, not all future versions. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt-python.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-python.spec.in b/libvirt-python.s

Re: [libvirt] [PATCH python] Avoid comparing boolean and integers

On Wed, Aug 09, 2017 at 02:17:10PM -0500, Eric Blake wrote: > On 08/09/2017 11:07 AM, Daniel P. Berrange wrote: > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > > --- > > libvirt-utils.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deleti

[libvirt] [PATCH python] rpm: assume python3 is always available

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt-python.spec.in | 17 - 1 file changed, 17 deletions(-) diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index fc30564..ed9f2bd 100644 --- a/libvirt-python.spec.in +++ b/libvirt-python.spec.in @

[libvirt] [PATCH python] rpm: rename packages to python2-libvirt / python3-libvirt

This compiles with Fedora naming policy for python packages Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt-python.spec.in | 28 +++- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in

[libvirt] [PATCH python] Avoid comparing boolean and integers

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt-utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-utils.c b/libvirt-utils.c index 727397d..0af13dc 100644 --- a/libvirt-utils.c +++ b/libvirt-utils.c @@ -108,7 +108,7 @@ virReallocN(void *

Re: [libvirt] [PATCH v2] Rewrite the way mockable functions are handled.

On Fri, Aug 04, 2017 at 06:13:42PM +0100, Daniel P. Berrange wrote: > Currently any mockable functions are marked with attributes > noinline, noclone and weak. This prevents the compiler from > optimizing away the impl of these functions. > > It has an unfortunate side effect w

Re: [libvirt] [PATCH 2/2] qemuDomainUndefineFlags: unlink nvram file regardless of domain state

On Mon, Aug 07, 2017 at 02:20:06PM +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1467245 > > Currently, there's a bug when undefining a domain with NVRAM > store. Basically, the unlink() of the NVRAM store file happens > during the undefine procedure iff domain is

Re: [libvirt] [PATCH v2 2/2] qemuDomainUndefineFlags: Forbid undefine of active domain with NVRAM

On Wed, Aug 09, 2017 at 02:55:36PM +0200, Michal Privoznik wrote: > On 08/09/2017 02:14 PM, Daniel P. Berrange wrote: > > On Wed, Aug 09, 2017 at 02:00:06PM +0200, Michal Privoznik wrote: > >> https://bugzilla.redhat.com/show_bug.cgi?id=1467245 > >> > >> Curr

Re: [libvirt] [PATCH v2 2/2] qemuDomainUndefineFlags: Forbid undefine of active domain with NVRAM

On Wed, Aug 09, 2017 at 02:00:06PM +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1467245 > > Currently, there's a bug when undefining a domain with NVRAM > store. Basically, the unlink() of the NVRAM store file happens > during the undefine procedure iff domain is

[libvirt] [PATCH v2] Update to latest keycodemapdb content

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/Makefile.am| 2 +- src/keycodemapdb | 2 +- src/util/virkeycode.c | 5 ++--- tests/virkeycodetest.c | 4 ++-- 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am

Re: [libvirt] [PATCH] Update to latest keycodemapdb content

On Tue, Aug 08, 2017 at 02:09:17PM +0200, Andrea Bolognani wrote: > On Mon, 2017-08-07 at 14:38 +0100, Daniel P. Berrange wrote: > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > > --- > > src/Makefile.am | 2 +- > > src/keycodemapdb | 2

[libvirt] [PATCH] docs: force content in

If there's no content in , the XSTL generator will turn it into which is not permitted in XHTML. Adding a single whitespace is enough to guarantee an explicit closing tag. Without this, the scripts never get loaded by the browser. Signed-off-by: Daniel P. Berrange <berra...@redhat.

[libvirt] [PATCH] Update to latest keycodemapdb content

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/Makefile.am | 2 +- src/keycodemapdb | 2 +- src/util/virkeycode.c | 5 ++--- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index b8e875482..45b58c0ad 100644 ---

[libvirt] [PATCH v2] Rewrite the way mockable functions are handled.

library, we also get all the symbols present. Finally the test suite can just directly define a 'foo' function in its source, removing the need to use LD_PRELOAD (though removal of LD_PRELOADS is left for a future patch). Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Changed

[libvirt] [PATCH] tools: make wireshark build quiet

Use $(AM_V_GEN) when running wireshark related tools Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- tools/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/Makefile.am b/tools/Makefile.am index 345521457..ffa8c3e19 100644 --- a

[libvirt] [PATCH] tests: add further XML namespace test

Validate that we can pass QEMU command line options using a default namespace, instead of a prefixed namespace Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- .../qemuxml2argvdata/qemuxml2argv-qemu-ns-alt.args | 27 +++ .../qemuxml2argvdata/qemuxml2argv-q

Re: [libvirt] [PATCH] docs: make website responsive for mobile devices

On Fri, Aug 04, 2017 at 05:35:05PM +0200, Pavel Hrdina wrote: > On Fri, Aug 04, 2017 at 04:07:51PM +0100, Daniel P. Berrange wrote: > > On Fri, Aug 04, 2017 at 04:56:30PM +0200, Peter Krempa wrote: > > > On Fri, Aug 04, 2017 at 13:31:04 +0100, Daniel Berrange wrote: > &

[libvirt] [PATCH] Remove bogus warning about vir$OBJECTGetConnect functions

iginal virConnectPtr object alongside the virDomainPtr. There's no reason to mandate such an approach though - it is valid for languages to expose this directly if that suits their needs better. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/libvirt-domain-snapshot.c | 6 --

[libvirt] [PATCH v2] docs: make website responsive for mobile devices

ned-off-by: Daniel P. Berrange <berra...@redhat.com> --- docs/main.css | 1 + docs/mobile.css | 94 + docs/page.xsl | 36 +- 3 files changed, 130 insertions(+), 1 deletion(-) create mode 100644 docs/mobile.css di

Re: [libvirt] [PATCH] rpm: conditionalize dep on perl for perl-interpretor split in F27

On Fri, Aug 04, 2017 at 04:37:37PM +0200, Michal Privoznik wrote: > On 08/02/2017 11:52 AM, Daniel P. Berrange wrote: > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > > --- > > libvirt.spec.in | 4 > > mingw-libvirt.spec.in | 4 &

Re: [libvirt] [PATCH] docs: make website responsive for mobile devices

On Fri, Aug 04, 2017 at 04:56:30PM +0200, Peter Krempa wrote: > On Fri, Aug 04, 2017 at 13:31:04 +0100, Daniel Berrange wrote: > > The website does not look good in a mobile device as the text is > > far too small and the layout assumes a wide screen. > > So can we fina

[libvirt] [PATCH] docs: make website responsive for mobile devices

The website does not look good in a mobile device as the text is far too small and the layout assumes a wide screen. Make the style dynanically adapt based on viewport size, so a mobile device gets a layout more suited to its dimensions. Signed-off-by: Daniel P. Berrange <berra...@redhat.

Re: [libvirt] Repack git repo?

On Thu, Aug 03, 2017 at 11:33:29AM +0200, Michal Privoznik wrote: > On 08/03/2017 09:57 AM, Daniel P. Berrange wrote: > > On Thu, Aug 03, 2017 at 09:16:13AM +0200, Michal Privoznik wrote: > >> So I was checking out the repo the other day and it took ages. So it got > >

Re: [libvirt] [PATCH] conf: Fix printing of 'type' and 'tty_compat' for Chr devices

On Wed, Aug 02, 2017 at 03:51:34PM -0400, John Ferlan wrote: > Commit id '0c1d8632' caused a regression in the virt-manager > test suite when formatting the type='spicevmc'/>. > > Adust the code to print the type in it's own new helper called > virDomainChrTypeFormat and have the

Re: [libvirt] Repack git repo?

On Thu, Aug 03, 2017 at 09:16:13AM +0200, Michal Privoznik wrote: > So I was checking out the repo the other day and it took ages. So it got > me thinking what might be the problem. Looks like a part of it is that > our pack is split among ~250 files. Therefore when somebody does > checkout git

Re: [libvirt] [PATCH] driver: conditionalize use of dlopen functions & use mingw-dlfcn

On Wed, Aug 02, 2017 at 01:31:03PM +0200, Peter Krempa wrote: > On Wed, Aug 02, 2017 at 11:26:06 +0100, Daniel Berrange wrote: > > Not every platform is guaranteed to have dlopen/dlsym, so we should > > conditionalize its use. Suprisingly it is actually present for Win32 > >

[libvirt] [PATCH] tools: rename 'socket' to 'sockpath'

A variable named 'socket' clashes with the function of the same name, causing build failures due to warnings on some platforms. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Pushed as CI build fix tools/virsh-domain.c | 22 +++--- 1 file changed, 11 inse

[libvirt] [PATCH] driver: conditionalize use of dlopen functions & use mingw-dlfcn

Not every platform is guaranteed to have dlopen/dlsym, so we should conditionalize its use. Suprisingly it is actually present for Win32 via the mingw-dlfcn add on, but we should still conditionalize it. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- configure.ac

[libvirt] [PATCH] rpm: conditionalize dep on perl for perl-interpretor split in F27

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt.spec.in | 4 mingw-libvirt.spec.in | 4 2 files changed, 8 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index b074bd171..8abecae22 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@

Re: [libvirt] [PATCH 7/7] util: Add safety net of checks to ensure valid object

On Fri, Jul 28, 2017 at 12:39:01PM -0400, John Ferlan wrote: > The virObject logic "assumes" that whatever is passed to its API's > would be some sort of virObjectPtr; however, if it is not then some > really bad things can happen. > > So far there's been only virObject{Ref|Unref},

Re: [libvirt] [PATCH 2/7] util: Introduce and use virObjectLockWrite

On Fri, Jul 28, 2017 at 12:38:56PM -0400, John Ferlan wrote: > Instead of making virObjectLock be the entry point for two > different types of locks, let's create a virObjectLockWrite API > which will be able to return status and force the (new) consumers > of the RWLock to make sure the lock is

Re: [libvirt] [PATCH 4/7] util: Introduce virObjectGetRWLockableObj

On Fri, Jul 28, 2017 at 12:38:58PM -0400, John Ferlan wrote: > Introduce a helper to handle the error path more cleanly. The same > as virObjectGetLockableObj. > > Signed-off-by: John Ferlan > --- > src/util/virobject.c | 51

Re: [libvirt] [PATCH 3/7] util: Only have virObjectLock handle virObjectLockable

On Fri, Jul 28, 2017 at 12:38:57PM -0400, John Ferlan wrote: > Now that virObjectLockWrite exists to handle the virObjectRWLockable > objects, let's restore virObjectLock to only handle virObjectLockable > type locks. There still exists the possibility that the input @anyobj > isn't a valid object

Re: [libvirt] [PATCH 1/7] util: Alter virObjectLockRead to return status

On Fri, Jul 28, 2017 at 12:38:55PM -0400, John Ferlan wrote: > Rather than ignore errors, let's have virObjectLockRead check for > the correct usage and issue an error when not properly used so > so that we don't run into situations where the resource we think > we're locking really isn't locked

Re: [libvirt] [PATCH 0/7] Misc improvements

On Mon, Jul 31, 2017 at 08:58:41AM +0200, Martin Kletzander wrote: > On Fri, Jul 28, 2017 at 04:58:57PM +0100, Daniel P. Berrange wrote: > > On Fri, Jul 28, 2017 at 11:47:56AM -0400, John Ferlan wrote: > > > > > > > > > On 07/28/2017 11:24 AM, Daniel P. Be

Re: [libvirt] [PATCH 0/7] Misc improvements

On Fri, Jul 28, 2017 at 11:47:56AM -0400, John Ferlan wrote: > > > On 07/28/2017 11:24 AM, Daniel P. Berrange wrote: > > On Fri, Jul 28, 2017 at 11:09:03AM -0400, John Ferlan wrote: > >> > >> > >> On 07/28/2017 10:32 AM, Martin Kletzander wrote: >

Re: [libvirt] [PATCH 0/7] Misc improvements

On Fri, Jul 28, 2017 at 11:09:03AM -0400, John Ferlan wrote: > > > On 07/28/2017 10:32 AM, Martin Kletzander wrote: > > On Thu, Jul 27, 2017 at 01:47:20PM +0200, Michal Privoznik wrote: > >> As I started to turn more object into using RW locks, I've found > >> couple of > >> areas for

Re: [libvirt] Exposing mem-path in domain XML

On Fri, Jul 28, 2017 at 10:45:21AM +0200, Michal Privoznik wrote: > On 07/27/2017 03:50 PM, Daniel P. Berrange wrote: > > On Thu, Jul 27, 2017 at 02:11:25PM +0200, Michal Privoznik wrote: > >> Dear list, > >> > >> there is the following bug [1] which

Re: [libvirt] [RFC]Add new mdev interface for QoS

On Thu, Jul 27, 2017 at 12:01:58PM -0600, Alex Williamson wrote: > On Thu, 27 Jul 2017 17:17:48 +0100 > "Daniel P. Berrange" <berra...@redhat.com> wrote: > > > On Wed, Jul 26, 2017 at 10:43:43AM -0600, Alex Williamson wrote: > > > [cc +libvir-list] > &g

Re: [libvirt] Entering freeze for libvirt-3.6.0

On Thu, Jul 27, 2017 at 06:14:58PM +0200, Andrea Bolognani wrote: > On Thu, 2017-07-27 at 22:42 +0800, Daniel Veillard wrote: > >   As planned I tagged 3.6.0-rc1 in git and I made the Release Candidate 1 > > signed tarball and rpms available from the usual place: > >  > >   

Re: [libvirt] [RFC]Add new mdev interface for QoS

On Wed, Jul 26, 2017 at 10:43:43AM -0600, Alex Williamson wrote: > [cc +libvir-list] > > On Wed, 26 Jul 2017 21:16:59 +0800 > "Gao, Ping A" wrote: > > > The vfio-mdev provide the capability to let different guest share the > > same physical device through mediate sharing,

Re: [libvirt] [PATCH 00/12] Cleanup website generation & add favicons

On Thu, Jul 27, 2017 at 04:02:35PM +0200, Michal Privoznik wrote: > On 07/26/2017 07:51 PM, Daniel P. Berrange wrote: > > This started as an attempt to add modern favicon support to > > the website. This requires use of HTML5 only syntax, which > > lead to the massive cleanu

Re: [libvirt] Exposing mem-path in domain XML

On Thu, Jul 27, 2017 at 02:11:25PM +0200, Michal Privoznik wrote: > Dear list, > > there is the following bug [1] which I'm not quite sure how to grasp. So > there is this application/infrastructure called Kove [2] that allows you > to have memory for your application stored on a distant host in

[libvirt] [PATCH] tests: add virfilecachedata to EXTRA_DIST

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Pushed as a build fix tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index 8349bbec4..9a822f7d5 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -164,6

Re: [libvirt] [PATCH 2/2] security: apparmor: load the storage driver dynamically

module or just initialize it. > > src/Makefile.am | 2 +- > src/security/virt-aa-helper.c | 10 +- > 2 files changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -

Re: [libvirt] [PATCH RFC 1/2] make: Drop building without driver modules

e.am | 6 -- > tests/testutils.c | 2 - > tools/virsh.c | 3 - > 11 files changed, 21 insertions(+), 310 deletions(-) > Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.f

[libvirt] [PATCH 06/12] docs: remove use of entity

A handful of places in the docs choose to use instead of '-' for no clear reason. Remove this inconsistency. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- docs/formatdomain.html.in | 34 +- docs/formatnetwork.html.in | 2 +- 2 files chang

[libvirt] [PATCH 12/12] docs: add full set of "favicon" files to support modern clients

Use of the relation "shortcut" for a favicon was an Internet Explorer only feature. Other browsers just require "icon". The new icons & metadata are generated using https://realfavicongenerator.net/ which is user tested to work well across all modern clients Signed-of

[libvirt] [PATCH 04/12] docs: fix typo s///

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- docs/hooks.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/hooks.html.in b/docs/hooks.html.in index 7a04ac198..6cc47a6c5 100644 --- a/docs/hooks.html.in +++ b/docs/hooks.html.in @@ -289,7

[libvirt] [PATCH 09/12] docs: generate pretty indented HTML for API docs

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- docs/newapi.xsl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/newapi.xsl b/docs/newapi.xsl index a55736d32..a2f0e0714 100644 --- a/docs/newapi.xsl +++ b/docs/newapi.xsl @@ -814,6 +814,7 @@ @@

[libvirt] [PATCH 11/12] docs: explicitly declare pages as being UTF-8 format

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- docs/page.xsl | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/page.xsl b/docs/page.xsl index 4d49be085..d9be66b93 100644 --- a/docs/page.xsl +++ b/docs/page.xsl @@ -83,6 +83,7 @@ Do not edit this file. C

[libvirt] [PATCH 03/12] docs: make xmllint & xsltproc compulsory

We already require libxml to be installed, so it is not unreasonable to require xmllint and xsltproc to be installed too - any platform with the former will have the latter too. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- docs/Makefile.am

[libvirt] [PATCH 02/12] docs: drop XHTML 1.0 validation of website

to. The only options are to stick with XHTML 1.0 forever, or drop the DTD validation, and we pick the latter. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- .travis.yml | 1 - docs/Makefile.am | 18 +- libvirt.spec.in

[libvirt] [PATCH 07/12] docs: use UTF-8 instead of HTML entities for decorated letters

We have files which use HTML entities for decorating letters with unlauts, accents, etc. Other files just use UTF-8 characters directly for this. Remove the HTML entities since they have no benefit and use UTF-8 instead. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> ---

[libvirt] [PATCH 10/12] docs: remove bogus 'shape' attribute on links

The 'shape' attribute on is used together with a 'coords' attribute to create hot-zones in image maps. We're not using image maps so our inclusion of a 'shape' attribute is bogus. Furthermore this is forbidden in HTML5. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> ---

[libvirt] [PATCH 05/12] docs: remove use of in docs

Some docs pages were using to add arbitrary whitespace in the page. This is something that should be done by CSS if needed, but it is not needed here, so delete it. There was also use of which adds no value at all when we have CSS to prettify tables. Signed-off-by: Daniel P. Berrange <be

[libvirt] [PATCH 00/12] Cleanup website generation & add favicons

This started as an attempt to add modern favicon support to the website. This requires use of HTML5 only syntax, which lead to the massive cleanup to stop using XHTML 1.0, which forms all of this series except the last patch Daniel P. Berrange (12): docs: switch to using 'id' attribute instead

Re: [libvirt] [PATCH] docs: Add build timestamps to generated html/php pages

Kletzander <mklet...@redhat.com> > --- > docs/Makefile.am | 13 + > docs/newapi.xsl | 2 ++ > docs/page.xsl| 4 > docs/site.xsl| 1 + > docs/subsite.xsl | 1 + > 5 files changed, 17 insertions(+), 4 deletions(-) Reviewed-by: Daniel P. Berr

Re: [libvirt] [PATCH glib] Don't set LC_ALL=C during build as that breaks python apps

On Tue, Jul 25, 2017 at 06:16:49PM +0200, Philipp Hahn wrote: > Hello, > > Am 25.07.2017 um 14:07 schrieb Daniel P. Berrange: > > Setting LC_ALL=C breaks python apps doing I/O on UTF-8 source > > files. In particular this broke glib-mkenums > > > > GEN

[libvirt] [PATCH glib] Don't set LC_ALL=C during build as that breaks python apps

(128) Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Pushed to fix rawhide build maint.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/maint.mk b/maint.mk index 405c6d0..ef72b4f 100644 --- a/maint.mk +++ b/maint.mk @@ -117,8 +117,8 @@ news-check-l

Re: [libvirt] [PATCH] Revert "virthread: Introduce virRWLockInitPreferWriter"

ywhere else. Revert this and if the starvation occurs > resolve it. > > Signed-off-by: Michal Privoznik <mpriv...@redhat.com> Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberra

Re: [libvirt] [PATCH 1/3] virthread: Introduce virRWLockInitPreferWriter

On Mon, Jul 24, 2017 at 01:12:59PM -0400, John Ferlan wrote: > > > On 07/19/2017 10:31 AM, Michal Privoznik wrote: > > We already have virRWLockInit. But this uses pthread defaults > > which prefer reader to initialize the RW lock. This may lead to > > writer starvation. Therefore we need to

Re: [libvirt] [PATCH] libvirt-domain.h: Fix enum description placement

On Fri, Jul 21, 2017 at 04:33:06PM +0200, Jiri Denemark wrote: > On Fri, Jul 21, 2017 at 14:42:05 +0100, Daniel P. Berrange wrote: > > On Fri, Jul 21, 2017 at 03:00:20PM +0200, Martin Kletzander wrote: > > > > struct meh { > > > /*# This is commen

Re: [libvirt] [PATCH] libvirt-domain.h: Fix enum description placement

On Fri, Jul 21, 2017 at 03:00:20PM +0200, Martin Kletzander wrote: > On Fri, Jul 21, 2017 at 11:58:45AM +0100, Daniel P. Berrange wrote: > > On Fri, Jul 21, 2017 at 12:52:06PM +0200, Michal Privoznik wrote: > > > There are only two acceptable places for describing enum values.

Re: [libvirt] [PATCH] docs: fix documentation of enum constants

On Fri, Jul 21, 2017 at 01:03:13PM +0200, Michal Privoznik wrote: > On 07/21/2017 01:01 PM, Daniel P. Berrange wrote: > > On Fri, Jul 21, 2017 at 12:58:55PM +0200, Michal Privoznik wrote: > >> > >> Yeah. Our generator is not that great. I wish that we'd switch to

Re: [libvirt] [PATCH] docs: fix documentation of enum constants

On Fri, Jul 21, 2017 at 12:58:55PM +0200, Michal Privoznik wrote: > On 07/21/2017 12:25 PM, Tomáš Golembiovský wrote: > > On Fri, 21 Jul 2017 10:12:38 +0200 > > Michal Privoznik wrote: > > > >> On 07/20/2017 08:21 PM, Tomáš Golembiovský wrote: > >>> The documentation string

Re: [libvirt] [PATCH] libvirt-domain.h: Fix enum description placement

virt-domain.h | 17 + > 1 file changed, 9 insertions(+), 8 deletions(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https

Re: [libvirt] [PATCH] docs: fix documentation of enum constants

On Fri, Jul 21, 2017 at 12:25:02PM +0200, Tomáš Golembiovský wrote: > On Fri, 21 Jul 2017 10:12:38 +0200 > Michal Privoznik wrote: > > > On 07/20/2017 08:21 PM, Tomáš Golembiovský wrote: > > > The documentation string has to follow the definition of a constant in > > > the

Re: [libvirt] [PATCH] docs: fix documentation of enum constants

On Fri, Jul 21, 2017 at 10:12:38AM +0200, Michal Privoznik wrote: > On 07/20/2017 08:21 PM, Tomáš Golembiovský wrote: > > The documentation string has to follow the definition of a constant in > > the enum. Otherwise, the HTML documentation will be generated > > incorrectly. > > > >

Re: [libvirt] [PATCH v1] numa: compute and set matching vcpus for numa domains

On Thu, Jul 20, 2017 at 03:03:25PM +0200, Wim ten Have wrote: > On Thu, 20 Jul 2017 11:10:31 +0100 > "Daniel P. Berrange" <berra...@redhat.com> wrote: > > > On Thu, Jul 20, 2017 at 11:29:26AM +0200, Wim Ten Have wrote: > > > From: Wim ten Have <wim

Re: [libvirt] [PATCH v1] numa: compute and set matching vcpus for numa domains

On Thu, Jul 20, 2017 at 11:29:26AM +0200, Wim Ten Have wrote: > From: Wim ten Have > > The QEMU driver can erroneously allocate more vpus to a domain > than there are cpus in the domain if the element is used > to describe element topology. Fix this by calculating >

Re: [libvirt] [PATCH go-xml] Add support for NAT in network forward

On Wed, Jul 12, 2017 at 01:26:03PM +0200, Thomas Hipp wrote: > Add support for NAT in network forward, and add test code. > > Signed-off-by: Thomas Hipp > --- > network.go | 20 ++-- > network_test.go | 31 +-- > 2 files changed,

Re: [libvirt] [PATCH go-xml] Add support for DNS in network

On Wed, Jul 12, 2017 at 03:28:13PM +0200, Thomas Hipp wrote: > Add support for DNS in network, and add test code. > > Signed-off-by: Thomas Hipp > --- > network.go | 39 ++ > network_test.go | 65 >

Re: [libvirt] [PATCH RESEND] qemu: shared disks with cache=directsync should be safe for migration

; 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> and pushed to git master Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fsto

[libvirt] [PATCH jenkins-ci] Put all RPM build files in GIT checkout build dir

the RPM files from previous builds preventing disk usage growing without bound. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Pushed to fix the CI system jobs/autotools.yaml| 2 +- jobs/perl-makemaker.yaml | 2 +- jobs/perl-modulebuild.yaml | 2 +- 3 files chan

<    1   2   3   4   5   6   7   8   9   10   >