From: Hyman
QEMU introduced a dirty ring feature, this patch add a new
KVM feature 'dirty-ring' to set this feature for kvm guests.
To enable the feature, libvirt add "-accel dirty_gfn_count=xxx"
to QEMU command line, the following XML needs to be added to
the guest's domain description:
From: Hyman
QEMU introduced a dirty ring feature, this patch add a new
KVM feature 'dirty-ring' to set this feature for kvm guests.
To enable the feature, libvirt add "-accel dirty-gfn-count=xxx"
to QEMU command line, the following XML needs to be added to
the guest's domain description:
From: Hyman
This is v1 of Dirty ring support of Libvirt. It is merely the same as v0, but
fix the parameter dirty-gfn-count passed to QEMU command line. A previous
implementation was patched by me mistakenly.
This series of patches is a supplement of dirty ring implementation for Libvirt:
From: Hyman
This series of patches is a supplement of dirty ring implementation in Libvirt:
https://lore.kernel.org/qemu-devel/20210108165050.406906-10-pet...@redhat.com/
Since QEMU enable the dirty ring feature by specifying the "-accel"
sub-parameter.
Libvirt use "-machine accel=xxx" option
From: Hyman
QEMU introduced a dirty ring feature, this patch add a new
KVM feature 'dirty-ring' to set this feature for kvm guests.
To enable the feature, libvirt add "-accel dirty-gfn-count=xxx"
to QEMU command line, the following XML needs to be added to
the guest's domain description:
From: Hyman
The v2 of Dirty ring support of Libvirt just and an empty function of
'qemuBuildAccelCommandLineTcgOptions' and do some code clen, if things
go smoothly, the tcg accelerator property may be support in the future,
this empty function give a hint to do that.
This is v1 of Dirty ring
From: Hyman
The v4 of Dirty Ring just fix args file in testsuite which has
'No-newline-at-end-of-file' and mak it a stand-alone patch.
The following is detail:
https://www.redhat.com/archives/libvir-list/2021-January/msg00626.html
The v3 of Dirty Ring do some modification based on the
From: Hyman
The test file disk-backing-chains-noindex.x86_64-latest.args has
'No newline at end of file', this patch rewrite it in case unexpected
behavior bewteen diffrent platform. See the details:
https://www.redhat.com/archives/libvir-list/2021-January/msg00626.html
Signed-off-by: Hyman
From: Hyman
QEMU introduced a dirty ring feature, this patch add a new
KVM feature 'dirty-ring' to set this feature for kvm guests.
To enable the feature, libvirt add "-accel dirty-gfn-count=xxx"
to QEMU command line, the following XML needs to be added to
the guest's domain description:
From: Hyman
The "-machine" options for accelerators are legacy, the "-accel" options
is a better mechanism. The following are the details:
https://lore.kernel.org/qemu-devel/3aa73987-40e8-3619-0723-9f17f7385...@redhat.com/
This patch introduce QEMU_CAPS_ACCEL capability to tell if we're dealing
From: Hyman
The v5 of Dirty Ring correct the mistake introduced in v3 patch.
Which using the shell script to modify the hundereds of test cases
in qemuxml2argvdata directory, and do not take the symlink into
account. The following is detail:
From: Hyman
The "-machine" options for accelerators are legacy, the "-accel" options
is a better mechanism. The following are the details:
https://lore.kernel.org/qemu-devel/3aa73987-40e8-3619-0723-9f17f7385...@redhat.com/
This patch introduce QEMU_CAPS_ACCEL capability to tell if we're dealing
From: Hyman
QEMU introduced a dirty ring feature, this patch add a new
KVM feature 'dirty-ring' to set this feature for kvm guests.
To enable the feature, libvirt add "-accel dirty-gfn-count=xxx"
to QEMU command line, the following XML needs to be added to
the guest's domain description:
From: Hyman
The "-machine" options for accelerators are legacy, the "-accel" options
is a better mechanism. The following are the details:
https://lore.kernel.org/qemu-devel/3aa73987-40e8-3619-0723-9f17f7385...@redhat.com/
This patch introduce QEMU_CAPS_ACCEL capability to tell if we're dealing
From: Hyman
This patchset aims to support dirty ring feature which has been introduced
in kernel:
https://lore.kernel.org/lkml/8b3f68dd-c61c-16a0-2077-0a5d3d57a...@redhat.com/
The QEMU patchset is also being applied for merge, the review may be under
the way:
From: Hyman
QEMU introduced a dirty ring feature, this patch add a new
KVM feature 'dirty-ring' to set this feature for kvm guests.
To enable the feature, libvirt add "-accel dirty-gfn-count=xxx"
to QEMU command line, the following XML needs to be added to
the guest's domain description:
From: Hyman
The v3 of Dirty Ring do some modification based on the following discussion:
https://www.redhat.com/archives/libvir-list/2021-January/msg00531.html
https://www.redhat.com/archives/libvir-list/2021-January/msg00520.html
modification 1: introducing the QEMU_CAPS_ACCEL so that we can
From: Hyman
The "-machine" options for accelerators are legacy, the "-accel" options
is a better mechanism. The following are the details:
https://lore.kernel.org/qemu-devel/3aa73987-40e8-3619-0723-9f17f7385...@redhat.com/
This patch introduce QEMU_CAPS_ACCEL capability to tell if we're dealing
From: Hyman Huang(黄勇)
Since the "-machine" option for accelerators is legacy, "-accel" option
may be a better mechanism. following are details:
https://lore.kernel.org/qemu-devel/3aa73987-40e8-3619-0723-9f17f7385...@redhat.com/
This patch introduce QEMU_CAPS_ACCEL capability to tell if we're
From: Hyman Huang(黄勇)
since qemu has introduced a dirty ring feature in 6.1.0, may be it's
the right time to introduce dirty ring in libvirt meanwhile.
this patch add feature named 'dirty-ring', which enable dirty ring
feature when starting vm. to try this out, three things has done
in this
From: Hyman Huang(黄勇)
introduce dirty_ring_size to hold the ring size configured
by user, and pass dirty_ring_size when building qemu commandline
if dirty ring feature enabled.
Signed-off-by: Hyman Huang(黄勇)
---
src/conf/domain_conf.c | 78 +
From: Hyman Huang(黄勇)
QEMU has introduced a dirty ring feature, this patch add
corresponding feature named 'dirty-ring', which enable
dirty ring feature when starting vm.
to enable the feature, libvirt add "-accel dirty-ring-size=xxx"
to QEMU command line, the following XML needs to be added to
From: Hyman Huang(黄勇)
v2
- split patchset into 4 patches
- leave out the tcg case when building commandline.
- handle the VIR_DOMAIN_KVM_DIRTY_RING case independently in ,
virDomainFeatureDefParse and virDomainDefFeaturesCheckABIStability,
do not integrate it with other cases...
- add
From: Hyman Huang(黄勇)
since the "-machine" option for accelerators is legacy, "-accel" option
may be a better mechanism. following are details:
https://lore.kernel.org/qemu-devel/3aa73987-40e8-3619-0723-9f17f7385...@redhat.com/
this patch introduce QEMU_CAPS_ACCEL capability to tell if we're
From: Hyman Huang(黄勇)
QEMU greater than 2.9.0 support '-accel' option, change the way
of assembling commandline from "accel=kvm" to "-accel kvm" when
specifying accelerator.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_command.c| 31 +-
From: Hyman Huang(黄勇)
since the "-machine" option for accelerators is legacy, "-accel" option
may be a better mechanism. following are details:
https://lore.kernel.org/qemu-devel/3aa73987-40e8-3619-0723-9f17f7385...@redhat.com/
this patch introduce QEMU_CAPS_ACCEL capability to tell if we're
From: Hyman Huang(黄勇)
QEMU has introduced a dirty ring feature, this patch add
corresponding feature named 'dirty-ring', which enable
dirty ring feature when starting vm.
to enable the feature, libvirt add "-accel dirty-ring-size=xxx"
to QEMU command line, the following XML needs to be added to
From: Hyman Huang(黄勇)
v3
- rebase master and fix the confilict when apply
"conf: introduce dirty_ring_size in struct "_virDomainDef" to current
master.
v2
- split patchset into 4 patches
- leave out the tcg case when building commandline.
- handle the VIR_DOMAIN_KVM_DIRTY_RING case
From: Hyman Huang(黄勇)
QEMU greater than 2.9.0 support '-accel' option, change the way
of assembling commandline from "accel=kvm" to "-accel kvm" when
specifying accelerator.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_command.c| 31 +-
From: Hyman Huang(黄勇)
introduce dirty_ring_size to hold the ring size configured
by user, and pass dirty_ring_size when building qemu commandline
if dirty ring feature enabled.
Signed-off-by: Hyman Huang(黄勇)
---
src/conf/domain_conf.c | 74 -
From: Chongyun Wu
pointer disk might be null in some special cases or new
usage scenarios, therefore code protection is needed to
prevent segment faults.
Signed-off-by: Chongyun Wu
---
src/qemu/qemu_blockjob.c | 43 ---
1 file changed, 24 insertions(+),
From: "Hyman Huang(黄勇)"
v7
- rebase on master
- modify the following points according to the advice given by Peter
1. skip the -accel switch and reuse the existing commit d20ebdda2
'qemu: Switch to -accel'
2. remove the post-parse function and do the parse work in
From: Hyman Huang(黄勇)
Dirty ring feature was introduced in qemu-6.1.0, this patch
add the corresponding feature named 'dirty-ring', which enable
dirty ring feature when starting vm.
To implement the dirty-ring feature, dirty_ring_size in struct
"_virDomainDef" is introduced to hold the dirty
From: Hyman Huang(黄勇)
Update the KVM feature tests for dirty ring.
Signed-off-by: Hyman Huang(黄勇)
---
tests/qemuxml2argvdata/kvm-features-off.xml | 1 +
tests/qemuxml2argvdata/kvm-features.args | 2 +-
tests/qemuxml2argvdata/kvm-features.xml | 1 +
From: Hyman Huang(黄勇)
QEMU greater than 2.9.0 support '-accel' option, change the way
of assembling commandline from "accel=kvm" to "-accel kvm" when
specifying accelerator.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_command.c | 31 ++-
From: Hyman Huang(黄勇)
introduce dirty_ring_size in struct "_virDomainDef" to hold
the ring size configured by user, and pass dirty_ring_size
when building qemu commandline if dirty ring feature enabled.
Signed-off-by: Hyman Huang(黄勇)
---
src/conf/domain_conf.c | 76
From: Hyman Huang(黄勇)
since the "-machine" option for accelerators is legacy, "-accel" option
may be a better mechanism. following are details:
https://lore.kernel.org/qemu-devel/3aa73987-40e8-3619-0723-9f17f7385...@redhat.com/
this patch introduce QEMU_CAPS_ACCEL capability to tell if we're
From: Hyman Huang(黄勇)
dirty ring feature was introduced in qemu-6.1, this patch add
corresponding feature named 'dirty-ring', which enable
dirty ring feature when starting vm.
to enable the feature, libvirt add "-accel dirty-ring-size=xxx"
to QEMU command line, the following XML needs to be
From: "Hyman Huang(黄勇)"
Ping for this series.
I still keep thinking the dirty ring feature is something good to
have for libvirt.
qemu-6.1 has supported dirty ring feature and followed up with the
commit 0e21bf24 "support dirtyrate at the granualrity of vcpu",
which is a typical usage scenario
From: Hyman Huang(黄勇)
When compile libvirt via ninja tool with default configuration,
it report the error message as the following:
"missing initializer for field 'path' of 'virTPMBinaryInfo'".
So initialize the 'path' field in 'virTPMBinaryInfo' with 'NULL'.
Signed-off-by: Hyman Huang(黄勇)
---
From: Hyman Huang(黄勇)
The Libvirt API virDomainStartDirtyRateCalc was extended.
Document this change.
Signed-off-by: Hyman Huang(黄勇)
---
NEWS.rst | 14 ++
1 file changed, 14 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index f545325..b684416 100644
--- a/NEWS.rst
+++ b/NEWS.rst
From: Hyman Huang(黄勇)
Introduce virDomainDirtyRateCalcFlags to get ready for
adding mode parameter to qemuDomainStartDirtyRateCalc.
Signed-off-by: Hyman Huang(黄勇)
---
include/libvirt/libvirt-domain.h | 13 +
1 file changed, 13 insertions(+)
diff --git
From: Hyman Huang(黄勇)
mode option of calc-dirty-rate command since qemu >=6.2.0.
Introduce QEMU_CAPS_DIRTYRATE_MODE capability definition.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
From: Hyman Huang(黄勇)
Extend domdirtyrate-calc virsh api with mode option, either
of these three options "page-sampling,dirty-bitmap,dirty-ring"
can be specified when calculating dirty page rate.
Signed-off-by: Hyman Huang(黄勇)
---
docs/manpages/virsh.rst| 7 +--
From: Hyman Huang(黄勇)
v6:
- rebase on mastr
- drop the commit [PATCH v5 1/9] in this patchset, post an extra
commit if needed in the future.
Please review, thanks !
Regards
Yong
v5:
- [PATCH v5 9/9]: Fix alignment error in qemuDomainGetStatsDirtyRate.
v4:
- Rebase the master
- [PATCH v4
From: Hyman Huang(黄勇)
Probing QEMU_CAPS_CALC_DIRTY_RATE capability in advance
in case of failure when calculating dirty page rate.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_driver.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c
From: Hyman Huang(黄勇)
Add mode parameter to qemuDomainStartDirtyRateCalc API, 'mode'
option of 'calc-dirty-rate' command was introduced since
qemu >= 6.2.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_driver.c | 3 ++-
src/qemu/qemu_monitor.c | 5 +++--
src/qemu/qemu_monitor.h
From: Hyman Huang(黄勇)
Add calc_mode for dirtyrate statistics retured by
virsh domstats --dirtyrate api, also add vcpu dirtyrate
if dirty-ring mode was used in last measurement.
Signed-off-by: Hyman Huang(黄勇)
---
src/libvirt-domain.c | 6 +
src/qemu/qemu_driver.c | 22
From: Hyman Huang(黄勇)
Extend flags parameter of virDomainStartDirtyRateCalc as a
superset of virDomainDirtyRateCalcFlags, parse the flags and
handle it correspondingly in qemuDomainStartDirtyRateCalc.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_driver.c | 23 ++-
1
From: Hyman Huang(黄勇)
calc-dirty-rate command was introduced since qemu >=5.2.0.
Introduce QEMU_CAPS_CALC_DIRTY_RATE capability definition.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
From: Hyman Huang(黄勇)
Add calc_mode for dirtyrate statistics retured by
virsh domstats --dirtyrate api, also add vcpu dirtyrate
if dirty-ring mode was used in last measurement.
Signed-off-by: Hyman Huang(黄勇)
---
src/libvirt-domain.c | 6 +
src/qemu/qemu_driver.c | 22
From: Hyman Huang(黄勇)
calc-dirty-rate command was introduced since qemu >=5.2.0.
Introduce QEMU_CAPS_CALC_DIRTY_RATE capability definition.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
From: Hyman Huang(黄勇)
Add mode parameter to qemuDomainStartDirtyRateCalc API, 'mode'
option of 'calc-dirty-rate' command was introduced since
qemu >= 6.2.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_driver.c | 3 ++-
src/qemu/qemu_monitor.c | 5 +++--
src/qemu/qemu_monitor.h
From: Hyman Huang(黄勇)
Extend domdirtyrate-calc virsh api with mode option, either
of these three options "page-sampling,dirty-bitmap,dirty-ring"
can be specified when calculating dirty page rate.
Signed-off-by: Hyman Huang(黄勇)
---
docs/manpages/virsh.rst| 7 +--
From: Hyman Huang(黄勇)
v4:
- Rebase the master
- [PATCH v4 1/9]: Refactor dirty page rate calculation status
implementation, display calc_status as string when
'virsh domstats --dirtyrate' api return.
- [PATCH v4 3/9]: Adjust the 'cap check' block before
From: Hyman Huang(黄勇)
For any virTypedParameter API normal practice is to use a string
to expose the data, not the rather enum integer value.
So let's drop the virDomainDirtyRateStatus in public header file
and introduce internal enum def qemuMonitorDirtyRateStatus to
describe the dirty page
From: Hyman Huang(黄勇)
mode option of calc-dirty-rate command since qemu >=6.2.0.
Introduce QEMU_CAPS_DIRTYRATE_MODE capability definition.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
From: Hyman Huang(黄勇)
Introduce virDomainDirtyRateCalcFlags to get ready for
adding mode parameter to qemuDomainStartDirtyRateCalc.
Signed-off-by: Hyman Huang(黄勇)
---
include/libvirt/libvirt-domain.h | 13 +
1 file changed, 13 insertions(+)
diff --git
From: Hyman Huang(黄勇)
Probing QEMU_CAPS_CALC_DIRTY_RATE capability in advance
in case of failure when calculating dirty page rate.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_driver.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c
From: Hyman Huang(黄勇)
Extend flags parameter of virDomainStartDirtyRateCalc as a
superset of virDomainDirtyRateCalcFlags, parse the flags and
handle it correspondingly in qemuDomainStartDirtyRateCalc.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_driver.c | 23 ++-
1
From: Hyman Huang(黄勇)
For any virTypedParameter API normal practice is to use a string
to expose the data, not the rather enum integer value.
So let's drop the virDomainDirtyRateStatus in public header file
and introduce internal enum def qemuMonitorDirtyRateStatus to
describe the dirty page
From: Hyman Huang(黄勇)
v5:
- [PATCH v5 9/9]: Fix alignment error in qemuDomainGetStatsDirtyRate.
v4:
- Rebase the master
- [PATCH v4 1/9]: Refactor dirty page rate calculation status
implementation, display calc_status as string when
'virsh domstats
From: Hyman Huang(黄勇)
Introduce virDomainDirtyRateCalcFlags to get ready for
adding mode parameter to qemuDomainStartDirtyRateCalc.
Signed-off-by: Hyman Huang(黄勇)
---
include/libvirt/libvirt-domain.h | 13 +
1 file changed, 13 insertions(+)
diff --git
From: Hyman Huang(黄勇)
Add mode parameter to qemuDomainStartDirtyRateCalc API, 'mode'
option of 'calc-dirty-rate' command was introduced since
qemu >= 6.2.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_driver.c | 3 ++-
src/qemu/qemu_monitor.c | 5 +++--
src/qemu/qemu_monitor.h
From: Hyman Huang(黄勇)
Extend domdirtyrate-calc virsh api with mode option, either
of these three options "page-sampling,dirty-bitmap,dirty-ring"
can be specified when calculating dirty page rate.
Signed-off-by: Hyman Huang(黄勇)
---
docs/manpages/virsh.rst| 7 +--
From: Hyman Huang(黄勇)
calc-dirty-rate command was introduced since qemu >=5.2.0.
Introduce QEMU_CAPS_CALC_DIRTY_RATE capability definition.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
From: Hyman Huang(黄勇)
Extend flags parameter of virDomainStartDirtyRateCalc as a
superset of virDomainDirtyRateCalcFlags, parse the flags and
handle it correspondingly in qemuDomainStartDirtyRateCalc.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_driver.c | 23 ++-
1
From: Hyman Huang(黄勇)
mode option of calc-dirty-rate command since qemu >=6.2.0.
Introduce QEMU_CAPS_DIRTYRATE_MODE capability definition.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
From: Hyman Huang(黄勇)
Add calc_mode for dirtyrate statistics retured by
virsh domstats --dirtyrate api, also add vcpu dirtyrate
if dirty-ring mode was used in last measurement.
Signed-off-by: Hyman Huang(黄勇)
---
src/libvirt-domain.c | 6 +
src/qemu/qemu_driver.c | 22
From: Hyman Huang(黄勇)
Probing QEMU_CAPS_CALC_DIRTY_RATE capability in advance
in case of failure when calculating dirty page rate.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_driver.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c
From: Hyman Huang(黄勇)
calc-dirty-rate command was introduced since qemu >=5.2.0.
Introduce QEMU_CAPS_CALC_DIRTY_RATE capability definition.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
From: Hyman Huang(黄勇)
Introduce virDomainDirtyRateCalcFlags and
virDomainDirtyRateCalcMode to get ready for adding mode
parameter to qemuDomainStartDirtyRateCalc.
Signed-off-by: Hyman Huang(黄勇)
---
include/libvirt/libvirt-domain.h | 24
1 file changed, 24
From: Hyman Huang(黄勇)
mode option of calc-dirty-rate command since qemu >=6.2.0.
Introduce QEMU_CAPS_DIRTYRATE_MODE capability definition.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
From: Hyman Huang(黄勇)
Extend domdirtyrate-calc virsh api with mode option, either
of these three options "page-sampling,dirty-bitmap,dirty-ring"
can be specified when calculating dirty page rate.
Signed-off-by: Hyman Huang(黄勇)
---
docs/manpages/virsh.rst | 7 +--
src/libvirt-domain.c
From: Hyman Huang(黄勇)
Add calc_mode for dirtyrate statistics retured by
virsh domstats --dirtyrate api, also add vcpu dirtyrate
if dirty-ring mode was used in last measurement.
Signed-off-by: Hyman Huang(黄勇)
---
src/libvirt-domain.c | 5 +
src/qemu/qemu_driver.c | 14
From: Hyman Huang(黄勇)
Add mode parameter to qemuDomainStartDirtyRateCalc API, 'mode'
option of 'calc-dirty-rate' command was introduced since
qemu >= 6.2.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_driver.c | 4 +++-
src/qemu/qemu_monitor.c | 5 +++--
From: Hyman Huang(黄勇)
v3:
- Rebase the master
- [PATCH v2 2/6]: Fix the usage of virQEMUCapsGet
- [PATCH v2 4/6]: Fix the cleanup missed in qemuDomainStartDirtyRateCalc
- [PATCH v2 4/6]: Move all blocks below ACL check
- [PATCH v2 4/6]: Make the qemuMonitorJSONStartDirtyRateCalc cleaner by
From: Hyman Huang(黄勇)
Probing QEMU_CAPS_CALC_DIRTY_RATE capability in advance
in case of failure when calculating dirty page rate.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_driver.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/qemu/qemu_driver.c
From: Hyman Huang(黄勇)
calc-dirty-rate command was introduced since qemu >=5.2.0.
Introduce QEMU_CAPS_CALC_DIRTY_RATE capability definition.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
From: Hyman Huang(黄勇)
Add calc_mode for dirtyrate statistics retured by
virsh domstats --dirtyrate api, also add vcpu dirtyrate
if dirty-ring mode was used in last measurement.
Signed-off-by: Hyman Huang(黄勇)
---
src/libvirt-domain.c | 5 +
src/qemu/qemu_driver.c | 14
From: Hyman Huang(黄勇)
Add mode option to extend qemuDomainStartDirtyRateCalc API,
which is introduced since qemu >= 6.2.
Signed-off-by: Hyman Huang(黄勇)
---
include/libvirt/libvirt-domain.h | 13 +
src/qemu/qemu_driver.c | 33 +++--
From: Hyman Huang(黄勇)
v2:
Rebase master and fix confilicts with commit
"Introduce QEMU_CAPS_DEVICE_VIRTIO_MEM_PCI_PREALLOC"
Thanks !
v1:
This patchset introduce mode option as the supplement of
qemuDomainStartDirtyRateCalc api, add calc_mode for dirtyrate
statistics correspondingly.
Qemu add
From: Hyman Huang(黄勇)
Extend domdirtyrate-calc virsh api with mode option, either
of these three options "page-sampling,dirty-bitmap,dirty-ring"
can be specified when calculating dirty page rate.
Signed-off-by: Hyman Huang(黄勇)
---
docs/manpages/virsh.rst | 7 +--
src/libvirt-domain.c
From: Hyman Huang(黄勇)
Probing QEMU_CAPS_CALC_DIRTY_RATE capability in advance
in case of failure when calculating dirty page rate.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_driver.c | 12
1 file changed, 12 insertions(+)
diff --git a/src/qemu/qemu_driver.c
From: Hyman Huang(黄勇)
mode option of calc-dirty-rate command since qemu >=6.2.0.
Introduce QEMU_CAPS_DIRTYRATE_MODE capability definition.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
From: Hyman Huang(黄勇)
Add mode option to extend qemuDomainStartDirtyRateCalc API,
which is introduced since qemu >= 6.2.
Signed-off-by: Hyman Huang(黄勇)
---
include/libvirt/libvirt-domain.h | 13 +
src/qemu/qemu_driver.c | 33 +++--
From: Hyman Huang(黄勇)
calc-dirty-rate command was introduced since qemu >=5.2.0.
Introduce QEMU_CAPS_CALC_DIRTY_RATE capability definition.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
From: Hyman Huang(黄勇)
mode option of calc-dirty-rate command since qemu >=6.2.0.
Introduce QEMU_CAPS_DIRTYRATE_MODE capability definition.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
From: Hyman Huang(黄勇)
Add calc_mode for dirtyrate statistics retured by
virsh domstats --dirtyrate api, also add vcpu dirtyrate
if dirty-ring mode was used in last measurement.
Signed-off-by: Hyman Huang(黄勇)
---
src/libvirt-domain.c | 5 +
src/qemu/qemu_driver.c | 14
From: Hyman Huang(黄勇)
Extend domdirtyrate-calc virsh api with mode option, either
of these three options "page-sampling,dirty-bitmap,dirty-ring"
can be specified when calculating dirty page rate.
Signed-off-by: Hyman Huang(黄勇)
---
docs/manpages/virsh.rst | 7 +--
src/libvirt-domain.c
From: Hyman Huang(黄勇)
Probing QEMU_CAPS_CALC_DIRTY_RATE capability in advance
in case of failure when calculating dirty page rate.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_driver.c | 12
1 file changed, 12 insertions(+)
diff --git a/src/qemu/qemu_driver.c
From: Hyman Huang(黄勇)
v1:
This patchset introduce mode option as the supplement of
qemuDomainStartDirtyRateCalc api, add calc_mode for dirtyrate
statistics correspondingly.
Qemu add mode parameter for calc-dirty-rate command since >= 6.2.0,
either of these three mode "page-sampling,
From: Hyman Huang(黄勇)
Extend qemuDomainGetVcpus for getting dirtylimit info so that
'virsh vcpuinfo' api can display vcpu dirty page rate limit.
Signed-off-by: Hyman Huang(黄勇)
---
include/libvirt/libvirt-domain.h | 2 ++
src/qemu/qemu_driver.c | 62
From: Hyman Huang(黄勇)
Implement qemuDomainSetVcpuDirtyLimit which set dirty page
rate limit.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_driver.c | 47
src/qemu/qemu_monitor.c | 13
src/qemu/qemu_monitor.h | 5
From: Hyman Huang(黄勇)
Add cancel option to vcpudirtylimit api to cancel dirty
page rate limit for virtual CPUs.
Signed-off-by: Hyman Huang(黄勇)
---
tools/virsh-domain.c | 64
1 file changed, 44 insertions(+), 20 deletions(-)
diff --git
From: Hyman Huang(黄勇)
Extend vcpuinfo api so that 'virsh vcpuinfo domain'
can display dirtylimit info for active virtual cpu,
which can be set by using 'virsh vcpudirtylimit'.
Signed-off-by: Hyman Huang(黄勇)
---
src/remote/remote_daemon_dispatch.c | 2 ++
src/remote/remote_driver.c |
From: Hyman Huang(黄勇)
Introduce virDomainSetVcpuDirtyLimit API to set upper limit
of dirty page rate.
Signed-off-by: Hyman Huang(黄勇)
---
include/libvirt/libvirt-domain.h | 16 +
src/driver-hypervisor.h | 7 ++
src/libvirt-domain.c | 51
From: Hyman Huang(黄勇)
Introduce virDomainCancelVcpuDirtyLimit API to cancel
upper limit of dirty page rate.
Signed-off-by: Hyman Huang(黄勇)
---
include/libvirt/libvirt-domain.h | 4
src/driver-hypervisor.h | 6 ++
src/libvirt-domain.c | 43
From: Hyman Huang(黄勇)
Implement qemuDomainCancelVcpuDirtyLimit to cancel
vcpu dirty page rate limit.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_driver.c | 47
src/qemu/qemu_monitor.c | 11 +++
src/qemu/qemu_monitor.h |
From: Hyman Huang(黄勇)
set-vcpu-dirty-limit/cancel-vcpu-dirty-limit/query-vcpu-dirty-limit
were introduced since qemu >=7.1.0. Introduce corresponding
capability.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h
1 - 100 of 116 matches
Mail list logo
