Hi, Michal:
Do you mean we should also remove "if (!priv->prDaemonRunning)" in
qemuProcessKillManagedPRDaemon ? I don't understand why do that, can you
tell me more details?
On 2019/5/30 18:22, Michal Privoznik wrote:
On 5/29/19 11:44 AM, Jie Wang wrote:
if libvirt receive DISCONNECTED
Hi, Michal:
Sorry, I don't think out which case make us to do that, what are
the risks? can you give me an example?
On 2019/5/31 15:21, Michal Privoznik wrote:
On 5/31/19 9:19 AM, wangjie (P) wrote:
Hi, Michal:
Do you mean we should also remove "if (!priv->prDaemo
Thanks，Michal
I understand what you mean， and I have sent the second patch “PATCH
v2”，please review it. :)
Jie
On 2019/5/31 16:55, Michal Privoznik wrote:
On 5/31/19 10:06 AM, wangjie (P) wrote:
Hi, Michal:
Sorry, I don't think out which case make us to do that, what
Ping
On 2019/6/18 21:28, Jie Wang wrote:
when a disk without PR perform attach or detach operation,
need not call qemuHotplugRemoveManagedPR, otherwise, it will
print err log about PR, let us fix it.
Signed-off-by: Jie Wang
---
src/qemu/qemu_hotplug.c | 7 +--
1 file changed, 5
Ping
On 2019/5/31 15:33, Jie Wang wrote:
If libvirt receive DISCONNECTED event and set prDaemonRunning to false,
and qemuDomainRemoveDiskDevice is performing in the meantime.
qemuDomainRemoveDiskDevice will return directly by prDaemonRunning
check, so the pr-helper0 object will remain.
In that
On 2019/6/19 14:16, Peter Krempa wrote:
On Tue, Jun 18, 2019 at 21:28:26 +0800, Jie Wang wrote:
when a disk without PR perform attach or detach operation,
need not call qemuHotplugRemoveManagedPR, otherwise, it will
print err log about PR, let us fix it.
Could you please elaborate which error
bug reproduce process:
1、perform migrateToURI3.
2、kill libvirtd when enter memory migration phase，and restart libvirtd.
3、perform migrateToURI3 again and again，migrateToURI3 will fail forever with
err-msg "Requested operation is not valid: domain has active block job"
I found the reasion which
I think current master had lost the ability of the followed patch:
https://github.com/libvirt/libvirt/commit/e8f263e0d006390c3764aaa07093b2d174b61379
On 2021/9/21 0:52, wangjie (P) wrote:
> bug reproduce process:
> 1、perform migrateToURI3.
> 2、kill libvirtd when enter memory migrat
