Re: [libvirt] libvirt-python: memory leak after GetXMLDesc?

2014-09-12 Thread Alex Jia
Hi Jun'ichi, Which are libvirt version and OS you're using? I also found a leak of XMLDesc() via valgrind, I think the generator should fix this, but you may wait for developers reply, thanks for reporting this. valgrind ==14265== 2,407 bytes in 1 blocks are definitely lost in loss record

Re: [libvirt] [PATCH] daemon: Enhance documentation for changinging NOFILE limit

2014-02-10 Thread Alex Jia
BTW, I filed a similar bug 1059518 for LXC guide. -- Regards, Alex - Original Message - From: Eric Blake ebl...@redhat.com To: libvir-list@redhat.com Sent: Tuesday, February 11, 2014 12:51:23 AM Subject: Re: [libvirt] [PATCH] daemon: Enhance documentation for changinging NOFILE

Re: [libvirt] [PATCH] po/zh_CN.po : Fix 2 Chinese typo

2013-12-04 Thread Alex Jia
Hi taget, In fact, there are many Chinese translation questions in po/zh_CN.po, the following is a example, if you can help fix them together, it will be great! msgid UNIX domain sockets are not supported on this platform msgstr 这个平台不支持 UNIX 域插槽 s/插槽/套接字/,the 'domain' is translated as '域', it

Re: [libvirt] [PATCH] Fix virsh net-info output for consistency

2013-11-19 Thread Alex Jia
ACK. -- Regards, Alex - Original Message - From: h...@redhat.com To: libvir-list@redhat.com Sent: Tuesday, November 19, 2013 2:20:57 PM Subject: [libvirt] [PATCH] Fix virsh net-info output for consistency From: Hao Liu h...@redhat.com All *-info virsh commands output a list of

Re: [libvirt] [libvirt-test-API][PATCH] npiv: Add basic NPIV test case

2013-10-22 Thread Alex Jia
On 10/22/2013 12:28 PM, jmiao wrote: The original NPIV test function create_virtual_hba doesn't check the validation of fabric_wwn, this patch modify create_virtual_hba to check fabric_wwn whether is invalid (0x). Is it always right for different vendor's HBAs? IMHO, you may check

Re: [libvirt] rpmbuild libvirt 1.1.2 problem

2013-09-13 Thread Alex Jia
Hi Martin, BTW, I met the same question, and I ran 'make check' under root. -- Regards, Alex - Original Message - From: Martin Kletzander mklet...@redhat.com To: Nehal J Wani nehaljw.k...@gmail.com Cc: libvir-list libvir-list@redhat.com, jsjshaowen...@21cn.com Sent: Thursday,

[libvirt] [PATCH] tools: add missing 'interface' type and update man page

2013-09-10 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- tools/virt-xml-validate.in | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/tools/virt-xml-validate.in b/tools/virt-xml-validate.in index 6bfa68f..8be9595 100644 --- a/tools/virt-xml-validate.in +++ b/tools

Re: [libvirt] [PATCH] Docs: fix a typo in virt-login-shell.pod

2013-09-05 Thread Alex Jia
Thanks and pushed now. -- Regards, Alex - Original Message - From: Peter Krempa pkre...@redhat.com To: Alex Jia a...@redhat.com Cc: libvir-list@redhat.com Sent: Tuesday, September 3, 2013 3:35:43 PM Subject: Re: [libvirt] [PATCH] Docs: fix a typo in virt-login-shell.pod On 09/03

[libvirt] [PATCH] Docs: fix a typo in virt-login-shell.pod

2013-09-02 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- tools/virt-login-shell.pod |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virt-login-shell.pod b/tools/virt-login-shell.pod index e27d500..bcd7855 100644 --- a/tools/virt-login-shell.pod +++ b/tools/virt-login-shell.pod

[libvirt] [PATCH] qemu: Add missing VIR_DOMAIN_BLOCK_COMMIT_DELETE flags

2013-08-27 Thread Alex Jia
The flag VIR_DOMAIN_BLOCK_COMMIT_DELETE is missed by qemuDomainBlockCommit(), and then will hit error unsupported flags (0x2) in function qemuDomainBlockCommit if users run 'virsh blockcommit' with '--delete' option. RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1001475 Signed-off-by: Alex

Re: [libvirt] [PATCH] qemu: Add missing VIR_DOMAIN_BLOCK_COMMIT_DELETE flags

2013-08-27 Thread Alex Jia
On 08/27/2013 04:47 PM, Peter Krempa wrote: On 08/27/13 09:53, Alex Jia wrote: The flag VIR_DOMAIN_BLOCK_COMMIT_DELETE is missed by qemuDomainBlockCommit(), and then will hit error unsupported flags (0x2) in function qemuDomainBlockCommit if users run 'virsh blockcommit' with '--delete' option

Re: [libvirt] [PATCH] qemu: Add missing VIR_DOMAIN_BLOCK_COMMIT_DELETE flags

2013-08-27 Thread Alex Jia
On 08/27/2013 07:59 PM, Eric Blake wrote: On 08/27/2013 03:37 AM, Michal Privoznik wrote: Yes, the codes haven't any implementation for BLOCK_COMMIT_DELETE flag now, maybe, only need to raise a friendly error message in here instead of unsupported flags (0x2) . I agree that this error

Re: [libvirt] [PATCH] virsh: fix return value error of cpu-stats

2013-08-26 Thread Alex Jia
On 08/26/2013 05:11 PM, Pavel Hrdina wrote: On 26.8.2013 07:11, Alex Jia wrote: On 08/23/2013 06:22 PM, Guannan Ren wrote: virsh cpu-stats guest --start 0 --count 3 It outputs right but the return value is 1 rather than 0 echo $? 1 It's ok with libvirt-0.10.2-23.el6.x86_64 on RHEL6.y

Re: [libvirt] [PATCH] util: Fix crash of libvirtd when running numatune with invalid nodeset

2013-08-18 Thread Alex Jia
On 08/16/2013 07:42 PM, Eric Blake wrote: On 08/16/2013 01:47 AM, Alex Jia wrote: This issue is introduced by commit 0fc8909, the virBitmapIsSet() needs caller to ensure 'b bitmap-max_bit', but it's lost in the virBitmapParse() caller, this will cause crash of libvirtd, with the patch

[libvirt] [PATCH] util: Fix crash of libvirtd when running numatune with invalid nodeset

2013-08-16 Thread Alex Jia
0x7f80f86bb70d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:115 RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=997367 Signed-off-by: Alex Jia a...@redhat.com --- The caller virBitmapGetBit() can make sure 'b bitmap-max_bit', so don't need to worry about higher caller

Re: [libvirt] [PATCH] virsh-domain: Fix memleak in cmdCPUBaseline

2013-08-16 Thread Alex Jia
ACK. -- Regards, Alex - Original Message - From: Peter Krempa pkre...@redhat.com To: libvir-list@redhat.com Cc: Peter Krempa pkre...@redhat.com Sent: Friday, August 16, 2013 4:38:59 PM Subject: [libvirt] [PATCH] virsh-domain: Fix memleak in cmdCPUBaseline

Re: [libvirt] [test-API][PATCH] Add display of cases result to log.xml

2013-08-15 Thread Alex Jia
Hi hongming, BTW, could we ignore module or function name in Test Procedure section, because the module and entry function are the same name, it's a deliberately design, but the Test Procedure looks like a duplicate naming for others. slice network:define:define

Re: [libvirt] [test-API][PATCH] Add display of cases result to log.xml

2013-08-15 Thread Alex Jia
Gren, I think it should be enough if we can know which test cases is run, and should hide some details such as checkpoint and clean function. -- Regards, Alex - Original Message - From: Guannan Ren g...@redhat.com To: Alex Jia a...@redhat.com Cc: hongming honzh...@redhat.com

Re: [libvirt] LXC: Helper function for checking ownership of dir when userns enabled

2013-08-09 Thread Alex Jia
On 08/09/2013 01:53 PM, Chen Hanxiao wrote: From: Chen Hanxiaochenhanx...@cn.fujitsu.com If we enable userns, the ownership of dir we provided for containers should match the uid/gid in idmap. Currently, the debug log is very implicit or misleading sometimes. This patch will help

Re: [libvirt] LXC: Helper function for checking ownership of dir when userns enabled

2013-08-09 Thread Alex Jia
On 08/09/2013 01:53 PM, Chen Hanxiao wrote: From: Chen Hanxiaochenhanx...@cn.fujitsu.com If we enable userns, the ownership of dir we provided for containers should match the uid/gid in idmap. Currently, the debug log is very implicit or misleading sometimes. This patch will help

[libvirt] [libvirt-sandbox][PATCH 0/2] Fix some issues in virt-sandbox-service

2013-08-09 Thread Alex Jia
Alex Jia (2): Fix logical judgement in get_name Raise clear error message if no legacy configuration bin/virt-sandbox-service | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) -- 1.8.3.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman

[libvirt] [libvirt-sandbox][PATCH 1/2] Fix logical judgement in get_name

2013-08-09 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- bin/virt-sandbox-service | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service index 03873c9..26b4a40 100755 --- a/bin/virt-sandbox-service +++ b/bin/virt-sandbox-service

[libvirt] [libvirt-sandbox][PATCH 2/2] Raise clear error message if no legacy configuration

2013-08-09 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- bin/virt-sandbox-service | 3 +++ 1 file changed, 3 insertions(+) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service index 26b4a40..cb40f6a 100755 --- a/bin/virt-sandbox-service +++ b/bin/virt-sandbox-service @@ -965,6 +965,9 @@ def

Re: [libvirt] [libvirt-sandbox][PATCH 2/2] Raise clear error message if no legacy configuration

2013-08-09 Thread Alex Jia
On 08/09/2013 06:30 PM, Daniel P. Berrange wrote: On Fri, Aug 09, 2013 at 06:26:47PM +0800, Alex Jia wrote: Signed-off-by: Alex Jiaa...@redhat.com --- bin/virt-sandbox-service | 3 +++ 1 file changed, 3 insertions(+) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service index

Re: [libvirt] [libvirt-sandbox][PATCH 1/2] Fix logical judgement in get_name

2013-08-09 Thread Alex Jia
On 08/09/2013 06:29 PM, Daniel P. Berrange wrote: On Fri, Aug 09, 2013 at 06:26:46PM +0800, Alex Jia wrote: Please explain the scenario where you hit the flaw in the commit message. I can see what you've changed, but I don't see why you have changed it. The commit message must describe the 'why

[libvirt] [libvirt-sandbox][PATCH v2] Fix logical judgement in get_name

2013-08-09 Thread Alex Jia
error. Signed-off-by: Alex Jia a...@redhat.com --- bin/virt-sandbox-service | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service index 03873c9..26b4a40 100755 --- a/bin/virt-sandbox-service +++ b/bin/virt-sandbox-service

Re: [libvirt] virDomainCreateWithFlags error

2013-08-08 Thread Alex Jia
On 08/08/2013 01:54 PM, Wangpan wrote: Hi all, I'm using 'libvirt 1.1.1-1 amd64' undef debian wheezy, I found that the return code is 139 when I run command: $ sudo virsh start df1c4670-18eb-4520-b5d8-aa8a492eb876 --paused; echo $? Thanks for reporting this issue, it's a libvirt's bug and

[libvirt] [PATCH] remote: Fix a segfault in remoteDomainCreateWithFlags

2013-08-08 Thread Alex Jia
?id=994855 Signed-off-by: Alex Jia a...@redhat.com --- src/remote/remote_driver.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index f828eef..71d0034 100644 --- a/src/remote/remote_driver.c +++ b/src/remote

Re: [libvirt] virDomainCreateWithFlags error

2013-08-08 Thread Alex Jia
- From: Alex Jia a...@redhat.com To: Wangpan hzwang...@corp.netease.com Cc: libvir-list libvir-list@redhat.com Sent: Thursday, August 8, 2013 2:30:09 PM Subject: Re: [libvirt] virDomainCreateWithFlags error On 08/08/2013 01:54 PM, Wangpan wrote: Hi all, I'm using 'libvirt 1.1.1-1 amd64' undef

Re: [libvirt] [sandbox][PATCH v3] Fix delete of running container

2013-08-08 Thread Alex Jia
On 08/08/2013 03:42 PM, Wayne Sun wrote: Delete running container is not supprted and will report an error. Related to bug: https://bugzilla.redhat.com/show_bug.cgi?id=994495 v1: Fix stop function and delete running container. v2: Delete running container is not allowed, spawn virsh to get

Re: [libvirt] [sandbox][PATCH v3] Fix delete of running container

2013-08-08 Thread Alex Jia
On 08/08/2013 06:42 PM, Daniel P. Berrange wrote: On Thu, Aug 08, 2013 at 03:42:28PM +0800, Wayne Sun wrote: Delete running container is not supprted and will report an error. Related to bug: https://bugzilla.redhat.com/show_bug.cgi?id=994495 v1: Fix stop function and delete running

Re: [libvirt] [PATCH] remote: Fix a segfault in remoteDomainCreateWithFlags

2013-08-08 Thread Alex Jia
Hi Martin, I think if the call() can't do this then it's impossible to de-duplicate in all similar functions. -- Regards, Alex - Original Message - From: Martin Kletzander mklet...@redhat.com To: Alex Jia a...@redhat.com Cc: libvir-list@redhat.com Sent: Thursday, August 8, 2013 8

Re: [libvirt] [PATCH] remote: Fix a segfault in remoteDomainCreateWithFlags

2013-08-08 Thread Alex Jia
Martin, I pushed this now. -- Regards, Alex - Original Message - From: Martin Kletzander mklet...@redhat.com To: Alex Jia a...@redhat.com Cc: libvir-list@redhat.com Sent: Thursday, August 8, 2013 8:09:57 PM Subject: Re: [libvirt] [PATCH] remote: Fix a segfault

Re: [libvirt] [libvirt-sandbox][PATCH] Update man page about virt-sandbox-service

2013-08-07 Thread Alex Jia
On 08/08/2013 10:42 AM, Zhe Peng wrote: Add upgrade and remove start,stop,list --- bin/virt-sandbox-service.pod |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/bin/virt-sandbox-service.pod b/bin/virt-sandbox-service.pod index 32caad9..e8ab55e 100644 ---

Re: [libvirt] [libvirt-sandbox][PATCH v2] Update man page about virt-sandbox-service

2013-08-07 Thread Alex Jia
On 08/08/2013 11:31 AM, Zhe Peng wrote: Add upgrade and remove start,stop,list ACK and pushed with comment update Remove obsolete 'list', 'start', 'stop' commands and add new 'upgrade' command. --- bin/virt-sandbox-service.pod |6 -- 1 files changed, 4 insertions(+), 2

[libvirt] [PATCH] conf:Fix a copy paste error

2013-07-26 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 10cb7f6..0e74039 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5153,7 +5153,7

Re: [libvirt] [sandbox][PATCH] Docs: remove duplicate -u item in create man page

2013-07-18 Thread Alex Jia
ACK. -- Regards, Alex - Original Message - From: Wayne Sun g...@redhat.com To: libvir-list@redhat.com Sent: Thursday, July 18, 2013 3:24:30 PM Subject: [libvirt] [sandbox][PATCH] Docs: remove duplicate -u item in create man page This related to bug:

[libvirt] [libvirt-sandbox][PATCH] Docs: update EXAMPLES section of virt-sandbox man page

2013-07-18 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- bin/virt-sandbox.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c index 883e6c0..b51465d 100644 --- a/bin/virt-sandbox.c +++ b/bin/virt-sandbox.c @@ -438,7 +438,9 @@ Run an interactive

Re: [libvirt] [sandbox][PATCH] Docs: remove duplicate -u item in create man page

2013-07-18 Thread Alex Jia
Pushed this under the trivial rule. -- Regards, Alex - Original Message - From: Alex Jia a...@redhat.com To: Wayne Sun g...@redhat.com Cc: libvir-list@redhat.com Sent: Thursday, July 18, 2013 3:49:58 PM Subject: Re: [libvirt] [sandbox][PATCH] Docs: remove duplicate -u item

Re: [libvirt] [libvirt-sandbox][PATCH] Docs: update EXAMPLES section of virt-sandbox man page

2013-07-18 Thread Alex Jia
Thanks and pushed now. -- Regards, Alex - Original Message - From: Daniel P. Berrange berra...@redhat.com To: Alex Jia a...@redhat.com Cc: libvir-list@redhat.com Sent: Thursday, July 18, 2013 5:24:14 PM Subject: Re: [libvirt] [libvirt-sandbox][PATCH] Docs: update EXAMPLES section

[libvirt] [PATCH] qemu: Prevent crash of libvirtd without guest agent configuration

2013-07-16 Thread Alex Jia
while reading data: Input/output error error: One or more references were leaked after disconnect from the hypervisor error: Failed to reconnect to the hypervisor RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=984821 Signed-off-by: Alex Jia a...@redhat.com --- src/qemu/qemu_driver.c | 12

Re: [libvirt] [PATCH] qemu: Prevent crash of libvirtd without guest agent configuration

2013-07-16 Thread Alex Jia
On 07/16/2013 04:35 PM, Peter Krempa wrote: On 07/16/13 08:31, Alex Jia wrote: If users haven't configured guest agent then qemuAgentCommand() will dereference a NULL 'mon' pointer, which causes crash of libvirtd. uhh, right :/ I broke that :/ GDB backtrace: (gdb) bt #0

[libvirt] [PATCH v2] qemu: Prevent crash of libvirtd without guest agent configuration

2013-07-16 Thread Alex Jia
of file while reading data: Input/output error error: One or more references were leaked after disconnect from the hypervisor error: Failed to reconnect to the hypervisor RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=984821 Signed-off-by: Alex Jia a...@redhat.com --- src/qemu/qemu_driver.c

Re: [libvirt] attach-device error: XML error: unknown device type

2013-07-04 Thread Alex Jia
On 07/04/2013 02:34 AM, Chris Evich wrote: On 07/03/2013 09:46 AM, Daniel P. Berrange wrote: On Wed, Jul 03, 2013 at 09:44:46AM -0400, Chris Evich wrote: Hi, On Fedora 18 (libvirt 0.10.2.6-1) I'm trying to add a new serial device to a KVM VM with: virsh attach-device foobar /tmp/serial.xml

Re: [libvirt] [sandbox][PATCH] Fix nits in virt-sandbox-service when raise ValueError

2013-05-28 Thread Alex Jia
On 05/28/2013 02:01 PM, Wayne Sun wrote: Put error msg in list when raise ValueError. This fix is for bug: [virt-sandbox-service] execute command with unsupported URI error msg is not right https://bugzilla.redhat.com/show_bug.cgi?id=967705 Signed-off-by: Wayne Sung...@redhat.com ---

[libvirt] [libvirt-sandbox][PATCH] Add missing get_unit_path function into class Container

2013-05-24 Thread Alex Jia
RHBZ:https://bugzilla.redhat.com/show_bug.cgi?id=966307 Signed-off-by: Alex Jia a...@redhat.com --- With the patch, we can successfully clone an existing Secure container, but I met a Warning, I think it may be a LibvirtGObject question, # virt-sandbox-service clone http1 clonebox Created

Re: [libvirt] [libvirt-perl][PATCH] Fix typo in domain help page

2013-05-20 Thread Alex Jia
ACK. -- Regards, Alex - Original Message - From: Zhe Peng zp...@redhat.com To: libvir-list@redhat.com Sent: Tuesday, May 21, 2013 10:46:03 AM Subject: [libvirt] [libvirt-perl][PATCH] Fix typo in domain help page The help page of $dom-set_metadata have a typo,this patch fix it.

Re: [libvirt] [PATCH] util: Prevent libvirtd crash from virPCIDeviceAddressIsEqual()

2013-05-02 Thread Alex Jia
On 04/29/2013 02:48 AM, Laine Stump wrote: On 04/28/2013 06:12 AM, Alex Jia wrote: GDB backtrace: Breakpoint 1, virPCIGetVirtualFunctionIndex (pf_sysfs_device_link=0x7fc04400f470 /sys/bus/pci/devices/:03:00.1, vf_sysfs_device_link=optimized out, vf_index=vf_index@entry=0x7fc06897b8f4

Re: [libvirt] [PATCH] util: Prevent libvirtd crash from virPCIDeviceAddressIsEqual()

2013-05-02 Thread Alex Jia
On 05/02/2013 11:30 PM, Laine Stump wrote: On 05/02/2013 02:06 AM, Alex Jia wrote: On 04/29/2013 02:48 AM, Laine Stump wrote: On 04/28/2013 06:12 AM, Alex Jia wrote: GDB backtrace: Breakpoint 1, virPCIGetVirtualFunctionIndex (pf_sysfs_device_link=0x7fc04400f470 /sys/bus/pci/devices/:03

[libvirt] [PATCH] util: Prevent libvirtd crash from virPCIDeviceAddressIsEqual()

2013-04-28 Thread Alex Jia
/virpci.c:1844 1844(bdf1-slot == bdf2-slot) (gdb) s Program received signal SIGSEGV, Segmentation fault. RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=957416 Signed-off-by: Alex Jia a...@redhat.com --- src/util/virpci.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions

[libvirt] [PATCH] sanlock: add missing test command in virt-sanlock-cleanup.in

2013-04-08 Thread Alex Jia
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=949483 Signed-off-by: Alex Jia a...@redhat.com --- In fact, the virt-sanlock-cleanup works well on RHEL6.4, but doesn't work on RHEL7.0, and got a error line 14: x: command not found, It may be different bash version issue. tools/virt-sanlock

Re: [libvirt] [PATCH] sanlock: add missing test command in virt-sanlock-cleanup.in

2013-04-08 Thread Alex Jia
On 04/09/2013 04:16 AM, Eric Blake wrote: On 04/08/2013 03:46 AM, Alex Jia wrote: RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=949483 Signed-off-by: Alex Jiaa...@redhat.com --- In fact, the virt-sanlock-cleanup works well on RHEL6.4, but doesn't work on RHEL7.0, and got a error line 14: x

[libvirt] [libvirt-sandbox][PATCH] Sync lxc-enter-namespace options with libvirt

2013-03-28 Thread Alex Jia
Do not change process security label Signed-off-by: Alex Jia a...@redhat.com --- bin/virt-sandbox-service|6 +++--- bin/virt-sandbox-service-bash-completion.sh |2 +- bin/virt-sandbox-service-execute.pod|2 +- 3 files changed, 5 insertions(+), 5 deletions

Re: [libvirt] [libvirt-sandbox][PATCH] Sync lxc-enter-namespace options with libvirt

2013-03-28 Thread Alex Jia
On 03/28/2013 05:31 PM, Daniel P. Berrange wrote: On Thu, Mar 28, 2013 at 04:48:31PM +0800, Alex Jia wrote: The option 'nolabel' has been changed by current libvirt upstream, it should be 'noseclabel' now, so need to sync the option change with libvirt. # ./tools/virsh -c lxc:/// lxc-enter

Re: [libvirt] [libvirt-sandbox][PATCH] Docs: update network options configuration

2013-03-27 Thread Alex Jia
On 03/27/2013 06:06 PM, Daniel P. Berrange wrote: On Mon, Mar 25, 2013 at 06:41:37PM +0800, Alex Jia wrote: Signed-off-by: Alex Jiaa...@redhat.com --- bin/virt-sandbox-service-create.pod |7 ++- bin/virt-sandbox.c |7 ++- 2 files changed, 12 insertions(+), 2

Re: [libvirt] [libvirt-sandbox][PATCH v2] Avoid segfault in gvir_sandbox_config_add_host_include_file

2013-03-27 Thread Alex Jia
On 03/27/2013 06:05 PM, Daniel P. Berrange wrote: On Mon, Mar 25, 2013 at 01:20:19PM +0800, Alex Jia wrote: RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=924574 Valgrind defects memory error: ==19297== Invalid free() / delete / delete[] / realloc() ==19297==at 0x4A077A6: free

[libvirt] [libvirt-sandbox][PATCH] Docs: update network options configuration

2013-03-25 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- bin/virt-sandbox-service-create.pod |7 ++- bin/virt-sandbox.c |7 ++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/bin/virt-sandbox-service-create.pod b/bin/virt-sandbox-service-create.pod index

Re: [libvirt] [libvirt-sandbox][PATCH] Avoid segfault in gvir_sandbox_config_add_host_include_file

2013-03-24 Thread Alex Jia
On 03/22/2013 06:45 PM, Daniel P. Berrange wrote: On Fri, Mar 22, 2013 at 05:38:23PM +0800, Alex Jia wrote: RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=924574 Valgrind defects memory error: ==19297== Invalid free() / delete / delete[] / realloc() ==19297==at 0x4A077A6: free

[libvirt] [libvirt-sandbox][PATCH v2] Avoid segfault in gvir_sandbox_config_add_host_include_file

2013-03-24 Thread Alex Jia
-by: Alex Jia a...@redhat.com --- libvirt-sandbox/libvirt-sandbox-config.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/libvirt-sandbox/libvirt-sandbox-config.c b/libvirt-sandbox/libvirt-sandbox-config.c index fc852f5..a98f40b 100644 --- a/libvirt-sandbox/libvirt

[libvirt] [libvirt-sandbox][PATCH] Avoid segfault in gvir_sandbox_config_add_host_include_file

2013-03-22 Thread Alex Jia
-by: Alex Jia a...@redhat.com --- libvirt-sandbox/libvirt-sandbox-config.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libvirt-sandbox/libvirt-sandbox-config.c b/libvirt-sandbox/libvirt-sandbox-config.c index 665a9fb..135eef1 100644 --- a/libvirt-sandbox/libvirt

[libvirt] [libvirt-sandbox][PATCH] Add missing break statements

2013-03-18 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- libvirt-sandbox/libvirt-sandbox-init-qemu.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/libvirt-sandbox/libvirt-sandbox-init-qemu.c b/libvirt-sandbox/libvirt-sandbox-init-qemu.c index 38ed284..dfa1374 100644

[libvirt] [libvirt-sandbox][PATCH] Docs: fix a typo in help documents

2013-03-18 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- bin/virt-sandbox.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c index bd7ac49..654a205 100644 --- a/bin/virt-sandbox.c +++ b/bin/virt-sandbox.c @@ -87,10 +87,10 @@ int main(int argc

Re: [libvirt] [libvirt-sandbox][PATCH] Docs: fix a typo in help documents

2013-03-18 Thread Alex Jia
On 03/18/2013 05:45 PM, Osier Yang wrote: On 2013年03月18日 17:39, Alex Jia wrote: Signed-off-by: Alex Jiaa...@redhat.com --- bin/virt-sandbox.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c index bd7ac49..654a205 100644

Re: [libvirt] [libvirt-sandbox][PATCH] Add missing break statements

2013-03-18 Thread Alex Jia
On 03/18/2013 05:51 PM, Osier Yang wrote: On 2013年03月18日 15:10, Alex Jia wrote: Signed-off-by: Alex Jiaa...@redhat.com --- libvirt-sandbox/libvirt-sandbox-init-qemu.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/libvirt-sandbox/libvirt-sandbox-init-qemu.c b

Re: [libvirt] [libvirt-sandbox][PATCHv2] Docs: fix a typo in help documents

2013-03-18 Thread Alex Jia
On 03/18/2013 06:02 PM, Osier Yang wrote: On 2013年03月18日 18:00, Alex Jia wrote: Signed-off-by: Alex Jiaa...@redhat.com --- bin/virt-sandbox.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c index bd7ac49..257d6c2 100644

Re: [libvirt] [libvirt-sandbox][PATCH v2] Docs: Fix security options wrongs in man page

2013-03-17 Thread Alex Jia
On 03/15/2013 07:29 PM, Daniel P. Berrange wrote: On Fri, Mar 15, 2013 at 06:57:15PM +0800, Alex Jia wrote: Signed-off-by: Alex Jiaa...@redhat.com --- bin/virt-sandbox.c | 17 + 1 files changed, 13 insertions(+), 4 deletions(-) ACK Daniel Thanks and push now

[libvirt] [libvirt-sandbox][PATCH] Docs: fix typos in IPv6 address

2013-03-15 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- bin/virt-sandbox.c |2 +- libvirt-sandbox/libvirt-sandbox-config.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c index 9becd07..69d1e62 100644 --- a/bin/virt

Re: [libvirt] [libvirt-sandbox][PATCH] Docs: fix typos in IPv6 address

2013-03-15 Thread Alex Jia
On 03/15/2013 04:02 PM, Osier Yang wrote: On 2013年03月15日 15:23, Alex Jia wrote: Signed-off-by: Alex Jiaa...@redhat.com --- bin/virt-sandbox.c |2 +- libvirt-sandbox/libvirt-sandbox-config.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[libvirt] [libvirt-sandbox][PATCH] Avoid infinite loop in gvir_sandbox_config_set_security_opts()

2013-03-15 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- libvirt-sandbox/libvirt-sandbox-config.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/libvirt-sandbox/libvirt-sandbox-config.c b/libvirt-sandbox/libvirt-sandbox-config.c index 90217f1..f96d417 100644 --- a/libvirt-sandbox

Re: [libvirt] [libvirt-sandbox][PATCH] Avoid infinite loop in gvir_sandbox_config_set_security_opts()

2013-03-15 Thread Alex Jia
On 03/15/2013 05:44 PM, Daniel P. Berrange wrote: On Fri, Mar 15, 2013 at 05:32:24PM +0800, Alex Jia wrote: Signed-off-by: Alex Jiaa...@redhat.com --- libvirt-sandbox/libvirt-sandbox-config.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/libvirt-sandbox/libvirt

Re: [libvirt] [libvirt-sandbox][PATCH v2] Avoid infinite loop in gvir_sandbox_config_set_security_opts()

2013-03-15 Thread Alex Jia
On 03/15/2013 05:52 PM, Daniel P. Berrange wrote: On Fri, Mar 15, 2013 at 05:50:32PM +0800, Alex Jia wrote: Signed-off-by: Alex Jiaa...@redhat.com --- libvirt-sandbox/libvirt-sandbox-config.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/libvirt-sandbox/libvirt

[libvirt] [libvirt-sandbox][PATCH v2] Avoid infinite loop in gvir_sandbox_config_set_security_opts()

2013-03-15 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- libvirt-sandbox/libvirt-sandbox-config.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/libvirt-sandbox/libvirt-sandbox-config.c b/libvirt-sandbox/libvirt-sandbox-config.c index 90217f1..08d21b9 100644 --- a/libvirt-sandbox

[libvirt] [libvirt-sandbox][PATCH] Docs: Fix security options wrongs in man page

2013-03-15 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- bin/virt-sandbox.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c index 69d1e62..66676c3 100644 --- a/bin/virt-sandbox.c +++ b/bin/virt-sandbox.c @@ -372,13 +372,19

Re: [libvirt] [libvirt-sandbox][PATCH] Docs: Fix security options wrongs in man page

2013-03-15 Thread Alex Jia
On 03/15/2013 06:42 PM, Daniel P. Berrange wrote: Dynamically allocate an SELinux label, using the base context USER:ROLE:TYPE:LEVEL, instead of the default base context. Thanks for your nice comment, the v2 patch is coming. -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [libvirt-sandbox][PATCH v2] Docs: Fix security options wrongs in man page

2013-03-15 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- bin/virt-sandbox.c | 17 + 1 files changed, 13 insertions(+), 4 deletions(-) diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c index 69d1e62..bd7ac49 100644 --- a/bin/virt-sandbox.c +++ b/bin/virt-sandbox.c @@ -372,13 +372,22

[libvirt] [libvirt-sandbox][PATCH] Fix copypaste error in autogen.sh

2013-03-14 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- autogen.sh |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/autogen.sh b/autogen.sh index 86cd496..4b760fa 100755 --- a/autogen.sh +++ b/autogen.sh @@ -12,7 +12,7 @@ DIE=0 (autoconf --version) /dev/null /dev/null 21

[libvirt] [libvirt-sandbox][PATCH] Avoid segfault if broadcast address is NULL

2013-03-14 Thread Alex Jia
. * How to reproduce? # virt-sandbox -c lxc:/// --network address=192.168.122.1 /bin/sh or # virt-sandbox -c lxc:/// --network address=192.168.122.1/24 /bin/sh Signed-off-by: Alex Jia a...@redhat.com --- libvirt-sandbox/libvirt-sandbox-config.c |8 1 files changed, 8 insertions

Re: [libvirt] [libvirt-sandbox][PATCH] Avoid segfault if broadcast address is NULL

2013-03-14 Thread Alex Jia
On 03/14/2013 07:16 PM, Daniel P. Berrange wrote: On Thu, Mar 14, 2013 at 07:00:43PM +0800, Alex Jia wrote: It seems the broadcast address parameter is not optional now, if users haven't specified the broadcast address to the network interface then a segfault will be raised. This patch is just

[libvirt] [libvirt-sandbox][PATCH] docs: correct libvirt sandbox command naming

2013-03-13 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- docs/testing.txt | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/testing.txt b/docs/testing.txt index 54106bb..13724b3 100644 --- a/docs/testing.txt +++ b/docs/testing.txt @@ -11,27 +11,27 @@ For all tests

[libvirt] [libvirt-sandbox][PATCH] docs: fix some typos in architecture.txt

2013-03-08 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- docs/architecture.txt | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/architecture.txt b/docs/architecture.txt index 16bffad..c227cbd 100644 --- a/docs/architecture.txt +++ b/docs/architecture.txt @@ -17,7

[libvirt] [libvirt-sandbox][PATCH] docs: fix some typos in TODO

2013-03-08 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- TODO |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/TODO b/TODO index 1ac37a0..fc63361 100644 --- a/TODO +++ b/TODO @@ -12,10 +12,10 @@ If we run a syslog within the container will it get messages from the outside

Re: [libvirt] Release of libvirt-1.0.0

2012-11-04 Thread Alex Jia
On 11/02/2012 07:13 PM, Daniel Veillard wrote: On Fri, Nov 02, 2012 at 06:30:50PM +0800, Alex Jia wrote: On 11/02/2012 01:13 PM, Daniel Veillard wrote: [...] improvements, but for a change I would like to point out the silent work of our translators communities, work being done

Re: [libvirt] Release of libvirt-1.0.0

2012-11-02 Thread Alex Jia
On 11/02/2012 01:13 PM, Daniel Veillard wrote: Well we just crossed that important milestone in the life of any project, so congratulation everybody the 1.0.0 release is out !!! For a bit of history, this is actually the 7th birthday of the project accounted from the first commit, on Nov

[libvirt] [PATCH] conf: avoid libvirt crash with empty address guestfwd channel

2012-09-13 Thread Alex Jia
://bugzilla.redhat.com/show_bug.cgi?id=856489 Signed-off-by: Alex Jia a...@redhat.com --- src/conf/domain_conf.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 2f8e5d2..02048c7 100644 --- a/src/conf/domain_conf.c +++ b/src/conf

Re: [libvirt] [PATCH] conf: avoid libvirt crash with empty address guestfwd channel

2012-09-13 Thread Alex Jia
- Original Message - From: Alex Jia a...@redhat.com To: libvir-list@redhat.com Cc: Alex Jia a...@redhat.com Sent: Friday, September 14, 2012 12:23:56 AM Subject: [libvirt][PATCH] conf: avoid libvirt crash with empty address guestfwd channel The 'def-target.addr' hasn't been initialized

Re: [libvirt] [PATCH] conf: avoid libvirt crash with empty address guestfwd channel

2012-09-13 Thread Alex Jia
Thanks and push now. -- Regards, Alex - Original Message - From: Eric Blake ebl...@redhat.com To: Alex Jia a...@redhat.com Cc: libvir-list@redhat.com Sent: Friday, September 14, 2012 12:38:39 AM Subject: Re: [libvirt] [PATCH] conf: avoid libvirt crash with empty address guestfwd

[libvirt] Can't successfully start libvirtd service

2012-09-12 Thread Alex Jia
Hi all, I compiled and installed libvirt from upstream, but I can't successfully start libvirtd service recently, for details, please see the following steps: # ./bootstrap ./configure --prefix=/usr make make install Notes, everything is okay. # service libvirtd restart Stopping libvirtd

Re: [libvirt] Can't successfully start libvirtd service

2012-09-12 Thread Alex Jia
, thanks a lot! -- Regards, Alex - Original Message - From: Alex Jia a...@redhat.com To: libvir libvir-list@redhat.com Sent: Wednesday, September 12, 2012 6:11:12 PM Subject: [libvirt] Can't successfully start libvirtd service Hi all, I compiled and installed libvirt from upstream

Re: [libvirt] [libvirt-perl PATCH v2] Virt.xs: fix flag issue on set_scheduler_parameters

2012-09-01 Thread Alex Jia
- Original Message - From: Daniel P. Berrange berra...@redhat.com To: Eric Blake ebl...@redhat.com Cc: Alex Jia a...@redhat.com, libvir-list@redhat.com Sent: Saturday, September 1, 2012 9:14:50 AM Subject: Re: [libvirt] [libvirt-perl PATCH v2] Virt.xs: fix flag issue

Re: [libvirt] [PATCH] Fix a crash when using Open vSwitch virtual ports

2012-08-30 Thread Alex Jia
On 08/30/2012 01:49 PM, Daniel Veillard wrote: Daniel, BTW, To test this patch again, it works for me :) On Wed, Aug 29, 2012 at 02:44:36PM -0400, Kyle Mestery wrote: Fixup buffer usage when handling VLANs. Also fix the logic used to determine if the virNetDevVlanPtr is valid or not. Fixes

Re: [libvirt] [perl-Sys-Virt][PATCH] Virt.xs: fix flag issue on set_scheduler_parameters

2012-08-29 Thread Alex Jia
On 08/29/2012 02:12 PM, Guannan Ren wrote: On 08/28/2012 11:38 AM, Alex Jia wrote: From: Alex Jia Alex Jia a...@redhat.com The default flags are inconsistent on both qemuSetSchedulerParameters() and qemuGetSchedulerParameters() in libvirt, the qemuGetSchedulerParameters() always passes

[libvirt] [libvirt-perl PATCH v2] Virt.xs: fix flag issue on set_scheduler_parameters

2012-08-29 Thread Alex Jia
From: Alex Jia Alex Jia a...@redhat.com The default flags are inconsistent on both qemuSetSchedulerParameters() and qemuGetSchedulerParameters() in libvirt, the qemuGetSchedulerParameters() always passes 'VIR_DOMAIN_AFFECT_CURRENT' flag to the qemuGetSchedulerParametersFlags(), it should

[libvirt] [PATCH] security: remove dead code from virSecurityDACGenLabel

2012-08-29 Thread Alex Jia
* src/security/security_dac.c: remove useless dead code. Signed-off-by: Alex Jia a...@redhat.com --- src/security/security_dac.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index 5de7391..211fb37 100644

Re: [libvirt] [PATCH] security: remove dead code from virSecurityDACGenLabel

2012-08-29 Thread Alex Jia
On 08/29/2012 06:23 PM, Peter Krempa wrote: Gah, I fixed the patch that made dead code from the break; statement on a different machine. ACK. Got it :) push now. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] util: Prevent libvirtd crash

2012-08-29 Thread Alex Jia
On 08/29/2012 06:45 PM, Laine Stump wrote: On 08/28/2012 07:28 AM, Alex Jia wrote: * src/util/virnetdevopenvswitch.c (virNetDevOpenvswitchAddPort): avoid libvirtd crash due to derefing a NULL virtVlan-tag. RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=852383 Signed-off-by: Alex Jiaa

Re: [libvirt] [PATCH] network: get vlan info for Open vSwitch interfaces from proper source

2012-08-29 Thread Alex Jia
On 08/29/2012 06:43 PM, Laine Stump wrote: This bug was revealed by the crash described in https://bugzilla.redhat.com/show_bug.cgi?id=852383 The vlan info pointer sent to virNetDevOpenvswitchAddPort should never be non-NULL unless there is at least one tag. The factthat such a vlan info

Re: [libvirt] [PATCH] Fix a crash when using Open vSwitch virtual ports

2012-08-29 Thread Alex Jia
On 08/30/2012 02:44 AM, Kyle Mestery wrote: Fixup buffer usage when handling VLANs. Also fix the logic used to determine if the virNetDevVlanPtr is valid or not. Fixes crashes in the latest code when using Open vSwitch virtualports. Hi Kyle, I just waive my patch then apply Laine and your

[libvirt] [PATCH] util: Prevent libvirtd crash

2012-08-28 Thread Alex Jia
* src/util/virnetdevopenvswitch.c (virNetDevOpenvswitchAddPort): avoid libvirtd crash due to derefing a NULL virtVlan-tag. RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=852383 Signed-off-by: Alex Jia a...@redhat.com --- src/util/virnetdevopenvswitch.c |3 ++- 1 files changed, 2

Re: [libvirt] [PATCH] util: Prevent libvirtd crash

2012-08-28 Thread Alex Jia
To: Alex Jia a...@redhat.com Cc: libvir-list@redhat.com Sent: Tuesday, August 28, 2012 11:25:02 PM Subject: Re: [libvirt] [PATCH] util: Prevent libvirtd crash On 08/28/2012 04:28 AM, Alex Jia wrote: * src/util/virnetdevopenvswitch.c (virNetDevOpenvswitchAddPort): avoid libvirtd crash due

Re: [libvirt] [libvirt-perl PATCH] Fix several APIs

2012-08-28 Thread Alex Jia
ACK. -- Regards, Alex - Original Message - From: Osier Yang jy...@redhat.com To: libvir-list@redhat.com Sent: Tuesday, August 28, 2012 11:52:24 PM Subject: [libvirt] [libvirt-perl PATCH] Fix several APIs These APIs accept one more argument (flags), which was ignored in the XS

  1   2   3   4   >