Re: [libvirt] [PATCH] Add support for qxl.revision in domain XML

2013-02-17 Thread Alon Levy
Hi Martin, On 02/04/2013 04:16 PM, Christophe Fergeau wrote: QXL devices have an associated 'revision' which is raised when new features have been introduced which would break migration to older versions. This commit makes it possible to set this revision as QEMU sometimes support newer

Re: [libvirt] [PATCH] qemu: Support ram bar size for qxl devices

2013-01-18 Thread Alon Levy
maybe you can solve it quicker for me then myself :) - Original Message - On 01/17/2013 12:35 PM, Alon Levy wrote: Adds a qxl-ram attribute globaly to the video.model element, that changes s/globaly/globally/ the resulting qemu command line only if video.type == qxl

Re: [libvirt] [PATCH] qemu: Support ram bar size for qxl devices

2013-01-18 Thread Alon Levy
On 01/17/2013 12:35 PM, Alon Levy wrote: Adds a qxl-ram attribute globaly to the video.model element, that changes s/globaly/globally/ check. the resulting qemu command line only if video.type == qxl. That attribute gets a default value of 64*1024 only if model.type is qxl

[libvirt] [PATCH v2] qemu: Support ram bar size for qxl devices

2013-01-18 Thread Alon Levy
Adds a ram attribute globally to the video.model element, that changes the resulting qemu command line only if video.type == qxl. video model type='qxl' ram='65536' vram='65536' heads='1'/ /video That attribute gets a default value of 64*1024. The schema is unchanged for other video element

[libvirt] [PATCH] qemu: Support ram bar size for qxl devices

2013-01-17 Thread Alon Levy
Adds a qxl-ram attribute globaly to the video.model element, that changes the resulting qemu command line only if video.type == qxl. That attribute gets a default value of 64*1024 only if model.type is qxl. In effect not changing any xml or argv for non qxl devices. For qxl devices a new

Re: [libvirt] [PATCH] qemu: Support ram bar size for qxl devices

2013-01-17 Thread Alon Levy
On Thu, Jan 17, 2013 at 09:35:22PM +0200, Alon Levy wrote: Adds a qxl-ram attribute globaly to the video.model element, that changes the resulting qemu command line only if video.type == qxl. That attribute gets a default value of 64*1024 only if model.type is qxl. In effect

Re: [libvirt] [PATCH] qemu: Support ram bar size for qxl devices

2013-01-17 Thread Alon Levy
On 17.01.2013 20:35, Alon Levy wrote: Adds a qxl-ram attribute globaly to the video.model element, that changes the resulting qemu command line only if video.type == qxl. That attribute gets a default value of 64*1024 only if model.type is qxl. In effect not changing any xml

Re: [libvirt] [PATCH] qemu: Support ram bar size for qxl devices

2013-01-17 Thread Alon Levy
On Thu, Jan 17, 2013 at 09:35:22PM +0200, Alon Levy wrote: Adds a qxl-ram attribute globaly to the video.model element, that changes the resulting qemu command line only if video.type == qxl. That attribute gets a default value of 64*1024 only if model.type is qxl. In effect

Re: [libvirt] [PATCH v2 1/3] qemu: refactor graphics code to not hardcode a single display

2012-11-12 Thread Alon Levy
[snip] I'd prefer if the refactoring of qemuBuildCommandLine was separated from removing the limit for number of graphics cards. But since I already reviewed the patch and I don't want to do that again, I'm giving a formal ACK to this version (with the small issues fixed, of course).

Re: [libvirt] [PATCH v2 2/3] qemu: graphics support for simultaneous one of each sdl, vnc, spice

2012-11-12 Thread Alon Levy
On Sat, Nov 10, 2012 at 15:20:24 +0100, Jiri Denemark wrote: On Sat, Nov 10, 2012 at 02:40:24 +0100, Alon Levy wrote: ACK with that removed. Actually, the ACK might have been a bit premature? What QEMU version is needed to support multiple graphics devices? And what happens if we try

Re: [libvirt] [PATCH 1/2 RESEND] qemu: refactor graphics code to not hardcode a single display

2012-11-09 Thread Alon Levy
hmm, I'm not using the enum everywhere, I'll send again after fixing (and use --patience). - Original Message - From: Alon Levy al...@redhat.com The check for a single display remains so no new functionality is added. --- No change to the patch itself, just the use

Re: [libvirt] [PATCH 1/2] qemu: refactor graphics code to not hardcode a single display

2012-11-09 Thread Alon Levy
On 11/08/2012 07:04 AM, Daniel P. Berrange wrote: On Thu, Nov 08, 2012 at 09:48:55AM +0100, Alon Levy wrote: The check for a single display remains so no new functionality is added. --- Concerning both patches, I've tested running with all three simultaneously (sdl+spice+vnc

[libvirt] [PATCH v2 2/3] qemu: graphics support for simultaneous one of each sdl, vnc, spice

2012-11-09 Thread Alon Levy
--- src/qemu/qemu_command.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index ba99c7a..a1a4523 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6183,9 +6183,26 @@

[libvirt] [PATCH v2 3/3] qemu/qemu_command.c: fix indent of label

2012-11-09 Thread Alon Levy
--- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index a1a4523..02a28b3 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -788,7 +788,7 @@ qemuAssignDeviceAliases(virDomainDefPtr

[libvirt] [PATCH v2 1/3] qemu: refactor graphics code to not hardcode a single display

2012-11-09 Thread Alon Levy
The check for a single display remains so no new functionality is added. --- v2 changes: removed enum, use virReportOOMError directly. use --patience added a one line label fix patch. The second patch changes a string that needs to be translated - how do I go about it?

[libvirt] [PATCH 2/2] qemu: graphics support for simultaneous one of each sdl, vnc, spice

2012-11-08 Thread Alon Levy
--- src/qemu/qemu_command.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index f9e4d4d..fcdf60c 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6186,9 +6186,26 @@

Re: [libvirt] [PATCH 1/2] qemu: refactor graphics code to not hardcode a single display

2012-11-08 Thread Alon Levy
On Thu, Nov 08, 2012 at 09:48:55AM +0100, Alon Levy wrote: The check for a single display remains so no new functionality is added. --- Concerning both patches, I've tested running with all three simultaneously (sdl+spice+vnc) and with spice+vnc, using a single qxl device

Re: [libvirt] [PATCH 1/2] domain_conf: add usbredir to list of valid spice channels

2012-05-08 Thread Alon Levy
On Mon, May 07, 2012 at 09:50:22AM -0600, Eric Blake wrote: On 05/07/2012 06:33 AM, Alon Levy wrote: Add usbredir channel to list of recognized spice channels. RHBZ: 819498 Signed-off-by: Alon Levy al...@redhat.com --- src/conf/domain_conf.c |3 ++- src/conf/domain_conf.h

Re: [libvirt] [PATCH 2/2] domain_conf: add default to list of valid spice channels

2012-05-08 Thread Alon Levy
On Mon, May 07, 2012 at 09:53:05AM -0600, Eric Blake wrote: On 05/07/2012 06:33 AM, Alon Levy wrote: qemu's behavior in this case is to change the spice server behavior to require secure connection to any channel not otherwise specified as being in plaintext mode. libvirt doesn't currently

[libvirt] [PATCH v2 2/2] domain_conf: add default to list of valid spice channels

2012-05-08 Thread Alon Levy
qemu's behavior in this case is to change the spice server behavior to require secure connection to any channel not otherwise specified as being in plaintext mode. libvirt doesn't currently allow requesting this (via plaintext-channel=channel name). RHBZ: 819499 Signed-off-by: Alon Levy al

[libvirt] [PATCH v2 1/2] domain_conf: add usbredir to list of valid spice channels

2012-05-08 Thread Alon Levy
Add usbredir channel to list of recognized spice channels. RHBZ: 819498 Signed-off-by: Alon Levy al...@redhat.com --- docs/formatdomain.html.in |5 +- docs/schemas/domaincommon.rng |1 + src/conf/domain_conf.c

[libvirt] [PATCH v3 1/2] domain_conf: add usbredir to list of valid spice channels

2012-05-08 Thread Alon Levy
Add usbredir channel to list of recognized spice channels. RHBZ: 819498 Signed-off-by: Alon Levy al...@redhat.com --- docs/formatdomain.html.in |5 +- docs/schemas/domaincommon.rng |1 + src/conf/domain_conf.c

[libvirt] [PATCH v3 2/2] domain_conf: add default to list of valid spice channels

2012-05-08 Thread Alon Levy
qemu's behavior in this case is to change the spice server behavior to require secure connection to any channel not otherwise specified as being in plaintext mode. libvirt doesn't currently allow requesting this (via plaintext-channel=channel name). RHBZ: 819499 Signed-off-by: Alon Levy al

[libvirt] [PATCH alt] tests/testutils: advertise VIR_TEST_VERBOSE and VIR_TEST_DEBUG if user attempts to get help

2012-05-08 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- tests/testutils.c |4 1 file changed, 4 insertions(+) diff --git a/tests/testutils.c b/tests/testutils.c index 4e8484f..ada676f 100644 --- a/tests/testutils.c +++ b/tests/testutils.c @@ -577,6 +577,10 @@ int virtTestMain(int argc

Re: [libvirt] [PATCH v3 2/2] domain_conf: add default to list of valid spice channels

2012-05-08 Thread Alon Levy
On Tue, May 08, 2012 at 12:19:45PM -0600, Eric Blake wrote: On 05/08/2012 11:42 AM, Alon Levy wrote: qemu's behavior in this case is to change the spice server behavior to require secure connection to any channel not otherwise specified as being in plaintext mode. libvirt doesn't currently

Re: [libvirt] [PATCH v3 2/2] domain_conf: add default to list of valid spice channels

2012-05-08 Thread Alon Levy
On Tue, May 08, 2012 at 10:10:34PM +0300, Alon Levy wrote: On Tue, May 08, 2012 at 12:19:45PM -0600, Eric Blake wrote: On 05/08/2012 11:42 AM, Alon Levy wrote: qemu's behavior in this case is to change the spice server behavior to require secure connection to any channel not otherwise

[libvirt] [PATCH 2/2] domain_conf: add default to list of valid spice channels

2012-05-07 Thread Alon Levy
qemu's behavior in this case is to change the spice server behavior to require secure connection to any channel not otherwise specified as being in plaintext mode. libvirt doesn't currently allow requesting this (via plaintext-channel=channel name). RHBZ: 819499 Signed-off-by: Alon Levy al

[libvirt] [PATCH 1/2] domain_conf: add usbredir to list of valid spice channels

2012-05-07 Thread Alon Levy
Add usbredir channel to list of recognized spice channels. RHBZ: 819498 Signed-off-by: Alon Levy al...@redhat.com --- src/conf/domain_conf.c |3 ++- src/conf/domain_conf.h |1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c

Re: [libvirt] [PATCH] Emit graphics events when a SPICE client connects/disconnects

2012-03-14 Thread Alon Levy
On Wed, Mar 14, 2012 at 05:06:48PM +0800, Osier Yang wrote: On 03/14/2012 01:45 PM, Laine Stump wrote: Wire up the domain graphics event notifications for SPICE. Adapted from a RHEL-only patch written by Dan Berrange that used custom __com.redhat_SPICE events - equivalent events are now

[libvirt] [PATCH] add screendump async to qemu

2012-03-06 Thread Alon Levy
at qemuProcessScreenshotComplete. For testing you need to apply the following patches (they are still pending review on qemu-devel): http://patchwork.ozlabs.org/patch/144706/ http://patchwork.ozlabs.org/patch/144705/ http://patchwork.ozlabs.org/patch/144704/ Signed-off-by: Alon Levy al...@redhat.com

[libvirt] [PATCH v2 wait-for-qemu] add screendump async to qemu

2012-03-06 Thread Alon Levy
at qemuProcessScreenshotComplete. For testing you need to apply the following patches (they are still pending review on qemu-devel): http://patchwork.ozlabs.org/patch/144706/ http://patchwork.ozlabs.org/patch/144705/ http://patchwork.ozlabs.org/patch/144704/ Signed-off-by: Alon Levy al...@redhat.com v2

[libvirt] [PATCH] src/datatypes.h: fix typo

2012-01-24 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- src/datatypes.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/datatypes.h b/src/datatypes.h index 91b1bfd..47058ed 100644 --- a/src/datatypes.h +++ b/src/datatypes.h @@ -31,7 +31,7 @@ * VIR_CONNECT_MAGIC

Re: [libvirt] [Qemu-devel] Guest Agent Summaries

2011-12-07 Thread Alon Levy
On Mon, Dec 05, 2011 at 03:36:59PM -0600, Michael Roth wrote: On 12/05/2011 01:21 PM, Chris Wright wrote: * Chris Wright (chr...@redhat.com) wrote: * Anthony Liguori (aligu...@us.ibm.com) wrote: 1. A short introduction to each of the guest agents, what guests they support, and what verbs they

Re: [libvirt] [PATCH v3 0/2] API to invoke S3/S4 on a host and also resume from within libvirt

2011-11-22 Thread Alon Levy
On Mon, Nov 21, 2011 at 05:26:55PM -0700, Eric Blake wrote: On 11/09/2011 05:05 AM, Srivatsa S. Bhat wrote: (This patch is positioned to go in after the patch that exports the host power management capabilities as XML, posted in [4]) I'm now reviewing that patch along with this series; if

Re: [libvirt] [libvirt-glib 2/3] Add some basic information to README

2011-11-15 Thread Alon Levy
On Tue, Nov 15, 2011 at 08:12:28PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- README | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/README b/README index e69de29..866ec53 100644 ---

Re: [libvirt] [PATCH] Add a systemtap script for watching QEMU monitor interactions

2011-10-24 Thread Alon Levy
On Mon, Oct 24, 2011 at 03:37:04PM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This change adds some systemtap/dtrace probes to the QEMU monitor client code. In particular it allows watching of all operations for a VM *

[libvirt] [PATCH] spice: support streaming-video parameter

2011-05-23 Thread Alon Levy
' streaming mode='off'/ /graphics Tested with the above and with tests/qemuxml2argvtest. Signed-off-by: Alon Levy al...@redhat.com --- Sorry for the resend, don't have the message id of my original message (now I'm registered to the list so won't happen again I hope). Michal

[libvirt] [PATCHv2] spice: support streaming-video parameter

2011-05-16 Thread Alon Levy
' streaming mode='off'/ /graphics Tested with the above and with tests/qemuxml2argvtest. Signed-off-by: Alon Levy al...@redhat.com --- Fixed: error code for missing mode is now VIR_ERR_XML_ERROR, and added documentation. Note: I'm not registered to the list, so please cc me on reply

[libvirt] [PATCH] spice: support streaming-video parameter

2011-05-03 Thread Alon Levy
' streaming mode='off'/ /graphics Tested with the above and with tests/qemuxml2argvtest. Signed-off-by: Alon Levy al...@redhat.com bla --- docs/schemas/domain.rng| 12 src/conf/domain_conf.c | 30

Re: [libvirt] [Qemu-devel] [PATCH 00/16] usb-ccid (v18)

2011-02-07 Thread Alon Levy
On Mon, Feb 07, 2011 at 08:56:30AM -0700, Eric Blake wrote: [adding libvir-list as well] On 02/07/2011 08:44 AM, Alon Levy wrote: I guess I'll wait a little longer for more feedback? Should I split the enum property separately? it's only used by ccid-card-emualted atm. The only non

[libvirt] [PATCH] docs/index.html.in: update QEMU url

2011-02-03 Thread Alon Levy
--- docs/index.html.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/index.html.in b/docs/index.html.in index 501f3e3..30cc9d7 100644 --- a/docs/index.html.in +++ b/docs/index.html.in @@ -38,7 +38,7 @@ on Linux and Solaris hosts. /li li -

Re: [libvirt] [PATCHv3 1/5] smartcard: add XML support for smartcard device

2011-01-31 Thread Alon Levy
On Mon, Jan 31, 2011 at 04:33:46PM -0700, Eric Blake wrote: On 01/26/2011 11:29 AM, Alon Levy wrote: yes, the db is a directory name, treated as normal (can be absolute or relative to cwd, I don't check, just feed it to NSS). From qemu's point of view, it can be relative; but how does

Re: [libvirt] [PATCHv3 1/5] smartcard: add XML support for smartcard device

2011-01-31 Thread Alon Levy
On Mon, Jan 31, 2011 at 04:40:06PM -0700, Eric Blake wrote: On 01/26/2011 11:29 AM, Alon Levy wrote: yes, the db is a directory name, treated as normal (can be absolute or relative to cwd, I don't check, just feed it to NSS). It defaults to /etc/pki/nssdb: Hmm; given Osier's recent

Re: [libvirt] [PATCHv3 0/5] smartcard: round 3

2011-01-26 Thread Alon Levy
On Wed, Jan 26, 2011 at 12:21:58PM +, Daniel P. Berrange wrote: On Wed, Jan 26, 2011 at 08:59:27AM +0200, Alon Levy wrote: On Tue, Jan 25, 2011 at 05:36:53PM -0700, Eric Blake wrote: This series has hopefully taken into account all the feedback from v2 (https://www.redhat.com/archives

Re: [libvirt] [PATCHv3 1/5] smartcard: add XML support for smartcard device

2011-01-26 Thread Alon Levy
On Wed, Jan 26, 2011 at 12:25:06PM +, Daniel P. Berrange wrote: On Tue, Jan 25, 2011 at 05:36:54PM -0700, Eric Blake wrote: +dl + dtcodemode='host'/code/dt + ddThe simplest operation, where the hypervisor relays all + requests from the guest into direct access to

Re: [libvirt] [PATCHv3 1/5] smartcard: add XML support for smartcard device

2011-01-26 Thread Alon Levy
On Wed, Jan 26, 2011 at 04:03:44PM +, Daniel P. Berrange wrote: On Wed, Jan 26, 2011 at 05:49:36PM +0200, Alon Levy wrote: On Wed, Jan 26, 2011 at 12:25:06PM +, Daniel P. Berrange wrote: On Tue, Jan 25, 2011 at 05:36:54PM -0700, Eric Blake wrote: +dl + dtcodemode

Re: [libvirt] [PATCHv3 1/5] smartcard: add XML support for smartcard device

2011-01-26 Thread Alon Levy
On Wed, Jan 26, 2011 at 11:20:50AM -0700, Eric Blake wrote: On 01/26/2011 11:09 AM, Alon Levy wrote: What does QEMU/NSS do with the certificate database ? Is it a readonly database, or does QEMU/NSS also write to this ? I'm wondering why we need to specify x509 certificates, as well

Re: [libvirt] [PATCHv3 0/5] smartcard: round 3

2011-01-25 Thread Alon Levy
On Tue, Jan 25, 2011 at 05:36:53PM -0700, Eric Blake wrote: This series has hopefully taken into account all the feedback from v2 (https://www.redhat.com/archives/libvir-list/2011-January/msg00608.html). Major changes: - enhance the XML to support optional ccid controller (missing

Re: [libvirt] [RFC PATCHv2 5/5] WIP: smartcard: turn on qemu support

2011-01-18 Thread Alon Levy
On Mon, Jan 17, 2011 at 01:12:28PM -0700, Eric Blake wrote: On 01/17/2011 11:42 AM, Alon Levy wrote: dev: ccid-card-emulated, id dev-prop: backend = nss-emulated dev-prop: cert1 = null dev-prop: cert2 = null

Re: [libvirt] [RFC PATCHv2 5/5] WIP: smartcard: turn on qemu support

2011-01-18 Thread Alon Levy
On Mon, Jan 17, 2011 at 01:12:28PM -0700, Eric Blake wrote: On 01/17/2011 11:42 AM, Alon Levy wrote: dev: ccid-card-emulated, id dev-prop: backend = nss-emulated dev-prop: cert1 = null dev-prop: cert2 = null

Re: [libvirt] [RFC PATCHv2 3/5] smartcard: add XML support for smartcard device

2011-01-17 Thread Alon Levy
On Mon, Jan 17, 2011 at 11:17:07AM +, Daniel P. Berrange wrote: On Sat, Jan 15, 2011 at 02:37:33PM +0200, Alon Levy wrote: On Fri, Jan 14, 2011 at 10:22:19AM -0700, Eric Blake wrote: On 01/14/2011 05:24 AM, Daniel P. Berrange wrote: On Thu, Jan 13, 2011 at 05:34:35PM -0700, Eric

Re: [libvirt] [RFC PATCHv2 5/5] WIP: smartcard: turn on qemu support

2011-01-17 Thread Alon Levy
On Mon, Jan 17, 2011 at 11:30:38AM -0700, Eric Blake wrote: On 01/15/2011 06:30 AM, Alon Levy wrote: In other words a hierarchy USB bus 0 | +- ccid0 | | | +- smartcard0 (ccid slot 0) | +- smartcard1 (ccid slot 3) | +- ccid1

Re: [libvirt] [RFC PATCHv2 3/5] smartcard: add XML support for smartcard device

2011-01-15 Thread Alon Levy
On Fri, Jan 14, 2011 at 10:22:19AM -0700, Eric Blake wrote: On 01/14/2011 05:24 AM, Daniel P. Berrange wrote: On Thu, Jan 13, 2011 at 05:34:35PM -0700, Eric Blake wrote: Assuming a hypervisor that supports multiple smartcard devices in the guest, this would be a valid XML description:

Re: [libvirt] [RFC PATCHv2 5/5] WIP: smartcard: turn on qemu support

2011-01-15 Thread Alon Levy
On Fri, Jan 14, 2011 at 07:23:17PM +, Daniel P. Berrange wrote: On Fri, Jan 14, 2011 at 11:25:36AM -0700, Eric Blake wrote: On 01/14/2011 05:41 AM, Daniel P. Berrange wrote: On Thu, Jan 13, 2011 at 05:34:37PM -0700, Eric Blake wrote: +virCommandAddArg(cmd, devstr);

Re: [libvirt] adding smartcard support to libvirt

2011-01-06 Thread Alon Levy
On Wed, Jan 05, 2011 at 12:25:58PM -0700, Eric Blake wrote: On 01/04/2011 02:17 AM, Alon Levy wrote: [focusing on the spicevmc chardev aspect] domain... devices smartcard mode='passthrough' name='xyz' serial type='spicevmc'/ /smartcard /devices /domain

Re: [libvirt] adding smartcard support to libvirt

2011-01-06 Thread Alon Levy
On Wed, Jan 05, 2011 at 02:55:55PM -0700, Eric Blake wrote: On 01/05/2011 02:09 PM, Alon Levy wrote: So, I'm thinking that this XML representation matches the spicevmc chardev: devices channel type='spicevmc'/ source port='5903' tlsPort='5904' autoport='no' listen='127.0.0.1

Re: [libvirt] adding smartcard support to libvirt

2011-01-04 Thread Alon Levy
/2010 03:00 AM, Alon Levy wrote: On Mon, Dec 20, 2010 at 12:19:42PM -0700, Eric Blake wrote: I also found the following which also served as a good overview for what you are proposing to add to qemu: http://cgit.freedesktop.org/~alon/qemu/commit/?h=usb_ccid.v9id=d5484a05 Of course, sorry